Re: [Mesa-dev] [PATCH 02/17] i965: enable component packing for vs and fs

On Thu, 2016-07-07 at 20:12 -0700, Jason Ekstrand wrote: > > On Jul 6, 2016 6:59 PM, "Timothy Arceri" m> wrote: > > > > --- > >  src/mesa/drivers/dri/i965/brw_fs.cpp     | 20 > >  src/mesa/drivers/dri/i965/brw_fs.h       |  5 +++-- > >  

Re: [Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

On Thu, 2016-07-07 at 20:12 -0700, Jason Ekstrand wrote: > > On Jul 7, 2016 7:47 PM, wrote: > > > > > > On Jul 7, 2016 9:59 AM, "Kenneth Graunke" > wrote: > > > > > > On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote: > > > > This will be used to store the

Re: [Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

On Jul 7, 2016 9:59 AM, "Kenneth Graunke" wrote: > > On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote: > > This will be used to store the total number of components used at this location > > when packing via ARB_enhanced_layouts. > > --- > >

Re: [Mesa-dev] [PATCH 02/17] i965: enable component packing for vs and fs

On Jul 6, 2016 6:59 PM, "Timothy Arceri" wrote: > > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 20 > src/mesa/drivers/dri/i965/brw_fs.h | 5 +++-- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 29 - > 3

Re: [Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

On Jul 7, 2016 7:47 PM, wrote: > > > On Jul 7, 2016 9:59 AM, "Kenneth Graunke" wrote: > > > > On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote: > > > This will be used to store the total number of components used at this location > > > when packing via

Re: [Mesa-dev] [PATCH 2/2] anv/dump: Fix post-blit memory barrier

Drp... Reviewed-by: Jason Ekstrand On Jul 7, 2016 4:06 PM, "Chad Versace" wrote: > Swap srcAccessMask and dstAccessMask. > --- > src/intel/vulkan/anv_dump.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 6/6] i965/fs: don't copy propagate if the instruction writes to more than two adjacent GRFs

Samuel Iglesias Gonsálvez writes: > This is not allowed by the HW and copy propagation can hide this issue to > lower_simd_width pass, which is going to fix it. > > Signed-off-by: Samuel Iglesias Gonsálvez > --- >

Re: [Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

Patches 7, 8, 10-13 & 15-17 are simple enough, Reviewed-by: Edward O'Callaghan I would perhaps suggest squashing 16+17 together, up to you. Kind Regards, Edward. On 07/08/2016 10:38 AM, Timothy Arceri wrote: > On Thu, 2016-07-07 at 17:50 +1000, Edward O'Callaghan

Re: [Mesa-dev] [PATCH 3/6] i965/fs/gen7: split instructions that run into exec masking bugs

Samuel Iglesias Gonsálvez writes: > From: Iago Toral Quiroga > > In fp64 we can produce code like this: > > mov(16) vgrf2<2>:UD, vgrf3<2>:UD > > That our simd lowering pass would typically split in instructions with a > width of 8, writing to two

[Mesa-dev] [PATCH 3/3] docs: Mark KHR_texture_compression_astc_sliced_3d done on i965

Signed-off-by: Anuj Phogat --- docs/GL3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/GL3.txt b/docs/GL3.txt index ce34869..883604a 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -255,6 +255,7 @@ GLES3.2, GLSL ES 3.2 GL_KHR_debug

[Mesa-dev] [PATCH 1/3] mesa: Add the infrastructure for KHR_texture_compression_astc_sliced_3d

Signed-off-by: Anuj Phogat --- src/mapi/glapi/registry/gl.xml | 1 + src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + src/mesa/main/teximage.c | 5 +++-- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] i965/gen9: Enable KHR_texture_compression_astc_sliced_3d

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 27dfb0c..c557137 100644 ---

Re: [Mesa-dev] [PATCH 7.5/11] glsl: Kill __intrinsic_atomic_sub

On 07/07/2016 06:34 PM, Ilia Mirkin wrote: > On Thu, Jul 7, 2016 at 9:26 PM, Ian Romanick wrote: >> On 07/07/2016 04:58 PM, Ilia Mirkin wrote: >>> On Thu, Jul 7, 2016 at 5:02 PM, Ian Romanick wrote: From: Ian Romanick

Re: [Mesa-dev] [PATCH 05/11] glsl: Replace the linear search in get_intrinsic_opcode with a radix trie

On 07/07/2016 04:03 PM, Dylan Baker wrote: > Quoting Ian Romanick (2016-07-05 17:46:13) >> From: Ian Romanick >> >> If there is a way to do this cleanly in mako, I'm very interested to >> hear about it. >> >>textdata bss dec hex filename >> 7529003

Re: [Mesa-dev] [PATCH 7.5/11] glsl: Kill __intrinsic_atomic_sub

On Thu, Jul 7, 2016 at 9:26 PM, Ian Romanick wrote: > On 07/07/2016 04:58 PM, Ilia Mirkin wrote: >> On Thu, Jul 7, 2016 at 5:02 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Just generate an __intrinsic_atomic_add

Re: [Mesa-dev] [PATCH 7.5/11] glsl: Kill __intrinsic_atomic_sub

On 07/07/2016 04:58 PM, Ilia Mirkin wrote: > On Thu, Jul 7, 2016 at 5:02 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Just generate an __intrinsic_atomic_add with a negated parameter. >> >> Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 1/4] glx: Call __glXInitVertexArrayState() with a usable gc.

On 07/07/2016 04:49 PM, Matt Turner wrote: > On Thu, Jul 7, 2016 at 2:34 PM, Ian Romanick wrote: >> On 07/07/2016 09:44 AM, Matt Turner wrote: >>> On Wed, Jun 29, 2016 at 2:16 PM, Ian Romanick wrote: On 06/29/2016 02:04 AM, Colin McDonald wrote:

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

On Wed, 2016-06-29 at 18:32 +0200, Marek Olšák wrote: > Hi, > > This series implements basic multithreaded LLVM shader compilation > in a minimally invasive way. (+51 lines of code in the main patch) > > It doesn't help on-demand shader compilation, but it does improve > loading and startup

Re: [Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

On Thu, 2016-07-07 at 17:50 +1000, Edward O'Callaghan wrote: > Hi, > > There is a typing issue in this patch in that, you are converting > ‘gl_linked_shader*’ to ‘gl_shader*’ for the first argument to > function > ‘void set_num_packed_components(gl_shader*, ir_variable_mode, > unsigned > int)’ at

[Mesa-dev] [Bug 96853] gl_PrimitiveID is zero when rendering points of size > 1

https://bugs.freedesktop.org/show_bug.cgi?id=96853 --- Comment #1 from Roland Scheidegger --- I think this would be a bug in the emulation code used for large points. Specifically, a gs is used to generate two tris out of a point, which means the prim id cannot be first used

Re: [Mesa-dev] [PATCH 05/11] glsl: Replace the linear search in get_intrinsic_opcode with a radix trie

On Thu, Jul 7, 2016 at 10:36 AM, Ian Romanick wrote: > On 07/07/2016 04:15 AM, Jason Ekstrand wrote: > > I can't help but think that we keep solving this problem... We have a > > low-collision hash table for vkGetProcAddress, something for > > glxGetProcAddress and

Re: [Mesa-dev] [PATCH 7.5/11] glsl: Kill __intrinsic_atomic_sub

On Thu, Jul 7, 2016 at 5:02 PM, Ian Romanick wrote: > From: Ian Romanick > > Just generate an __intrinsic_atomic_add with a negated parameter. > > Signed-off-by: Ian Romanick > --- >

Re: [Mesa-dev] [PATCH 1/4] glx: Call __glXInitVertexArrayState() with a usable gc.

On Thu, Jul 7, 2016 at 2:34 PM, Ian Romanick wrote: > On 07/07/2016 09:44 AM, Matt Turner wrote: >> On Wed, Jun 29, 2016 at 2:16 PM, Ian Romanick wrote: >>> On 06/29/2016 02:04 AM, Colin McDonald wrote: I'm not familiar with the code, other than

[Mesa-dev] [PATCH 1/2] anv/dump: Fix vkCmdPipelineBarrier flags

'true' is not valid for VkDependencyFlags. --- src/intel/vulkan/anv_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c index 1dc5079..49a5ae2 100644 --- a/src/intel/vulkan/anv_dump.c +++

[Mesa-dev] [PATCH 2/2] anv/dump: Fix post-blit memory barrier

Swap srcAccessMask and dstAccessMask. --- src/intel/vulkan/anv_dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c index 49a5ae2..4a5a44f 100644 --- a/src/intel/vulkan/anv_dump.c +++ b/src/intel/vulkan/anv_dump.c

Re: [Mesa-dev] [PATCH 5/5] anv/dump: Add support for dumping framebuffers

On Fri 17 Jun 2016, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_dump.c| 127 > + > src/intel/vulkan/anv_private.h | 10 +++ > src/intel/vulkan/genX_cmd_buffer.c | 4 ++ > 3 files changed, 141 insertions(+) This patch looks very helpful.

Re: [Mesa-dev] [PATCH 05/11] glsl: Replace the linear search in get_intrinsic_opcode with a radix trie

Quoting Ian Romanick (2016-07-05 17:46:13) > From: Ian Romanick > > If there is a way to do this cleanly in mako, I'm very interested to > hear about it. > >textdata bss dec hex filename > 7529003 273096 28584 7830683 777c9b

[Mesa-dev] [PATCH v2 1/5] swr: [rasterizer] add support for llvm-3.9

v2: use signed compare, remove unneeded vmask --- .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 38 -- .../jitter/scripts/gen_llvm_ir_macros.py | 5 --- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/5] swr: [rasterizer] add support for llvm-3.9

> On Jul 6, 2016, at 7:32 PM, Roland Scheidegger wrote: > > Am 06.07.2016 um 23:51 schrieb Tim Rowley: >> --- >> .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 38 >> -- >> .../jitter/scripts/gen_llvm_ir_macros.py | 5 --- >> 2 files

Re: [Mesa-dev] [PATCH 1/6] i965/fs: add a helper function to create double immediates

Samuel Iglesias Gonsálvez writes: > From: Iago Toral Quiroga > > Gen7 hardware does not support double immediates so these need > to be moved in 32-bit chunks to a regular vgrf instead. Instead > of doing this every time we need to create a DF immediate,

Re: [Mesa-dev] [PATCH 4/5] anv/dump: Add a barrier for the source image

On Fri 17 Jun 2016, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_dump.c | 22 ++ > 1 file changed, 22 insertions(+) Patch 4 is Reviewed-by: Chad Versace ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 3/5] anv/dump: Refactor the guts into helpers

On Fri 17 Jun 2016, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_dump.c | 224 > +++- > 1 file changed, 139 insertions(+), 85 deletions(-) > > diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c > index ffb892c..0fee93c 100644 >

Re: [Mesa-dev] [PATCH 5/6] i965/fs: do pack lowering before simd splitting

Samuel Iglesias Gonsálvez writes: > From: Iago Toral Quiroga > > So that we can have gen7 split large writes produced by the pack lowering. Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 10

Re: [Mesa-dev] [PATCH 4/4] radeonsi: disable multi-threading when shader dumps are enabled

With that typo in patch 1 fixed, the series is: Reviewed-by: Marek Olšák Marek On Thu, Jul 7, 2016 at 9:39 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Otherwise, shader dumps can become interleaved and unusable. > ---

Re: [Mesa-dev] [PATCH 3/4] radeonsi: use multi-threaded compilation in debug contexts

On Thu, Jul 7, 2016 at 9:39 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > We only have to stay single-threaded when debug output must be synchronous. > This yields better parallelism in shader-db runs for me. shader-db should already get the

Re: [Mesa-dev] [PATCH] mesa: Mark R*32F formats as filterable when an extension is present.

Reviewed-by: Ilia Mirkin On Thu, Jul 7, 2016 at 5:36 PM, Kenneth Graunke wrote: > GL_OES_texture_float_linear marks R32F, RG32F, RGB32F, and RGBA32F > as texture filterable. > > Fixes glGenerateMipmap GL errors when visiting a WebGL demo in Chromium:

Re: [Mesa-dev] [PATCH 4/6] i965/fs: do not require force_writemask_all with exec_size 4

Samuel Iglesias Gonsálvez writes: > So far we only used instructions with this size in situations where we > did not operate per-channel and we wanted to ignore the execution mask, > but gen7 fp64 will need to emit code with a width of 4 that needs > normal execution

[Mesa-dev] [PATCH] mesa: Mark R*32F formats as filterable when an extension is present.

GL_OES_texture_float_linear marks R32F, RG32F, RGB32F, and RGBA32F as texture filterable. Fixes glGenerateMipmap GL errors when visiting a WebGL demo in Chromium: http://www.iamnop.com/particles Cc: Matt Atwood Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 1/4] glx: Call __glXInitVertexArrayState() with a usable gc.

On 07/07/2016 09:44 AM, Matt Turner wrote: > On Wed, Jun 29, 2016 at 2:16 PM, Ian Romanick wrote: >> On 06/29/2016 02:04 AM, Colin McDonald wrote: >>> I'm not familiar with the code, other than diving in to fix these >>> indirect multi-texture problems, so you will know much

Re: [Mesa-dev] [PATCH 02/11] glsl: Replace big pile of hand-written code with a generator

Quoting Ian Romanick (2016-07-05 17:46:10) > From: Ian Romanick > > Right now the generator generates nearly identical code. There is no > change in the binary size. > >textdata bss dec hex filename > 7529283 273096 28584 7830963 777db3

[Mesa-dev] [Bug 96853] gl_PrimitiveID is zero when rendering points of size > 1

https://bugs.freedesktop.org/show_bug.cgi?id=96853 Bug ID: 96853 Summary: gl_PrimitiveID is zero when rendering points of size > 1 Product: Mesa Version: git Hardware: Other OS: Linux (All)

[Mesa-dev] [PATCH 7.5/11] glsl: Kill __intrinsic_atomic_sub

From: Ian Romanick Just generate an __intrinsic_atomic_add with a negated parameter. Signed-off-by: Ian Romanick --- src/compiler/glsl/builtin_functions.cpp| 50 +++--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |

Re: [Mesa-dev] [PATCH 00/11] ARB_shader_atomic_counter_ops for NIR and i965

This series (with the updates) is on my fd.o ARB_shader_atomic_counter_ops-i965 branch. On 07/05/2016 05:46 PM, Ian Romanick wrote: > The first 7 patches in this series put GLSL-to-NIR on a small diet. I > looked at the giant sequense of 'if (strcmp(...) == 0) { ... } else if > (strcmp(...) ==

Re: [Mesa-dev] [PATCH 2/5] anv/dump: Use anv_minify instead of hand-rolling it

Patches 1 and 2 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl: restrict swap_available dri2_egl_display field to X11

On Mon 20 Jun 2016, Frank Binns wrote: > This field is only ever set and read by the X11 platform. > > Signed-off-by: Frank Binns > --- > src/egl/drivers/dri2/egl_dri2.h | 2 +- > src/egl/drivers/dri2/platform_wayland.c | 2 -- > 2 files changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH] egl: Fix the bad surface attributes combination checking for pbuffers. (v2)

On Mon 20 Jun 2016, Guillaume Charifi wrote: > Fixes a regression induced by commit a0674ce5c41903ccd161e89abb149621bfbc40d2: > When EGL_TEXTURE_FORMAT and EGL_TEXTURE_TARGET were both specified (and > both != EGL_NO_TEXTURE), an error was instantly triggered, before the > other one had even a

Re: [Mesa-dev] [PATCH 3/3] radeonsi: catch a potential state tracker error with non-MSAA FBs

For the series: Reviewed-by: Marek Olšák Marek On Wed, Jul 6, 2016 at 6:07 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > At least st/mesa ensures this, so I'd rather not handle deviations in > radeonsi. > --- >

Re: [Mesa-dev] [PATCH mesa] egl/display: remove unnecessary code and make it easier to read

On Wed 06 Jul 2016, Eric Engestrom wrote: > Remove the two first level `if` as they will always be true, and > flatten the two remaining `if`. > No functional change. > > Signed-off-by: Eric Engestrom > --- > src/egl/main/egldisplay.c | 29

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Fri 01 Jul 2016, Chad Versace wrote: > On Thu 30 Jun 2016, Stéphane Marchesin wrote: > > On Thu, Jun 30, 2016 at 3:20 PM, Gurchetan Singh > > wrote: > > > There are a few places in the code where clearing and reading are done on > > > incorrect buffers for GLES

Re: [Mesa-dev] [PATCH 09/11] nir/intrinsics: Add more atomic_counter ops

On 07/07/2016 02:40 AM, Iago Toral wrote: > On Tue, 2016-07-05 at 17:46 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/compiler/glsl/glsl_to_nir.cpp | 43 >>

Re: [Mesa-dev] [PATCH 05/11] glsl: Replace the linear search in get_intrinsic_opcode with a radix trie

On 07/07/2016 04:15 AM, Jason Ekstrand wrote: > I can't help but think that we keep solving this problem... We have a > low-collision hash table for vkGetProcAddress, something for > glxGetProcAddress and eglGetProcAddress (hopefully the same?) and now > this. Can we pick a method, make it a

[Mesa-dev] [PATCH v2 17/24] i965: Use LZD to implement nir_op_find_lsb on Gen < 7

From: Ian Romanick v2: Rebase on changes to previous two patches. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22 +- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 26

[Mesa-dev] [PATCH v2 16/24] i965: Use LZD to implement nir_op_ifind_msb on Gen < 7

From: Ian Romanick v2: Retype LZD source as UD to avoid potential problems with 0x8000. Suggested by Matt. Also update comment about problem values with LZD(abs(x)). Suggested by Curro. Signed-off-by: Ian Romanick ---

Re: [Mesa-dev] [PATCH 4/4] st/omx/dec: make decoder video buffer progressive

Hi Emil, Have a look again, I think the logic is nothing wrong. reason In lines On 07/07/2016 11:39 AM, Emil Velikov wrote: On 6 July 2016 at 19:03, Leo Liu wrote: The idea of encode tunneling is to use video buffer directly for encoder, but currently the encoder doesn’t

[Mesa-dev] [PATCH v2 15/24] i965: Use LZD to implement nir_op_ufind_msb

From: Ian Romanick This uses one less instruction. v2: Move emit_find_msb_using_lzd out of the visitor classes. Suggested by Curro. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 3 +++

Re: [Mesa-dev] [PATCH] swrast: fix active attribs with atifragshader

On 06/26/2016 09:48 PM, Miklós Máté wrote: Only include the ones that can be used by the shader. This fixes texture coordinates, which were completely wrong, because WPOS was included in the list of attribs. It also increases performance noticeably. Signed-off-by: Miklós Máté

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

On Thu, Jul 7, 2016 at 7:01 PM, Connor Abbott wrote: > On Thu, Jul 7, 2016 at 12:57 PM, Erik Faye-Lund wrote: >> On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: >>> This was appearing in vc4 VS/CS in mupen64, due to vertex attrib

Re: [Mesa-dev] [PATCH 2/2] nir: Optimize away IF statements with no body on either side.

Eric Anholt writes: > Due to the rampant dead code elimination in coordinate shaders for vc4, we > often end up with IFs that do nothing on either side. In the > loops-enabled build, shader-db gives: > > total instructions in shared programs: 125192 -> 119693 (-4.39%) >

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

On Thu, Jul 7, 2016 at 12:57 PM, Erik Faye-Lund wrote: > On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: >> This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering >> producing some constants that were getting compared. >> >> total

Re: [Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote: > This will be used to store the total number of components used at this > location > when packing via ARB_enhanced_layouts. > --- > src/compiler/glsl/glsl_to_nir.cpp | 1 + > src/compiler/glsl/ir.h | 5 +++ >

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: > This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering > producing some constants that were getting compared. > > total instructions in shared programs: 112276 -> 112198 (-0.07%) > instructions in affected

Re: [Mesa-dev] [PATCH 1/4] glx: Call __glXInitVertexArrayState() with a usable gc.

On Wed, Jun 29, 2016 at 2:16 PM, Ian Romanick wrote: > On 06/29/2016 02:04 AM, Colin McDonald wrote: >> I'm not familiar with the code, other than diving in to fix these >> indirect multi-texture problems, so you will know much more about it >> than me. >> >> But, my

Re: [Mesa-dev] [PATCH 4/4] st/omx/dec: make decoder video buffer progressive

On 07/07/2016 11:39 AM, Emil Velikov wrote: On 6 July 2016 at 19:03, Leo Liu wrote: The idea of encode tunneling is to use video buffer directly for encoder, but currently the encoder doesn’t support interlaced surface, the OMX decoder set progressive surface before on that

Re: [Mesa-dev] [PATCH 4/4] st/omx/dec: make decoder video buffer progressive

On 07/07/2016 11:28 AM, Julien Isorce wrote: No encoder with nouveau driver so I cannot do a tunneling test but at least this does not break the decoder part so the 4 patches are: Tested-by: Julien Isorce > Thx! Thanks for that. Leo On

Re: [Mesa-dev] [PATCH] st/omx: fix crash when vid_enc_Constructor fails

On 07/07/2016 11:17 AM, Julien Isorce wrote: It happens when trying to use omxh264enc with nouveau driver because it does not provide any encoder at the moment. It crashes on enc_ReleaseTasks(>free_tasks) because at this time the list is not initialized. So this patch make sure the lists are

Re: [Mesa-dev] [PATCH 4/4] st/omx/dec: make decoder video buffer progressive

On 6 July 2016 at 19:03, Leo Liu wrote: > The idea of encode tunneling is to use video buffer directly for encoder, > but currently the encoder doesn’t support interlaced surface, the OMX > decoder set progressive surface before on that purpose. > > Since now we are polling the

Re: [Mesa-dev] [PATCH] st/omx: fix crash when vid_enc_Constructor fails

Hi Julien, On 7 July 2016 at 16:17, Julien Isorce wrote: > It happens when trying to use omxh264enc with nouveau driver > because it does not provide any encoder at the moment. > > It crashes on enc_ReleaseTasks(>free_tasks) because > at this time the list is not

Re: [Mesa-dev] [PATCH 4/4] st/omx/dec: make decoder video buffer progressive

No encoder with nouveau driver so I cannot do a tunneling test but at least this does not break the decoder part so the 4 patches are: Tested-by: Julien Isorce Thx! On 6 July 2016 at 19:03, Leo Liu wrote: > The idea of encode tunneling is to use video

[Mesa-dev] [PATCH] st/omx: fix crash when vid_enc_Constructor fails

It happens when trying to use omxh264enc with nouveau driver because it does not provide any encoder at the moment. It crashes on enc_ReleaseTasks(>free_tasks) because at this time the list is not initialized. So this patch make sure the lists are initialized. Another way to fix this would be to

Re: [Mesa-dev] mesa: don't install GLX files if GLX is not built

On 7 July 2016 at 15:14, Akihiko Odaki wrote: > Hi Emil, > > On 2016-07-07 19:11, Emil Velikov wrote: >> >> [Adding back mesa-dev] > > > Sorry, I mistakenly clicked "Reply" instead of "Reply All". > >> Hi Akihiko Odaki >> >> Before anything, let me say a couple

Re: [Mesa-dev] Mesa 12.0.0 release candidate 4

On 6 July 2016 at 20:37, Rob Clark wrote: > On Thu, Jun 23, 2016 at 9:35 AM, Emil Velikov > wrote: >> Hi all, >> >> On 21 June 2016 at 15:35, Emil Velikov wrote: >>> The fourth release candidate for Mesa 12.0.0 is now

Re: [Mesa-dev] Mesa 12.0.0 release candidate 4

On 6 July 2016 at 20:30, Jason Ekstrand wrote: > > > On Thu, Jun 23, 2016 at 6:35 AM, Emil Velikov > wrote: >> >> Hi all, >> >> On 21 June 2016 at 15:35, Emil Velikov wrote: >> > The fourth release candidate for Mesa

Re: [Mesa-dev] [PATCH 1/4] gallium: add async flag to pipe_debug_callback

On Thu, 2016-07-07 at 09:39 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- >  src/gallium/include/pipe/p_state.h   | 6 ++ >  src/gallium/state_trackers/clover/core/queue.cpp | 5 - >  src/mesa/state_tracker/st_debug.c| 5

Re: [Mesa-dev] mesa: don't install GLX files if GLX is not built

Hi Emil, On 2016-07-07 19:11, Emil Velikov wrote: [Adding back mesa-dev] Sorry, I mistakenly clicked "Reply" instead of "Reply All". Hi Akihiko Odaki Before anything, let me say a couple of things about DRI. The DRI interface is an abstraction layer where you have winsys (GLX/EGL/other)

Re: [Mesa-dev] [PATCH 2/4] radeon/uvd: move polaris fw check into radeon_video.c

Am 07.07.2016 um 15:33 schrieb Leo Liu: On 07/07/2016 05:57 AM, Christian König wrote: From: Christian König It's actually not very clever to claim to support H.264 and then fail to create a decoder. Signed-off-by: Christian König ---

Re: [Mesa-dev] [PATCH 1/4] radeon/video: fix coding style in radeon_video.c

Am 07.07.2016 um 15:51 schrieb Aaron Watry: On Thu, Jul 7, 2016 at 4:57 AM, Christian König > wrote: From: Christian König > Signed-off-by: Christian König

Re: [Mesa-dev] [PATCH 1/4] radeon/video: fix coding style in radeon_video.c

On Thu, Jul 7, 2016 at 4:57 AM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/drivers/radeon/radeon_video.c | 12 ++-- > 1 file changed, 6

Re: [Mesa-dev] [PATCH 2/4] radeon/uvd: move polaris fw check into radeon_video.c

On 07/07/2016 05:57 AM, Christian König wrote: From: Christian König It's actually not very clever to claim to support H.264 and then fail to create a decoder. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c

Re: [Mesa-dev] [PATCH 05/11] glsl: Replace the linear search in get_intrinsic_opcode with a radix trie

I can't help but think that we keep solving this problem... We have a low-collision hash table for vkGetProcAddress, something for glxGetProcAddress and eglGetProcAddress (hopefully the same?) and now this. Can we pick a method, make it a little Python helper, and use it everywhere? Not being

Re: [Mesa-dev] mesa: don't install GLX files if GLX is not built

[Adding back mesa-dev] Hi Akihiko Odaki Before anything, let me say a couple of things about DRI. The DRI interface is an abstraction layer where you have winsys (GLX/EGL/other) agnostic DRI module and different DRI loaders, each implementing different winsys' API. Thus DRI modules do/should not

Re: [Mesa-dev] [PATCH mesa] i965/blorp: fix indentation level

On Thu, Jul 07, 2016 at 08:36:35AM +0300, Pohjolainen, Topi wrote: > On Wed, Jul 06, 2016 at 10:02:42PM +0100, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > src/mesa/drivers/dri/i965/gen7_blorp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH 00/11] ARB_shader_atomic_counter_ops for NIR and i965

On Wed, 2016-07-06 at 09:36 +0200, Iago Toral wrote: > On Tue, 2016-07-05 at 17:46 -0700, Ian Romanick wrote: > > > > The first 7 patches in this series put GLSL-to-NIR on a small > > diet.  I > > looked at the giant sequense of 'if (strcmp(...) == 0) { ... } else > > if > > (strcmp(...) == 0) {

[Mesa-dev] [PATCH 1/4] radeon/video: fix coding style in radeon_video.c

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_video.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_video.c

[Mesa-dev] [PATCH 4/4] radeon/uvd: simplify sending context buffer message

From: Christian König Just send it whenever it is allocated. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 2/4] radeon/uvd: move polaris fw check into radeon_video.c

From: Christian König It's actually not very clever to claim to support H.264 and then fail to create a decoder. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 8

[Mesa-dev] [PATCH 3/4] radeon/uvd: fix contex buffer destruction in the error path

From: Christian König Destroying a not allocated buffer is harmless. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 09/11] nir/intrinsics: Add more atomic_counter ops

On Tue, 2016-07-05 at 17:46 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- >  src/compiler/glsl/glsl_to_nir.cpp  | 43 > +++--- >  src/compiler/glsl/nir_intrinsic_map.py 

Re: [Mesa-dev] [PATCH 09/11] nir/intrinsics: Add more atomic_counter ops

On Tue, 2016-07-05 at 17:46 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- >  src/compiler/glsl/glsl_to_nir.cpp  | 43 > +++--- >  src/compiler/glsl/nir_intrinsic_map.py 

Re: [Mesa-dev] [PATCH 2/6] i965/fs: use the new helper function to create double immediates

On Thursday, July 7, 2016 9:33:01 AM PDT Samuel Iglesias Gonsálvez wrote: > > On 06/07/16 22:32, Kenneth Graunke wrote: > > On Wednesday, July 6, 2016 12:09:58 PM PDT Samuel Iglesias Gonsálvez wrote: > >> From: Iago Toral Quiroga > >> > >> --- > >>

Re: [Mesa-dev] [PATCH 1/4] gallium: add async flag to pipe_debug_callback

On 07.07.2016 09:53, Edward O'Callaghan wrote: On 07/07/2016 05:39 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/include/pipe/p_state.h | 6 ++ src/gallium/state_trackers/clover/core/queue.cpp | 5 -

Re: [Mesa-dev] [PATCH 1/4] gallium: add async flag to pipe_debug_callback

On 07/07/2016 05:39 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/include/pipe/p_state.h | 6 ++ > src/gallium/state_trackers/clover/core/queue.cpp | 5 - > src/mesa/state_tracker/st_debug.c| 5 - > 3

Re: [Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

Hi, There is a typing issue in this patch in that, you are converting ‘gl_linked_shader*’ to ‘gl_shader*’ for the first argument to function ‘void set_num_packed_components(gl_shader*, ir_variable_mode, unsigned int)’ at the various call sites. Cheers, Edward. On 07/07/2016 11:58 AM, Timothy

[Mesa-dev] [PATCH 2/4] st/mesa: set debug callback async flag

From: Nicolai Hähnle --- src/mesa/state_tracker/st_context.c | 3 ++- src/mesa/state_tracker/st_debug.c | 6 -- src/mesa/state_tracker/st_debug.h | 2 +- src/mesa/state_tracker/st_manager.c | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] radeonsi: disable multi-threading when shader dumps are enabled

From: Nicolai Hähnle Otherwise, shader dumps can become interleaved and unusable. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH 3/4] radeonsi: use multi-threaded compilation in debug contexts

From: Nicolai Hähnle We only have to stay single-threaded when debug output must be synchronous. This yields better parallelism in shader-db runs for me. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH 1/4] gallium: add async flag to pipe_debug_callback

From: Nicolai Hähnle --- src/gallium/include/pipe/p_state.h | 6 ++ src/gallium/state_trackers/clover/core/queue.cpp | 5 - src/mesa/state_tracker/st_debug.c| 5 - 3 files changed, 14 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/6] i965/fs: use the new helper function to create double immediates

On 06/07/16 22:32, Kenneth Graunke wrote: > On Wednesday, July 6, 2016 12:09:58 PM PDT Samuel Iglesias Gonsálvez wrote: >> From: Iago Toral Quiroga >> >> --- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff

Re: [Mesa-dev] [PATCH] radeonsi: don't interleave R600_DEBUG-enabled shader dumps

On 07.07.2016 03:33, Tom Stellard wrote: On Wed, Jul 06, 2016 at 11:55:03PM +0200, Nicolai Hähnle wrote: From: Nicolai Hähnle Only setting R600_DEBUG doesn't set any debug callback. Conversely, the debug callback is only called when R600_DEBUG is set. I don't get

[Mesa-dev] [Bug 96410] [Perf] Pre validate _mesa_sampler_uniforms_pipeline_are_valid like _mesa_sampler_uniforms_are_valid

https://bugs.freedesktop.org/show_bug.cgi?id=96410 gregory.hain...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 96358] SSO: wrong interface validation between GS and VS (regresion due to latest gles 3.1)

https://bugs.freedesktop.org/show_bug.cgi?id=96358 Timothy Arceri changed: What|Removed |Added Status|ASSIGNED|RESOLVED

  1   2   >