Re: [Mesa-dev] [PATCH 4/4] i965/blorp: Make post draw flush more explicit

2017-01-18 Thread Pohjolainen, Topi
On Thu, Jan 19, 2017 at 09:25:19AM +0200, Pohjolainen, Topi wrote: > On Wed, Jan 18, 2017 at 01:54:43PM -0800, Jason Ekstrand wrote: > >On Jan 18, 2017 1:47 PM, "Francisco Jerez" <[1]curroje...@riseup.net> > >wrote: > > > >Topi Pohjolainen <[2]topi.pohjolai...@gmail.com> writes: > >

Re: [Mesa-dev] [v2 1/4] i965/blorp: Use the render cache mechanism instead of explicit flushing

2017-01-18 Thread Pohjolainen, Topi
On Wed, Jan 18, 2017 at 01:29:41PM -0800, Francisco Jerez wrote: > Topi Pohjolainen writes: > > > by replacing brw_emit_mi_flush() with brw_render_cache_set_check_flush(). > > The latter splits the flush in two: > > > >brw_emit_pipe_control_flush(brw, > >

Re: [Mesa-dev] [PATCH] nir/algebraic: Only include nir_search_helpers once

2017-01-18 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2017-01-18 at 15:24 -0800, Jason Ekstrand wrote: > We were including it once per value, so probably around 10k times. > Let's not cause the compiler any more work than we have to. > --- >  src/compiler/nir/nir_algebraic.py | 2 +- >  1

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for NONE attachment type

2017-01-18 Thread Iago Toral
On Wed, 2017-01-18 at 16:48 -0200, Alejandro Piñeiro wrote: > When the attachment type is NONE (att->Type), > FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE should be NONE too. > > Note that technically, the current behaviour follows the spec. From > OpenGL 4.5 spec, Section 9.2.3 "Framebuffer Object

Re: [Mesa-dev] [PATCH 4/4] i965/blorp: Make post draw flush more explicit

2017-01-18 Thread Pohjolainen, Topi
On Wed, Jan 18, 2017 at 01:54:43PM -0800, Jason Ekstrand wrote: >On Jan 18, 2017 1:47 PM, "Francisco Jerez" <[1]curroje...@riseup.net> >wrote: > >Topi Pohjolainen <[2]topi.pohjolai...@gmail.com> writes: >> Blits do not need any special treatment as the target buffer >> object

[Mesa-dev] [PATCH 1/2] android: correct typo in build

2017-01-18 Thread Tapani Pälli
Fixes: 63c58dfc653c499aab5b8d0ea07f1dc1af88c856 Signed-off-by: Tapani Pälli --- Android.common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Android.common.mk b/Android.common.mk index a75d4e7..30166a6 100644 --- a/Android.common.mk +++

[Mesa-dev] [PATCH 2/2] android: add vulkan build for intel

2017-01-18 Thread Tapani Pälli
fixes to issues spotted by Emil Velikov: - set ANV_TIMESTAMP corretly - fix typo with VULKAN_GEM_FILES v2: update to use Makefile.sources under vulkan instead of having own v3: update to changes to generate from vk.xml (commit c7fc310) Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v2 05/20] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

2017-01-18 Thread Samuel Iglesias Gonsálvez
On Wed, 2017-01-18 at 11:39 -0800, Matt Turner wrote: > On Wed, Jan 18, 2017 at 2:45 AM, Samuel Iglesias Gonsálvez > wrote: > > On Tue, 2017-01-17 at 13:33 -0800, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > From: Matt

Re: [Mesa-dev] [PATCH v2] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-18 Thread Michel Dänzer
On 19/01/17 02:10 PM, Nayan Deshmukh wrote: > PresentPixmap only works if the pixmap depth and format matches > with the window, otherwise it returns a BadMatch protocol error. Nitpick: PresentPixmap only returns BadMatch if the depths don't match. It doesn't know anything about formats, so if

Re: [Mesa-dev] Clean ups (fortnightly spamming)

2017-01-18 Thread Edward O'Callaghan
This series is, Acked-by: Edward O'Callaghan On 01/19/2017 05:23 PM, Timothy Arceri wrote: > Thanks to all that have help review the series so far. 70+ patches have > landed since I jumped into this just 10 to go. > > The first 3 are the major changes and need to be

[Mesa-dev] [PATCH 10/10] mesa: remove unused gl_shader_info field from gl_linked_shader

2017-01-18 Thread Timothy Arceri
--- src/mesa/main/mtypes.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 580ed8c..2ed089a 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2354,8 +2354,6 @@ struct gl_linked_shader struct exec_list

[Mesa-dev] [PATCH 09/10] mesa/glsl: set and get cs layouts to and from shader_info

2017-01-18 Thread Timothy Arceri
--- src/compiler/glsl/linker.cpp | 35 +++ src/mesa/main/mtypes.h | 10 -- src/mesa/main/shaderapi.c| 6 ++ src/mesa/main/shaderobj.c| 2 -- 4 files changed, 17 insertions(+), 36 deletions(-) diff --git a/src/compiler/glsl/linker.cpp

[Mesa-dev] [PATCH 07/10] mesa/glsl/i965: set and get tes layouts directly to and from shader_info

2017-01-18 Thread Timothy Arceri
--- src/compiler/glsl/linker.cpp| 64 +++-- src/mesa/drivers/dri/i965/brw_tcs.c | 6 ++-- src/mesa/main/shaderapi.c | 15 +++-- 3 files changed, 40 insertions(+), 45 deletions(-) diff --git a/src/compiler/glsl/linker.cpp

[Mesa-dev] [PATCH 08/10] mesa/glsl: set and get gs layouts directly to and from shader_info

2017-01-18 Thread Timothy Arceri
--- src/compiler/glsl/linker.cpp | 70 +++- src/mesa/main/shaderapi.c| 12 +++- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index b1dbbc2..294d9c0 100644 ---

[Mesa-dev] [PATCH 06/10] glsl: use last_vert_prog to get last {clip, cull}_distance_array_size

2017-01-18 Thread Timothy Arceri
--- src/compiler/glsl/link_varyings.cpp | 6 -- src/compiler/glsl/linker.cpp| 14 -- src/mesa/main/mtypes.h | 7 --- 3 files changed, 4 insertions(+), 23 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp

[Mesa-dev] [PATCH 05/10] mesa/glsl: set {clip, cull}_distance_array_size directly in gl_program

2017-01-18 Thread Timothy Arceri
There are some line wrapping violations here but those lines will get deleted in the following patch. --- src/compiler/glsl/glsl_to_nir.cpp | 2 -- src/compiler/glsl/linker.cpp| 32 +++ src/mesa/drivers/dri/i965/brw_vs.c | 2 +- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 04/10] st/mesa/glsl: change xfb_program field to last_vert_prog

2017-01-18 Thread Timothy Arceri
Now that the i965 backend doesn't depend on this field we can make it more generic and short circuit a bunch of code paths. The new field will be used in a following patch for another clean-up. --- src/compiler/glsl/link_varyings.cpp| 5 +++- src/compiler/glsl/linker.cpp |

[Mesa-dev] [PATCH 02/10] mesa/meta: rewrite _mesa_shader_program_use() and _mesa_program_use()

2017-01-18 Thread Timothy Arceri
These are rewritten to do what the function name suggests, that is _mesa_shader_program_use() sets the use of all stage and _mesa_program_use() sets the use of a single stage. This patch is split out to make review easier but will be squashed into mesa: use gl_program for CurrentProgram rather

[Mesa-dev] [PATCH 01/10] mesa: use gl_program for CurrentProgram rather than gl_shader_program

2017-01-18 Thread Timothy Arceri
This makes much more sense and should be more performant in some critical paths such as SSO validation which is called at draw time. Previously the CurrentProgram array could have contained multiple pointers to the same struct which was confusing and we would often need to fish out the

[Mesa-dev] [PATCH 03/10] mesa: update active relinked program

2017-01-18 Thread Timothy Arceri
This likely fixes a subroutine bug were _mesa_shader_program_init_subroutine_defaults() would never have been called for the relinked program as we previously just set _NEW_PROGRAM as dirty and never called the _mesa_use* functions. We also switch to using gl_program for the CurrentProgram array

[Mesa-dev] Clean ups (fortnightly spamming)

2017-01-18 Thread Timothy Arceri
Thanks to all that have help review the series so far. 70+ patches have landed since I jumped into this just 10 to go. The first 3 are the major changes and need to be squashed together, the reset of the changes are straight forward. Please review. ___

[Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

2017-01-18 Thread Rhys Kidd
Use of unsigned loop control variable with '>= 0' would lead to infinite loop. Reported by clang: etnaviv_compiler.c:1024:39: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] for (unsigned sp = c->frame_sp; sp >= 0; sp--)

Re: [Mesa-dev] [PATCH] gallivm: use #ifdef not #if for PIPE_ARCH_BIG_ENDIAN

2017-01-18 Thread Roland Scheidegger
Am 19.01.2017 um 05:40 schrieb Dave Airlie: > From: Dave Airlie > > This fixes the build on ppc/s390. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/gallivm/lp_bld_gather.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Mesa-dev] [PATCH v2] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-18 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth and format matches with the window, otherwise it returns a BadMatch protocol error. For other buffers we copy them to a buffer which is send to X. v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8 Signed-off-by: Nayan Deshmukh

[Mesa-dev] [PATCH] gallivm: use #ifdef not #if for PIPE_ARCH_BIG_ENDIAN

2017-01-18 Thread Dave Airlie
From: Dave Airlie This fixes the build on ppc/s390. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_gather.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_gather.c

Re: [Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Michel Dänzer
On 19/01/17 02:23 AM, Nayan Deshmukh wrote: > On Wed, Jan 18, 2017 at 9:21 PM, Michel Dänzer wrote: >> On 19/01/17 12:27 AM, Nayan Deshmukh wrote: >>> PresentPixmap only works if the pixmap depth matches the window >>> depth, otherwise it returns a BadMatch protocol error. >>>

Re: [Mesa-dev] [PATCH 07/19] clover: automake: remove -I$(srcdir)

2017-01-18 Thread Aaron Watry
Patches 6 and 7 are Tested-by: Aaron Watry The content looks good to me as well, but I'm not great at automake. You can have a Reviewed-by as well, for what it's worth. --Aaron On Mon, Jan 16, 2017 at 9:45 AM, Emil Velikov wrote: > From: Emil

[Mesa-dev] [PATCH 3/3] gallivm: Reenable PPC VSX (v3)

2017-01-18 Thread Ben Crocker
Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, now that LLVM bug 26775 and its corollary, 25503, are fixed. Amendment: remove extraneous spaces in macro def & invocations. We would prefer a runtime check, e.g. via an LLVMQueryString (analogous to glGetString,

[Mesa-dev] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8" (v3)

2017-01-18 Thread Ben Crocker
If llvm::sys::getHostCPUName() returns "generic", override it with "pwr8" (on PPC64LE). This is a work-around for a bug in LLVM: a table entry for "POWER8NVL" is missing, resulting in (big-endian) "generic" being returned on little-endian Power8NVL systems. The result is that code that attempts

[Mesa-dev] [PATCH 1/3] gallivm: Improve debug output

2017-01-18 Thread Ben Crocker
Improve debug output from gallivm_compile_module and lp_build_create_jit_compiler_for_module, printing the -mcpu and -mattr options passed to LLC. Signed-off-by: Ben Crocker --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 5 -

Re: [Mesa-dev] [PATCH 2/5] nir: shuffle constants to the top

2017-01-18 Thread Jason Ekstrand
On Tue, Jan 17, 2017 at 6:12 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > If one of the inputs to and mul/add is the result of an another > mul/add there is a chance that we can reuse the result of that > mul/add in other calls if we do the multiplication in the right > order. > >

Re: [Mesa-dev] [PATCH 4/5] configure: explicitly require shared glapi for enable-dri

2017-01-18 Thread Steven Newbury
On Wed, 2016-12-07 at 13:25 +, Emil Velikov wrote: > From: Emil Velikov > > We've been using and depending on it for at least a couple of years. > Make it obvious and error out, should one opt for it. > > Signed-off-by: Emil Velikov >

Re: [Mesa-dev] [PATCH 09/12] glcpp: Avoid unnecessary linear_strdup

2017-01-18 Thread Ian Romanick
On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > The lexer copies every identifier it finds. At first look it seems > needless, because all these identifiers are already available stored > inside of shader text, but my experiments with immutable explicitly > sized strings (ptr, len) resulted in a

Re: [Mesa-dev] [PATCH 08/12] glcpp: Use strpbrk in the line continuations pass

2017-01-18 Thread Ian Romanick
On 01/07/2017 06:30 PM, Vladislav Egorov wrote: > Well, running radamsa fuzzer right now and it's able to find quite a bit > of various problems (difference in output/error reporting against > master) in the hand-written parser without any effort. Some cases should > be added to the test-suite

Re: [Mesa-dev] [PATCH 07/12] glcpp: Skip unnecessary line continuations removal

2017-01-18 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > Overwhelming majority of shaders don't use line continuations. In my > shader-db only shaders from the Talos Principle and Serious Sam used > them, less than 1% out of all

Re: [Mesa-dev] [PATCH 06/12] ralloc: Use strnlen() inside of strncat()

2017-01-18 Thread Ian Romanick
On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > If the str is long or isn't null-terminated, strlen() could take a lot > of time or even crash. I don't know why was it used in the first place, > maybe for platforms without strnlen(), but strnlen() is already used > inside of ralloc_strndup(), so

[Mesa-dev] [PATCH] nir/algebraic: Only include nir_search_helpers once

2017-01-18 Thread Jason Ekstrand
We were including it once per value, so probably around 10k times. Let's not cause the compiler any more work than we have to. --- src/compiler/nir/nir_algebraic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_algebraic.py

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-18 Thread Andy Furniss
Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: On 17 January 2017 at 14:55, Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 6:25 PM, Christian König wrote: Hi Nayan, I've pushed this

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #6 from Andres Rodriguez --- small patch on mesa-dev with Emil's suggestion. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] vulkan/wsi: clarify the severity of lack of DRI3 v2

2017-01-18 Thread Andres Rodriguez
The current message sounds like a small warning, clarify that it can result in lack of presentation support and application crashes. v2: add "if they do" (Bas) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98263 Signed-off-by: Andres Rodriguez ---

Re: [Mesa-dev] [PATCH] radv: fix include order for installed headers v2

2017-01-18 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Jan 18, 2017 at 11:48 PM, Andres Rodriguez wrote: > In situations where libdrm_amdgpu and mesa are installed to the same > location, the mesa installed headers will take precedence over the git > source

Re: [Mesa-dev] [PATCH 03/12] glcpp: Use Bloom filter before identifier search

2017-01-18 Thread Ian Romanick
On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > Absolute majority of identifiers in shaders are not macro references. > Many shaders don't use preprocessing macros at all. Almost all > queries to parser->defines hash-table will be unsuccessful. Note > that all predefined macros start either with

Re: [Mesa-dev] [PATCH] vulkan/wsi: clarify the severity of lack of DRI3

2017-01-18 Thread Bas Nieuwenhuizen
On Wed, Jan 18, 2017 at 11:49 PM, Andres Rodriguez wrote: > The current message sounds like a small warning, clarify that it can > result in lack of presentation support and application crashes. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98263 > Signed-off-by:

Re: [Mesa-dev] [PATCH] vulkan/wsi: clarify the severity of lack of DRI3

2017-01-18 Thread Jason Ekstrand
Sure Acked-by: Jason ekstrand On Wed, Jan 18, 2017 at 2:49 PM, Andres Rodriguez wrote: > The current message sounds like a small warning, clarify that it can > result in lack of presentation support and application crashes. > > Bugzilla:

[Mesa-dev] [PATCH] vulkan/wsi: clarify the severity of lack of DRI3

2017-01-18 Thread Andres Rodriguez
The current message sounds like a small warning, clarify that it can result in lack of presentation support and application crashes. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98263 Signed-off-by: Andres Rodriguez --- src/vulkan/wsi/wsi_common_x11.c | 6 -- 1

Re: [Mesa-dev] [PATCH 02/12] glcpp: Avoid unnecessary strcmp()

2017-01-18 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick I'd also accept a follow-up patch that fixes the formatting of multi-line comments in this function (file?) by putting the closing */ on its own line. :) On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > strcmp() is slow.

[Mesa-dev] [PATCH] radv: fix include order for installed headers v2

2017-01-18 Thread Andres Rodriguez
In situations where libdrm_amdgpu and mesa are installed to the same location, the mesa installed headers will take precedence over the git source headers. This is due to the AMDGPU_CFLAGS containing the install directory. This situation can cause build errors if the git version of a header is

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-18 Thread Ian Romanick
On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > glcpp's printing is an obvious low hanging fruit: > > 1. It unnecessarily uses formatted printing to print output of >preprocessing. To print just one character '+' it first uses >vsnprintf("%s", "+") to calculate number of characters in

[Mesa-dev] [PATCH] radv: fix include order for installed headers

2017-01-18 Thread Andres Rodriguez
In situations where libdrm_amdgpu and mesa are installed to the same location, the mesa installed headers will take precedence over the git source headers. This is due to the AMDGPU_CFLAGS containing the install directory. This situation can cause build errors if the git version of a header is

[Mesa-dev] [Bug 99446] [anv] (and radv) Regression enabling Vulkan loader interface version 3

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99446 --- Comment #1 from Bas Nieuwenhuizen --- Would it be possible to get a stacktrace with debug symbols for libvulkan, as well as make sure it is somewhat up to date? -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH 3/4] i965/gen6: Issue direct depth stall and flush after depth clear

2017-01-18 Thread Francisco Jerez
Topi Pohjolainen writes: > instead of calling unconditionally brw_emit_mi_flush() which > does: > >brw_emit_pipe_control_flush(brw, > PIPE_CONTROL_DEPTH_CACHE_FLUSH | >

Re: [Mesa-dev] [PATCH 4/4] i965/blorp: Make post draw flush more explicit

2017-01-18 Thread Jason Ekstrand
On Jan 18, 2017 1:47 PM, "Francisco Jerez" wrote: Topi Pohjolainen writes: > Blits do not need any special treatment as the target buffer > object is added to render cache just as one does for normal draw. > Color clears and resolves in turn

Re: [Mesa-dev] [PATCH 4/4] i965/blorp: Make post draw flush more explicit

2017-01-18 Thread Francisco Jerez
Topi Pohjolainen writes: > Blits do not need any special treatment as the target buffer > object is added to render cache just as one does for normal draw. > Color clears and resolves in turn require explicit "end of pipe > synchronization". It is not clear what this

Re: [Mesa-dev] [PATCH] radeonsi: reject invalid vertex element formats

2017-01-18 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 01/18/2017 10:35 PM, Marek Olšák wrote: From: Marek Olšák This should fix a coverity defect. --- src/gallium/drivers/radeonsi/si_state.c | 5 + 1 file changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH] radeonsi: reject invalid vertex element formats

2017-01-18 Thread Marek Olšák
From: Marek Olšák This should fix a coverity defect. --- src/gallium/drivers/radeonsi/si_state.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f60a499..5bc1789 100644 ---

Re: [Mesa-dev] [v2 1/4] i965/blorp: Use the render cache mechanism instead of explicit flushing

2017-01-18 Thread Francisco Jerez
Topi Pohjolainen writes: > by replacing brw_emit_mi_flush() with brw_render_cache_set_check_flush(). > The latter splits the flush in two: > >brw_emit_pipe_control_flush(brw, >PIPE_CONTROL_DEPTH_CACHE_FLUSH | >

Re: [Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-18 Thread Samuel Pitoiset
You were too fast for writing the fix, but I was very close. :) Confirmed, it fixes VM faults in Deux Ex: Mankind Divided. Thanks! Reviewed-by: Samuel Pitoiset On 01/18/2017 10:21 PM, Marek Olšák wrote: From: Marek Olšák This fixes VM

[Mesa-dev] [PATCH] radeonsi: don't forget to add HTILE to the buffer list for texturing

2017-01-18 Thread Marek Olšák
From: Marek Olšák This fixes VM faults. Discovered by Samuel Pitoiset. Cc: 17.0 13.0 --- src/gallium/drivers/radeonsi/si_descriptors.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 06/20] i965/fs: fix dst stride in IVB/BYT type conversions

2017-01-18 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Tue, 2017-01-17 at 13:26 -0800, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > From: "Juan A. Suarez Romero" >> > >> > When converting a DF to F, we set dst stride to

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #9 from Laurent carlier --- (In reply to Germano Massullo from comment #5) > Everytime I try to enable Vulkan API, I get "Cannot set display mode" error > message > > I attach api trace while trying to enable

[Mesa-dev] [AppVeyor] mesa master #3189 completed

2017-01-18 Thread AppVeyor
Build mesa 3189 completed Commit ea8b2624c8 by Emil Velikov on 1/18/2017 7:48 PM: utils: really remove the __END_DECLS macro\n\nFixes: d1efa09d342 "util: import sha1 implementation from OpenBSD"\nSigned-off-by: Emil Velikov

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #8 from Hadrien --- (In reply to Ernst Sjöstrand from comment #4) > I had a similar problem, turns out it was: > https://github.com/ValveSoftware/steam-for-linux/issues/4638 > > If you change to the Steam

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #7 from Ernst Sjöstrand --- Germano, I think you have a completely different issue than the original reporter. You should probably file a separate bugreport. -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #6 from Hadrien --- (In reply to Eero Tamminen from comment #3) > Which Graphics -> Performance -> GPU Speed setting you're using? > > Talos works with Mesa Vulkan/Intel when using "low" or "medium" level, but

Re: [Mesa-dev] [PATCH v2 05/20] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

2017-01-18 Thread Matt Turner
On Wed, Jan 18, 2017 at 2:45 AM, Samuel Iglesias Gonsálvez wrote: > On Tue, 2017-01-17 at 13:33 -0800, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > From: Matt Turner >> > >> > On HSW+, scalar DF sources can

Re: [Mesa-dev] [PATCH v2 05/20] i965: Use <0, 2, 1> region for scalar DF sources on IVB/BYT.

2017-01-18 Thread Matt Turner
On Tue, Jan 17, 2017 at 1:33 PM, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> From: Matt Turner >> >> On HSW+, scalar DF sources can be accessed using the normal <0,1,0> >> region, but on IVB and BYT DF regions

Re: [Mesa-dev] [AppVeyor] mesa master #3186 failed

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 19:13, AppVeyor wrote: > Build mesa 3186 failed > > Commit d1efa09d34 by Emil Velikov on 1/13/2017 4:51 PM: > util: import sha1 implementation from OpenBSD\n\nAt the moment we support 5+ > different implementations each with varying\namount of bugs -

[Mesa-dev] [AppVeyor] mesa master #3186 failed

2017-01-18 Thread AppVeyor
Build mesa 3186 failed Commit d1efa09d34 by Emil Velikov on 1/13/2017 4:51 PM: util: import sha1 implementation from OpenBSD\n\nAt the moment we support 5+ different implementations each with varying\namount of bugs - from thread safely problems [1], to

[Mesa-dev] [PATCH v2] mesa/main: Fix FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for NONE attachment type

2017-01-18 Thread Alejandro Piñeiro
When the attachment type is NONE (att->Type), FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE should be NONE too. Note that technically, the current behaviour follows the spec. From OpenGL 4.5 spec, Section 9.2.3 "Framebuffer Object Queries": "If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE,

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 18:12, Jose Fonseca wrote: >>> In order to untangle things we want to have a distinction between the >>> gallium (gallivm afaict) and other users - RADV presently. >>> So how about we update the RADV instances and ensure that the we set >>> the

Re: [Mesa-dev] [PATCH 7/8] configure.ac: disable enable_gallium_llvm in the !x86 case

2017-01-18 Thread Marek Olšák
On Wed, Jan 18, 2017 at 5:59 PM, Emil Velikov wrote: > On 18 January 2017 at 16:47, Chuck Atkins wrote: >> Forgive me, as I'm not too familiar with the rest of the infrastructure >> surrounding this, but what's the motivation for disabling llvm

Re: [Mesa-dev] android: patches for upcoming mesa 17.0 release

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 18:09, Mauro Rossi wrote: > 2017-01-18 17:40 GMT+01:00 Emil Velikov : >> On 10 January 2017 at 15:13, Emil Velikov wrote: >>> On 10 January 2017 at 00:52, Mauro Rossi wrote:

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Tobias Droste
Mit freundlichen Grüßen Tobias Droste Am Mittwoch, 18. Januar 2017, 18:12:37 CET schrieb Jose Fonseca: > On 18/01/17 17:51, Tobias Droste wrote: > > Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: > >> On 18 January 2017 at 15:11, Jose Fonseca wrote: > >>>

[Mesa-dev] [Bug 99442] The Talos Principle hangs with Vulkan/Radeon

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99442 --- Comment #5 from Germano Massullo --- Everytime I try to enable Vulkan API, I get "Cannot set display mode" error message I attach api trace while trying to enable Vulkan API

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Jose Fonseca
On 18/01/17 17:51, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: On 18 January 2017 at 15:11, Jose Fonseca wrote: I've reverted this and took a closer look. I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM

Re: [Mesa-dev] [PATCH 8/8] configure.ac: correctly manage llvm auto-detection

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:54:04 CET schrieb Emil Velikov: > From: Emil Velikov > > Earlier refactoring commits changed from one, dare I say it, broken > behaviour to another. Namely: > > Before, as you explicitly

Re: [Mesa-dev] android: patches for upcoming mesa 17.0 release

2017-01-18 Thread Mauro Rossi
2017-01-18 17:40 GMT+01:00 Emil Velikov : > On 10 January 2017 at 15:13, Emil Velikov wrote: >> On 10 January 2017 at 00:52, Mauro Rossi wrote: >>> >>> Hi, >>> >>> I'm sending a series of 12 patches for android, >>>

Re: [Mesa-dev] [PATCH 6/8] configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed

2017-01-18 Thread Tobias Droste
Am Mittwoch, 18. Januar 2017, 13:54:02 CET schrieb Emil Velikov: > From: Emil Velikov > > Earlier refactoring commits started setting the above regardless if LLVM > is used or not. Move them to the respective section to restore the > original functionality. > > Since

Re: [Mesa-dev] [PATCH 4/8] configure.ac: don't use == with test

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Old habits... sorry :-) Am Mittwoch, 18. Januar 2017, 13:54:00 CET schrieb Emil Velikov: > From: Emil Velikov > > Although it works, it's not the correct thing to do. > > Cc: Tobias Droste >

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 --- Comment #5 from Emil Velikov --- (In reply to Kai from comment #4) > The problem was not so much me not seeing that message, the problem was more > that I didn't connect "no DRI3 support" equals "this game won't

Re: [Mesa-dev] [PATCH 5/8] Revert "configure.ac: Create correct LLVM_VERSION_INT with minor >= 10"

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:54:01 CET schrieb Emil Velikov: > As stated in [1] by the LLVM devs, the new versioning scheme will not > deploy any minor version (i.e. it will always be zero). As such the > patch should not be needed. > > This

Re: [Mesa-dev] [PATCH 3/8] configure.ac: remove unused LLVM variables

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:53:59 CET schrieb Emil Velikov: > From: Emil Velikov > > LLVM_BINDIR is completely unused while others such as LLVM_LIBDIR are > used only internally. In the latter case there's no need to

Re: [Mesa-dev] [PATCH 2/8] configure.ac: directly print the contents of USE_LLVM

2017-01-18 Thread Tobias Droste
Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:53:58 CET schrieb Emil Velikov: > From: Emil Velikov > > There's no point in the extra conditional. > > Cc: Tobias Droste > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 1/8] configure.ac: directly print the contents of HAVE_GALLIUM_LLVM

2017-01-18 Thread Tobias Droste
You may want to hold this one until we have a solution for Joses problem. In case the .c file changes stay: Reviewed-by: Tobias Droste Am Mittwoch, 18. Januar 2017, 13:53:57 CET schrieb Emil Velikov: > From: Emil Velikov > > Just ensure that the

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-18 Thread Tobias Droste
Am Mittwoch, 18. Januar 2017, 15:40:22 CET schrieb Emil Velikov: > On 18 January 2017 at 15:11, Jose Fonseca wrote: > > I've reverted this and took a closer look. > > > > I'm fine with autoconf glue doing whatever: HAVE_LLVM -> HAVE_GALLIUM_LLVM > > and what not. > > > >

[Mesa-dev] [Bug 98263] [radv] The Talos Principle fails to launch with "Fatal error: Cannot set display mode."

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98263 Germano Massullo changed: What|Removed |Added CC|

[Mesa-dev] [Bug 99446] [anv] (and radv) Regression enabling Vulkan loader interface version 3

2017-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99446 Bas Nieuwenhuizen changed: What|Removed |Added QA Contact|intel-3d-bugs@lists.freedes

Re: [Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Nayan Deshmukh
On Wed, Jan 18, 2017 at 9:21 PM, Michel Dänzer wrote: > On 19/01/17 12:27 AM, Nayan Deshmukh wrote: >> PresentPixmap only works if the pixmap depth matches the window >> depth, otherwise it returns a BadMatch protocol error. >> >> Signed-off-by: Nayan Deshmukh

Re: [Mesa-dev] [PATCH 7/8] configure.ac: disable enable_gallium_llvm in the !x86 case

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 16:47, Chuck Atkins wrote: > Forgive me, as I'm not too familiar with the rest of the infrastructure > surrounding this, but what's the motivation for disabling llvm on non-x86 > given that llvm itself is available on a wide variety of platforms? >

Re: [Mesa-dev] [PATCH 7/8] configure.ac: disable enable_gallium_llvm in the !x86 case

2017-01-18 Thread Chuck Atkins
Forgive me, as I'm not too familiar with the rest of the infrastructure surrounding this, but what's the motivation for disabling llvm on non-x86 given that llvm itself is available on a wide variety of platforms? -- Chuck Atkins Staff R Engineer, Scientific Computing Kitware, Inc. (518)

Re: [Mesa-dev] android: patches for upcoming mesa 17.0 release

2017-01-18 Thread Emil Velikov
On 10 January 2017 at 15:13, Emil Velikov wrote: > On 10 January 2017 at 00:52, Mauro Rossi wrote: >> >> Hi, >> >> I'm sending a series of 12 patches for android, >> comprising fixes for build errors, LLVMInitializeAMDGPU* declarations, >> Android

Re: [Mesa-dev] [PATCH] android: ac/debug: move sid_tables.h generation and IB decode to amd/common

2017-01-18 Thread Emil Velikov
On 12 January 2017 at 10:28, Nicolai Hähnle wrote: > On 12.01.2017 01:14, Mauro Rossi wrote: >> >> Hi, >> >> I'm sending a patch to support recent changes in radeonsi and amd/common, >> in order to fix android building errors due to files moved to amd/common. >> >> The patch

Re: [Mesa-dev] [PATCH] nir: add min/max optimisation

2017-01-18 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Jan 18, 2017 3:23 AM, "Elie Tournier" wrote: Add the following optimisations: min(x, -x) = -abs(x) min(x, -abs(x)) = -abs(x) min(x, abs(x)) = x max(x, -abs(x)) = x max(x, abs(x)) = abs(x) max(x, -x) = abs(x)

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Jason Ekstrand
On Jan 18, 2017 8:07 AM, "Emil Velikov" wrote: On 18 January 2017 at 09:43, Timothy Arceri wrote: > I'm all for > importing an implementation I just wanted to be sure we make a good > choice as we will likely be stuck with it for a long

Re: [Mesa-dev] [PATCH] glx: don't expose systemTimeExtension for DRI2/DRI3/DRISW

2017-01-18 Thread Emil Velikov
On 27 September 2016 at 13:39, Emil Velikov wrote: > Used/applicable to only dri1 drivers. > > Signed-off-by: Emil Velikov > --- > If anyone wants to go ahead and start moving the DRI1 only functionality > to src/glx/dri[1] that'll be

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-18 Thread Emil Velikov
On 18 January 2017 at 09:43, Timothy Arceri wrote: > I'm all for > importing an implementation I just wanted to be sure we make a good > choice as we will likely be stuck with it for a long time. > Would you like to give it some more testing/benchmarking, or I can

Re: [Mesa-dev] [v2 2/4] i965: Make depth clear flushing more explicit

2017-01-18 Thread Jason Ekstrand
On Jan 18, 2017 2:22 AM, "Topi Pohjolainen" wrote: Current blorp logic issues unconditional "flush everything" (see brw_emit_mi_flush()) after each render. For example, all blits issue this unconditionally which shouldn't be needed if they set render cache properly os

Re: [Mesa-dev] [v2 1/4] i965/blorp: Use the render cache mechanism instead of explicit flushing

2017-01-18 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Jan 18, 2017 2:22 AM, "Topi Pohjolainen" wrote: > by replacing brw_emit_mi_flush() with brw_render_cache_set_check_flush(). > The latter splits the flush in two: > >brw_emit_pipe_control_flush(brw, >

Re: [Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Michel Dänzer
On 19/01/17 12:27 AM, Nayan Deshmukh wrote: > PresentPixmap only works if the pixmap depth matches the window > depth, otherwise it returns a BadMatch protocol error. > > Signed-off-by: Nayan Deshmukh > --- > src/gallium/state_trackers/vdpau/output.c| 6 ++

Re: [Mesa-dev] [PATCH v4 7/7] gallium: add pipe_screen::resource_changed callback wrappers

2017-01-18 Thread Emil Velikov
On 6 December 2016 at 16:17, Philipp Zabel wrote: > Add resource_changed to the ddebug, rbug, and trace wrappers. Since it > is optional, there is no need to add it to noop. > > Signed-off-by: Philipp Zabel > Suggested-by: Nicolai Hähnle

  1   2   >