Re: [Mesa-dev] [Mesa-stable] [PATCH v3 2/3] i965/fs: detect different bit size accesses to uniforms to push them in proper locations

2017-02-28 Thread Samuel Iglesias Gonsálvez
On 27/02/17 22:02, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> Previously, if we had accesses with different sizes to the same uniform, we >> might not >> push it aligned with the bigger one. This is a problem in BSW/BXT when we >> access >> an array

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-02-28 Thread Axel Davy
My understanding of the code is that the disk cache just depends on the sscreen->b.disk_shader_cache being initialized, and it looks like this is always initialized. Thus the disk cache is always enabled. Could you add a RADEON_DEBUG env var to disable it, please ? Thanks, Axel Davy On

Re: [Mesa-dev] [PATCH 2/2] anv: do not subtract the base layer to copute depth in 3DSTATE_DEPTH_BUFFER

2017-02-28 Thread Iago Toral
On Fri, 2017-02-24 at 07:25 -0800, Jason Ekstrand wrote: > On Feb 23, 2017 11:40 PM, "Iago Toral Quiroga" > wrote: > According to the PRM description of the Depth field: > >   "This field specifies the total number of levels for a volume > texture >    or the number of array

Re: [Mesa-dev] [PATCH 02/24] i965: Move some helpers from brw_context.h to brw_shader.h

2017-02-28 Thread Matt Turner
On Tue, Feb 28, 2017 at 9:03 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_compiler.c | 1 + > src/mesa/drivers/dri/i965/brw_context.h | 16 > src/mesa/drivers/dri/i965/brw_shader.h | 18 ++ > 3 files changed, 19

Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Xu, Randy
>> We have a dependency on gralloc in the EGL layer so that is why I don't see >> it as a problem for Vulkan WSI. It’s true. In Android O dessert (not released yet), all HALs except for OpeGL and Vulcan need to be wrapped by HIDL and binderized now. While I guess Google wants to avoid this

Re: [Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

2017-02-28 Thread Jason Ekstrand
For those of you who like branches: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/move-compiler On Tue, Feb 28, 2017 at 9:03 PM, Jason Ekstrand wrote: > This little series moves the i965 back-end compiler to src/intel/compiler. > It's not incredibly pretty; I

Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Tapani Pälli
On 03/01/2017 07:21 AM, Xu, Randy wrote: Hi, Tapani According to https://source.android.com/devices/graphics/implement-vulkan.html "Window System Integration (WSI) extensions are exported by the loader and primarily implemented in it rather than the driver.". Also, Google provides the

Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 9:21 PM, Xu, Randy wrote: > Hi, Tapani > > > > According to https://source.android.com/devices/graphics/implement- > vulkan.html > "Window System Integration (WSI) extensions are exported by the loader and > primarily implemented in it rather than the

[Mesa-dev] V2 Enable radeonsi disk cache

2017-02-28 Thread Timothy Arceri
Patches 1 & 2 are new improvements to the disk cache util. Patches 3 & 4 are unchanged. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/4] Revert "glsl: Switch to disable-by-default for the GLSL shader cache"

2017-02-28 Thread Timothy Arceri
This reverts commit 0f60c6616e93cba72bff4fbfedb72a753ef78e05. Piglit and all games tested so far seem to be working without issue. This change will allow wide user testing and we can decided before the next release if we need to turn it off again. Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-02-28 Thread Timothy Arceri
This reduces the cache size for Deus Ex from ~160M to ~30M for radeonsi. I'm also seeing the following improvements in minimum fps in the Shadow of Mordor benchmark: no-cache:~10fps with-cache-no-compression: ~15fps with-cache-and-compression: ~20fps Note the with cache

[Mesa-dev] [PATCH 1/4] util/disk_cache: add support for detecting corrupt cache entries

2017-02-28 Thread Timothy Arceri
--- src/util/disk_cache.c | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index f5e1145..2a0edca 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -31,20 +31,21 @@ #include

[Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-02-28 Thread Timothy Arceri
V2: - when loading from disk cache also binary insert into memory cache. - check that the binary loaded from disk is the correct size. If not delete the cache item and skip loading from cache. V3: - remove unrequired variable Tested-by: Michel Dänzer ---

Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Xu, Randy
Hi, Tapani According to https://source.android.com/devices/graphics/implement-vulkan.html "Window System Integration (WSI) extensions are exported by the loader and primarily implemented in it rather than the driver.". Also, Google provides the stubhal.c in frameworks/native/vulkan/libvulkan,

[Mesa-dev] [PATCH 22/24] i965: Delete brw_do_cubemap_normalize

2017-02-28 Thread Jason Ekstrand
This hasn't been used for quite some time now but we never bothered to get rid of it when we dropped GLSL IR support for vec4. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_context.h| 2 - .../drivers/dri/i965/brw_cubemap_normalize.cpp

[Mesa-dev] [PATCH 16/24] i965: Move BRW_ATTRIB_WA_* defines to brw_compiler.h

2017-02-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compiler.h | 14 +- src/mesa/drivers/dri/i965/brw_nir_attribute_workarounds.c | 1 - src/mesa/drivers/dri/i965/brw_vs.h| 11 --- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 17/24] i965: Make mark_surface_used a static inline in brw_compiler.h

2017-02-28 Thread Jason Ekstrand
One of these days, I'd like to see this function go away all together but for now, let's at least put it near the struct it updates. --- src/mesa/drivers/dri/i965/brw_compiler.h | 13 + src/mesa/drivers/dri/i965/brw_shader.cpp | 13 - 2 files changed, 13 insertions(+), 13

[Mesa-dev] [PATCH 23/24] i965: Reduce cross-pollination between the DRI driver and compiler

2017-02-28 Thread Jason Ekstrand
A lot of compiler stuff was including brw_context.h as a convenient grab-bag way of getting at a bunch of other includes. Also, a bunch of non-compiler stuff is including compiler "internal" headers for no good reason. --- src/intel/blorp/blorp_priv.h | 2 +-

[Mesa-dev] [PATCH 24/24] i965: Move the back-end compiler to src/intel/compiler

2017-02-28 Thread Jason Ekstrand
--- src/intel/Makefile.am | 2 + src/intel/Makefile.compiler.am | 116 + src/intel/Makefile.sources | 89 src/intel/compiler/.gitignore | 1 + .../dri/i965 =>

[Mesa-dev] [PATCH 14/24] i965/inst: Stop using fi_type

2017-02-28 Thread Jason Ekstrand
It's a mesa define that's trivial to inline. This removes a dependence on main/imports.h. --- src/mesa/drivers/dri/i965/brw_inst.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_inst.h b/src/mesa/drivers/dri/i965/brw_inst.h index

[Mesa-dev] [PATCH 19/24] i965: Move image uniform setup to brw_nir_uniforms.cpp

2017-02-28 Thread Jason Ekstrand
It's the only thing that's using it. --- src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp | 51 ++ src/mesa/drivers/dri/i965/brw_shader.cpp | 51 -- 2 files changed, 51 insertions(+), 51 deletions(-) diff --git

[Mesa-dev] [PATCH 20/24] i965: Move a bunch of pre-compile and link stuff to brw_program.h

2017-02-28 Thread Jason Ekstrand
It's all GL-specific and brw_program.h is not part of i965_compiler. --- src/mesa/drivers/dri/i965/brw_program.h | 15 +++ src/mesa/drivers/dri/i965/brw_shader.h | 14 -- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 18/24] i965: Move channel_expressions and vector_splitting to brw_program.h

2017-02-28 Thread Jason Ekstrand
They're GL-specific. --- src/mesa/drivers/dri/i965/brw_fs.h | 3 --- src/mesa/drivers/dri/i965/brw_program.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index d0e272b..00861ce 100644 ---

[Mesa-dev] [PATCH 15/24] i965: Move BRW_MAX_DRAW_BUFFERS to brw_compiler.h

2017-02-28 Thread Jason Ekstrand
It does sort-of go with MAX_UBO and friends but MAX_DRAW_BUFFERS is an actual hardware constant based on the number of things we can blend rather than an arbitrary "number of things allowed in GL" like some of the other maximums are. --- src/mesa/drivers/dri/i965/brw_compiler.h | 3 +++

[Mesa-dev] [PATCH 21/24] i965: Add a header for brw_vec4_vs_visitor

2017-02-28 Thread Jason Ekstrand
brw_vs.h is not a compiler file but brw_vec4_visitor is definitely a compiler thing. --- src/mesa/drivers/dri/i965/Makefile.sources| 1 + src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 +- src/mesa/drivers/dri/i965/brw_vec4_vs_visitor.cpp | 2 +-

[Mesa-dev] [PATCH 03/24] i965: Move brw_disassemble_inst to brw_eu.h

2017-02-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_context.h | 4 src/mesa/drivers/dri/i965/brw_eu.h | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index eda5c32..aa938b6 100644 ---

[Mesa-dev] [PATCH 07/24] i965: Get rid of BRW_PRIM_OFFSET

2017-02-28 Thread Jason Ekstrand
This is a relic of when we wired up meta to be able to use RECTLIST primitives. It's no longer needed. --- src/mesa/drivers/dri/i965/brw_defines.h | 8 src/mesa/drivers/dri/i965/brw_util.c| 8 ++-- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 04/24] i965: Move some gen4 WM defines to brw_compiler.h

2017-02-28 Thread Jason Ekstrand
These go in wm_prog_key so they're part of the compiler interface. --- src/mesa/drivers/dri/i965/brw_compiler.h | 24 +++- src/mesa/drivers/dri/i965/brw_wm.c | 32 src/mesa/drivers/dri/i965/brw_wm.h | 17 -

[Mesa-dev] [PATCH 08/24] i965: Don't use MAX_SURFACES in mark_surface_used

2017-02-28 Thread Jason Ekstrand
Vulkan doesn't respect MAX_SURFACES so this assert isn't valid in that case. It should, however, assert that it isn't insanely large. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp

[Mesa-dev] [PATCH 13/24] i965: Move brw_register_blocks to brw_fs.cpp

2017-02-28 Thread Jason Ekstrand
Its one and only caller is brw_compile_fs which lives there. --- src/mesa/drivers/dri/i965/brw_context.h | 11 --- src/mesa/drivers/dri/i965/brw_fs.cpp| 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h

[Mesa-dev] [PATCH 01/24] i965: Move a couple of #defines from brw_context to brw_compiler

2017-02-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compiler.h | 16 src/mesa/drivers/dri/i965/brw_context.h | 18 -- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src/mesa/drivers/dri/i965/brw_compiler.h index

[Mesa-dev] [PATCH 06/24] i965/vue_map: Stop using GLbitfield types

2017-02-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compiler.h | 8 src/mesa/drivers/dri/i965/brw_vue_map.c | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src/mesa/drivers/dri/i965/brw_compiler.h index 1b71c7f..16d4d0e 100644

[Mesa-dev] [PATCH 12/24] i965: Move SHADER_TIME_STRIDE to brw_compiler.h

2017-02-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compiler.h | 8 src/mesa/drivers/dri/i965/brw_context.h | 8 src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_program.c | 10 +- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- 5 files changed, 15

[Mesa-dev] [PATCH 10/24] i964/gs: Move MAX_GS_INPUT_VERTICES to brw_vec4_gs_visitor.h

2017-02-28 Thread Jason Ekstrand
It's only users are in brw_vec4_gs_visitor and gen6_vec4_gs_visitor. --- src/mesa/drivers/dri/i965/brw_context.h | 2 -- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h

[Mesa-dev] [PATCH 09/24] i965/gs: Add the gl_prim_to_hw_prim table to vec4_gs_visitor.cpp

2017-02-28 Thread Jason Ekstrand
It's currently in brw_util.c but that's the only bit of brw_util.c that's shared between the compiler and the rest of the GL driver. It's just a fairly obvious table so the duplication isn't bad. It's certainly less pain than trying to figure out how to share the code. ---

[Mesa-dev] [PATCH 11/24] i965: Move SOL binding #defines to brw_compiler.h

2017-02-28 Thread Jason Ekstrand
While we're at it, we also change the GEN6 binding macro to be a start index that gets added to the binding. This makes things a bit more explicit. --- src/mesa/drivers/dri/i965/brw_compiler.h | 30 src/mesa/drivers/dri/i965/brw_context.h | 27

[Mesa-dev] [PATCH 05/24] i965: Move assign_common_binding_table_offsets to brw_program

2017-02-28 Thread Jason Ekstrand
This isn't used by Vulkan and is specific to the way the GL driver works. There's no reason to have it in common compiler code. Also, it relies on BRW_MAX_* defines which are defined in brw_context.h --- src/mesa/drivers/dri/i965/brw_program.c | 87

[Mesa-dev] [PATCH 02/24] i965: Move some helpers from brw_context.h to brw_shader.h

2017-02-28 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_compiler.c | 1 + src/mesa/drivers/dri/i965/brw_context.h | 16 src/mesa/drivers/dri/i965/brw_shader.h | 18 ++ 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.c

Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Tapani Pälli
On 03/01/2017 06:17 AM, Jason Ekstrand wrote: On Tue, Feb 28, 2017 at 7:52 PM, Randy Xu > wrote: The VK_ANDROID_native_buffer is implemented in Android Vulkan HAL, not driver, but must be claimed in device extension list. Otherwise,

[Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

2017-02-28 Thread Jason Ekstrand
This little series moves the i965 back-end compiler to src/intel/compiler. It's not incredibly pretty; I didn't do as much header clean-up as perhaps could have been done. Anything that I didn't know what to do with I moved to brw_shader or brw_program. The second-to-last patch which shuffles

Re: [Mesa-dev] [PATCH 27/34] i965: Make CCS stride match kernel's expectations

2017-02-28 Thread Ben Widawsky
On 17-02-28 11:44:24, Jason Ekstrand wrote: On Mon, Feb 27, 2017 at 7:23 PM, Ben Widawsky wrote: On 17-02-27 18:40:41, Jason Ekstrand wrote: On Mon, Feb 27, 2017 at 5:38 PM, Jason Ekstrand wrote: On Mon, Feb 27, 2017 at 4:56 PM, Ben Widawsky

[Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-28 Thread Jacob Lifshay
This commit improves the message by telling them that they could probably enable DRI3. More importantly, it includes a little heuristic to check to see if we're running on AMD or NVIDIA's proprietary X11 drivers and, if we are, doesn't emit the warning. This way, users with both a discrete card

Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Xu, Randy
Hi, Jason The device_extensions array is used to screen the ppEnabledExtensionNames in vkCreateDevice. The Android app passes the VK_ANDROID_native_buffer and will cause VK_ERROR_EXTENSION_NOT_PRESENT error w/o this patch. Btw, anv_CreateDevice function is called by Android Vulkan framework

Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 7:52 PM, Randy Xu wrote: > The VK_ANDROID_native_buffer is implemented in Android Vulkan HAL, > not driver, but must be claimed in device extension list. Otherwise, > this extension will be screened off in framework and driver. > This seems rather

[Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list

2017-02-28 Thread Randy Xu
The VK_ANDROID_native_buffer is implemented in Android Vulkan HAL, not driver, but must be claimed in device extension list. Otherwise, this extension will be screened off in framework and driver. Test: Pass Vulkan dEQP-VK.wsi.android.swapchain.* on Android platform Signed-off-by: Randy Xu

Re: [Mesa-dev] [PATCH] automake: r600: radeonsi: correctly manage libamd_common.la linking

2017-02-28 Thread Michel Dänzer
On 28/02/17 08:08 PM, Emil Velikov wrote: > From: Emil Velikov > > Since both r600 and radeonsi use code from libamd_common they need to > static link it. At the same time, adding a common library to LIB_DEPS is > fragile [can lean to multiple symbol definitions] and

[Mesa-dev] [PATCH] egl: Ensure ResetNotificationStrategy matches for shared contexts.

2017-02-28 Thread Kenneth Graunke
Fixes: dEQP-EGL.functional.robustness.negative_context.invalid_robust_shared_context_creation Signed-off-by: Kenneth Graunke --- src/egl/drivers/dri2/egl_dri2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

2017-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99987 --- Comment #2 from Emil Velikov --- I would suggest building mesa w/o the glvnd stuff and ensuring the mesa libGL/friends are picked. That aside it seems similar to bug 99027 ? Admittedly I've got limited experience

[Mesa-dev] [PATCH] i965: Fix symbolic size of next_offset[] array.

2017-02-28 Thread Kenneth Graunke
It's indexed by buffer, not stream. BRW_MAX_SOL_BUFFERS and MAX_VERTEX_STREAMS happen to both be 4, so there's no actual bug. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] android: vulkan: add support for libmesa_vulkan_{util, wsi}

2017-02-28 Thread Eric Engestrom
On Tuesday, 2017-02-28 18:18:01 +, Emil Velikov wrote: > On 28 February 2017 at 16:05, Eric Engestrom > wrote: > > >> > The quick and dirty fix is to add a rule forcing the serialisation, like > >> > this: > >> > util/vk_enum_to_str.c: util/vk_enum_to_str.h > >>

Re: [Mesa-dev] [PATCH 5/7] anv: Implement VK_KHX_external_memory_capabilities (v2)

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 2:38 PM, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 10:58 AM, Chad Versace > wrote: > >> This is a complete but trivial implementation. It's trivial becasue We >> support no external memory capabilities yet. Most of

[Mesa-dev] [PATCH v2] glsl: remove unecessary flags.q.subroutine_def

2017-02-28 Thread Samuel Pitoiset
This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the flags.q struct which is nice because arb_bindless_texture will need 4 bits for the new layout qualifiers. No piglit regressions found (including compiler tests) with "-t subroutine".

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-28 Thread Samuel Pitoiset
On 03/01/2017 12:04 AM, Timothy Arceri wrote: On 01/03/17 03:57, Samuel Pitoiset wrote: On 02/26/2017 10:19 PM, Timothy Arceri wrote: On 25/02/17 22:15, Samuel Pitoiset wrote: This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in

Re: [Mesa-dev] [PATCH 7/9] anv: Implement VK_KHX_external_semaphore_fd

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 3:04 PM, Chris Wilson wrote: > On Tue, Feb 28, 2017 at 08:56:45AM -0800, Jason Ekstrand wrote: > > + if (handleTypes == 0) { > > + /* The DRM execbuffer ioctl always execute in-oder, even between > > + * different rings. As such, a

Re: [Mesa-dev] [PATCH 02/18] anv/image: Add anv_layout_to_aux_usage()

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 3:01 PM, Nanley Chery wrote: > On Tue, Feb 28, 2017 at 11:00:14AM -0800, Jason Ekstrand wrote: > > On Tue, Feb 28, 2017 at 10:53 AM, Nanley Chery > > wrote: > > > > > On Tue, Feb 28, 2017 at 10:38:12AM -0800, Jason Ekstrand

Re: [Mesa-dev] [PATCH 7/9] anv: Implement VK_KHX_external_semaphore_fd

2017-02-28 Thread Chris Wilson
On Tue, Feb 28, 2017 at 08:56:45AM -0800, Jason Ekstrand wrote: > + if (handleTypes == 0) { > + /* The DRM execbuffer ioctl always execute in-oder, even between > + * different rings. As such, a dummy no-op semaphore is a perfectly > + * valid implementation. That's not quite

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-28 Thread Timothy Arceri
On 01/03/17 03:57, Samuel Pitoiset wrote: On 02/26/2017 10:19 PM, Timothy Arceri wrote: On 25/02/17 22:15, Samuel Pitoiset wrote: This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the flags.q struct which is nice because

Re: [Mesa-dev] [PATCH 02/18] anv/image: Add anv_layout_to_aux_usage()

2017-02-28 Thread Nanley Chery
On Tue, Feb 28, 2017 at 11:00:14AM -0800, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 10:53 AM, Nanley Chery > wrote: > > > On Tue, Feb 28, 2017 at 10:38:12AM -0800, Jason Ekstrand wrote: > > > On Tue, Feb 28, 2017 at 10:32 AM, Nanley Chery > >

Re: [Mesa-dev] [PATCH 5/8] i965: Add script to gen code for OA counter queries

2017-02-28 Thread Robert Bragg
On Mon, Feb 27, 2017 at 5:38 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Hey Rob, > > Your series look pretty good. Just a tiny nit on this patch below. > > As we've discussed in the office, I think it would be nice to have part of > this work factored out in src/intel. > But

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

2017-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99856 --- Comment #23 from Mig --- I recompiled with the default llvm compiler 3.9.1 and it works for me too! Number of platforms: 2 1. Device: AMD TONGA (DRM 3.8.0 / 4.9.11-1-ARCH, LLVM 3.9.1) success: got back 1 binaries,

Re: [Mesa-dev] [PATCH 5/7] anv: Implement VK_KHX_external_memory_capabilities (v2)

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 10:58 AM, Chad Versace wrote: > This is a complete but trivial implementation. It's trivial becasue We > support no external memory capabilities yet. Most of the real work in > this commit is in reworking the UUIDs advertised by the driver. > >

Re: [Mesa-dev] [PATCH 7/7] anv: Implement VK_KHX_external_memory_fd (v2)

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 10:58 AM, Chad Versace wrote: > From: Jason Ekstrand > > > v2 (chadv): > - Rebase. > - Fix vkGetPhysicalDeviceImageFormatProperties2KHR when > handleType == 0. > - Move handleType-independency comments out of

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

2017-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99987 Norman Gaywood changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 22/37] gallium/tests: remove execute bit from TGSI shader - vert-uadd.sh

2017-02-28 Thread Jose Fonseca
On 23/02/17 17:13, Emil Velikov wrote: From: Emil Velikov Just like the the dozens of other shaders, the file is parsed by separate tool and not executed. Cc: José Fonseca Signed-off-by: Emil Velikov --- Jose, please

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

2017-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99856 --- Comment #22 from Henrique Dante de Almeida --- Jan, the patch fixes the problem and hello world works here. Should I report the bug in llvm bug tracker ? -- You are receiving this mail because: You are the QA Contact for

Re: [Mesa-dev] [PATCH 19/37] bin/perf-annotate-jit: add .py suffix

2017-02-28 Thread Jose Fonseca
On 23/02/17 17:13, Emil Velikov wrote: From: Emil Velikov To provide direct feedback about the file in question. Cc: José Fonseca Signed-off-by: Emil Velikov --- Jose, I sincerely hope this doesn't cause issues on

Re: [Mesa-dev] [PATCH 2/9] anv: Add a real semaphore struct

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 1:59 PM, Chris Wilson wrote: > On Tue, Feb 28, 2017 at 08:56:40AM -0800, Jason Ekstrand wrote: > > It's just a dummy for now, but we'll flesh it out as needed for external > > semaphores. > > --- > > src/intel/vulkan/anv_private.h | 15

Re: [Mesa-dev] [PATCH 2/9] anv: Add a real semaphore struct

2017-02-28 Thread Chris Wilson
On Tue, Feb 28, 2017 at 08:56:40AM -0800, Jason Ekstrand wrote: > It's just a dummy for now, but we'll flesh it out as needed for external > semaphores. > --- > src/intel/vulkan/anv_private.h | 15 +++ > src/intel/vulkan/anv_queue.c | 30 -- > 2 files

Re: [Mesa-dev] [PATCH 1/2] i965: Drop unused STATE_TEXRECT_SCALE code.

2017-02-28 Thread Chris Forbes
Nice to see the last remnants of this go. For the series: Reviewed-by: Chris Forbes On Wed, Mar 1, 2017 at 9:53 AM, Kenneth Graunke wrote: > In the past, we used this on Gen4-5 to transform non-normalized texture > coordinates (for

Re: [Mesa-dev] [PATCH 00/18] anv: Remove the HiZ restriction on input attachments

2017-02-28 Thread Nanley Chery
On Mon, Feb 27, 2017 at 09:36:53PM -0800, Jason Ekstrand wrote: > Did a read-through and, overall, this looks great. I made a few comments > but they're fairly simple. Thank you for taking the time to look over this series. > > One question though: Am I correct in thinking that we are still

Re: [Mesa-dev] [PATCH] radv: fix txs for sampler buffers

2017-02-28 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Feb 28, 2017 at 7:53 AM, Dave Airlie wrote: > From: Dave Airlie > > I messed this up when I wrote it, this fixes: > dEQP-VK.memory.pipeline_barrier.*uniform_texel_buffer.* > > Cc: "17.0"

[Mesa-dev] [PATCH 1/2] i965: Drop unused STATE_TEXRECT_SCALE code.

2017-02-28 Thread Kenneth Graunke
In the past, we used this on Gen4-5 to transform non-normalized texture coordinates (for sampler2DRect) to normalized ones. We also used it on Gen6-7.5 for sampler2DRect with GL_CLAMP. Jason dropped this code in 6c8ba59cff14a1a86273f4008ff2a8e68335ab25 in favor of using nir_lower_tex(), which

[Mesa-dev] [PATCH 2/2] mesa: Drop unused STATE_TEXRECT_SCALE program statevars.

2017-02-28 Thread Kenneth Graunke
The last user is now gone. Signed-off-by: Kenneth Graunke --- src/mesa/program/prog_statevars.c | 23 --- src/mesa/program/prog_statevars.h | 1 - 2 files changed, 24 deletions(-) diff --git a/src/mesa/program/prog_statevars.c

Re: [Mesa-dev] [PATCH 03/18] anv/cmd_buffer: Replace layout_to_hiz_usage()

2017-02-28 Thread Nanley Chery
On Tue, Feb 28, 2017 at 11:49:18AM -0800, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 11:35 AM, Nanley Chery > wrote: > > > On Tue, Feb 28, 2017 at 08:16:43AM -0800, Jason Ekstrand wrote: > > > On Tue, Feb 28, 2017 at 5:54 AM, Nanley Chery > >

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

2017-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98502 --- Comment #22 from Eugene Shalygin --- (In reply to Mauro Santos from comment #21) > The difference between both is that with 4.4.52 the device stays powered off > when using lspci but with 4.9.11 the

Re: [Mesa-dev] [PATCH] amd/common: fix ASICREV_IS_POLARIS11_M for Polaris12

2017-02-28 Thread Dave Airlie
On 1 March 2017 at 06:09, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.0 Reviewed-by: Dave Airlie > --- > src/amd/common/amdgpu_id.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH] amd/common: fix ASICREV_IS_POLARIS11_M for Polaris12

2017-02-28 Thread Alex Deucher
On Tue, Feb 28, 2017 at 3:09 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.0 Reviewed-by: Alex Deucher > --- > src/amd/common/amdgpu_id.h | 2 +- > 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH] amd/common: fix ASICREV_IS_POLARIS11_M for Polaris12

2017-02-28 Thread Marek Olšák
From: Marek Olšák Cc: 17.0 --- src/amd/common/amdgpu_id.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/amdgpu_id.h b/src/amd/common/amdgpu_id.h index 1683a5a..1ecae1a 100644 ---

Re: [Mesa-dev] [PATCH 03/18] anv/cmd_buffer: Replace layout_to_hiz_usage()

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 11:35 AM, Nanley Chery wrote: > On Tue, Feb 28, 2017 at 08:16:43AM -0800, Jason Ekstrand wrote: > > On Tue, Feb 28, 2017 at 5:54 AM, Nanley Chery > wrote: > > > > > On Mon, Feb 27, 2017 at 08:41:56PM -0800, Jason Ekstrand

Re: [Mesa-dev] [PATCH 27/34] i965: Make CCS stride match kernel's expectations

2017-02-28 Thread Jason Ekstrand
On Mon, Feb 27, 2017 at 7:23 PM, Ben Widawsky wrote: > On 17-02-27 18:40:41, Jason Ekstrand wrote: > >> On Mon, Feb 27, 2017 at 5:38 PM, Jason Ekstrand >> wrote: >> >> On Mon, Feb 27, 2017 at 4:56 PM, Ben Widawsky wrote: >>> >>> On

Re: [Mesa-dev] [PATCH 03/18] anv/cmd_buffer: Replace layout_to_hiz_usage()

2017-02-28 Thread Nanley Chery
On Tue, Feb 28, 2017 at 08:16:43AM -0800, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 5:54 AM, Nanley Chery wrote: > > > On Mon, Feb 27, 2017 at 08:41:56PM -0800, Jason Ekstrand wrote: > > > On Feb 27, 2017 5:21 PM, "Nanley Chery" wrote: > > > >

Re: [Mesa-dev] problem on building vmwgfx

2017-02-28 Thread Sinclair Yeh
On Tue, Feb 28, 2017 at 04:41:48PM +, Eric Engestrom wrote: > > Looks like there are more issues than I thought. > I don't know this codebase at all, I just recognized the first error you > saw and knew how to fix it. > > For more in-depth help, I suggest asking Sinclair or Thomas (both

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-28 Thread Marek Olšák
On Tue, Feb 28, 2017 at 6:37 PM, Roland Scheidegger wrote: > Am 28.02.2017 um 17:11 schrieb Jose Fonseca: >> On 20/02/17 20:28, Roland Scheidegger wrote: >>> Am 20.02.2017 um 20:56 schrieb Marek Olšák: On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote:

Re: [Mesa-dev] [PATCH] vulkan: provide vk.xml as argument to the python generator

2017-02-28 Thread Jason Ekstrand
Thanks! Reviewed-by: Jason Ekstrand On Tue, Feb 28, 2017 at 10:56 AM, Emil Velikov wrote: > From: Emil Velikov > > Do not hardcode the file in the python script, but pass it via the build > system(s). The former is

Re: [Mesa-dev] [PATCH 02/18] anv/image: Add anv_layout_to_aux_usage()

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 10:53 AM, Nanley Chery wrote: > On Tue, Feb 28, 2017 at 10:38:12AM -0800, Jason Ekstrand wrote: > > On Tue, Feb 28, 2017 at 10:32 AM, Nanley Chery > > wrote: > > > > > On Tue, Feb 28, 2017 at 08:26:56AM -0800, Jason Ekstrand

[Mesa-dev] [PATCH] vulkan: provide vk.xml as argument to the python generator

2017-02-28 Thread Emil Velikov
From: Emil Velikov Do not hardcode the file in the python script, but pass it via the build system(s). The former is the only one that should know about the file locaiton/tree structure. Cc: Dylan Baker Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 7/7] anv: Implement VK_KHX_external_memory_fd (v2)

2017-02-28 Thread Chad Versace
From: Jason Ekstrand v2 (chadv): - Rebase. - Fix vkGetPhysicalDeviceImageFormatProperties2KHR when handleType == 0. - Move handleType-independency comments out of handleType-switch, in vkGetPhysicalDeviceExternalBufferPropertiesKHX. Reduces diff in

[Mesa-dev] [PATCH 5/7] anv: Implement VK_KHX_external_memory_capabilities (v2)

2017-02-28 Thread Chad Versace
This is a complete but trivial implementation. It's trivial becasue We support no external memory capabilities yet. Most of the real work in this commit is in reworking the UUIDs advertised by the driver. v2 (chadv): - Fix chain traversal in vkGetPhysicalDeviceImageFormatProperties2KHR.

Re: [Mesa-dev] [PATCH 02/18] anv/image: Add anv_layout_to_aux_usage()

2017-02-28 Thread Nanley Chery
On Tue, Feb 28, 2017 at 10:38:12AM -0800, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 10:32 AM, Nanley Chery > wrote: > > > On Tue, Feb 28, 2017 at 08:26:56AM -0800, Jason Ekstrand wrote: > > > On Mon, Feb 27, 2017 at 5:20 PM, Nanley Chery > >

Re: [Mesa-dev] [PATCH 02/18] anv/image: Add anv_layout_to_aux_usage()

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 10:32 AM, Nanley Chery wrote: > On Tue, Feb 28, 2017 at 08:26:56AM -0800, Jason Ekstrand wrote: > > On Mon, Feb 27, 2017 at 5:20 PM, Nanley Chery > wrote: > > > > > This function supersedes layout_to_hiz_usage(). > > > > > >

Re: [Mesa-dev] [PATCH 02/18] anv/image: Add anv_layout_to_aux_usage()

2017-02-28 Thread Nanley Chery
On Tue, Feb 28, 2017 at 08:26:56AM -0800, Jason Ekstrand wrote: > On Mon, Feb 27, 2017 at 5:20 PM, Nanley Chery wrote: > > > This function supersedes layout_to_hiz_usage(). > > > > Signed-off-by: Nanley Chery > > --- > >

Re: [Mesa-dev] [PATCH 04/18] anv: Update the HiZ sampling helper

2017-02-28 Thread Nanley Chery
On Tue, Feb 28, 2017 at 09:33:26AM -0800, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 9:29 AM, Nanley Chery wrote: > > > On Tue, Feb 28, 2017 at 08:07:35AM -0800, Jason Ekstrand wrote: > > > On Tue, Feb 28, 2017 at 8:02 AM, Nanley Chery > >

Re: [Mesa-dev] [PATCH] android: vulkan: add support for libmesa_vulkan_{util, wsi}

2017-02-28 Thread Emil Velikov
On 28 February 2017 at 16:05, Eric Engestrom wrote: >> > The quick and dirty fix is to add a rule forcing the serialisation, like >> > this: >> > util/vk_enum_to_str.c: util/vk_enum_to_str.h >> > This fixes the race condition, but still writes both files twice for no

[Mesa-dev] [Bug 99849] Dashed lines (drawn via GLAMOR) are not rendered correctly

2017-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99849 Roland Scheidegger changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 6/7] anv: Implement VK_KHX_external_memory

2017-02-28 Thread Chad Versace
On Mon 27 Feb 2017, Jason Ekstrand wrote: > There's really nothing for us to do here. So long as the user doesn't > set any crazy environment variables such as INTEL_VK_HIZ=false, all of > the compression formats etc. should "just work" at least for opaque > handle types. > --- >

[Mesa-dev] [Bug 99849] Dashed lines (drawn via GLAMOR) are not rendered correctly

2017-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99849 --- Comment #6 from Roland Scheidegger --- FWIW I've actually captured a replay and when playing back on a nvidia blob, it doesn't show a dashed line neither (just solid). I'm inclined to believe this is a glamor bug. The

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-28 Thread Roland Scheidegger
Am 28.02.2017 um 17:11 schrieb Jose Fonseca: > On 20/02/17 20:28, Roland Scheidegger wrote: >> Am 20.02.2017 um 20:56 schrieb Marek Olšák: >>> On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote: On 20/02/2017 20:11, Ilia Mirkin wrote: > > On Mon, Feb 20, 2017 at 2:01

Re: [Mesa-dev] [PATCH 9/9] anv: Implement support for exporting semaphores as FENCE_FD

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 9:25 AM, Chris Wilson wrote: > On Tue, Feb 28, 2017 at 08:56:47AM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_batch_chain.c | 91 ++ > ++-- > > src/intel/vulkan/anv_device.c | 26 +++

Re: [Mesa-dev] [PATCH 13/18] anv/pass: Store subpass attachment reference list

2017-02-28 Thread Nanley Chery
On Tue, Feb 28, 2017 at 09:28:15AM -0800, Jason Ekstrand wrote: > On Tue, Feb 28, 2017 at 8:48 AM, Nanley Chery wrote: > > > On Mon, Feb 27, 2017 at 09:22:13PM -0800, Jason Ekstrand wrote: > > > On Feb 27, 2017 5:21 PM, "Nanley Chery" wrote: > > > >

Re: [Mesa-dev] [PATCH 04/18] anv: Update the HiZ sampling helper

2017-02-28 Thread Jason Ekstrand
On Tue, Feb 28, 2017 at 9:29 AM, Nanley Chery wrote: > On Tue, Feb 28, 2017 at 08:07:35AM -0800, Jason Ekstrand wrote: > > On Tue, Feb 28, 2017 at 8:02 AM, Nanley Chery > wrote: > > > > > On Mon, Feb 27, 2017 at 08:48:48PM -0800, Jason Ekstrand

  1   2   >