Re: [Mesa-dev] [PATCH 14/14] anv: Implement VK_ANDROID_native_buffer (v8)

I will review these eventually On September 27, 2017 8:14:25 PM Chad Versace wrote: This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync

Re: [Mesa-dev] XDC 2017 feedback

On 09/27/2017 10:07 PM, Rob Clark wrote: > On Wed, Sep 27, 2017 at 10:49 PM, Ian Romanick wrote: >> On 09/27/2017 04:55 PM, Rob Clark wrote: >>> On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: On 09/26/2017 09:57 AM, Daniel Vetter wrote:

Re: [Mesa-dev] XDC 2017 feedback

On Thu, Sep 28, 2017 at 7:36 AM, Matt Turner wrote: > On Wed, Sep 27, 2017 at 10:07 PM, Rob Clark wrote: >> If you had known of the khr dates, and brought it up in Feb (or really >> somewhat earlier, given that XDC is roughly same time each year +/- >>

Re: [Mesa-dev] [PATCH] meson: remove duplicate libisl dependency in anv

Reviewed-by: Tapani Pälli On 09/28/2017 02:26 AM, Dylan Baker wrote: Signed-off-by: Dylan Baker CC: Kristian Høgsberg --- src/intel/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] XDC 2017 feedback

On Wed, Sep 27, 2017 at 10:07 PM, Rob Clark wrote: > If you had known of the khr dates, and brought it up in Feb (or really > somewhat earlier, given that XDC is roughly same time each year +/- > few weeks), that *might* have been early enough to move things. That's unfair.

Re: [Mesa-dev] XDC 2017 feedback

On Wed, Sep 27, 2017 at 10:49 PM, Ian Romanick wrote: > On 09/27/2017 04:55 PM, Rob Clark wrote: >> On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: >>> On 09/26/2017 09:57 AM, Daniel Vetter wrote: Hi all, First again big thanks to

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

On Wednesday, September 27, 2017 8:39:27 AM PDT Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/texstate.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c > index

[Mesa-dev] [PATCH 14/14] anv: Implement VK_ANDROID_native_buffer (v8)

This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then puts the

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

On 09/27/2017 05:06 PM, Marek Olšák wrote: > It fixes a crash with an apitrace that I have. Other than that, no > tests. Yes, it should be tagged for stable. Ok. Adding a test would be cool, but I won't bust your chops. :) Reviewed-by: Ian Romanick > Marek > > On

Re: [Mesa-dev] XDC 2017 feedback

On 09/27/2017 04:55 PM, Rob Clark wrote: > On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: >> On 09/26/2017 09:57 AM, Daniel Vetter wrote: >>> Hi all, >>> >>> First again big thanks to Stéphane and Jennifer for organizing a great XDC. >>> >>> Like last year we'd like to

[Mesa-dev] [PATCH] anv: Implement VK_ANDROID_native_buffer (v7)

This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then puts the

[Mesa-dev] [PATCH] gallium: add new LOD opcode

From: Roland Scheidegger The operation performed is all the same as LODQ, but with the usual differences between dx10 and GL texture opcodes, that is separate resource and sampler indices (plus result swizzling, and setting z/w channels to zero). ---

Re: [Mesa-dev] [PATCH] anv: Remove base_vertex/instance from push_constants

Reviewed-by: Lionel Landwerlin On 28/09/17 01:02, Jason Ekstrand wrote: This is just legacy cruft. We don't push these values; we pass them in as vertex attributes. --- src/intel/vulkan/anv_private.h | 7 --- 1 file changed, 7 deletions(-) diff --git

[Mesa-dev] [PATCH 10/14] anv: Move close(fd) from anv_bo_cache_import to its callers

This will allow us to implement VK_ANDROID_native_buffer without dup'ing the fd. We must close the fd in VK_KHR_external_memory_fd, but we should not in VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_allocator.c | 12 src/intel/vulkan/anv_device.c| 11 +++

[Mesa-dev] [PATCH 14/14] anv: Install as Vulkan HAL module in Android.mk build

From: Tapani Pälli Now that anvil fully implements the Vulkan HAL interface, we can install it as the vendor HAL module at /vendor/lib/hw/vulkan.${board}.so. To do so: - Rename LOCAL_MODULE to vulkan.$(TARGET_BOARD_PLATFORM). - Use LOCAL_PROPRIETARY_MODULE to install

[Mesa-dev] [PATCH 13/14] anv: Implement VK_ANDROID_native_buffer (v6)

This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then puts the

[Mesa-dev] [PATCH 11/14] anv: Add sizeless anv_bo_cache_import()

The patch renames anv_bo_cache_import() to anv_bo_cache_import_with_size(); and adds a new variant, anv_bo_cache_import(), that lacks the 'size' parameter. Same as pre-patch, anv_bo_cache_import_with_size() continues to validate the imported size. The patch is essentially a refactor patch. It

[Mesa-dev] [PATCH 09/14] anv: Add field anv_image::bo_is_owned

If this flag is set, then the image and it's bo have the same lifetime. vkDestroyImage will release the bo. We need this for VK_ANDROID_native_buffer, because that extension creates the VkImage and imports its memory in the same call, vkCreateImage. --- src/intel/vulkan/anv_image.c | 9

[Mesa-dev] [PATCH 07/14] anv/image: Refactor how tiling is chosen (v2)

The code that restricts the VkImage's tiling flags, extract it into a new function named choose_isl_tiling_flags(). This reduces the diff in upcoming patches for VK_ANDROID_native_buffer. v2: - Rebase onto 'needs_shadow' changes on master. - Assert that choose_isl_tiling_flags() chooses at

[Mesa-dev] [PATCH 12/14] anv: Add func anv_gem_get_tiling()

Will use in VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_gem.c | 16 src/intel/vulkan/anv_private.h | 1 + 2 files changed, 17 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index 3994c6b66c2..34c09891086 100644 ---

[Mesa-dev] [PATCH 06/14] anv/image: Better var names for image-create-info structs

Upcoming patches teach vkCreateImage to understand VkNativeBufferANDROID. And much later patches will do the same for whatever VkImageCreateInfo-chained struct imports dma-bufs. And then again for the struct that will be introduced by the inevitable extension VK_ANDROID_external_memory_whatever.

[Mesa-dev] [PATCH 04/14] intel: Add simple logging façade for Android

I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). On Android, stdio goes to /dev/null. On Android, remote gdb is even more painful than the usual remote gdb. On Android, nothing works like you expect and debugging is hell. I need logging. This patch introduces a small, simple

[Mesa-dev] [PATCH 03/14] intel: Move definition of LOG_TAG from header into Makefiles

This patch prevents compilation failures in upcoming Android Vulkan patches, failures due to redefinition of LOG_TAG in Android system headers. This patch does not change the value of LOG_TAG. It remains "INTEL-MESA". (I don't like it, though. The all-caps smells like FORTRAN). Only one Intel

[Mesa-dev] [PATCH 01/14] anv/android: Link to Android libraries in the autotools build

A first step to supporting Vulkan on ARC++. Mesa on ARC++ uses Autotools, not Android.mk. Doing this now, even before VK_ANDROID_native_buffer is implemented, allows us to incrementally add Android support to the Autotools build. --- src/intel/Makefile.vulkan.am | 5 + 1 file changed, 5

[Mesa-dev] [PATCH 00/14] anv: Implement VK_ANDROID_native_buffer (v3)

This series adds Android support to Anvil. And Android requires VK_ANDROID_native_buffer. I tested the series on 64-bit ARC++ on a Skylake Chromebook with a 3.18 kernel. (ARC++ is the Android container in Chrome OS). (Yes, I said 3.18. That's not a typo). Here's my test results: - A little,

[Mesa-dev] [PATCH 02/14] anv/android: Link to libsync, liblog in Android.mk

From: Tapani Pälli chadv: I made this patch by extracting the hunk from Tapani's patch in https://lists.freedesktop.org/archives/mesa-dev/2017-September/169602.html. Signed-off-by: Chad Versace --- src/intel/Android.vulkan.mk | 2 +- 1 file

[Mesa-dev] [PATCH 08/14] anv/image: Refactor creation of aux surfaces (v2)

Creation of hiz, ccs, and mcs surfaces was encoded in a large, deep 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into one function per aux type: try_make_hiz_surface() try_make_ccs_surface() try_make_mcs_surface() For clarity, also rename make_surface()

[Mesa-dev] [PATCH 05/14] anv: Better support for Android logging (v2)

In src/intel/vulkan/*, redirect all instances of printf, vk_error, anv_loge, anv_debug, anv_finishme, anv_perf_warn, anv_assert, and their many variants to the new intel_log functions. I believe I caught them all. The other subdirs of src/intel are left for a future exercise. v2: - Rebase onto

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

It fixes a crash with an apitrace that I have. Other than that, no tests. Yes, it should be tagged for stable. Marek On Thu, Sep 28, 2017 at 1:34 AM, Ian Romanick wrote: > This looks right... at least it makes ATI_fragment_shader behave like > ARB_fragment_program. I

[Mesa-dev] [PATCH] anv: Remove base_vertex/instance from push_constants

This is just legacy cruft. We don't push these values; we pass them in as vertex attributes. --- src/intel/vulkan/anv_private.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 3ba623a..b58c803 100644 ---

Re: [Mesa-dev] XDC 2017 feedback

On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: > On 09/26/2017 09:57 AM, Daniel Vetter wrote: >> Hi all, >> >> First again big thanks to Stéphane and Jennifer for organizing a great XDC. >> >> Like last year we'd like to hear feedback on how this year's XDC went, >>

Re: [Mesa-dev] XDC 2017 feedback

It was a great time! Next year I should pay more attention that this was happening so I don't sign up at the last moment causing me to miss a day, and having a fever on the last day. Looking forward to next year's! On Wed, Sep 27, 2017 at 4:25 PM, Ian Romanick wrote: > On

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

This looks right... at least it makes ATI_fragment_shader behave like ARB_fragment_program. I don't suppose there are any tests that exercise this problem? Should this be tagged for stable? On 09/27/2017 08:39 AM, Marek Olšák wrote: > From: Marek Olšák > > --- >

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

Boris Brezillon writes: > On Wed, 27 Sep 2017 12:41:52 -0700 > Eric Anholt wrote: > >> Boris Brezillon writes: >> >> > On Wed, 27 Sep 2017 10:15:23 -0700 >> > Eric Anholt wrote: >> >

[Mesa-dev] [PATCH] meson: remove duplicate libisl dependency in anv

Signed-off-by: Dylan Baker CC: Kristian Høgsberg --- src/intel/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build index 9f0ee558e8a..a0be95c747c 100644

Re: [Mesa-dev] XDC 2017 feedback

On 09/26/2017 09:57 AM, Daniel Vetter wrote: > Hi all, > > First again big thanks to Stéphane and Jennifer for organizing a great XDC. > > Like last year we'd like to hear feedback on how this year's XDC went, > both the good (and what you'd like to see more of) and the not so > good. Talk

Re: [Mesa-dev] [PATCH] radv: set image view type when decompressing depth surfaces

Reviewed-by: Bas Nieuwenhuizen On Wed, Sep 27, 2017 at 2:09 PM, Samuel Pitoiset wrote: > This was missing. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_decompress.c | 1 + > 1 file changed,

[Mesa-dev] [PATCH] radv: set image view type when decompressing depth surfaces

This was missing. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_decompress.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_meta_decompress.c b/src/amd/vulkan/radv_meta_decompress.c index 4ff4e41ea7..fedcfad3ae 100644 ---

Re: [Mesa-dev] [PATCH] util: fix in-class initialization of static member

On Wed, Sep 27, 2017 at 12:36 PM, Thomas Helland wrote: > string_buffer_test.cpp:43: error: ISO C++ forbids initialization of > member ‘str1’ > string_buffer_test.cpp:43: error: making ‘str1’ static > string_buffer_test.cpp:43: error: invalid in-class initialization of

Re: [Mesa-dev] [PATCH 2/2] wayland-drm: constify the callbacks struct, take 2

On 2017-09-27 01:49 PM, Emil Velikov wrote: From: Emil Velikov Now that wayland-drm (correctly) keeps a local copy of the callbacks, this should not longer cause explosions. After all the symbol is a local, constant data. Cc: Daniel Stone

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

On Wed, 27 Sep 2017 22:03:15 +0200 Boris Brezillon wrote: > On Wed, 27 Sep 2017 12:41:52 -0700 > Eric Anholt wrote: > > > Boris Brezillon writes: > > > > > On Wed, 27 Sep 2017 10:15:23 -0700 > > > Eric

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

On Wed, 27 Sep 2017 12:41:52 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > On Wed, 27 Sep 2017 10:15:23 -0700 > > Eric Anholt wrote: > > > >> Boris Brezillon writes: > >>

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

Marek Olšák wrote: Sorry too late, I pushed it. I don't know if stable is affected. It regresses things starting on radeonsi using weston eg. mpv - [vo/opengl/wayland] error occurred on the display fd: closing file descriptor kodi - terminate called after throwing an instance of

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

Boris Brezillon writes: > On Wed, 27 Sep 2017 10:15:23 -0700 > Eric Anholt wrote: > >> Boris Brezillon writes: >> >> > On Wed, 27 Sep 2017 15:24:16 +0100 >> > Chris Wilson

[Mesa-dev] [PATCH] util: fix in-class initialization of static member

string_buffer_test.cpp:43: error: ISO C++ forbids initialization of member ‘str1’ string_buffer_test.cpp:43: error: making ‘str1’ static string_buffer_test.cpp:43: error: invalid in-class initialization of static data member of non-integral type ‘const char*’ Bugzilla:

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

On Wed, 2017-09-27 at 18:09 +0100, Emil Velikov wrote: > On 27 September 2017 at 17:28, Marek Olšák wrote: > > On Wed, Sep 27, 2017 at 6:22 PM, Emil Velikov > > wrote: > > > On 27 September 2017 at 16:00, Daniel Stone wrote: > >

Re: [Mesa-dev] [PATCH] i965/fs: force pull model for 64-bit GS inputs

On Wednesday, September 27, 2017 5:21:49 AM PDT Iago Toral Quiroga wrote: > Triggering the push model when 64-bit inputs are involved is not easy due to > the constrains on the maximum number of registers that we allow for this mode, > however, for GS with 'points' primitive type and just a couple

Re: [Mesa-dev] [PATCH] amd/addrlib: Rename the GB_ADDR_CONFIGs to GB_ADDR_CONFIG_{SI, GFX9}

On 09/27/2017 11:53 AM, Nicolai Hähnle wrote: > On 27.09.2017 20:42, Nicholas Miell wrote: >> Giving the same name to two different types violates the C++ One >> Definition >> Rule and gcc will complain about it in LTO builds. > > Oh my. What does the gcc warning look like? (I assume it's just a

Re: [Mesa-dev] [PATCH] amd/addrlib: Rename the GB_ADDR_CONFIGs to GB_ADDR_CONFIG_{SI, GFX9}

On 27.09.2017 20:42, Nicholas Miell wrote: Giving the same name to two different types violates the C++ One Definition Rule and gcc will complain about it in LTO builds. Oh my. What does the gcc warning look like? (I assume it's just a warning.) Since these are auto-generated headers which

[Mesa-dev] [PATCH 2/2] wayland-drm: constify the callbacks struct, take 2

From: Emil Velikov Now that wayland-drm (correctly) keeps a local copy of the callbacks, this should not longer cause explosions. After all the symbol is a local, constant data. Cc: Daniel Stone Cc: Derek Foreman

[Mesa-dev] [PATCH 1/2] wayland-drm: use a copy of the wayland_drm_callbacks struct

From: Emil Velikov The callbacks may be called even when they are no longer valid. Say, the user is dlclose(ing) libEGL while the buffers are being destroyed. Cc: Daniel Stone Cc: Derek Foreman Cc:

Re: [Mesa-dev] [PATCH v2] egl/dri: link directly to libglapi.so

On Wed, Sep 27, 2017 at 11:36 AM, Emil Velikov wrote: > From: Emil Velikov > > Shared glapi (libglapi.so) has been a requirement for years, in order > to build EGL. > > Remove the no longer necessary dlopen/dlsym dance and link to the >

[Mesa-dev] [Bug 102980] weston crashes with egl use since wayland-drm: constify the callbacks struct

https://bugs.freedesktop.org/show_bug.cgi?id=102980 Andy Furniss changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH] amd/addrlib: Rename the GB_ADDR_CONFIGs to GB_ADDR_CONFIG_{SI, GFX9}

Giving the same name to two different types violates the C++ One Definition Rule and gcc will complain about it in LTO builds. Signed-off-by: Nicholas Miell --- src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +- src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h | 2 +-

Re: [Mesa-dev] feature levels in clover (was: Re: [PATCH 2/2] clover: Query and export int64 atomics)

Jan Vesely writes: > On Tue, 2017-09-26 at 14:51 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Wed, 2017-09-20 at 19:10 -0500, Aaron Watry wrote: >> > > [SNIP] >> > > >> > > Not trying to rain on your parade, but I've been

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

On Wed, 27 Sep 2017 10:15:23 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > On Wed, 27 Sep 2017 15:24:16 +0100 > > Chris Wilson wrote: > > > >> Quoting Boris Brezillon (2017-09-27 15:06:53) > >> > On

Re: [Mesa-dev] [PATCH 00/13] i965: Align1 ternary instruction support for CNL

On Fri, Aug 25, 2017 at 6:25 PM, Matt Turner wrote: > Cannonlake (Gen10) adds align1 access mode to ternary instructions. In align1 > mode, instructions can use more (and mixed) datatypes and a single 16-bit > immediate value. This series adds the infrastructure to emit and

Re: [Mesa-dev] initial meson port

On Wed, Sep 27, 2017 at 12:38 PM, Eric Anholt wrote: > Dylan Baker writes: > >> [ Unknown signature status ] >> I've gone ahead and pushed the Vulkan drivers meson builds. >> >> For those interested in helping finish the conversion, I have a branch >>

[Mesa-dev] [PATCH v2] broadcom: Fix out-of-tree build include path

Cc: Eric Anholt Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.") --- src/broadcom/Makefile.cle.am| 4 +++- src/gallium/drivers/vc4/Makefile.am | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/broadcom/Makefile.cle.am

Re: [Mesa-dev] initial meson port

Dylan Baker writes: > [ Unknown signature status ] > I've gone ahead and pushed the Vulkan drivers meson builds. > > For those interested in helping finish the conversion, I have a branch > "wip/meson-4" on my github (github.com/dcbaker/mesa) that has i965 and most of > the

Re: [Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

On 09/27/2017 11:18 AM, Nicolai Hähnle wrote: Didn't you send this already? It looks familiar, even in the v2. Yeah, but I neglected to cc my coworkers. Anyway, both patches: Reviewed-by: Nicolai Hähnle Thanks! -Brian On 27.09.2017 16:01, Brian Paul wrote:

[Mesa-dev] [AppVeyor] mesa master #5633 completed

Build mesa 5633 completed Commit a8fd58eae5 by Eric Anholt on 5/12/2017 11:05 PM: vc4: Add labels to BOs for debug builds or with VC4_DEBUG=surf set.\n\nThis has proven to be incredibly useful for debugging CMA allocation\nfailures and driving memory

Re: [Mesa-dev] XDC 2017 feedback

Hi, In general, I think the organization was great. I agree having everything happen in a single room was a good point. Here's some of my personal feedback: * I didn't like the tables layout at all. I found it to be extremely uncomfortable to have to look sideways in order to see the screens

[Mesa-dev] [PATCH] broadcom: Fix out-of-tree build include path

Cc: Eric Anholt Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.") --- src/broadcom/Makefile.cle.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/broadcom/Makefile.cle.am b/src/broadcom/Makefile.cle.am index

Re: [Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

Didn't you send this already? It looks familiar, even in the v2. Anyway, both patches: Reviewed-by: Nicolai Hähnle On 27.09.2017 16:01, Brian Paul wrote: --- src/gallium/auxiliary/util/u_log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

Boris Brezillon writes: > On Wed, 27 Sep 2017 15:24:16 +0100 > Chris Wilson wrote: > >> Quoting Boris Brezillon (2017-09-27 15:06:53) >> > On Wed, 27 Sep 2017 14:50:10 +0100 >> > Chris Wilson wrote: >> >

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

On 27 September 2017 at 17:28, Marek Olšák wrote: > On Wed, Sep 27, 2017 at 6:22 PM, Emil Velikov > wrote: >> On 27 September 2017 at 16:00, Daniel Stone wrote: >>> Hi Marek, >>> >>> On 27 September 2017 at 15:55, Marek Olšák

Re: [Mesa-dev] feature levels in clover (was: Re: [PATCH 2/2] clover: Query and export int64 atomics)

On Tue, 2017-09-26 at 14:51 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Wed, 2017-09-20 at 19:10 -0500, Aaron Watry wrote: > > > [SNIP] > > > > > > Not trying to rain on your parade, but I've been thinking that we > > > might need to be able to query the

Re: [Mesa-dev] initial meson port

I've gone ahead and pushed the Vulkan drivers meson builds. For those interested in helping finish the conversion, I have a branch "wip/meson-4" on my github (github.com/dcbaker/mesa) that has i965 and most of the core classic mesa stack building. I'm working on GLX, then EGL to start testing

[Mesa-dev] [PATCH] anv: fix push descriptors with set > 0

When writing to set > 0, we were just wrongly writing to set 0. This commit fixes this by allocating each set from the dynamic state stream as we write to them. Cc: "17.2 17.1" Fixes: 9f60ed98e501 ("anv: add VK_KHR_push_descriptor support") Reported-by: Daniel

Re: [Mesa-dev] [PATCH 4/3] glsl: tidy up IR after loop unrolling

Reviewed-by: Marek Olšák Marek On Fri, Sep 22, 2017 at 1:49 AM, Timothy Arceri wrote: > c7affbf6875622a enabled GLSLOptimizeConservatively on some > drivers. The idea was to speed up compile times by running > the GLSL IR passes only once each time

[Mesa-dev] [AppVeyor] mesa wip/meson-4 #5632 failed

Build mesa 5632 failed Commit e48445a757 by Dylan Baker on 9/22/2017 7:55 PM: meson: build the loader Configure your notification preferences ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH v2] egl/dri: link directly to libglapi.so

From: Emil Velikov Shared glapi (libglapi.so) has been a requirement for years, in order to build EGL. Remove the no longer necessary dlopen/dlsym dance and link to the library directly. This allows us to remove a handful of platform specific workarounds, due to the

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

On Wed, Sep 27, 2017 at 6:22 PM, Emil Velikov wrote: > On 27 September 2017 at 16:00, Daniel Stone wrote: >> Hi Marek, >> >> On 27 September 2017 at 15:55, Marek Olšák wrote: >>> if (dmabuf_ret && dmabuf_ret->val.val_bool) {

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

On 27 September 2017 at 16:00, Daniel Stone wrote: > Hi Marek, > > On 27 September 2017 at 15:55, Marek Olšák wrote: >> if (dmabuf_ret && dmabuf_ret->val.val_bool) { >>uint64_t cap; >> >>if (drmGetCap(sPriv->fd, DRM_CAP_PRIME, ) == 0 &&

Re: [Mesa-dev] [PATCH] i965: Record the presence of the kernel scheduler

On Wed, 2017-09-27 at 16:18 +0100, Chris Wilson wrote: > Mention to the debug log if the kernel scheduler is enabled; and in > particular if it has preemption enabled. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Ben

Re: [Mesa-dev] [PATCH v4 2/4] util/ralloc: Don't define assert with magic member without DEBUG

Quoting Eric Engestrom (2017-09-27 04:10:37) > On Tuesday, 2017-09-26 23:38:11 +, Dylan Baker wrote: > > It is possible to have DEBUG disabled but asserts on (NDEBUG(, which > > parentheses typo > > other than that: > Reviewed-by: Eric Engestrom > > and I think

[Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

From: Marek Olšák --- src/mesa/main/texstate.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 269e291..edd2253 100644 --- a/src/mesa/main/texstate.c +++ b/src/mesa/main/texstate.c @@

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

On Wed, 2017-09-27 at 16:15 +0100, Emil Velikov wrote: > On 26 September 2017 at 18:08, Juan A. Suarez Romero > wrote: > > On Wed, 2017-09-06 at 15:07 +0100, Emil Velikov wrote: > > > On 5 August 2017 at 00:25, Emil Velikov wrote: > > > > From: Emil

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] egl/drm: set the VISUAL_TYPE alongside the VISUAL_ID

On Wed, 2017-09-27 at 16:13 +0100, Emil Velikov wrote: > Hi Juan, > > On 26 September 2017 at 18:00, Juan A. Suarez Romero > wrote: > > On Tue, 2017-08-22 at 09:20 +0100, Daniel Stone wrote: > > > Hi, > > > > > > On 21 August 2017 at 18:30, Emil Velikov

Re: [Mesa-dev] [PATCH 3/4] vulkan/wsi/wayland: Copy wl_proxy objects from oldSwapchain if available

On Wed, Sep 27, 2017 at 1:53 AM, Daniel Stone wrote: > Hi, > > On 26 September 2017 at 23:55, Jason Ekstrand > wrote: > > static void > > -wsi_wl_display_destroy(struct wsi_wl_display *display) > > +wsi_wl_display_ref(struct wsi_wl_display *display)

Re: [Mesa-dev] [PATCH 4/4] vulkan/wsi/wayland: Return better error messages

On Wed, Sep 27, 2017 at 1:55 AM, Daniel Stone wrote: > Good stuff; thanks for cleaning that up. Modulo my comments on 2 and > 3, the series is: > Reviewed-by: Daniel Stone > Thanks! ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix border color translation for integer textures

For the series: Tested-by: Dieter Nützel Dieter Am 26.09.2017 16:46, schrieb Nicolai Hähnle: From: Nicolai Hähnle This fixes the extremely unlikely case that an application uses 0x8000 or 0x3f80 as border color for an integer texture

Re: [Mesa-dev] [Mesa-stable] [PATCH 5/5] radeonsi/gfx9: fix geometry shaders without output vertices

For the series: Tested-by: Dieter Nützel Dieter Am 26.09.2017 16:43, schrieb Nicolai Hähnle: From: Nicolai Hähnle Not that those are super common or useful, but hey! Fun corner cases of the API... Fixes

Re: [Mesa-dev] [PATCH] glsl: do not set the 'smooth' qualifier by default on ES shaders

Tested-by: Dieter Nützel Dieter Am 26.09.2017 17:11, schrieb Nicolai Hähnle: From: Nicolai Hähnle It leads to surprising states with integer inputs and outputs on vertex processing stages (e.g. geometry stages). Instead, rely on the driver to

Re: [Mesa-dev] [PATCH 2/4] vulkan/wsi/wayland: Stop caching Wayland displays

On Wed, Sep 27, 2017 at 1:52 AM, Daniel Stone wrote: > Hi, > > On 26 September 2017 at 23:55, Jason Ekstrand > wrote: > > @@ -833,24 +816,19 @@ wsi_wl_surface_create_swapchain(VkIcdSurfaceBase > *icd_surface, > > chain->vk_format =

[Mesa-dev] [PATCH] i965: Record the presence of the kernel scheduler

Mention to the debug log if the kernel scheduler is enabled; and in particular if it has preemption enabled. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Ben Widawsky ---

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

On 26 September 2017 at 18:08, Juan A. Suarez Romero wrote: > On Wed, 2017-09-06 at 15:07 +0100, Emil Velikov wrote: >> On 5 August 2017 at 00:25, Emil Velikov wrote: >> > From: Emil Velikov >> > >> > As mentioned in

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] egl/drm: set the VISUAL_TYPE alongside the VISUAL_ID

Hi Juan, On 26 September 2017 at 18:00, Juan A. Suarez Romero wrote: > On Tue, 2017-08-22 at 09:20 +0100, Daniel Stone wrote: >> Hi, >> >> On 21 August 2017 at 18:30, Emil Velikov wrote: >> > On 21 August 2017 at 15:44, Daniel Stone

[Mesa-dev] [PATCH 2/2] gallium/util: use new util_vasprintf() function

--- src/gallium/auxiliary/util/u_log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_log.c b/src/gallium/auxiliary/util/u_log.c index 359b3e1..dacbe05 100644 --- a/src/gallium/auxiliary/util/u_log.c +++ b/src/gallium/auxiliary/util/u_log.c @@

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

Hi Marek, On 27 September 2017 at 15:55, Marek Olšák wrote: > if (dmabuf_ret && dmabuf_ret->val.val_bool) { >uint64_t cap; > >if (drmGetCap(sPriv->fd, DRM_CAP_PRIME, ) == 0 && >(cap & DRM_PRIME_CAP_IMPORT)) { >

[Mesa-dev] [PATCH 1/2] util: add util_vasprintf() for Windows (v2)

We don't have vasprintf() on Windows so we need to implement it ourselves. v2: compute actual length of output string, per Nicolai Hähnle. --- src/util/u_string.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/util/u_string.h b/src/util/u_string.h index

[Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

From: Marek Olšák This unbreaks waffle/gbm (piglit/gbm) which fails initialization. --- src/gallium/state_trackers/dri/dri2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri2.c

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

On Wed, 27 Sep 2017 15:24:16 +0100 Chris Wilson wrote: > Quoting Boris Brezillon (2017-09-27 15:06:53) > > On Wed, 27 Sep 2017 14:50:10 +0100 > > Chris Wilson wrote: > > > > > Quoting Boris Brezillon (2017-09-27 14:45:17) > > > > static

Re: [Mesa-dev] [PATCH 06/22] i965: Enable BatchbufferLogger in i965 driver

>My worry is that batch->bo is not constant for the construction of a single >execbuf2. > If intel_batchbuffer.c runs out of room inside the batch->bo, it will > allocate a new one and continue building it. That will be ok, but if the (fd, GEM BO handle) changes, there is a serious issue. >

Re: [Mesa-dev] [PATCH 06/22] i965: Enable BatchbufferLogger in i965 driver

Quoting Rogovin, Kevin (2017-09-27 15:22:00) > Hi, > > > Hmm, this needs updating for the batch/state split; > > This was rebased (and working) against Mesa of Monday, Sept 25, 2017, which I > thought already had the batchbuffer split. I had thought the split was > already in master... but

Re: [Mesa-dev] [PATCH mesa 1/6] egl_dri2: move glFlush out of struct dri2_egl_driver

On 26 September 2017 at 23:47, Eric Engestrom wrote: > There's no reason to store this there, it doesn't depend on the driver. > > Signed-off-by: Eric Engestrom > --- > src/egl/drivers/dri2/egl_dri2.c | 44 > ++--- >

Re: [Mesa-dev] [PATCH] egl/wayland: Make wayland_drm_init declaration match the implementation

Hi, On 27 September 2017 at 14:56, Emil Velikov wrote: > On 26 September 2017 at 21:51, Daniel Stone wrote: >> The wayland-drm callback struct is referenced, rather than duplicated, >> inside wayland-drm. Constifying this struct involved

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

Quoting Boris Brezillon (2017-09-27 15:06:53) > On Wed, 27 Sep 2017 14:50:10 +0100 > Chris Wilson wrote: > > > Quoting Boris Brezillon (2017-09-27 14:45:17) > > > static struct vc4_bo * > > > vc4_bo_from_cache(struct vc4_screen *screen, uint32_t size, const char > >

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

On Wed, Sep 27, 2017 at 11:06 PM, Emil Velikov wrote: > On 25 September 2017 at 08:25, Tomasz Figa wrote: > >> Gentle ping. :) >> > > I forgot that you don't have commit access. Can you please apply for one? Yep, I have it on my list, sorry for

  1   2   >