[Mesa-dev] [PATCH 10/21] intel/isl: Use ISL_DIM_LAYOUT_GEN9_1D for Yf/Ys

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index fcbe2ad..68a92b8 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -678,8 +678,10 @@ isl_surf_choose_dim_layout(const struct isl_device *dev,

[Mesa-dev] [PATCH 21/21] intel/isl: Enable Yf tiling

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl_gen7.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c index 4fa9851..2aa3916 100644 --- a/src/intel/isl/isl_gen7.c +++ b/src/intel/isl/isl_gen7.c @@ -205,7 +205,6 @@ isl_gen6_filter_tiling(const struct isl_device *dev,

[Mesa-dev] [PATCH 14/21] intel/isl: Pull the uncompressed surface view code from anv

2018-02-22 Thread Jason Ekstrand
This adds a helper isl_surf_get_uncompressed_surf for creating a surface which provides an uncompressed view into a compressed surface. The code is basically a direct port of the uncompressed surface code from the Vulkan driver which, in turn, was a port from BLORP. --- src/intel/isl/isl.c

[Mesa-dev] [PATCH 13/21] intel/isl: Support Yf/Ys in isl_surf_get_image_offset_sa

2018-02-22 Thread Jason Ekstrand
All that's really needed here is to handle the array offsetting by using an Z or array offset instead of the Y offset. --- src/intel/isl/isl.c | 45 ++--- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 15/21] intel/blorp: Use isl_surf_get_uncompressed_surf

2018-02-22 Thread Jason Ekstrand
--- src/intel/blorp/blorp_blit.c | 58 +--- 1 file changed, 17 insertions(+), 41 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 876498d..5b63754 100644 --- a/src/intel/blorp/blorp_blit.c +++

[Mesa-dev] [PATCH 19/21] intel/isl: Support Yf/Ys tiling in emit_depth_stencil_hiz

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl_emit_depth_stencil.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl_emit_depth_stencil.c b/src/intel/isl/isl_emit_depth_stencil.c index 90ce889..901f406 100644 --- a/src/intel/isl/isl_emit_depth_stencil.c +++

[Mesa-dev] [PATCH 12/21] intel/isl: Fill out the correct phys_total_extent for Ys/Yf

2018-02-22 Thread Jason Ekstrand
With these tilings, everything is aligned to a tile and the tiled surface size calculations will handle the array stride for us. We need to provide an accurate 4D size so that 3D and multisampled images get tiled correctly. --- src/intel/isl/isl.c | 51

[Mesa-dev] [PATCH 07/21] intel/isl: Take a dim and sample count in isl_tiling_get_info

2018-02-22 Thread Jason Ekstrand
The layout of Yf and Ys tiles are dependent on these parameters. --- src/intel/blorp/blorp_blit.c | 5 +++-- src/intel/isl/isl.c| 15 ++- src/intel/isl/isl.h| 8 ++-- src/mesa/drivers/dri/i965/intel_blit.c | 5 +++-- 4 files

[Mesa-dev] [PATCH 11/21] intel/isl: Use the depth field of phys_level0_sa for GEN4_2D 3D surfaces

2018-02-22 Thread Jason Ekstrand
This makes things a tiny bit stickier in isl_calc_phys_total_extent_el but will be worth it when we enable Yf and Ys. --- src/intel/isl/isl.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 68a92b8..d3efc76

[Mesa-dev] [PATCH 17/21] intel/isl: Don't compute image tiling data for Yf/Ys tiling

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl_storage_image.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/isl/isl_storage_image.c b/src/intel/isl/isl_storage_image.c index 0ae79a2..b0556c7 100644 --- a/src/intel/isl/isl_storage_image.c +++ b/src/intel/isl/isl_storage_image.c @@ -233,6

[Mesa-dev] [PATCH 16/21] intel/isl: Support Ys and Yf in isl_surf_get_uncompressed_surf

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 74e248d..f93db0c 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -2419,7 +2419,52 @@

[Mesa-dev] [PATCH 20/21] i965: Explicitly disable Yf and Ys tiling

2018-02-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 59dbfb9..978253a 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c +++

[Mesa-dev] [PATCH 09/21] intel/isl: Use the tile size for computing standard Y alignments

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl_gen9.c | 85 +--- 1 file changed, 9 insertions(+), 76 deletions(-) diff --git a/src/intel/isl/isl_gen9.c b/src/intel/isl/isl_gen9.c index e5d0f95..f9d391a 100644 --- a/src/intel/isl/isl_gen9.c +++ b/src/intel/isl/isl_gen9.c @@

[Mesa-dev] [PATCH 18/21] intel/isl: Support Yf/Ys tiling in surf_fill_state

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl_surface_state.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index bfb27fa..a1d5fc2 100644 --- a/src/intel/isl/isl_surface_state.c +++

[Mesa-dev] [PATCH 05/21] intel/isl: Use a 4D physical total extent for size calculations

2018-02-22 Thread Jason Ekstrand
With Yf and Ys tiling, everything is actually four dimensional because we can have multiple depth or multisampled array slices in the same tile. This commit just enhances the calculations so they can handle it. --- src/intel/isl/isl.c | 71 +++-- 1

[Mesa-dev] [PATCH 04/21] intel/isl: Make tile logical extents four dimensional

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 36 src/intel/isl/isl.h | 2 +- 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index cbe295b..5bdc726 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -160,7

[Mesa-dev] [PATCH 03/21] intel/isl: Make the offset helpers four dimensional

2018-02-22 Thread Jason Ekstrand
We need to do this in order to handle Yf and Ys tiling because they use a four-dimensional tile instead of laying everything out in two dimensions. --- src/intel/blorp/blorp_blit.c | 8 ++- src/intel/isl/isl.c| 60 ++

[Mesa-dev] [PATCH 08/21] intel/isl: Implement correct tile size calculations for Ys/Yf

2018-02-22 Thread Jason Ekstrand
The tile size calculations use a clever bit of math to make them short and simple. We add unit tests to assert that they identically match the tables in the PRM. --- src/intel/Makefile.isl.am | 9 +- src/intel/isl/isl.c | 56 ++-

[Mesa-dev] [PATCH 00/21] intel/isl: Add support for Yf and Ys tiling

2018-02-22 Thread Jason Ekstrand
This patch series adds support to ISL for Yf and Ys tiling on gen9+. It really didn't end up being as bad as I thought it would be. Most of the work was in massaging things to handle 4D logical tile sizes so that we can properly handle the more complex tiles. There was also a bit of bother

[Mesa-dev] [PATCH 06/21] intel/isl: Expose isl_tiling_get_info

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 7 +-- src/intel/isl/isl.h | 7 +++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 46aff46..95c1271 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -154,9 +154,11 @@

[Mesa-dev] [PATCH 02/21] intel/blorp: Use isl_surf_get_image_offset_B_tile_el in ccs_ambiguate

2018-02-22 Thread Jason Ekstrand
--- src/intel/blorp/blorp_clear.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index dde116f..2597f30 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp/blorp_clear.c @@ -976,12 +976,8 @@

[Mesa-dev] [PATCH 01/21] intel/isl: Add a isl_surf_get_image_offset_B_tile_el helper

2018-02-22 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 45 - src/intel/isl/isl.h | 20 2 files changed, 52 insertions(+), 13 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 1a32c02..bba7310 100644 --- a/src/intel/isl/isl.c +++

Re: [Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

2018-02-22 Thread Mathias Fröhlich
Hi Brian, On Thursday, 22 February 2018 23:32:23 CET Brian Paul wrote: > Just a few little nit-picks. With those fixed, the series is: > Reviewed-by: Brian Paul > > Nice work! Thanks! Thank you for the review! And is pushed now! best Mathias

[Mesa-dev] [PATCH] radeonsi/nir: enable lowering of fpow

2018-02-22 Thread Timothy Arceri
Lowering fpow in NIR rather than LLVM can be beneficial. Polaris results: Totals from affected shaders: SGPRS: 124928 -> 124896 (-0.03 %) VGPRS: 68616 -> 68332 (-0.41 %) Spilled SGPRs: 394 -> 413 (4.82 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0

[Mesa-dev] [PATCH] ac: make use of ac_get_llvm_num_components() helper

2018-02-22 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 50f3a4f69e..444107d14e 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@

[Mesa-dev] [PATCH v2] gallium/tgsi: remove is_msaa_sampler array from tgsi_shader_info

2018-02-22 Thread Timothy Arceri
Seems to have not been used since 16be87c90429 --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 6 -- src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 - 2 files changed, 7 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105208 Jens Petersen changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] gallium/tgsi: remove is_msaa_sampler array from tgsi_shader_info

2018-02-22 Thread Timothy Arceri
Seems to have not been used since 16be87c90429 --- src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.h b/src/gallium/auxiliary/tgsi/tgsi_scan.h index 0f872b0022..1887ff342d 100644 ---

[Mesa-dev] [PATCH] virgl: add offset alignment values to to v2 caps struct

2018-02-22 Thread Gurchetan Singh
From: "gurchetansi...@chromium.org" glBindBufferRange(..) in vrend_draw_bind_ubo is failing with more than one uniform block. This is due to improper alignment of the start of the second block. Let's query the proper alignment from the driver and pass it back to

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

2018-02-22 Thread Lionel Landwerlin
On 22/02/18 19:26, Emil Velikov wrote: Hi Lionel, On 9 February 2018 at 10:03, Lionel Landwerlin wrote: Fixes: 458468c136e "i965: Expose OA counters via INTEL_performance_query" Signed-off-by: Lionel Landwerlin Cc: "18.0"

[Mesa-dev] [PATCH 2/2] radeonsi/nir: fix loading of doubles for tess varyings

2018-02-22 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 2e398f6335..49db4d6367 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 1/2] radeonsi/nir: fix lds store in tcs outputs handling

2018-02-22 Thread Timothy Arceri
We were ignoring the channel offset. --- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 9ccae9f18d..2e398f6335 100644 ---

Re: [Mesa-dev] Adding a SPIR-V target to libclc

2018-02-22 Thread Francisco Jerez
Jan Vesely writes: > On Thu, 2018-02-15 at 22:50 -0800, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Thu, 2018-02-15 at 20:36 -0800, Francisco Jerez wrote: >> > > Jan Vesely writes: >> > > >> > > > On Thu,

Re: [Mesa-dev] [PATCH 05/17] intel/compiler: Add Gen11+ native float type

2018-02-22 Thread Kenneth Graunke
On Tuesday, February 20, 2018 9:15:12 PM PST Matt Turner wrote: > @@ -306,6 +312,7 @@ unsigned > brw_reg_type_to_size(enum brw_reg_type type) > { > static const unsigned type_size[] = { > + [BRW_REGISTER_TYPE_NF] = 8, This is a bit of a fib, given that NF is 66 bits, but...probably

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105211 --- Comment #4 from Dieter Nützel --- (In reply to Daniel Stone from comment #1) > Yes, sorry about this, the autotools build is quite funny with > wayland-protocols. > > At the moment, you can solve this by simply

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Ilia Mirkin
On Thu, Feb 22, 2018 at 7:41 PM, Ilia Mirkin wrote: > On Thu, Feb 22, 2018 at 7:39 PM, Emil Velikov > wrote: >> On 23 February 2018 at 00:17, Ilia Mirkin wrote: >>> On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov

[Mesa-dev] [PATCH] radv: Fix autotools build.

2018-02-22 Thread Bas Nieuwenhuizen
Somewhere along the way the Makefile changes got lost ... Fixes: 4db78f3a6b "radv: Put supported extensions in a struct." --- src/amd/vulkan/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am index

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Ilia Mirkin
On Thu, Feb 22, 2018 at 7:39 PM, Emil Velikov wrote: > On 23 February 2018 at 00:17, Ilia Mirkin wrote: >> On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov >> wrote: diff --git a/src/mesa/state_tracker/st_context.c

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Emil Velikov
On 23 February 2018 at 00:17, Ilia Mirkin wrote: > On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov > wrote: >> Hi Jordan, >> >> On 22 February 2018 at 19:59, Jordan Justen >> wrote: >>> The QT framework has a bug in

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

2018-02-22 Thread Roland Scheidegger
Am 22.02.2018 um 08:58 schrieb Alejandro Piñeiro: > On 30/01/18 01:24, Roland Scheidegger wrote: >> Am 29.01.2018 um 17:03 schrieb Alejandro Piñeiro: >>> On 29/01/18 16:38, Roland Scheidegger wrote: Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: > On 27/01/18 12:09, Roland Scheidegger

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-22 Thread Dieter Nützel
Am 22.02.2018 10:49, schrieb Daniel Stone: Hi Dieter, 2018-02-22 0:57 GMT+00:00 Dieter Nützel : Making all in vulkan make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten make[3]: *** Keine Regel vorhanden, um das Ziel

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Ilia Mirkin
On Thu, Feb 22, 2018 at 7:11 PM, Emil Velikov wrote: > Hi Jordan, > > On 22 February 2018 at 19:59, Jordan Justen wrote: >> The QT framework has a bug in their shader program cache, which is >> built on GL_ARB_get_program_binary. >> >> In an

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread Grazvydas Ignotas
Seems to fix dxvk, nice! Also tested DOOM which still works. Tested-by: Grazvydas Ignotas On Thu, Feb 22, 2018 at 6:57 PM, James Legg wrote: > When transitioning to an htile compressed depth format, Set the full > depth range, so later

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Emil Velikov
Hi Jordan, On 22 February 2018 at 19:59, Jordan Justen wrote: > The QT framework has a bug in their shader program cache, which is > built on GL_ARB_get_program_binary. > > In an effort to allow them to fix the bug we don't enable more than 1 > binary format for

[Mesa-dev] [PATCH] anv/allocator: Unconditionally call futex_wake

2018-02-22 Thread Jason Ekstrand
There is a potential race between the __sync_fetch_and_add and the futex_wake where another thread could come in and start waiting. If we hit this case, the other thread will never get woken back up because the futex_wake doesn't get called. We can fix this by calling futex_wake unconditionally.

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #3 from pritzl3...@gmail.com --- Created attachment 137546 --> https://bugs.freedesktop.org/attachment.cgi?id=137546=edit tracefile -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #2 from pritzl3...@gmail.com --- I'm not sure for how long this has been happening. Definitely for as long as I had my Vega, so at least since the middle of october. I almost always run the latest rc kernels and used to use Mesa from

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #8 from Darius Spitznagel --- Maybe this helps. Every "older" feral port has it's own "shader warmer". Disable it in the prefereces file in ~/.local/share/feral-interactive/AlienIsolation like below...

Re: [Mesa-dev] [PATCH 12/13] mesa: Use atomics for shared VAO reference counts.

2018-02-22 Thread Brian Paul
On 02/21/2018 10:45 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich VAOs will be used in the next change as immutable object across multiple contexts. Only reference counting may write concurrently on the VAO. So, make the reference count thread safe for

Re: [Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

2018-02-22 Thread Brian Paul
Just a few little nit-picks. With those fixed, the series is: Reviewed-by: Brian Paul Nice work! On 02/21/2018 10:45 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich During the patch series this VAO gets populated with either the

Re: [Mesa-dev] [PATCH 08/13] mesa: Make _mesa_vertex_attrib_binding public.

2018-02-22 Thread Brian Paul
On 02/21/2018 10:45 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Change vertex_attrib_binding() to _mesa_vertex_attrib_binding(), add a flush_vertices argument, and make it publically available. "publicly" -Brian The function will be needed later

Re: [Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread Bas Nieuwenhuizen
yeah, looks like I may have lifted the values from a driver which set the ZRANGE_PRECISION to 0, but this at least mirrors PAL and fixes one of the remaining transition issues there that I was aware of. Reviewed-by: Bas Nieuwenhuizen since IIRC the last change was also

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-22 Thread Andreas Boll
Reviewed-by: Andreas Boll 2018-02-21 21:09 GMT+01:00 Brian Paul : > v2: fix indentation, prefix with "4.3:" like other sections. > --- > src/xdemos/glinfo_common.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] glxinfo/wglinfo: fix indentation for listing compression formats

2018-02-22 Thread Andreas Boll
Reviewed-by: Andreas Boll 2018-02-21 21:09 GMT+01:00 Brian Paul : > And prefix with "GL_ARB_texture_compression:" like other sections. > --- > src/xdemos/glinfo_common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Scott D Phillips
Jordan Justen writes: > The QT framework has a bug in their shader program cache, which is > built on GL_ARB_get_program_binary. > > In an effort to allow them to fix the bug we don't enable more than 1 > binary format for compatibility profiles. > > This is only being

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-02-22 Thread Alex Deucher
On Thu, Feb 22, 2018 at 1:49 PM, Bas Nieuwenhuizen wrote: > On Thu, Feb 22, 2018 at 7:04 PM, Kristian Høgsberg > wrote: >> On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: >> >>> On Wed, Feb 21, 2018 at 1:14 AM, Chad

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105207 --- Comment #1 from Bas Nieuwenhuizen --- Curious, I haven't noticed that and that sounds really similar to my benchmarking setup. Not being able to reboot is a generic amdgpu problem after a hang. It happening for

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #7 from russianneuroman...@ya.ru --- > but apparently they are just compiled but not run, because the scene shows > visible artifacts that are not there when the compute shaders are enabled Does it looks like on screenshot in bug

Re: [Mesa-dev] [PATCH v4] anv/blorp: multisample resolve all attachment layers

2018-02-22 Thread Nanley Chery
On Thu, Feb 22, 2018 at 08:23:30AM +0100, Iago Toral wrote: > On Wed, 2018-02-21 at 09:58 -0800, Nanley Chery wrote: > > On Wed, Feb 21, 2018 at 09:18:49AM +0100, Iago Toral Quiroga wrote: > > > We were only resolving the first. > > > > > > v2: > > > - Do not require that the number of layers

[Mesa-dev] [PATCH 18.0 v2] i965, gallium: Disable ARB_get_program_binary for compat profiles

2018-02-22 Thread Jordan Justen
The QT framework has a bug in their shader program cache, which is built on GL_ARB_get_program_binary. In an effort to allow them to fix the bug we don't enable more than 1 binary format for compatibility profiles. This is only being done on the 18.0 release branch. Ref:

[Mesa-dev] [AppVeyor] mesa master #6992 completed

2018-02-22 Thread AppVeyor
Build mesa 6992 completed Commit d6b7539206 by Samuel Pitoiset on 2/5/2018 2:51 PM: ac/nir: remove emission of nir_op_fpow\n\nfpow is now lowered at NIR level.\n\nSigned-off-by: Samuel Pitoiset \nReviewed-by: Bas Nieuwenhuizen

[Mesa-dev] [AppVeyor] mesa master #6991 failed

2018-02-22 Thread AppVeyor
Build mesa 6991 failed Commit 7aa008d1d7 by Samuel Pitoiset on 2/2/2018 6:04 PM: radv: enable lowering of fpow to fexp2 and flog2\n\nThere is no fpow in hardware, so it's always lowered somewhere,\nbut it appears that lowering at NIR level is better. Figured

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

2018-02-22 Thread Emil Velikov
Hi Lionel, On 9 February 2018 at 10:03, Lionel Landwerlin wrote: > Fixes: 458468c136e "i965: Expose OA counters via INTEL_performance_query" > Signed-off-by: Lionel Landwerlin > Cc: "18.0" > --- >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] intel/compiler: Memory fence commit must always be enabled for gen10+

2018-02-22 Thread Emil Velikov
Hi Anuj, On 7 February 2018 at 01:09, Anuj Phogat wrote: > Commit bit in the message descriptor (Bit 13) must be always set > to true in CNL+ for memory fence messages. It also fixes a piglit > GPU hang on cnl+ in simulation environment. > Piglit test:

[Mesa-dev] [PATCH v3] anv: enable VK_EXT_shader_stencil_export

2018-02-22 Thread Gustavo Lima Chaves
v2: An attempt to support SpvExecutionModeStencilRefReplacingEXT's behavior also follows, with the interpretation to said mode being we prevent writes to the built-in FragStencilRefEXT variable when the execution mode isn't set. v3: A more cautious reading of

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-02-22 Thread Eric Anholt
Kristian Høgsberg writes: > On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: > >> On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace > wrote: >> > On Thu 21 Dec 2017, Daniel Vetter wrote: >> >> On Thu, Dec 21, 2017 at 12:22

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-02-22 Thread Francisco Jerez
Pierre Moreau writes: >> do we already have an upstream version of both dependencies we could >> just use? Or do we still need special branches? > > For both we can use the master branch of the upstream version. SPIRV-Tools > validator is still not perfect, but it does

Re: [Mesa-dev] [PATCH v3 14/21] clover/llvm: Allow translating from SPIR-V to LLVM IR

2018-02-22 Thread Francisco Jerez
Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > .../state_trackers/clover/llvm/invocation.cpp | 26 > ++ > .../state_trackers/clover/llvm/invocation.hpp | 4 >

Re: [Mesa-dev] [PATCH v3 06/21] clover/api: Rework the validation of devices for building

2018-02-22 Thread Francisco Jerez
Pierre Moreau writes: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/api/program.cpp | 39 > +- > src/gallium/state_trackers/clover/core/program.cpp | 3 +- > 2 files changed, 25 insertions(+), 17

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-02-22 Thread Bas Nieuwenhuizen
On Thu, Feb 22, 2018 at 7:04 PM, Kristian Høgsberg wrote: > On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: > >> On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace > wrote: >> > On Thu 21 Dec 2017, Daniel Vetter wrote: >> >>

[Mesa-dev] [PATCH v2 5/6] tegra: Initial support

2018-02-22 Thread Thierry Reding
Tegra K1 and later use a GPU that can be driven by the Nouveau driver. But the GPU is a pure render node and has no display engine, hence the scanout needs to happen on the Tegra display hardware. The GPU and the display engine each have a separate DRM device node exposed by the kernel. To make

[Mesa-dev] [PATCH v2 6/6] autotools: Add tegra to AM_DISTCHECK_CONFIGURE_FLAGS

2018-02-22 Thread Thierry Reding
From: Thierry Reding This allows the driver to be built on a make distcheck and makes sure that it properly builds when a distribution tarball is made. Suggested-by: Emil Velikov Signed-off-by: Thierry Reding --- Makefile.am

[Mesa-dev] [PATCH v2 3/6] nouveau/nvc0: Extract common tile mode macro

2018-02-22 Thread Thierry Reding
From: Thierry Reding Add a new macro that can be used to extract the tiling mode from a tile_mode value. This is will be used to determine the number of GOBs used in block linear mode. Acked-by: Emil Velikov Tested-by: Andre Heider

[Mesa-dev] [PATCH v2 4/6] nouveau: Add framebuffer modifier support

2018-02-22 Thread Thierry Reding
From: Thierry Reding This adds support for framebuffer modifiers to Nouveau. This will be used by the Tegra driver to share metadata about the format of buffers (such as the tiling mode or compression). Changes in v2: - remove unused parameters to nouveau_buffer_create() -

[Mesa-dev] [PATCH v2 1/6] drm/fourcc: Fix fourcc_mod_code() definition

2018-02-22 Thread Thierry Reding
From: Thierry Reding Avoid a compiler warnings when the val parameter is an expression. This is based on commit 5843f4e02fbe86a59981e35adc6cabebee46fdc0 from Linux v4.16-rc1. Acked-by: Emil Velikov Tested-by: Andre Heider

[Mesa-dev] [PATCH v2 2/6] drm/tegra: Sanitize format modifiers

2018-02-22 Thread Thierry Reding
From: Thierry Reding The existing format modifier definitions were merged prematurely, and recent work has unveiled that the definitions are suboptimal in several ways: - The format specifiers, except for one, are not Tegra specific, but the names don't reflect that.

[Mesa-dev] [PATCH v2 0/6] NVIDIA Tegra support

2018-02-22 Thread Thierry Reding
From: Thierry Reding This series of patches implements initial support for Tegra. The first two patches import DRM UAPI from v4.16-rc1 that provide framebuffer modifiers that can be used to specify buffers shared between Nouveau and the Tegra DRM driver. Patches 3 and 4 add

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105211 --- Comment #3 from Emil Velikov --- Daniel, let's opt for your earlier suggestion and stop shipping those generated sources. It's causing more problems than what it's worth. There was some fun when building/using the

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105211 --- Comment #2 from Alan Swanson --- No worries. But just to note that wayland-protocols does have a dependency on wayland-scanner from the main wayland build - or at least an autotools configure failure if not present

[Mesa-dev] [PATCH] fixup! tegra: Initial support

2018-02-22 Thread Thierry Reding
From: Thierry Reding --- configure.ac| 5 +++-- src/gallium/drivers/tegra/Makefile.am | 9 +--- src/gallium/drivers/tegra/Makefile.sources | 5 - src/gallium/drivers/tegra/tegra_context.c | 8 +++

[Mesa-dev] [PATCH] fixup! nouveau: Add framebuffer modifier support

2018-02-22 Thread Thierry Reding
From: Thierry Reding --- src/gallium/drivers/nouveau/nouveau_buffer.c | 3 +- src/gallium/drivers/nouveau/nouveau_buffer.h | 3 +- src/gallium/drivers/nouveau/nouveau_screen.c | 10 --- src/gallium/drivers/nouveau/nv30/nv30_resource.c | 4 +-

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-02-22 Thread Kristian Høgsberg
On Wed, Feb 21, 2018 at 4:00 PM Alex Deucher wrote: > On Wed, Feb 21, 2018 at 1:14 AM, Chad Versace wrote: > > On Thu 21 Dec 2017, Daniel Vetter wrote: > >> On Thu, Dec 21, 2017 at 12:22 AM, Kristian Kristensen < hoegsb...@google.com> wrote: >

Re: [Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

2018-02-22 Thread Roland Scheidegger
Looks great. Reviewed-by: Roland Scheidegger Am 22.02.2018 um 17:29 schrieb Jose Fonseca: > The MSVC version we (at VMware) primarily care about from now on is > 2015. > > We can drop support for building with 2013 in a future commit. I'm not > aware of significant changes

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

2018-02-22 Thread Emil Velikov
On 22 February 2018 at 17:36, Chuck Atkins wrote: >> > If there's a better way forward for having a minimal-dependency >> > software-only implementation, I'd certainly be willing to try it. At >> > the >> > moment though, gallium-xlib-glx is our path for that. >> > >> I

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105211 --- Comment #1 from Daniel Stone --- Yes, sorry about this, the autotools build is quite funny with wayland-protocols. At the moment, you can solve this by simply removing the linux-dmabuf lines from

Re: [Mesa-dev] [PATCH 0/4] i965: add support for performance queries on CNL

2018-02-22 Thread Emil Velikov
Hi Lionel, On 22 February 2018 at 17:24, Lionel Landwerlin wrote: > One of the patch is quite big so, unlikely to make it to the ml. You > can look at this series on my github : > > i965: add performance query support on CNL > Indeed patch 4/4 seems stuck.

Re: [Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

2018-02-22 Thread Emil Velikov
On 22 February 2018 at 17:25, Eric Engestrom wrote: > On Thursday, 2018-02-22 13:37:54 +, Frank Binns wrote: >> dri2_display_destroy() is called when platform specific display >> initialisation fails. However, this would typically lead to a >> segfault due to the

[Mesa-dev] [Bug 105211] build failure after zwp_dmabuf commit if wayland-protocols is not installed

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105211 Bug ID: 105211 Summary: build failure after zwp_dmabuf commit if wayland-protocols is not installed Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

2018-02-22 Thread Chuck Atkins
> > > If there's a better way forward for having a minimal-dependency > > software-only implementation, I'd certainly be willing to try it. At the > > moment though, gallium-xlib-glx is our path for that. > > > I was merely mentioning that the xlib-glx are in worse shape than the dri > one. > >

Re: [Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

2018-02-22 Thread Eric Engestrom
On Thursday, 2018-02-22 13:37:54 +, Frank Binns wrote: > dri2_display_destroy() is called when platform specific display > initialisation fails. However, this would typically lead to a > segfault due to the dri2_egl_display vbtl not having been set up. > > Fixes: 2db95482964

[Mesa-dev] [PATCH 0/4] i965: add support for performance queries on CNL

2018-02-22 Thread Lionel Landwerlin
Hi all, This series adds support for perf queries on CNL. It depends on a new kernel uAPI so I don't expect this to land just yet. The uAPI has received enough review this can be look after from the Mesa side. It's a bit verbose unfortunately because we have to support multiple ways to getting

[Mesa-dev] [PATCH 3/4] i965: perf: add support for new equation operators

2018-02-22 Thread Lionel Landwerlin
Some equations of the CNL metrics started to use operators we haven't defined yet, just add those. Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa.py | 15 +++ 1 file changed, 15 insertions(+) diff --git

[Mesa-dev] [PATCH 1/4] drm-uapi: bump headers

2018-02-22 Thread Lionel Landwerlin
This commit is meant to be replaced with a proper bump from drm-next. --- include/drm-uapi/i915_drm.h | 146 +++- 1 file changed, 145 insertions(+), 1 deletion(-) diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h index

[Mesa-dev] [PATCH 2/4] i965: perf: query topology

2018-02-22 Thread Lionel Landwerlin
With the introduction of asymmetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam to tell userspace what subslices are available. We introduce a new uAPI in the kernel driver to report exactly what part of the GPU are fused and require this to be available on Gen10+. Prior

Re: [Mesa-dev] [PATCH] intel: aubinator_error_decode: fix segfault on missing register

2018-02-22 Thread Kenneth Graunke
On Thursday, February 22, 2018 5:41:10 AM PST Lionel Landwerlin wrote: > Some register might be missing in our genxmls. Don't try to decode > them. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator_error_decode.c | 4 ++-- > 1 file changed, 2

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104553 Alejandro Piñeiro (freenode IRC: apinheiro) changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] radv: Really use correct HTILE expanded words.

2018-02-22 Thread James Legg
When transitioning to an htile compressed depth format, Set the full depth range, so later rasterization can pass HiZ. Previously, for depth only formats, the depth range was set to 0 to 0. This caused unwanted HiZ rejections with a VK_FORMAT_D16_UNORM depth buffer (VK_FORMAT_D32_SFLOAT was not

Re: [Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

2018-02-22 Thread Brian Paul
On 02/22/2018 09:29 AM, Jose Fonseca wrote: The MSVC version we (at VMware) primarily care about from now on is 2015. We can drop support for building with 2013 in a future commit. I'm not aware of significant changes in C99/C11 support from MSVC 2013 to 2015, but there's no point in

[Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

2018-02-22 Thread Frank Binns
dri2_display_destroy() is called when platform specific display initialisation fails. However, this would typically lead to a segfault due to the dri2_egl_display vbtl not having been set up. Fixes: 2db95482964 ("loader_dri3/glx/egl: Optionally use a blit context for blitting operations")

[Mesa-dev] [PATCH 2/5] swr/rast: Code generation cleanup

2018-02-22 Thread George Kyriazis
Generate more compact code from gen_llvm.hpp. --- .../swr/rasterizer/codegen/templates/gen_llvm.hpp | 36 +- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp

  1   2   >