[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #3 from Clément Guérin --- Created attachment 141244 --> https://bugs.freedesktop.org/attachment.cgi?id=141244=edit GTA 5 RADV_DEBUG log Here's the log attached as requested. -- You are receiving this mail because: You are the

[Mesa-dev] [PATCH v2] Add NV_fragment_shader_interlock support.

2018-08-22 Thread Kevin Rogovin
From: Kevin Rogovin The main purpose for having NV_fragment_shader_interlock extension is because that extension is also for GLES31 while the ARB extension is for GL only. v2: Add to review notes (requested by Emil Velikov) Reviewed-by: Plamena Manolova --- docs/relnotes/18.3.0.html

Re: [Mesa-dev] [PATCH] Add NV_fragment_shader_interlock support.

2018-08-22 Thread Kevin Rogovin
Hi, My request for an account was NAK'd by the i965 maintainer. As such, I will post a v2 with the update to release notes requested and I hope Plamena can push that for me. Best Regards, -Kevin Rogovin On Tue, Aug 21, 2018 at 12:39 PM Emil Velikov wrote: > Hi Kevin, > > On 20 August 2018

Re: [Mesa-dev] [PATCH 6/5] egl/android: continue to next device if dri2_create_screen fails

2018-08-22 Thread Tomasz Figa
On Thu, Aug 23, 2018 at 1:44 AM Emil Velikov wrote: > > Hi Tomasz, > > On 21 August 2018 at 14:54, Tomasz Figa wrote: > > Hi Emil, > > > > On Tue, Aug 14, 2018 at 2:05 AM Emil Velikov > > wrote: > >> > >> From: Emil Velikov > >> > >> Unlike the other platforms, here we aim do guess if the

Re: [Mesa-dev] [PATCH v2 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-22 Thread Sagar Ghuge
On 08/22/2018 04:31 PM, Marek Olšák wrote: > On Wed, Aug 22, 2018 at 5:52 PM Sagar Ghuge wrote: >> >> Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle >> GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. >> >> Remove DepthClamp, because DepthClampNear + DepthClampFar replaces

Re: [Mesa-dev] [PATCH] radv: remove dead variables after splitting per member structs

2018-08-22 Thread Timothy Arceri
On 23/08/18 09:57, Timothy Arceri wrote: On 22/08/18 20:34, Samuel Pitoiset wrote: Otherwise, nir_lower_clip_cull_distance_arrays might report wrong number of output clips/culls because it relies on shader output variables and some of them might be dead. This fixes a rendering issue with

Re: [Mesa-dev] [PATCH] radv: remove dead variables after splitting per member structs

2018-08-22 Thread Timothy Arceri
On 22/08/18 20:34, Samuel Pitoiset wrote: Otherwise, nir_lower_clip_cull_distance_arrays might report wrong number of output clips/culls because it relies on shader output variables and some of them might be dead. This fixes a rendering issue with Dolphin and Super Mario Sunshine. Fixes:

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-22 Thread Timothy Arceri
On 21/08/18 19:42, Vadym Shovkoplias wrote: Hi Timothy, Alejandro, Thanks for the review comments! I'd just like to mention that the same approach is already used in link_varyings.cpp file in function cross_validate_outputs_to_inputs(). Here is a code snippet: if (*input->data.used *&&

Re: [Mesa-dev] [PATCH 1/2] meson: fix egl build for surfaceless

2018-08-22 Thread Dylan Baker
Quoting Gurchetan Singh (2018-08-22 16:08:33) > Without this, I get: > > > platform_surfaceless.c:38:10: fatal error: 'loader.h' file not found > > #include "loader.h" > > ^~ > > 1 error generated. > > Fixes: 108d257a16859898f5ce02f4759c5c58f9b8c050 ("meson: build libEGL") > >

Re: [Mesa-dev] [PATCH v2 4/7] mesa: add support for GL_AMD_depth_clamp_separate tokens

2018-08-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Aug 22, 2018 at 4:32 PM Sagar Ghuge wrote: > > _mesa_set_enable() and _mesa_IsEnabled() extended to accept new two > tokens GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD. > > v2: Remove unnecessary parentheses (Marek Olsak) > > Signed-off-by: Sagar

Re: [Mesa-dev] [PATCH v2 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-22 Thread Marek Olšák
On Wed, Aug 22, 2018 at 5:52 PM Sagar Ghuge wrote: > > Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle > GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. > > Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it, > as suggested by Marek Olsak. > > Driver that

[Mesa-dev] [PATCH 1/2] meson: fix egl build for surfaceless

2018-08-22 Thread Gurchetan Singh
Without this, I get: > platform_surfaceless.c:38:10: fatal error: 'loader.h' file not found > #include "loader.h" > ^~ > 1 error generated. Fixes: 108d257a16859898f5ce02f4759c5c58f9b8c050 ("meson: build libEGL") v2: Split up patches, modify commit message (Dylan) ---

[Mesa-dev] [PATCH 2/2] meson: fix egl build for android

2018-08-22 Thread Gurchetan Singh
Haven't tested this, but we do include loader.h in platform_android.c Fixes: c5ec1556859b7d33637c9fad13d3473c7b2f9eb3 ("meson: wire up egl/android") --- src/egl/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/meson.build b/src/egl/meson.build index 9c0b6b4b4a..06922c6c3c

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Jason Ekstrand
On Wed, Aug 22, 2018 at 5:35 PM Fritz Koenig wrote: > On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand > wrote: > > > > Two questions: > > > > 1) Have you grep'd through the rest of i965 looking for Name to make > sure you got them all? > > Yes, I have. I believe that I got them all now. > > >

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Fritz Koenig
On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand wrote: > > Two questions: > > 1) Have you grep'd through the rest of i965 looking for Name to make sure > you got them all? Yes, I have. I believe that I got them all now. > 2) Have you had a chance to run it through our CI system? No I

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Jason Ekstrand
Two questions: 1) Have you grep'd through the rest of i965 looking for Name to make sure you got them all? 2) Have you had a chance to run it through our CI system? On Wed, Aug 22, 2018 at 5:00 PM Fritz Koenig wrote: > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. --- src/mesa/drivers/dri/i965/brw_blorp.c| 20 +--- src/mesa/drivers/dri/i965/intel_pixel_read.c | 4

[Mesa-dev] [PATCH] glapi: actually implement GL_EXT_robustness for GLES

2018-08-22 Thread Marek Olšák
From: Marek Olšák The extension was exposed but not the functions. This fixes: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.readn_pixels dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_nuniformfv

[Mesa-dev] [PATCH v2 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-22 Thread Sagar Ghuge
Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it, as suggested by Marek Olsak. Driver that enables AMD_depth_clamp_separate will only ever look at

Re: [Mesa-dev] [PATCH] amd/addrlib: Fix include path for c99_compat.h

2018-08-22 Thread Mariusz Ceier
Oh, ok, no problem ;) I just sent v2. On 22 August 2018 at 21:44, Dylan Baker wrote: > Quoting Kai Wasserbäch (2018-08-22 14:23:07) >> Hey Mariusz, >> Mariusz Ceier wrote on 8/22/18 10:16 PM: >> > Without this patch mesa doesn't compile: >> > >> > In file included from

Re: [Mesa-dev] [PATCH] amd/addrlib: Fix include path for c99_compat.h

2018-08-22 Thread Dylan Baker
Quoting Kai Wasserbäch (2018-08-22 14:23:07) > Hey Mariusz, > Mariusz Ceier wrote on 8/22/18 10:16 PM: > > Without this patch mesa doesn't compile: > > > > In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39: > > ../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h:

[Mesa-dev] [PATCH v2] amd/addrlib: Fix include path for c99_compat.h

2018-08-22 Thread Mariusz Ceier
Without this patch mesa doesn't compile: In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39: ../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h: No such file or directory #include "c99_compat.h" ^~ compilation terminated. Fixes 15ca5ce99a

Re: [Mesa-dev] [PATCH] vulkan/wsi: fix pointer-integer conversion warnings

2018-08-22 Thread Grazvydas Ignotas
On Tue, Aug 21, 2018 at 1:05 AM, Bas Nieuwenhuizen wrote: > Reviewed-by: Bas Nieuwenhuizen > > Did you have access to push? Yeah, just pushed everything. Gražvydas > > On Mon, Aug 20, 2018 at 11:40 PM, Grazvydas Ignotas wrote: >> For 32bit build. Trivial. >> --- >>

Re: [Mesa-dev] [PATCH] amd/addrlib: Fix include path for c99_compat.h

2018-08-22 Thread Kai Wasserbäch
Hey Mariusz, Mariusz Ceier wrote on 8/22/18 10:16 PM: > Without this patch mesa doesn't compile: > > In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39: > ../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h: No such file > or directory > #include "c99_compat.h"

Re: [Mesa-dev] [PATCH 0/7] Implement AMD_depth_clamp_separate extension

2018-08-22 Thread Ian Romanick
I sent a minor comment on patch 6. The rest of the series is Reviewed-by: Ian Romanick On 08/21/2018 05:02 PM, Sagar Ghuge wrote: > This patch series implements AMD_depth_clamp_separate extension. > Previously I sent patches for comments and based on Ian and Marek's > suggestions, I did some

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Bug 107457 depends on bug 107359, which changed state. Bug 107359 Summary: [Regression] [bisected] [OpenGL CTS] [SKL,BDW] KHR-GL46.texture_barrier*-texels, GTF-GL46.gtf21.GL2FixedTests.buffer_corners.buffer_corners, and

Re: [Mesa-dev] [PATCH v2 6/7] i965: add functional changes for AMD_depth_clamp_separate

2018-08-22 Thread Ilia Mirkin
I admit to always being confused by depth, but: On Wed, Aug 22, 2018, 16:23 Sagar Ghuge wrote: > Gen >= 9 have ability to control clamping of depth values separately at > near and far plane. > > z_w is clamped to the range [min(n,f), 0] if clamping at near plane is > enabled, [0, max(n,f)] if

[Mesa-dev] [PATCH v2 4/7] mesa: add support for GL_AMD_depth_clamp_separate tokens

2018-08-22 Thread Sagar Ghuge
_mesa_set_enable() and _mesa_IsEnabled() extended to accept new two tokens GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD. v2: Remove unnecessary parentheses (Marek Olsak) Signed-off-by: Sagar Ghuge --- src/mesa/main/enable.c | 36 1 file changed, 36

[Mesa-dev] [PATCH v2 6/7] i965: add functional changes for AMD_depth_clamp_separate

2018-08-22 Thread Sagar Ghuge
Gen >= 9 have ability to control clamping of depth values separately at near and far plane. z_w is clamped to the range [min(n,f), 0] if clamping at near plane is enabled, [0, max(n,f)] if clamping at far plane is enabled and [min(n,f) max(n,f)] if clamping at both plane is enabled. v2: 1) Use

[Mesa-dev] [PATCH] amd/addrlib: Fix include path for c99_compat.h

2018-08-22 Thread Mariusz Ceier
Without this patch mesa doesn't compile: In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39: ../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h: No such file or directory #include "c99_compat.h" ^~ compilation terminated. Signed-off-by:

Re: [Mesa-dev] [PATCH v2 2/7] mesa: Add types for AMD_depth_clamp_separate.

2018-08-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Aug 22, 2018 at 4:00 PM Sagar Ghuge wrote: > > Add some basic types and storage for the AMD_depth_clamp_separate > extension. > > v2: 1) Drop unnecessary definition (Marek Olsak) > 2) Expose extension in compatibility profile (Marek Olsak) > >

Re: [Mesa-dev] [PATCH 6/7] i965: add functional changes for AMD_depth_clamp_separate

2018-08-22 Thread Ian Romanick
On 08/21/2018 05:02 PM, Sagar Ghuge wrote: > Gen >= 9 have ability to control clamping of depth values separately at > near and far plane. > > z_w is clamped to the range [min(n,f), 0] if clamping at near plane is > enabled, [0, max(n,f)] if clamping at far plane is enabled and [min(n,f) >

[Mesa-dev] [PATCH v2 2/7] mesa: Add types for AMD_depth_clamp_separate.

2018-08-22 Thread Sagar Ghuge
Add some basic types and storage for the AMD_depth_clamp_separate extension. v2: 1) Drop unnecessary definition (Marek Olsak) 2) Expose extension in compatibility profile (Marek Olsak) Signed-off-by: Sagar Ghuge --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h |

Re: [Mesa-dev] [PATCH v2 2/7]] mesa: Add types for AMD_depth_clamp_separate.

2018-08-22 Thread Sagar Ghuge
Please ignore this patch. Subject contains extra bracket. I will resend the patch. On 08/22/2018 12:54 PM, Sagar Ghuge wrote: > Add some basic types and storage for the AMD_depth_clamp_separate > extension. > > v2: 1) Drop unnecessary definition (Marek Olsak) > 2) Expose extension in

[Mesa-dev] [PATCH v2 2/7]] mesa: Add types for AMD_depth_clamp_separate.

2018-08-22 Thread Sagar Ghuge
Add some basic types and storage for the AMD_depth_clamp_separate extension. v2: 1) Drop unnecessary definition (Marek Olsak) 2) Expose extension in compatibility profile (Marek Olsak) Signed-off-by: Sagar Ghuge --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h |

Re: [Mesa-dev] [PATCH mesa] vk/wsi: avoid reading uninitialised memory

2018-08-22 Thread Caio Marcelo de Oliveira Filho
On Tue, Jul 17, 2018 at 01:18:42PM +0100, Eric Engestrom wrote: > It will be ignored by x11_swapchain_result() anyway (because reaching > the `fail` label without setting `result` means the swapchain status was > already a hard error), but the compiler still complains about reading > uninitialised

Re: [Mesa-dev] [PATCH 7/9] intel/nir: Use the new dead write vars pass

2018-08-22 Thread Jason Ekstrand
shader-db numbers? On Wed, Aug 15, 2018 at 4:57 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > --- > src/intel/compiler/brw_nir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c > index

Re: [Mesa-dev] [PATCH 5/9] nir: Add a local dead write vars removal pass

2018-08-22 Thread Jason Ekstrand
On Wed, Aug 15, 2018 at 4:57 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Instead of doing this as part of the existing (local) copy prop vars > pass. This is an intermediate step before changing both the dead > write and the copy prop vars to act on the whole program

[Mesa-dev] [PATCH piglit] egl_khr_create_context: Proper invalid attributes for EGL 1.5

2018-08-22 Thread Miguel A. Vico
When EGL_KHR_create_context was originally written, EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR was an invalid attribute for OpenGL ES. After moving the extension to core EGL 1.5, the aforementioned attribute was made valid for both OpenGL and OpenGL ES. Check whether the EGL version is

Re: [Mesa-dev] [PATCH] nir/vars_to_ssa: Don't build deref nodes for non-local variables

2018-08-22 Thread Caio Marcelo de Oliveira Filho
On Mon, Jul 09, 2018 at 05:11:54PM -0700, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_lower_vars_to_ssa.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) This patch is Reviewed-by: Caio Marcelo de Oliveira Filho I also verified it pass the test that was

Re: [Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

2018-08-22 Thread Jose Fonseca
On 22/08/18 18:05, Dylan Baker wrote: v2: - fix typos in commit message --- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 15a31da9411..b26a3c624e8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,7 +34,6 @@ branches:

Re: [Mesa-dev] [PATCH 4/9] nir: Give end_block its own index

2018-08-22 Thread Jason Ekstrand
Seems reasonable Reviewed-by: Jason Ekstrand On Wed, Aug 15, 2018 at 4:58 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Since there's no particular reason for the index to be 0, choose an > index that is not used by other block. This is convenient when we > store

Re: [Mesa-dev] [PATCH 3/9] nir: Skip common instructions when comparing deref paths

2018-08-22 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Aug 15, 2018 at 4:57 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Deref paths may share the same deref instructions in their chains, > e.g. > > ssa_100 = deref_var A > ssa_101 = deref_struct "array_field" of ssa_100 >

Re: [Mesa-dev] [PATCH 05/12] amd/addrlib: mark physicalSliceSize as MAYBE_UNUSED in Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled

2018-08-22 Thread Marek Olšák
Pushed, thanks! Marek On Wed, Aug 22, 2018 at 11:30 AM Kai Wasserbäch wrote: > > Kai Wasserbäch wrote on 8/22/18 5:19 PM: > > Hey Marek, > > Marek Olšák wrote on 8/22/18 3:13 AM: > >> Get you send me a "git fetch" line that I can use to download your patches? > > > > sure. I rebased them on top

Re: [Mesa-dev] [PATCH] meson: fix egl build for surfaceless and android

2018-08-22 Thread Dylan Baker
Both of these changes look correct to me, could you split them into two separate patches though? To the one that adds inc_loader to surfaceless add: Fixes: 108d257a16859898f5ce02f4759c5c58f9b8c050 ("meson: build libEGL") To the one that adds it for android add: Fixes:

Re: [Mesa-dev] [PATCH] i965/icl: Allow headerless sampler messages for pre-emptable contexts

2018-08-22 Thread Anuj Phogat
On Mon, Aug 20, 2018 at 2:13 PM Kenneth Graunke wrote: > > On Monday, August 20, 2018 10:26:29 AM PDT Anuj Phogat wrote: > > On Mon, Aug 20, 2018 at 12:18 AM Kenneth Graunke wrote: > [snip] > > > I don't know if people are trying to enable pre-emption during GPGPU > > > work on pre-Gen11. If so,

Re: [Mesa-dev] EGL_MESA_query_renderer

2018-08-22 Thread Rob Clark
On Wed, Aug 22, 2018 at 1:43 PM Emil Velikov wrote: > > On 21 August 2018 at 14:40, Rob Clark wrote: > > On Tue, Aug 21, 2018 at 5:19 AM Emil Velikov > > wrote: > >> > >> HI all, > >> > >> On 20 August 2018 at 20:01, Rob Clark wrote: > >> > +Emil since he had some interest in this extension

Re: [Mesa-dev] EGL_MESA_query_renderer

2018-08-22 Thread Emil Velikov
On 22 August 2018 at 06:24, Veluri Mithun wrote: > Hi all, > > On Tue, Aug 21, 2018 at 2:49 PM Emil Velikov > wrote: >> >> HI all, >> >> On 20 August 2018 at 20:01, Rob Clark wrote: >> > +Emil since he had some interest in this extension too >> > >> > >> Bth since I did not hear anything last

[Mesa-dev] [Bug 107654] Account request Kevin Rogovin

2018-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107654 Kenneth Graunke changed: What|Removed |Added Assignee|sitewranglers@lists.freedes |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] meson: fix egl build for surfaceless and android

2018-08-22 Thread Gurchetan Singh
Without this, I get: > platform_surfaceless.c:38:10: fatal error: 'loader.h' file not found > #include "loader.h" > ^~ > 1 error generated. I also included this for platform_android, but I haven't tested that case. --- src/egl/meson.build | 2 ++ 1 file changed, 2 insertions(+)

[Mesa-dev] [PATCH/RFC] glsl: allow redeclaring variables as 'precise invariant'

2018-08-22 Thread Erik Faye-Lund
There's seems to be nothing in the GLSL (ES) specifications that diallow redeclaring a variable as both 'precise' and 'invariant' in the same statement. But the way the parse-rules are structured this fails to parse, because this is handled in single_declaration, which has an exhaustive list of

Re: [Mesa-dev] [PATCH 2/9] nir: Export deref comparison functions

2018-08-22 Thread Jason Ekstrand
Thanks! I've been wanting to do this ever since I added that function. I just didn't have a second consumer. Reviewed-by: Jason Ekstrand On Wed, Aug 15, 2018 at 4:57 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Reviewed-by: Timothy Arceri > --- >

Re: [Mesa-dev] [PATCH 1/9] util/dynarray: add a clone function

2018-08-22 Thread Jason Ekstrand
On Thu, Aug 16, 2018 at 12:30 AM Thomas Helland wrote: > 2018-08-15 23:56 GMT+02:00 Caio Marcelo de Oliveira Filho > : > > --- > > src/util/u_dynarray.h | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > > index

[Mesa-dev] [PATCH v4 38/49] meson: Set visibility and compat args for graw

2018-08-22 Thread Dylan Baker
--- src/gallium/targets/graw-gdi/meson.build | 1 + src/gallium/targets/graw-null/meson.build | 2 ++ src/gallium/targets/graw-xlib/meson.build | 1 + 3 files changed, 4 insertions(+) diff --git a/src/gallium/targets/graw-gdi/meson.build b/src/gallium/targets/graw-gdi/meson.build index

[Mesa-dev] [PATCH v4 17/49] meson: Add necessary defines for mesa_gallium on windows

2018-08-22 Thread Dylan Baker
v4: - Retain scons comments for windows specific defines Reviewed-by: Eric Anholt --- src/mesa/meson.build | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index ea884977db8..100b0d61487 100644 ---

Re: [Mesa-dev] [PATCH v2 10/11] nir: Add an array copy optimization

2018-08-22 Thread Caio Marcelo de Oliveira Filho
> I've applied your suggestions. Please double-check: > > https://gitlab.freedesktop.org/jekstrand/mesa/commit/28c01e9a0ce84ff53fa8805e4a35a691ea3fc744 Reviewed-by: Caio Marcelo de Oliveira Filho ___ mesa-dev mailing list

[Mesa-dev] [PATCH v4 31/49] meson: disable sse4.1 optimizations with msvc

2018-08-22 Thread Dylan Baker
There isn't an obvious command line switch here, /arch:AVX *might* be the right thing, but meson doesn't know what to do here either and leaves the -msse4.1 and -mstackrealign. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 33/49] meson: don't define GLX_USE_TLS for windows

2018-08-22 Thread Dylan Baker
Because the macros for exporting dll symbols and using TLS are mutually exclusive. --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 9c445c58e52..66d25967df9 100644 --- a/meson.build +++ b/meson.build @@ -329,7 +329,10 @@ if

[Mesa-dev] [PATCH v4 47/49] appveyor: use msbuild instead of ninja

2018-08-22 Thread Dylan Baker
I think that most windows users probably find using msbuild more interesting than ninja, even if ninja is faster. I've left the ninja build in case someone wants to look at it. - v4: Add /m switch to make build somewhat faster --- appveyor.yml | 8 1 file changed, 4 insertions(+), 4

[Mesa-dev] [PATCH v4 36/49] meson: Don't build glsl cache_test for windows

2018-08-22 Thread Dylan Baker
v2: - Use new with_shader_cache variable instead of host_machine.system() == 'windows' --- src/compiler/glsl/tests/meson.build | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build

[Mesa-dev] [PATCH v4 28/49] meson: Add support for using win_flex and win_bison on windows

2018-08-22 Thread Dylan Baker
--- meson.build | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 9de29b832a0..c5baaf60c68 100644 --- a/meson.build +++ b/meson.build @@ -1364,8 +1364,31 @@ endif # pthread stubs. Lets not and say we didn't

[Mesa-dev] [PATCH v4 29/49] meson: make nm binary optional

2018-08-22 Thread Dylan Baker
This makes nm not required, but used if found. In general I imagine that this means that on windows nm wont be found, and on other platforms it will. v2: - fix gbm and egl symbols check tests to only be run if nm is found - reword commit message to reflect the code change --- meson.build

[Mesa-dev] [PATCH v4 37/49] glsl/tests: define ssize_t on windows

2018-08-22 Thread Dylan Baker
--- src/compiler/glsl/tests/blob_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/blob_test.c b/src/compiler/glsl/tests/blob_test.c index 1cc97236e7e..21b8b1efdc1 100644 --- a/src/compiler/glsl/tests/blob_test.c +++ b/src/compiler/glsl/tests/blob_test.c @@

[Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

2018-08-22 Thread Dylan Baker
v2: - fix typos in commit message --- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 15a31da9411..b26a3c624e8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,7 +34,6 @@ branches: clone_depth: 100 cache: --

[Mesa-dev] [PATCH v4 35/49] util/tests: Use define instead of VLA

2018-08-22 Thread Dylan Baker
To allow the this test to be built with MSVC, which doesn't support VLAs. --- src/util/tests/hash_table/clear.c | 13 +++-- src/util/tests/hash_table/delete_management.c | 13 +++-- src/util/tests/hash_table/insert_many.c | 11 ++-

[Mesa-dev] [PATCH v4 45/49] appveyor: Add support for meson as well as scons

2018-08-22 Thread Dylan Baker
v4: - Rebase on python3 generators - Cache meson wraps - Build x86 instead of x86_64, since that's what the pre-build LLVM is --- appveyor.yml | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index

[Mesa-dev] [PATCH v4 40/49] meson: Fix gtest linkage on msvc

2018-08-22 Thread Dylan Baker
We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index 91a49240416..ed0d6974bd3 100644 ---

[Mesa-dev] [PATCH v4 41/49] meson: disable graw tests on mingw

2018-08-22 Thread Dylan Baker
I can't figure out why symbols are being exposed that shouldn't. --- src/gallium/tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 15b9f549647..1d08da2ac10 100644 ---

[Mesa-dev] [PATCH v4 10/49] meson: build getopt when using msvc

2018-08-22 Thread Dylan Baker
v4: - Don't wrap a single file in a list to match mesa style - Use null_dep instead of empty list Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v3) Reviewed-by: Eric Engestrom --- src/getopt/meson.build | 29 + src/meson.build| 5 + 2 files

[Mesa-dev] [PATCH v4 34/49] meson: Add idep_getopt for tests

2018-08-22 Thread Dylan Baker
There are quite a few tests that require getopt, when using MSVC we need to use the bundled version of getopt since there isn't a system version. --- src/compiler/glsl/glcpp/meson.build | 2 +- src/compiler/glsl/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH v4 13/49] meson: don't allow glvnd on windows

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5102ffe0c7c..32a731e2024 100644 --- a/meson.build +++ b/meson.build @@ -356,7 +356,9 @@ endif with_glvnd =

[Mesa-dev] [PATCH v4 39/49] meson: don't build gallium trivial tests on windows

2018-08-22 Thread Dylan Baker
They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 0ee04350c87..15b9f549647 100644 ---

[Mesa-dev] [PATCH v4 16/49] meson: Add windows defines to glapi

2018-08-22 Thread Dylan Baker
These are needed to control the export or symbols due to differences between the way windows and *nix handle symbol exports. Reviewed-by: Eric Anholt --- src/mapi/es1api/meson.build | 10 +- src/mapi/es2api/meson.build | 10 +- src/mapi/glapi/meson.build| 13

[Mesa-dev] [PATCH v4 26/49] meson: fix pipe-loader compilation for windows

2018-08-22 Thread Dylan Baker
v2: - Add missing D to pound define - Simply define the variable rather than set it to 1 (mirrors android.mk not scons) --- src/gallium/auxiliary/pipe-loader/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v4 25/49] util/xmlconfig: include strndup.h for windows

2018-08-22 Thread Dylan Baker
--- src/util/xmlconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c index 5264f2598b4..51cc5f3dd87 100644 --- a/src/util/xmlconfig.c +++ b/src/util/xmlconfig.c @@ -39,6 +39,7 @@ #include #include #include +#include "strndup.h" #include

[Mesa-dev] [PATCH v4 04/49] add a git ignore for subprojects

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- subprojects/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 subprojects/.gitignore diff --git a/subprojects/.gitignore b/subprojects/.gitignore new file mode 100644 index 000..68a882edba6 --- /dev/null +++

[Mesa-dev] [PATCH v4 23/49] meson: Don't check for posix_memalign on windows

2018-08-22 Thread Dylan Baker
There's a mingw bug for this, it exports __builtin_posix_memalign but not posix_memalign, so the check will succeed, but compiling will fail. --- meson.build | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 0f37117e3fc..c89b805e71f

[Mesa-dev] [PATCH v4 15/49] meson: Make shader-cache a trillean instead of boolean

2018-08-22 Thread Dylan Baker
So that it can be implicitly disabled on windows, where it doesn't compile. v2: - Use an auto-option rather than automagic. - fix shader_cache check (== -> !=) v4: - Use new with_shader_cache instead of get_option('shader-cache') elsewhere in the meson build --- meson.build | 18

[Mesa-dev] [PATCH v4 24/49] meson: Add support for wrapping llvm

2018-08-22 Thread Dylan Baker
For building on Windows (when not using cygwin), the assumption is that LLVM will have to be handled via a binary wrap. In this case the user wanting to use LLVM is this way will need to create a directory in subprojects (any name is fine), and pass that name via the -Dllvm-wrap option (for

[Mesa-dev] [PATCH v4 20/49] meson: build libgl-gdi target

2018-08-22 Thread Dylan Baker
v4: - Fix check for broken mingw (should be for x86 not x86_64) - Add comment about why check is needed --- src/gallium/meson.build | 1 + src/gallium/targets/libgl-gdi/meson.build | 46 +++ 2 files changed, 47 insertions(+) create mode 100644

[Mesa-dev] [PATCH v4 19/49] meson: build wgl state tracker

2018-08-22 Thread Dylan Baker
v4: - Handle enable gles properly - Add comments about what various #defines do Reviewed-by: Eric Anholt --- src/gallium/meson.build| 3 ++ src/gallium/state_trackers/wgl/meson.build | 57 ++ 2 files changed, 60 insertions(+) create mode 100644

[Mesa-dev] [PATCH v4 02/49] Replace uses of _mesa_bitcount with util_bitcount

2018-08-22 Thread Dylan Baker
and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem in nir for platforms that don't have popcount or popcountll, such as 32bit msvc. v4: - add this patch --- src/compiler/glsl/ir_constant_expression.cpp | 2 +- src/compiler/glsl/ir_expression_operation.py | 2 +-

[Mesa-dev] [PATCH v4 49/49] appveyor: cache pip packages

2018-08-22 Thread Dylan Baker
--- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index 2c45f534ec3..2cb520b9604 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -36,6 +36,7 @@ clone_depth: 100 cache: - llvm-5.0.1-msvc2015-mtd.7z - subprojects\packagecache +-

[Mesa-dev] [PATCH v4 00/49] Meson for Windows

2018-08-22 Thread Dylan Baker
This is the 4th iteration of my meson for windows series. It includes (hopefully) all of the review feedback I got on the v3, as well as a few new fixes and features, namely the appveyor build now uses the same LLVM as scons to build LLVMPipe (I would like to build SWR, but that requires LLVM

[Mesa-dev] [PATCH v4 03/49] meson: always define libglapi

2018-08-22 Thread Dylan Baker
This allows the identifier to be used even if shared-glapi isn't build, which simplifies a bunch of things. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mapi/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/meson.build b/src/mapi/meson.build index

[Mesa-dev] [PATCH v4 05/49] meson: add a zlib subproject

2018-08-22 Thread Dylan Baker
To help windows build Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 2 +- subprojects/zlib.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/zlib.wrap diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 07/49] glapi: export glapi_destroy_multithread when building shared-glapi on windows

2018-08-22 Thread Dylan Baker
Which will allow meson to build a shared glapi build with mingw. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mapi/glapi/glapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/glapi.h b/src/mapi/glapi/glapi.h index d5d4e0a03a6..cbdef2e4c5a

[Mesa-dev] [PATCH v4 18/49] meson: build gallium gdi winsys

2018-08-22 Thread Dylan Baker
Reviewed-by: Eric Anholt --- src/gallium/meson.build | 6 ++ src/gallium/winsys/sw/gdi/meson.build | 27 +++ 2 files changed, 33 insertions(+) create mode 100644 src/gallium/winsys/sw/gdi/meson.build diff --git a/src/gallium/meson.build

[Mesa-dev] [PATCH v4 11/49] meson: Add a platform for windows

2018-08-22 Thread Dylan Baker
This mirrors the haiku build which uses a platform. v2: - Fix some rebase problems Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 8 ++-- meson_options.txt | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 43/49] tests/vma: fix build with MSVC

2018-08-22 Thread Dylan Baker
--- src/util/tests/vma/vma_random_test.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test.cpp index 1f194fcdf92..9246176cbf2 100644 --- a/src/util/tests/vma/vma_random_test.cpp +++

[Mesa-dev] [PATCH v4 30/49] meson: for incluse of inttypes.h for glcpp with msvc

2018-08-22 Thread Dylan Baker
Because we provide a copy if MSVC doesn't, and we need it to make flex do what we want. --- src/compiler/glsl/glcpp/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index

[Mesa-dev] [PATCH v4 06/49] meson: add a expat subproject

2018-08-22 Thread Dylan Baker
For Windows Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build| 2 +- subprojects/expat.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/expat.wrap diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 14/49] meson: add windows compiler checks and libraries

2018-08-22 Thread Dylan Baker
v4: - Fix typo in warning code (4246 -> 4267) - Copy comments from scons for what MSVC warnings codes do - Merge linker argument changes into this commit --- meson.build | 155 +++- 1 file changed, 106 insertions(+), 49 deletions(-) diff

[Mesa-dev] [PATCH v4 32/49] meson: add switches for SWR with MSVC

2018-08-22 Thread Dylan Baker
--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++

[Mesa-dev] [PATCH v4 48/49] appveyor: Add a wrap for llvm

2018-08-22 Thread Dylan Baker
The appveyor build has a copy of llvm 5.0.1 that scons uses, meson can also use this to build llvm pipe (though not swr, which requires 6.0.0) as well. This requires a plain buildtype, since we need to compile single threaded to link with the provided LLVM, as well as a 32 bit build for the same

[Mesa-dev] [PATCH v4 21/49] meson: build graw-gdi target

2018-08-22 Thread Dylan Baker
--- src/gallium/meson.build | 4 ++- src/gallium/targets/graw-gdi/meson.build | 36 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/gallium/targets/graw-gdi/meson.build diff --git a/src/gallium/meson.build

[Mesa-dev] [PATCH v4 09/49] meson: fix dl detection on non cygwin windows

2018-08-22 Thread Dylan Baker
v4: - Don't run checks on Windows that will always fail Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v3) Reviewed-by: Eric Engestrom --- meson.build | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 22/49] meson: fix gallium-osmesa to build for windows

2018-08-22 Thread Dylan Baker
v2: - set so_version to '' (only affects windows) - always set lib prefix to 'lib', even on msvc --- src/gallium/state_trackers/osmesa/meson.build | 12 ++-- src/gallium/targets/osmesa/meson.build| 11 ++- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v4 01/49] move u_math to src/util

2018-08-22 Thread Dylan Baker
Currently we have two sets of functions for bit counts, one in gallium and one in core mesa. The ones in core mesa are header only in many cases, since they reduce to "#define _mesa_bitcount popcount", but they provide a fallback implementation. This is important because 32bit msvc doesn't have

[Mesa-dev] [PATCH v4 44/49] meson: maintain names of shared API libraries

2018-08-22 Thread Dylan Baker
Mesa uses the lib prefix, and doesn't use a version for it's dynamic libraries, which meson defaults to. v2: - this patch --- src/mapi/es1api/meson.build | 2 ++ src/mapi/es2api/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git

  1   2   >