On Tuesday, November 13, 2018 2:33:59 PM PST Anuj Phogat wrote:
> L3 allocation table in h/w specification recommends using 4 KB
> granularity for programming allocation fields in L3CNTLREG.
>
> Signed-off-by: Anuj Phogat
> Cc: Kenneth Graunke
> Cc: Francisco Jerez
> Cc: Lionel Landwerlin
>
Kenneth Graunke writes:
> On Thursday, November 15, 2018 5:51:18 PM PST Francisco Jerez wrote:
>> Anuj Phogat writes:
>>
>> > Use L3 configuration table specified in h/w specification.
>> >
>> > Signed-off-by: Anuj Phogat
>> > Cc: Kenneth Graunke
>> > Cc: Francisco Jerez
>> > Cc: Lionel
On Thursday, November 15, 2018 5:51:18 PM PST Francisco Jerez wrote:
> Anuj Phogat writes:
>
> > Use L3 configuration table specified in h/w specification.
> >
> > Signed-off-by: Anuj Phogat
> > Cc: Kenneth Graunke
> > Cc: Francisco Jerez
> > Cc: Lionel Landwerlin
> > ---
> >
Previously we would print errors on the console like:
libEGL debug: EGL user error 0x3001 (EGL_NOT_INITIALIZED) in eglInitialize
When we had everything we needed for:
libEGL debug: EGL user error 0x3001 (EGL_NOT_INITIALIZED) in eglInitialize:
DRI2: failed to find EGLDevice
(for a gbm
Pushed.
On Thu, Nov 15, 2018 at 8:15 PM Jason Ekstrand wrote:
> Thanks. I'm going to push it once it gets done running through CI.
>
> On Thu, Nov 15, 2018 at 4:03 AM Danylo Piliaiev
> wrote:
>
>> Handle all cases in calculation of layers count for isl_view
>> taking into account texture view
It's not at all intel-specific; the formula is dictated by OpenGL and
Vulkan. The only intel-specific thing is that we need the lowering. As
a nice side-effect, the new version is variable-group-size ready.
Cc: Plamena Manolova
---
src/compiler/nir/nir.h| 1 +
Thanks. I'm going to push it once it gets done running through CI.
On Thu, Nov 15, 2018 at 4:03 AM Danylo Piliaiev
wrote:
> Handle all cases in calculation of layers count for isl_view
> taking into account texture view and image unit.
> st_convert_image was taken as a reference.
>
> When
Anuj Phogat writes:
> Use L3 configuration table specified in h/w specification.
>
> Signed-off-by: Anuj Phogat
> Cc: Kenneth Graunke
> Cc: Francisco Jerez
> Cc: Lionel Landwerlin
> ---
> src/intel/common/gen_l3_config.c | 16 ++--
> 1 file changed, 10 insertions(+), 6
I need other types from the header now, and "gl.h is big" is not a good
reason to duplicate definitions.
---
src/loader/loader.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/loader/loader.c b/src/loader/loader.c
index 461f96aa6a44..041a59212be7 100644
---
Everyone needs to call it, and platform_x11 forgot to.
---
src/egl/drivers/dri2/egl_dri2.c | 2 ++
src/egl/drivers/dri2/platform_android.c | 2 --
src/egl/drivers/dri2/platform_drm.c | 2 --
src/egl/drivers/dri2/platform_surfaceless.c | 2 --
You can tell by "Mesa/configs/default" how old this is. Your build system
really has to provide the DEFAULT_DRIVER_DIR, or other loaders will break.
---
src/glx/dri_common.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/glx/dri_common.c b/src/glx/dri_common.c
index
I copied the code from egl_dri2.c, but the functionality was equivalent
between all the loaders other than their particular environment variables.
---
src/egl/Makefile.am | 3 +-
src/egl/drivers/dri2/egl_dri2.c | 75 +++---
src/egl/meson.build | 3 --
The only thing you do with a dri driver handle is get the extensions
pointer, so just fold it in to simplify the callers.
---
src/glx/dri2_glx.c | 8 +---
src/glx/dri3_glx.c | 8 +---
src/glx/dri_common.c | 20 +++-
src/glx/dri_common.h | 6 ++
src/glx/dri_glx.c
On Wed 14 Nov 2018, Eric Engestrom wrote:
> On Tuesday, 2018-11-13 14:10:45 +, Lionel Landwerlin wrote:
> > According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
> > image with a DRM format not supported should yield the BAD_MATCH
> > error :
> >
> > "
> >* If is
While disassembling the predicate always print flag subregister number
to keep grammar same across the generation for assembler tool.
Signed-off-by: Sagar Ghuge
---
src/intel/compiler/brw_disasm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
---
src/compiler/nir/nir_loop_analyze.c | 31 ++---
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/src/compiler/nir/nir_loop_analyze.c
b/src/compiler/nir/nir_loop_analyze.c
index 9c3fd2f286..c779383b36 100644
--- a/src/compiler/nir/nir_loop_analyze.c
+++
Daniel Stone writes:
> gbm_bo_create() was presumably meant to originally accept gbm_bo_format
> enums, but it's accepted GBM_FORMAT_* tokens since the dawn of time.
> This is good, since gbm_bo_format is rarely used and covers a lot less
> ground than GBM_FORMAT_*.
>
> Change the documentation
This adds support for the VK_GOOGLE_display timing extension, which
provides two things:
1) Detailed information about when frames are displayed, including
slack time between GPU execution and display frame.
2) Absolute time control over swapchain queue processing. This allows
the
Emulate MESA_FORMAT_R_SRGB8 by using L8_UNORM_SRGB. This is possible
because component swizzling is handled based on the mesa format and,
hence, the a r001 swizzling can be used to correct the components.
Enables and makes pass (tested on Kabylake)
Dear all,
this series adds support for the GL_SR8_EXT texture format. When you review
please take a closer look at the second patch, to see whether the fbo
completeness states make sense. Always returning GL_FRAMEBUFFER_UNSUPPORTED
makes
This makes it possible to use a hardware luminance format as RED format.
Signed-off-by: Gert Wollny
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
The driver was returning GL_FRAMEBUFFER_UNSUPPORTED for all cases of an
incomplete fbo, be a bit more specific about this following the description
of glCheckFramebufferStatus.
This helps to keeps dEQP happy when adding EXT_texture_sRGB_R8 support.
Signed-off-by: Gert Wollny
---
As the name says, the format is an sRGB format.
Signed-off-by: Gert Wollny
---
src/intel/isl/isl_format_layout.csv | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl_format_layout.csv
b/src/intel/isl/isl_format_layout.csv
index 0b9421e3f9..a1efa66657 100644
Reviewed-by: Matt Turner
and pushed.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Monday, 2018-11-12 10:50:52 -0500, Rob Clark wrote:
> So I can drop env2u() helper from freedreno_util.h and get rid of one
> small ir3 dependency on gallium/freedreno
>
> Signed-off-by: Rob Clark
> ---
> src/util/debug.c | 12
> src/util/debug.h | 2 ++
> 2 files changed, 14
Hi Guido,
Am Dienstag, den 09.10.2018, 13:50 +0200 schrieb Guido Günther:
> Hi,
> On Mon, Sep 17, 2018 at 04:06:57PM +0200, Guido Günther wrote:
> > etna_resource_alloc and etna_resource_from_handle currently use different
> > checks.
> > This leads to
> >
> > etna_resource_from_handle:492:
On Thu, 2018-11-15 at 15:37 +0100, Lucas Stach wrote:
> Some of the status variables in the compiler are only used in asserts
> and thus may be unused in release builds. Annotate them accordingly
> to avoid 'unused but set' warnings from the compiler.
>
> Signed-off-by: Lucas Stach
> ---
>
On Thu, 2018-11-15 at 15:37 +0100, Lucas Stach wrote:
> Take into account the render target format when checking if the color
> mask affects all channels of the RT. This allows to enable full
> override in a few cases where a non-alpha format is used.
>
> Signed-off-by: Lucas Stach
> ---
>
On Thu, 2018-11-15 at 15:37 +0100, Lucas Stach wrote:
> There is no need to do the detour over the resource behind the
> surface to get the format. Use the surface format directly.
>
> Signed-off-by: Lucas Stach
> ---
> src/gallium/drivers/etnaviv/etnaviv_blend.c | 2 +-
>
On Thu, 2018-11-15 at 15:37 +0100, Lucas Stach wrote:
> At least GC2000 seems to push some dirt from the PE color cache into
> the last bound render target when drawing depth only. Newer cores
> seem to behave properly and don't do this, but I have found no way
> to fix it on GC2000. Flushes and
Both extensions GL_ARB_indirect_parameters and GL_NV_conditional_render
use MI_PREDICATE for their work so when conditional rendering was enabled
GL_ARB_indirect_parameters incorrectly handled already present predicate
result and didn't restore it in the end.
Instead special code path for this
Some of the status variables in the compiler are only used in asserts
and thus may be unused in release builds. Annotate them accordingly
to avoid 'unused but set' warnings from the compiler.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 8
1 file
There is no need to do the detour over the resource behind the
surface to get the format. Use the surface format directly.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_blend.c | 2 +-
src/gallium/drivers/etnaviv/etnaviv_context.c | 9 ++---
2 files changed, 3
At least GC2000 seems to push some dirt from the PE color cache into
the last bound render target when drawing depth only. Newer cores
seem to behave properly and don't do this, but I have found no way
to fix it on GC2000. Flushes and stalls don't seem to make any
difference.
In order to stop the
Take into account the render target format when checking if the color
mask affects all channels of the RT. This allows to enable full
override in a few cases where a non-alpha format is used.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_blend.c | 7 +--
1 file changed,
This doesn't seem to work, instead always use the fully
expanded mode for MSAA textures.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c
No CTS regressions on GFX8 now. Still some fails when resolving
DCC/MSAA textures on GFX9.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_image.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index
This is currently broken. My plan is to re-enable it once I
have figured why this breaks a few number of CTS.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_clear.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/amd/vulkan/radv_meta_clear.c
Hi,
This little series fixes some CTS when DCC is enabled for MSAA textures.
It will be easier for me to improve the thing if the current implementation
doesn't introduce any CTS regressions.
This is still disabled by default for now anyways.
Please review,
Thanks!
Samuel Pitoiset (3):
radv:
Rb
On November 15, 2018 00:42:45 Sagar Ghuge wrote:
Both BRW_SFID_SAMPLER and GEN6_SFID_DATAPORT_SAMPLER_CACHE are getting
disassembled as "sampler", which is misleading for assembler tool.
Signed-off-by: Sagar Ghuge
---
src/intel/compiler/brw_disasm.c | 2 +-
1 file changed, 1 insertion(+),
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
Reviewed-by: Emil Velikov
---
Sorry about the spam, but I realized Emils r-b wasn't
included in
Mesa 18.2.5 is now available.
In this release we have:
A patch for nine state tracker that fixes several crashes using nine's
thread_submit feature. There are other patches to other state trackers.
A couple of patches for Meson build system, as well as for autotools.
In the drivers side, there
From: Gert Wollny
Use EXT_framebuffer_sRGB to expose EXT_sRGB_write_control on GLES. Remove
the checks for desktion GL in the enable calls, since EXT_framebuffer_sRGB
now also indicates support for switching the linear-sRGB color
space conversion on GLES.
This patch enables and makes pass
From: Gert Wollny
EXT_sRGB is an (incomplete) GLES extension that provides support for sRGB
framebuffer attachments, hence it can be used to check for this support
as an alternative to EXT_framebuffer_sRGB that provides the same
functionality but also sRGB write control support.
However, since
From: Gert Wollny
For GLES sRGB framebuffer attachemnt support is provided in two steps:
(1) sRGB attachments like described in EXT_sRGB (and GLES 3.0) that enable
linear to sRGB color space transformation automatically, and (2) the ability
to switch formats of the render target surface between
From: Gert Wollny
GLES 3.0 does not actually require support for EXT_framebuffer_sRGB, it
only needs support for sRGB attachments to framebuffers and framebuffer
objects as defined in ARB_framebuffer_objects.
v2: Clarify that ARB_framebuffer_objects is needed.
Signed-off-by: Gert Wollny
---
From: Gert Wollny
All drivers that support EXT_framebuffer_sRGB also support EXT_sRGB, but
in order to keep this commit minimal, and not to break any drivers both
flags are checked.
v2: - Use only EXT_sRGB (Ilia Mirkin)
- Move adding the flag EXT_sRGB to gl_extensions to a separate patch
From: Gert Wollny
Add a new cap that indicates whether the drivers supports
enabling/disabling the conversion from linear space to sRGB
for a framebuffer attachment. In Driver terms that this CAP indicates
whether the driver can switch between a linear and and a sRGB surface
format for draw
From: Gert Wollny
v2: - Use the renamed CAPS
- add assertions to make sure that mesa doesn't try to switch
destination surface formats when it is not supported. (Ilia Mirkin)
Signed-off-by: Gert Wollny
---
src/gallium/drivers/virgl/virgl_context.c | 10 ++
From: Gert Wollny
Signed-off-by: Gert Wollny
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index d7e02efb54..ca369e39f2 100644
---
From: Gert Wollny
Dear all,
after the RFC and Ilias comments I reworked the series another time.
Changes with respect to the RFC are
- renaming the new CAP
- reordering of the patches that no double checking of
EXT_sRGB and EXT_framebuffer_sRGB is needed.
thanks for reviewing,
Following the support for fences on the virtio driver add support
for native fence on virgl. This was somewhat based on the freedeno one.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
This patch has been tested using Qemu & Virglrenderer.
Linux virtgpu fences branch:
On 14/11/2018 22:38, Jason Ekstrand wrote:
> I just sent one more, "nir/lower_io: Add shared to get_io_offset_src"
> that's required for the pass to apply properly to shared vairables.
>
I have reviewed it too.
> Do we have any testing of shared variables with anything other than 32
> bits?
Nice, seems to halve CPU cost of submitting 100 command buffers in 1
submit with the simultaneous use flag set.
Reviewed-by: Bas Nieuwenhuizen
for the series.
On Thu, Nov 15, 2018 at 11:27 AM Samuel Pitoiset
wrote:
>
> The chained submission is the fastest path and it should now
> be used more
Reviewed-by: Samuel Iglesias Gonsálvez
On 14/11/2018 22:36, Jason Ekstrand wrote:
> ---
> src/compiler/nir/nir_lower_io.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c
> index f3377eaec8f..64424307812 100644
> ---
On 14/11/2018 00:23, Jason Ekstrand wrote:
> We have a bunch of code to do this in the back-end compiler but it's
> fairly specific to typed surface messages and the way we emit them.
> This breaks it out into NIR were it's easier to do things a bit more
> generally. It also means we can easily
On Tue, 2018-11-13 at 16:26 -0800, Matt Turner wrote:
> On Mon, Nov 12, 2018 at 8:35 AM Juan A. Suarez Romero
> wrote:
> > Hello list,
> >
> > The candidate for the Mesa 18.2.5 is now available. Currently we have:
> > - 25 queued
> > - 0 nominated (outstanding)
> > - and 2 rejected patch
>
>
This path will be eventually improved later but as it's only
used on SI (or with RADV_DEBUG=noibs), I'm not sure if that
matters much.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 46 ---
1 file changed, 29 insertions(+), 17 deletions(-)
The chained submission is the fastest path and it should now
be used more often than before. This removes some EOP events.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 103 ++
1 file changed, 55 insertions(+), 48 deletions(-)
diff --git
Handle all cases in calculation of layers count for isl_view
taking into account texture view and image unit.
st_convert_image was taken as a reference.
When u->Layered is true the whole level is taken with respect to
image view. In other case only one layer is taken.
v3: (Józef Kucia and Ilia
This has been initially added for a Sascha demo (ie. deferredshadows),
but as far I can tell this seems to no longer be needed.
No CTS changes on GFX9 and I didn't find a game that is affected.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 3 ---
1 file changed, 3
On Thu, 15 Nov 2018, 10:11 Samuel Pitoiset After doing a bunch of benchmarks, primitive binning helps
> some games like The Talos Principle (+5%) or Serious Sam 2017
> (+3%). For other titles, either it doesn't change anything or
> it hurts very few (less than 1%).
>
> This only affects GFX9.
>
>
https://bugs.freedesktop.org/show_bug.cgi?id=108742
--- Comment #1 from coolo...@gmail.com ---
Seems to definitely be a mesa issue and not llvm, built mesa 18.2.0 with latest
llvm and the issue does not occur. Will attempt to bisect
--
You are receiving this mail because:
You are the QA Contact
On Wed, 2018-11-14 at 18:52 +, Emil Velikov wrote:
> On Wed, 14 Nov 2018 at 18:51, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > Currently we detect when a breaking commit:
> > - has landed in stable, and
> > - is referenced by a untagged fix in master
> >
> > Yet we did not
On Thu, 2018-11-08 at 15:05 +, Emil Velikov wrote:
> From: Emil Velikov
>
> With later commits we'll fold all the different scripts into one.
> Add the explicit prefix, so that we know the origin of the nomination
>
> v2:
> - pass the sha as argument to the function
> - drop $tag = none
On 11/15/18 10:07 AM, Bas Nieuwenhuizen wrote:
On Thu, Nov 15, 2018 at 9:06 AM Samuel Pitoiset
wrote:
On 11/15/18 12:16 AM, Bas Nieuwenhuizen wrote:
On Wed, Nov 14, 2018 at 5:32 PM Samuel Pitoiset
wrote:
On 11/14/18 5:28 PM, Bas Nieuwenhuizen wrote:
On Wed, Nov 14, 2018 at 5:26 PM
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_debug.h | 1 +
src/amd/vulkan/radv_device.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h
index 9fe4c3b740..397d567961 100644
--- a/src/amd/vulkan/radv_debug.h
+++
After doing a bunch of benchmarks, primitive binning helps
some games like The Talos Principle (+5%) or Serious Sam 2017
(+3%). For other titles, either it doesn't change anything or
it hurts very few (less than 1%).
This only affects GFX9.
Signed-off-by: Samuel Pitoiset
---
On Thu, Nov 15, 2018 at 9:06 AM Samuel Pitoiset
wrote:
>
>
>
> On 11/15/18 12:16 AM, Bas Nieuwenhuizen wrote:
> > On Wed, Nov 14, 2018 at 5:32 PM Samuel Pitoiset
> > wrote:
> >>
> >>
> >>
> >> On 11/14/18 5:28 PM, Bas Nieuwenhuizen wrote:
> >>> On Wed, Nov 14, 2018 at 5:26 PM Samuel Pitoiset
>
Hi;
On 11/13/18 4:28 AM, Timothy Arceri wrote:
Sorry for not getting back sooner on this one.
I'm leaning towards a NAK on this one. This is just under 300 new lines
of code to work around a possibly over strict piglit test. While the
test is not wrong an implementation is also not required
On 11/15/18 12:16 AM, Bas Nieuwenhuizen wrote:
On Wed, Nov 14, 2018 at 5:32 PM Samuel Pitoiset
wrote:
On 11/14/18 5:28 PM, Bas Nieuwenhuizen wrote:
On Wed, Nov 14, 2018 at 5:26 PM Samuel Pitoiset
wrote:
+5% in ultra settings for both 4k and 1080p.
Signed-off-by: Samuel Pitoiset
---
71 matches
Mail list logo
