Re: [Mesa-dev] [PATCH 2/5] radv: add radv_process_depth_image_layer() helper

Wouldn't it be much better if we do all the layers in a single draw instead? On Tue, Jul 2, 2019 at 2:47 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_decompress.c | 137 ++ > 1 file changed, 74 insertions(+), 63 deletions(

Re: [Mesa-dev] [PATCH v2 7/7] radv: enable DCC for layers on GFX8

r-b for the series On Mon, Jul 1, 2019 at 4:27 PM Samuel Pitoiset wrote: > > It's currently only enabled if dcc_slice_size is equal to > dcc_slice_fast_clear_size because the driver assumes that > portions of multiple layers are contiguous but it's not > always true. > > Still not supported on GF

Re: [Mesa-dev] [PATCH 2/3] radv: merge radv_dcc_clear_level() into radv_clear_dcc()

On Mon, Jul 1, 2019 at 2:15 PM Samuel Pitoiset wrote: > > > On 7/1/19 2:13 PM, Bas Nieuwenhuizen wrote: > > On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset > > wrote: > >> This will help for clearing DCC arrays because we need to know > >> the subresour

Re: [Mesa-dev] [PATCH 2/3] radv: merge radv_dcc_clear_level() into radv_clear_dcc()

On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset wrote: > > This will help for clearing DCC arrays because we need to know > the subresource range. How will it help? I don't think we use it in the next commit in the series? > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_clea

Re: [Mesa-dev] [PATCH 3/3] radv: fix decompressing DCC levels with compute

r-b On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c > b/src/amd/vulkan/radv_meta_fast_cl

Re: [Mesa-dev] [PATCH 1/3] radv: make sure to mark the image as compressed when clearing DCC levels

r-b On Thu, Jun 27, 2019 at 3:02 PM Samuel Pitoiset wrote: > > Found while working on DCC for arrays. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 22 ++ > src/amd/vulkan/radv_meta.h | 3 --- > src/amd/vulkan/radv_meta_clear.c | 10 +++

Re: [Mesa-dev] [PATCH 4/4] radv: rework how the number of VGPRs is computed

r-b for the series On Wed, Jun 26, 2019 at 3:07 PM Samuel Pitoiset wrote: > > Just a cleanup, it shouldn't change anything. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 22 > src/amd/vulkan/radv_shader.c | 34 ++

Re: [Mesa-dev] [PATCH 1/6] ac: compute the size of one DCC slice on GFX8

On Fri, Jun 28, 2019 at 9:19 AM Samuel Pitoiset wrote: > > Addrlib doesn't provide this info. Because DCC is linear, at least > on GFX8, it's easy to compute the size one slice. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_surface.c | 6 ++ > src/amd/common/ac_surface.h | 1 +

Re: [Mesa-dev] [PATCH] radv: add si_emit_ia_multi_vgt_param() helper

R-b On Wed, Jun 26, 2019, 9:20 AM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 34 +++- > 1 file changed, 25 insertions(+), 9 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv

Re: [Mesa-dev] [PATCH] radv: only export clip/cull distances if PS reads them

R-b On Wed, Jun 26, 2019, 4:32 PM Samuel Pitoiset wrote: > The only exception is the GS copy shader which emits them > unconditionally. > > Totals from affected shaders: > SGPRS: 71320 -> 71008 (-0.44 %) > VGPRS: 54372 -> 54240 (-0.24 %) > Code Size: 2952628 -> 2941368 (-0.38 %) bytes > Max Wave

Re: [Mesa-dev] [PATCH] radv: fix FMASK expand if layerCount is VK_REMAINING_ARRAY_LAYERS

R-b On Wed, Jun 26, 2019, 4:20 PM Samuel Pitoiset wrote: > This doesn't fix anything known, but it's likely going to > break if layerCount is ~0U. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fmask_expand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH] radv: rename and re-document cache flush flags

r-b On Tue, Jun 25, 2019 at 5:54 PM Samuel Pitoiset wrote: > > SMEM and VMEM caches are L0 on gfx10. Ported from RadeonSI. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c| 16 - > src/amd/vulkan/radv_device.c| 12 +++ > src/amd/vulkan/

Re: [Mesa-dev] [PATCH] radv: set DISABLE_CONSTANT_ENCODE_REG to 1 for Raven2

r-b On Tue, Jun 25, 2019 at 4:13 PM Samuel Pitoiset wrote: > > Ported from RadeonSI, will be emitted for GFX10 too. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 5 - > src/amd/vulkan/radv_device.c | 2 ++ > src/amd/vulkan/radv_private.h| 3 +++ > 3 f

Re: [Mesa-dev] [PATCH 5/8] radeonsi: don't set spi_ps_input_* for monolithic shaders

n 21, 2019 at 7:03 PM Bas Nieuwenhuizen > wrote: >> >> Doesn't this cause assertions in si_shader_ps() for monolithic >> shaders? Some of these assertions check that at least one bit in a >> group is set and I think we end up with input_ena = 0 for monolithic >&g

Re: [Mesa-dev] [PATCH 2/2] radv: always initialize levels without DCC as fully expanded

r-b for this patch only. On Mon, Jun 24, 2019 at 5:00 PM Samuel Pitoiset wrote: > > This fixes a rendering issue with RoTR/DXVK. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 32 +++- > 1 file changed, 15 insertions(+), 17 deletions(-)

Re: [Mesa-dev] [PATCH 1/2] radv: fix setting CB_DCC_BASE if the base level doesn't enable DCC

why? We should be regulating enabling it with S_028C70_DCC_ENABLE. On Mon, Jun 24, 2019 at 5:00 PM Samuel Pitoiset wrote: > > CB_DCC_BASE should be 0 if no DCC. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 15 --- > 1 file changed, 8 insertions(+), 7 de

Re: [Mesa-dev] [PATCH] radv: clear FMASK layers instead of the whole buffer on GFX8

r-b On Mon, Jun 24, 2019 at 12:14 PM Samuel Pitoiset wrote: > > This reduces the size of fill operations needed to clear FMASK > for layered color textures. > > GFX9 unsupported for now. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_surface.c | 1 + > src/amd/common/

Re: [Mesa-dev] [PATCH] radv: clear CMASK layers instead of the whole buffer on GFX8

r-b On Mon, Jun 24, 2019 at 6:37 PM Samuel Pitoiset wrote: > > This reduces the size of fill operations needed to clear CMASK > for layered color textures. > > GFX9 unsupported for now. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_surface.c | 3 ++- > src/amd/common/ac_sur

Re: [Mesa-dev] [PATCH] radv: add support for VK_AMD_buffer_marker

R-b On Fri, Jun 21, 2019, 4:14 PM Samuel Pitoiset wrote: > This simple extension might be useful for debugging purposes. > GAPID has support for it. > > Signed-off-by: Samuel Pitoiset > --- > > A simple crucible test: > https://gitlab.freedesktop.org/mesa/crucible/merge_requests/47 > > src/amd

Re: [Mesa-dev] [PATCH 5/8] radeonsi: don't set spi_ps_input_* for monolithic shaders

Doesn't this cause assertions in si_shader_ps() for monolithic shaders? Some of these assertions check that at least one bit in a group is set and I think we end up with input_ena = 0 for monolithic shaders now? On Thu, Jun 20, 2019 at 6:20 AM Marek Olšák wrote: > > From: Marek Olšák > > The dri

Re: [Mesa-dev] [PATCH 2/8] amd/rtld: update the ELF representation of LDS symbols

Marek, I thought you also r-b'd this? Either way r-b. On Thu, Jun 20, 2019 at 6:20 AM Marek Olšák wrote: > > From: Nicolai Hähnle > > The initial prototype used a processor-specific symbol type, but > feedback suggests that an approach using processor-specific section > name that encodes the al

Re: [Mesa-dev] [PATCH v2 6/9] radv: decompress HTILE if the resolve src image is compressed

We only need this if the HTILE is not tc-compat? Otherwise the read side is independent of compute/fragment shader. On Wed, Jun 12, 2019 at 11:44 AM Samuel Pitoiset wrote: > > It's required to decompress HTILE before resolving with the > compute path. > > v2: - do proper layout transitions >

Re: [Mesa-dev] [PATCH v2 7/9] radv: clear the depth/stencil resolve attachment if necessary

r-b On Wed, Jun 12, 2019 at 11:44 AM Samuel Pitoiset wrote: > > The driver might need to clear one aspect of the depth/stencil > resolve attachment before performing the resolve itself. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_clear.c | 73

Re: [Mesa-dev] [PATCH 6/8] radeonsi: flatten the switch for DPBB tunables

r-b On Thu, Jun 20, 2019 at 6:20 AM Marek Olšák wrote: > > From: Marek Olšák > > --- > .../drivers/radeonsi/si_state_binning.c| 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state_binning.c > b/src/gallium/dri

Re: [Mesa-dev] [PATCH 4/8] radeonsi: set the calling convention for inlined function calls

r-b On Thu, Jun 20, 2019 at 6:19 AM Marek Olšák wrote: > > From: Marek Olšák > > otherwise the behavior is undefined > --- > src/amd/common/ac_llvm_build.c | 8 > src/amd/common/ac_llvm_build.h | 3 +++ > src/gallium/drivers/radeonsi/si_c

Re: [Mesa-dev] [PATCH v2 2/9] radv: record if a render pass has depth/stencil resolve attachments

R-b On Wed, Jun 12, 2019, 11:44 AM Samuel Pitoiset wrote: > Only supported with vkCreateRenderPass2(). > > v2: - do not set has_resolve (now has_color_resolve) for ds resolves > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pass.c| 27 ++- > src/amd/v

Re: [Mesa-dev] [PATCH v2 1/9] radv: rename has_resolve to has_resolve_color

Please fix the title to use the correct variable name. Otherwise r-b On Wed, Jun 12, 2019, 11:44 AM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve.c | 2 +- > src/amd/vulkan/radv_pass.c | 4 ++-- > src/amd/vulkan/radv_private.h | 4

Re: [Mesa-dev] [PATCH v2 1/6] radv: initialize levels without DCC during layout transitions

R-b for the series On Thu, Jun 20, 2019, 9:14 AM Samuel Pitoiset wrote: > v2: use a different path for GFX9 > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 49 +++- > 1 file changed, 48 insertions(+), 1 deletion(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH] radv: disable viewport clamping even if FS doesn't write Z

R-b On Tue, Jun 18, 2019, 6:55 PM Samuel Pitoiset wrote: > This fixes new CTS dEQP-VK.pipeline.depth_range_unrestricted.*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_pi

Re: [Mesa-dev] [PATCH 1/6] radv: initialize levels without DCC during layout transitions

R-b On Tue, Jun 18, 2019, 4:12 PM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 40 +++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv_

Re: [Mesa-dev] [PATCH 1/6] radv: initialize levels without DCC during layout transitions

Actually, retract r-b, please fix the legacy accesses on gfx9+ too. On Wed, Jun 19, 2019, 11:02 AM Bas Nieuwenhuizen wrote: > R-b > > On Tue, Jun 18, 2019, 4:12 PM Samuel Pitoiset > wrote: > >> Signed-off-by: Samuel Pitoiset >> --- >> src/

Re: [Mesa-dev] [PATCH] radv: implement compressed FMASK texture reads with RADV_PERFTEST=tccompatcmask

Oops. No, r-b On Wed, Jun 19, 2019, 9:48 AM Samuel Pitoiset wrote: > > On 6/17/19 12:24 PM, Bas Nieuwenhuizen wrote: > > > > > On Thu, Jun 13, 2019, 3:42 PM Samuel Pitoiset > wrote: > >> This allows us to disable the FMASK decompress pass when >> trans

Re: [Mesa-dev] [PATCH 5/6] radv: do not fast clears if one level can't be fast cleared

On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > And fallback to slow color clears. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_clear.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/amd/vulkan/radv_meta_clear.c > b/src/amd/vulkan/

Re: [Mesa-dev] [PATCH 6/6] radv: enable DCC for mipmapped color textures on GFX8

r-b On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > It's tricky on GFX9, so only GFX8 for now. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_image.c b/src/am

Re: [Mesa-dev] [PATCH 4/6] radv: add fast clears support for mipmapped color images with DCC

r-b On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_clear.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_meta_clear.c > b/src/amd/vulkan/radv_meta_clear.c > i

Re: [Mesa-dev] [PATCH 3/6] radv: add radv_dcc_clear_level() helper

On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > For clearing only one level. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta.h | 3 +++ > src/amd/vulkan/radv_meta_clear.c | 23 --- > 2 files changed, 23 insertions(+), 3 deletions(-) > > d

Re: [Mesa-dev] [PATCH 2/6] radv: re-initialize DCC metadata after decompressing using compute

r-b On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c > b/src/amd/vulkan/radv_meta_fast_cle

Re: [Mesa-dev] [PATCH] radv: fix FMASK expand with SRGB formats

r-b Fixes tag? On Tue, Jun 18, 2019 at 4:07 PM Samuel Pitoiset wrote: > > Found while working on DCC for MSAA. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fmask_expand.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_meta_

Re: [Mesa-dev] [PATCH] radeonsi: fix undefined shift in macro definition

Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 18, 2019 at 11:20 PM Dave Airlie wrote: > > From: Dave Airlie > > Pointed out by coverity > --- > src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH] radv: adjust the DCC base VA for mipmapped color attachments

Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 18, 2019 at 11:48 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/

Re: [Mesa-dev] [PATCH] radv: fix color decompressions for FMASK/CMASK

Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 18, 2019 at 11:58 AM Samuel Pitoiset wrote: > > Only skip levels without DCC when it's a DCC decompression. > Whoops. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 3 ++- > 1 fil

Re: [Mesa-dev] [PATCH 3/3] radv: do not decompress levels without DCC with the graphics path

R-b for the series On Tue, Jun 18, 2019, 10:27 AM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 35 +++ > 1 file changed, 20 insertions(+), 15 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c >

Re: [Mesa-dev] [PATCH 7/8] radv: add mipmaps support for color decompressions (DCC/FMASK/CMASK)

On Mon, Jun 17, 2019 at 10:06 PM Samuel Pitoiset wrote: > > > On 6/17/19 10:01 PM, Bas Nieuwenhuizen wrote: > > On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset > > wrote: > >> And some cleanups. > >> > >> Signed-off-by: Samuel Pitoiset >

Re: [Mesa-dev] [PATCH 1/8] radv: allocate DCC metadata for each mip

with that fixed, r-b On Mon, Jun 17, 2019 at 12:51 PM Samuel Pitoiset wrote: > > > On 6/17/19 12:50 PM, Bas Nieuwenhuizen wrote: > > On Mon, Jun 17, 2019 at 12:40 PM Samuel Pitoiset > > wrote: > >> Signed-off-by: Samuel Pitoiset > >> --- > >> s

Re: [Mesa-dev] [PATCH 8/8] radv: add mipmaps support for DCC decompression on compute

r-b On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 106 +- > 1 file changed, 54 insertions(+), 52 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c > b/src/amd/

Re: [Mesa-dev] [PATCH 7/8] radv: add mipmaps support for color decompressions (DCC/FMASK/CMASK)

On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset wrote: > > And some cleanups. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 228 +++--- > 1 file changed, 129 insertions(+), 99 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_cl

Re: [Mesa-dev] [PATCH] amd: update addrlib

On Mon, Jun 17, 2019 at 9:19 PM Marek Olšák wrote: > > On Sat, Jun 15, 2019 at 5:51 PM Bas Nieuwenhuizen > wrote: >> >> I'm not quite sure why the dimension changes are needed for radeonsi, >> but for both polarisd and vega the compressed texture CTS tests p

[Mesa-dev] [PATCH] radv: Disable linear tiled compressed textures.

Support got removed in the new addrlib update. --- src/amd/vulkan/radv_formats.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index e61d793e7f2..e8470a1622e 100644 --- a/src/amd/vulkan/radv_formats.c +++ b/src/amd/vulkan/radv_

Re: [Mesa-dev] [PATCH 6/8] radv: set the DCC/FCE predicates from the base level

r-b On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c > b/src/amd/vulkan/radv_meta_fast_clear.c > index 8fba2a

Re: [Mesa-dev] [PATCH 4/8] radv: store the DCC predicate for each mip

r-b On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 41 ++- > src/amd/vulkan/radv_meta.h| 3 +- > src/amd/vulkan/radv_meta_clear.c | 8 -- > src/amd/vulkan/r

Re: [Mesa-dev] [PATCH 5/8] radv: load the fast color clear values from the base level

r-b On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv_cmd_buffer.c >

Re: [Mesa-dev] [PATCH 3/8] radv: store the FCE predicate for each mip

r-b On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 19 --- > src/amd/vulkan/radv_meta_clear.c | 9 - > src/amd/vulkan/radv_meta_fast_clear.c | 2 +- > src/amd/vulkan/radv_p

Re: [Mesa-dev] [PATCH 2/8] radv: store the fast color clear values for each mip

r-b On Mon, Jun 17, 2019 at 12:41 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 38 +++- > src/amd/vulkan/radv_meta_clear.c | 2 +- > src/amd/vulkan/radv_private.h| 12 +- > 3 files changed, 39 in

Re: [Mesa-dev] [PATCH 1/8] radv: allocate DCC metadata for each mip

On Mon, Jun 17, 2019 at 12:40 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c > index 909145e1e75..d3bbc9e67

Re: [Mesa-dev] [PATCH] radv: implement compressed FMASK texture reads with RADV_PERFTEST=tccompatcmask

On Thu, Jun 13, 2019, 3:42 PM Samuel Pitoiset wrote: > This allows us to disable the FMASK decompress pass when > transitioning from CB writes to shader reads. > > This will likely be improved and enabled by default in the future. > > No CTS regressions on GFX8 but a few number of multisample CTS

Re: [Mesa-dev] [PATCH] radv: make sure to init the DCC decompress compute path state

R-b On Thu, Jun 13, 2019, 12:40 PM Samuel Pitoiset wrote: > This fixes a segfault when forcing DCC decompressions on compute > because internal meta objects are not created since the on-demand > stuff. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 8 +++

Re: [Mesa-dev] [PATCH] radv: emit framebuffer state from primary if secondary doesn't herit it

Can we fix the title?(inherit) On Thu, Jun 13, 2019, 1:53 PM Samuel Pitoiset wrote: > Otherwise fast color/depth clears can't work because they depend > on the framebuffer. > > This fixes the following CTS (when the small hint is disabled): > - dEQP-VK.geometry.layered.1d_array.secondary_cmd_buf

Re: [Mesa-dev] [PATCH 1/2] radv: rely on ac_compute_cmask() for CMASK info

R-b for the series On Thu, Jun 13, 2019, 5:14 PM Samuel Pitoiset wrote: > Instead of re-computing in the driver. The 3d and cube flags > are correctly set, so the same values should returned by > ac_compute_surface(). > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 45

Re: [Mesa-dev] [PATCH] amd: update addrlib

I'm not quite sure why the dimension changes are needed for radeonsi, but for both polarisd and vega the compressed texture CTS tests pass on RADV. Acked-by: Bas Nieuwenhuizen Tested-by: Bas Nieuwenhuizen On Sat, Jun 15, 2019 at 12:47 AM Marek Olšák wrote: > > From:

Re: [Mesa-dev] [PATCH] radeonsi: reduce MAX_GEOMETRY_OUTPUT_VERTICES

Reviewed-by: Bas Nieuwenhuizen On Sat, Jun 15, 2019 at 1:00 AM Marek Olšák wrote: > > From: Nicolai Hähnle > > This fixes piglit spec@glsl-1.50@gs-max-output. > --- > src/gallium/drivers/radeonsi/si_get.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > &g

Re: [Mesa-dev] [PATCH] ac: update llvm.amdgcn.icmp intrinsic name for LLVM 9+

r-b On Fri, Jun 14, 2019 at 11:57 AM Samuel Pitoiset wrote: > > LLVM r363339 changed llvm.amdgcn.icmp.i* to llvm.amdgcn.icmp.i64.i*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/amd/

Re: [Mesa-dev] [PATCH] radv: flush and invalidate CB before resetting query pools on GFX9

Add DB while we are at it? Otherwise, r-b On Thu, Jun 13, 2019 at 10:51 AM Samuel Pitoiset wrote: > > We have to emit a CACHE_FLUSH_AND_INV_TS_EVENT to be sure all > prior GPU work is done. > > This fixes the following CTS (when the small hint is disabled): > dEQP-VK.query_pool.statistics_query.

Re: [Mesa-dev] [PATCH 2/2] radv: fix VK_EXT_memory_budget if one heap isn't available

r-b with the vega m ref changed in the commit message. On Wed, Jun 12, 2019 at 11:18 AM Samuel Pitoiset wrote: > > > On 6/12/19 9:58 AM, Michel Dänzer wrote: > > On 2019-06-11 5:03 p.m., Samuel Pitoiset wrote: > >> On 6/11/19 4:56 PM, Alex Deucher wrote: > >>> On Tue, Jun 11, 2019 at 10:43 AM Sam

Re: [Mesa-dev] [PATCH 2/2] radv: fix VK_EXT_memory_budget if one heap isn't available

So can we rephrase this entire thing based on physical_devices->mem_type_indices, instead of opencoding ordering & detection? On Tue, Jun 11, 2019 at 4:43 PM Samuel Pitoiset wrote: > > On VegaM, the visible VRAM size is equal to the VRAM size, which > means only two heaps are exposed. > > This fi

Re: [Mesa-dev] [PATCH 1/2] radv: fix occlusion queries on VegaM

So allowing disabled render backends without pre-setting them in the reset procedure will break the OCCLUSION_QUERY packet. Luckily we don't seem to use it for radv (yet?). Maybe find a way to comment that somewhere? Otherwise, r-b On Tue, Jun 11, 2019 at 4:43 PM Samuel Pitoiset wrote: > > The n

Re: [Mesa-dev] [PATCH 5/5] radv: add radv_get_resolve_pipeline() helper in the graphics path

r-b On Mon, Jun 10, 2019 at 5:42 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve_fs.c | 41 +++ > 1 file changed, 29 insertions(+), 12 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c > b/src/amd/v

Re: [Mesa-dev] [PATCH 4/5] radv: do not decompress all image layers before resolving inside a subpass

r-b On Mon, Jun 10, 2019 at 5:42 PM Samuel Pitoiset wrote: > > When decompressing resolve source images, we should rely on the > framebuffer layer count instead of resolving all images layers. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve.c | 12 +--- > 1 f

Re: [Mesa-dev] [PATCH 3/5] radv: initialize the aspect mask when decompressing resolve source images

r-b On Mon, Jun 10, 2019 at 5:42 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/amd/vulkan/radv_meta_resolve.c > b/src/amd/vulkan/radv_meta_resolve.c > index 817182e17d9..0a7af

Re: [Mesa-dev] [PATCH 1/5] radv: do not resolve all image layers with compute inside a subpass

r-b On Mon, Jun 10, 2019 at 5:42 PM Samuel Pitoiset wrote: > > When resolving inside a subpass, we should rely on the framebuffer > layer count instead of resolving all images layers. This should > improve performance of layered resolves a bit. > > Signed-off-by: Samuel Pitoiset > --- > src/amd

Re: [Mesa-dev] [PATCH 2/5] radv: perform proper layout transitions before resolving

r-b On Mon, Jun 10, 2019 at 5:42 PM Samuel Pitoiset wrote: > > Use an explicit pipeline barrier for doing layout transitions > instead of duplicating some code. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve.c | 38 +++--- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

On Sat, Jun 8, 2019 at 3:36 PM Alex Smith wrote: > > On Mon, 3 Jun 2019 at 13:27, Koenig, Christian > wrote: >> >> Am 03.06.19 um 14:21 schrieb Alex Smith: >> >> On Mon, 3 Jun 2019 at 11:57, Koenig, Christian >> wrote: >>> >>> Am 02.06.19 um 12:32 schrieb Alex Smith: >>> > Put the uncached GTT

Re: [Mesa-dev] [PATCH] radv: fix alpha-to-coverage when there is unused color attachments

r-b On Thu, Jun 6, 2019 at 4:27 PM Samuel Pitoiset wrote: > > When alphaToCoverage is enabled, we should always write the alpha > channel of MRT0 if it's unused. This now matches RadeonSI. > > This fixes the new CTS: > dEQP-VK.pipeline.multisample.alpha_to_coverage_unused_attachment.samples_*.alp

Re: [Mesa-dev] [PATCH 6/8] radv: handle sample locations during automatic layout transitions

On Thu, Jun 6, 2019, 10:07 AM Samuel Pitoiset wrote: > > On 6/6/19 3:41 AM, Bas Nieuwenhuizen wrote: > > On Wed, Jun 5, 2019 at 12:04 PM Samuel Pitoiset > > wrote: > >> > >> On 6/5/19 2:51 AM, Bas Nieuwenhuizen wrote: > >>> On Thu, May

Re: [Mesa-dev] [PATCH 6/8] radv: handle sample locations during automatic layout transitions

On Wed, Jun 5, 2019 at 12:04 PM Samuel Pitoiset wrote: > > > On 6/5/19 2:51 AM, Bas Nieuwenhuizen wrote: > > On Thu, May 30, 2019 at 4:02 PM Samuel Pitoiset > > wrote: > >> From the Vulkan spec 1.1.109: > >> > >> "Some implementations ma

Re: [Mesa-dev] [PATCH] radv: set the subpass before any initial subpass transitions

r-b On Mon, Jun 3, 2019 at 3:45 PM Bas Nieuwenhuizen wrote: > > While it is not wrong, I don't think this is the right fix, as the > current_layout is not necessarily accurate. > > Will try to get something better. > > On Thu, May 30, 2019 at 3:10 PM Samuel Pitoiset &g

Re: [Mesa-dev] [PATCH] Revert "radv: fix color conversions for normalized uint/sint formats"

r-b On Wed, Jun 5, 2019 at 12:02 PM Samuel Pitoiset wrote: > > For some reasons, this actually introduced rendering issues with > Far Cry 3 (and probably Far Cry 4). I'm reverting it for now > until I figure out the right fix. > > See the following link for reference: > https://github.com/ValveSo

Re: [Mesa-dev] [PATCH 8/8] radv: enable VK_EXT_sample_locations

Most of the series looks reasonable to me besides the few comments added. That said looking back at the patch you committed I don't think we revert to the default locations the right way. We return early from radv_update_multisample_state if the old pipeline has the same number of samples, which

Re: [Mesa-dev] [PATCH 6/8] radv: handle sample locations during automatic layout transitions

On Thu, May 30, 2019 at 4:02 PM Samuel Pitoiset wrote: > > From the Vulkan spec 1.1.109: > >"Some implementations may need to evaluate depth image values > while performing image layout transitions. To accommodate this, > instances of the VkSampleLocationsInfoEXT structure can be >

Re: [Mesa-dev] [PATCH 1/8] radv: allow to save/restore sample locations during meta operations

On Thu, May 30, 2019 at 4:02 PM Samuel Pitoiset wrote: > > This will be used for the depth decompress pass that might need > to emit variable sample locations during layout transitions. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta.c | 20 > src/amd/vul

Re: [Mesa-dev] [PATCH] radv: do not use gfx fast depth clears for layered depth/stencil images

r-b On Mon, Jun 3, 2019 at 5:49 PM Samuel Pitoiset wrote: > > The driver should only fast depth clears with the graphics path > when the view covers all image layers, otherwise this might > corrupt layers when HTILE is enabled. > > Cc: 19.0 19.1 mesa-sta...@lists.freedesktop.org > Signed-off-by:

Re: [Mesa-dev] [PATCH] radv: set the subpass before any initial subpass transitions

While it is not wrong, I don't think this is the right fix, as the current_layout is not necessarily accurate. Will try to get something better. On Thu, May 30, 2019 at 3:10 PM Samuel Pitoiset wrote: > > This might fix initial subpass transitions when multiview is used. > Noticed while implement

Re: [Mesa-dev] [PATCH] radv: flush pending query reset caches before copying results

r-b On Fri, May 24, 2019 at 10:06 AM Samuel Pitoiset wrote: > > From the Vulkan spec 1.1.108: >"vkCmdCopyQueryPoolResults is guaranteed to see the effect of > previous uses of vkCmdResetQueryPool in the same queue, without any > additional synchronization." > > Signed-off-by: Samuel P

Re: [Mesa-dev] Error: unsupported relocations

On Sun, Jun 2, 2019 at 12:41 PM James Harvey wrote: > > On Sat, Jun 1, 2019 at 10:56 PM Jan Vesely wrote: > > On Sat, 2019-06-01 at 18:21 -0400, James Harvey wrote: > > > On Sat, Jun 1, 2019 at 6:19 PM James Harvey > > > wrote: > > > > On Tue, Feb 19, 2019 at 7:52 PM james harvey > > > > wrot

Re: [Mesa-dev] [PATCH] radv: Change memory type order for GPUs without dedicated VRAM

applications pushing out driver internal stuff (descriptor sets etc.) from "VRAM", posssibly hitting perf elsewhere. That said, Reviewed-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_device.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) >

Re: [Mesa-dev] [PATCH] ac: use amdgpu-flat-work-group-size

Reviewed-by: Bas Nieuwenhuizen Thanks! On Fri, May 31, 2019 at 10:08 PM Marek Olšák wrote: > > From: Marek Olšák > > --- > src/amd/common/ac_llvm_util.c| 10 ++ > src/amd/common/ac_llvm_util.h| 1 + > src/amd/vulkan/radv_nir_

Re: [Mesa-dev] [PATCH] ac/nir: mark some texture intrinsics as convergent

On Fri, May 31, 2019, 12:49 AM Marek Olšák wrote: > > > On Thu, May 30, 2019, 6:44 PM Bas Nieuwenhuizen > wrote: > >> >> >> On Thu, May 30, 2019, 11:45 PM Marek Olšák wrote: >> >>> >>> >>> On Thu, May 30, 2019, 3:54 PM Rhys

Re: [Mesa-dev] [PATCH] ac/nir: mark some texture intrinsics as convergent

he intrinsic is marked as convergent >> >> Cc: >> Signed-off-by: Rhys Perry >> Reviewed-By: Bas Nieuwenhuizen >> --- >> src/amd/common/ac_nir_to_llvm.c | 12 >> 1 file changed, 12 insertions(+) >> >> diff --git a/src/amd/common/ac_n

Re: [Mesa-dev] [PATCH] ac/nir: mark some texture intrinsics as convergent

On Thu, May 30, 2019 at 6:50 PM Rhys Perry wrote: > > Otherwise LLVM can sink them and their texture coordinate calculations > into divergent branches. > > Cc: > Signed-off-by: Rhys Perry > --- > src/amd/common/ac_nir_to_llvm.c | 29 + > 1 file changed, 29 insertions

Re: [Mesa-dev] [PATCH] radv: fix some compiler warnings

Or even better, cast it to uint32_t explicitly. On Thu, May 30, 2019 at 8:23 PM Bas Nieuwenhuizen wrote: > > maybe use UINT32_MAX? > > otherwise r-b > > On Thu, May 30, 2019 at 6:50 PM Rhys Perry wrote: > > > > Fixes -Woverflow warnings with GCC 9.1.1 >

Re: [Mesa-dev] [PATCH] radv: fix some compiler warnings

maybe use UINT32_MAX? otherwise r-b On Thu, May 30, 2019 at 6:50 PM Rhys Perry wrote: > > Fixes -Woverflow warnings with GCC 9.1.1 > > Signed-off-by: Rhys Perry > --- > src/amd/vulkan/si_cmd_buffer.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/amd/vulk

Re: [Mesa-dev] [PATCH 2/2] radv: use RADV_CMD_DRITY_DYNAMIC_* when restoring viewport/scissor

r-b for both if you fix the DRITY in the title of this one. On Thu, May 30, 2019 at 12:26 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta.c b/src

Re: [Mesa-dev] [PATCH] radv: enable transformFeedbackStreamsLinesTriangles

r-b On Thu, May 30, 2019 at 10:05 AM Samuel Pitoiset wrote: > > The driver should already support this without any changes. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_device

Re: [Mesa-dev] [PATCH v2] radv: implement VK_EXT_sample_locations

pression. > > Marek > > On Tue, May 21, 2019 at 8:17 PM Bas Nieuwenhuizen > wrote: > >> So this does not seem to use the sample locations during layout >> transitions? >> >> AFAIK those are needed for e.g. HTILE decompression as it is based on >&g

Re: [Mesa-dev] [PATCH 5/7] radv: decompress HTILE if the resolve src image is compressed

On Mon, May 27, 2019 at 5:38 PM Samuel Pitoiset wrote: > > It's required to decompress HTILE before resolving with the > compute path. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/7] radv: record if a render pass has depth/stencil resolve attachments

That seems OK. On Tue, May 28, 2019 at 8:25 AM Samuel Pitoiset wrote: > > > On 5/27/19 6:48 PM, Bas Nieuwenhuizen wrote: > > On Mon, May 27, 2019 at 5:38 PM Samuel Pitoiset > > wrote: > >> Only supported with vkCreateRenderPass2(). > >> > >> Sig

Re: [Mesa-dev] [PATCH] radv: sync before resetting a pool if there is active pending queries

r-b On Tue, May 28, 2019 at 11:05 AM Samuel Pitoiset wrote: > > Make sure to sync all previous work if the given command buffer > has pending active queries. Otherwise the GPU might write queries > data after the reset operation. > > This fixes a bunch of new dEQP-VK.query_pool.* CTS failures. >

Re: [Mesa-dev] [PATCH 1/2] radv: always use view format when performing subpass resolves

Don't you also need to change it in the pipeline selection? (e.g. your newly added radv_get_resolve_pipeline()) Otherwise r-b for the eries. On Tue, May 28, 2019 at 11:02 AM Samuel Pitoiset wrote: > > It makes sense to use the image view formats when resolving > inside subpasses, while we have t

Re: [Mesa-dev] [PATCH] radv: allocate more space in the CS when emitting events

r-b On Tue, May 28, 2019 at 12:54 PM Samuel Pitoiset wrote: > > If the driver waits for CP DMA to be idle and emit an EOP event > we need more space. > > This fixes a crash with Quake Champions. > > Cc: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > 1 file

Re: [Mesa-dev] [PATCH 2/2] radv add radv_get_resolve_pipeline() in the compute path

r-b for the series On Mon, May 27, 2019 at 5:39 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve_cs.c | 56 +-- > 1 file changed, 36 insertions(+), 20 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c

Re: [Mesa-dev] [PATCH] radeonsi: fix timestamp queries for compute-only contexts

Reviewed-by: Bas Nieuwenhuizen On Mon, May 27, 2019 at 10:10 PM Marek Olšák wrote: > > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_fence.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_

<    1   2   3   4   5   6   7   8   9   10   >