Re: [Mesa-dev] VulkanCTS only supporting robustBufferAccess == true?

This is enforcing a hard requirement in the spec: 30.1. Feature Requirements All Vulkan graphics implementations must support the following features: * robustBufferAccess On Fri, Nov 8, 2019 at 1:49 PM wrote: > > Testing my Vulkan driver agains Vulkan CTS, I am a bit suprised, that is >

Re: [Mesa-dev] [PATCH] i965: Fix alpha to one with dual color blending.

Sigh, I should have just ignored the docs when I was poking at this years ago. Reviewed-by: Chris Forbes <chrisfor...@google.com> On Mon, May 29, 2017 at 10:49 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > The BLEND_STATE documentation says that alpha to one must be disab

Re: [Mesa-dev] [PATCH 1/2] i965: Drop unused STATE_TEXRECT_SCALE code.

Nice to see the last remnants of this go. For the series: Reviewed-by: Chris Forbes <chrisfor...@google.com> On Wed, Mar 1, 2017 at 9:53 AM, Kenneth Graunke <kenn...@whitecape.org> wrote: > In the past, we used this on Gen4-5 to transform non-normalized texture > coordinates

Re: [Mesa-dev] [PATCH] mesa: Implement ARB_texture_filter_minmax for i965/gen9+

This looks like it misses the interactions with texture completeness. - Chris On Wed, Feb 1, 2017 at 7:53 AM, Plamena Manolova wrote: > This extension provides a new texture and sampler parameter > (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce a

Re: [Mesa-dev] [PATCH] mesa: Clamp ValueMask to [0, 255].

I don't see any spec justification for masking this. dEQP is broken here. Implementations have the flexibility to retain more bits in the mask (and have more bits set in the initial state) than the depth of the deepest stencil buffer supported. From the ES3 spec, 4.1.4, second to last para:

Re: [Mesa-dev] [PATCH 2/2] i965: Add i965 plumbing for ARB_post_depth_coverage for i965 (gen9+).

here looks good, so: Reviewed-by: Chris Forbes <chrisfor...@google.com> On Thu, Dec 1, 2016 at 9:00 AM, Plamena Manolova <plamena.manol...@intel.com > wrote: > This extension allows the fragment shader to control whether values in > gl_SampleMaskIn[] reflect the coverage

Re: [Mesa-dev] [PATCH 1/2] mesa: Add GL and GLSL plumbing for ARB_post_depth_coverage for i965 (gen9+).

Excellent, disregard that. Patch looks good. On Thu, Dec 1, 2016 at 3:10 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Wed, Nov 30, 2016 at 9:10 PM, Chris Forbes <chr...@ijw.co.nz> wrote: > > This patch misses adding the #define to the GLSL preprocessor. Other than &g

Re: [Mesa-dev] [PATCH 1/2] mesa: Add GL and GLSL plumbing for ARB_post_depth_coverage for i965 (gen9+).

This patch misses adding the #define to the GLSL preprocessor. Other than that it looks good though, so with that fixed: Reviewed-by: Chris Forbes <chrisfor...@google.com> On Thu, Dec 1, 2016 at 8:53 AM, Plamena Manolova <plamena.manol...@intel.com > wrote: > This extension allo

Re: [Mesa-dev] [PATCH] anv: bump the texture gather offset limits

The HW limits here are -8/7 when using the gather4 message. [gather4_po allows -32/31, and specified per channel] On Mon, Nov 28, 2016 at 10:49 AM, Ilia Mirkin wrote: > This matches what NVIDIA and AMD hardware expose. > > Signed-off-by: Ilia Mirkin

[Mesa-dev] [PATCH 2/2] i965: Advertise 8 subpixel bits always.

The mesa default is 4, but we program the hardware for 8 on all generations. Signed-off-by: Chris Forbes <chrisfor...@google.com> --- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dr

[Mesa-dev] [PATCH 1/2] mesa: Remove EXTRA_EXT declaration for ARB_viewport_array

Now that we also have to consider OES_viewport_array & friends, nothing uses this. Signed-off-by: Chris Forbes <chrisfor...@google.com> --- src/mesa/main/get.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 5f5e76a..854f8ab 100644

Re: [Mesa-dev] [PATCH 2/3] mesa: Handle OES_texture_view tokens

This patch isn't right. These enum values are the same as the desktop version, so your new cases will never actually be used. On Mon, Aug 29, 2016 at 2:24 AM, Francesco Ansanelli wrote: > Signed-off-by: Francesco Ansanelli > --- >

Re: [Mesa-dev] [PATCH 7/7] i965: Delete the FS_OPCODE_INTERPOLATE_AT_CENTROID virtual opcode.

I remember arguing about this when it got added -- tradeoff was payload size/register pressure vs needing to call out to this unit, if centroid barycentric coords weren't required for anything else? It does seem fairly pointless, though. For the series:- Reviewed-by: Chris Forbes <chris

Re: [Mesa-dev] [PATCH 2/7] nir: Add a nir_lower_io flag for using load_interpolated_input intrins.

Seems a little unfortunate to add a random bool to this interface which is otherwise fairly descriptive, but OK. On Tue, Jul 19, 2016 at 8:26 AM, Kenneth Graunke wrote: > While my intention is that the new intrinsics should be usable by all > drivers, we need to make them

Re: [Mesa-dev] [PATCH 6/7] i965: Rewrite FS input handling to use the new NIR intrinsics.

On Tue, Jul 19, 2016 at 8:26 AM, Kenneth Graunke wrote: > + default: > + assert(!"invalid intrinsic"); > unreachable() ? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] r600g: add support for B5G6R5 PBO uploads via texture buffers

On Tue, Jul 12, 2016 at 9:59 PM, Marek Olšák wrote: + *endian = r600_endian_swap(32); I don't fully understand r600, but this 32 seems dubious? - Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Don't leak scratch BOs for TCS/TES.

Reviewed-by: Chris Forbes <chrisfor...@google.com> On Mon, Jun 13, 2016 at 12:03 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > These need to be freed too. > > Cc: "12.0" <mesa-sta...@lists.freedesktop.org> > Signed-off-by: Kenneth Graunke <kenn.

Re: [Mesa-dev] [PATCH] mesa/get: return correct value for layer provoking vertex.

Reviewed-by: Chris Forbes <chrisfor...@google.com> On Fri, Jun 3, 2016 at 2:27 PM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > This fixes: > GL45-CTS.geometry_shader.layered_rendering.layered_rendering > > on Skylake.

[Mesa-dev] [PATCH 3/4] mesa: Allow relax various desktop-only checks for cube arrays

Signed-off-by: Chris Forbes <chrisfor...@google.com> --- src/mesa/main/get.c | 2 +- src/mesa/main/get_hash_params.py | 6 +++--- src/mesa/main/teximage.c | 3 ++- src/mesa/main/texobj.c | 2 +- src/mesa/main/texparam.c | 3 ++- src/mesa/main/texsto

[Mesa-dev] [PATCH 4/4] docs: Note that OES_texture_cube_map_array is done.

Signed-off-by: Chris Forbes <chrisfor...@google.com> --- docs/GL3.txt | 2 +- docs/relnotes/12.1.0.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index e8d401d..eeaed52 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@

[Mesa-dev] [PATCH 2/4] glsl: Add support for cube arrays in ES.

Signed-off-by: Chris Forbes <chrisfor...@google.com> --- src/compiler/glsl/builtin_functions.cpp | 12 src/compiler/glsl/builtin_types.cpp | 23 --- src/compiler/glsl/glsl_lexer.ll | 14 +++--- 3 files changed, 31 insertions(+), 18 del

[Mesa-dev] [PATCH 1/4] mesa: Add scaffolding for OES_texture_cube_map_array

This is the same as ARB_texture_cube_map_array plus some image interactions. Signed-off-by: Chris Forbes <chrisfor...@google.com> --- src/compiler/glsl/glcpp/glcpp-parse.y| 5 - src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ src/compiler/glsl/glsl_parser_extras.h | 4 +++

Re: [Mesa-dev] [PATCH] glsl/parser: handle multiple layout sections with AST nodes.

Eek, that would do it. Reviewed-by: Chris Forbes <chrisfor...@google.com> On Mon, May 23, 2016 at 5:55 PM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > For geometry/compute inputs and tess control outputs, we create > an

Re: [Mesa-dev] [PATCH] glsl/ast: subroutineTypes can't be returned from functions.

Reviewed-by: Chris Forbes <chrisfor...@google.com> On Mon, May 23, 2016 at 2:15 PM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > These types can't be returne

Re: [Mesa-dev] arb_shader_subroutine CTS fixes

1, 3-11 inclusive are: Reviewed-by: Chris Forbes <chrisfor...@google.com> On Mon, May 23, 2016 at 12:52 PM, Dave Airlie <airl...@gmail.com> wrote: > Since I wrote ARB_shader_subroutine as mostly a hack to enable GL4.0, > I felt a bit guilty and lo

Re: [Mesa-dev] [PATCH 06/12] glsl: fix subroutine uniform .length().

On Mon, May 23, 2016 at 12:52 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes .length() on subroutine uniform arrays, if > we don't find the identifier normally, we look up the corresponding > subroutine identifier instead. > > Fixes: >

Re: [Mesa-dev] [PATCH] glsl: be more strict when validating shader inputs

With the version cutoff fixed, this and the patch it builds on are (squashed together or not): Reviewed-by: Chris Forbes <chrisfor...@google.com> On Fri, May 13, 2016 at 4:58 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Fri, May 13, 2016 at 12:51 AM, Dave Airlie <airl..

Re: [Mesa-dev] [PATCH 4/4] i965: Enable ARB_texture_stencil8 and OES_texture_stencil8 on Gen8+.

Series is: Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Wed, Apr 27, 2016 at 3:33 AM, Thomas Helland <thomashellan...@gmail.com> wrote: > I guess you should also update GL4.4 section in GL3.txt. > And add the extension to the release notes. > Either a follow

Re: [Mesa-dev] [PATCH] mesa: default FixedSampleLocations to true when using a dummy image

Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Fri, Feb 12, 2016 at 9:31 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > GL_ARB_texture_multisample and GLES 3.1 expect the initial value to be > GL_TRUE. This fixes

[Mesa-dev] [PATCH] i965: ir: dump floats as %-g rather than %f, so we can see denormals

Signed-off-by: Chris Forbes <chr...@ijw.co.nz> --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 41a3f81..8734560 100644 --- a/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] i965/skl: Utilize new 5th bit for gateway messages

Might be a good idea to update the comment above the second hunk. It's very precise about which bits, and so now wrong. - Chris On Wed, Jan 27, 2016 at 12:44 PM, Ben Widawsky wrote: > Cc: Jordan Justen > Signed-off-by: Ben Widawsky

Re: [Mesa-dev] [PATCH] glsl: remove old FINISHME

Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Tue, Jan 26, 2016 at 6:22 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > This should have been removed long ago. > --- > src/glsl/linker.cpp | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/

Re: [Mesa-dev] [PATCH] i965: Mark TCS URB writes as having side effects.

Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Tue, Jan 12, 2016 at 12:04 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > This adds barrier dependencies around TCS_OPCODE_URB_WRITE, preventing > reads and writes from being incorrectly scheduled. > > Fixes ren

Re: [Mesa-dev] [PATCH v2 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On 8 Jan 2016 9:03 AM, "Nicolai Hähnle" <nhaeh...@gmail.com> wrote: > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > Some games developers are unaware that an index buffer in a VBO still needs > to be read by

Re: [Mesa-dev] [PATCH 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

I think this misses the image load/store case. (*samplerBuffer) - Chris From: Nicolai Hähnle Some games developers are unaware that an index buffer in a VBO still needs to be read by the CPU if some varying data comes from a user pointer (unless glDrawRangeElements and

Re: [Mesa-dev] [PATCH 0/10] Tessellation shaders for Gen7/7.5.

Ken, That's great news, that hang was quite the head scratcher. - Chris On 25 Dec 2015 14:34, "Kenneth Graunke" wrote: > This morning, I woke up and somehow "knew" what was causing my HS GPU hangs > on Gen7/7.5. It turns out I was (completely) wrong, but through some >

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

Series (with the v2 changes) is: Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Thu, Nov 19, 2015 at 12:46 PM, Ian Romanick <i...@freedesktop.org> wrote: > This patch series implements a new GL extension, > EXT_shader_samples_identical. This extension allows shaders to &g

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

It lives! Thanks for picking this up, Ian. Had a very brief look at the series as it arrived, looks good; will try to do a real review later today. - Chris On Nov 19, 2015 12:47 PM, "Ian Romanick" wrote: > This patch series implements a new GL extension, >

Re: [Mesa-dev] Intent to work on support for EXT_internalformat_query2

Presumably ARB_internalformat_query2? On Tue, Oct 27, 2015 at 9:31 PM, Eduardo Lima Mitev wrote: > Hello, > > This is an announcement that a few folks at Igalia team are planning to > work on adding support for EXT_internalformat_query2 extension to Mesa. > > If somebody had

Re: [Mesa-dev] [PATCH 5/5] i965: Implement ARB_fragment_layer_viewport.

For the series Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Oct 27, 2015 7:03 AM, "Kenneth Graunke" <kenn...@whitecape.org> wrote: > Normally, we could read gl_Layer from bits 26:16 of R0.0. However, the > specification requires that bogus out-of-range 32-bit

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/9] ff_fragment_shader: Use binding to set the sampler unit

The comment above this about the cast to int can probably go away? - Chris On Sat, Oct 10, 2015 at 2:52 PM, Ian Romanick wrote: > From: Ian Romanick > > This is the way layout(binding=xxx) works from GLSL. The old method > just happened to work

Re: [Mesa-dev] [PATCH 6/6] i965: Simplify handling of VUE map changes.

For the v2 series: Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Sat, Sep 12, 2015 at 6:58 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > The old code was disasterously complex - spread across multiple atoms > which may not even run, inspecting the dirty bits to try an

Re: [Mesa-dev] [PATCH 05/12] i965/vec4/skl+: Use lcd2dms_w instead of lcd2dms

s/lcd2dms/ld2dms/g in various places in this patch and others. On Fri, Sep 18, 2015 at 4:00 AM, Neil Roberts wrote: > In order to support 16x MSAA, skl+ has a wider version of lcd2dms that > takes two parameters for the MCS data. The MCS data in the response > still fits

Re: [Mesa-dev] [PATCH 1/2] i965: Fix value of _3DPRIM_TRIFAN_NOSTIPPLE.

These two are: Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Mon, Sep 7, 2015 at 7:03 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > TRIFAN_NOSTIPPLE has always been 0x16 - 0x15 is marked "Reserved" on all > platforms. See the 965 PRM, Volume 2, Table 3-1, &

Re: [Mesa-dev] [PATCH 12/12] i965: Simplify handling of VUE map changes.

This had got pretty tangled. For the series: Reviewed-by: Chris Forbes <chr...@ijw.co.nz> On Sat, Aug 29, 2015 at 9:24 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > The old code was disasterously complex - spread across multiple atoms > which may not even run, inspect

Re: [Mesa-dev] [PATCH] i965: Improve disassembly of data port read messages.

Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Aug 14, 2015 at 9:52 AM, Kenneth Graunke kenn...@whitecape.org wrote: We now print out the name of the message instead of its numerical value, and label the message control and surface numbers. Signed-off-by: Kenneth Graunke kenn

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

I'd just add a 2015 block and a 2014 block. On Thu, Aug 13, 2015 at 9:36 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Aug 12, 2015 at 5:23 PM, Thomas Helland thomashellan...@gmail.com wrote: 2015-08-12 18:56 GMT+02:00 Kenneth Graunke kenn...@whitecape.org: On Wednesday, August 12, 2015

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

Some perf numbers would be nice. How much is this winning? - Chris On Mon, Aug 3, 2015 at 11:18 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: On Sun, 2015-08-02 at 19:50 +0200, Alejandro Seguí wrote: Maybe just for completeness you could add this to the commit message The util/hash_table

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

be determined, and we should just mass-migrate... -ilia On Sun, Aug 2, 2015 at 8:05 PM, Chris Forbes chr...@ijw.co.nz wrote: Some perf numbers would be nice. How much is this winning? - Chris On Mon, Aug 3, 2015 at 11:18 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: On Sun, 2015

[Mesa-dev] [PATCH] glsl: when generating out/inout parameter fixups, do indexing before the call

-index-inout-mat2-row * shaders@out-parameter-indexing@vs-inout-index-inout-vec4 * shaders@out-parameter-indexing@vs-inout-index-inout-vec4-array-element Further changes are needed for other expression types. Signed-off-by: Chris Forbes chr...@ijw.co.nz Cc: Ben Widawsky b...@bwidawsk.net --- src

Re: [Mesa-dev] [PATCH] glsl: recognize ARB_shading_language_420pack to be enabled with 4.20+

Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Jul 25, 2015 at 9:07 AM, Ilia Mirkin imir...@alum.mit.edu wrote: The 420pack extension enables various GLSL rules that need to be applied to any GLSL 4.20+ shader even if the extension is not explicitly enabled. Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] i965: Use updated kernel interface for accurate TIMESTAMP reads

This fixes my HSW getting dropped back to 3.2 most of the time, and seems like the reasonable thing to do. Tested-and-acked-by: Chris Forbes chr...@ijw.co.nz On Tue, Jul 21, 2015 at 11:58 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: I was mistaken, I thought we already had fixed

Re: [Mesa-dev] [PATCH v2] i965/fs: Don't use the pixel interpolater for centroid interpolation

Oh, never mind - I see there's another hunk that my mailer had folded away for some reason. I'm happy that it's correct now :) On Jul 13, 2015 23:33, Neil Roberts n...@linux.intel.com wrote: Chris Forbes chr...@ijw.co.nz writes: Nitpicks aside, I don't think this is a great idea now

Re: [Mesa-dev] [PATCH] glsl: use set rather than old hash table for ir_validate

Perf data? On Fri, Jul 10, 2015 at 6:41 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: This implementation should be faster and there was no need to store a data field. --- src/glsl/ir_validate.cpp | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used

Surely the *right* thing would be to have the correct order expressed in brw-vb.*, instead so you don't have this workaround in multiple places. As a minimal fix for stable though, this seems OK, so - Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Jul 11, 2015 at 5:04 AM, Neil Roberts n

Re: [Mesa-dev] [PATCH v2] i965/fs: Don't use the pixel interpolater for centroid interpolation

s/interpolater/interpolator/g On Fri, Jul 10, 2015 at 1:31 AM, Neil Roberts n...@linux.intel.com wrote: For centroid interpolation we can just directly use the values set up in the shader payload instead of querying the pixel interpolator. To do this we need to modify

Re: [Mesa-dev] [PATCH v2] i965/fs: Don't use the pixel interpolater for centroid interpolation

they compare with a centroid-qualified input. [I'm assuming you don't always get these delivered to the FS in SKL, but no docs access...] - Chris On Sat, Jul 11, 2015 at 11:18 AM, Chris Forbes chr...@ijw.co.nz wrote: s/interpolater/interpolator/g On Fri, Jul 10, 2015 at 1:31 AM, Neil Roberts n

Re: [Mesa-dev] [PATCH 07/19] glsl/types: add new subroutine type (v3)

7-12 inclusive are Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Jul 9, 2015 at 7:17 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This type will be used to store the name of subroutine types as in subroutine void myfunc(void); will store myfunc

Re: [Mesa-dev] [PATCH 09/19] glsl/ir: add subroutine information storage to ir_function (v1.1)

Do you really need is_subroutine_def ? It seems redundant with num_subroutine_types0. On Thu, Jul 9, 2015 at 7:17 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com We need to store two sets of info into the ir_function, if this is a function definition with a

Re: [Mesa-dev] [PATCH] i965/vs: Fix matNxM vertex attributes where M != 4.

Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Jul 2, 2015 at 8:08 PM, Kenneth Graunke kenn...@whitecape.org wrote: Matrix vertex attributes have their columns padded out to vec4s, which I was failing to account for. Scalar NIR expects them to be packed, however. Cc: mesa-sta

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

Looks OK to me. I didn't think there was going to be much required to make this work -- is nice that it turned out to be nothing. Reviewed-by: Chris Forbes chr...@ijw.co.nz - Chris On Fri, Jul 3, 2015 at 6:41 AM, Neil Roberts n...@linux.intel.com wrote: There was a comment saying

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: reset the source packing when creating temp transfer image

Seems reasonable to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Jul 2, 2015 at 7:18 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Commit 4b249d2ee (mesa: Handle transferOps in texstore_rgba) introduced proper transferops handling, but in updating the source to the newly allocated

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Jul 2, 2015 at 4:16 AM, Mike Stroyan m...@lunarg.com wrote: When there are no color buffer render targets, gen6 and gen7 still use the first BLEND_STATE element to determine alpha test. gen6_upload_blend_state was allocating zero elements when

Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

Seems fair. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Jul 2, 2015 at 10:22 AM, Ilia Mirkin imir...@alum.mit.edu wrote: The optimization logic relies on being able to read out constbuf values from program parameters. However that only works if there's no relative addressing involved

Re: [Mesa-dev] [PATCH 16/16] i965: Remove the brw_context from the visitors

For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Jun 23, 2015 at 1:07 PM, Jason Ekstrand ja...@jlekstrand.net wrote: As of this commit, nothing actually needs the brw_context. --- src/mesa/drivers/dri/i965/brw_cs.cpp| 6 -- src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 14/16] i965/vec4: Turn some _mesa_problem calls into asserts

Recent convention has been to use unreachable(str) rather than assert(!str) On Tue, Jun 23, 2015 at 1:07 PM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/mesa/drivers/dri/i965/brw_vec4_vp.cpp | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 13/16] i965/vs: Pass the current set of clip planes through run() and run_vs()

Is fairly unpleasant that the clip plane plumbing needs to be so special in the visitors at all -- but breaking the context dependency is a win. - Chris On Tue, Jun 23, 2015 at 1:07 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Previously, these were pulled out of the GL context conditionally

Re: [Mesa-dev] [PATCH] i965: Add missing braces around if-statement.

Oh, how silly :) Reviewed-by: Chris Forbes chr...@ijw.co.nz - Chris On Fri, Jun 19, 2015 at 11:19 AM, Matt Turner matts...@gmail.com wrote: Fixes a performance problem caused by commit b639ed2f. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895 --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] i965: Set max texture buffer size to hardware limit

Previously we were leaving this at the default of 64K, which meets the spec but is too small for some real uses. The hardware can handle up to 128M. User was complaining about this on freenode ##OpenGL today. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] i965/fs: Use UW-typed immediate in multiply inst.

After discussion on IRC, this seems reasonable to me. Unfortunate that CHV is fussy. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Jun 3, 2015 at 1:24 PM, Matt Turner matts...@gmail.com wrote: Some hardware reads only the low 16-bits even if the type is UD, but other hardware like

Re: [Mesa-dev] [PATCH 1/2] i965: Don't use a temporary when generating an indirect sample

This thing has been trouble since I wrote it. Nice to see it go. Both patches are: Reviewed-by: Chris Forbes chr...@ijw.co.nz On May 30, 2015 6:28 AM, Matt Turner matts...@gmail.com wrote: On Fri, May 29, 2015 at 6:53 AM, Neil Roberts n...@linux.intel.com wrote: Previously when generating

Re: [Mesa-dev] [PATCH] docs: Mark ARB_shader_storage_buffer_object as in progress

Hardly needed, but: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, May 25, 2015 at 7:41 PM, Iago Toral Quiroga ito...@igalia.com wrote: --- docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 9d56ee5..44a824b 100644

Re: [Mesa-dev] [PATCH] i965: Remove _NEW_MULTISAMPLE dirty bit from 3DSTATE_PS_EXTRA.

Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, May 25, 2015 at 7:38 PM, Kenneth Graunke kenn...@whitecape.org wrote: BRW_NEW_NUM_SAMPLES is sufficient. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH] docs: Mark ARB_shader_storage_buffer_object as in progress

Oh, I meant I would have just pushed something like this :) - Chris On Mon, May 25, 2015 at 8:26 PM, Iago Toral ito...@igalia.com wrote: On Mon, 2015-05-25 at 20:15 +1200, Chris Forbes wrote: Hardly needed, but: I know, I should've sent this patch when we started working on this... I got

Re: [Mesa-dev] [PATCH] i965/fs: Disable opt_sampler_eot for textureGather

I don't have CHV or SKL hw or docs to try and confirm this, but this does what it claims to. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, May 9, 2015 at 5:10 AM, Neil Roberts n...@linux.intel.com wrote: The opt_sampler_eot optimisation seems to break when the last instruction

Re: [Mesa-dev] [PATCH 11/23] glsl/types: add new subroutine type

Patches 11-13 are: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Apr 24, 2015 at 1:42 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This type will be used to store the name of subroutine types as in subroutine void myfunc(void); will store myfunc

[Mesa-dev] [PATCH 2/4] i965/gen6: Upload all the clip viewports

Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/gen6_viewport_state.c | 40 + 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_viewport_state.c b/src/mesa/drivers/dri/i965/gen6_viewport_state.c index

[Mesa-dev] [PATCH 3/4] i965/gen6: Upload all the SF viewports

Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_structs.h | 2 ++ src/mesa/drivers/dri/i965/gen6_viewport_state.c | 29 +++-- 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_structs.h b/src

[Mesa-dev] [PATCH 1/4] i965/gen6: setup limits for ARB_viewport_array

Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH 4/4] i965/gen6: Enable ARB_viewport_array and AMD_vertex_shader_viewport_index

Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/intel_extensions.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index c28c171..3088a1a

Re: [Mesa-dev] [PATCH 20/23] i965: Plumb compiler debug logging through a function pointer in brw_compiler

Looks like everything prior to this patch has landed; Ken's two patches for the printf-like debug plumbing, and the remaining patches from this series are: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sun, Apr 19, 2015 at 9:02 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Sat, Apr 18

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

/* Only ARB_texture_gather but not GLSL 4.0 or ARB_gpu_shader5. * used for relaxation of const offset requirements. */ static bool -texture_gather_only(const _mesa_glsl_parse_state *state) +texture_gather_only_or_es31(const _mesa_glsl_parse_state *state) { return

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

Nevermind, pre-coffee. On re-reading the GLSL ES 3.1 spec, the offset is required to be constant wherever texture offsets are used. On Fri, May 1, 2015 at 10:03 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Apr 30, 2015 at 5:56 PM, Chris Forbes chr...@ijw.co.nz wrote: /* Only

Re: [Mesa-dev] [PATCH 17/18] i965/ps/gen8: Refactor state uploading

It might be better to just prefetch no samplers in this case? -- a shader that has this many active samplers probably doesn't actually use them all in a single invocation. On Thu, Apr 30, 2015 at 5:23 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, April 29, 2015 07:47:26 PM

Re: [Mesa-dev] [PATCH v5] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN6

Have an: Acked-by: Chris Forbes chr...@ijw.co.nz On Fri, Apr 24, 2015 at 3:41 AM, Marius Predut marius.pre...@intel.com wrote: On SNB and IVB hw, for 1 pixel line thickness or less, the general anti-aliasing algorithm give up - garbage line is generated. Setting a Line Width of 0.0 specifies

Re: [Mesa-dev] [PATCH] i965: Disassemble sampler message names on Gen5+.

On the this is silly, I should really fix it list forever... Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Apr 24, 2015 at 6:02 PM, Kenneth Graunke kenn...@whitecape.org wrote: Previously, sampler messages were decoded as sampler (1, 0, 2, 2) mlen 6 rlen 8 { align1 1H }; I

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] i965: Fix instanced geometry shaders on Gen8+.

For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Apr 4, 2015 at 11:46 PM, Kenneth Graunke kenn...@whitecape.org wrote: Jordan added this in commit 741782b5948bb3d01d699f062a37513c2e73b076 for Gen7 platforms. Embarassingly, this was missed for well over a year. Fixes

Re: [Mesa-dev] [PATCH 14/23] i965: Use BRW_SURFACE_* in place of GL_TEXTURE_*

I'd adjust the write to surf[0] to use surf_type too. Other than that, this patch is: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Mar 31, 2015 at 10:04 AM, Anuj Phogat anuj.pho...@gmail.com wrote: Makes no functional changes in the code. Signed-off-by: Anuj Phogat anuj.pho

Re: [Mesa-dev] [PATCH 3/3] glsl: Reassociate multiplication of mat*mat*vec.

For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Mar 28, 2015 at 5:22 PM, Matt Turner matts...@gmail.com wrote: The typical case of mat4*mat4*vec4 is 80 scalar multiplications, but mat4*(mat4*vec4) is only 32. On HSW (with vec4 vertex shaders): instructions in affected

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glsl: fix names in lower_constant_arrays_to_uniforms

Looks good to me. I should have considered this cross-stage case when I fixed the first part of this bug... Do you have a piglit test which hits this? Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Mar 23, 2015 at 8:12 PM, Tapani Pälli tapani.pa...@intel.com wrote: Patch changes lowering

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glsl: fix names in lower_constant_arrays_to_uniforms

-LIBDRM_INTEL_REQUIRED=2.4.60 +LIBDRM_INTEL_REQUIRED=2.4.59 Hang on, what's this hunk doing here? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10/11] i965/fs: Implement support for ir_barrier

jordan.l.jus...@intel.com Reviewed-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_defines.h| 5 + src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 +++ src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 3/4] i965: Rename do_stage_prog to brw_stage_compile

I think that having both the existing `struct brw_vs_compile` and a function with the same name is going to cause confusion. (same with the other non-fs stages) On Sat, Mar 21, 2015 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 06:02 PM, Ian Romanick wrote: On 03/20/2015

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: Generate link error for non-matching gl_FragCoord redeclarations

LGTM. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Mar 7, 2015 at 1:15 PM, Anuj Phogat anuj.pho...@gmail.com wrote: in different fragment shaders. This also applies to a case when gl_FragCoord is redeclared with no layout qualifiers in one fragment shader and not declared but used

Re: [Mesa-dev] [PATCH] i965/fs: Print spills:fills and number of promoted constants.

With the fix Jason mentioned: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Mar 18, 2015 at 10:19 AM, Matt Turner matts...@gmail.com wrote: On Tue, Mar 17, 2015 at 2:15 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Tue, Mar 17, 2015 at 2:09 PM, Matt Turner matts...@gmail.com wrote

[Mesa-dev] [PATCH 2/2] i965/disasm: Fix format strings

Most of the brw_inst_* api returns 64bit values. This fixes disassembly of sampler messages, etc. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_disasm.c | 48 +- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 1/2] i965/disasm: Mark format() as being printf-style.

This allows us to get warnings from GCC when we mess up the format strings. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_disasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] i965/gen6 gs: Convert brw_imm_ud/brw_imm_d to src_reg

Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Mar 4, 2015 at 2:25 PM, Jordan Justen jordan.l.jus...@intel.com wrote: Same idea as this patch, only for gen6_gs_visitor: commit 49a938a265f5959c9b558995cc658f80acb6eb18 Author: Jordan Justen jordan.l.jus...@intel.com Date: Fri Feb 20 12

Re: [Mesa-dev] [PATCH] i965/gs: Check newly-generated GS-out VUE map against correct stage

Thanks Matt -- yes, for 10.5 as well. I'll also note that this fixes: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=5 On Sat, Feb 28, 2015 at 8:48 PM, Matt Turner matts...@gmail.com wrote: On Fri, Feb 27, 2015 at 11:03 PM, Chris Forbes chr...@ijw.co.nz wrote: Previously, we

[Mesa-dev] [PATCH] i965/gs: Check newly-generated GS-out VUE map against correct stage

if it happened to match the VS-out layout. Signed-off-by: Chris Forbes chr...@ijw.co.nz Cc: 10.4 mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_gs.c b/src/mesa/drivers/dri/i965

  1   2   3   4   5   6   7   8   9   10   >