This is enforcing a hard requirement in the spec:
30.1. Feature Requirements
All Vulkan graphics implementations must support the following features:
* robustBufferAccess
On Fri, Nov 8, 2019 at 1:49 PM wrote:
>
> Testing my Vulkan driver agains Vulkan CTS, I am a bit suprised, that is
> seem
Sigh, I should have just ignored the docs when I was poking at this years
ago.
Reviewed-by: Chris Forbes
On Mon, May 29, 2017 at 10:49 PM, Kenneth Graunke
wrote:
> The BLEND_STATE documentation says that alpha to one must be disabled
> when dual color blending is enabled. However, it a
Nice to see the last remnants of this go.
For the series:
Reviewed-by: Chris Forbes
On Wed, Mar 1, 2017 at 9:53 AM, Kenneth Graunke
wrote:
> In the past, we used this on Gen4-5 to transform non-normalized texture
> coordinates (for sampler2DRect) to normalized ones. We also used
This looks like it misses the interactions with texture completeness.
- Chris
On Wed, Feb 1, 2017 at 7:53 AM, Plamena Manolova wrote:
> This extension provides a new texture and sampler parameter
> (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce a
> filtered texel value by com
I don't see any spec justification for masking this. dEQP is broken here.
Implementations have the flexibility to retain more bits in the mask (and
have more bits set in the initial state) than the depth of the deepest
stencil buffer supported. From the ES3 spec, 4.1.4, second to last para:
"In
Ilia, it is different from the NV variant -- NV unfortunately threw a bunch
of other stuff in (extra subpixel bits in conservative mode).
Series is:
Reviewed-by: Chris Forbes
On Fri, Dec 2, 2016 at 8:21 AM, Ilia Mirkin wrote:
> Ah, I see. The difference is that it exists, unlike the ARB
here looks good, so:
Reviewed-by: Chris Forbes
On Thu, Dec 1, 2016 at 9:00 AM, Plamena Manolova wrote:
> This extension allows the fragment shader to control whether values in
> gl_SampleMaskIn[] reflect the coverage after application of the early
> depth and stencil tests.
>
>
Excellent, disregard that. Patch looks good.
On Thu, Dec 1, 2016 at 3:10 PM, Ilia Mirkin wrote:
> On Wed, Nov 30, 2016 at 9:10 PM, Chris Forbes wrote:
> > This patch misses adding the #define to the GLSL preprocessor. Other than
>
> The future is today. That's no longer nec
This patch misses adding the #define to the GLSL preprocessor. Other than
that it looks good though, so with that fixed:
Reviewed-by: Chris Forbes
On Thu, Dec 1, 2016 at 8:53 AM, Plamena Manolova wrote:
> This extension allows the fragment shader to control whether values in
> gl_Sample
The HW limits here are -8/7 when using the gather4 message. [gather4_po
allows -32/31, and specified per channel]
On Mon, Nov 28, 2016 at 10:49 AM, Ilia Mirkin wrote:
> This matches what NVIDIA and AMD hardware expose.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> Not sure what the true HW limit is
The mesa default is 4, but we program the hardware for 8 on all
generations.
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index
Now that we also have to consider OES_viewport_array & friends, nothing uses
this.
Signed-off-by: Chris Forbes
---
src/mesa/main/get.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index 5f5e76a..854f8ab 100644
--- a/src/mesa/main/get.c
+++ b
This patch isn't right. These enum values are the same as the desktop
version, so your new cases will never actually be used.
On Mon, Aug 29, 2016 at 2:24 AM, Francesco Ansanelli
wrote:
> Signed-off-by: Francesco Ansanelli
> ---
> src/mesa/main/texparam.c | 48 ++
Oh dear, hacks on both sides. Sorry for this nonsense.
Series is:-
Reviewed-by: Chris Forbes
On Tue, Jul 19, 2016 at 5:16 PM, Jason Ekstrand
wrote:
> From the Sky Lake PRM:
>
>"For SURFTYPE_CUBE: For Sampling Engine Surfaces and Typed Data Port
>Surfaces, the range
I remember arguing about this when it got added -- tradeoff was payload
size/register pressure vs needing to call out to this unit, if centroid
barycentric coords weren't required for anything else? It does seem fairly
pointless, though.
For the series:-
Reviewed-by: Chris Forbes
On Tue
Seems a little unfortunate to add a random bool to this interface which is
otherwise fairly descriptive, but OK.
On Tue, Jul 19, 2016 at 8:26 AM, Kenneth Graunke
wrote:
> While my intention is that the new intrinsics should be usable by all
> drivers, we need to make them optional until all driv
On Tue, Jul 19, 2016 at 8:26 AM, Kenneth Graunke
wrote:
> + default:
> + assert(!"invalid intrinsic");
>
unreachable() ?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Jul 12, 2016 at 9:59 PM, Marek Olšák wrote:
+ *endian = r600_endian_swap(32);
I don't fully understand r600, but this 32 seems dubious?
- Chris
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org
Reviewed-by: Chris Forbes
On Mon, Jun 13, 2016 at 12:03 PM, Kenneth Graunke
wrote:
> These need to be freed too.
>
> Cc: "12.0"
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_context.c | 4
> 1 file changed, 4 insertions(+)
>
&
Reviewed-by: Chris Forbes
On Fri, Jun 3, 2016 at 2:27 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes:
> GL45-CTS.geometry_shader.layered_rendering.layered_rendering
>
> on Skylake.
>
> Signed-off-by: Dave Airlie
> ---
> src/mesa/main/get_hash_params.
Signed-off-by: Chris Forbes
---
src/mesa/main/get.c | 2 +-
src/mesa/main/get_hash_params.py | 6 +++---
src/mesa/main/teximage.c | 3 ++-
src/mesa/main/texobj.c | 2 +-
src/mesa/main/texparam.c | 3 ++-
src/mesa/main/texstorage.c | 3 ++-
6 files
Signed-off-by: Chris Forbes
---
docs/GL3.txt | 2 +-
docs/relnotes/12.1.0.html | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index e8d401d..eeaed52 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -269,7 +269,7 @@ GLES3.2, GLSL ES
Signed-off-by: Chris Forbes
---
src/compiler/glsl/builtin_functions.cpp | 12
src/compiler/glsl/builtin_types.cpp | 23 ---
src/compiler/glsl/glsl_lexer.ll | 14 +++---
3 files changed, 31 insertions(+), 18 deletions(-)
diff --git a/src
This is the same as ARB_texture_cube_map_array plus some image
interactions.
Signed-off-by: Chris Forbes
---
src/compiler/glsl/glcpp/glcpp-parse.y| 5 -
src/compiler/glsl/glsl_parser_extras.cpp | 2 ++
src/compiler/glsl/glsl_parser_extras.h | 4
src/mapi/glapi/gen/es_EXT.xml
Eek, that would do it.
Reviewed-by: Chris Forbes
On Mon, May 23, 2016 at 5:55 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> For geometry/compute inputs and tess control outputs, we create
> an AST node to keep track of some things. However if we have
> multiple layout sec
Reviewed-by: Chris Forbes
On Mon, May 23, 2016 at 2:15 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> These types can't be returned.
>
> This fixes:
>
> GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types
1, 3-11 inclusive are:
Reviewed-by: Chris Forbes
On Mon, May 23, 2016 at 12:52 PM, Dave Airlie wrote:
> Since I wrote ARB_shader_subroutine as mostly a hack to enable GL4.0,
> I felt a bit guilty and looked at CTS issues with it.
>
> There are a bunch of CTS tests that do expli
On Mon, May 23, 2016 at 12:52 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes .length() on subroutine uniform arrays, if
> we don't find the identifier normally, we look up the corresponding
> subroutine identifier instead.
>
> Fixes:
> GL45-CTS.shader_subroutine.arrays_of_arrays_of_un
With the version cutoff fixed, this and the patch it builds on are
(squashed together or not):
Reviewed-by: Chris Forbes
On Fri, May 13, 2016 at 4:58 PM, Ilia Mirkin wrote:
> On Fri, May 13, 2016 at 12:51 AM, Dave Airlie wrote:
> >>> second argument is for ES... 0 means "
Series is:
Reviewed-by: Chris Forbes
On Wed, Apr 27, 2016 at 3:33 AM, Thomas Helland
wrote:
> I guess you should also update GL4.4 section in GL3.txt.
> And add the extension to the release notes.
> Either a follow up patch or squashed into this one is fine with me.
>
> Re
Reviewed-by: Chris Forbes
On Fri, Feb 12, 2016 at 9:31 AM, Ilia Mirkin wrote:
> GL_ARB_texture_multisample and GLES 3.1 expect the initial value to be
> GL_TRUE. This fixes
>
>
> dEQP-GLES31.functional.state_query.texture_level.texture_2d_multisample_array.fixed_sample_lo
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 41a3f81..8734560 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src
Might be a good idea to update the comment above the second hunk. It's very
precise about which bits, and so now wrong.
- Chris
On Wed, Jan 27, 2016 at 12:44 PM, Ben Widawsky
wrote:
> Cc: Jordan Justen
> Signed-off-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 +++
Reviewed-by: Chris Forbes
On Tue, Jan 26, 2016 at 6:22 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> This should have been removed long ago.
> ---
> src/glsl/linker.cpp | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/glsl/linker.cpp b/src
Reviewed-by: Chris Forbes
On Tue, Jan 12, 2016 at 12:04 PM, Kenneth Graunke
wrote:
> This adds barrier dependencies around TCS_OPCODE_URB_WRITE, preventing
> reads and writes from being incorrectly scheduled.
>
> Fixes rendering in GFXBench 4.0's tessellation demo.
>
&
Reviewed-by: Chris Forbes
On 8 Jan 2016 9:03 AM, "Nicolai Hähnle" wrote:
> From: Nicolai Hähnle
>
> Some games developers are unaware that an index buffer in a VBO still needs
> to be read by the CPU if some varying data comes from a user pointer
> (unless
> glDrawR
I think this misses the image load/store case. (*samplerBuffer)
- Chris
From: Nicolai Hähnle
Some games developers are unaware that an index buffer in a VBO still needs
to be read by the CPU if some varying data comes from a user pointer (unless
glDrawRangeElements and friends are used). This is
Ken,
That's great news, that hang was quite the head scratcher.
- Chris
On 25 Dec 2015 14:34, "Kenneth Graunke" wrote:
> This morning, I woke up and somehow "knew" what was causing my HS GPU hangs
> on Gen7/7.5. It turns out I was (completely) wrong, but through some
> miraculous series of ill
Series (with the v2 changes) is:
Reviewed-by: Chris Forbes
On Thu, Nov 19, 2015 at 12:46 PM, Ian Romanick wrote:
> This patch series implements a new GL extension,
> EXT_shader_samples_identical. This extension allows shaders to
> determine when all of the samples in a particular
It lives! Thanks for picking this up, Ian.
Had a very brief look at the series as it arrived, looks good; will try to
do a real review later today.
- Chris
On Nov 19, 2015 12:47 PM, "Ian Romanick" wrote:
> This patch series implements a new GL extension,
> EXT_shader_samples_identical. This ex
Presumably ARB_internalformat_query2?
On Tue, Oct 27, 2015 at 9:31 PM, Eduardo Lima Mitev
wrote:
> Hello,
>
> This is an announcement that a few folks at Igalia team are planning to
> work on adding support for EXT_internalformat_query2 extension to Mesa.
>
> If somebody had started work on this
For the series
Reviewed-by: Chris Forbes
On Oct 27, 2015 7:03 AM, "Kenneth Graunke" wrote:
> Normally, we could read gl_Layer from bits 26:16 of R0.0. However, the
> specification requires that bogus out-of-range 32-bit values written by
> previous stages need to appear in
The comment above this about the cast to int can probably go away?
- Chris
On Sat, Oct 10, 2015 at 2:52 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> This is the way layout(binding=xxx) works from GLSL. The old method
> just happened to work (and significantly predated support for
> layout
For the v2 series:
Reviewed-by: Chris Forbes
On Sat, Sep 12, 2015 at 6:58 PM, Kenneth Graunke
wrote:
> The old code was disasterously complex - spread across multiple atoms
> which may not even run, inspecting the dirty bits to try and decide
> whether it was necessary to do checks.
s/lcd2dms/ld2dms/g in various places in this patch and others.
On Fri, Sep 18, 2015 at 4:00 AM, Neil Roberts wrote:
> In order to support 16x MSAA, skl+ has a wider version of lcd2dms that
> takes two parameters for the MCS data. The MCS data in the response
> still fits in a single register so
These two are:
Reviewed-by: Chris Forbes
On Mon, Sep 7, 2015 at 7:03 PM, Kenneth Graunke wrote:
> TRIFAN_NOSTIPPLE has always been 0x16 - 0x15 is marked "Reserved" on all
> platforms. See the 965 PRM, Volume 2, Table 3-1, "3D Primitive Topology
> Type Encoding&q
This had got pretty tangled.
For the series:
Reviewed-by: Chris Forbes
On Sat, Aug 29, 2015 at 9:24 PM, Kenneth Graunke wrote:
> The old code was disasterously complex - spread across multiple atoms
> which may not even run, inspecting the dirty bits to try and decide
> wheth
Reviewed-by: Chris Forbes
On Fri, Aug 14, 2015 at 9:52 AM, Kenneth Graunke wrote:
> We now print out the name of the message instead of its numerical
> value, and label the message control and surface numbers.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri
I'd just add a 2015 block and a 2014 block.
On Thu, Aug 13, 2015 at 9:36 AM, Ilia Mirkin wrote:
> On Wed, Aug 12, 2015 at 5:23 PM, Thomas Helland
> wrote:
>> 2015-08-12 18:56 GMT+02:00 Kenneth Graunke :
>>> On Wednesday, August 12, 2015 06:32:50 PM Thomas Helland wrote:
2015-08-12 17:48 GMT
that should be determined, and
> we should just mass-migrate...
>
> -ilia
>
> On Sun, Aug 2, 2015 at 8:05 PM, Chris Forbes wrote:
> > Some perf numbers would be nice. How much is this winning?
> >
> > - Chris
> >
> > On Mon, Aug 3, 2015 at 11:18 AM, Timo
Some perf numbers would be nice. How much is this winning?
- Chris
On Mon, Aug 3, 2015 at 11:18 AM, Timothy Arceri wrote:
> On Sun, 2015-08-02 at 19:50 +0200, Alejandro Seguí wrote:
>
> Maybe just for completeness you could add this to the commit message
>
> The util/hash_table was intended to b
-index-inout-mat2-row
* shaders@out-parameter-indexing@vs-inout-index-inout-vec4
* shaders@out-parameter-indexing@vs-inout-index-inout-vec4-array-element
Further changes are needed for other expression types.
Signed-off-by: Chris Forbes
Cc: Ben Widawsky
---
src/glsl/ast_function.cpp | 15
Reviewed-by: Chris Forbes
On Sat, Jul 25, 2015 at 9:07 AM, Ilia Mirkin wrote:
> The 420pack extension enables various GLSL rules that need to be applied
> to any GLSL 4.20+ shader even if the extension is not explicitly
> enabled.
>
> Signed-off-by: Ilia Mirkin
> ---
> sr
This fixes my HSW getting dropped back to 3.2 most of the time, and
seems like the reasonable thing to do.
Tested-and-acked-by: Chris Forbes
On Tue, Jul 21, 2015 at 11:58 PM, Chris Wilson wrote:
> I was mistaken, I thought we already had fixed this in the kernel a
> couple of years ago.
Oh, never mind - I see there's another hunk that my mailer had folded away
for some reason. I'm happy that it's correct now :)
On Jul 13, 2015 23:33, "Neil Roberts" wrote:
> Chris Forbes writes:
>
> > Nitpicks aside, I don't think this is a great idea
n the tests,
because they compare with a centroid-qualified input. [I'm assuming
you don't always get these delivered to the FS in SKL, but no docs
access...]
- Chris
On Sat, Jul 11, 2015 at 11:18 AM, Chris Forbes wrote:
> s/interpolater/interpolator/g
>
> On Fri, Jul 10, 2015
s/interpolater/interpolator/g
On Fri, Jul 10, 2015 at 1:31 AM, Neil Roberts wrote:
> For centroid interpolation we can just directly use the values set up
> in the shader payload instead of querying the pixel interpolator. To
> do this we need to modify brw_compute_barycentric_interp_modes to
> d
Surely the *right* thing would be to have the correct order expressed
in brw->vb.*, instead so you don't have this workaround in multiple
places.
As a minimal fix for stable though, this seems OK, so -
Reviewed-by: Chris Forbes
On Sat, Jul 11, 2015 at 5:04 AM, Neil Roberts wrote:
&g
Perf data?
On Fri, Jul 10, 2015 at 6:41 PM, Timothy Arceri wrote:
> This implementation should be faster and there was no
> need to store a data field.
> ---
> src/glsl/ir_validate.cpp | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/src/glsl/ir
7-12 inclusive are
Reviewed-by: Chris Forbes
On Thu, Jul 9, 2015 at 7:17 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This type will be used to store the name of subroutine types
>
> as in subroutine void myfunc(void);
> will store myfunc into a subroutine type.
>
>
Do you really need is_subroutine_def ? It seems redundant with
num_subroutine_types>0.
On Thu, Jul 9, 2015 at 7:17 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> We need to store two sets of info into the ir_function,
> if this is a function definition with a subroutine list
> (subroutine_def) o
Reviewed-by: Chris Forbes
On Thu, Jul 2, 2015 at 8:08 PM, Kenneth Graunke wrote:
> Matrix vertex attributes have their columns padded out to vec4s, which
> I was failing to account for. Scalar NIR expects them to be packed,
> however.
>
> Cc: mesa-sta...@lists.freedesktop.org
Looks OK to me. I didn't think there was going to be much required to
make this work -- is nice that it turned out to be nothing.
Reviewed-by: Chris Forbes
- Chris
On Fri, Jul 3, 2015 at 6:41 AM, Neil Roberts wrote:
> There was a comment saying that in SIMD16 mode the pixel inte
Seems fair.
Reviewed-by: Chris Forbes
On Thu, Jul 2, 2015 at 10:22 AM, Ilia Mirkin wrote:
> The optimization logic relies on being able to read out constbuf values
> from program parameters. However that only works if there's no relative
> addressing involved.
>
Reviewed-by: Chris Forbes
On Thu, Jul 2, 2015 at 4:16 AM, Mike Stroyan wrote:
> When there are no color buffer render targets, gen6 and gen7 still
> use the first BLEND_STATE element to determine alpha test.
> gen6_upload_blend_state was allocating zero elements when
> ctx->Col
Seems reasonable to me.
Reviewed-by: Chris Forbes
On Thu, Jul 2, 2015 at 7:18 AM, Ilia Mirkin wrote:
> Commit 4b249d2ee (mesa: Handle transferOps in texstore_rgba) introduced
> proper transferops handling, but in updating the source to the newly
> allocated temporary image neglected
Reviewed-by: Chris Forbes
On Sat, Jun 27, 2015 at 11:31 AM, Kenneth Graunke wrote:
> On Friday, June 26, 2015 04:17:39 PM Jason Ekstrand wrote:
>> On Fri, Jun 26, 2015 at 3:56 PM, Kenneth Graunke
>> wrote:
>> > Legacy user clipping (using gl_Position or gl_C
For the series:
Reviewed-by: Chris Forbes
On Tue, Jun 23, 2015 at 1:07 PM, Jason Ekstrand wrote:
> As of this commit, nothing actually needs the brw_context.
> ---
> src/mesa/drivers/dri/i965/brw_cs.cpp| 6 --
> src/mesa/drivers/dri/i965/brw_fs.cpp
Is fairly unpleasant that the clip plane plumbing needs to be so
special in the visitors at all -- but breaking the context dependency
is a win.
- Chris
On Tue, Jun 23, 2015 at 1:07 PM, Jason Ekstrand wrote:
> Previously, these were pulled out of the GL context conditionally based on
> whether w
Recent convention has been to use unreachable("str") rather than assert(!"str")
On Tue, Jun 23, 2015 at 1:07 PM, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_vec4_vp.cpp | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw
Oh, how silly :)
Reviewed-by: Chris Forbes
- Chris
On Fri, Jun 19, 2015 at 11:19 AM, Matt Turner wrote:
> Fixes a performance problem caused by commit b639ed2f.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90895
> ---
> src/mesa/drivers/dri/i965/brw_meta_f
After discussion on IRC, this seems reasonable to me. Unfortunate that
CHV is fussy.
Reviewed-by: Chris Forbes
On Wed, Jun 3, 2015 at 1:24 PM, Matt Turner wrote:
> Some hardware reads only the low 16-bits even if the type is UD, but
> other hardware like Cherryview can't handle this
Previously we were leaving this at the default of 64K, which meets the
spec but is too small for some real uses. The hardware can handle up to
128M.
User was complaining about this on freenode ##OpenGL today.
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_context.c | 1 +
1 file
This thing has been trouble since I wrote it. Nice to see it go.
Both patches are:
Reviewed-by: Chris Forbes
On May 30, 2015 6:28 AM, "Matt Turner" wrote:
> On Fri, May 29, 2015 at 6:53 AM, Neil Roberts
> wrote:
> > Previously when generating the send instruction for a
Oh, I meant I would have just pushed something like this :)
- Chris
On Mon, May 25, 2015 at 8:26 PM, Iago Toral wrote:
> On Mon, 2015-05-25 at 20:15 +1200, Chris Forbes wrote:
>> Hardly needed, but:
>
> I know, I should've sent this patch when we started working on this... I
Hardly needed, but:
Reviewed-by: Chris Forbes
On Mon, May 25, 2015 at 7:41 PM, Iago Toral Quiroga wrote:
> ---
> docs/GL3.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/GL3.txt b/docs/GL3.txt
> index 9d56ee5..44a824b 100644
> --- a
Reviewed-by: Chris Forbes
On Mon, May 25, 2015 at 7:38 PM, Kenneth Graunke wrote:
> BRW_NEW_NUM_SAMPLES is sufficient.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
&g
Patches 11-13 are:
Reviewed-by: Chris Forbes
On Fri, Apr 24, 2015 at 1:42 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This type will be used to store the name of subroutine types
>
> as in subroutine void myfunc(void);
> will store myfunc into a subroutine type.
>
>
I don't have CHV or SKL hw or docs to try and confirm this, but this
does what it claims to.
Reviewed-by: Chris Forbes
On Sat, May 9, 2015 at 5:10 AM, Neil Roberts wrote:
> The opt_sampler_eot optimisation seems to break when the last
> instruction is SHADER_OPCODE_TG4. A bunch of P
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/intel_extensions.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index c28c171..3088a1a 100644
--- a/src
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_structs.h | 2 ++
src/mesa/drivers/dri/i965/gen6_viewport_state.c | 29 +++--
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_structs.h
b/src/mesa/drivers
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_context.c | 4 ++--
src/mesa/drivers/dri/i965/brw_defines.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index 6c00f6c
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/gen6_viewport_state.c | 40 +
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/gen6_viewport_state.c
b/src/mesa/drivers/dri/i965/gen6_viewport_state.c
index 0c63283
Looks like everything prior to this patch has landed;
Ken's two patches for the printf-like debug plumbing, and the
remaining patches from this series are:
Reviewed-by: Chris Forbes
On Sun, Apr 19, 2015 at 9:02 AM, Jason Ekstrand wrote:
> On Sat, Apr 18, 2015 at 1:55 PM, Kenneth
Nevermind, pre-coffee. On re-reading the GLSL ES 3.1 spec, the offset
is required to be constant wherever texture offsets are used.
On Fri, May 1, 2015 at 10:03 AM, Ilia Mirkin wrote:
> On Thu, Apr 30, 2015 at 5:56 PM, Chris Forbes wrote:
>>> /* Only ARB_texture_gather but not
> /* Only ARB_texture_gather but not GLSL 4.0 or ARB_gpu_shader5.
> * used for relaxation of const offset requirements.
> */
> static bool
> -texture_gather_only(const _mesa_glsl_parse_state *state)
> +texture_gather_only_or_es31(const _mesa_glsl_parse_state *state)
> {
> return !state->
It might be better to just prefetch no samplers in this case? -- a
shader that has this many active samplers "probably" doesn't actually
use them all in a single invocation.
On Thu, Apr 30, 2015 at 5:23 AM, Kenneth Graunke wrote:
> On Wednesday, April 29, 2015 07:47:26 PM Pohjolainen, Topi wrote:
Have an:
Acked-by: Chris Forbes
On Fri, Apr 24, 2015 at 3:41 AM, Marius Predut wrote:
> On SNB and IVB hw, for 1 pixel line thickness or less,
> the general anti-aliasing algorithm give up - garbage line is generated.
> Setting a Line Width of 0.0 specifies the rasterization of
> t
On the "this is silly, I should really fix it" list forever...
Reviewed-by: Chris Forbes
On Fri, Apr 24, 2015 at 6:02 PM, Kenneth Graunke wrote:
> Previously, sampler messages were decoded as
>
> sampler (1, 0, 2, 2) mlen 6 rlen 8 { align1 1H };
>
> I
For the series:
Reviewed-by: Chris Forbes
On Sat, Apr 4, 2015 at 11:46 PM, Kenneth Graunke wrote:
> Jordan added this in commit 741782b5948bb3d01d699f062a37513c2e73b076 for
> Gen7 platforms. Embarassingly, this was missed for well over a year.
>
> Fixes Piglit's spe
I'd adjust the write to surf[0] to use surf_type too.
Other than that, this patch is:
Reviewed-by: Chris Forbes
On Tue, Mar 31, 2015 at 10:04 AM, Anuj Phogat wrote:
> Makes no functional changes in the code.
>
> Signed-off-by: Anuj Phogat
> ---
> src/m
For the series:
Reviewed-by: Chris Forbes
On Sat, Mar 28, 2015 at 5:22 PM, Matt Turner wrote:
> The typical case of mat4*mat4*vec4 is 80 scalar multiplications, but
> mat4*(mat4*vec4) is only 32.
>
> On HSW (with vec4 vertex shaders):
> instructions in affected programs:
> -LIBDRM_INTEL_REQUIRED=2.4.60
> +LIBDRM_INTEL_REQUIRED=2.4.59
Hang on, what's this hunk doing here?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Looks good to me. I should have considered this cross-stage case when
I fixed the first part of this bug...
Do you have a piglit test which hits this?
Reviewed-by: Chris Forbes
On Mon, Mar 23, 2015 at 8:12 PM, Tapani Pälli wrote:
> Patch changes lowering pass to use unique name for e
Jordan,
You also need to set m0.2:15 (Barrier count enable) and m0.2:14-9
(Barrier count) to have the message gateway actually collect the
proper number of threads, right?
- Chris
On Mon, Mar 23, 2015 at 2:49 PM, Jordan Justen
wrote:
> Signed-off-by: Jordan Justen
> Reviewed-by:
I think that having both the existing `struct brw_vs_compile` and a
function with the same name is going to cause confusion. (same with
the other non-fs stages)
On Sat, Mar 21, 2015 at 2:04 PM, Ian Romanick wrote:
> On 03/20/2015 06:02 PM, Ian Romanick wrote:
>> On 03/20/2015 05:49 PM, Carl Worth
LGTM.
Reviewed-by: Chris Forbes
On Sat, Mar 7, 2015 at 1:15 PM, Anuj Phogat wrote:
> in different fragment shaders. This also applies to a case when gl_FragCoord
> is redeclared with no layout qualifiers in one fragment shader and not
> declared but used in other fragment shader.
&
With the fix Jason mentioned:
Reviewed-by: Chris Forbes
On Wed, Mar 18, 2015 at 10:19 AM, Matt Turner wrote:
> On Tue, Mar 17, 2015 at 2:15 PM, Jason Ekstrand wrote:
>> On Tue, Mar 17, 2015 at 2:09 PM, Matt Turner wrote:
>>> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.c
Most of the brw_inst_* api returns 64bit values. This fixes disassembly
of sampler messages, etc.
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_disasm.c | 48 +-
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/src/mesa/drivers/dri
This allows us to get warnings from GCC when we mess up the format
strings.
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_disasm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c
b/src/mesa/drivers/dri/i965/brw_disasm.c
index
1 - 100 of 1332 matches
Mail list logo