On Friday, 2019-03-08 15:54:37 -0700, Brian Paul wrote:
> ---
> docs/meson.html | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/docs/meson.html b/docs/meson.html
> index 7ffef81..43090aa 100644
> --- a/docs/meson.html
> +++ b/docs/meson.html
> @@ -274,6 +274,19 @@ on the s
option.
Thanks! I left a couple comments below, but this is:
Reviewed-by: Eric Engestrom
> ---
> docs/contents.html | 2 +-
> docs/meson.html| 138
> +++--
> 2 files changed, 104 insertions(+), 36 deletions(-)
>
> diff -
On Sunday, 2019-03-03 21:10:50 +0100, Mauro Rossi wrote:
> Necessary to avoid building error in Android,
> due to 'compiler/glsl/float64_glsl.h' file not found
>
> Fixes: cb4e3e3 ("st/mesa: add support for lowering fp64/int64 for nir
> drivers")
> Signed-off-by: Mauro Rossi
> ---
> src/mesa/And
nce sys/types.h is included through another
> system headers
Reviewed-by: Eric Engestrom
> ---
> src/gallium/winsys/svga/drm/vmw_screen.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/winsys/svga/drm/vmw_screen.h
> b/src/gallium/winsys/svga/drm/vmw_sc
ect... :]
Fixes: cc15460e182148292be8 "meson: drop GLESv1 .so version back to 1.0.0"
Reviewed-by: Eric Engestrom
> ---
> src/mapi/es1api/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mapi/es1api/meson.build b/src/mapi/es1api
On Monday, 2019-02-25 11:57:20 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Mention the tick-box otherwise only the MR author can rebase the series.
I thought it was already mentioned... oops.
Reviewed-by: Eric Engestrom
>
> Cc: Jordan Justen
> Cc: Dylan Baker
&g
Hi all,
The GitLab CI translated from Travis is really resource-hungry (see the
discussion DanielS started [1]).
Efforts are ongoing to make it nicer to its runners, but as
a (hopefully) temporary measure, the CI is now opt-in to avoid wasting
cycles if the dev pushing commits didn't want to run
On Tuesday, 2019-02-19 15:30:39 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Some platforms lack O_CLOEXEC. The loader_open_device() handles those
> appropriately, so use the helper.
>
> Signed-off-by: Emil Velikov
I'll review 1 & 3 later, but 2 & 4 a
ast) {
> + /* Use kms swrast only with vgem */
> + if (strcmp(driver_name, "vgem") == 0)
> +dri2_dpy->driver_name = strdup("kms_swrast");
> + free(driver_name);
> + } else {
> + /* Use the given hardware driver
On Monday, 2019-02-18 17:31:41 +, Daniel Stone wrote:
> Hi all,
> A few people have noted that Mesa's GitLab CI is just too slow, and
> not usable in day-to-day development, which is a massive shame.
Agreed :/
>
> I looked into it a bit this morning, and also discussed it with Emil,
> though
On Tuesday, 2019-02-05 15:31:08 +, Emil Velikov wrote:
> From: Emil Velikov
>
> VGEM and kms_swrast were introduced to work with one another.
>
> All we do is CPU rendering to dumb buffers. There is no reason to carve
> out GPU memory, increasing the memory pressure on a device that could
>
ES 32
> struct dri2_egl_display *dri2_dpy = dpy->DriverData;
> - const int limit = 64;
Any reason to drop the 64 down to 32?
Other than that, looks good to me:
Reviewed-by: Eric Engestrom
> - const int base = 128;
> - int fd;
> - int i;
> -
> - /* Attempt to find D
e = _eglAddDevice(dri2_dpy->fd, true);
> + assert(dpy->Device);
>
> - return false;
> + dri2_dpy->driver_name = strdup("swrast");
> + if (!dri2_dpy->driver_name)
> + return false;
> +
> + if (!dri2_load_driver_swrast(dpy))
free(dri2_dpy
-Dtools=etnaviv -Dplatforms=wayland -Dglx=disabled \
>build/
>
> Cc: Alexander von Gluck IV
> Cc: Dylan Baker
> Cc: Boris Brezillon
> Reported-by: Boris Brezillon
> Fixes: 834d221512f ("meson: Add Haiku platform support v4")
> Signed-off-by: Emil Velikov
Revie
of the error
message, can you update that?
Regardless, the patch is correct:
Reviewed-by: Eric Engestrom
>
> Fixes: 1ce5d757d04a ("freedreno: core buffer modifier support")
> Signed-off-by: Vinson Lee
> ---
> src/gallium/drivers/freedreno/meson.build | 2 +-
> 1 file
so have this patch somewhere... I should send out my
patches more regularly :]
With Frank's typo fix
Reviewed-by: Eric Engestrom
> ---
> src/egl/drivers/dri2/egl_dri2.c | 45 -
> 1 file changed, 11 insertions(+), 34 deletions(-)
>
> diff --git a/src
L_BAD_MATCH.
Admittedly I don't understand everything in this function, but your
patch looks reasonable.
Acked-by: Eric Engestrom
I ran it through our CI and no regression was spotted, so there's
that :)
If Emil doesn't raise any concern by the end of the week, I'll push
On Tuesday, 2019-02-05 12:09:45 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Cc: Rafael Antognolli
> Cc: Jason Ekstrand
> Cc: Dylan Baker
> Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.")
> Signed-off-by: Emil Veliko
On Saturday, 2019-02-02 10:32:15 -0500, Marek Olšák wrote:
> On Sat, Feb 2, 2019, 7:17 AM Eric Engestrom
> > On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote:
> > > If there is no feedback soon, I'll push this.
> >
> > Have you tested that xcb-randr &
On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote:
> If there is no feedback soon, I'll push this.
Have you tested that xcb-randr < 1.12 works?
Probably shouldn't remove a restriction unless you're sure it isn't
needed :)
>
> Marek
>
> On Wed, Jan 30, 2019 at 12:44 PM Erik Faye-Lund <
> e
On Monday, 2019-01-28 14:29:00 -0500, Ilia Mirkin wrote:
> 2. I've seen a bunch of things land where I would have had comments
> beforehand. Once the patch is in, I don't really have an easy way to
> provide feedback. In the past if such a thing would happen, I just
> take the subject of the patch,
On Saturday, 2019-01-26 00:50:40 -0800, Caio Marcelo de Oliveira Filho wrote:
> This patch is
>
> Reviewed-by: Caio Marcelo de Oliveira Filho
>
> Since it fixes a patch that were marked for stable, maybe add CC:
> stable for this one too?
`Fixes:` already means it will be applied everywhere the
On Saturday, 2019-01-26 08:28:20 +, Vinson Lee wrote:
> meson.build:166:21: ERROR: Unknown method "verson_compare" for a string.
Oops, thanks for the patch.
Reviewed-by: Eric Engestrom
>
> Fixes: c1efa240c91e ("meson: Add warnings and errors when using ICC"
On Thursday, 2019-01-17 15:55:44 +0100, Erik Faye-Lund wrote:
> It could have been made obvious for instance by showing the commit-
> graph next to the commit-list, decorating it with the branch head in
> one end and clear continuation in the other.
I'd love that, it would really help a lot!
Care
On Friday, 2019-01-11 09:50:25 -0800, Caio Marcelo de Oliveira Filho wrote:
[snip]
> - To find the discussion associated with a commit in master, I'd
> search the title in the mailing list archives. With MRs, the usual
> way that this connection is made would be the reference to the MR as
>
On Wednesday, 2019-01-23 11:28:14 +0100, Erik Faye-Lund wrote:
> On Wed, 2019-01-23 at 10:08 +0000, Eric Engestrom wrote:
> > On Wednesday, 2019-01-23 10:36:15 +0100, Erik Faye-Lund wrote:
> > > Sending MRs from the main Mesa repository increase clutter in the
> > &g
On Wednesday, 2019-01-23 11:21:27 +0100, Erik Faye-Lund wrote:
> On Wed, 2019-01-23 at 10:14 +, Daniel Stone wrote:
> > Hi,
> >
> > On Wed, 23 Jan 2019 at 10:09, Eric Engestrom <
> > eric.engest...@intel.com> wrote:
> > > On Wednesday, 2019-
fork rather than from the main
> + Mesa repository
I would add "as it clutters it unnecessarily" as you mentioned in the
commit message.
Reviewed-by: Eric Engestrom
>
>
>
> --
> 2.20.1
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tuesday, 2019-01-22 13:32:15 +, Emil Velikov wrote:
> On Mon, 21 Jan 2019 at 19:53, Eric Engestrom wrote:
> >
> AFAICT this triggers when egl is explicitly disabled and drm is
> explicitly listed in the with-platforms list.
> Please add the triggering configure line to
Fixes: 2c4f6ceeb466cb15df34 "configure.ac: Fail if egl x11 platform
dependencies are not available"
Signed-off-by: Eric Engestrom
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index c7473d77ef
(if available).
Yeah, I had that change locally, but didn't push it :]
Reviewed-by: Eric Engestrom
>
> 7c8ee3f0f "util: simplify string duplication logic"
"Fixes:" ?
> ---
> tests/util/piglit-shader-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On Saturday, 2019-01-12 13:24:38 -0500, Ilia Mirkin wrote:
> On Sat, Jan 12, 2019 at 9:40 AM Gert Wollny wrote:
> > I will not push it with
> > the strong NAK you gave, Ilia. To me consensus means that all who
> > contribute significantly to the project (like you certainly do) agree
> > or abstain
On Friday, 2019-01-11 16:43:27 +0200, Andres Gomez wrote:
> "&>" is bash specific.
>
> Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid
> sha")
> Cc: Juan A. Suarez
> Cc: Eric Engestrom
> Cc: Dylan Baker
> Cc: Emil V
"bin/get-pick-list.sh: simplify git oneline printing")
> Cc: Juan A. Suarez
> Cc: Eric Engestrom
> Cc: Dylan Baker
> Cc: Emil Velikov
> Signed-off-by: Andres Gomez
> ---
> bin/get-pick-list.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -
On Friday, 2019-01-11 14:20:38 +, Emil Velikov wrote:
> On Wed, 2 Jan 2019 at 13:48, Eric Engestrom wrote:
> >
> > On Thursday, 2018-12-27 20:41:47 +, Alexander von Gluck IV wrote:
> > > ---
> > > src/egl/drivers/haiku/egl_haiku.cpp | 3 ++-
> >
On Friday, 2019-01-11 10:58:38 +0100, Iago Toral Quiroga wrote:
> We had defined MAX_IMAGES as 8, which we used to size the array for
> image push constant data. The comment there stated that this was for
> gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes
> that array, asserting
On Tuesday, 2019-01-08 14:30:32 +0100, Samuel Pitoiset wrote:
> Signed-off-by: Samuel Pitoiset
Acked-by: Eric Engestrom
You've inspired me, I'll send the same for anv in a bit ;)
> ---
> src/amd/vulkan/radv_android.c| 18 +--
> src/amd/vulkan/radv_cmd_buffer
; diff --git a/src/egl/main/eglconfigdebug.h b/src/egl/main/eglconfigdebug.h
> new file mode 100644
> index 000..8be6223
> --- /dev/null
> +++ b/src/egl/main/eglconfigdebug.h
> @@ -0,0 +1,55 @@
> +/**
> + *
On Monday, 2019-01-07 12:43:54 -0800, Dylan Baker wrote:
> Quoting Andres Gomez (2019-01-07 05:49:00)
> > The property is supported by the most of the editors, but not all:
> > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
> >
&
On January 7, 2019 5:07:34 PM UTC, Andres Gomez wrote:
> As suggested by Emil Velikov.
>
> Cc: Dylan Baker
> Cc: Juan A. Suarez
> Cc: Emil Velikov
> Signed-off-by: Andres Gomez
Reviewed-by: Eric Engestrom
> ---
> docs/release-calendar.html | 10 +
Hopefully we can kick start the revolution and other distros will start
providing them as well :)
Signed-off-by: Eric Engestrom
---
docs/meson.html | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/meson.html b/docs/meson.html
index eff13aa1c515825eb564..082333b19d3673af1340
`gcc-ar` is preferred over the generic `ar`, and the `arm` family is
for 32-bit ARM [1].
[1] https://mesonbuild.com/Reference-tables.html#cpu-families
Signed-off-by: Eric Engestrom
---
docs/meson.html | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/meson.html b
return EGL_FALSE;
> }
> - disp->Device = dev;
> + dpy->Device = dev;
>
> TRACE("Add configs\n");
> if (!haiku_add_configs_for_visuals(dpy))
> --
> 2.14.5
Thanks!
Pushed with these tags added:
Reviewed-by: Eric Engestrom
Fixes: 009
Fixes the following errors:
usage: which [-as] program ...
/Users/travis/.travis/job_stages: line 110: --version: command not found
... caused by the use of an undefined $LLVM_CONFIG
Signed-off-by: Eric Engestrom
---
.travis.yml | 14 +-
1 file changed, 9 insertions(+), 5
On Monday, 2018-12-17 11:37:05 -0800, Dylan Baker wrote:
> Quoting Emil Velikov (2018-12-17 11:03:32)
> > On Fri, 14 Dec 2018 at 17:53, Dylan Baker wrote:
> > >
> > > Quoting Emil Velikov (2018-12-13 08:06:07)
> > > > From: Emil Velikov
> > > >
> > > > This commit adds a number of build combos:
>
fused as to how you can see this failure.
>
>
> Jan
>
> On Mon, Dec 24, 2018 at 10:51 AM Jan Vesely wrote:
>
> > On Sun, 2018-12-23 at 15:35 +, Eric Engestrom wrote:
> > > On Sunday, 2018-12-23 12:31:20 +0100, Jan Vesely wrote:
> > > > Fr
On Sunday, 2018-12-23 12:31:20 +0100, Jan Vesely wrote:
> From: Jan Vesely
>
> intel_vulkan.h uses '#include "vulkan.h"' so the file needs to be in
> include path.
> Fixes meson build of anv
Hmm, that doesn't look?
include/vulkan/vulkan_intel.h has `#include "vulkan.h"`, which lives at
include/
On Tuesday, 2018-12-18 01:09:48 +0200, Andres Gomez wrote:
> Cc: Dylan Baker
> Cc: Juan A. Suarez
> Cc: Emil Velikov
> Signed-off-by: Andres Gomez
> ---
> docs/release-calendar.html | 118 -
> 1 file changed, 116 insertions(+), 2 deletions(-)
>
> diff --git
On Thursday, 2018-12-20 08:30:53 +, Silvestrs Timofejevs wrote:
> Eric, thank you for reviewing my patch. I have expanded little bit
> on some of your comments bellow. I will be sending fallow up V2 of the patch
> shortly.
> On Thu, Dec 06, 2018 at 11:00:25AM +, Eric Eng
7;s changing
- they'll choose to either ignore it, use the flag, and *choose* to go
with the option above
- or they can choose to try meson, get any issues fixed *while still
being able to work with their old setup in the mean time*
This last bit is the entire point of this patch, so let me
On Tuesday, 2018-12-18 09:51:19 +0100, Juan A. Suarez Romero wrote:
> On Mon, 2018-12-17 at 19:51 +0100, Bas Nieuwenhuizen wrote:
> > On Mon, Dec 17, 2018 at 6:33 PM Juan A. Suarez Romero
> > wrote:
> > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote:
On December 18, 2018 5:36:19 PM UTC, Dylan Baker wrote:
> Quoting Ilia Mirkin (2018-12-06 09:39:25)
> > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom
> wrote:
> > >
> > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote:
> > > > Under w
On Wednesday, 2018-12-12 15:24:25 -0800, Dylan Baker wrote:
> In the autotools discussion I've come to realize that we also need to talk
> about
> the -DDEBUG guard. It seems that there are two different uses, and thus two
> different asks about it:
>
> - Nine (and RadeonSI?) use -DDEBUG to hide
On Wednesday, 2018-12-12 19:45:06 -0500, Marek Olšák wrote:
> On Wed, Dec 12, 2018 at 7:35 PM Rob Clark wrote:
>
> > On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote:
> > >
> > > Quoting Rob Clark (2018-12-12 15:52:47)
> > > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker
> > wrote:
> > > > >
>
for the dependency.
>
> v2: terminate the GLX_USE_WINDOWSGL hunk
>
> Cc: Jon TURNEY
> Cc: Dylan Baker
> Cc: Eric Engestrom
> Fixes: 5bc509363b6 ("glx: make xf86vidmode mandatory for direct rendering")
> Signed-off-by: Emil Velikov
> ---
> This time it'
"meson: build gallium vdpau state tracker"
Signed-off-by: Eric Engestrom
---
src/gallium/state_trackers/vdpau/meson.build | 9 -
src/gallium/targets/vdpau/meson.build| 3 ++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/vdpau/m
the dependency.
>
> Cc: Jon TURNEY
> Cc: Dylan Baker
> Cc: Eric Engestrom
> Fixes: 5bc509363b6 ("glx: make xf86vidmode mandatory for direct rendering")
> Signed-off-by: Emil Velikov
> ---
> configure.ac | 4 ++--
> meson.build | 4 ++--
>
On Friday, 2018-12-07 10:19:23 +0100, Erik Faye-Lund wrote:
> On Wed, 2018-12-05 at 21:46 -0600, Jason Ekstrand wrote:
> > On Wed, Dec 5, 2018 at 7:05 PM Jordan Justen <
> > jordan.l.jus...@intel.com> wrote:
> > > On 2018-12-05 15:44:18, Jason Ekstrand wrote:
> > > > On Wed, Dec 5, 2018 at 5:32 PM
On Friday, 2018-12-07 09:16:38 -0800, Dylan Baker wrote:
> Just to make it easier to run a nir tests together.
>
> Fixes: a0ae12ca91a45f81897e774019cde9bd081f03a0
>("nir/algebraic: Add unit tests for bitsize validation")
Reviewed-by: Eric Engestrom
> ---
>
ik, Jason,
>Matt, Michel and Rob.
>
> Signed-off-by: Jordan Justen
Reviewed-by: Eric Engestrom
> ---
> docs/submittingpatches.html | 76 ++---
> 1 file changed, 71 insertions(+), 5 deletions(-)
>
> diff --git a/docs/submittingpatches.html b/
Thierry Reding (cc'ed) when he first introduced
tegra support in 1755f608f5201e0a23f00 "tegra: Initial support".
> On Thu, Dec 6, 2018 at 11:57 AM Eric Engestrom
> wrote:
> >
> > From: Igor Gnatenko
> >
> > Fixes: 68076b87474e7959c161 "mes
From: Igor Gnatenko
Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker"
Cc: Dylan Baker
---
src/gallium/targets/vdpau/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/targets/vdpau/meson.build
b/src/gallium/targets/vdpau/meson.bui
On Friday, 2018-11-09 18:04:12 +, Silvestrs Timofejevs wrote:
> Feature to print out EGL returned configs for debug purposes.
>
> 'eglChooseConfig' and 'eglGetConfigs' debug information printout is
> enabled when the log level equals '_EGL_DEBUG'. The configs are
> printed, and if any of them
Added in 824cfc1ee5e0aba15b676 "radv: rework the TC-compat HTILE
hardware bug with COND_EXEC", but it is unused.
Signed-off-by: Eric Engestrom
---
src/amd/vulkan/radv_cmd_buffer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/
ned(__VEC__) || !defined(__ALTIVEC__)
> +#error "AltiVec not enabled"
> +#endif''',
> +args : _test_args,
> +name : 'Altivec')
> + clover_cpp_std += ['cpp_std=gnu++11']
> +endif
This doe
I think it would be good to link to our meson page and point to our
mailing list as well, as I expect the ones who still hadn't moved on
will need help :)
>
>
>
> diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
> index 3f97c941aa5..4a9a983b43a 100644
> --- a/docs/submittingpatches.html
> +++ b/docs/submittingpatches.html
[snip]
> @@ -370,7 +370,7 @@ within the commit summary.
>
> Test for build breakage between patches e.g last 8 commits.
>
> -git rebase -i --exec="make -j4" HEAD~8
> +git rebase -i --exec="ninja" HEAD~8
IIRC git rebase will CWD to the git root, so you will need
`ninja -C builddir/` here.
>
> Sets the default mailing address for your repo.
>
> diff --git a/docs/vmware-guest.html b/docs/vmware-guest.html
> index 4e0932e781f..0c7bcbed59d 100644
> --- a/docs/vmware-guest.html
> +++ b/docs/vmware-guest.html
> @@ -106,13 +106,14 @@ On the host, all you're doing is running VMware
>
> Prerequisites
>
> + sudo apt-get install automake libtool libpthread-stubs0-dev
I'm assuming this is a rebase mistake?
>
> Kernel version at least 2.6.25
> Xserver version at least 1.7
> Ubuntu: For ubuntu you need to install a number of build dependencies.
>
>sudo apt-get install git-core
> - sudo apt-get install automake libtool libpthread-stubs0-dev
> + sudo apt-get install automake libtool meson libpthread-stubs0-dev
>sudo apt-get install xserver-xorg-dev x11proto-xinerama-dev libx11-xcb-dev
>sudo apt-get install libxcb-glx0-dev libxrender-dev
>sudo apt-get build-dep libgl1-mesa-dri libxcb-glx0-dev
[snip]
Other than that, it looks all good to me!
Assuming the release managers are ok with your changes to
docs/releasing.html, this is:
Reviewed-by: Eric Engestrom
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
2018 at 6:19 PM andrey simiklit
> wrote:
>
> > On Fri, Nov 30, 2018 at 5:49 PM Eric Engestrom
> > wrote:
> >
> >> On Friday, 2018-11-30 15:47:11 +, Lionel Landwerlin wrote:
> >> > On 14/11/2018 16:30, asimiklit.w...@gmail.com wrote:
> >
On Monday, 2018-12-03 09:31:21 -0800, Dylan Baker wrote:
> There are now no known distributions using autotools, meson has all of
> the features that autotools does. We don't need two build systems to do
> exactly the same thing, meson is faster, easier to maintain, and used by
> more devs than aut
This silences the -Wswitch compiler warning.
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_image.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 4003ac28444d7edffbf9..1748e9230d726c214715 100644
--- a/src/intel
On Tuesday, 2018-12-04 14:14:51 +0200, Toni Lönnberg wrote:
> ../src/intel/tools/aubinator_error_decode.c: In function
> ‘instdone_register_for_ring’:
> ../src/intel/tools/aubinator_error_decode.c:177:4: warning: enumeration value
> ‘I915_ENGINE_CLASS_INVALID’ not handled in switch [-Wswitch]
>
On Monday, 2018-12-03 10:06:30 -0800, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-12-03 09:46:29)
> > On Monday, 2018-12-03 09:25:48 -0800, Dylan Baker wrote:
> > > Can I admit I was really wanted to send this patch out and it actually
> > > makes me
> &
On Monday, 2018-12-03 09:25:48 -0800, Dylan Baker wrote:
> Can I admit I was really wanted to send this patch out and it actually makes
> me
> sad that you beat me too it?
Heh, I think many (most?) of us wanted to send this patch :P
>
> That said there are a couple things you missed.
I think
On Monday, 2018-12-03 08:59:48 -0800, Eric Anholt wrote:
> Eric Anholt writes:
>
> > [ Unknown signature status ]
> > Eric Engestrom writes:
> >
> >> Cc: Emil Velikov
> >> Cc: Andres Gomez
> >> Cc: Juan A. Suarez Romero
>
Cc: Emil Velikov
Cc: Andres Gomez
Cc: Juan A. Suarez Romero
Cc: Dylan Baker
Signed-off-by: Eric Engestrom
---
This patch depends on the releasing procedure in docs/releasing.html to
be updated to not rely on autotools anymore.
I think our release managers (cc'ed) should work togethe
with attribute warn_unused_result
> > fread(assembly, *end, 1, fp);
> >
> > v2: Fixed incorrect return value check.
> > ( Eric Engestrom )
> >
> > v3: Zero size file check placed before fread with exit()
> > ( Eric Engestrom )
> >
Signed-off-by: Eric Engestrom
---
The 32-bit linux one is tested, but the other two are "I think this
should be right".
---
docs/meson.html | 83 +
1 file changed, 83 insertions(+)
diff --git a/docs/meson.html b/docs/meson.
Signed-off-by: Eric Engestrom
---
docs/mesa.css | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/mesa.css b/docs/mesa.css
index 7ab8152b040e6f469711..cfdcc94a06759befd568 100644
--- a/docs/mesa.css
+++ b/docs/mesa.css
@@ -29,6 +29,9 @@ pre {
/*font-family: monospace
On Wednesday, 2018-11-28 13:36:29 -0800, Eric Anholt wrote:
> Jordan Justen writes:
>
> > This documents a mechanism for using GitLab Merge Requests as an
> > optional, secondary way to get code reviews for patchsets.
> >
> > We still require all patches to be emailed.
> >
> > Aside from the pote
On Thursday, 2018-11-29 10:11:22 +0100, Erik Faye-Lund wrote:
> On Tue, 2018-11-27 at 17:13 -0800, Jordan Justen wrote:
> > This documents a mechanism for using GitLab Merge Requests as an
> > optional, secondary way to get code reviews for patchsets.
> >
> > We still require all patches to be ema
Signed-off-by: Eric Engestrom
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 4ee40503d044a0985c89..2d300d0421980cba7866 100644
--- a/meson.build
+++ b/meson.build
@@ -917,7 +917,7 @@ endif
# case of cross compiling where we
On Wednesday, 2018-11-28 16:28:53 +0100, Erik Faye-Lund wrote:
> On Wed, 2018-11-28 at 15:20 +, Emil Velikov wrote:
> > On Wed, 28 Nov 2018 at 14:29, Eric Engestrom <
> > eric.engest...@intel.com> wrote:
> > > On Wednesday, 2018-11-28 01:18:16 -0800, Jordan Juste
On Tuesday, 2018-11-27 19:45:50 -0800, Jordan Justen wrote:
> On 2018-11-27 19:20:09, Matt Turner wrote:
> > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > wrote:
> > >
> > > This documents a mechanism for using GitLab Merge Requests as an
> > > optional, secondary way to get code reviews for
e copy it from https://developercertificate.org/?
>
> > I would propose you add it as a separate file and link that, to avoid
> > confusion about what "this license document" refers to.
>
> I do see that Eclipse had it on a page with other content. A
more.
And while at it:
Reviewed-by: Eric Engestrom
Cc: mesa-sta...@lists.freedesktop.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Fixes: da997ebec92942193955 "vulkan: Add KHR_display extension using DRM [v10]"
Cc: Keith Packard
Signed-off-by: Eric Engestrom
---
src/vulkan/wsi/wsi_common_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common_display.c
b/src/
On Tuesday, 2018-11-27 11:39:42 +, Emil Velikov wrote:
> From: Emil Velikov
>
> As we fail to open the node, we leak the node/device name.
>
> Cc: mesa-sta...@lists.freedesktop.org
> Cc: Eric Engestrom
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/
Scons and autotools don't define it, and as of last commit nothing
uses it.
`VERSION` is also a generic enough name that something somewhere will
eventually clash, and we don't want to repeat the LLVM `DEBUG` fiasco.
Signed-off-by: Eric Engestrom
---
Android.common.mk | 1 -
m
Everything else uses PACKAGE_VERSION, so let's be consistent, and
VERSION and PACKAGE_VERSION are currently defined to be the same in
meson and android, while VERSION is undefined in autotools and scons.
Signed-off-by: Eric Engestrom
---
src/vulkan/util/vk_util.c | 6 +++---
1 file chang
anv and radv both happened to already return 2^14 for these, but
querying the ICD is better and will help if vdreno (or whatever it's
called) doesn't have the same max.
Signed-off-by: Eric Engestrom
---
src/vulkan/wsi/wsi_common.c | 7 ---
src/vulkan/wsi/wsi_common.h
his looked familiar... turns out I sent this exact patch a couple years
ago, but never got around to addressing your comments :P
https://patchwork.freedesktop.org/patch/98132/
Anyway, with the close(fd) and free(device_name) you mentioned, this is:
Reviewed-by: Eric Engestrom
(While at it, free(devic
On Thursday, 2018-11-22 15:04:54 +, Emil Velikov wrote:
> On 2018/11/22, Eric Engestrom wrote:
> > On Thursday, 2018-11-22 13:15:05 +0000, Eric Engestrom wrote:
> > > More or less any of this issue pointed out by the compiler is
> > > a coding error. Make sure
n info into the instance"
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index f35a61fa0817a505a8f0..45ba2c1b10b6ee505be2 100644
--- a/src/intel/
ight; why did you change
it to use the icd version instead? Was is fixing an issue somewhere?
Unless Bas objects, this is:
Reviewed-by: Eric Engestrom
> }
>
> instance = vk_zalloc2(&default_alloc, pAllocator, sizeof(*instance), 8,
> --
> 2.19.1
>
> __
Not a hot path obviously, but the table still has 425 extensions, which
you can go through in just 9 steps with a binary search.
The table is already sorted, as required by other parts of the code and
enforced by mesa's `main-test`.
Signed-off-by: Eric Engestrom
---
src/mesa/main/extensi
The correct include path is "vulkan/…".
Signed-off-by: Eric Engestrom
---
include/meson.build | 1 -
src/vulkan/util/meson.build | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/meson.build b/include/meson.build
index 081c1bc000
On Thursday, 2018-11-22 13:15:05 +, Eric Engestrom wrote:
> More or less any of this issue pointed out by the compiler is
> a coding error. Make sure we flag it and bail loudly.
>
> v2: - apply the change to autotools and scons as well (Emil)
> - C++ doesn't need t
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108829
Cc: Emil Velikov
Fixes: 3218056e0eb375eeda470 "meson: Build i965 and dri stack"
Signed-off-by: Eric Engestrom
---
src/mapi/shared-glapi/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/m
More or less any of this issue pointed out by the compiler is
a coding error. Make sure we flag it and bail loudly.
v2: - apply the change to autotools and scons as well (Emil)
- C++ doesn't need this, it's already an error and the flag
doesn't exist (Gert)
Sign
On Wednesday, 2018-11-21 13:14:48 +, Emil Velikov wrote:
> From: Emil Velikov
>
> More or less any issue pointed out by the compiler is an error. Make
> sure we flag and bail loudly.
>
> Cc: Eric Engestrom
> Signed-off-by: Emil Velikov
> ---
> Eric, feel fr
On Thursday, 2018-11-22 12:07:03 +, Emil Velikov wrote:
> On 2018/11/21, Gert Wollny wrote:
> > Am Mittwoch, den 21.11.2018, 13:14 + schrieb Emil Velikov:
>
> > > +AX_CHECK_COMPILE_FLAG([-Werror=incompatible-pointer-
> > > types],[CFXXLAGS="$CXXFLAGS -Werror=incompatible-pointer-types"
201 - 300 of 2141 matches
Mail list logo
