Re: [Mesa-dev] [PATCH 1/5] swr/rast: Remove unneeded virtual from methods

Whole series Reviewed-By: George Kyriazis > Thanks! On May 16, 2018, at 11:14 AM, Alok Hota > wrote: --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.h | 4 ++-- 1 file

Re: [Mesa-dev] [PATCH] swr: Fix include for createInstructionCombiningPass with llvm-7.0.

It would be nice to avoid the extra #if LLVM_VERSION_MAJOR and include InstCombine.h into the same #if below, as follows: --- a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp +++ b/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp @@ -69,6 +69,7 @@ using PassManager =

Re: [Mesa-dev] [PATCH] swr/rast: Fix WriteBitcodeToFile usage with llvm-7.0.

Reviewed-By: George Kyriazis > On May 1, 2018, at 2:05 AM, Vinson Lee > wrote: Fix build error after llvm-7.0svn r325155 ("Pass a reference to a module to the bitcode writer."). CXX

Re: [Mesa-dev] [PATCH] swr: Fix include for createInstructionCombiningPass with llvm-7.0.

This patch does not address all the compile issues with llvm trunk (at least the ones that I see in my build). The following patch, however, works: diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index

Re: [Mesa-dev] [PATCH 2/3] Autotools: Add passes.h to sources so it will be included in the tarball

I agree on the commit message wording. Sorry about missing passes.h in the original check-in. Reviewed-by: George Kyriazis > On Apr 20, 2018, at 10:00 PM, Kenneth Graunke > wrote:

Re: [Mesa-dev] [PATCH] swr: Remove unnecessary memset call

Reviewed-By: George Kyriazis > On Apr 12, 2018, at 8:49 PM, Vlad Golovkin > wrote: Zeroing memory after calloc is not necessary. This also allows to avoid possible

Re: [Mesa-dev] [PATCH v3 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

Thank you! Reviewed-By: George Kyriazis > On Apr 4, 2018, at 3:22 AM, Mike Lothian > wrote: Include llvm/Transforms/Utils.h with the newest LLVM 7 v2: Include with " " rather than < >

Re: [Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

Please use LLVM defines consistent with the surrounding code. Surrounding code uses LLVM_VERSION_MAJOR / LLVM_VERSION_MINOR. This code should then be: #if LLVM_VERSION_MAJOR >= 7 … #endif Thank you! George > On Apr 1, 2018, at 3:05 PM, Vinson Lee wrote: > > On Sun,

Re: [Mesa-dev] [PATCH] autotools: include all meson.build files

Reviewed-By: George Kyriazis > On Mar 2, 2018, at 12:00 PM, Dylan Baker > wrote: Otherwise SWR cannot be built with meson from an autotools generated tarball, such as the 18.0.0-rc4

Re: [Mesa-dev] [PATCH] swr/rast: Fix macOS macro.

Yes, a typo on our end. Thank you! Reviewed-By: George Kyriazis > On Feb 24, 2018, at 5:55 PM, Vinson Lee > wrote: Fixes: a25093de7188 ("swr/rast: Implement JIT shader caching to

Re: [Mesa-dev] Patch submit question

It’s a commit that needs to be slightly different in master and 18.0, hence 2x the # of commits. Thanks for the 662cff8f pointer. Perfect example! George > On Feb 26, 2018, at 4:14 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > > On 26 February 2018 at 20:18, K

Re: [Mesa-dev] Patch submit question

Thanks Jordan, Since I won’t be checking this in to mesa master, what do I need to do to actually push it to the stable branch, after I get a review on mesa-dev? George > On Feb 23, 2018, at 5:43 PM, Justen, Jordan L <jordan.l.jus...@intel.com> > wrote: > > On 2018-02-23

Re: [Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

It also fixes the errors that I was getting with gcc 5.4.0 with configure build on ubuntu 16.04. Tested-By: George Kyriazis > On Feb 25, 2018, at 6:52 PM, Roland Scheidegger > wrote: Am

Re: [Mesa-dev] Mesa (master): glsl: Switch ast_type_qualifier to a 128-bit bitset.

Hello Francisco, This change breaks my ubuntu 16.04 build with gcc 5.4.0. Here’t where it breaks: CXX glsl/glsl_lexer.lo In file included from ../../../src/compiler/glsl/glsl_lexer.ll:27:0: ../../../src/compiler/glsl/ast.h:643:16: error: member ‘ast_type_qualifier::bitset_t

[Mesa-dev] Patch submit question

Hello mesa-dev, I have a quick patch submission question: I have a patch that I’d like to also nominate to mesa-stable (specifically 18.0.1 or 18.0.2), however the same patch is different between master and stable branches, due to neighboring code having changed in the meantime. What’s the

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

lib-glx segfaults. - Chuck On Wed, Feb 21, 2018 at 12:36 PM, Kyriazis, George <george.kyria...@intel.com<mailto:george.kyria...@intel.com>> wrote: Chuck, In which cases do you hit this? When an architecture is not supported, then swr_create_screen() falls back to a different

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

Chuck, In which cases do you hit this? When an architecture is not supported, then swr_create_screen() falls back to a different (older) architecture. Thanks, George > On Feb 21, 2018, at 8:26 AM, Chuck Atkins wrote: > > This fixes a segfault exposed by a29d63ecf7

Re: [Mesa-dev] [PATCH] swr: remove dead LLVM code paths

Thank you, Emil, for the cleanup! Reviewed-By: George Kyriazis > On Feb 20, 2018, at 12:03 PM, Emil Velikov > wrote: From: Emil Velikov

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

> On Feb 13, 2018, at 4:54 PM, Dylan Baker wrote: > > Quoting Andres Gomez (2018-02-13 14:42:57) > [snip] >> >> -if with_amd_vk or with_gallium_radeonsi >> +if with_amd_vk or with_gallium_radeonsi or with_gallium_swr >> _llvm_version = '>= 4.0.0' >> -elif

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

I am not an expert on all the changes needed for travis and packaging, but the swr changes look good. Reviewed-by: George Kyriazis > On Feb 13, 2018, at 4:42 PM, Andres Gomez > wrote:

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

SWR is OK with moving to LLVM 4.0 and above. Just to clarify: This goes to master, which means mesa 18.0 is not affected, just 18.1 and later. Correct? Thanks, George > On Feb 6, 2018, at 11:07 AM, Kyriazis, George <george.kyria...@intel.com> > wrote: > > As far as SWR i

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

As far as SWR is concerned, we’ll have to ask our customers. Will respond shortly. Thanks, George > On Feb 6, 2018, at 9:42 AM, Andres Gomez wrote: > > Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") > Cc: Marek Olšák > Cc: Emil Velikov

Re: [Mesa-dev] [PATCH] swr: don't export swr_create_screen_internal

Yep, tested on our side, and looks good. Reviewed-By: George Kyriazis > On Jan 29, 2018, at 9:42 AM, Chuck Atkins > wrote: Lgtm, should probably get a rb from Intel though to

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr/rast: support llvm 3.9 type declarations

On Jan 24, 2018, at 11:43 AM, Emil Velikov > wrote: On 24 January 2018 at 15:30, George Kyriazis > wrote: LLVM 3.9 was not taken into in initial check-in. Fixes: 01ab218bbc

Re: [Mesa-dev] [PATCH 04/20] swr/rast: Initial work for debugging support.

Emil, I’m already working on it. Thanks! George > On Jan 23, 2018, at 10:04 AM, Emil Velikov wrote: > > Hi George, > > On 19 January 2018 at 21:46, George Kyriazis > wrote: >> Adds ability to step into jitted llvm IR in Visual Studio.

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

Chuck, Change verified on my end; check-in coming coming up soon. George On Jan 22, 2018, at 2:11 PM, Kyriazis, George <george.kyria...@intel.com<mailto:george.kyria...@intel.com>> wrote: On Jan 22, 2018, at 12:02 PM, Chuck Atkins <chuck.atk...@kitware.com<mailto:chuck.

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

On Jan 22, 2018, at 12:02 PM, Chuck Atkins > wrote: Hi Emil, Fixes: a4be2bcee2f ("swr: allow a single swr architecture to be builtin") It doesn't fix anything that was broken from that commit. The issues with error handling were

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

On Jan 18, 2018, at 1:10 PM, Roland Scheidegger > wrote: Am 17.01.2018 um 23:33 schrieb George Kyriazis: The texture swizzle was not doing the right thing for avx512-style 16-wide loads. Special-case the post-load swizzle operations for avx512 so

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

On Jan 18, 2018, at 1:10 PM, Roland Scheidegger > wrote: Am 17.01.2018 um 23:33 schrieb George Kyriazis: The texture swizzle was not doing the right thing for avx512-style 16-wide loads. Special-case the post-load swizzle operations for avx512 so

Re: [Mesa-dev] Mesa 18.0.0 release plan

Hello Emil, For the swr driver we are planning on getting some features in in the last couple of days, but one extra week will help us out. Specifically, we are thinking of checking in: - FE 16-wide shader support. This will entail calling lp_build_tgsi_soa() with width 16. Having some

Re: [Mesa-dev] [PATCH v2] swr: Correct texture allocation and limit max size to 2GB

Looks good. Reviewed-By: George Kyriazis > On Nov 30, 2017, at 11:51 AM, Bruce Cherniak > wrote: This patch fixes piglit tex3d-maxsize by correcting 4 things: The total_size

Re: [Mesa-dev] [PATCH v3] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

The problem that I’m seeing with timespec_get is that centos6 does not have it. I’ve put some changes out for review that actually remove timespec_get() in favor of using a variation of os_time_get_nano(). It’s good to always use the same time functions, and not have multiple ways of doing

Re: [Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

ortable it is. Of course, the most fool-proof solution would be a configure script check, but it could be redundant. George > On Nov 10, 2017, at 2:41 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > > On 10.11.2017 19:20, Kyriazis, George wrote: >

[Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

Hello Nicolai, Your commit e3a8013 (util/u_queue: add util_queue_fence_wait_timeout), breaks the centos6 build. Specifically, I am getting: CC libmesautil_la-u_queue.lo ../../../src/util/u_queue.c: In function '_util_queue_fence_wait_timeout': ../../../src/util/u_queue.c:173:7: error:

Re: [Mesa-dev] [PATCH] swr: Fixed an uncommon freed-memory access during state validation

Looks good.. Reviewed-By: George Kyriazis > On Nov 8, 2017, at 6:39 PM, Bruce Cherniak > wrote: State validation is performed during clear and draw calls. Validation during

Re: [Mesa-dev] Piglit on windows

> On Oct 10, 2017, at 1:23 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Kyriazis, George (2017-10-10 11:02:26) >> >>> On Oct 10, 2017, at 12:46 PM, Dylan Baker <dy...@pnwbakers.com> wrote: >>> >>> Quoting Jose Fonseca (2017-10

Re: [Mesa-dev] Piglit on windows

> On Oct 10, 2017, at 12:46 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Jose Fonseca (2017-10-10 08:41:49) >> On 10/10/17 16:31, Kyriazis, George wrote: >>> Hello… >>> >>> Piglit on windows prints out a message saying “Timeout are no

Re: [Mesa-dev] Piglit on windows

On Oct 10, 2017, at 10:41 AM, Jose Fonseca <jfons...@vmware.com<mailto:jfons...@vmware.com>> wrote: On 10/10/17 16:31, Kyriazis, George wrote: Hello… Piglit on windows prints out a message saying “Timeout are not implemented on Windows.”. These timeouts are the test timeouts in

[Mesa-dev] Piglit on windows

Hello… Piglit on windows prints out a message saying “Timeout are not implemented on Windows.”. These timeouts are the test timeouts in case a test hangs. What do people do when running piglit on windows and they hit a timeout? I would imagine there would be a non-zero number of people

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

Emil, I’m working with Trevor to upstream the correct versions of the swr patches. Thanks, George > On Oct 2, 2017, at 9:04 AM, Emil Velikov wrote: > > Hi Trevor, > > On 2 October 2017 at 13:48, Trevor Sandy wrote: >> Hi George, >> >> You

Re: [Mesa-dev] [PATCH 2/2] swr: Report format max_samples=1 to maintain support for "fake" msaa.

Discussed with Bruce. Reviewed-By: George Kyriazis > On Aug 31, 2017, at 11:09 PM, Brian Paul > wrote: I'm not familiar with this driver so I'll give this an Acked-by: Brian Paul

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

> On Jul 27, 2017, at 1:49 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > > On Thu, Jul 27, 2017 at 2:45 PM, Kyriazis, George > <george.kyria...@intel.com> wrote: >> >> On Jul 27, 2017, at 1:25 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

On Jul 27, 2017, at 1:25 PM, Ilia Mirkin > wrote: On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis > wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Jul 23, 2017, at 1:51 PM, Ilia Mirkin <imir...@alum.mit.edu<mailto:imir...@alum.mit.edu>> wrote: On Sun, Jul 23, 2017 at 12:27 PM, Kyriazis, George <george.kyria...@intel.com<mailto:george.kyria...@intel.com>> wrote: On Jul 23, 2017, at 11:21 AM, Ilia Mirki

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Jul 23, 2017, at 1:42 PM, Rowley, Timothy O > wrote: On Jul 23, 2017, at 11:08 AM, George Kyriazis > wrote: The shader that is used to copy vertex data out of the

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Jul 23, 2017, at 11:21 AM, Ilia Mirkin > wrote: On Sun, Jul 23, 2017 at 12:08 PM, George Kyriazis > wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the

Re: [Mesa-dev] [PATCH] swr: invalidate attachment on transition change

+Bruce Andres, VTK/Kitware has already modified their code to enable dual depth peeling for Mesa version >= 17.2. From that perspective, it doesn’t matter if the change goes into the 17.1.x releases or 17.2. Having said that, we haven’t seen any issues with that check-in, so if it makes it

Re: [Mesa-dev] [PATCH 02/11] mesa/glthread: remove HAVE_PTHREAD guards

I can verify that the fix works. Thank you! George > On Jun 26, 2017, at 3:24 PM, Marek Olšák <mar...@gmail.com> wrote: > > I just pushed the fix. > > Marek > > On Mon, Jun 26, 2017 at 10:01 PM, Kyriazis, George > <george.kyria...@intel.com> wrote: &g

Re: [Mesa-dev] [PATCH 02/11] mesa/glthread: remove HAVE_PTHREAD guards

Marek Our windows mesa build broke with your checkin: "mesa/glthread: remove HAVE_PTHREAD guards”. Namely: Compiling src\mesa\main\context.c ... context.c c:\users\gkyriazi\src\mesa\src\mesa\main\glthread.h(34): fatal error C1083: Cannot open include file: 'pthread.h': No such file or

Re: [Mesa-dev] [PATCH 2/2] swr: Fix polygonmode for front==back

I am perfectly fine not submitting into stable. And can remove the assert, since it’s causing trouble. FWIW, piglit llvmpipe.py fixes 3 tests with no regressions. George On Apr 25, 2017, at 9:23 PM, Rowley, Timothy O > wrote:

Re: [Mesa-dev] [PATCH 10/14] travis: add "scons swr" to the build matrix

As discussed, If you run scons with a small -j number, it would work (verified by Emil). With that change Reviewed-by: George Kyriazis > For the rest of the series, I don’t have enough experience with travis to review.. George On

Re: [Mesa-dev] [PATCH 10/14] travis: add "scons swr" to the build matrix

rasterizer.cpp takes a lot of resources to compile. Looks like the autotools build runs -j2, which limits the exposure, because of fewer parallel jobs, while scons, by default is more aggressive. Suggest running scons -j 1 or scons -j 2 for swr. Thanks, George > On Apr 21, 2017, at 7:08 AM,

Re: [Mesa-dev] [PATCH] swr: Fix swr osmesa build

Thanks Emil, I will attempt to un-meh a bit at checkin. George > On Apr 14, 2017, at 5:52 PM, Emil Velikov wrote: > > Commit summary is a bit meh, but regardless. > > Reviewed-by: Emil Velikov > > -Emil

Re: [Mesa-dev] [PATCH] swr: Enable MSAA in OpenSWR software renderer

Reviewed-by: George Kyriazis > With the assumption that there are additional changes forthcoming. On Apr 13, 2017, at 5:40 PM, Bruce Cherniak > wrote: This patch enables

Re: [Mesa-dev] [PATCH] swr: Add polygon stipple support

On Apr 14, 2017, at 11:35 AM, Ilia Mirkin > wrote: On Fri, Apr 14, 2017 at 11:18 AM, Ilia Mirkin > wrote: On Thu, Apr 13, 2017 at 4:30 PM, George Kyriazis

Re: [Mesa-dev] [PATCH] swr: add linux to scons build

On Apr 14, 2017, at 12:44 PM, Emil Velikov > wrote: On 13 April 2017 at 20:17, George Kyriazis > wrote: Make swr compile for both linux and windows. ---

Re: [Mesa-dev] [PATCH] docs: document the C++14 SWR requirement

On Apr 12, 2017, at 10:03 AM, Rowley, Timothy O > wrote: On Apr 12, 2017, at 9:11 AM, Emil Velikov > wrote: From: Emil Velikov

Re: [Mesa-dev] [PATCH v2 10/10] swr: [rasterizer codegen] Fix windows build

Tried Depends(), but it doesn’t work all the time. There are some cases where it works, and some others where it doesn’t. I’ll need to investigate more. Fix in a separate checkin later? George On Mar 27, 2017, at 8:38 PM, Rowley, Timothy O

Re: [Mesa-dev] [PATCH 01/10] swr: [rasterizer codegen] Refactor codegen

Apart from 01/10 and 10/10 (that have been discussed in other emails), patches 02/10 to 09/10 Reviewed-By: George Kyriazis > On Mar 25, 2017, at 7:00 AM, Tim Rowley >

Re: [Mesa-dev] [PATCH v2 01/10] swr: [rasterizer codegen] Refactor codegen

With this v2 change PATCH 10/10 has to be updated. V2 of 10/10 coming in a separate envelope. With the 10/10 update, this patch: Reviewed-By: George Kyriazis > George On Mar 27, 2017, at 11:17 AM, Tim Rowley

Re: [Mesa-dev] [PATCH v2 1/2] [util] add extern "C" guards

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, February 15, 2017 10:04 PM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev

Re: [Mesa-dev] [PATCH] [swr] fix windows build

You mean use extern "C" (inside a c++ guard) on u_upload_mgr.h and friends? Thanks, George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, February 15, 2017 4:25 PM > To: Kyria

Re: [Mesa-dev] [PATCH] [swr] fix index buffers with non-zero indices

Thanks, Good point. I'll send a new version our for review. George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, January 31, 2017 11:50 AM > To: Kyriazis, George <george.kyria...@intel.c

Re: [Mesa-dev] [PATCH] [swr] fix index buffers with non-zero indices

and index buffers, which is the case that this fixes). What do you think? Thanks, George > -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, January 31, 2017 11:17 AM > To: Kyriazis, George <george.kyria.

Re: [Mesa-dev] [PATCH 7/9] scons: swr: remove explicit __STDC_.*_MACROS defines

Signed-off: George Kyriazis <george.kyria...@intel.com> > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, January 26, 2017 7:24 AM > To: mesa-dev@lists.freedesktop.org > Cc: emil.l.veli...@gmail.com; Kyriazis, George <g

Re: [Mesa-dev] [PATCH] swr: Prune empty nodes in CalculateProcessorTopology.

Bruce, I think you have to add the cc: line in the message body, and not cc mesa-stable explicitly, as described in http://www.mesa3d.org/devinfo.html. I could be wrong, though. Otherwise, Reviewed-By: George Kyriazis Thanks, George > -Original Message-

Re: [Mesa-dev] [PATCH v3] swr: fix windows build break

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Wednesday, January 4, 2017 2:30 PM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Me

Re: [Mesa-dev] [PATCH v3] swr: fix windows build break

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Wednesday, January 4, 2017 2:22 PM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev]

Re: [Mesa-dev] [PATCH] swr: remove unneeded llvm version check

Reviewed-by: George Kyriazis George > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tim Rowley > Sent: Tuesday, January 3, 2017 10:25 AM > To: Cherniak, Bruce ; mesa- >

Re: [Mesa-dev] [PATCH] swr: Implement fence attached work queues for deferred deletion.

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Bruce Cherniak > Sent: Monday, December 12, 2016 7:25 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr:

Re: [Mesa-dev] [PATCH] swr: Templetize std::max to work on windows

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Tuesday, November 29, 2016 1:54 PM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev]

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

I'll retract this diff for now, then. George > -Original Message- > From: Jose Fonseca [mailto:jfons...@vmware.com] > Sent: Thursday, November 24, 2016 1:42 PM > To: Emil Velikov <emil.l.veli...@gmail.com>; Kyriazis, George > <george.kyria...@intel.com>

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 11:37 AM > To: Kyriazis, George <george.kyria...@intel.com>; Jose Fonseca > <jfons...@vmware.com&g

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

Thanks, I'll update the docs explaining the *-By: a bit better and send it out for review. George > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Wednesday, November 23, 2016 10:59 AM > To: K

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 10:02 AM > To: Ilia Mirkin <imir...@alum.mit.edu> > Cc: Kyriazis, George <george.kyria...

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

. George > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Monday, November 21, 2016 10:27 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PATCH

Re: [Mesa-dev] [PATCH v5 09/11] swr: Modify gen_knobs.{cpp|h} creation script

Thank you for the reviews, Emil. Tim will check-in the series, since he has check-in privileges. George > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Saturday, November 19, 2016 4:23 PM > To: Kyriazis, George <george.kyria...@inte

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Friday, November 18, 2016 5:24 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Thursday, November 17, 2016 11:12 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Thursday, November 17, 2016 11:12 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} creation script

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, November 17, 2016 11:22 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PATCH v

Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

3 PM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver > > On 10 November 2016 at 17:27, Kyriazis, George <george.kyria...@intel.com> > wrote:

Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, November 10, 2016 8:14 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PAT

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

Alright, I won't include that particular change in my v2 of the other changes that I have, then. Thanks! George > -Original Message- > From: Brian Paul [mailto:bri...@vmware.com] > Sent: Wednesday, November 9, 2016 4:03 PM > To: Kyriazis, George <george.kyria...@in

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

, George > -Original Message- > From: Marek Olšák [mailto:mar...@gmail.com] > Sent: Wednesday, November 9, 2016 3:31 PM > To: Brian Paul <bri...@vmware.com> > Cc: Kyriazis, George <george.kyria...@intel.com>; mesa- > d...@lists.freedesktop.org > Subject

Re: [Mesa-dev] [PATCH 1/3] gallium/scons: OpenSWR Windows support

> -Original Message- > From: Jose Fonseca [mailto:jfons...@vmware.com] > Sent: Tuesday, November 8, 2016 4:17 PM > To: Kyriazis, George <george.kyria...@intel.com>; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/scons: O

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

> -Original Message- > From: Jose Fonseca [mailto:jfons...@vmware.com] > Sent: Tuesday, November 8, 2016 4:12 PM > To: Kyriazis, George <george.kyria...@intel.com>; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc

Re: [Mesa-dev] [PATCH 3/3] swr: Support windows builds

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, November 8, 2016 10:54 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PATCH 3/

Re: [Mesa-dev] [PATCH 3/3] swr: Support windows builds

Comments inline.. > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, November 8, 2016 8:25 AM > To: Kyriazis, George <george.kyria...@intel.com> > Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> > Subject: Re: [Mesa

Re: [Mesa-dev] [PATCH 1/3] gallium/scons: OpenSWR Windows support

Thank you for the review. Comments inline. > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, November 8, 2016 7:52 AM > To: Kyriazis, George <george.kyria...@intel.com>; Jose Fonseca > <jfons...@vmware.com>

Re: [Mesa-dev] [PATCH] swr: Removed stalling SwrWaitForIdle from queries.

Reviewed-by: George Kyriazis > From: Bruce Cherniak > Subject: [PATCH] swr: Removed stalling SwrWaitForIdle from queries. Date: September 27, 2016 at 1:27:08 PM CDT To:

Re: [Mesa-dev] [PATCH] gallium: detect avx512 cpu features

All good, but I would suggest matching the already existing editing style (ie correct tabulation, and zero-padding of cpuid() args. Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf

Re: [Mesa-dev] [PATCH] swr: Add missing break in query switch statement.

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Monday, May 9, 2016 9:00 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: Add

Re: [Mesa-dev] [PATCH] swr: Remove stall waiting for core query counters.

Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Thursday, April 28, 2016 12:13 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr:

Re: [Mesa-dev] [PATCH v2] swr: fix memory leaks from vs/fs compilation

Reviewed by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tim Rowley > Sent: Wednesday, April 20, 2016 7:42 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH v2] swr: fix

Re: [Mesa-dev] [PATCH] swr: support samplers in vertex shaders

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: support

Re: [Mesa-dev] [PATCH] swr: handle pci cap requests

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tim Rowley > Sent: Friday, April 1, 2016 8:03 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: handle pci

Re: [Mesa-dev] [PATCH] gallium/swr: Resource management

Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Wednesday, March 9, 2016 7:30 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] gallium/swr: Resource management > >

Re: [Mesa-dev] [PATCH v3 2/2] Hang off screen destructor off main XCloseDisplay() callback.

n Paul [mailto:bri...@vmware.com] > Sent: Thursday, March 3, 2016 11:32 AM > To: Kyriazis, George <george.kyria...@intel.com>; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v3 2/2] Hang off screen destructor off main > XCloseDisplay() callback. > > On 03/

Re: [Mesa-dev] [PATCH v2] Support unlimited number of display connections

v-boun...@lists.freedesktop.org] On > Behalf Of Kyriazis, George > Sent: Wednesday, March 2, 2016 7:03 PM > To: Brian Paul <bri...@vmware.com>; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2] Support unlimited number of display > connections > > I am re-se

  1   2   >