Re: [Mesa-dev] [PATCH] anv/device: fix maximum number of images supported

On 11/01/2019 11:37, Eric Engestrom wrote: On Friday, 2019-01-11 10:58:38 +0100, Iago Toral Quiroga wrote: We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but anv_nir_apply_pipeline_layout runs for

Re: [Mesa-dev] [PATCH] anv/pipeline_cache: fix incorrect guards for NIR cache

nal intention, but I kind of prefer having all fields initialized. While looking at this patch, I noticed that we're not freeing nir_cache in anv_pipeline_cache_finish. This looks good : Reviewed-by: Lionel Landwerlin diff --git a/src/intel/vulkan/anv_pipeline_cache.c b/src/intel/vul

Re: [Mesa-dev] [PATCH] nir: fix warning in nir_lower_io.c

On 08/01/2019 17:33, Caio Marcelo de Oliveira Filho wrote: Add unreachable case for invalid deref type. Fixes the warning below In file included from ../src/compiler/nir/nir_lower_io.c:34: ../src/compiler/nir/nir_lower_io.c: In function ‘nir_lower_explicit_io’:

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

On 08/01/2019 11:11, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-01-08 11:03:26) Hi Andrii, Although I think what these patches do makes sense, I think it's missing the bigger picture. There is a lot more state that gets lost if we have to revert all of the emitted commands. A quick

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

Hi Andrii, Although I think what these patches do makes sense, I think it's missing the bigger picture. There is a lot more state that gets lost if we have to revert all of the emitted commands. A quick look at brw_upload_pipeline_state() shows all of the programs could be invalid as well, or

[Mesa-dev] [shaderdb 2/2] intel_stub: update stubbing logic for newer mesa

DRI2 backend of Mesa started relying more on libdrm to open DRM devices nodes and opening multiple fds on a single node. This change keeps track of up to 10 fds so that stub works again. Signed-off-by: Lionel Landwerlin --- intel_stub.c | 98

[Mesa-dev] [shaderdb 0/2] Intel fixes

We need a custom stub to run shaderdb and this was somewhat broken with newer versions of Mesa. Cheers, Lionel Landwerlin (2): run: fix uninitialized value intel_stub: update stubbing logic for newer mesa intel_stub.c | 98 +--- run.c

[Mesa-dev] [shaderdb 1/2] run: fix uninitialized value

Signed-off-by: Lionel Landwerlin --- run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.c b/run.c index 1e415c9..f3e65a3 100644 --- a/run.c +++ b/run.c @@ -837,7 +837,7 @@ main(int argc, char **argv) enum shader_type type; unsigned num_shaders

Re: [Mesa-dev] [PATCH 06/16] nir: improve convert_yuv_to_rgb when fuse_ffma=true

HW. On 12/19/18 12:34 PM, Lionel Landwerlin wrote: Hey Jonathan, I'm kind of curious as to whether we can have a single expression that pretty much generates the same final code (through some of the algebraic lowering/optimizations). I'll give it a try on Intel HW, see what it does

[Mesa-dev] MR: i965: fix VF cache issue workaround

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/62 A small series to fix an issue observed in Blender : https://bugs.freedesktop.org/show_bug.cgi?id=109072 Cheers, - Lionel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] MR: anv: fix clear color resolves

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/50 Hi all, We're having issues with clear color resolves when image views & images have different formats (for example image R8G8B8A8_UNORM & view R8G8B8A8_SRGB see https://bugs.freedesktop.org/show_bug.cgi?id=108911). Jason suggested we

[Mesa-dev] MR: Intel: aub viewer fixes

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/49 A small series of fixes & 2 small improvement for the aub viewer. Cheers, - Lionel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] MR: Intel: comprehensive aub generation from error state

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/48 Hi all, Error states generated by the i915 driver expose a lot of different buffers. This include context image, ring buffer as well as the user submitted buffers. This series updates the error2aub tool to generate a more comprehensive

Re: [Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

of storing an additional color field in the clear color information so that gets loaded into the blorp shader and then can apply some srgb conversion if needed. Thoughts? Thanks a lot, - Lionel On 21/12/2018 13:13, Lionel Landwerlin wrote: Looking at this, I think the issue is more

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

community won't be very surprised. And this patch is the call for people who haven't noticed yet. Acked-by: Lionel Landwerlin - Lionel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

Looking at this, I think the issue is more in anv_blorp.c. All of the mcs/ccs ops we're doing use the anv_image which can be a different format from the anv_image_view we're dealing with. In this particular bug, the image is R8G8B8A8_UNORM while the view is R8G8B8A8_SRGB. I think this might

[Mesa-dev] MR: anv: don't do partial resolve on layer > 0

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/40 A couple of bugs have been reported on multisampled & multilayered surfaces in Anv. After having found what I thought was a workaround, it turned out to be an actual fix. Please visit the URL above for a full explanation. I also

Re: [Mesa-dev] [PATCH 06/16] nir: improve convert_yuv_to_rgb when fuse_ffma=true

Hey Jonathan, I'm kind of curious as to whether we can have a single expression that pretty much generates the same final code (through some of the algebraic lowering/optimizations). I'll give it a try on Intel HW, see what it does. - Lionel On 19/12/2018 16:39, Jonathan Marek wrote: When

Re: [Mesa-dev] [PATCH v3] anv: support VkExternalFormatANDROID in vkCreateSamplerYcbcrConversion

rsion->mapping[1] = pCreateInfo->components.g; + conversion->mapping[2] = pCreateInfo->components.b; + conversion->mapping[3] = pCreateInfo->components.a; + } + if (!ext_format) With that fixed: Reviewed-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH v5] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

ILING_OPTIMAL); + I think you want to give tiling as a parameter, with that fixed : Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Bump the patch version to 96

Reviewed-by: Lionel Landwerlin On 17/12/2018 16:49, Jason Ekstrand wrote: --- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index b6269d0047a..a0bf4127002 100644

Re: [Mesa-dev] [PATCH 1/2] vulkan: Update the XML and headers to 1.1.96

Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Suggestions for improving meson-based builds

On 17/12/2018 12:04, Ilia Mirkin wrote: On Mon, Dec 17, 2018 at 6:59 AM Lionel Landwerlin wrote: On 17/12/2018 00:33, Jason Ekstrand wrote: On Sun, Dec 16, 2018 at 1:49 PM Ilia Mirkin wrote: 1. Build creation command recovery. With autotools, "head config.log" will tell y

Re: [Mesa-dev] Suggestions for improving meson-based builds

On 17/12/2018 00:33, Jason Ekstrand wrote: On Sun, Dec 16, 2018 at 1:49 PM Ilia Mirkin > wrote: 1. Build creation command recovery. With autotools, "head config.log" will tell you how you configured it. This is important when things get screwed up, and

Re: [Mesa-dev] [PATCH] nir: remove unused variable

Reviewed-by: Lionel Landwerlin On 13/12/2018 14:25, Alejandro Piñeiro wrote: To avoid the following warning: ./src/compiler/nir/nir_loop_analyze.c:807:16: warning: unused variable ‘ns’ [-Wunused-variable] nir_shader *ns = impl->function->shader; --- Perhaps this is solved

Re: [Mesa-dev] [PATCH] intel/blorp: Assert that we don't re-layout a compressed surface

Reviewed-by: Lionel Landwerlin On 12/12/2018 03:35, Jason Ekstrand wrote: ping On Thu, Apr 5, 2018 at 12:50 PM Jason Ekstrand <mailto:ja...@jlekstrand.net>> wrote: ---  src/intel/blorp/blorp_blit.c | 3 +++  1 file changed, 3 insertions(+) diff --git a/src/in

Re: [Mesa-dev] [PATCH 08/15] anv/android: support import/export of AHardwareBuffer objects

On 12/12/2018 08:34, Tapani Pälli wrote: On 12/11/18 3:05 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) v3: properly handle usage bits when creating from image v4: refactor, code cleanup (Jason) v5

Re: [Mesa-dev] [PATCH 15/15] anv/android: turn on VK_ANDROID_external_memory_android_hardware_buffer

On 27/11/2018 10:53, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_extensions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index 7c81228f705

Re: [Mesa-dev] [PATCH 14/15] anv: ignore VkSamplerYcbcrConversion on non-yuv formats

at->can_ycbcr)     break; If you add the paragraph from the commit message in this code path too, that would remind our future selves about this detail :) Thanks and with that changed : Reviewed-by: Lionel Landwerlin if (conversion == NULL) break; - s

Re: [Mesa-dev] [PATCH 02/15] anv: refactor make_surface to use data from anv_image

On 27/11/2018 10:53, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin I think Eric might be interested by this refactoring. --- src/intel/vulkan/anv_image.c | 78 ++ src/intel/vulkan/anv_private.h | 5 +++ 2 files

Re: [Mesa-dev] [PATCH 13/15] anv: support VkSamplerYcbcrConversionInfo in vkCreateImageView

On 27/11/2018 10:53, Tapani Pälli wrote: If a conversion struct was passed, then initialize view using format from the conversion structure. v2: use vk_format directly from the anv_format struct Signed-off-by: Tapani Pälli One suggestion : Reviewed-by: Lionel Landwerlin --- src

Re: [Mesa-dev] [PATCH 11/15] anv: support VkExternalFormatANDROID in vkCreateSamplerYcbcrConversion

On 27/11/2018 10:53, Tapani Pälli wrote: If external format is used, we store the external format identifier in conversion to be used later when creating VkImageView. v2: rebase to b43f955037c changes Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_formats.c | 13 + 1 file

Re: [Mesa-dev] [PATCH 10/15] anv/android: support creating images from external format

prepare_ahw_image, support vkBindImageMemory2, calculate stride correctly for rgb(x) surfaces, rename as 'resolve_ahw_image' v4: rebase to b43f955037c changes Signed-off-by: Tapani Pälli Another couple of suggestions belower, otherwise : Reviewed-by: Lionel Landwerlin --- src/intel

Re: [Mesa-dev] [PATCH 03/15] anv: make anv_get_image_format_features public

On 27/11/2018 10:53, Tapani Pälli wrote: This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID. Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c | 22 +++--- src/intel/vulkan/anv_private.h | 5 + 2

Re: [Mesa-dev] [PATCH 01/15] anv: add create_flags as part of anv_image

On 27/11/2018 10:53, Tapani Pälli wrote: This will make it possible for next patch to rip anv_image_create_info out from make_surface function. Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_image.c | 1 + src/intel/vulkan/anv_private.h | 1

Re: [Mesa-dev] [PATCH 08/15] anv/android: support import/export of AHardwareBuffer objects

-off-by: Tapani Pälli Just a couple of suggestions below, otherwise : Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_android.c | 123 +++ src/intel/vulkan/anv_android.h | 10 +++ src/intel/vulkan/anv_android_stubs.c | 16 src/intel

Re: [Mesa-dev] [PATCH 12/15] anv: add VkFormat field as part of anv_format

On 27/11/2018 10:53, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c | 4 src/intel/vulkan/anv_private.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan

Re: [Mesa-dev] [PATCH 05/15] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On 27/11/2018 10:53, Tapani Pälli wrote: + const native_handle_t *handle = + AHardwareBuffer_getNativeHandle(buffer); + int dma_buf = (handle && handle->numFds) ? handle->data[0] : -1; + if (dma_buf < 0) + return VK_ERROR_INVALID_EXTERNAL_HANDLE_KHR; + Actually, maybe

Re: [Mesa-dev] [PATCH 06/15] anv: add anv_ahw_usage_from_vk_usage helper function

On 27/11/2018 10:53, Tapani Pälli wrote: v2: rebase to b43f955037c changes Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_android.c | 31 src/intel/vulkan/anv_android.h | 2 ++ src/intel/vulkan

Re: [Mesa-dev] [PATCH 04/15] anv: add from/to helpers with android and vulkan formats

On 11/12/2018 11:32, Tapani Pälli wrote: On 12/11/18 12:56 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason) v3: add HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL, we make it define for now to avoid direct dependency to minigbm

Re: [Mesa-dev] [PATCH 09/15] anv/android: add ahardwarebuffer external memory properties

Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index aa2093f7f15..972a6f98620 100644 --- a/src/intel/vulkan/anv_formats.c

Re: [Mesa-dev] [PATCH 07/15] anv: refactor, remove else block in AllocateMemory

On 27/11/2018 10:53, Tapani Pälli wrote: This makes it cleaner to introduce more cases where we import memory from different types of external memory buffers. Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 64

Re: [Mesa-dev] [PATCH 05/15] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On 27/11/2018 10:53, Tapani Pälli wrote: Use the anv_format address in formats table as implementation-defined external format identifier for now. When adding YUV format support this might need to change. v2: code cleanup (Jason) v3: set anv_format address as identifier v4: setup

Re: [Mesa-dev] [PATCH 04/15] anv: add from/to helpers with android and vulkan formats

On 27/11/2018 10:53, Tapani Pälli wrote: v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason) v3: add HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL, we make it define for now to avoid direct dependency to minigbm headers Signed-off-by: Tapani Pälli --- src/intel/vulkan/vk_format_info.h | 50

Re: [Mesa-dev] [PATCH] anv,radv: Disable VK_EXT_pci_bus_info

update ships. The one known use of this extension is internal to mesa and will continue working with the extension disabled and will naturally update when we get a new header. Cc: "18.3" Acked-by: Lionel Landwerlin --- src/amd/vulkan/radv_extensions.py | 2 +- src/in

Re: [Mesa-dev] [PATCH] i965: Flip arguments to load_register_reg helpers.

Rb On 08/12/2018 00:32, Kenneth Graunke wrote: load_register_imm and load_register_mem take the destination as the first argument, so I'd like load_register_reg to do the same the sake of consistency. Otherwise, reading sequences of mixed LRI/LRM/LRR is needlessly confusing. ---

Re: [Mesa-dev] [PATCH] intel/aubinator_error_decode: Get rid of warning for missing switch case

On 04/12/2018 14:08, Toni Lönnberg wrote: On Tue, Dec 04, 2018 at 01:41:37PM +, Eric Engestrom wrote: On Tuesday, 2018-12-04 14:14:51 +0200, Toni Lönnberg wrote: ../src/intel/tools/aubinator_error_decode.c: In function ‘instdone_register_for_ring’:

Re: [Mesa-dev] [PATCH mesa] anv: add unreachable() for VK_EXT_fragment_density_map

On 04/12/2018 13:42, Eric Engestrom wrote: This silences the -Wswitch compiler warning. Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan

Re: [Mesa-dev] [PATCH] intel/aubinator_error_decode: Get rid of warning for missing switch case

Reviewed-by: Lionel Landwerlin Will push shortly, thanks. On 04/12/2018 12:14, Toni Lönnberg wrote: ../src/intel/tools/aubinator_error_decode.c: In function ‘instdone_register_for_ring’: ../src/intel/tools/aubinator_error_decode.c:177:4: warning: enumeration value ‘I915_ENGINE_CLASS_INVALID

Re: [Mesa-dev] [PATCH] anv/query: flush render target before copying results

On 03/12/2018 22:08, Jason Ekstrand wrote: On Mon, Dec 3, 2018 at 11:26 AM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: This change tracks render target writes in the pipeline and applies a render target flush before copying the query results to mak

[Mesa-dev] [PATCH] anv: don't do partial resolve on layer > 0

We've made the choice not to use fast clears on layer > 0 with multilayer images, so when transitioning those images, don't bother doing a partial resolve on them. Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108910 Bugzilla: ht

[Mesa-dev] [PATCH] anv/query: flush render target before copying results

This change tracks render target writes in the pipeline and applies a render target flush before copying the query results to make sure the preceding operations have landed in memory before the command streamer initiates the copy. Signed-off-by: Lionel Landwerlin Bugzilla: https

Re: [Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

was fixed. ( Eric Engestrom ) Signed-off-by: Andrii Simiklit With the nit below : Reviewed-by: Lionel Landwerlin --- src/intel/tools/i965_disasm.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/intel/tools/i965_disasm.c b/src/intel/tools

Re: [Mesa-dev] [PATCH v2] anv: flush pipeline before query result copies

On 29/11/2018 16:58, Jason Ekstrand wrote: On Thu, Nov 29, 2018 at 10:45 AM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Pipeline barriers inserted through vkCmdPipelineBarrier() should be taken into account when copying results. In the particular bug

[Mesa-dev] [PATCH v2] anv: flush pipeline before query result copies

we copy the buffers using the 3D pipeline whereas we copy the query results using the command streamer. Those work in parallel unless synchronized. v2: Unconditionally flush the pipeline before copying the results (Jason) Signed-off-by: Lionel Landwerlin Suggested-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On 29/11/2018 16:15, Jason Ekstrand wrote: On Thu, Nov 29, 2018 at 9:52 AM Józef Kucia <mailto:joseph.ku...@gmail.com>> wrote: On Thu, Nov 29, 2018 at 4:43 PM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: > > Pipeline barr

[Mesa-dev] [PATCH] anv: flush pipeline before query result copies

we copy the buffers using the 3D pipeline whereas we copy the query results using the command streamer. Those work in parallel unless synchronized. Signed-off-by: Lionel Landwerlin Suggested-by: Jason Ekstrand Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108894 Cc: mesa-sta

Re: [Mesa-dev] [PATCH] nir: Fix assert in print_intrinsic_instr().

On 26/11/2018 15:04, Józef Kucia wrote: Signed-off-by: Józef Kucia Reviewed-by: Lionel Landwerlin --- src/compiler/nir/nir_print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index e20c28fec874

Re: [Mesa-dev] [PATCH mesa] anv: correctly use vulkan 1.0 by default

"anv: Copy the appliation info into the instance" Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index

Re: [Mesa-dev] [PATCH 2/5] anv/pipeline: Hash shader modules and spec constants separately

On 13/10/2018 01:08, Jason Ekstrand wrote: The stuff hashed by anv_pipeline_hash_shader is exactly the inputs to anv_shader_compile_to_nir so it can be used for NIR caching. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline.c | 54 - 1

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Cache the pre-lowered NIR

especially if it only happens once for several misses and it simplifies the cache. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline.c | 49 ++--- 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src

Re: [Mesa-dev] [PATCH 4/5] anv/pipeline_cache: Add support for caching NIR

On 13/10/2018 01:08, Jason Ekstrand wrote: Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline_cache.c | 100 ++ src/intel/vulkan/anv_private.h| 18 + 2 files changed, 118 insertions(+) diff --git a/src/intel/vulkan/anv_pipeline_cache.c

Re: [Mesa-dev] [PATCH 1/5] anv/pipeline: Move wpos and input attachment lowering to lower_nir

On 13/10/2018 01:08, Jason Ekstrand wrote: This lets us make anv_pipeline_compile_to_nir take a device instead of a pipeline. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH 3/5] compiler/types: Serialize/deserialize subpass input types correctly

On 13/10/2018 01:08, Jason Ekstrand wrote: They have glsl_sampler_dim enum values of 8 and 9 which don't work when you & them with 0x7. Fortunately, we have plenty of bits. I think this needs a Cc stable right? Reviewed-by: Lionel Landwerlin --- src/compiler/glsl_types.cpp

Re: [Mesa-dev] [PATCH 01/21] intel/defines: Explicitly cast to uint32_t in SET_FIELD and SET_BITS

delete it for us. I would use BITFIELD_BIT, but not a big deal. Reviewed-by: Lionel Landwerlin --- src/intel/compiler/brw_eu_defines.h | 4 ++-- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/compiler

Re: [Mesa-dev] [PATCH] i915: Delete swizzling detection logic.

Reviewed-by:  Lionel Landwerlin On 17/11/2018 09:24, Kenneth Graunke wrote: This is all leftover from the i965 split. --- src/mesa/drivers/dri/i915/intel_context.c | 2 -- src/mesa/drivers/dri/i915/intel_context.h | 1 - src/mesa/drivers/dri/i915/intel_screen.c | 26

Re: [Mesa-dev] [PATCH 5/5] intel/aub_viewer: Print blend states properly

Thanks Toni, pushing the whole lot :) On 16/11/2018 11:35, Toni Lönnberg wrote: Reviewed-by: Toni Lönnberg On Fri, Nov 09, 2018 at 04:49:13PM +, Lionel Landwerlin wrote: Identical fix to : commit 70de31d0c106f58d6b7e6d5b79b8d90c1c112a3b Author: Jason Ekstrand Date: Fri Aug 24 16:05

Re: [Mesa-dev] [PATCH] egl/dri: fix error value with unknown drm format

On 14/11/2018 11:04, Eric Engestrom wrote: On Tuesday, 2018-11-13 14:10:45 +, Lionel Landwerlin wrote: According to the EGL_EXT_image_dma_buf_import spec, creating an EGL image with a DRM format not supported should yield the BAD_MATCH error : " * If is EGL_LINUX_DMA_BU

Re: [Mesa-dev] [PATCH 06/13] anv: move helper function internally

Thanks, pushed 1-6 for now. On 08/11/2018 22:42, Jason Ekstrand wrote: I left a nit on 3.  Otherwise, 1-6 are Reviewed-by: Jason Ekstrand <mailto:ja...@jlekstrand.net>> On Mon, Nov 5, 2018 at 9:36 AM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote:

Re: [Mesa-dev] [PATCH] egl/dri: fix error value with unknown drm format

On 13/11/2018 15:43, Emil Velikov wrote: On Tue, 13 Nov 2018 at 14:11, Lionel Landwerlin wrote: According to the EGL_EXT_image_dma_buf_import spec, creating an EGL image with a DRM format not supported should yield the BAD_MATCH error : " * If is EGL_LINUX_DMA_BU

[Mesa-dev] [PATCH] egl/dri: fix error value with unknown drm format

MATCH is generated. " Signed-off-by: Lionel Landwerlin Fixes: 20de7f9f226401 ("egl/dri2: support for creating images out of dma buffers") --- src/egl/drivers/dri2/egl_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/

Re: [Mesa-dev] [PATCH v2 3/4] dri: add AYUV format

On 13/11/2018 12:04, Tapani Pälli wrote: On 11/13/18 1:43 PM, Lionel Landwerlin wrote: I think this chunk (or the whole patch) should be cherry picked to stable. Otherwise we get a BAD_ATTRIBUTE error for trying to create an AYUV EGLImage. We should have BAD_MATCH instead. Or should we

Re: [Mesa-dev] [PATCH v2 3/4] dri: add AYUV format

I think this chunk (or the whole patch) should be cherry picked to stable. Otherwise we get a BAD_ATTRIBUTE error for trying to create an AYUV EGLImage. We should have BAD_MATCH instead. - Lionel On 09/11/2018 10:55, Lionel Landwerlin wrote: diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src

Re: [Mesa-dev] [PATCH v3] intel/decoder: tools: Use engine for decoding batch instructions

I forgot that aubinator_viewer_decoder.cpp needs to be updated too. But updated locally and will push with the fix. Thanks! - Lionel On 08/11/2018 10:36, Lionel Landwerlin wrote: Reviewed-by: Lionel Landwerlin On 07/11/2018 14:50, Toni Lönnberg wrote: The engine to which the batch was sent

Re: [Mesa-dev] [PATCH v4 01/10] intel/genxml: Add engine definition to render engine instructions (gen4)

For all the xml changes : Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/5] intel/aubinator: fix ring buffer pointer

We can only start parsing commands from the head pointer. This was working fine up to now because we only dealt with a "made up" ring buffer (generated by aub_write) which always had its head at 0. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 ++--

[Mesa-dev] [PATCH 1/5] intel/aub_read: remove useless breaks

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_read.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/intel/tools/aub_read.c b/src/intel/tools/aub_read.c index d83e88ddced..cde6cb4ba03 100644 --- a/src/intel/tools/aub_read.c +++ b/src/intel/tools/aub_read.c @@ -219,27

[Mesa-dev] [PATCH 2/5] intel/decoders: read ring buffer length

Use this value to limit reading the ring buffer. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 +++- src/intel/tools/aubinator_viewer.cpp | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools

[Mesa-dev] [PATCH 4/5] intel/aub_viewer: fix dynamic state printing

Identical fix to : commit cbd4bc1346f7397242e157bb66099b950a8c5643 Author: Jason Ekstrand Date: Fri Aug 24 16:04:03 2018 -0500 intel/batch_decoder: Fix dynamic state printing Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer_decoder.cpp | 4 ++-- 1 file changed, 2

[Mesa-dev] [PATCH 5/5] intel/aub_viewer: Print blend states properly

Identical fix to : commit 70de31d0c106f58d6b7e6d5b79b8d90c1c112a3b Author: Jason Ekstrand Date: Fri Aug 24 16:05:08 2018 -0500 intel/batch_decoder: Print blend states properly Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer_decoder.cpp | 18 -- 1

[Mesa-dev] [PATCH 0/5] intel/aubinators: fixes

Hi all, Here are a few cleanups/fixes I have in a pretty long branch. I figured this would be easier to review on its own. Thanks for your time, Lionel Landwerlin (5): intel/aub_read: remove useless breaks intel/decoders: read ring buffer length intel/aubinator: fix ring buffer pointer

[Mesa-dev] [PATCH v2 3/4] dri: add AYUV format

v2: Add a AYUV entry android in the android backend (Tapani) Signed-off-by: Lionel Landwerlin Reviewed-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 2 ++ src/egl/drivers/dri2/egl_dri2.c | 1 + src/egl/drivers/dri2/platform_android.c | 1 + 3 files changed, 4

[Mesa-dev] [PATCH v2 2/4] nir/lower_tex: Add AYUV lowering support

Byte ordering is : 0: V 1: U 2: Y 3: A v2: Split refactoring of alpha channel (Lionel) Signed-off-by: Lionel Landwerlin Reviewed-by: Tapani Pälli --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_tex.c | 19 +++ 2 files changed, 20 insertions(+) diff

[Mesa-dev] [PATCH v2 0/4] i965: add support for sampling from AYUV images

Hi all, This v2 just splits the nir commit in 2 for readability and adds an entry into the android backend. Many thanks to Tapani for the review. Cheers, Lionel Landwerlin (4): nir/lower_tex: add alpha channel parameter for yuv lowering nir/lower_tex: Add AYUV lowering support dri: add

[Mesa-dev] [PATCH v2 4/4] i965: add support for sampling from AYUV

Signed-off-by: Lionel Landwerlin Reviewed-by: Tapani Pälli --- src/intel/compiler/brw_compiler.h| 1 + src/intel/compiler/brw_nir.c | 1 + src/mesa/drivers/dri/i965/brw_wm.c | 6 ++ src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 4 files changed, 11 insertions

[Mesa-dev] [PATCH v2 1/4] nir/lower_tex: add alpha channel parameter for yuv lowering

We're about to introduce AYUV support which provides its own alpha channel. So give alpha as a parameter and set it to 1 on exising formats. Signed-off-by: Lionel Landwerlin --- src/compiler/nir/nir_lower_tex.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] dri: add AYUV format

Signed-off-by: Lionel Landwerlin --- include/GL/internal/dri_interface.h | 2 ++ src/egl/drivers/dri2/egl_dri2.c | 1 + 2 files changed, 3 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 6f9c2c8b8cf..072f3799eac 100644

[Mesa-dev] [PATCH 3/3] i965: add support for sampling from AYUV

Signed-off-by: Lionel Landwerlin --- src/intel/compiler/brw_compiler.h| 1 + src/intel/compiler/brw_nir.c | 1 + src/mesa/drivers/dri/i965/brw_wm.c | 6 ++ src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 4 files changed, 11 insertions(+) diff --git a/src/intel

[Mesa-dev] [PATCH 1/3] nir/lower_tex: Add AYUV lowering support

Signed-off-by: Lionel Landwerlin --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_tex.c | 36 ++-- 2 files changed, 31 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f4f6b106505..2a843de8ae1

[Mesa-dev] [PATCH 0/3] i965: add support for sampling from AYUV images

Hi all, This series is a copycat of what Johnson Lin did to add UYVY support a while ago, only this time adding AYUV. Hopefully I didn't get the byte ordering as I had to write the piglit tests for it too :) https://patchwork.freedesktop.org/series/52254/ Cheers, Lionel Landwerlin (3): nir

Re: [Mesa-dev] [PATCH v3 02/10] intel/genxml: Add engine definition to render engine instructions (gen45)

On 08/11/2018 13:38, Toni Lönnberg wrote: Will post v4 as a series instead of replying to these ones if that's ok with you. That would great, thank you. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v3 02/10] intel/genxml: Add engine definition to render engine instructions (gen45)

On 08/11/2018 13:06, Toni Lönnberg wrote: On Thu, Nov 08, 2018 at 10:47:20AM +, Lionel Landwerlin wrote: Missing tag on : CS_URB_STATE CONSTANT_BUFFER MI_FLUSH URB_FENCE XY_COLOR_BLT XY_SETUP_BLT XY_SRC_COPY_BLT XY_TEXT_IMMEDIATE_BLT

Re: [Mesa-dev] [PATCH v4] intel/decoder: tools: gen_engine to drm_i915_gem_engine_class

Thanks a lot, Reviewed-by: Lionel Landwerlin On 08/11/2018 12:41, Toni Lönnberg wrote: Removed the gen_engine enum and changed the involved functions to use the drm_i915_gem_engine_class enum from UAPI instead. v3: Wrong engine was being used for blocks in video ring v4: Fixed

Re: [Mesa-dev] [PATCH] intel/l3: update ICL L3 configurations

I forgot to Cc some people :) On 07/11/2018 13:31, Lionel Landwerlin wrote: CNL configurations where given in increments of 2Kb, while ICL are given in increments of 4Kb. We seem to have missed some updates in the internal documentation. Signed-off-by: Lionel Landwerlin BSpec: 21166 --- src

Re: [Mesa-dev] [PATCH v3 10/10] intel/genxml: Add engine definition to render engine instructions (gen11)

Same as Gen9 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 09/10] intel/genxml: Add engine definition to render engine instructions (gen10)

Probably same as Gen9 :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 08/10] intel/genxml: Add engine definition to render engine instructions (gen9)

Missing render : MI_LOAD_URB_MEM MI_RS_CONTEXT MI_RS_CONTROL MI_RS_STORE_DATA_IMM MI_URB_ATOMIC_ALLOC MI_TOPOLOGY_FILTER Render & blitter : MI_DISPLAY_FLIP ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v3 07/10] intel/genxml: Add engine definition to render engine instructions (gen8)

Missing render : MI_TOPOLOGY_FILTER MI_URB_CLEAR SWTESS_BASE_ADDRESS MI_RS_STORE_DATA_IMM MI_RS_CONTROL MI_RS_CONTEXT MI_LOAD_URB_MEM MI_STORE_URB_MEM ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v3 06/10] intel/genxml: Add engine definition to render engine instructions (gen75)

Missing render engine : SWTESS_BASE_ADDRESS MI_RS_CONTEXT MI_RS_CONTROL MI_RS_STORE_DATA_IMM ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 05/10] intel/genxml: Add engine definition to render engine instructions (gen7)

Just SWTESS_BASE_ADDRESS missing render engine ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

<    1   2   3   4   5   6   7   8   9   10   >