Re: [Mesa-dev] [PATCH] EGL/android: Enhance pbuffer implementation

Hi, On Fri, Nov 25, 2016 at 12:58 PM, Liu Zhiquan wrote: > Some dri drivers will pass multiple bits in buffer_mask parameter > to droid_image_get_buffer(), more than the actual supported buffer > type combination. For such case, will go through all the bits, and > will not

Re: [Mesa-dev] [PATCH] EGL/android: Enhance pbuffer implementation

On Mon, Nov 28, 2016 at 10:35 PM, Emil Velikov wrote: > On 25 November 2016 at 03:58, Liu Zhiquan wrote: >> Some dri drivers will pass multiple bits in buffer_mask parameter >> to droid_image_get_buffer(), more than the actual supported buffer >>

Re: [Mesa-dev] EGL/android: pbuffer implementation.

tion above, looking forward, thanks. P.S. Please avoid top-posting on mailing lists, it really messes up the messages. Best regards, Tomasz > > Best regards, > Zhifang Long > > >> -Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: T

Re: [Mesa-dev] EGL/android: pbuffer implementation.

On Thu, Nov 24, 2016 at 12:00 PM, Tomasz Figa <tf...@chromium.org> wrote: > Hi Zhifang, > > On Thu, Nov 24, 2016 at 11:39 AM, Long, Zhifang <zhifang.l...@intel.com> > wrote: >>> >> > @@ -353,6 +353,18 @@ droid_destroy_surface(_EGLDriver *drv, &

Re: [Mesa-dev] EGL/android: pbuffer implementation.

Hi Zhifang, On Thu, Nov 24, 2016 at 11:39 AM, Long, Zhifang wrote: >> >> > @@ -353,6 +353,18 @@ droid_destroy_surface(_EGLDriver *drv, >> >> _EGLDisplay *disp, _EGLSurface *surf) >> >> >dri2_surf->window->common.decRef(_surf->window- >> >common); >> >> > } >>

Re: [Mesa-dev] EGL/android: pbuffer implementation.

On Tue, Nov 22, 2016 at 3:15 PM, Liu, Zhiquan wrote: > Hi Tomasz, > > Thanks for you commends. >> > >> >> Looks like this patch has already landed, but please let me try to >> confirm some things here anyway. Would you mind keeping me on CC for >> any future patches for the

Re: [Mesa-dev] EGL/android: pbuffer implementation.

On Tue, Nov 22, 2016 at 2:44 PM, Tapani Pälli <tapani.pa...@intel.com> wrote: > > > On 11/21/2016 04:15 PM, Emil Velikov wrote: >> >> On 21 November 2016 at 07:23, Tomasz Figa <tf...@chromium.org> wrote: >>> >>> Hi, >>> >>>

Re: [Mesa-dev] EGL/android: pbuffer implementation.

On Mon, Nov 21, 2016 at 11:15 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 21 November 2016 at 07:23, Tomasz Figa <tf...@chromium.org> wrote: >> Hi, >> >> On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan <zhiquan@intel.com> wrote: >>>

Re: [Mesa-dev] [PATCH v2 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats (v2)

On Mon, Nov 21, 2016 at 10:39 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 21 November 2016 at 06:50, Tomasz Figa <tf...@chromium.org> wrote: >> On Thu, Nov 10, 2016 at 5:48 PM, Tapani Pälli <tapani.pa...@intel.com> wrote: >>> >>>

Re: [Mesa-dev] EGL/android: pbuffer implementation.

Hi, On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan wrote: > mesa android path didn't support pbuffer, so add pbuffer support to > fix most deqp and cts pbuffer test cases fail; > add single buffer config to support pbuffer, and create image for > pbuffer when pbuffer type

Re: [Mesa-dev] [PATCH v2 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats (v2)

On Thu, Nov 10, 2016 at 5:48 PM, Tapani Pälli <tapani.pa...@intel.com> wrote: > > > On 11/10/2016 09:55 AM, Tomasz Figa wrote: >> >> There is an interface that can be used to query YUV buffers for their >> internal format. Specifically, if gralloc:lock_ycbcr() is

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 9 November 2016 at 08:32, Tomasz Figa <tf...@chromium.org> wrote: >> It is currently completely broken, as it ends up using RGBX_ on >> hardware side, due to no way of disti

Re: [Mesa-dev] [PATCH v2 1/2] egl/android: Get gralloc module in dri2_initialize_android() (v2)

On Thu, Nov 10, 2016 at 4:55 PM, Tomasz Figa <tf...@chromium.org> wrote: > Currently droid_open_device() gets a reference to the gralloc module > only for its own use and does not store it anywhere. To make it possible > to call gralloc methods from code added in further patches, l

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

On Thu, Nov 10, 2016 at 11:42 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Wed, Nov 9, 2016 at 11:23 PM, Tomasz Figa <tf...@chromium.org> wrote: >> On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> On

[Mesa-dev] [PATCH v2 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats (v2)

. v2: Fixes from Emil's review: a) Added comments for parts that might be not clear, b) Changed get_fourcc_yuv() to return -1 on failure, c) Changed is_yuv() to use bool. Signed-off-by: Tomasz Figa <tf...@chromium.org> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- src

[Mesa-dev] [PATCH v2 0/2] egl/android: Support YUV formats in a gralloc-agnostic way

, which allows handling of flexible YUV formats and querying the fixed YV12 for plane parameters. Tomasz Figa (2): egl/android: Get gralloc module in dri2_initialize_android() (v2) egl/android: Use gralloc::lock_ycbcr for resolving YUV formats (v2) src/egl/drivers/dri2/egl_dri2.h | 4

[Mesa-dev] [PATCH v2 1/2] egl/android: Get gralloc module in dri2_initialize_android() (v2)

it in dri2_dpy. v2: fixes from Emil's review: a) remove duplicate initialization of 'err'. Signed-off-by: Tomasz Figa <tf...@chromium.org> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- src/egl/drivers/dri2/egl_dri2.h | 4 src/egl/drivers/dri2/platform_an

Re: [Mesa-dev] [PATCH 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats

On Thu, Nov 10, 2016 at 1:50 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Thu, Nov 10, 2016 at 5:14 AM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 9 November 2016 at 08:33, Tomasz Figa <tf...@chromium.org> wrote: >>> There is an interfac

Re: [Mesa-dev] [PATCH 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats

On Thu, Nov 10, 2016 at 5:14 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 9 November 2016 at 08:33, Tomasz Figa <tf...@chromium.org> wrote: >> There is an interface that can be used to query YUV buffers for their >> internal format. Specifically, if gralloc:

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 9 November 2016 at 08:32, Tomasz Figa <tf...@chromium.org> wrote: >> It is currently completely broken, as it ends up using RGBX_ on >> hardware side, due to no way of disti

[Mesa-dev] [PATCH 0/2] egl/android: Support YUV formats in a gralloc-agnostic way

, which allows handling of flexible YUV formats and querying the fixed YV12 for plane parameters. Tomasz Figa (2): egl/android: Get gralloc module in dri2_initialize_android() egl/android: Use gralloc::lock_ycbcr for resolving YUV formats src/egl/drivers/dri2/egl_dri2.h | 4 + src/egl

[Mesa-dev] [PATCH 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats

. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 146 ++-- 1 file changed, 120 insertions(+), 26 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 0

[Mesa-dev] [PATCH 1/2] egl/android: Get gralloc module in dri2_initialize_android()

it in dri2_dpy. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/egl_dri2.h | 4 src/egl/drivers/dri2/platform_android.c | 28 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.h b/s

[Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

It is currently completely broken, as it ends up using RGBX_ on hardware side, due to no way of distinguishing between these two in the DRI API, while HAL_PIXEL_FORMAT_RGB_888 is clearly defined to be the 3-byte per pixel RGB format. Signed-off-by: Tomasz Figa <tf...@chromium.org> --

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On Fri, Oct 28, 2016 at 11:33 PM, Rob Herring wrote: > On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov > wrote: >> On 28 October 2016 at 13:22, Rob Clark wrote: >>> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix glFramebufferTexture* error codes (v2)

; On 10/11/2016 09:29 AM, Tomasz Figa wrote: > >> [Fixing CC list.] >> >> Ping. Would appreciate someone taking a look at this. Thanks in advance! >> >> On Fri, Aug 26, 2016 at 2:57 AM, Chad Versace <chadvers...@chromium.org >> <mailto:chadvers...@chromium.or

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix glFramebufferTexture* error codes (v2)

[Fixing CC list.] Ping. Would appreciate someone taking a look at this. Thanks in advance! On Fri, Aug 26, 2016 at 2:57 AM, Chad Versace wrote: > Bump. > > On Thu 11 Aug 2016, Chad Versace wrote: > > If check_textarget() determined that textarget was incorrect, it

Re: [Mesa-dev] [PATCH 0/4] Resolving Android + desktop OpenGL 'hack'

On Sat, Aug 27, 2016 at 4:12 AM, Ilia Mirkin wrote: > On Fri, Aug 26, 2016 at 3:01 PM, Ryan Houdek wrote: >> Most of the Tegra devices (K1 and above) provide desktop GL, except for the >> Nexus devices which cut out that functionality. >> Not sure

Re: [Mesa-dev] [PATCH 0/4] Resolving Android + desktop OpenGL 'hack'

rstanding it generally provides only a back buffer to the producer. What are the specific features that Dolphin relies on? Are they missing even on newer versions of OpenGL ES (3.0/3.1)? Best regards, Tomasz > > On Thu, Aug 25, 2016 at 4:47 PM, Tomasz Figa <tf...@chromium.org> wrote: >&g

Re: [Mesa-dev] [PATCH 0/4] Resolving Android + desktop OpenGL 'hack'

_mesa.so > (which is essentially libEGL.so with a fancy name). > > Tomasz, is desktop OpenGL a thing for ARC ? Can you check with > someone from the team(s) on the above. AFAIK nothing in Android really cares about desktop OpenGL. For the complete series: Reviewe

Re: [Mesa-dev] [PATCH v2 0/4] gallium/winsys/kms: Fix issues with prime import

Hi Emil, On Wed, Aug 24, 2016 at 10:41 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Tomasz, > > On 2 August 2016 at 11:46, Tomasz Figa <tf...@chromium.org> wrote: >> Current prime import code in kms-dri Gallium winsys backend has several >> issues

Re: [Mesa-dev] [PATCH v2 3/4] gallium/winsys/kms: Move display target handle lookup to separate function (v2)

On Fri, Aug 12, 2016 at 8:03 AM, Jordan Justen <jordan.l.jus...@intel.com> wrote: > On 2016-08-08 01:55:18, Tomasz Figa wrote: >>On Fri, Aug 5, 2016 at 2:37 AM, Jordan Justen <jordan.l.jus...@intel.com> >>wrote: >> >> On

Re: [Mesa-dev] [PATCH v2 3/4] gallium/winsys/kms: Move display target handle lookup to separate function (v2)

On Fri, Aug 5, 2016 at 2:37 AM, Jordan Justen <jordan.l.jus...@intel.com> wrote: > On 2016-08-02 03:46:27, Tomasz Figa wrote: > > As a preparation to use the lookup in more than once place, move the > > code that looks up given KMS/GEM handle to a separate function. T

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

On Wed, Aug 3, 2016 at 9:38 PM, Rob Herring <r...@kernel.org> wrote: > On Tue, Aug 2, 2016 at 9:27 PM, Tomasz Figa <tf...@chromium.org> wrote: >> Hi Rob, >> >> On Wed, Aug 3, 2016 at 2:32 AM, Rob Herring <r...@kernel.org> wrote: >>> On Tue, Aug 2,

Re: [Mesa-dev] Mesa (master): egl/dri2: Add reference count for dri2_egl_display

Hi, On Tue, Aug 2, 2016 at 7:21 PM, Martin Peres wrote: > On 29/07/16 09:20, Michel Dänzer wrote: >> >> On 28.07.2016 22:11, Emil Velikov wrote: >>> >>> Module: Mesa >>> Branch: master >>> Commit: 9ee683f877b283020c6f24776236f1145cb7a4ea >>> URL: >>>

Re: [Mesa-dev] [PATCH v2 7/7] egl/android: Make drm_gralloc headers optional (v2)

On Wed, Aug 3, 2016 at 5:12 AM, Rob Herring <r...@kernel.org> wrote: > On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa <tf...@chromium.org> wrote: >> Make the code at least compile when being built without drm_gralloc >> headers. >> >> v2: Replaced #ifdefs wi

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

Hi Rob, On Wed, Aug 3, 2016 at 2:32 AM, Rob Herring <r...@kernel.org> wrote: > On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa <tf...@chromium.org> wrote: >> From: Nicolas Boichat <drink...@chromium.org> >> >> Existing image loader code supports creating image

[Mesa-dev] [PATCH v2 4/7] egl/android: Refactor image creation to separate flink and prime paths (v2)

more easily in the future. v2: Split into separate patch. Add error messages. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 99 +++-- 1 file changed, 57 insertions(+), 42 deletions(-) diff --git a/src/egl/driver

[Mesa-dev] [PATCH v2 5/7] egl/android: Make get_fourcc() accept HAL formats

() first to convert from native to DRI_IMAGE_FORMAT. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/driver

[Mesa-dev] [PATCH v2 1/7] egl/android: Remove unused variables in droid_get_buffers_with_format()

Fix compilation warnings due to unused variables left after some earlier code changes. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/driver

[Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

quests of unavailable buffers. Improve coding style. Signed-off-by: Nicolas Boichat <drink...@chromium.org> Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/drivers/dri2/platform_android.c | 64 +---

[Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

This patch adds support for YV12 pixel format to the Android platform backend. Only creating EGL images is supported, it is not added to the list of available visuals. v2: Use const array defined just for YV12 instead of trying to be overly generic. Signed-off-by: Tomasz Figa <

[Mesa-dev] [PATCH v2 7/7] egl/android: Make drm_gralloc headers optional (v2)

Make the code at least compile when being built without drm_gralloc headers. v2: Replaced #ifdefs with stubs for gralloc_drm_get_gem_handle() and GRALLOC_MODULE_PERFORM_GET_DRM_FD. Removed explicit render node probing code. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- s

[Mesa-dev] [PATCH v2 2/7] egl/android: Respect buffer mask in droid_image_get_buffers (v2)

-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 124a30c..d78c06d 100644 --- a/src/egl/d

[Mesa-dev] [PATCH v2 0/7] egl/android: Improve the Android EGL backend

/android: Fix support for pbuffers Tomasz Figa (6): egl/android: Remove unused variables in droid_get_buffers_with_format() egl/android: Respect buffer mask in droid_image_get_buffers egl/android: Refactor image creation to separate flink and prime paths egl/android: Make get_fourcc() accept

[Mesa-dev] [PATCH v2 1/4] gallium/winsys/kms: Fix double refcount when importing from prime FD (v2)

Currently the code creates a display target struct with refcount field initialized to 1 and then the caller again increments it, leading to a leaked reference. Let's remove the unnecessary increment. v2: Split from one big patch into four fixing one thing at a time. Signed-off-by: Tomasz Figa

[Mesa-dev] [PATCH v2 0/4] gallium/winsys/kms: Fix issues with prime import

://patchwork.freedesktop.org/patch/98856/) and so they patches inside are considered to be v2. Tomasz Figa (4): gallium/winsys/kms: Fix double refcount when importing from prime FD (v2) gallium/winsys/kms: Fully initialize kms_sw_dt at prime import time (v2) gallium/winsys/kms: Move display target handle lookup

[Mesa-dev] [PATCH v2 4/4] gallium/winsys/kms: Look up the GEM handle after importing a prime FD (v2)

ist first and bumping the refcount of the found dt on hit and falling back to creating a new dt only on miss. v2: Split into separate function. Use helper function for lookup. Signed-off-by: Tomasz Figa <tf...@chromium.org> CC: <mesa-sta...@lists.freedesktop.org> --- src/gallium/wi

[Mesa-dev] [PATCH v2 2/4] gallium/winsys/kms: Fully initialize kms_sw_dt at prime import time (v2)

there, so that caller can take the returned struct as is. v2: Split from one big patch into four fixing one thing at a time. Signed-off-by: Tomasz Figa <tf...@chromium.org> CC: <mesa-sta...@lists.freedesktop.org> --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 18 +++---

[Mesa-dev] [PATCH v2 3/4] gallium/winsys/kms: Move display target handle lookup to separate function (v2)

As a preparation to use the lookup in more than once place, move the code that looks up given KMS/GEM handle to a separate function. This change should not introduce any functional changes. v2: Split into separate patch. Move lookup code into separate function. Signed-off-by: Tomasz Figa <

Re: [Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

Hi Emil, Sorry for late reply. On Mon, Jul 18, 2016 at 7:33 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 15 July 2016 at 08:53, Tomasz Figa <tf...@chromium.org> wrote: >> There are DRI_IMAGE_FOURCC macros, for which there are no corresponding >> DRI_IMAG

Re: [Mesa-dev] [PATCH] gallium/sw/kms: Fix multiple imports from PRIME FDs

Hi Emil, On Sat, Jul 16, 2016 at 6:38 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 15 July 2016 at 08:27, Tomasz Figa <tf...@chromium.org> wrote: >> When a buffer with a GEM handle already existing in our context is >> (re-)imported from a PRIME FD, the resu

Re: [Mesa-dev] [PATCH v2] egl: android: query native window default width and height

c/egl/drivers/dri2/egl_dri2.c | 11 +++ > src/egl/drivers/dri2/egl_dri2.h | 4 > src/egl/drivers/dri2/platform_android.c | 27 +++ > 3 files changed, 42 insertions(+) Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz

Re: [Mesa-dev] [PATCH 06/10] egl/android: Fix support for pbuffers

On Thu, Jul 21, 2016 at 6:19 AM, Rob Herring <r...@kernel.org> wrote: > On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa <tf...@chromium.org> wrote: >> From: Nicolas Boichat <drink...@chromium.org> >> >> Existing image loader code supports creating image

Re: [Mesa-dev] [PATCH 10/10] egl/android: Add fallback to kms_swrast driver

On Wed, Jul 20, 2016 at 10:34 PM, Rob Herring <r...@kernel.org> wrote: > On Wed, Jul 20, 2016 at 12:53 AM, Tomasz Figa <tf...@chromium.org> wrote: >> On Wed, Jul 20, 2016 at 7:40 AM, Rob Herring <r...@kernel.org> wrote: >>> On Fri, Jul 15, 2016 at 2:53 AM, To

Re: [Mesa-dev] [PATCH 00/10] egl/android: Improve the Android EGL backend

On Wed, Jul 20, 2016 at 10:43 PM, Rob Herring <r...@kernel.org> wrote: > On Mon, Jul 18, 2016 at 11:29 PM, Tomasz Figa <tf...@chromium.org> wrote: >> On Tue, Jul 19, 2016 at 12:35 PM, Rob Herring <r...@kernel.org> wrote: >>> On Fri, Jul 15, 2016 at 2:53 AM, To

Re: [Mesa-dev] [PATCH 00/10] egl/android: Improve the Android EGL backend

Hi Rob, On Tue, Jul 19, 2016 at 1:29 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Tue, Jul 19, 2016 at 12:35 PM, Rob Herring <r...@kernel.org> wrote: >> >> Patches 7-10 wouldn't apply. Do you have a git tree with the series? > > Hmm, I rebased them on Mesa m

Re: [Mesa-dev] [PATCH 10/10] egl/android: Add fallback to kms_swrast driver

On Wed, Jul 20, 2016 at 7:40 AM, Rob Herring <r...@kernel.org> wrote: > On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa <tf...@chromium.org> wrote: >> If no hardware driver is present, it is possible to fall back to >> the kms_swrast driver with any DRI node that supports

Re: [Mesa-dev] [PATCH 00/10] egl/android: Improve the Android EGL backend

On Tue, Jul 19, 2016 at 12:35 PM, Rob Herring <r...@kernel.org> wrote: > On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa <tf...@chromium.org> wrote: >> Hi, >> >> This series is a collection of various fixes and extensions we came up >> with during our attem

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Tue, Jul 19, 2016 at 2:35 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 18 July 2016 at 16:38, Tomasz Figa <tf...@chromium.org> wrote: >> On Mon, Jul 18, 2016 at 11:58 PM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> On 18 July 2016

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Mon, Jul 18, 2016 at 11:58 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 18 July 2016 at 13:02, Tomasz Figa <tf...@chromium.org> wrote: >> On Mon, Jul 18, 2016 at 7:28 PM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> Hi Tomasz, >

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Mon, Jul 18, 2016 at 7:28 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Tomasz, > > On 15 July 2016 at 08:53, Tomasz Figa <tf...@chromium.org> wrote: >> We can support render nodes alone without any private headers, so let's >> make support for

Re: [Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

Hi Rob, On Sun, Jul 17, 2016 at 5:57 AM, Rob Herring <r...@kernel.org> wrote: > On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa <tf...@chromium.org> wrote: >> There are DRI_IMAGE_FOURCC macros, for which there are no corresponding >> DRI_IMAGE_FORMAT macros. To support s

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Sat, Jul 16, 2016 at 11:17 PM, Rob Herring <r...@kernel.org> wrote: > On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa <tf...@chromium.org> wrote: >> We can support render nodes alone without any private headers, so let's >> make support for control nodes depend on pres

Re: [Mesa-dev] [PATCH 04/10] egl/android: Stop leaking DRI images

Hi Eric, On Sat, Jul 16, 2016 at 3:05 AM, Eric Anholt <e...@anholt.net> wrote: > Tomasz Figa <tf...@chromium.org> writes: > >> Current implementation of the DRI image loader does not free the images >> created in get_back_bo() and so leaks memory. Moreover, it cre

Re: [Mesa-dev] [PATCH 01/10] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

[Adding Haixia to the thread.] On Sat, Jul 16, 2016 at 2:52 AM, Eric Anholt <e...@anholt.net> wrote: > Tomasz Figa <tf...@chromium.org> writes: > >> From: Haixia Shi <h...@chromium.org> >> >> Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFF

[Mesa-dev] [PATCH 10/10] egl/android: Add fallback to kms_swrast driver

-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 9c8156c..f0afca1 100644 ---

[Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

We can support render nodes alone without any private headers, so let's make support for control nodes depend on presence of private drm_gralloc headers. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/Android.mk | 1 + src/egl/drivers/dri2/egl_

[Mesa-dev] [PATCH 09/10] egl/android: Add support for YV12 pixel format

This patch adds support for YV12 pixel format to the Android platform backend. Only creating EGL images is supported, it is not added to the list of available visuals. Signed-off-by: Tomasz Figa <tf...@chromium.org> Signed-off-by: Kalyan Kondapally <kalyan.kondapa...@intel.com>

[Mesa-dev] [PATCH 08/10] egl/android: Make get_fourcc() accept HAL formats

() first to convert from native to DRI_IMAGE_FORMAT. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/driver

[Mesa-dev] [PATCH 06/10] egl/android: Fix support for pbuffers

issues. In addition, the config generation code is fixed to include single buffered contexts required for pbuffers and make sure that generated configs support only surfaces which can handle their supported buffering modes. Signed-off-by: Nicolas Boichat <drink...@chromium.org> Signed-of

[Mesa-dev] [PATCH 01/10] egl/android: Set EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT

From: Haixia Shi <h...@chromium.org> Set config attributes EGL_MAX_PBUFFER_WIDTH and EGL_MAX_PBUFFER_HEIGHT to hard-coded non-zero values. These two attributes are required on Android. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c |

[Mesa-dev] [PATCH 04/10] egl/android: Stop leaking DRI images

call to destroyImage() in droid_enqueue_buffer() and a check if image is already created to get_back_bo() to fix the above. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/egl/d

[Mesa-dev] [PATCH 00/10] egl/android: Improve the Android EGL backend

for pbuffers Tomasz Figa (8): egl/android: Check return value of dri2_get_dri_config() egl/android: Add some useful error messages egl/android: Stop leaking DRI images egl/android: Respect buffer mask in droid_image_get_buffers egl/android: Make drm_gralloc headers optional egl/android

[Mesa-dev] [PATCH 02/10] egl/android: Check return value of dri2_get_dri_config()

It might return NULL if specific config variant is unsupported. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_and

[Mesa-dev] [PATCH 03/10] egl/android: Add some useful error messages

It is much easier to debug issues when the application gives some meaningful error messages. This patch adds few to the EGL Android platform backend. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 13 ++--- 1 file changed, 10 inse

[Mesa-dev] [PATCH 05/10] egl/android: Respect buffer mask in droid_image_get_buffers

Drivers can request different set of buffers depending on the buffer mask they pass to the get_buffers callback. This patch makes droid_image_get_buffers() respect this mask. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/egl/drivers/dri2/platform_android.c | 15 +++

Re: [Mesa-dev] [PATCH v2] i965: store reference to the context within struct brw_fence (v2)

[Used wrong CC list originally, sorry ;/] On Fri, Jul 15, 2016 at 4:27 PM, Tomasz Figa <tf...@chromium.org> wrote: > From: Emil Velikov <emil.l.veli...@gmail.com> > > As the spec allows for {server,client}_wait_sync to be called without > currently bound context, while our

[Mesa-dev] [PATCH] gallium/sw/kms: Fix multiple imports from PRIME FDs

ourselves. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 30 +-- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/src/gallium/winsys/sw/k

[Mesa-dev] [PATCH v2] i965: store reference to the context within struct brw_fence (v2)

t_wait() and brw_fence_is_completed() as suggested by Chad. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/mesa/drivers/dri/i965/intel_syncobj.c | 55 --- 1 file changed, 44 insertions(+), 11 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] gallium/dri: Add shared glapi to LIBADD on Android

Hi Emil, On Thu, Jul 14, 2016 at 1:28 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 13 July 2016 at 04:29, Nicolas Boichat <drink...@chromium.org> wrote: >> From: Tomasz Figa <tf...@chromium.org> >> >> An earlier patch fixed the problem for classi

Re: [Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers

Please disregard this one. Forgot to add change log and update the subject with version suffix. Fixed and resent already. Sorry for the noise. On Mon, Jun 13, 2016 at 7:48 PM, Tomasz Figa <tf...@chromium.org> wrote: > The images struct is an uninitialized local variable on

[Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers (v2)

and pointer dereference to keep line length reasonable. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/mesa/drivers/dri/i965/brw_context.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dr

[Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers

from images.image_mask and dereferencing further fields. Another solution would be to initialize image_mask with 0, but checking the return value seems more sensible and it is what Gallium is doing. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/mesa/drivers/dri/i965/brw_context.

[Mesa-dev] [PATCH] i965: Check return value of screen->image.loader->getBuffers

images.image_mask and dereferencing further fields. Another solution would be to initialize image_mask with 0, but checking the return value seems more sensible and it is what Gallium is doing. Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/mesa/drivers/dri/i965/brw_context

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

Uhm, dropped other recipients by mistake last time. As I said, it was too late hour to reply for me. :) On Sun, May 29, 2016 at 2:09 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 27 May 2016 at 17:22, Tomasz Figa <tf...@chromium.org> wrote: >> On Sat, May 28, 2

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

Hi, On Fri, May 27, 2016 at 7:36 PM, Nicolas Boichat wrote: > Hi Emil, > > Took us some time to clean things up, but we got an ebuild and repo to > share with you. > > On Tue, May 24, 2016 at 10:52 PM, Emil Velikov > wrote: > [snip] >>> We also

[Mesa-dev] [PATCH 3/4] st/mesa: Fix paths used in Android builds

in Android.gen.mk. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com CC: mesa-sta...@lists.freedesktop.org --- src/mesa/Android.libmesa_dricore.mk | 2 ++ src/mesa/Android.libmesa_st_mesa.mk | 2 ++ src/mesa/program/Android.mk | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/mesa

[Mesa-dev] [PATCH 1/4] util: Include in Android builds

This patch fixes Android build failures by including src/util directory in compilation. Files inside of this directory are compiled into libmesa_util static library and linked with resulting libGLES_mesa. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com CC: mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH 4/4] glsl: Fix no return value for non-void function

Even though scope outside the switch statement is unreachable, the compiler generates a warning, which is treated as error by Android toolchain. Fix the issue by adding dummy return statement. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com CC: mesa-sta...@lists.freedesktop.org --- src/glsl

[Mesa-dev] [PATCH 2/4] st/mesa: Generate format_info.c in Android builds

Current Android makefiles lack generation of format_info.c, which is a dependency of main/format.c. This patch adds necessary code to Android.gen.mk. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com CC: mesa-sta...@lists.freedesktop.org --- src/mesa/Android.gen.mk | 9 + 1 file changed

[Mesa-dev] [PATCH 0/4] Fix Mesa Android build issues

://androidarmv6.github.io/ Tomasz Figa (4): util: Include in Android builds st/mesa: Generate format_info.c in Android builds st/mesa: Fix paths used in Android builds glsl: Fix no return value for non-void function Android.mk | 1 + src/egl/main/Android.mk

Re: [Mesa-dev] [PATCH 4/4] glsl: Fix no return value for non-void function

On 27.09.2014 16:40, Emil Velikov wrote: On 27/09/14 15:20, Tomasz Figa wrote: Even though scope outside the switch statement is unreachable, the compiler generates a warning, which is treated as error by Android toolchain. Fix the issue by adding dummy return statement. I fear that other

<    1   2   3