Re: [Mesa-dev] [PATCH] vbo: remove MaxVertexAttribStride assert check.

2018-05-21 Thread Ian Romanick
On 05/17/2018 11:56 PM, Mathias Fröhlich wrote: > Hi Dave, > > On Friday, 18 May 2018 06:57:19 CEST Dave Airlie wrote: >>> May be I should take care of all of these type of asserts, also the ones >>> with MaxVertexAttribRelativeOffset and care for not checking them >>> when the extension version

Re: [Mesa-dev] [PATCH] vbo: remove MaxVertexAttribStride assert check.

2018-05-18 Thread Mathias Fröhlich
Hi Dave, On Friday, 18 May 2018 06:57:19 CEST Dave Airlie wrote: > > May be I should take care of all of these type of asserts, also the ones > > with MaxVertexAttribRelativeOffset and care for not checking them > > when the extension version is unavailable or checking against the OpenGL > > spec

Re: [Mesa-dev] [PATCH] vbo: remove MaxVertexAttribStride assert check.

2018-05-17 Thread Dave Airlie
On 15 May 2018 at 16:31, Mathias Fröhlich wrote: > Hi Dave, > > On Tuesday, 15 May 2018 07:44:44 CEST Dave Airlie wrote: >> From: Dave Airlie >> >> Some drivers (virgl) don't support GL4.4 or GLES3.1 yet, >> so never fill in this const. > > May be I

Re: [Mesa-dev] [PATCH] vbo: remove MaxVertexAttribStride assert check.

2018-05-15 Thread Mathias Fröhlich
Hi Dave, On Tuesday, 15 May 2018 07:44:44 CEST Dave Airlie wrote: > From: Dave Airlie > > Some drivers (virgl) don't support GL4.4 or GLES3.1 yet, > so never fill in this const. May be I should take care of all of these type of asserts, also the ones with

[Mesa-dev] [PATCH] vbo: remove MaxVertexAttribStride assert check.

2018-05-14 Thread Dave Airlie
From: Dave Airlie Some drivers (virgl) don't support GL4.4 or GLES3.1 yet, so never fill in this const. Signed-off-by: Dave Airlie --- src/mesa/vbo/vbo_exec_draw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c