Your attached patch looks good to me. You can add my r-b to it.
Quoting Jon Turney (2018-01-15 11:50:04)
> On 12/01/2018 17:33, Dylan Baker wrote:
> > Maybe this is correct, but it makes me nervous treating with_gallium as
> > equivalent to with_dri, since gallium drivers can be built dri-less
>
On Mon, 2018-01-15 at 20:01 +, Jon Turney wrote:
> On 12/01/2018 17:25, Dylan Baker wrote:
> > meson considers classic swrast to be a dri driver, I know it's not exactly
> > accurate, but, at least for me, it made the build system easier to reason
> > about.
>
> I think maybe the point here
On 12/01/2018 17:25, Dylan Baker wrote:
meson considers classic swrast to be a dri driver, I know it's not exactly
accurate, but, at least for me, it made the build system easier to reason about.
I think maybe the point here is that '-Ddri-drivers= -Dgallium-drivers=
-Dglx=dri' (or at least,
On 12/01/2018 17:33, Dylan Baker wrote:
Maybe this is correct, but it makes me nervous treating with_gallium as
equivalent to with_dri, since gallium drivers can be built dri-less
(gallium-xlib, and some other configurations on windows). I think something
like:
with_glx = get_option('glx')
meson considers classic swrast to be a dri driver, I know it's not exactly
accurate, but, at least for me, it made the build system easier to reason about.
Quoting Adam Jackson (2018-01-12 09:06:37)
> On Fri, 2018-01-12 at 13:18 +, Jon Turney wrote:
> > 'meson -Ddri-drivers=
Maybe this is correct, but it makes me nervous treating with_gallium as
equivalent to with_dri, since gallium drivers can be built dri-less
(gallium-xlib, and some other configurations on windows). I think something
like:
with_glx = get_option('glx')
if with_glx == 'auto'
if with_dri
On Fri, 2018-01-12 at 13:18 +, Jon Turney wrote:
> 'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' fails with 'dri
> based GLX requires at least one DRI driver'
>
> Signed-off-by: Jon Turney
> ---
> meson.build | 2 +-
> src/glx/meson.build | 2
'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' fails with 'dri
based GLX requires at least one DRI driver'
Signed-off-by: Jon Turney
---
meson.build | 2 +-
src/glx/meson.build | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git