Re: [Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

2018-03-05 Thread Brian Paul
On 03/05/2018 06:14 AM, Emil Velikov wrote: On 13 February 2018 at 20:27, Brian Paul wrote: On 02/13/2018 11:10 AM, Vadym Shovkoplias wrote: Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION v2: - Combine similar

Re: [Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

2018-03-05 Thread Emil Velikov
On 13 February 2018 at 20:27, Brian Paul wrote: > On 02/13/2018 11:10 AM, Vadym Shovkoplias wrote: >> >> Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS >> and glGetStringi for GL_SHADING_LANGUAGE_VERSION >> >> v2: >>- Combine similar functionality into >>

Re: [Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

2018-02-13 Thread Brian Paul
Looks good. I wrote a new piglit test to exercise this. I'll cc you on the review request for it. Thanks for your persistence on this! I'll re-test and push this soon. Reviewed-by: Brian Paul On 02/13/2018 11:10 AM, Vadym Shovkoplias wrote: Add support for

[Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

2018-02-13 Thread Vadym Shovkoplias
Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION v2: - Combine similar functionality into _mesa_get_shading_language_version() function. - Change GLSL version return mechanism. v3: - Add return of empty string for GLSL ver 1.10. - Move