Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Christian König wrote: Ah, yes of course. If we delay creating the decoder we need to call begin_frame() again as well. Please review and/or test the attached patch. Andy I did understand you right that this is already a Tested-by from your side, isn't it? Yes, this patch seems OK.

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

The patch is Reviewed-by: Nayan Deshmukh On Mon, Jan 23, 2017 at 7:01 PM, Christian König wrote: > Ah, yes of course. If we delay creating the decoder we need to call > begin_frame() again as well. > > Please review and/or test the attached

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Ah, yes of course. If we delay creating the decoder we need to call begin_frame() again as well. Please review and/or test the attached patch. Andy I did understand you right that this is already a Tested-by from your side, isn't it? I am wondering if calling decode_bitstream one at a time

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Nayan Deshmukh wrote: Hi Christian, The new patch leads to seg fault on my system. You forgot to set the needs_begin_frame to true when the decoder is created. Here's diff for reference: Setting true there seems to fix, though only a quick test. The patch below sets false :-)

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Hi Christian, The new patch leads to seg fault on my system. You forgot to set the needs_begin_frame to true when the decoder is created. Here's diff for reference: diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Andy Furniss wrote: Christian König wrote: Hi Andy, Am 19.01.2017 um 11:46 schrieb Andy Furniss: I think you are right about the slices, the failing vids are blu-ray/tv. https://drive.google.com/file/d/0BxP5-S1t9VEEZlozcjVUZ1lDbWM/view?usp=sharing Thanks for the link, if you have time

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Christian König wrote: Hi Andy, Am 19.01.2017 um 11:46 schrieb Andy Furniss: I think you are right about the slices, the failing vids are blu-ray/tv. https://drive.google.com/file/d/0BxP5-S1t9VEEZlozcjVUZ1lDbWM/view?usp=sharing Thanks for the link, if you have time please give the attached

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Hi Andy, Am 19.01.2017 um 11:46 schrieb Andy Furniss: I think you are right about the slices, the failing vids are blu-ray/tv. https://drive.google.com/file/d/0BxP5-S1t9VEEZlozcjVUZ1lDbWM/view?usp=sharing Thanks for the link, if you have time please give the attached patch a try. It

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Christian König wrote: Am 19.01.2017 um 00:20 schrieb Andy Furniss: Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: On 17 January 2017 at 14:55, Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 6:25 PM, Christian

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

On Thu, Jan 19, 2017 at 2:07 PM, Christian König wrote: > Am 19.01.2017 um 00:20 schrieb Andy Furniss: >> >> Nayan Deshmukh wrote: >>> >>> On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov >>> wrote: On 17 January 2017 at 14:55, Nayan

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Am 19.01.2017 um 00:20 schrieb Andy Furniss: Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: On 17 January 2017 at 14:55, Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 6:25 PM, Christian König

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: On 17 January 2017 at 14:55, Nayan Deshmukh wrote: On Tue, Jan 17, 2017 at 6:25 PM, Christian König wrote: Hi Nayan, I've pushed this

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: > On 17 January 2017 at 14:55, Nayan Deshmukh wrote: >> On Tue, Jan 17, 2017 at 6:25 PM, Christian König >> wrote: >>> Hi Nayan, >>> >>> I've pushed this patch

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

On 17 January 2017 at 14:55, Nayan Deshmukh wrote: > On Tue, Jan 17, 2017 at 6:25 PM, Christian König > wrote: >> Hi Nayan, >> >> I've pushed this patch yesterday and this one just a minute ago. >> > Thanks for the push. I am planning on

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

On Tue, Jan 17, 2017 at 6:25 PM, Christian König wrote: > Hi Nayan, > > I've pushed this patch yesterday and this one just a minute ago. > Thanks for the push. I am planning on sending a similar patch for vaapi. Regards, Nayan

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Hi Nayan, I've pushed this patch yesterday and this one just a minute ago. Christian. Am 16.01.2017 um 14:19 schrieb Nayan Deshmukh: Hi Christian, Please push this patch. There are a couple of patches [1] which are not yet reviewed. They are trivial and are tested by Andy. Please have a

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Hi Christian, Please push this patch. There are a couple of patches [1] which are not yet reviewed. They are trivial and are tested by Andy. Please have a look at them. Regards, Nayan [1] https://lists.freedesktop.org/archives/mesa-dev/2017-January/140395.html On Fri, Jan 13, 2017 at 11:17

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Nayan Deshmukh wrote: On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss wrote: Would be interesting to see if you see the same with this vid which easily shows the corruption. https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s?usp=sharing Looks bad

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss wrote: > > Nayan Deshmukh wrote: >> >> On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: >> >>> Nayan Deshmukh wrote: >>> Hi Andy, Please test this patch for regressions. >>> >>> Do you

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Nayan Deshmukh wrote: On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, Please test this patch for regressions. Do you have a testcase to show the fix? TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2 h/w dec never

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Andy, >> >> Please test this patch for regressions. >> > > Do you have a testcase to show the fix? > > TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2 > h/w dec never worked

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Nayan Deshmukh wrote: Hi Andy, Please test this patch for regressions. Do you have a testcase to show the fix? TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2 h/w dec never worked properly anyway. https://bugs.freedesktop.org/show_bug.cgi?id=93760 With mpv --hwdec=vaapi it

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Am 13.01.2017 um 14:15 schrieb Nayan Deshmukh: If begin_frame is called before setting intra_matrix and non_intra_matrix it leads to segmentation faults when vl_mpeg12_decoder.c is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Nayan Deshmukh

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

Hi Andy, Please test this patch for regressions. Cheers, Nayan On Fri, Jan 13, 2017 at 6:45 PM, Nayan Deshmukh wrote: > If begin_frame is called before setting intra_matrix and > non_intra_matrix it leads to segmentation faults when > vl_mpeg12_decoder.c is used. >