Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

Am Dienstag, den 16.05.2017, 21:31 +0200 schrieb Christian Gmeiner: > Hi Wladimir. > > I started working on this topic last week and thought some time on how > to add those ext texture formats in a clean and nice way. I come up > with this patches: > >

[Mesa-dev] [v2 4/7] i965/gen4: Simplify depth/stencil invalidate check

There is no separate stencil on gen < 6. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c

[Mesa-dev] [v2 7/7] i965/gen4: Tell briefly how workaround depth gets reconciled

CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c

[Mesa-dev] [v2 3/7] i965/gen4: Remove redundant check for depth when rebasing stencil

In case of gen < 6 stencil (if present) is always combined with depth. Both stencil and depth attachments point to the same physical surface. Alignment workaround starts by considering depth and updates stencil accordingly. Current logic continues with stencil and in vain considers the case where

[Mesa-dev] [v2 5/7] i965: Drop depth/stencil miptree pointers in alignment workaround

In brw_workaround_depthstencil_alignment() corresponding renderbuffers are always set to refer to the same temp miptrees. There is no need to carry them in context. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h| 3 ---

Re: [Mesa-dev] [PATCH v2] drirc: Add allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition

Pushed, thanks. Marek On Sun, May 21, 2017 at 11:46 PM, Benedikt Schemmer wrote: > From: Benedikt Schemmer > > This patch sets the allow_glsl_builtin_variable_redeclaration for Dead > Island Riptide Definitive Edition. > > Tested with Mesa git as of today and Dying

Re: [Mesa-dev] [PATCH v3 01/15] st/dri: refactor multi-planar YUV import path

Am Mittwoch, den 10.05.2017, 23:15 +0530 schrieb Varad Gautam: > From: Varad Gautam > > we currently ignore the plane count when converting from > __DRI_IMAGE_FORMAT* tokens to __DRI_IMAGE_FOURCC* for multiplanar > images, and only return the first plane's simplified

Re: [Mesa-dev] [PATCH 11/13] egl: refactor dri2_create_screen() into three separate functions

On Thu, May 11, 2017 at 1:57 PM, Emil Velikov wrote: > Split the create_screen into: > - create screen > - setup/bind extensions > - setup screen > > This will allow us to reuse the latter two on egl/drm. Said platform > does create its own screen and attempts to

Re: [Mesa-dev] How does FakeGLX work since Mesa 10?

On 05/09/2017 12:07 PM, Tom Hudson wrote: I'm trying to upgrade a Mesa 10 installation to Mesa 17. There have been plenty of changes, but only one breakage that's left me perplexed. https://cgit.freedesktop.org/mesa/mesa/commit/?id=c00b250c8061d042d9905e61b9077462ee91008b In this CL, Mesa

[Mesa-dev] [v2 6/7] i965/gen4: Refactor depth/stencil rebase

Effectively there is the same code twice, once for depth and again for stencil. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 243 - 1 file changed, 63 insertions(+), 180 deletions(-) diff --git

[Mesa-dev] [v2 2/7] i965/gen4: Remove non-existing stencil and hiz buffer setup

Separate stencil and hiz are only enabled for gen6+. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h| 6 +- src/mesa/drivers/dri/i965/brw_misc_state.c | 120 +++-- 2 files changed, 14 insertions(+), 112

[Mesa-dev] [v2 1/7] i965/gen4: Set depth offset when there is stencil attachment only

Current version fails to set depthstencil.depth_offset when there is only stencil attachment (it does set the intra tile offsets though). Fixes piglits: g45,g965,ilk: depthstencil-render-miplevels 1024 s=z24_s8 g45,ilk:depthstencil-render-miplevels 273 s=z24_s8 CC:

Re: [Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

2017-05-22 21:19 GMT+02:00 Ian Romanick : > On 05/22/2017 11:55 AM, Thomas Helland wrote: >> _mesa_hash_table_search is one of our hottest function according to perf. >> Callgrind shows the refcounting as one of the major users of the >> searching functions. We can reduce the

[Mesa-dev] [Bug 100988] glXGetCurrentDisplay() no longer works for FakeGLX contexts?

https://bugs.freedesktop.org/show_bug.cgi?id=100988 Brian Paul changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |bri...@vmware.com

[Mesa-dev] [PATCH 1/7] egl/drm: check for dri2_dpy->flush before using the flush extension

From: Emil Velikov The current __DRI_DRI2 imples __DRI2_FLUSH. At the same time, one can use __DRI_IMAGE_DRIVER alongside the latter, so the current check is confusing at best. Check for what we use. v2: Split out from whitespace changes Reviewed-by: Chad Versace

[Mesa-dev] [PATCH 2/7] egl/x11: check for dri2_dpy->flush before using the flush extension

From: Emil Velikov Analogous to earlier commit. Note that the dri2_x11_post_sub_buffer and dri2_x11_swap_buffers_region paths already implicitly require __DRI2_FLUSH. The corresponding extensions (NV_post_sub_buffer and NOK_swap_region) are enabled only with DRI2.

[Mesa-dev] [PATCH 1.5/7] egl/drm: flatten codeflow

From: Emil Velikov Rework the code to return early and drop an indentation level. No functional change, yet it should be easier to read. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 39

[Mesa-dev] [PATCH 3.5/7] egl/x11: flatten codeflow

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c

[Mesa-dev] [PATCH 2/6] nir: Prehash in instr_set to avoid hashing twice

This should prove benefitial in the common case of inserting and not rewriting anything. V2: Use hash_instr directly instead of going through the function pointer embedded in the set --- src/compiler/nir/nir_instr_set.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 0/6] Prehash all the things

While this doesn't prehash all the things, it does switch quite a lot of places from doing a search and then a subsequent insert to first hash the key, and then use this hash when searching / inserting. While our new pointer hashing function remedied much of our overhead hashing pointers, there is

[Mesa-dev] [PATCH 3/6] glsl: Prehash in constant propagation

This should reduce overhead since we can hash only once. --- src/compiler/glsl/opt_constant_propagation.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/opt_constant_propagation.cpp b/src/compiler/glsl/opt_constant_propagation.cpp index

[Mesa-dev] [PATCH 6/6] util: Avoid computing hash twice in string_to_uint_map

This is not a hot path, but when we have the functionality we should take advantage of it. --- src/util/string_to_uint_map.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util/string_to_uint_map.h b/src/util/string_to_uint_map.h index e0533ec6ea..3248696e88

[Mesa-dev] [PATCH 4/6] glsl: Prehash in constant var pass to avoid hashing twice

Should help us reduce some hash table overhead. V2: Fix whitespace error --- src/compiler/glsl/opt_constant_variable.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/opt_constant_variable.cpp b/src/compiler/glsl/opt_constant_variable.cpp index

[Mesa-dev] [PATCH 5/6] glsl: Prehash to avoid computing the hash twice

Copy propagation elements is a large user of the hash table. We should not be computing the hash twice when we don't have to. --- src/compiler/glsl/opt_copy_propagation_elements.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

_mesa_hash_table_search is one of our hottest function according to perf. Callgrind shows the refcounting as one of the major users of the searching functions. We can reduce the pain by prehashing, so that we avoid hashing two times when inserting in the table. On a short shader-db run (with

Re: [Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

On Mon, May 22, 2017 at 1:07 PM Jose Fonseca wrote: > This prevents spurious failures when libtxc-dxtn-s2tc is installed. > > Note: lp_test_format does need any change s/does/doesn't/ With that commit message fix: Reviewed-by: Rhys Kidd since we

Re: [Mesa-dev] [PATCH 00/13] egl: gbm: Misc cleanups and robustness patches

On Thu, May 11, 2017 at 1:57 PM, Emil Velikov wrote: > Hi all, > > I was around the EGL/GBM codebase and I've noticed that we do a few > things, rather badly: > - we have unnessesary layer of abstraction in GBM like the following > gbm_dri_foo -> gbm_drm_foo -> gbm_foo

Re: [Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

On Mon, May 22, 2017 at 10:07 AM, Rafael Antognolli wrote: > On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat wrote: >> These declarations will help the code start compiling >> once we wire up the makefiles for gen10. Later patches >> will start using these

Re: [Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

Reviewed-by: Roland Scheidegger Thanks! Am 22.05.2017 um 19:06 schrieb Jose Fonseca: > This prevents spurious failures when libtxc-dxtn-s2tc is installed. > > Note: lp_test_format does need any change since we were already ignoring > S3TC failures there. > --- >

Re: [Mesa-dev] Mesa 17.1.1 release candidate

> > The candidate for the Mesa 17.1.1 is now available. Excellent! >From build perspective - SWR now ships it's final generated header, thus > Python/mako is no longer required. > Just what I was looking for, thanks! Is a source tarball available that I can test the build with? I would just

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle wrote: > Hi all, > > I've been looking into ARB_gl_spirv for radeonsi. I don't fancy re-inventing > the ~8k LOC of src/compiler/spirv, and there's already a perfectly fine > SPIR-V -> NIR -> LLVM compiler pipeline in radv, so I

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On 05/22/2017 12:02 PM, Marek Olšák wrote: > On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle wrote: >> Hi all, >> >> I've been looking into ARB_gl_spirv for radeonsi. I don't fancy re-inventing >> the ~8k LOC of src/compiler/spirv, and there's already a perfectly fine >>

[Mesa-dev] [PATCH] mesa: Remove GL_APPLE_vertex_array_object stubs

From: Ian Romanick Mark the functions 'exec="skip"' in the XML instead. libGL will still have the functions, but the driver won't try to use them. I verified that this commit works with piglit's 'object-namespace-pollution glClear vertex-array' on x64 with a driver

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

On Fri, May 19, 2017 at 06:09:49PM -0700, Nanley Chery wrote: > On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote: > > On Fri, May 19, 2017 at 4:51 PM, Nanley Chery wrote: > > > > > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > > > > --- >

Re: [Mesa-dev] [PATCH 0/9][RFC] GLSL preprocessor/parser improvements

2017-05-22 3:41 GMT+02:00 Timothy Arceri : > I suspect you forgot to test with a debug build, there is issues with the > string buffer changes somewhere. > > ralloc.c:203: reralloc_size: Assertion `ralloc_parent(ptr) == ctx' failed. > > #0 0x770eb91f in raise ()

Re: [Mesa-dev] [PATCH] st/nine: Fix a regression and syntax cleanup

The crash with STALKER: CoC is fixed with this patch. Tested-by: Edmondo Tommasina Thanks edmondo On Mon, May 22, 2017 at 12:22 AM, Axel Davy wrote: > A few cleanups and in particular initializing properly > the new pipe_draw_info fields. > This

Re: [Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

On 05/22/2017 11:55 AM, Thomas Helland wrote: > _mesa_hash_table_search is one of our hottest function according to perf. > Callgrind shows the refcounting as one of the major users of the > searching functions. We can reduce the pain by prehashing, so that we > avoid hashing two times when

Re: [Mesa-dev] [RFC PATCH 02/65] mesa: implement ARB_bindless_texture

On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/context.c | 3 + src/mesa/main/dd.h | 17 + src/mesa/main/mtypes.h | 34 ++ src/mesa/main/samplerobj.c | 6 + src/mesa/main/shared.c

Re: [Mesa-dev] [RFC PATCH 01/65] mapi: add GL_ARB_bindless_texture entry points

On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_bindless_texture.xml | 100 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 4 +-

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

Hey Ian, Do you want more time to look into this? I double-checked that glslang accepts this code pattern. Cheers, Nicolai On 16.05.2017 14:29, Nicolai Hähnle wrote: On 16.05.2017 02:56, Ian Romanick wrote: On 05/15/2017 02:27 AM, Nicolai Hähnle wrote: Hi all, This series aims to

Re: [Mesa-dev] [PATCH 2/6] nir: Prehash in instr_set to avoid hashing twice

2017-05-22 20:55 GMT+02:00 Thomas Helland : > This should prove benefitial in the common case of inserting > and not rewriting anything. > > V2: Use hash_instr directly instead of going through the function > pointer embedded in the set Threw some sysprof profiles at

Re: [Mesa-dev] driconf: Add allow_glsl_builtin_variable_redeclaration option

On 05/22/2017 11:49 PM, Dieter Nützel wrote: Hello John, hello Samuel, is 'allow_glsl_builtin_redeclaration=true' needed after this (commit #bf4d7671f423f5d4e451fba81bb9d9ae57f5fe5b) landed? Hi, Yes, because the option is only enabled with 2b878cb8fdb99dd84602553c2e95ef47747f4529.

Re: [Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

Jose Fonseca writes: > This prevents spurious failures when libtxc-dxtn-s2tc is installed. > > Note: lp_test_format does need any change since we were already ignoring > S3TC failures there. Tested-by: Eric Anholt signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH] mesa: Remove GL_APPLE_vertex_array_object stubs

On 23/05/17 05:26, Ian Romanick wrote: From: Ian Romanick Mark the functions 'exec="skip"' in the XML instead. libGL will still have the functions, but the driver won't try to use them. I verified that this commit works with piglit's 'object-namespace-pollution

Re: [Mesa-dev] [PATCH] st/nine: Fix a regression and syntax cleanup

FW: Got it a shot with radeonsi/RX580 under Wine-2.8-staging. Tried it with LS2015, LS2017, TS2017 and PES2015. Tested-by: Dieter Nützel Dieter Am 22.05.2017 00:22, schrieb Axel Davy: A few cleanups and in particular initializing properly the new pipe_draw_info fields.

Re: [Mesa-dev] driconf: Add allow_glsl_builtin_variable_redeclaration option

Hello John, hello Samuel, is 'allow_glsl_builtin_redeclaration=true' needed after this (commit #bf4d7671f423f5d4e451fba81bb9d9ae57f5fe5b) landed? Thanks, Dieter ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

2017-05-22 21:44 GMT+02:00 Thomas Helland : > 2017-05-22 21:19 GMT+02:00 Ian Romanick : >> On 05/22/2017 11:55 AM, Thomas Helland wrote: >>> _mesa_hash_table_search is one of our hottest function according to perf. >>> Callgrind shows the

Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

2017-05-22 19:51 GMT+02:00 Lucas Stach : > Am Dienstag, den 16.05.2017, 21:31 +0200 schrieb Christian Gmeiner: >> Hi Wladimir. >> >> I started working on this topic last week and thought some time on how >> to add those ext texture formats in a clean and nice way. I come up

Re: [Mesa-dev] driconf: Add allow_glsl_builtin_variable_redeclaration option

Am 22.05.2017 23:56, schrieb Samuel Pitoiset: On 05/22/2017 11:49 PM, Dieter Nützel wrote: Hello John, hello Samuel, is 'allow_glsl_builtin_redeclaration=true' needed after this (commit #bf4d7671f423f5d4e451fba81bb9d9ae57f5fe5b) landed? Hi, Yes, because the option is only enabled with

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On Mon, May 22, 2017 at 9:16 AM, Emil Velikov wrote: > On 20 May 2017 at 01:16, Rob Herring wrote: >> On Fri, May 19, 2017 at 12:57 PM, Emil Velikov >> wrote: >>> On 18 May 2017 at 23:01, Rob Herring wrote:

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

Hello Samuel, running this on radeonsi/RX580. Didn't saw better numbers for Wine/TS2017 (TrainSimulator 2017) ever before. But didn't feaguered if it (can) use bindless (with Wine/stagging). Do we have a knob to toggle bindless on and off? A key from Feral for DiRT Rally or the like would be

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 04:29:16PM -0700, Ian Romanick wrote: > On 05/19/2017 10:28 AM, Nanley Chery wrote: > > On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> The previous code handled everything with the general case. I

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

Taking the "just reply to Nicolai" approach like everyeone else... Nicolai, First off, thanks for working on this! I've given it a bit of thought in the context of i965, so I've got a few ideas about how you could overcome some of the issues. On Sun, May 21, 2017 at 3:48 AM, Nicolai Hähnle

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

I'm quite sure on Gentoo lib points to lib64 and we have a lib32 On Mon, 22 May 2017 at 22:46 Rob Herring wrote: > On Mon, May 22, 2017 at 9:16 AM, Emil Velikov > wrote: > > On 20 May 2017 at 01:16, Rob Herring wrote: > >> On Fri,

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On 23/05/17 05:02, Marek Olšák wrote: On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle wrote: Hi all, I've been looking into ARB_gl_spirv for radeonsi. I don't fancy re-inventing the ~8k LOC of src/compiler/spirv, and there's already a perfectly fine SPIR-V -> NIR -> LLVM

Re: [Mesa-dev] [PATCH] st/dri: Add fence extension to SW path

When you resubmit the patch again, please add (v3) to the subject. On Mon 08 May 2017, Gurchetan Singh wrote: > Use the same fence implementation for drisw.c as dri2.c by making > dri2FenceExtension an external variable. Since the fence implementation > is not dri2.c specific, put it in a

Re: [Mesa-dev] [PATCH 01/10] mesa: split vertex_array_vertex_buffer() in two

For the series: Tested-by: Dieter Nützel on radeonsi/RX580 Dieter Am 22.05.2017 07:46, schrieb Timothy Arceri: This will allow us to skip the error checkes when adding KHR_no_error support. Reviewed-by: Nicolai Hähnle ---

[Mesa-dev] [PATCH 1/2] st/dri: move fence implemention into separate file

Since the fence implementation is not dri2.c specific, put it in a separate file. This way SW implementations can use this extension too. v2: Don't depend on dri2.c for extensions (Emil) v3: Make this patch only move extension into a separate file (Chad). ---

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On Mon, May 22, 2017 at 9:15 PM, Timothy Arceri wrote: > On 23/05/17 10:44, Marek Olšák wrote: >> >> On Tue, May 23, 2017 at 12:07 AM, Timothy Arceri >> wrote: >>> >>> On 23/05/17 05:02, Marek Olšák wrote: On Sun, May 21, 2017 at 12:48

Re: [Mesa-dev] [PATCH 0/6] Prehash all the things

For the series: Tested-by: Dieter Nützel on radeonsi/RX580 Unigine_Heaven-4.0, Unigine_Valley-1.0, Unigine_Superposition-1.0, LS2015 (Wine-staging), Mesa-demos (objviewer) Dieter Am 22.05.2017 20:55, schrieb Thomas Helland: While this doesn't prehash all the things,

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On Mon, May 22, 2017 at 5:47 PM, Mike Lothian wrote: > I'm quite sure on Gentoo lib points to lib64 and we have a lib32 I'm talking about Android. > > On Mon, 22 May 2017 at 22:46 Rob Herring wrote: >> >> On Mon, May 22, 2017 at 9:16 AM, Emil Velikov

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On Tue, May 23, 2017 at 12:07 AM, Timothy Arceri wrote: > On 23/05/17 05:02, Marek Olšák wrote: >> >> On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle >> wrote: >>> >>> Hi all, >>> >>> I've been looking into ARB_gl_spirv for radeonsi. I don't fancy >>>

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On Mon, May 22, 2017 at 6:45 PM, Rob Clark wrote: > On Mon, May 22, 2017 at 9:33 PM, Rob Clark wrote: > > On Mon, May 22, 2017 at 9:15 PM, Timothy Arceri > wrote: > >> On 23/05/17 10:44, Marek Olšák wrote: > >>> > >>> On Tue, May

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On Mon, May 22, 2017 at 6:48 PM, Jason Ekstrand wrote: > On Mon, May 22, 2017 at 6:45 PM, Rob Clark wrote: > >> On Mon, May 22, 2017 at 9:33 PM, Rob Clark wrote: >> > On Mon, May 22, 2017 at 9:15 PM, Timothy Arceri

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On 23/05/17 11:45, Rob Clark wrote: On Mon, May 22, 2017 at 9:33 PM, Rob Clark wrote: On Mon, May 22, 2017 at 9:15 PM, Timothy Arceri wrote: On 23/05/17 10:44, Marek Olšák wrote: On Tue, May 23, 2017 at 12:07 AM, Timothy Arceri

Re: [Mesa-dev] [RFC PATCH 28/65] tc: add ARB_bindless_texture support

On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/util/u_threaded_context.c| 147 > + > .../auxiliary/util/u_threaded_context_calls.h | 4 +

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

On 22/05/17 17:29, Eric Anholt wrote: Jose Fonseca writes: I suppose the failures happen with S2TC lib-dxtn implementation. Because I haven't seen them failing with the old implementation, or when no implementation is present (as the tests will just skip.) We could craft

[Mesa-dev] [PATCH] u_format_test: Ignore S3TC errors.

This prevents spurious failures when libtxc-dxtn-s2tc is installed. Note: lp_test_format does need any change since we were already ignoring S3TC failures there. --- src/gallium/tests/unit/u_format_test.c | 25 + 1 file changed, 25 insertions(+) diff --git

Re: [Mesa-dev] [RFC PATCH 29/65] tgsi: add new Bindless flag to tgsi_instruction_texture

On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > Old-style images are identified using TGSI_FILE_SAMPLER, but > bindless samplers can be TGSI_FILE_CONSTANT or TGSI_FILE_TEMPORARY. > > To avoid backend compilers to be confused, this adds a new flag > that will

Re: [Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat wrote: > These declarations will help the code start compiling > once we wire up the makefiles for gen10. Later patches > will start using these functions for gen10. > > Signed-off-by: Anuj Phogat > --- >

Re: [Mesa-dev] [PATCH 1/3] etnaviv: Add support for extended texture formats

> Thx - will send out updated patches the next days. I quite busy with > lot of stuff atm but > a long weekend is coming :) Yeah np I could update my patches to that too and re-send them if that is more convenient, Wladimir ___ mesa-dev mailing list

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #7 from raffa...@zoho.com --- ah, I'm on git://anongit.freedesktop.org/mesa/mesa , I'll try iXit then -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

This fixes WoW for me Thanks On Mon, 22 May 2017 at 00:18 wrote: > *Comment # 4 on > bug 101088 from Axel > Davy * > > Should be

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

On 05/20/2017 09:01 PM, Nicolai Hähnle wrote: On 19.05.2017 18:52, Samuel Pitoiset wrote: Hi, This series implements ARB_bindless_texture for RadeonSI. Reminder: the GLSL compiler part is already upstream. This series has been mainly tested with Feral games, here's the list of existing

Re: [Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

On 05/22/2017 01:26 AM, Roland Scheidegger wrote: Clearly, you forgot the doc bits... Yes, some doc bits could be helpful. :) Roland Am 19.05.2017 um 18:52 schrieb Samuel Pitoiset: Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_context.h | 16

Re: [Mesa-dev] [PATCH v13 32/36] i965: Remove scanout restriction from lossless compression

On Fri, May 19, 2017 at 10:38:15AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > v2: Try to keep the assert as recommended by Topi. This requires > modifying the num_samples check to be <= 1 because internally created > buffers set num_samples = 0. > > v3: Buffers are

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #6 from Axel Davy --- It applies well for me on master. You can also find the patch here: https://github.com/iXit/Mesa-3D -- You are receiving this mail because: You are the assignee for the bug. You are the

Re: [Mesa-dev] [PATCH v13 20/36] i965/miptree: Allocate mcs_buf for an image's CCS_E

On Fri, May 19, 2017 at 10:38:03AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > This code will disable actually creating these buffers for the scanout, > but it puts the allocation in place. > > Primarily this patch is split out for review, it can be squashed in >

Re: [Mesa-dev] [PATCH 1/3] radeonsi: move building llvm.SI.load.const into ac_build_buffer_load

On 19.05.2017 17:54, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 50 src/amd/common/ac_llvm_build.h | 3 +- src/amd/common/ac_nir_to_llvm.c | 2 +-

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] radeonsi: load patch_id for TES-as-ES when exporting for PS

Hi Emil, I'm not actually aware of a real application affected by this. I noticed it while fixing a corner case for the CTS, and there's a piglit test for it now, but even the CTS isn't affected. So to be honest I'd just drop this patch from stable. Cheers, Nicolai On 18.05.2017 19:52,

Re: [Mesa-dev] [PATCH v13 30/36] i965: Use partial resolves for CCS buffers being scanned out

On Fri, May 19, 2017 at 10:38:13AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > On Gen9 hardware, the display engine is able to scanout a compressed > framebuffer by providing an offset to auxiliary compression information. > Unfortunately, the hardware is incapable of

Re: [Mesa-dev] [PATCH v2] drirc: Add allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition

Reviewed-by: Samuel Pitoiset On 05/21/2017 11:46 PM, Benedikt Schemmer wrote: From: Benedikt Schemmer This patch sets the allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition. Tested with Mesa git as of today and

Re: [Mesa-dev] [PATCH v4 3/4] egl: implement __DRIbackgroundCallableExtension.isThreadSafe

Hi Gregory, On 21 May 2017 at 15:59, Gregory Hainaut wrote: > +static GLboolean > +dri_is_thread_safe(void *loaderPrivate) > +{ > +#ifdef HAVE_X11_PLATFORM > + struct dri2_egl_surface *dri2_surf = loaderPrivate; > + _EGLDisplay *display =

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

I suppose the failures happen with S2TC lib-dxtn implementation. Because I haven't seen them failing with the old implementation, or when no implementation is present (as the tests will just skip.) We could craft the test cases so they aren't sensitive to S2TC. On the other hand the patent

[Mesa-dev] Please dont remove support for working hardware

I have read on https://phoronix.com/scan.php?page=news_item=Mesa-2017-Cleanup-Discussion that there is a discussion about removing still working hardware. Please fix the problems instead. Please, dont remove support for

Re: [Mesa-dev] [PATCH v13 02/36] egl/main: add support for fourth plane tokens

Hey, On 22 May 2017 at 13:43, Emil Velikov wrote: > On 19 May 2017 at 10:37, Daniel Stone wrote: >> The EGL_EXT_dma_buf_import_modifiers extension adds support for a >> fourth plane, just like DRM KMS API does. >> >> Bump maximum dma_buf plane

[Mesa-dev] [PATCH] glsl: Fix g++ initializer order warning

Fixes this warning: In file included from ../../../src/compiler/glsl/ir.cpp:25:0: ../../../src/compiler/glsl/ir.h: In constructor 'ir_swizzle::ir_swizzle(ir_rvalue*, ir_swizzle_mask)': ../../../src/compiler/glsl/ir.h:1955:20: warning: 'ir_swizzle::mask' will be initialized after [-Wreorder]

Re: [Mesa-dev] [PATCH v13 08/36] egl: advertise EGL_EXT_image_dma_buf_import_modifiers

On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Varad Gautam > > Signed-off-by: Varad Gautam > Reviewed-by: Daniel Stone > Signed-off-by: Daniel Stone > --- >

Re: [Mesa-dev] [PATCH] egl/wayland: verify event queue was allocated

On 22 May 2017 at 12:16, Daniel Stone wrote: > On 22 May 2017 at 11:07, Lionel Landwerlin > wrote: >> We're already verified that 'window' wasn't NULL, I'm guess this >> allocation error is about the newly created queue. > > Reviewed-by:

Re: [Mesa-dev] [PATCH v13 02/36] egl/main: add support for fourth plane tokens

On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Pekka Paalanen > > The EGL_EXT_dma_buf_import_modifiers extension adds support for a > fourth plane, just like DRM KMS API does. > > Bump maximum dma_buf plane count to four. > > v2:

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #9 from Hleb Valoshka <375...@gmail.com> --- Hi Axel, I've tested your patch with Unigine Heaven, HL2 mod Metastasis and STALKER: Shadows of Chernobyl. Everything is fine, no glitches, no crashes. -- You are receiving this mail

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #5 from raffa...@zoho.com --- Sorry but I can't manage to apply this patch, which branch/commit it's supposed to be applied on? (tried on master) patching file src/gallium/state_trackers/nine/device9.c Hunk #1 succeeded at 2915 with

Re: [Mesa-dev] [PATCH v13 31/36] i965/miptree: Remove dead code assertion

On Fri, May 19, 2017 at 10:38:14AM +0100, Daniel Stone wrote: > From: Ben Widawsky > > We no longer allocate a miptree for the mcs_buf, so this is not a useful > assertion. > > While here, move the CCS disabling so that we only conditionally shut it > off. This helps us dtrt

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

Hi Dan, On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Varad Gautam > > query and return supported dmabuf format modifiers for > EGL_EXT_image_dma_buf_import_modifiers. > > v2: move format check to the driver instead of making format queries >

Re: [Mesa-dev] [PATCH v4 4/4] glthread/gallium: require safe_glthread to start glthread

Hi Gregory, A minor nit below and this that the series is Reviewed-by: Emil Velikov On 21 May 2017 at 15:59, Gregory Hainaut wrote: > Print an error message for the user if the requirement isn't met, or > we're not thread safe. > > v2:

Re: [Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

On Sun, May 21, 2017 at 10:49 PM, Thomas Helland wrote: > From: Vladislav Egorov > > strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" > only if the identifier starts with '_', which is rare. > > Reviewed-by: Ian Romanick > ---

Re: [Mesa-dev] [PATCH] etnaviv: Don't try to use the index buffer if size is zero

Am Freitag, den 19.05.2017, 12:40 +0200 schrieb Tomeu Vizoso: > If info->index_size is zero, info->index will point to uninitialized > memory. > > Fatal signal 11 (SIGSEGV), code 2, fault addr 0xab5d07a3 in tid 20456 > (surfaceflinger) > > Signed-off-by: Tomeu Vizoso

[Mesa-dev] [Bug 100741] Chromium - Memory leak

https://bugs.freedesktop.org/show_bug.cgi?id=100741 Gary Wang changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] r600: fix compilation error without amdgpu

This fixes the following compilation error when amdgpu is not selected. CC common/common_libamd_common_la-ac_gpu_info.lo In file included from common/ac_gpu_info.c:26:0: common/ac_gpu_info.h:31:10: fatal error: amdgpu.h: No such file or directory #include ^~

Re: [Mesa-dev] [PATCH 2/3] i965: Use the upload BO for push constants on Gen9+.

Hi, On 13.05.2017 22:26, Kenneth Graunke wrote: Shaders can use quite a bit of uniform data. Better to put it in the upload buffers, like we do for client vertex data, rather than the batch buffer state area, which is primarly used for indirect state. This should free up batch space, allowing

  1   2   >