Re: [Mesa-dev] [PATCH] ttn: Fix out-of-bounds accesses since the always-2D-constants change.

On 07.09.2017 19:17, Eric Anholt wrote: Only one of the three checks for dim was updated, so we would try to set a UBO buffer index source value on a nir_load_uniform, and wouldn't actually declare non-UBO uniforms. Fixes: 37dd8e8dee1d ("gallium: all drivers should accept two-dimensional

Re: [Mesa-dev] [PATCH 2/3] winsys/amdgpu: implement sync_file import/export

This will need a bump of the libdrm version requirements, right? Apart from that and a minor comment on patch 3, the series is Reviewed-by: Nicolai Hähnle On 12.09.2017 22:50, Marek Olšák wrote: From: Marek Olšák syncobj is used internally for

[Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

From: Nicolai Hähnle The NIR-to-LLVM pass already does this; now the same fix covers radeonsi as well. Fixes various tests of dEQP-GLES31.functional.texture.filtering.cube_array.combinations.* Cc: mesa-sta...@lists.freedesktop.org --- src/amd/common/ac_llvm_build.c

[Mesa-dev] [PATCH 3/5] amd/common: add chip_class to ac_llvm_context

From: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 5 - src/amd/common/ac_llvm_build.h | 7 ++- src/amd/common/ac_nir_to_llvm.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 2

[Mesa-dev] [PATCH 1/5] radeonsi: workaround for gather4 on integer cube maps

From: Nicolai Hähnle This is the same workaround that radv already applied in commit 3ece76f03dc0 ("radv/ac: gather4 cube workaround integer"). Fixes dEQP-GLES31.functional.texture.gather.basic.cube.rgba8i/ui.* Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

From: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 3 +-- src/amd/common/ac_llvm_build.h | 1 - src/amd/common/ac_nir_to_llvm.c | 5 + src/gallium/drivers/radeonsi/si_pipe.c | 1 - src/gallium/drivers/radeonsi/si_pipe.h | 1 -

[Mesa-dev] [PATCH 0/5] ac, radeonsi: workarounds for various cubemap issues

Hi all, Clearly, the Vulkan CTS inherited the thoroughness of dEQP's ES tests in this area, because the first two fixes were already done for radv. The last fix is for a quite amusing issue. One of the dEQP tests chooses a viewport pseudo-randomly for rendering a sqare. With some of the

Re: [Mesa-dev] [PATCH v2 1/2] gallium: Add PIPE_SHADER_CAP_FP16

On 08.09.2017 00:03, Jan Vesely wrote: Denotes native half precision float operations capability v2: PIPE_CAP_HALFS -> PIPE_SHADER_CAP_FP16 fix indentation Signed-off-by: Jan Vesely Reviewed-by: Nicolai Hähnle --- I modeled this after

Re: [Mesa-dev] [RFC] NIR serialization

On Wed, Sep 13, 2017 at 8:42 AM, Nicolai Hähnle wrote: > On 13.09.2017 11:54, Eero Tamminen wrote: > >> Hi, >> >> On 12.09.2017 09:55, Jordan Justen wrote: >> >>> On 2017-09-11 21:44:32, Timothy Arceri wrote: >>> On 12/09/17 14:23, Ian Romanick wrote: > On

[Mesa-dev] [Bug 102564] swr: GPU Caps Viewer crashes with any 3D demo

https://bugs.freedesktop.org/show_bug.cgi?id=102564 --- Comment #5 from George Kyriazis --- Thanks Alex for the information on the dlls. While OpenSWR does not do anything special to explicitly disable 32-bit support, our team is not testing / developing on 32-bit.

Re: [Mesa-dev] [PATCH] radv: fix possible GPU hangs by zeroing the descriptor set

On 08.09.2017 16:42, Bas Nieuwenhuizen wrote: On Fri, Sep 8, 2017 at 4:30 PM, Samuel Pitoiset wrote: On 09/08/2017 04:08 PM, Józef Kucia wrote: On Fri, Sep 8, 2017 at 2:43 PM, Samuel Pitoiset wrote: when an application doesn't update

Re: [Mesa-dev] [PATCH] radv: fix possible GPU hangs by zeroing the descriptor set

On 09/13/2017 05:10 PM, Nicolai Hähnle wrote: On 08.09.2017 16:42, Bas Nieuwenhuizen wrote: On Fri, Sep 8, 2017 at 4:30 PM, Samuel Pitoiset wrote: On 09/08/2017 04:08 PM, Józef Kucia wrote: On Fri, Sep 8, 2017 at 2:43 PM, Samuel Pitoiset

Re: [Mesa-dev] [PATCH] util: Query build-id by symbol address, not library name

On Tue 12 Sep 2017, Matt Turner wrote: > On Tue, Sep 12, 2017 at 5:05 PM, Chad Versace wrote: > > This patch renames build_id_find_nhdr() to > > build_id_find_nhdr_for_addr(), and changes it to never examine the > > library name. > > > > Tested on Fedora by confirming that

Re: [Mesa-dev] [PATCH 1/5] util: Add a string buffer implementation

Thank you for doing all the cleanup work! Two small issues that I could still find: On 11.09.2017 22:21, Thomas Helland wrote: Based on Vladislav Egorovs work on the preprocessor, but split out to a util functionality that should be universal. Setup, teardown, memory handling and general

Re: [Mesa-dev] [PATCH] virgl: drop const dimensions on first block.

On 13.09.2017 01:28, Dave Airlie wrote: From: Dave Airlie The virgl protocol version of tgsi doesn't handle this yet, transform it back to the old ways. Fixes: 41e342d5 tgsi/ureg: always emit constants (and their decls) as 2D Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 3/3] radeonsi: implement sync_file import/export

On Wed, Sep 13, 2017 at 5:39 PM, Nicolai Hähnle wrote: > On 12.09.2017 22:50, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_pipe_common.c | 77 >> ++- >>

Re: [Mesa-dev] [PATCH 2/3] radv: only copy the dynamic states that changed

On Wednesday 13 September 2017, Samuel Pitoiset wrote: > When binding a new pipeline, we applied all dynamic states > without checking if they really need to be re-emitted. This > doesn't seem to be useful for the meta operations because only > the viewports/scissors are updated. > > This should

Re: [Mesa-dev] [PATCH] mesa/st/tests: Correct build flags and force -std=c++11

On 13 September 2017 at 13:42, Gert Wollny wrote: > Am Mittwoch, den 13.09.2017, 13:11 +0100 schrieb Emil Velikov: >> Hi Gert, >> >> On 13 September 2017 at 09:32, Gert Wollny >> wrote: >> > Include src/gallium/Automake.inc, correct the build flags >>

Re: [Mesa-dev] [PATCH 3/3] radeonsi: implement sync_file import/export

On 12.09.2017 22:50, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 77 ++- src/gallium/drivers/radeonsi/si_pipe.c| 4 +- 2 files changed, 79 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

I've changed my mind. The patch is OK: Reviewed-by: Marek Olšák Marek On Wed, Sep 13, 2017 at 4:45 PM, Denis Pauk wrote: > What do you think about replace all checks in patch to asserts? > > > Best regards, > Denis. > > On Sep 13,

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

On Wed, Sep 13, 2017 at 6:03 AM, Andres Gomez wrote: > Jason, this patch landed tagged for mesa-stable but without mentioning > any specific branch. > > For 17.1 it depends on earlier commit 4fab67a4415 which did not land in > the branch so I'm keeping it out. > > I hope this

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

https://bugs.freedesktop.org/show_bug.cgi?id=102682 --- Comment #4 from Nicolai Hähnle --- IMHO, while there is a certain internal logic to it, having to put driver="dri2" here is surprising and bad usability. I'd say this is a valid bug, and should be fixed. -- You are

[Mesa-dev] [PATCH 2/3] radv: only copy the dynamic states that changed

When binding a new pipeline, we applied all dynamic states without checking if they really need to be re-emitted. This doesn't seem to be useful for the meta operations because only the viewports/scissors are updated. This should reduce the number of commands added to the IB when a new graphics

[Mesa-dev] [PATCH 3/3] radv: only emit the depth bounds test values when set dynamically

The depth bounds test values are either set at pipeline creation or dynamically using vkCmdSetDepthBounds(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE

From: Nicolai Hähnle To be able to properly distinguish between GL_ANY_SAMPLES_PASSED and GL_ANY_SAMPLES_PASSED_CONSERVATIVE. This patch goes through all drivers, having them treat the two query types identically, except: 1. radeon incorrectly enabled conservative mode

[Mesa-dev] [PATCH] st/glsl_to_tgsi: fix theoretical memory leak

From: Nicolai Hähnle It can't *really* happen since we don't use subroutines. CID: 1417491 --- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

On 12.09.2017 17:01, Eric Engestrom wrote: The function is only called from one place, which is hidden behind the same `#ifdef DEBUG`. Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" Signed-off-by: Eric Engestrom Is there an alternative way to do that,

Re: [Mesa-dev] [PATCH 3/3] radeonsi: implement sync_file import/export

On 13.09.2017 18:21, Marek Olšák wrote: On Wed, Sep 13, 2017 at 5:39 PM, Nicolai Hähnle wrote: On 12.09.2017 22:50, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 77 ++-

Re: [Mesa-dev] [PATCH] glsl: do not set the 'smooth' qualifier by default on ES shaders

On 12.09.2017 03:33, Timothy Arceri wrote: On 12/09/17 00:57, Nicolai Hähnle wrote: On 11.09.2017 16:47, Ilia Mirkin wrote: On Mon, Sep 11, 2017 at 10:44 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle It breaks integer inputs and outputs on

Re: [Mesa-dev] [RFC] NIR serialization

On 13.09.2017 11:54, Eero Tamminen wrote: Hi, On 12.09.2017 09:55, Jordan Justen wrote: On 2017-09-11 21:44:32, Timothy Arceri wrote: On 12/09/17 14:23, Ian Romanick wrote: On 09/08/2017 01:59 AM, Kenneth Graunke wrote: We shouldn't use SPIR-V for the shader cache. The compilation process

Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

On Wednesday, 2017-09-13 17:24:57 +0200, Nicolai Hähnle wrote: > On 12.09.2017 17:01, Eric Engestrom wrote: > > The function is only called from one place, which is hidden behind > > the same `#ifdef DEBUG`. > > > > Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" > > Signed-off-by: Eric

[Mesa-dev] [PATCH 5/5] amd/common: add workaround for cube map array layer clamping

From: Nicolai Hähnle Fixes dEQP-GLES31.functional.texture.filtering.cube_array.* Cc: mesa-sta...@lists.freedesktop.org --- src/amd/common/ac_llvm_build.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] util/build_id: Include

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] ac/surface: match Z and stencil tile config

Hi Nicolai, I'm doing a final run through the lists for 17.2.1 and doesn't seem like this landed in master. Just a friendly poke, in case it fell through the cracks. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH mesa] swr: use ARRAY_SIZE macro

Regardless of making it a v2, etc. :-) Sorry for the complication of not being able to just accept the original. Reviewed-by: Bruce Cherniak > On Sep 12, 2017, at 8:03 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom

[Mesa-dev] [PATCH] util/build_id: Include

Fix the build for Android Nougat. The dladdr(3) manpage says that is required. On Linux, the build succeeded without it because build_id.c includes which includes . On Android, we must include directly. Fixes: 5c98d382 "util: Query build-id by symbol address, not library name" Cc: Matt Turner

Re: [Mesa-dev] [PATCH 3/5] amd/common: add chip_class to ac_llvm_context

Hi Nicolai, On 13 September 2017 at 18:04, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/amd/common/ac_llvm_build.c | 5 - > src/amd/common/ac_llvm_build.h | 7 ++- >

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

Hi all, On 31 August 2017 at 23:48, Jason Ekstrand wrote: > We are looking up the execution type prior to checking how many sources > we have. This leads to looking for a type for src1 on MOV instructions > which is bogus. On BDW+, the src1 register type overlaps with the

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Could you please commit this changes? I have not found what i need to do next after recieve "approve" for changes in https://www.mesa3d.org/submittingpatches.html#reviewing. Do i need to send new mail with "Reviewed-by: " mark? On Wed, Sep 13, 2017 at 6:36 PM, Marek Olšák

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

Not sure if we'll want to do this, since we'll need to need to effectively revert it anyways when we implement derivatives with DPP (although we'll have to rename has_ds_bpermute to has_dpp...). On Wed, Sep 13, 2017 at 1:04 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle

[Mesa-dev] [Bug 102710] vkCmdBlitImage with arrayLayers > 1 fails

https://bugs.freedesktop.org/show_bug.cgi?id=102710 --- Comment #1 from Bas Nieuwenhuizen --- Do you have a testcase? Could you also tell a bit more about what you do and what happens? Do you use VK_REMAINING_ARRAY_LAYERS? Is the result only the first layer being

[Mesa-dev] [Bug 102710] vkCmdBlitImage with arrayLayers > 1 fails

https://bugs.freedesktop.org/show_bug.cgi?id=102710 Bug ID: 102710 Summary: vkCmdBlitImage with arrayLayers > 1 fails Product: Mesa Version: 17.2 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 3/5] amd/common: add chip_class to ac_llvm_context

On 13.09.2017 19:25, Emil Velikov wrote: Hi Nicolai, On 13 September 2017 at 18:04, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 5 - src/amd/common/ac_llvm_build.h

Re: [Mesa-dev] [PATCH 01/23] vulkan: Import vk_android_native_buffer.h

On Wed 13 Sep 2017, Emil Velikov wrote: > On 2 September 2017 at 09:17, Chad Versace wrote: > > Just as Mesa imports the Khronos Vulkan headers, it should import this > > Android-private Vulkan header too. This guarantees that Mesa will > > continue to build even when

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] ac/surface: match Z and stencil tile config

On 13.09.2017 20:28, Emil Velikov wrote: Hi Nicolai, I'm doing a final run through the lists for 17.2.1 and doesn't seem like this landed in master. Just a friendly poke, in case it fell through the cracks. Are you absolutely sure about that? ;-) Admittedly it's only been ~3 hours since I

[Mesa-dev] [PATCH v2 09/15] i965: Pass screen to intel_batchbuffer_reset().

This will let us access screen->kernel_features in the next patch. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c

[Mesa-dev] [PATCH v2 13/15] i965: Delete BATCH_RESERVED handling.

Now that we can grom the batchbuffer if we absolutely need the extra space, we don't need to reserve space for the final do-or-die ending commands. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 11 +++ src/mesa/drivers/dri/i965/intel_batchbuffer.h | 26 -- 2

[Mesa-dev] [PATCH v2 10/15] i965: Use a separate state buffer, but avoid changing flushing behavior.

Previously, we emitted GPU commands and indirect state into the same buffer, using a stack/heap like system where we filled in commands from the start of the buffer, and state from the end of the buffer. We then flushed before the two met in the middle. Meeting in the middle is fatal, so you

[Mesa-dev] [PATCH v2 14/15] i965: Disentangle batch and state buffer flushing.

We now flush the batch when either the batchbuffer or statebuffer reaches the original intended batch size, instead of when the sum of the two reaches a certain size (which makes no sense now that they're separate buffers). With this change, we also need to update our "are we near the end?"

[Mesa-dev] [PATCH v2 15/15] i965: Print size of validation and relocation lists in INTEL_DEBUG=flush

It's nice to have this information. While we're at it, tweak the formatting to try and vertically align numbers in the common case. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v2 07/15] i965: Split brw_emit_reloc into brw_batch_reloc and brw_state_reloc.

brw_batch_reloc emits a relocation from the batchbuffer to elsewhere. brw_state_reloc emits a relocation from the statebuffer to elsewhere. For now, they do the same thing, but when we actually split the two buffers, we'll change brw_state_reloc to use the state buffer. ---

[Mesa-dev] [PATCH v2 12/15] i965: Make BLORP properly avoid batch wrapping.

We need to set brw->no_batch_wrap to actually avoid flushing in the middle of our BLORP operation, and instead grow the batchbuffer. --- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH v2 11/15] i965: Grow the batch/state buffers if we need space and can't flush.

Previously, we would just assert fail and die in this case. The only safeguard is the "estimated max prim size" checks when starting a draw (or compute dispatch or BLORP operation)...which are woefully broken. Growing is fairly straightforward: 1. Allocate a new larger BO. 2. memcpy the

[Mesa-dev] [PATCH v2 08/15] i965: Prepare INTEL_DEBUG=bat decoding for a separate statebuffer.

We'll need to read from both buffers when decoding state. This also drops the "failed to map" fallback - it's completely useless on LLC systems where we write directly to the mapped BO. It's not that useful on non-LLC systems either. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 110

[Mesa-dev] [PATCH v2 06/15] i965: Refactor relocs into a brw_reloc_list structure.

I'm planning on splitting batch and state into separate buffers, at which point we'll need two relocation lists. In preparation for that, this patch refactors the relocation stuff into a structure we can replicate...which looks a lot like anv_reloc_list. Reviewed-by: Chris Wilson

Re: [Mesa-dev] [PATCH] i965: Implement another VF cache invalidate workaround on Gen8+.

Ken, Looks like this patch never landed upstream? We also need it for CNL. On Mon, Jan 30, 2017 at 10:59 AM, Pohjolainen, Topi wrote: > On Sun, Jan 29, 2017 at 08:24:16PM -0800, Kenneth Graunke wrote: >> ...and provide a better citation for the existing one. >> >>

Re: [Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

On 13.09.2017 22:20, Dave Airlie wrote: On 14 September 2017 at 03:04, Nicolai Hähnle wrote: From: Nicolai Hähnle The NIR-to-LLVM pass already does this; now the same fix covers radeonsi as well. Fixes various tests of

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

On 13 September 2017 at 11:07, Gert Wollny wrote: > Am Dienstag, den 12.09.2017, 17:15 +0100 schrieb Eric Engestrom: >> On Tuesday, 2017-09-12 17:26:43 +0200, Gert Wollny wrote: >> > Am Dienstag, den 12.09.2017, 12:26 +0100 schrieb Emil Velikov: >> > > On 12 September 2017

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

On 13 September 2017 at 20:27, Denis Pauk wrote: > Could you please commit this changes? > > I have not found what i need to do next after recieve "approve" for changes > in https://www.mesa3d.org/submittingpatches.html#reviewing. > Do i need to send new mail with

Re: [Mesa-dev] [PATCH shader-db 3/3] run: add extension_in_string() helper

On 13 September 2017 at 22:13, Matt Turner wrote: > On Mon, Aug 21, 2017 at 3:27 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> memmem() does not attribute what the character after the searched string >> is. Thus

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

On Wed, Sep 13, 2017 at 3:46 PM, Nicolai Hähnle wrote: > On 13.09.2017 20:45, Connor Abbott wrote: >> >> Not sure if we'll want to do this, since we'll need to need to >> effectively revert it anyways when we implement derivatives with DPP >> (although we'll have to

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

On 13.09.2017 20:45, Connor Abbott wrote: Not sure if we'll want to do this, since we'll need to need to effectively revert it anyways when we implement derivatives with DPP (although we'll have to rename has_ds_bpermute to has_dpp...). Is there a reason for not deriving has_dpp from

Re: [Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

On 14 September 2017 at 03:04, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The NIR-to-LLVM pass already does this; now the same fix covers > radeonsi as well. > > Fixes various tests of >

Re: [Mesa-dev] [PATCH 23/23] anv: Implement VK_ANDROID_native_buffer

On Wed 13 Sep 2017, Emil Velikov wrote: > Hi Chad, > > On the topic of keep this in the driver vs separate module - I think > it makes sense to keep it internal. > > Sure radv/others won't be able to reuse the code [that easily], at the > same time it gives greater control and one could make

Re: [Mesa-dev] [PATCH mesa 2/6] dri/radeon: use ARRAY_SIZE macro

Reviewed-by: Ian Romanick On 09/07/2017 03:21 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/mesa/drivers/dri/radeon/radeon_tcl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 23/23] anv: Implement VK_ANDROID_native_buffer

On 13 September 2017 at 22:15, Chad Versace wrote: >> > + >> > +static void UNUSED >> > +static_asserts(void) >> > +{ >> > + STATIC_ASSERT(HWVULKAN_DISPATCH_MAGIC == ICD_LOADER_MAGIC); >> > +} > >> Seems like a left over? With that gone, there should be no need for

Re: [Mesa-dev] [PATCH] radv/ac: bump params array for image atomic comp swap

On 13 September 2017 at 23:36, Andres Gomez wrote: > Hi Dave, > > This patch landed tagged for 17.2 only. Was it, then, not nominated for > 17.1 intentionally ? Actually good point, this one should be in 17.1 as well. Thanks, Dave.

[Mesa-dev] [PATCH v2 03/15] i965: Use a WC map and memcpy for the batch instead of pwrite.

We'd like to eliminate the malloc'd shadow copy eventually, but there are still unresolved performance problems. In the meantime, let's at least get rid of pwrite. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff

[Mesa-dev] [PATCH v2 05/15] i965: Move brw_state_batch code to intel_batchbuffer.c

The batch buffer and state buffer code is fairly tied together, and having it in one .c file will make refactoring easier. Also, drop some commentary above brw_state_batch. The "aperture checking performance hacks" are long since gone, so that paragraph makes little sense at this point. ---

[Mesa-dev] [PATCH v2 01/15] i965: Delete a batch size assertion that isn't very useful.

This assertion prevents you from doing intel_batchbuffer_require_space with a size so huge it won't fit in the batchbuffer. This doesn't seem like a common mistake, and I've never seen the assert to be useful. Soon, I hope to have batches grow, at which point this won't make sense. ---

[Mesa-dev] [PATCH v2 04/15] i965: Drop a useless ret == 0 check.

Prior to the previous patch, we would pwrite the batchbuffer contents, and wanted to skip the execbuffer if that failed. Now that we memcpy, we don't set ret != 0 on failure anymore, so it will always be 0. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 42 +-- 1

[Mesa-dev] [PATCH v2 02/15] i965: Use batch->bo->size in brw_emit_reloc assertion.

This makes the assertion safe against batchbuffers growing. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c index

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

On 13 September 2017 at 21:35, Matt Turner wrote: > On 09/13, Emil Velikov wrote: >> >> As Andres pointed out this commit depends on 4fab67a4415 et al, which >> seems to be missing in 17.1 and 17.2. >> >> I've ported this to 17.2 by moving the brw_inst_src[01]_reg_type() >>

Re: [Mesa-dev] [PATCH shader-db 3/3] run: add extension_in_string() helper

On Mon, Aug 21, 2017 at 3:27 AM, Emil Velikov wrote: > From: Emil Velikov > > memmem() does not attribute what the character after the searched string > is. Thus it will flag even when haystack is "foobar" while we're looking > for "foo". > >

Re: [Mesa-dev] [PATCH 1/3] i965/gen8: Remove unused gen8_emit_3dstate_multisample()

On 09/11, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen Reviewed-by: Matt Turner signature.asc Description: Digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 4/5] amd/common: remove has_ds_bpermute argument from ac_build_ddxy

On 13.09.2017 21:48, Connor Abbott wrote: On Wed, Sep 13, 2017 at 3:46 PM, Nicolai Hähnle wrote: On 13.09.2017 20:45, Connor Abbott wrote: Not sure if we'll want to do this, since we'll need to need to effectively revert it anyways when we implement derivatives with

Re: [Mesa-dev] [PATCH] automake: enable libunwind in `make distcheck'

On 09/11, Emil Velikov wrote: From: Emil Velikov Enable the toggle to catch when the library is missing from the link path. Better to test, fail and address before releasing Mesa ;-) Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/3] intel/blorp/hiz: Always set sample number

On 09/11, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen Patches 2-3 (because I don't know a lot about this code) are Acked-by: Matt Turner Chromium has been disabling HiZ on Braswell for stability reasons (trying to find out more

Re: [Mesa-dev] [PATCH 11/19] anv: Use GNU C empty brace initializer

On 08/29/2017 10:19 AM, Emil Velikov wrote: > On 29 August 2017 at 18:10, Matt Turner wrote: >> On Tue, Aug 29, 2017 at 3:35 AM, Emil Velikov >> wrote: >>> On 29 August 2017 at 11:11, Eric Engestrom >>> wrote: On

Re: [Mesa-dev] [PATCH v2 03/15] i965: Use a WC map and memcpy for the batch instead of pwrite.

On 09/13, Kenneth Graunke wrote: We'd like to eliminate the malloc'd shadow copy eventually, but there are still unresolved performance problems. In the meantime, let's at least get rid of pwrite. I don't know much about this. What is wrong with pwrite, and why is WC better? Does this change

Re: [Mesa-dev] [PATCH] glsl: do not set the 'smooth' qualifier by default on ES shaders

On 14/09/17 01:22, Nicolai Hähnle wrote: On 12.09.2017 03:33, Timothy Arceri wrote: On 12/09/17 00:57, Nicolai Hähnle wrote: On 11.09.2017 16:47, Ilia Mirkin wrote: On Mon, Sep 11, 2017 at 10:44 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

I pushed the patch. Thanks. Marek On Wed, Sep 13, 2017 at 9:27 PM, Denis Pauk wrote: > Could you please commit this changes? > > I have not found what i need to do next after recieve "approve" for changes > in https://www.mesa3d.org/submittingpatches.html#reviewing. > Do i

[Mesa-dev] [PATCH 15/20] anv/image: Refactor creation of aux surfaces (v2)

From: Chad Versace Creation of hiz, ccs, and mcs surfaces was encoded in a large, deep 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into one function per aux type: try_make_hiz_surface() try_make_ccs_surface()

[Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply

Re: [Mesa-dev] [PATCH] i965: Record NOS dependencies for shader programs and only check those.

On 08/22, Kenneth Graunke wrote: Previously, the state upload code listened to a broad set of dirty flags that corresponded to all possible state dependencies for a shader stage. This is somewhat overkill. For example, if a shader has no textures, there is no need to listen to _NEW_TEXTURE.

Re: [Mesa-dev] [PATCH 3/3] glsl: avoid accessing invalid memory after get_variable_being_redeclared()

Nice improvement, I remember being bitten by this in the past! Series is: Reviewed-by: Nicolai Hähnle On 13.09.2017 12:46, Iago Toral Quiroga wrote: After get_variable_being_redeclared() has been called, it is no longer safe to access the original variable pointer,

[Mesa-dev] [PATCH 1/3] radv: store the dynamic state mask into radv_dynamic_state

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- src/amd/vulkan/radv_pipeline.c | 2 +- src/amd/vulkan/radv_private.h| 7 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [Bug 102573] fails to build on armel

https://bugs.freedesktop.org/show_bug.cgi?id=102573 --- Comment #2 from Shmerl --- (In reply to Emil Velikov from comment #1) > I don't have a armel setup handy, so if > anyone anyone can polish/fix the test and send a patch, that would be > appreciated. It might be

[Mesa-dev] [PATCH 13/20] anv/image: Better var names for image-create-info structs

From: Chad Versace Upcoming patches teach vkCreateImage to understand VkNativeBufferANDROID. And much later patches will do the same for whatever VkImageCreateInfo-chained struct imports dma-bufs. And then again for the struct that will be introduced by the inevitable

[Mesa-dev] [PATCH 17/20] anv: Move close(fd) from anv_bo_cache_import to its callers

From: Chad Versace This will allow us to implement VK_ANDROID_native_buffer without dup'ing the fd. We must close the fd in VK_KHR_external_memory_fd, but we should not in VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_allocator.c | 12

[Mesa-dev] [PATCH 16/20] anv: Add field anv_image::bo_is_owned

From: Chad Versace If this flag is set, then the image and it's bo have the same lifetime. vkDestroyImage will release the bo. We need this for VK_ANDROID_native_buffer, because that extension creates the VkImage and imports its memory in the same call, vkCreateImage.

[Mesa-dev] [PATCH 11/20] intel: Add simple logging façade for Android

From: Chad Versace I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). On Android, stdio goes to /dev/null. On Android, remote gdb is even more painful than the usual remote gdb. On Android, nothing works like you expect and debugging is hell. I need

[Mesa-dev] [PATCH 10/20] intel: Move definition of LOG_TAG from header into Makefiles

From: Chad Versace This patch prevents compilation failures in upcoming Android Vulkan patches, failures due to redefinition of LOG_TAG in Android system headers. This patch does not change the value of LOG_TAG. It remains "INTEL-MESA". (I don't like it, though. The

[Mesa-dev] [PATCH 18/20] anv: Add sizeless anv_bo_cache_import()

From: Chad Versace The patch renames anv_bo_cache_import() to anv_bo_cache_import_with_size(); and adds a new variant, anv_bo_cache_import(), that lacks the 'size' parameter. Same as pre-patch, anv_bo_cache_import_with_size() continues to validate the imported size.

[Mesa-dev] [PATCH 19/20] anv: Add func anv_gem_get_tiling()

From: Chad Versace Will use in VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_gem.c | 16 src/intel/vulkan/anv_private.h | 1 + 2 files changed, 17 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index

[Mesa-dev] [PATCH 07/20] anv: Feed vk_android_native_buffer.xml to generators

From: Chad Versace Feed the XML to anv_extensions.py and anv_entrypoints_gen.py. Do it on all platforms, not just Android. Tested on Android and Fedora. We always parse the Android XML, regardless of target platform, to help reduce the chance that people working on

[Mesa-dev] [PATCH 14/20] anv/image: Refactor how tiling is chosen

From: Chad Versace The code that restricts the VkImage's tiling flags, extract it into a new function named choose_isl_tiling_flags(). This reduces the diff in upcoming patches for VK_ANDROID_native_buffer. --- src/intel/vulkan/anv_image.c | 31

[Mesa-dev] [PATCH 12/20] anv: Better support for Android logging (v2)

From: Chad Versace In src/intel/vulkan/*, redirect all instances of printf, vk_error, anv_loge, anv_debug, anv_finishme, anv_perf_warn, anv_assert, and their many variants to the new intel_log functions. I believe I caught them all. The other subdirs of src/intel are

Re: [Mesa-dev] [PATCH v2 01/15] i965: Delete a batch size assertion that isn't very useful.

The series looks good to me. I had a question on 03/15, mostly for clarification in the commit message. The series is Reviewed-by: Matt Turner signature.asc Description: Digital signature ___ mesa-dev mailing list

[Mesa-dev] [PATCH 3/3] glsl: make loop unrolling more like the nir unrolling path

The old code incorrectly assumed that loop terminators will always be at the start of the loop. It really seems to be just luck that we haven't triggered any bugs here, for example if there is a loop terminator at the start of the loop we might actually ignore any other terminators that might be

  1   2   >