Re: [Mesa-dev] [PATCH 3/6] glx/apple: include util/debug.h for env_var_as_boolean prototype

2018-02-02 Thread Emil Velikov
On 2 February 2018 at 10:16, Eric Engestrom wrote: > On Sunday, 2018-01-28 14:18:27 +, Jon Turney wrote: >> mesa/src/glx/glxcmds.c:1295:21: error: implicit declaration of function >> 'env_var_as_boolean' is invalid in C99 >>

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

2018-02-02 Thread Gert Wollny
Am Freitag, den 02.02.2018, 06:56 -0500 schrieb Ilia Mirkin: > On Fri, Feb 2, 2018 at 4:07 AM, Gert Wollny > wrote: > > Am Freitag, den 02.02.2018, 09:04 +0100 schrieb Roland Scheidegger: > > > > > > > > > Yes, the _GL spec_ says it is an array. > > > But in gallium it

[Mesa-dev] [Bug 104374] Cemu 1.11.1 via Wine using Mesa Mild exposes LLVM AMDGPU bugs on RX Vega..

2018-02-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104374 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 3/6] glx/apple: include util/debug.h for env_var_as_boolean prototype

2018-02-02 Thread Emil Velikov
On 2 February 2018 at 10:16, Eric Engestrom wrote: > On Sunday, 2018-01-28 14:18:27 +, Jon Turney wrote: >> mesa/src/glx/glxcmds.c:1295:21: error: implicit declaration of function >> 'env_var_as_boolean' is invalid in C99 >>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-02 Thread Tomasz Figa
On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: > On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: >> Hi Rob, >> >> On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss >> wrote: uint32_t (*get_fd)(buffer_handle_t

Re: [Mesa-dev] [PATCH 1/4] glx/test: fix building for osx

2018-02-02 Thread Emil Velikov
On 1 February 2018 at 17:48, Jon Turney wrote: > An additional stub for applegl_create_context() is needed > Cannot test indirect API as it's not built on osx, currently > > Signed-off-by: Jon Turney > --- >

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

2018-02-02 Thread Ilia Mirkin
On Fri, Feb 2, 2018 at 4:07 AM, Gert Wollny wrote: > Am Freitag, den 02.02.2018, 09:04 +0100 schrieb Roland Scheidegger: >> >> >> Yes, the _GL spec_ says it is an array. >> But in gallium it can't be. Therefore I think it's incorrect if we >> end up with array accesses there

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

2018-02-02 Thread Ilia Mirkin
On Fri, Feb 2, 2018 at 7:55 AM, Gert Wollny wrote: > Am Freitag, den 02.02.2018, 06:56 -0500 schrieb Ilia Mirkin: >> On Fri, Feb 2, 2018 at 4:07 AM, Gert Wollny >> wrote: >> > Am Freitag, den 02.02.2018, 09:04 +0100 schrieb Roland Scheidegger: >> > >

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-02 Thread Rob Herring
On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: > Hi Rob, > > On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss > wrote: >>> uint32_t (*get_fd)(buffer_handle_t handle, uint32_t plane); >>> uint64_t (*get_modifier)(buffer_handle_t

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for HEVC encode

2018-02-02 Thread Zhang, Boyuan
The whole series are the updated version. Changes are made mainly based on the comments from previous code review, plus fixing a few typos. -Original Message- From: Zhang, Boyuan Sent: February-02-18 11:11 AM To: mesa-dev@lists.freedesktop.org Cc: Zhang, Boyuan Subject: [PATCH 01/12]

Re: [Mesa-dev] [PATCH] r600: fix resq for buffer images.

2018-02-02 Thread Roland Scheidegger
Am 02.02.2018 um 08:29 schrieb Dave Airlie: > From: Dave Airlie > > If this is an image buffer, we need to calculate the correct resource > id. > > Fixes: > KHR-GL45.shader_image_size.* > > Signed-off-by: Dave Airlie > --- >

[Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Marek Olšák
From: Marek Olšák Only these are supported: - LLVM 4.0 - LLVM 5.0 - LLVM 6.0 - master (7.0) --- configure.ac | 4 +- src/amd/common/ac_llvm_build.c | 187 ++--- src/amd/common/ac_llvm_helper.cpp

Re: [Mesa-dev] [PATCH] r600/fp64: fix integer->double conversion

2018-02-02 Thread Roland Scheidegger
Am 02.02.2018 um 05:56 schrieb Dave Airlie: > From: Dave Airlie > > Doing a straight uint/int->fp32->fp64 conversion causes > some precision issues, Roland suggested splitting the > integer into two portions and doing two separate > int->fp32->fp64 conversions then adding the

Re: [Mesa-dev] [PATCH] radv: Don't expose VK_KHX_multiview on android.

2018-02-02 Thread Emil Velikov
Hi Bas, On 31 January 2018 at 11:31, Bas Nieuwenhuizen wrote: > deqp does not allow any KHX extensions, and since deqp is included > in android-cts, android does not allow any khx extensions. > > So disable VK_KHX_multiview on android. > --- >

[Mesa-dev] [PATCH] autotools: Only build libmesa-st-tests-common.a for tests.

2018-02-02 Thread Bas Nieuwenhuizen
We don't need the library if we don't build tests, and building it adds a dependency on gtest which adds a dependency on cxxabi.h. Fixes: 6569b33b6e "mesa/st/tests: unify MockCodeLine* classes" --- src/mesa/state_tracker/tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH] radv: enable lowering of fpow to fexp2 and flog2

2018-02-02 Thread Samuel Pitoiset
There is no fpow in hardware, so it's always lowered somewhere, but it appears that lowering at NIR level is better. Figured while comparing compute shaders between RadeonSI and RADV. Polaris10: Totals from affected shaders: SGPRS: 18936 -> 18904 (-0.17 %) VGPRS: 12240 -> 12220 (-0.16 %) Spilled

Re: [Mesa-dev] [PATCH] radv: Don't expose VK_KHX_multiview on android.

2018-02-02 Thread Bas Nieuwenhuizen
On Fri, Feb 2, 2018 at 6:59 PM, Emil Velikov wrote: > Hi Bas, > > On 31 January 2018 at 11:31, Bas Nieuwenhuizen wrote: >> deqp does not allow any KHX extensions, and since deqp is included >> in android-cts, android does not allow any khx

[Mesa-dev] [PATCH 06/12] st/va: move H264 enc functions into separate file

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Move all H264 encode related functions into separate file. Similar to VAAPI decode side, there will be separate file for each codec on encode side as well. Signed-off-by: Boyuan Zhang Acked-by: Christian König

[Mesa-dev] [PATCH 05/12] radeon/vcn: add header implementations for HEVC

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Implement encoding of sps, pps, vps, aud, and slice headers for HEVC based on HEVC specs. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 348

[Mesa-dev] [PATCH 02/12] radeon/vcn: add vcn encode interface for HEVC

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Add vcn encode interface for HEVC, and rename radeon_enc_h264_enc_pic to radeon_enc_pic since radeon_enc_pic is used by both H264 and HEVC. Signed-off-by: Boyuan Zhang Acked-by: Christian König ---

[Mesa-dev] [PATCH 03/12] radeon/vcn: support picture parameters for HEVC

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Pass pipe_picture_desc instead of pipe_h264_enc_picture_desc so that it can be used for different codecs. Add functions to handle picture parameters that will be used for HEVC encode. Signed-off-by: Boyuan Zhang Acked-by: Christian

[Mesa-dev] [PATCH 07/12] st/va: add HEVC picture desc

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Add HEVC picture desc, and add codec check when creating and destroying context. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/state_trackers/va/context.c| 26

Re: [Mesa-dev] [PATCH] r600: don't do stack workarounds for hemlock

2018-02-02 Thread Roland Scheidegger
Am 02.02.2018 um 12:16 schrieb Emil Velikov: > Hi Roland, > > On 30 January 2018 at 05:07, wrote: >> From: Roland Scheidegger >> >> By the looks of it it seems hemlock is treated separately to cypress, but >> certainly it won't need the stack workarounds

[Mesa-dev] [PATCH 01/12] vl: add parameters for HEVC encode

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Add HEVC encode interface Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/include/pipe/p_video_state.h | 99 1 file changed, 99 insertions(+) diff

[Mesa-dev] [PATCH] ac/nir: fix a crash in load_gs_input() on pre-GFX9 chips

2018-02-02 Thread Samuel Pitoiset
Fixes: df1d5174fcc ("ac/nir: replace SI.buffer.load.dword with amdgcn.buffer.load") Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH] ac/nir: fix a crash in load_gs_input() on pre-GFX9 chips

2018-02-02 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 2, 2018 at 6:56 PM, Samuel Pitoiset wrote: > Fixes: df1d5174fcc ("ac/nir: replace SI.buffer.load.dword with > amdgcn.buffer.load") > Signed-off-by: Samuel Pitoiset > ---

[Mesa-dev] [Bug 104915] Indexed SHADING_LANGUAGE_VERSION query not supported

2018-02-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104915 Bug ID: 104915 Summary: Indexed SHADING_LANGUAGE_VERSION query not supported Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity:

[Mesa-dev] [PATCH 04/12] radeon/vcn: add ib implementations for HEVC

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Implement required ibs for vcn HEVC encode. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 267 1 file changed, 222

[Mesa-dev] [PATCH 10/12] st/va: add HEVC encode functions

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Add a separate file for HEVC encode functions. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/meson.build

[Mesa-dev] [PATCH 09/12] st/va: enable dual instances encode only for H264

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Logics that related to dual instances encode should only be done for H264, not other codecs. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/state_trackers/va/picture.c | 3 ++-

[Mesa-dev] [PATCH 08/12] st/va: add entrypoint check for HEVC

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Add entrypoint check for HEVC to differentiate decode and encode jobs. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/state_trackers/va/context.c | 22 -- 1

[Mesa-dev] [PATCH 12/12] radeonsi: enable vcn encode for HEVC main

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Enable vcn encode for HEVC main profile on Raven. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/drivers/radeonsi/si_get.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 11/12] st/va: implement HEVC encode functions

2018-02-02 Thread boyuan.zhang
From: Boyuan Zhang Implement HEVC encode functions based on VAAPI HEVC encode interface. Signed-off-by: Boyuan Zhang Acked-by: Christian König --- src/gallium/state_trackers/va/picture_hevc_enc.c | 150

[Mesa-dev] [PATCH 1/7] gallium: allow drivers to impose BO flags restrictions on constant buffer 0

2018-02-02 Thread Marek Olšák
From: Marek Olšák Required by radeonsi for optimal behavior. --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c

[Mesa-dev] [PATCH 6/7] winsys/radeon: add struct radeon_vm_heap

2018-02-02 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Samuel Pitoiset --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 63 --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 9 ++-- src/gallium/winsys/radeon/drm/radeon_drm_winsys.h | 11

[Mesa-dev] [PATCH 5/7] winsys/amdgpu: enable 32-bit VM allocations

2018-02-02 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c

[Mesa-dev] [PATCH 3/7] ac: query high bits of 32-bit address space

2018-02-02 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 7 +++ src/amd/common/ac_gpu_info.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 6d9dcb5..b5b059e 100644 --- a/src/amd/common/ac_gpu_info.c

[Mesa-dev] [PATCH 7/7] winsys/radeon: implement and enable 32-bit VM allocations

2018-02-02 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Samuel Pitoiset --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 42 +++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 28 ++-

[Mesa-dev] [PATCH 2/7] gallium: use PIPE_CAP_CONSTBUF0_FLAGS

2018-02-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_inlines.h | 21 + src/gallium/auxiliary/vl/vl_compositor.c| 2 +- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/state_trackers/xa/xa_renderer.c | 7 --- 4 files changed,

[Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Marek Olšák
Hi, This is the second and hopefully final version of 32-bit pointer support for radeonsi. Constant buffer 0 now has restrictions on which buffers can be set in that slot. I plan to push this when my LLVM patch lands in 6.0 (hopefully it will be accepted there). There will also be a dependency

Re: [Mesa-dev] [PATCH] radv: Don't expose VK_KHX_multiview on android.

2018-02-02 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-02-02 10:14:04) > On Fri, Feb 2, 2018 at 6:59 PM, Emil Velikov wrote: > > Hi Bas, > > > > On 31 January 2018 at 11:31, Bas Nieuwenhuizen wrote: > >> deqp does not allow any KHX extensions, and since deqp is included >

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Dylan Baker
FYI: I sent out a patch a few minutes ago to set the minimum version more like autotools does, but I'm fine with this landing first. Reviewed-by: Dylan Baker Quoting Marek Olšák (2018-02-02 11:07:57) > Adding this: > > diff --git a/meson.build b/meson.build > index

Re: [Mesa-dev] [PATCH] meson: Check for actual LLVM required versions

2018-02-02 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 2, 2018 at 7:55 PM, Dylan Baker wrote: > Currently we always check for 3.9.0, which is pretty safe since > everything except radv work with >= 3.9 and 3.9 is pretty old at this > point. However, radv

[Mesa-dev] [PATCH 4/7] gallium/radeon: add 32-bit address space heaps

2018-02-02 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Samuel Pitoiset --- src/gallium/drivers/radeon/radeon_winsys.h | 47 -- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h

Re: [Mesa-dev] [PATCH] radv: Don't expose VK_KHX_multiview on android.

2018-02-02 Thread Bas Nieuwenhuizen
On Fri, Feb 2, 2018 at 10:31 PM, Dylan Baker wrote: > Quoting Bas Nieuwenhuizen (2018-02-02 10:14:04) >> On Fri, Feb 2, 2018 at 6:59 PM, Emil Velikov >> wrote: >> > Hi Bas, >> > >> > On 31 January 2018 at 11:31, Bas Nieuwenhuizen

[Mesa-dev] [PATCH] meson: Check for actual LLVM required versions

2018-02-02 Thread Dylan Baker
Currently we always check for 3.9.0, which is pretty safe since everything except radv work with >= 3.9 and 3.9 is pretty old at this point. However, radv actually requires 4.0, and there is a patch for radeonsi to do the same. Fixes: 673dda833076 ("meson: build "radv" vulkan driver for radeon

Re: [Mesa-dev] [PATCH] autotools: Only build libmesa-st-tests-common.a for tests.

2018-02-02 Thread Gert Wollny
Thanks, my automake knowledge is a bit rusty so that I didn't know about this option to limit the build to "make check". Reviewed-By: Gert Wollny Am Freitag, den 02.02.2018, 16:59 +0100 schrieb Bas Nieuwenhuizen: > We don't need the library if we don't build tests, and

[Mesa-dev] [PATCH 9/7] radeonsi: disallow constant buffers with a 64-bit address in slot 0

2018-02-02 Thread Marek Olšák
From: Marek Olšák State trackers must use a user buffer or const_uploader, or set pipe_resource::flags same as const_uploader->flags. Reviewed-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 6 ++

[Mesa-dev] [PATCH 8/7] radeonsi: move const_uploader allocations to 32-bit address space

2018-02-02 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Samuel Pitoiset --- Continuation of the 32-bit pointer series. src/gallium/drivers/radeon/r600_buffer_common.c | 3 +++ src/gallium/drivers/radeon/r600_pipe_common.c | 5 +++--

[Mesa-dev] [PATCH 10/7] radeonsi: implement 32-bit pointers in user data SGPRs (v2)

2018-02-02 Thread Marek Olšák
From: Marek Olšák SGPRS: 2170102 -> 2158430 (-0.54 %) VGPRS: 1645656 -> 1641516 (-0.25 %) Spilled SGPRs: 9078 -> 8810 (-2.95 %) Spilled VGPRs: 130 -> 114 (-12.31 %) Scratch size: 1508 -> 1492 (-1.06 %) dwords per thread Code Size: 52094872 -> 52692540 (1.15 %) bytes Max

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Roland Scheidegger
Am 02.02.2018 um 21:48 schrieb Marek Olšák: > Hi, > > This is the second and hopefully final version of 32-bit pointer > support for radeonsi. > > Constant buffer 0 now has restrictions on which buffers can be set > in that slot. > > I plan to push this when my LLVM patch lands in 6.0

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Dylan Baker
I went ahead and pushed my patch, the only things you should need to do for the meson side now is move with_gallium_radeonsi, and remove the stray `s` in the error message. Dylan Quoting Bas Nieuwenhuizen (2018-02-02 11:56:26) > I'd prefer if Dylan's patch goes first, as we are bumping swr too

Re: [Mesa-dev] [PATCH] meson: Check for actual LLVM required versions

2018-02-02 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-02-02 11:54:58) > Reviewed-by: Bas Nieuwenhuizen > > On Fri, Feb 2, 2018 at 7:55 PM, Dylan Baker wrote: > > Currently we always check for 3.9.0, which is pretty safe since > > everything except radv work with >= 3.9

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Marek Olšák
Adding this: diff --git a/meson.build b/meson.build index 80ea60f..22eb702 100644 --- a/meson.build +++ b/meson.build @@ -991,12 +991,12 @@ endif _llvm = get_option('llvm') if _llvm == 'auto' dep_llvm = dependency( -'llvm', version : '>= 3.9.0', modules : llvm_modules, +'llvm',

[Mesa-dev] [PATCH v3 4/9] meson: Actually link xvmc target with libxvmc

2018-02-02 Thread Dylan Baker
Unlike vdpau this is required. Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") Signed-off-by: Dylan Baker --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index 2df2497..4f280d9 100644 --- a/meson.build

[Mesa-dev] [PATCH v3 1/9] meson: use va-api version reported by pkg-config

2018-02-02 Thread Dylan Baker
Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") Signed-off-by: Dylan Baker --- meson.build | 2 +- src/gallium/state_trackers/va/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build

[Mesa-dev] [PATCH v3 3/9] meson: actually link with libomxil-bellagio

2018-02-02 Thread Dylan Baker
This state tracker actually needs to link, unlike vdpau. Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") Signed-off-by: Dylan Baker --- meson.build | 5 - 1 file changed, 5 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v3 2/9] meson: link dri3 xcb libs into vlwinsys instead of into each target

2018-02-02 Thread Dylan Baker
This makes the dependencies easier to manage, since each media target doesn't need to worry about linking to half a dozen libraries. Fixes: b1b65397d0c4978e3 ("meson: Build gallium auxiliary") Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build|

[Mesa-dev] [PATCH v3 5/9] meson: fix vdpau target linkage

2018-02-02 Thread Dylan Baker
The VDPAU state tracker needs to be linked with whole-archive (autotools does this). Because we are linking the whole archive we alos need to link with libswdri and libswkmsdri if those have been enabled. Fixes: 68076b87474e7959 ("meson: build gallium vdpau state tracker") Signed-off-by: Dylan

[Mesa-dev] [PATCH v3 6/9] meson: fix va target linkage

2018-02-02 Thread Dylan Baker
The state tracker needs to be linked with whole-archive (like autotools). As a result there are symbols from libswdri and libswkmsdri that are needed, so link those as well. Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH v3 0/9] meson: fix gallium media target linkage

2018-02-02 Thread Dylan Baker
The linkage of all of the gallium media targets is broken in various ways in the meson build. This series should correct that by doing more what the autotools build does. You may note in the last 5 patches the addition of libswdri and libswkmsdri, these are needed because we're now linking the

[Mesa-dev] [PATCH v3 7/9] meson: Fix omx-bellagio target linkage

2018-02-02 Thread Dylan Baker
This needs to use --whole-archive (link_whole in meson) to properly expose symbols. Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/omx-bellagio/meson.build | 13 +++-- 1 file changed, 11

[Mesa-dev] [PATCH v3 8/9] meson: Fix xa target linkage

2018-02-02 Thread Dylan Baker
This needs to use --whole-archive (link_whole in meson) to properly expose symbols. Fixes: 0ba909f0f111824 ("meson: build gallium xa state tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/xa/meson.build | 13 +++-- 1 file changed, 11 insertions(+), 2

[Mesa-dev] [PATCH v3 9/9] meson: fix xvmc target linkage

2018-02-02 Thread Dylan Baker
This needs to link the state tracker with --whole-archive to expose the right symbols. Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/xvmc/meson.build | 13 +++-- 1 file changed, 11

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Marek Olšák
This series actually has 10 patches. See 8/7, 9/7, 10/7. Marek On Fri, Feb 2, 2018 at 9:48 PM, Marek Olšák wrote: > Hi, > > This is the second and hopefully final version of 32-bit pointer > support for radeonsi. > > Constant buffer 0 now has restrictions on which buffers can

Re: [Mesa-dev] [PATCH v2 20/24] anv/cmd_buffer: Rework aux tracking

2018-02-02 Thread Nanley Chery
On Fri, Jan 19, 2018 at 03:47:37PM -0800, Jason Ekstrand wrote: > This commit completely reworks aux tracking. This includes a number of > somewhat distinct changes: > > 1) Since we are no longer fast-clearing multiple slices, we only need > to track one fast clear color and one fast clear

Re: [Mesa-dev] [PATCH 1/2] i965: Add copy param to brw_cache_new_bo

2018-02-02 Thread Kenneth Graunke
On Friday, February 2, 2018 5:07:00 PM PST Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_program_cache.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Roland Scheidegger
Am 03.02.2018 um 03:12 schrieb Marek Olšák: > On Sat, Feb 3, 2018 at 2:55 AM, Roland Scheidegger wrote: >> Am 03.02.2018 um 00:31 schrieb Marek Olšák: >>> On Sat, Feb 3, 2018 at 12:01 AM, Roland Scheidegger >>> wrote: Am 02.02.2018 um 23:39 schrieb

Re: [Mesa-dev] [PATCH v2 21/24] anv: Allow fast-clearing the first slice of a multi-slice image

2018-02-02 Thread Nanley Chery
On Fri, Feb 02, 2018 at 09:02:25PM -0800, Jason Ekstrand wrote: > On Fri, Feb 2, 2018 at 5:58 PM, Nanley Chery wrote: > > > On Fri, Feb 02, 2018 at 04:42:14PM -0800, Jason Ekstrand wrote: > > > On Fri, Feb 2, 2018 at 2:39 PM, Nanley Chery > > wrote:

Re: [Mesa-dev] [PATCH 2/2] i965: Create new program cache bo when clearing the program cache

2018-02-02 Thread Kenneth Graunke
On Friday, February 2, 2018 5:07:01 PM PST Jordan Justen wrote: > When the disk shader cache CI testing was enabled, we started noticing > occasional failures on deqp test runs. (Mainly SNB, rarely HSW) > > Before this change, when we cleared the (in memory) program cache we > reused the same bo.

Re: [Mesa-dev] [PATCH 2/2] i965: Create new program cache bo when clearing the program cache

2018-02-02 Thread Kenneth Graunke
On Friday, February 2, 2018 5:07:01 PM PST Jordan Justen wrote: > When the disk shader cache CI testing was enabled, we started noticing > occasional failures on deqp test runs. (Mainly SNB, rarely HSW) > > Before this change, when we cleared the (in memory) program cache we > reused the same bo.

Re: [Mesa-dev] [PATCH] anv: Do color resolve tracking one slice at a time for 3D images

2018-02-02 Thread Jason Ekstrand
On Fri, Feb 2, 2018 at 6:55 PM, Nanley Chery wrote: > On Thu, Feb 01, 2018 at 06:31:18PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_image.c | 14 +- > > We should also update the comment in anv_image that describes 3D as > having one

Re: [Mesa-dev] [PATCH] intel/blorp: Use the hardware op for CCS ambiguate on gen10+

2018-02-02 Thread Jason Ekstrand
On Fri, Feb 2, 2018 at 6:47 PM, Nanley Chery wrote: > On Tue, Jan 30, 2018 at 05:20:07PM -0800, Jason Ekstrand wrote: > > Completely untested. > > The message in your fdo branch looks good. > > > --- > > src/intel/blorp/blorp_clear.c | 12 +++- > >

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Bas Nieuwenhuizen
Also change meson.build? On Fri, Feb 2, 2018 at 7:34 PM, Marek Olšák wrote: > From: Marek Olšák > > Only these are supported: > - LLVM 4.0 > - LLVM 5.0 > - LLVM 6.0 > - master (7.0) > --- > configure.ac | 4 +- >

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

2018-02-02 Thread Bas Nieuwenhuizen
I'd prefer if Dylan's patch goes first, as we are bumping swr too otherwise. Though either way: Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 2, 2018 at 8:15 PM, Dylan Baker wrote: > FYI: I sent out a patch a few minutes ago to set the minimum

Re: [Mesa-dev] [PATCH 2/7] gallium: use PIPE_CAP_CONSTBUF0_FLAGS

2018-02-02 Thread Axel Davy
Hi Marek, Since the previous patch makes it mandatory to use the flags when required, I guess this patch should also add the neccessary changes to gallium nine. Yours, Axel Davy On 02/02/2018 21:48, Marek Olšák wrote: From: Marek Olšák ---

Re: [Mesa-dev] [PATCH] intel/blorp: Use the hardware op for CCS ambiguate on gen10+

2018-02-02 Thread Nanley Chery
On Tue, Jan 30, 2018 at 05:20:07PM -0800, Jason Ekstrand wrote: > Completely untested. The message in your fdo branch looks good. > --- > src/intel/blorp/blorp_clear.c | 12 +++- > src/intel/blorp/blorp_genX_exec.h | 6 ++ > 2 files changed, 17 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH] anv: Do color resolve tracking one slice at a time for 3D images

2018-02-02 Thread Nanley Chery
On Thu, Feb 01, 2018 at 06:31:18PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 14 +- We should also update the comment in anv_image that describes 3D as having one slice per LOD. > src/intel/vulkan/anv_private.h | 9 - >

Re: [Mesa-dev] [PATCH v2 21/24] anv: Allow fast-clearing the first slice of a multi-slice image

2018-02-02 Thread Jason Ekstrand
On Fri, Feb 2, 2018 at 5:58 PM, Nanley Chery wrote: > On Fri, Feb 02, 2018 at 04:42:14PM -0800, Jason Ekstrand wrote: > > On Fri, Feb 2, 2018 at 2:39 PM, Nanley Chery > wrote: > > > > > On Fri, Jan 19, 2018 at 03:47:38PM -0800, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH v2 21/24] anv: Allow fast-clearing the first slice of a multi-slice image

2018-02-02 Thread Jason Ekstrand
On Fri, Feb 2, 2018 at 2:39 PM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:38PM -0800, Jason Ekstrand wrote: > > Now that we're tracking aux properly per-slice, we can enable this for > > applications which actually care. > > --- > > src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH v2 21/24] anv: Allow fast-clearing the first slice of a multi-slice image

2018-02-02 Thread Nanley Chery
On Fri, Feb 02, 2018 at 04:42:14PM -0800, Jason Ekstrand wrote: > On Fri, Feb 2, 2018 at 2:39 PM, Nanley Chery wrote: > > > On Fri, Jan 19, 2018 at 03:47:38PM -0800, Jason Ekstrand wrote: > > > Now that we're tracking aux properly per-slice, we can enable this for > > >

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Marek Olšák
On Fri, Feb 2, 2018 at 10:26 PM, Roland Scheidegger wrote: > Am 02.02.2018 um 21:48 schrieb Marek Olšák: >> Hi, >> >> This is the second and hopefully final version of 32-bit pointer >> support for radeonsi. >> >> Constant buffer 0 now has restrictions on which buffers can be

Re: [Mesa-dev] [PATCH 2/7] gallium: use PIPE_CAP_CONSTBUF0_FLAGS

2018-02-02 Thread Marek Olšák
On Fri, Feb 2, 2018 at 10:44 PM, Axel Davy wrote: > Hi Marek, > > Since the previous patch makes it mandatory to use the flags when required, > I guess this patch should also add the neccessary changes to gallium nine. Nine uses user buffers and const_uploader, so it's

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Roland Scheidegger
Am 02.02.2018 um 23:39 schrieb Marek Olšák: > On Fri, Feb 2, 2018 at 10:26 PM, Roland Scheidegger > wrote: >> Am 02.02.2018 um 21:48 schrieb Marek Olšák: >>> Hi, >>> >>> This is the second and hopefully final version of 32-bit pointer >>> support for radeonsi. >>> >>>

Re: [Mesa-dev] [PATCH] r600/eg: use texture target to pick array size not view target (v2)

2018-02-02 Thread Roland Scheidegger
Am 02.02.2018 um 06:33 schrieb Dave Airlie: > From: Dave Airlie > > This fixes a few CTS cases in : > KHR-GL45.texture_view.view_sampling > > some multisample cases are still broken, but not sure this is > the same problem. > > v2: fix more cases > > Signed-off-by: Dave

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Marek Olšák
On Fri, Feb 2, 2018 at 11:39 PM, Marek Olšák wrote: > On Fri, Feb 2, 2018 at 10:26 PM, Roland Scheidegger > wrote: >> Am 02.02.2018 um 21:48 schrieb Marek Olšák: >>> Hi, >>> >>> This is the second and hopefully final version of 32-bit pointer >>> support

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Marek Olšák
On Sat, Feb 3, 2018 at 12:01 AM, Roland Scheidegger wrote: > Am 02.02.2018 um 23:39 schrieb Marek Olšák: >> On Fri, Feb 2, 2018 at 10:26 PM, Roland Scheidegger >> wrote: >>> Am 02.02.2018 um 21:48 schrieb Marek Olšák: Hi, This is the second

[Mesa-dev] [PATCH 2/2] i965: Create new program cache bo when clearing the program cache

2018-02-02 Thread Jordan Justen
When the disk shader cache CI testing was enabled, we started noticing occasional failures on deqp test runs. (Mainly SNB, rarely HSW) Before this change, when we cleared the (in memory) program cache we reused the same bo. Since the disk shader cache quickly restores programs, it appears that

[Mesa-dev] [PATCH 1/2] i965: Add copy param to brw_cache_new_bo

2018-02-02 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_program_cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri/i965/brw_program_cache.c index

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Roland Scheidegger
Am 03.02.2018 um 00:31 schrieb Marek Olšák: > On Sat, Feb 3, 2018 at 12:01 AM, Roland Scheidegger > wrote: >> Am 02.02.2018 um 23:39 schrieb Marek Olšák: >>> On Fri, Feb 2, 2018 at 10:26 PM, Roland Scheidegger >>> wrote: Am 02.02.2018 um 21:48

Re: [Mesa-dev] [PATCH 05/12] radeon/vcn: add header implementations for HEVC

2018-02-02 Thread Zhang, Boyuan
Update patch 05/12 with a fix. From: Boyuan Zhang Implement encoding of sps, pps, vps, aud, and slice headers for HEVC based on HEVC specs. Signed-off-by: Boyuan Zhang Acked-by: Christian König ---

Re: [Mesa-dev] [PATCH v2 20/24] anv/cmd_buffer: Rework aux tracking

2018-02-02 Thread Jason Ekstrand
On Fri, Feb 2, 2018 at 1:47 PM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:37PM -0800, Jason Ekstrand wrote: > > This commit completely reworks aux tracking. This includes a number of > > somewhat distinct changes: > > > > 1) Since we are no longer fast-clearing

Re: [Mesa-dev] [PATCH v2 21/24] anv: Allow fast-clearing the first slice of a multi-slice image

2018-02-02 Thread Nanley Chery
On Fri, Jan 19, 2018 at 03:47:38PM -0800, Jason Ekstrand wrote: > Now that we're tracking aux properly per-slice, we can enable this for > applications which actually care. > --- > src/intel/vulkan/anv_blorp.c | 22 +++--- > src/intel/vulkan/genX_cmd_buffer.c | 13

[Mesa-dev] [PATCH] radv: implement VK_EXT_external_memory_host

2018-02-02 Thread Fredrik Höglund
Ported from the radeonsi GL_AMD_pinned_memory implementation. Signed-off-by: Fredrik Höglund --- Tested using a version of the cube demo modified to use host memory allocations for buffers and staging images. src/amd/vulkan/radv_device.c | 60

Re: [Mesa-dev] [PATCH v2 20/24] anv/cmd_buffer: Rework aux tracking

2018-02-02 Thread Nanley Chery
On Fri, Feb 02, 2018 at 02:39:25PM -0800, Jason Ekstrand wrote: > On Fri, Feb 2, 2018 at 1:47 PM, Nanley Chery wrote: > > > On Fri, Jan 19, 2018 at 03:47:37PM -0800, Jason Ekstrand wrote: > > > This commit completely reworks aux tracking. This includes a number of > > >

Re: [Mesa-dev] [PATCH 0/7] RadeonSI 32-bit pointers v2 & Gallium changes

2018-02-02 Thread Marek Olšák
On Sat, Feb 3, 2018 at 2:55 AM, Roland Scheidegger wrote: > Am 03.02.2018 um 00:31 schrieb Marek Olšák: >> On Sat, Feb 3, 2018 at 12:01 AM, Roland Scheidegger >> wrote: >>> Am 02.02.2018 um 23:39 schrieb Marek Olšák: On Fri, Feb 2, 2018 at 10:26 PM,

Re: [Mesa-dev] [PATCH 4/8] mesa: Track position/generic0 aliasing in the VAO.

2018-02-02 Thread Emil Velikov
On 1 February 2018 at 07:32, wrote: > From: Mathias Fröhlich > > Since the first material attribute no longer aliases with > the generic0 attribute, only aliasing between generic0 and > position is left and entirely dependent on the enabled >

Re: [Mesa-dev] [PATCH] r600: don't do stack workarounds for hemlock

2018-02-02 Thread Emil Velikov
Hi Roland, On 30 January 2018 at 05:07, wrote: > From: Roland Scheidegger > > By the looks of it it seems hemlock is treated separately to cypress, but > certainly it won't need the stack workarounds cedar/redwood (and > seemingly every other eg chip

Re: [Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

2018-02-02 Thread Roland Scheidegger
Are you sure of that? You only get 11 stride bits to program, and they are in bytes. Therefore I can't see how you could program 2048 (unless the hw would interpet 0 as 2048 but I think stride 0 is valid there?). Roland Am 02.02.2018 um 07:23 schrieb Dave Airlie: > From: Dave Airlie

Re: [Mesa-dev] [PATCH] r600/eg: fix cube map array buffer images.

2018-02-02 Thread Roland Scheidegger
Oops my bad... Reviewed-by: Roland Scheidegger Am 02.02.2018 um 07:57 schrieb Dave Airlie: > From: Dave Airlie > > This fixes a crash in: > KHR-GL45.texture_cube_map_array.texture_size_compute_sh. > > Signed-off-by: Dave Airlie >

  1   2   >