[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 Bug ID: 107351 Summary: Android 8.1: radv segfault with 3Dmark vulkan benchmarks Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: other

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Dave Airlie
On 24 July 2018 at 03:14, Gert Wollny wrote: > Am Montag, den 23.07.2018, 21:17 +1000 schrieb Dave Airlie: >> On 23 July 2018 at 17:28, Gert Wollny >> wrote: >> > Am Montag, den 23.07.2018, 17:13 +1000 schrieb Dave Airlie: >> > > On 23 July 2018 at 16:46, Gert Wollny >> > > wrote: >> > > > Am

Re: [Mesa-dev] [PATCH 1/2] nir: add const_index parameters to system value builder function

2018-07-23 Thread Eric Anholt
Karol Herbst writes: > On Mon, Jul 23, 2018 at 7:02 PM, Eric Anholt wrote: >> Karol Herbst writes: >> >>> this allows to replace some nir_load_system_value calls with the specific >>> system value constructor >>> >>> Reviewed-by: Jason Ekstrand >>> Signed-off-by: Karol Herbst >>> --- >>>

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #2 from Bas Nieuwenhuizen --- Do you have a hash of the upstream git version you based this on? (just so I can see how the lines correlate in radv_image.c) -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

2018-07-23 Thread Erik Faye-Lund
On Jul 23, 2018 22:05, Dave Airlie wrote:On 20 July 2018 at 13:39, Gurchetan Singh wrote: > Reviewed-by: Gurchetan Singh > On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund > wrote: >> >> The IOCTLs doesn't pass this along, so computing them in the first >> place is kinda pointless. >> >>

[Mesa-dev] [Bug 107295] Access violation on glDrawArrays with count >= 2048

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107295 Roland Scheidegger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #5 from Mauro Rossi --- >Is ANDROID properly defined? Yes, because it is defined by the build system itself, without need of passing the LOCAL_CFLAGS := -DANDROID Mauro -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-23 Thread Kenneth Graunke
On Monday, July 23, 2018 10:46:31 AM PDT Jason Ekstrand wrote: > The original pass only looked for load_uniform intrinsics but there are > a number of other places that could end up loading a push constant. One > obvious omission was images which always implicitly use a push constant. > Legacy VS

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #3 from Mauro Rossi --- Hi Bas, the problem was obeserved in the last month, but the relevant parts radv_image.c and radv_android.c did not change, so anything between 3da693b and HEAD the addr2line output is not always reliable

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #4 from Bas Nieuwenhuizen --- No, on ANDROID, the call to radv_image_from_gralloc should happen for wsi images and wsi_info should be always NULL. Is ANDROID properly defined? -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH 12/15] nir/types: Add a wrapper to access gl_type

2018-07-23 Thread Timothy Arceri
On 23/07/18 22:48, Alejandro Piñeiro wrote: On 21/07/18 05:15, Timothy Arceri wrote: On 21/07/18 13:09, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Actually I take that back. This introduces a dependency on GL in NIR, Hmm, but that dependency is already there. nir.h includes

Re: [Mesa-dev] [PATCH] i965/miptree: Fix can_blit_slice()

2018-07-23 Thread Chris Wilson
Quoting Nanley Chery (2018-07-23 18:17:15) > Satisfy the BLT engine's row pitch limitation on the destination > miptree. The destination miptree is untiled, so its row_pitch will be > slightly less than or equal to the source miptree's row_pitch. Use the > source miptree's row_pitch in

Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

2018-07-23 Thread Dave Airlie
On 20 July 2018 at 13:39, Gurchetan Singh wrote: > Reviewed-by: Gurchetan Singh > On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund > wrote: >> >> The IOCTLs doesn't pass this along, so computing them in the first >> place is kinda pointless. >> >> Signed-off-by: Erik Faye-Lund >> --- >> >> This

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #6 from Mauro Rossi --- Created attachment 140802 --> https://bugs.freedesktop.org/attachment.cgi?id=140802=edit extended logcat to see what happens before and after extended logcat to see what happens before and after -- You

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #9 from Bas Nieuwenhuizen --- Yes, images not explicitly using the path for Android cross-api interop should just follow the normal path. -- You are receiving this mail because: You are the assignee for the bug. You are the QA

Re: [Mesa-dev] [PATCH] nir: Add flipping of gl_PointCoord.y in nir_lower_wpos_ytransform.

2018-07-23 Thread Rob Clark
On Mon, Jul 23, 2018 at 1:25 PM, Eric Anholt wrote: > Eric Anholt writes: > >> This is controlled by a new nir_shader_compiler_options flag, and fixes >> dEQP-GLES3.functional.shaders.builtin_variable.pointcoord on V3D. >> --- > > Ken, Rob, any chance you could take a quick look at this? I

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #1 from Mauro Rossi --- Created attachment 140797 --> https://bugs.freedesktop.org/attachment.cgi?id=140797=edit logcat of slingshot extreeme vulkan test -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH v3 1/2] intel/fs: New methods dst_write_pattern and src_read_pattern at fs_inst

2018-07-23 Thread Jose Maria Casanova Crespo
These new methods return for a instruction register source/destination the read/write byte pattern of the 32-byte GRF as an unsigned int. The returned pattern takes into account the exec_size of the instruction, the type bitsize, the register stride and a relative offset inside the register. The

Re: [Mesa-dev] [PATCH] i965/miptree: Fix can_blit_slice()

2018-07-23 Thread Nanley Chery
On Mon, Jul 23, 2018 at 08:20:15PM +0100, Chris Wilson wrote: > Quoting Nanley Chery (2018-07-23 18:17:15) > > Satisfy the BLT engine's row pitch limitation on the destination > > miptree. The destination miptree is untiled, so its row_pitch will be > > slightly less than or equal to the source

Re: [Mesa-dev] [PATCH] nir: Add flipping of gl_PointCoord.y in nir_lower_wpos_ytransform.

2018-07-23 Thread Kenneth Graunke
On Monday, July 23, 2018 1:24:08 PM PDT Rob Clark wrote: > On Mon, Jul 23, 2018 at 1:25 PM, Eric Anholt wrote: > > Eric Anholt writes: > > > >> This is controlled by a new nir_shader_compiler_options flag, and fixes > >> dEQP-GLES3.functional.shaders.builtin_variable.pointcoord on V3D. > >> ---

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #8 from Mauro Rossi --- In the code between ANDROID braces, is it correct that code falls through in case of !gralloc_info or should it bail out? Just a question as I may be very wrong and confused #ifdef ANDROID const

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #10 from Bas Nieuwenhuizen --- If you're in a position to get more useful info, it would be great if you could dump the *pCreateInfo arg of the crashing radv_CreateImage. -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH 1/2] intel/fs: New method for register_byte_use_pattern for fs_inst

2018-07-23 Thread Chema Casanova
El 20/07/18 a las 22:10, Francisco Jerez escribió: > Chema Casanova writes: > >> El 20/07/18 a las 00:34, Francisco Jerez escribió: >>> Chema Casanova writes: >>> El 14/07/18 a las 00:14, Francisco Jerez escribió: > Jose Maria Casanova Crespo writes: > >> For a register

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #7 from Bas Nieuwenhuizen --- Looking at the full backtrace it looks like plain texture creation, nothing Android specific so I'll need to debug the specific app sometime. 07-22 21:31:16.071 5007 5007 F DEBUG : backtrace: 07-22

Re: [Mesa-dev] [PATCH] glsl: remove delegating constructors to allow build with C++98

2018-07-23 Thread Matt Turner
Reviewed-by: Matt Turner and pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] docs: move releases from Fridays to Wednesdays

2018-07-23 Thread Dylan Baker
Acked-by: Dylan Baker Quoting Juan A. Suarez Romero (2018-07-23 02:22:06) > Reviewed-by: Juan A. Suarez > > Reviewed/Acked/Agreed, whatever makes more sense :) > > > > J.A. > > On Thu, 2018-07-19 at 16:00 +0300, Andres Gomez wrote: > > As discussed at: > >

Re: [Mesa-dev] [PATCH 5/8] nir: add 16bit type information to glsl types

2018-07-23 Thread Bas Nieuwenhuizen
On Thu, Jul 19, 2018 at 2:48 PM, Daniel Schürmann wrote: > Signed-off-by: Daniel Schürmann > --- > src/compiler/glsl_types.h | 15 +++ > src/compiler/nir_types.cpp | 12 > src/compiler/nir_types.h | 1 + > 3 files changed, 28 insertions(+) > > diff --git

[Mesa-dev] [PATCH 2/2] i965: implement MESA_framebuffer_flip_y [v3]

2018-07-23 Thread Fritz Koenig
Instead of using _mesa_is_winsys_fbo or _mesa_is_user_fbo to infer if an fbo is flipped use the InvertedY flag. v2: * additional window-system framebuffer checks [for jason] v3: * s/inverted_y/flip_y/g [for chadv] * s/InvertedY/FlipY/g [for chadv] --- src/mesa/drivers/dri/i965/brw_blorp.c

[Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v4]

2018-07-23 Thread Fritz Koenig
Adds an extension to glFramebufferParameteri that will specify if the framebuffer is vertically flipped. Historically system framebuffers are vertically flipped and user framebuffers are not. Checking to see the state was done by looking at the name field. This adds an explicit field. v2: *

Re: [Mesa-dev] i915/swrast vertex array regression

2018-07-23 Thread Mathias Fröhlich
Hi Ville, > I noticed a while back that xonotic had started to misrender the gun > models on i915. Yesterday I bisected it down to commit 64d2a2048054 > ("mesa: Make gl_vertex_array contain pointers to first order VAO > members."). Actually that commit broke things even worse (and the > game

Re: [Mesa-dev] [PATCH] nir: Add a couple trivial abs optimizations

2018-07-23 Thread Ian Romanick
Funny thing about this... this is how i915 implements ABS. :) Reviewed-by: Ian Romanick On 07/23/2018 12:02 AM, Jason Ekstrand wrote: > Spotted in a shader in Batman: Arkham City. > --- > src/compiler/nir/nir_opt_algebraic.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[Mesa-dev] [Bug 54971] __glXInitialize can initialize same display multiple times

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54971 Julien Isorce changed: What|Removed |Added CC||julien.iso...@gmail.com -- You are

Re: [Mesa-dev] [PATCH 1/2] nir: add const_index parameters to system value builder function

2018-07-23 Thread Eric Anholt
Karol Herbst writes: > this allows to replace some nir_load_system_value calls with the specific > system value constructor > > Reviewed-by: Jason Ekstrand > Signed-off-by: Karol Herbst > --- > src/compiler/nir/nir_builder_opcodes_h.py | 21 +++-- > 1 file changed, 19

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Gert Wollny
Am Montag, den 23.07.2018, 21:17 +1000 schrieb Dave Airlie: > On 23 July 2018 at 17:28, Gert Wollny > wrote: > > Am Montag, den 23.07.2018, 17:13 +1000 schrieb Dave Airlie: > > > On 23 July 2018 at 16:46, Gert Wollny > > > wrote: > > > > Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave

Re: [Mesa-dev] [PATCH 1/2] nir: add const_index parameters to system value builder function

2018-07-23 Thread Karol Herbst
On Mon, Jul 23, 2018 at 7:02 PM, Eric Anholt wrote: > Karol Herbst writes: > >> this allows to replace some nir_load_system_value calls with the specific >> system value constructor >> >> Reviewed-by: Jason Ekstrand >> Signed-off-by: Karol Herbst >> --- >>

Re: [Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

2018-07-23 Thread Jordan Justen
On 2018-07-23 03:29:21, Eero Tamminen wrote: > Hi, > > Should this fix also: > https://bugs.freedesktop.org/show_bug.cgi?id=106382 > ? > It helped a bit. For me, on a simple test program, it allowed shader time to work once, even when the cache had a non-shader-time program. But,

[Mesa-dev] [PATCH] i965/miptree: Fix can_blit_slice()

2018-07-23 Thread Nanley Chery
Satisfy the BLT engine's row pitch limitation on the destination miptree. The destination miptree is untiled, so its row_pitch will be slightly less than or equal to the source miptree's row_pitch. Use the source miptree's row_pitch in can_blit_slice instead of its blt_pitch. Fixes

[Mesa-dev] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-23 Thread Jason Ekstrand
The original pass only looked for load_uniform intrinsics but there are a number of other places that could end up loading a push constant. One obvious omission was images which always implicitly use a push constant. Legacy VS clip planes also get pushed into the shader. Cc:

[Mesa-dev] [Bug 107305] glsl/opt_copy_propagation_elements.cpp:72:9: error: delegating constructors are permitted only in C++11

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107305 Caio Marcelo de Oliveira Filho changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] nir: Add flipping of gl_PointCoord.y in nir_lower_wpos_ytransform.

2018-07-23 Thread Eric Anholt
Eric Anholt writes: > This is controlled by a new nir_shader_compiler_options flag, and fixes > dEQP-GLES3.functional.shaders.builtin_variable.pointcoord on V3D. > --- Ken, Rob, any chance you could take a quick look at this? I think this is the last change I need in Mesa for GLES2

Re: [Mesa-dev] [PATCH] r600: enable tess_input_info for TES

2018-07-23 Thread Gert Wollny
Looks reasonable, Reviewed-By: Gert Wollny Am Donnerstag, den 19.07.2018, 14:42 +1000 schrieb Dave Airlie: > From: Dave Airlie > > There might be a nicer way to do this, but this is at least correct. > > This fixes: > KHR-GL44.tessellation_shader.single.max_patch_vertices > KHR- >

Re: [Mesa-dev] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-23 Thread Lionel Landwerlin
On 23/07/18 18:46, Jason Ekstrand wrote: The original pass only looked for load_uniform intrinsics but there are a number of other places that could end up loading a push constant. One obvious omission was images which always implicitly use a push constant. Legacy VS clip planes also get pushed

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-07-23 Thread Timothy Arceri
On 24/07/18 14:24, Marek Olšák wrote: On Mon, Jul 23, 2018 at 11:33 PM, Timothy Arceri wrote: On 24/07/18 11:15, Marek Olšák wrote: On Fri, Jul 20, 2018 at 12:53 AM, Dave Airlie wrote: On 20 July 2018 at 13:12, Marek Olšák wrote: From: Marek Olšák To make

Re: [Mesa-dev] [PATCH 3/8] ac: add support for 16bit UBO loads

2018-07-23 Thread Marek Olšák
On Thu, Jul 19, 2018 at 8:48 AM, Daniel Schürmann wrote: > Signed-off-by: Daniel Schürmann > --- > src/amd/common/ac_llvm_build.c | 25 + > src/amd/common/ac_llvm_build.h | 8 > src/amd/common/ac_nir_to_llvm.c | 21 ++--- > 3 files changed, 51

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-07-23 Thread Marek Olšák
On Fri, Jul 20, 2018 at 12:53 AM, Dave Airlie wrote: > On 20 July 2018 at 13:12, Marek Olšák wrote: >> From: Marek Olšák >> >> To make dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 >> finish sooner on the older CPUs. (otherwise it gets killed and we fail >> the test) > > I

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-07-23 Thread Timothy Arceri
On 24/07/18 11:15, Marek Olšák wrote: On Fri, Jul 20, 2018 at 12:53 AM, Dave Airlie wrote: On 20 July 2018 at 13:12, Marek Olšák wrote: From: Marek Olšák To make dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 finish sooner on the older CPUs. (otherwise it gets killed and we

[Mesa-dev] [PATCH 2/2] gallium/u_vbuf: handle indirect multidraws correctly and efficiently (v2)

2018-07-23 Thread Marek Olšák
From: Marek Olšák v2: need to do MAX{start+count} instead of MAX{count} added piglit tests --- src/gallium/auxiliary/util/u_vbuf.c | 199 1 file changed, 175 insertions(+), 24 deletions(-) diff --git a/src/gallium/auxiliary/util/u_vbuf.c

[Mesa-dev] [PATCH] mesa: allow indirect draws with the default VAO and compatibility profile

2018-07-23 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/draw_validate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/draw_validate.c b/src/mesa/main/draw_validate.c index c0a234a2bc2..29304bd5144 100644 --- a/src/mesa/main/draw_validate.c +++ b/src/mesa/main/draw_validate.c

[Mesa-dev] [PATCH 1/2] gallium/u_vbuf: split u_vbuf_get_minmax_index function (v2)

2018-07-23 Thread Marek Olšák
From: Marek Olšák This will be used by indirect multidraws. v2: clean up the function further, change return types to unsigned --- src/gallium/auxiliary/util/u_vbuf.c | 101 ++-- 1 file changed, 51 insertions(+), 50 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] ac, radeonsi: reduce optimizations for complex compute shaders on older APUs

2018-07-23 Thread Marek Olšák
On Mon, Jul 23, 2018 at 11:33 PM, Timothy Arceri wrote: > On 24/07/18 11:15, Marek Olšák wrote: >> >> On Fri, Jul 20, 2018 at 12:53 AM, Dave Airlie wrote: >>> >>> On 20 July 2018 at 13:12, Marek Olšák wrote: From: Marek Olšák To make

[Mesa-dev] [PATCH 0/7] ASTC texture compression for all Gallium drivers

2018-07-23 Thread Marek Olšák
Hi, This series enables ASTC texture compression for all Gallium drivers that don't support it in hardware. The works the same as the ETC2 fallback, i.e. it decompresses ASTC inside glCompressedTexImage to a supported uncompressed format. RadeonSI now finally supports the following: -

[Mesa-dev] [PATCH 3/7] st/mesa: use st_compressed_format_fallback more

2018-07-23 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_format.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 9ae796eca9e..45513e8683e 100644 --- a/src/mesa/state_tracker/st_format.c

[Mesa-dev] [PATCH 7/7] st/mesa: implement ASTC 2D LDR fallback for all drivers

2018-07-23 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_texture.c | 17 +++- src/mesa/state_tracker/st_context.c| 3 ++ src/mesa/state_tracker/st_context.h| 1 + src/mesa/state_tracker/st_extensions.c | 5 +++ src/mesa/state_tracker/st_format.c | 56 ++ 5

[Mesa-dev] [PATCH 4/7] st/mesa: generalize code for the compressed texture map/unmap fallback

2018-07-23 Thread Marek Olšák
From: Marek Olšák in order to support ASTC --- src/mesa/state_tracker/st_cb_texture.c | 41 +++--- src/mesa/state_tracker/st_texture.h| 13 2 files changed, 31 insertions(+), 23 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH 1/7] mesa: add ASTC 2D LDR decoder

2018-07-23 Thread Marek Olšák
From: Marek Olšák --- src/mesa/Makefile.sources |2 + src/mesa/main/formats.c| 42 + src/mesa/main/formats.h|3 + src/mesa/main/texcompress_astc.cpp | 1871 src/mesa/main/texcompress_astc.h | 47 + src/util/half_float.c

[Mesa-dev] [PATCH 5/7] st/mesa: generalize fallback_copy_image for compressed textures

2018-07-23 Thread Marek Olšák
From: Marek Olšák in order to support ASTC --- src/mesa/state_tracker/st_cb_copyimage.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_copyimage.c b/src/mesa/state_tracker/st_cb_copyimage.c index 5230b61877f..f5d8c047800

[Mesa-dev] [PATCH 2/7] st/mesa: generalize st_etc_fallback -> st_compressed_format_fallback

2018-07-23 Thread Marek Olšák
From: Marek Olšák for ASTC support later --- src/mesa/state_tracker/st_cb_copyimage.c | 4 ++-- src/mesa/state_tracker/st_cb_texture.c | 24 ++-- src/mesa/state_tracker/st_texture.h | 2 +- 3 files changed, 17 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 6/7] st/mesa: add ETC2 & ASTC fast path for GetTex(Sub)Image

2018-07-23 Thread Marek Olšák
From: Marek Olšák Not sure if GL/GLES can hit this path, but it's just decompression. --- src/mesa/state_tracker/st_cb_texture.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index

Re: [Mesa-dev] [PATCH] nir: Add a couple trivial abs optimizations

2018-07-23 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Gert Wollny
Am Montag, den 23.07.2018, 17:13 +1000 schrieb Dave Airlie: > On 23 July 2018 at 16:46, Gert Wollny > wrote: > > Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: > > > > > > > > + uint32_t max_shader_buffer = shader == > > > > > PIPE_SHADER_FRAGMENT ? > > > > > +

[Mesa-dev] [Bug 106906] Failed to recongnize keyword “sampler2DRect” and "sampler2DRectShadow"

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106906 Zhaowei Yuan changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] nir: Add a couple of iand/ior optimizations

2018-07-23 Thread Timothy Arceri
Ian and I have been looking at these type of things recently. Ian has started work on a pass to cover this stuff without having to add dozens of these types of opts. https://lists.freedesktop.org/archives/mesa-dev/2018-July/200583.html On 23/07/18 17:36, Jason Ekstrand wrote: Spotted in a

Re: [Mesa-dev] [PATCH] intel/compiler: fix lower conversions to account for predication

2018-07-23 Thread Iago Toral
This is still pending review, any takers? Iago On Tue, 2018-07-17 at 11:10 +0200, Iago Toral Quiroga wrote: > The pass can create a temporary result for the instruction and then > moves from it to the original destination, however, if the original > instruction was predicated, the mov has to be

Re: [Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

2018-07-23 Thread Jason Ekstrand
This is better but there are still environment variables that affect compilation. For instance, the INTEL_SCALAR_VS/TCS/TES/GS environment variables. On Sun, Jul 22, 2018 at 9:28 PM Jordan Justen wrote: > Since various options within INTEL_DEBUG could impact code generation, > we need to set

Re: [Mesa-dev] [PATCH 07/10] nir: add loop unroll support for wrapper loops

2018-07-23 Thread Timothy Arceri
On 22/07/18 19:50, Jason Ekstrand wrote: On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri > wrote: This adds support for unrolling the classic     do {         // ...     } while (false) that is used to wrap multi-line macros. GLSL IR also

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Dave Airlie
On 23 July 2018 at 16:46, Gert Wollny wrote: > Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: >> >> > > + uint32_t max_shader_buffer = shader == PIPE_SHADER_FRAGMENT ? >> > > + rs->caps.caps.v2.max_shader_buffer_frag_compute : >> > >> > Shouldn't max_shader_buffer_frag_compute

Re: [Mesa-dev] [PATCH] intel/blorp: Fix blits to R8G8B8_UNORM_SRGB sRGB harder

2018-07-23 Thread Lionel Landwerlin
On 22/07/18 22:45, Jason Ekstrand wrote: On Sun, Jul 22, 2018 at 1:23 PM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: On 21/07/18 07:12, Jason Ekstrand wrote: > The first fix attempt contained a nasty typo which somehow didn't get > caught in review.  It

[Mesa-dev] [PATCH] nir: Add a couple of iand/ior optimizations

2018-07-23 Thread Jason Ekstrand
Spotted in a shader in Batman: Arkham City. --- src/compiler/nir/nir_opt_algebraic.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index ba277fdfd0e..f2007852b21 100644 ---

Re: [Mesa-dev] [PATCH v2 1/2] i965, anv: Add extra unused character in disk_cache renderer temp string

2018-07-23 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On Sun, Jul 22, 2018 at 9:28 PM Jordan Justen wrote: > This extra character should not be used by snprintf, but we make it > available to verify that we printed the exact number we wanted, and > didn't overflow. > > v2: > * Also update Anvil > > Signed-off-by: Jordan

[Mesa-dev] [PATCH] nir: Add a couple trivial abs optimizations

2018-07-23 Thread Jason Ekstrand
Spotted in a shader in Batman: Arkham City. --- src/compiler/nir/nir_opt_algebraic.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index f49b43f3213..ba277fdfd0e 100644 ---

Re: [Mesa-dev] [PATCH v2] mesa: enable EXT_render_snorm extension

2018-07-23 Thread Tapani Pälli
On 07/03/2018 03:10 AM, Nanley Chery wrote: On Fri, Jun 15, 2018 at 08:11:57AM +0300, Tapani Pälli wrote: Patch sets additional formats renderable and enables the extension when OpenGL ES 3.1 is supported. v2: instead of dummy_true, have a separate toggle for extension (Eric Anholt)

[Mesa-dev] Intel video bios table specification

2018-07-23 Thread Xu Zhongxing
Is there public specification for the Intel video bios table in the OpRegion? I checked the documents on 01.org. None of them contains the spec for the VBT. -- Xu Zhongxing ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/2] i965: Context aware user space EU control through application

2018-07-23 Thread J Karanje, Kedar
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Lionel Landwerlin > Sent: Friday, July 20, 2018 3:31 PM > To: Chris Wilson ; Muthukumar, Aravindan > ; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 2/2] i965: Context

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

2018-07-23 Thread Gert Wollny
Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: > > > > + uint32_t max_shader_buffer = shader == PIPE_SHADER_FRAGMENT ? > > > + rs->caps.caps.v2.max_shader_buffer_frag_compute : > > > > Shouldn't max_shader_buffer_frag_compute also be used for > > PIPE_SHADER_COMPUTE? > >

[Mesa-dev] [Bug 106906] Failed to recongnize keyword “sampler2DRect” and "sampler2DRectShadow"

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106906 --- Comment #3 from Zhaowei Yuan --- Is there nobody can give any reponse on this report? -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list

[Mesa-dev] [PATCH v2 7/8] nir: add loop unroll support for wrapper loops

2018-07-23 Thread Timothy Arceri
This adds support for unrolling the classic do { // ... } while (false) that is used to wrap multi-line macros. GLSL IR also wraps switch statements in a loop like this. shader-db results IVB: total loops in shared programs: 2515 -> 2512 (-0.12%) loops in affected programs: 33

[Mesa-dev] [PATCH v2 4/8] nir: always attempt to find loop terminators

2018-07-23 Thread Timothy Arceri
This will help later patches with unrolling loops that end with a break i.e. loops the always exit on their first interation. --- src/compiler/nir/nir_loop_analyze.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_loop_analyze.c

[Mesa-dev] v2 Loop unrolling and if statement opts

2018-07-23 Thread Timothy Arceri
v2: - make use of nir_block_dominates() in the if-statement opts as suggested by Connor. This allowed for a reduction in code required but also allowed me to implemented some extra optimisations. - implement feedback from Jason on loop unrolling opts.

[Mesa-dev] [PATCH v2 1/8] nir: evaluate if condition uses inside the if branches

2018-07-23 Thread Timothy Arceri
Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is clearly positive. shader-db results IVB: total instructions in shared programs:

[Mesa-dev] [PATCH v2 3/8] nir: allow more nested loops to be unrolled

2018-07-23 Thread Timothy Arceri
The innermost check was added to stop us from unrolling multiple loops in a single pass, and to stop outer loops from unrolling. When we successfully unroll a loop we need to run the analysis pass again before deciding if we want to go ahead an unroll a second loop. However the logic was flawed

[Mesa-dev] [PATCH v2 2/8] nir: propagates if condition evaluation down some alu chains

2018-07-23 Thread Timothy Arceri
shader-db IVB results: total instructions in shared programs: 9993483 -> 9993472 (-0.00%) instructions in affected programs: 1300 -> 1289 (-0.85%) helped: 11 HURT: 0 total cycles in shared programs: 219476091 -> 219476059 (-0.00%) cycles in affected programs: 7675 -> 7643 (-0.42%) helped: 10

[Mesa-dev] [PATCH v2 5/8] nir: add complex_loop bool to loop info

2018-07-23 Thread Timothy Arceri
In order to be sure loop_terminator_list is an accurate representation of all the jumps in the loop we need to be sure we didn't encounter any other complex behaviour such as continues, nested breaks, etc during analysis. This will be used in the following patch. --- src/compiler/nir/nir.h

[Mesa-dev] [PATCH v2 8/8] nir: add loop unroll support for complex wrapper loops

2018-07-23 Thread Timothy Arceri
In GLSL IR we cheat with switch statements and simply convert them into loops with a single iteration. This allowed us to make use of the existing jump instruction handling provided by the loop handing code, it also allows dead code to be cleaned up once we have wrapped the code in a loop.

[Mesa-dev] [PATCH v2 6/8] nir/opt_loop_unroll: Remove unneeded phis if we make progress

2018-07-23 Thread Timothy Arceri
Now that SSA values can be derefs and they have special rules, we have to be a bit more careful about our LCSSA phis. In particular, we need to clean up in case LCSSA ended up creating a phi node for a deref. This avoids validation issues with some CTS tests with the following patch, but its

[Mesa-dev] [PATCH v2] glcpp: Sync line number for macro

2018-07-23 Thread zhaowei yuan
Line number of a predefined macro should be set as where it is referenced rather than declared Patch v2 does nothing more except ccing more maintainers Signed-off-by: zhaowei yuan Bugzilla: https://patchwork.freedesktop.org/patch/225818/ --- src/compiler/glsl/glcpp/glcpp-lex.l | 1 +

Re: [Mesa-dev] [PATCH] docs: move releases from Fridays to Wednesdays

2018-07-23 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Reviewed/Acked/Agreed, whatever makes more sense :) J.A. On Thu, 2018-07-19 at 16:00 +0300, Andres Gomez wrote: > As discussed at: > https://lists.freedesktop.org/archives/mesa-dev/2018-March/188525.html > > Cc: Emil Velikov > Cc: Juan A. Suarez Romero

[Mesa-dev] [PATCH v3 1/4] nv50/ir: add preliminary support for OP_XMAD

2018-07-23 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 26 ++ .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 +-- .../drivers/nouveau/codegen/nv50_ir_print.cpp | 19

[Mesa-dev] [PATCH v3 4/4] nv50/ir: further optimize multiplication by immediates

2018-07-23 Thread Rhys Perry
Strongly mitigates the harm from the previous commit, which made many integer multiplications much more heavy on the register and instruction count. total instructions in shared programs : 5839715 -> 5801926 (-0.65%) total gprs used in shared programs: 670553 -> 669853 (-0.10%) total shared

[Mesa-dev] [PATCH v3 0/4] nv50/ir: Improve Performance of Integer Multiplication

2018-07-23 Thread Rhys Perry
Changes in v3: - stylistic changes - simplify createMulMethod2() - update shader-db statistics - use util_bitcount64 and util_next_power_of_two64 instead of reimplementing them Changes in v2: - rebase - bring back constant folding for multiplication by power-of-twos for nv50 - remove TODO in

[Mesa-dev] [PATCH v3 3/4] nv50/ir: optimize imul/imad to xmads

2018-07-23 Thread Rhys Perry
This hits the shader-db numbers a good bit, though a few xmads is way faster than an imul or imad and the cost is mitigated by the next commit, which optimizes many multiplications by immediates into shorter and less register heavy instructions than the xmads. total instructions in shared

[Mesa-dev] [PATCH v3 2/4] gm107/ir: add support for OP_XMAD on GM107+

2018-07-23 Thread Rhys Perry
Signed-off-by: Rhys Perry --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 65 ++ .../nouveau/codegen/nv50_ir_target_gm107.cpp | 6 +- .../nouveau/codegen/nv50_ir_target_nvc0.cpp| 1 + 3 files changed, 71 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] forward precise-flag if supported

2018-07-23 Thread Erik Faye-Lund
New versions of virglrenderer supports the precise-flag, so let's forward it from TGSI if that's the case. This fixes a few dEQP-GLES31 tests: - dEQP-GLES31.functional.tessellation.common_edge.quads_equal_spacing_precise -

Re: [Mesa-dev] [PATCH] docs: update calendar to match the 18.2 plan with the one announced

2018-07-23 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez J.A. On Thu, 2018-07-19 at 15:21 -0700, Dylan Baker wrote: > Quoting Andres Gomez (2018-07-19 06:03:11) > > Additionally, I've extended the 18.1 cycle by one more release, > > tentatively assigned to Dylan, due to the ~2 weeks delay for 18.2. > > This seems

Re: [Mesa-dev] [PATCH 1/2] RFC : Context aware user space Resource control

2018-07-23 Thread Kedar J Karanje
On Fri, Jul 20, 2018 at 10:59:03AM +0100, Lionel Landwerlin wrote: > On 20/07/18 09:32, aravindan.muthuku...@intel.com wrote: > >diff --git a/src/egl/generate/egl.xml b/src/egl/generate/egl.xml > >index 9250f93..52b0c9f 100644 > >--- a/src/egl/generate/egl.xml > >+++ b/src/egl/generate/egl.xml >

Re: [Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

2018-07-23 Thread Eero Tamminen
Hi, Should this fix also: https://bugs.freedesktop.org/show_bug.cgi?id=106382 ? - Eero On 23.07.2018 07:27, Jordan Justen wrote: Since various options within INTEL_DEBUG could impact code generation, we need to set the disk cache driver_flags parameter based on the INTEL_DEBUG

Re: [Mesa-dev] [PATCH] anv: Pay attention to VK_ACCESS_MEMORY_(READ|WRITE)_BIT

2018-07-23 Thread Alex Smith
On 20 July 2018 at 19:01, Jason Ekstrand wrote: > On Fri, Jul 20, 2018 at 8:37 AM Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> On 20/07/18 11:44, Alex Smith wrote: >> >> According to the spec, these should apply to all read/write access >> types (so would be equivalent to

[Mesa-dev] [PATCH v2] anv: Pay attention to VK_ACCESS_MEMORY_(READ|WRITE)_BIT

2018-07-23 Thread Alex Smith
According to the spec, these should apply to all read/write access types (so would be equivalent to specifying all other access types individually). Currently, they were doing nothing. v2: Handle VK_ACCESS_MEMORY_WRITE_BIT in dstAccessMask. Signed-off-by: Alex Smith Cc:

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 Gregor Münch changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REOPENED

[Mesa-dev] [Bug 107276] radv: OpBitfieldUExtract returns incorrect result when count is zero

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107276 Gregor Münch changed: What|Removed |Added CC||ximi...@mail.ru --- Comment #6 from

[Mesa-dev] [Bug 106590] Wrong line numbers expanded while compiling shaders

2018-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106590 --- Comment #3 from Zhaowei Yuan --- I posted patch v2 to cc more maintainer: https://patchwork.freedesktop.org/patch/240324/ -- You are receiving this mail because: You are the assignee for the

  1   2   >