Re: [Mesa-dev] [PATCH v2 8/8] egl: add EGL_platform_device support

2019-04-04 Thread Emil Velikov
On Wed, 3 Apr 2019 at 15:51, Marek Olšák wrote: > > On Wed, Apr 3, 2019 at 10:13 AM Mathias Fröhlich > wrote: >> >> > What is missing for merging this? >> >> I saw the pbuffer swrast crash and proposed to disable them via the >> 3rd patch that I pushed into my branch for you. >> Emil never

Re: [Mesa-dev] [PATCH 1/2] swr/rast: don't create wrapper for every Create LLVM call

2019-04-04 Thread Emil Velikov
On Mon, 25 Feb 2019 at 18:19, Emil Velikov wrote: > > Sorry to let this hang for so long. > > After some review, it looks like we have some upcoming changes internally > > that would be complicated with this change, and with this approach. At the > > time, I think we will hold off on this

[Mesa-dev] Requests for Proposal for hosting XDC 2020

2019-04-04 Thread Daniel Vetter
Hi all, The X.org board is soliciting proposals to host XDC in 2020. By the usual rotation a location in Europe is preferred, but the board will also consider other locations, especially if there's an interesting co-location with another conference. If you consider hosting XDC, we have assembled

[Mesa-dev] [Bug 110301] mesa-git reports Vulkan 1.1.90

2019-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110301 --- Comment #2 from Svyatoslav Timofeev --- Thanks. :) I was worried about that. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [Bug 110323] mesa-19.0.1 fails to compile with llvm-8.0.0 and Gallium swr driver

2019-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110323 Bug ID: 110323 Summary: mesa-19.0.1 fails to compile with llvm-8.0.0 and Gallium swr driver Product: Mesa Version: 19.0 Hardware: x86-64 (AMD64) OS: Linux

[Mesa-dev] [PATCH 2/2] st/nine: skip position checks in SetCursorPosition()

2019-04-04 Thread Andre Heider
For HW cursors, "cursor.pos" doesn't hold the current position of the pointer, just the position of the last call to SetCursorPosition(). Skip the check against stale values for present interface v1.5, so it can do it properly itself. Signed-off-by: Andre Heider --- Corresponding d3d9-nine.dll

[Mesa-dev] [PATCH 1/2] st/nine: introduce SetVersion() for present interface v1.4

2019-04-04 Thread Andre Heider
A follow up patch requires a behaviour change, so we need to negotiate the present version to be used to keep backward compatiblity. We already get the supported version from the WINE side via GetVersion(). Introduce the member SetVersion() to pass back the maximum common version. Signed-off-by:

[Mesa-dev] [PATCH 1/2] egl: add optional plat_opt to _eglFindDisplay()

2019-04-04 Thread Emil Velikov
From: Emil Velikov The EGL_EXT_platform_device extension will be coming shortly. It will effectively require comparing the platform specific options, passed via the attribs array. Cc: Mathias Fröhlich Cc: Marek Olšák Signed-off-by: Emil Velikov --- I'm not a huge fan of this. Yet again the

[Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-04 Thread Emil Velikov
This new 'platform' is added by default with no guards. It is effectively a copy of the surfaceless one, with updated function names and brand new probe function. Due to the reuse, some of the ifdef HAVE_SURFACELESS_PLATFORM guards have been dropped. A worthy mention are the changes in

[Mesa-dev] [PATCH 2/4] panfrost: Expose perfcounters through the pipe_query interface

2019-04-04 Thread Boris Brezillon
There's existing support for dumping perf counters in a files but nothing to expose them in a standard way to the gallium pipe infra. Define new driver hooks and add a common infra to expose perfcounters in a standard way. Signed-off-by: Boris Brezillon ---

[Mesa-dev] [PATCH 1/4] drm-uapi: panfrost: Add perfcnt related bits

2019-04-04 Thread Boris Brezillon
Sync panfrost_drm.h to get perfcnt related definitions. Signed-off-by: Boris Brezillon --- include/drm-uapi/panfrost_drm.h | 122 1 file changed, 122 insertions(+) diff --git a/include/drm-uapi/panfrost_drm.h b/include/drm-uapi/panfrost_drm.h index

[Mesa-dev] [PATCH 4/4] panfrost: Add T860 counters

2019-04-04 Thread Boris Brezillon
Define the T860 counters table. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_perfcnt.c | 199 - 1 file changed, 198 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_perfcnt.c b/src/gallium/drivers/panfrost/pan_perfcnt.c

[Mesa-dev] [PATCH 3/4] panfrost: Implement perfcnt hooks in the DRM driver

2019-04-04 Thread Boris Brezillon
Use the PERFMON/PERFCNT ioctls to get HW counters. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c | 245 + 1 file changed, 245 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index

[Mesa-dev] [PATCH 0/4] panfrost: Expose HW counters through the pipe_query iface

2019-04-04 Thread Boris Brezillon
Hello, This is an attempt at exposing Mali Midgard/Bifrost perf counters in a more or less generic way so that they can be used through the pipe_query interface. That should allow one to dump/display those counters using gallium-hud or any tool/lib that uses the GL_AMD_performance_monitor API

Re: [Mesa-dev] [PATCH 0/4] panfrost: Expose HW counters through the pipe_query iface

2019-04-04 Thread Alyssa Rosenzweig
> This series adds new hooks to the panfrost_driver driver interface so > that both the drm and non-drm drivers can be plugged (I only developped > the glue for the DRM driver so far, but can work on the non-DRM driver > if needed). You're in luck: we dropped support for the non-DRM driver

Re: [Mesa-dev] [PATCH 3/4] panfrost: Implement perfcnt hooks in the DRM driver

2019-04-04 Thread Alyssa Rosenzweig
> + struct pandrost_drm_perfcnt_query *data; Typo. How did that even compile? --Oh, wait, you have that typo throughout the file. s/pandrost/panfrost/g, please ;) --- Other than that, Reviewed-by: Alyssa Rosenzweig ___ mesa-dev mailing list

Re: [Mesa-dev] Move adriconf to mesa repositories

2019-04-04 Thread Emil Velikov
On Tue, 2 Apr 2019 at 19:40, Jean Hertel wrote: > > Hey Emil, > > You also showed interest in this project in the past. > Any thoughts about moving it to mesa gitlab? > Yes I have interest in a configuration tool, although my vision varies a lot from what adriconf and its predecessor. That said,

Re: [Mesa-dev] [PATCH v2 8/8] egl: add EGL_platform_device support

2019-04-04 Thread Mathias Fröhlich
Good morning, On Wednesday, 3 April 2019 16:51:03 CEST Marek Olšák wrote: > On Wed, Apr 3, 2019 at 10:13 AM Mathias Fröhlich > wrote: > > > > What is missing for merging this? > > > > I saw the pbuffer swrast crash and proposed to disable them via the > > 3rd patch that I pushed into my branch

Re: [Mesa-dev] [PATCH 1/2] swr/rast: don't create wrapper for every Create LLVM call

2019-04-04 Thread Hota, Alok
> > Can you elaborate what seems to be the problem? I'm more than happy to > > rework the patch so it works for you guys - do you have a WIP branch > > somewhere? > > > Humble ping? > > It's been 2 months since I've put this forward. In this time we could have > merged it resolving a massive hack

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.3.6 release candidate

2019-04-04 Thread Jason Ekstrand
On Thu, Apr 4, 2019 at 11:16 AM Emil Velikov wrote: > On Tue, 2 Apr 2019 at 20:13, Matt Turner wrote: > > > > On Mon, Apr 1, 2019 at 5:18 AM Emil Velikov > wrote: > > > For anyone wondering about the delay: > > > > > > We have been using LunarG OpenGL and Vulkan testing service to > > >

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.3.6 release candidate

2019-04-04 Thread Matt Turner
On Thu, Apr 4, 2019 at 9:16 AM Emil Velikov wrote: > > On Tue, 2 Apr 2019 at 20:13, Matt Turner wrote: > > > > On Mon, Apr 1, 2019 at 5:18 AM Emil Velikov > > wrote: > > > For anyone wondering about the delay: > > > > > > We have been using LunarG OpenGL and Vulkan testing service to > > >

Re: [Mesa-dev] [PATCH 1/4] drm-uapi: panfrost: Add perfcnt related bits

2019-04-04 Thread Alyssa Rosenzweig
Good, but let's wait for the kernel side to be finalized first, in case the UABI changes a bit there :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] panfrost: Expose perfcounters through the pipe_query interface

2019-04-04 Thread Alyssa Rosenzweig
> + if (!screen->driver->create_perfcnt_query) > + return NULL; Redundant -- it'll always be set since there's only DRM driver now. We should probably drop the indirection wholesale, too, but that's for a different patch. I guess if the DRM implementation isn't until next patch,

Re: [Mesa-dev] Move adriconf to mesa repositories

2019-04-04 Thread Jean Hertel
From: Emil Velikov Sent: 4th april, 2019 13:08 >Yes I have interest in a configuration tool, although my vision varies >a lot from what adriconf and its predecessor. I'm super interested and open to hear yours, and other mesa devs, ideas on how a good configuration utility should look and

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] swr/rast: don't create wrapper for every Create LLVM call

2019-04-04 Thread Dylan Baker
Quoting Hota, Alok (2019-04-04 09:44:40) > > > Can you elaborate what seems to be the problem? I'm more than happy to > > > rework the patch so it works for you guys - do you have a WIP branch > > > somewhere? > > > > > Humble ping? > > > > It's been 2 months since I've put this forward. In this

Re: [Mesa-dev] [PATCH 4/4] panfrost: Add T860 counters

2019-04-04 Thread Alyssa Rosenzweig
I sure hope you have a way of automatically generating these ^_^ One fleeting thought is that some of the counters have "scales" attached, where the logical value we need to report back is some specified integer multiple of what the hardware actually writes. I don't know if we want to account

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.3.6 release candidate

2019-04-04 Thread Emil Velikov
On Tue, 2 Apr 2019 at 20:13, Matt Turner wrote: > > On Mon, Apr 1, 2019 at 5:18 AM Emil Velikov wrote: > > For anyone wondering about the delay: > > > > We have been using LunarG OpenGL and Vulkan testing service to > > validate Mesa releases since day 1. > > > > Unfortunately, they've been

Re: [Mesa-dev] [PATCH 1/2] egl: add optional plat_opt to _eglFindDisplay()

2019-04-04 Thread Adam Jackson
On Thu, 2019-04-04 at 16:25 +0100, Emil Velikov wrote: > I'm not a huge fan of this. Yet again the other platform (x11) that uses > these has a number of issues, see below for details. Once those are resolved > we could try and make this more uniform. > > a) spec does not mention if a new (or

Re: [Mesa-dev] new dispatch generator broke with Marek's parallel compile commit

2019-04-04 Thread Ian Romanick
On 4/3/19 10:20 AM, Emil Velikov wrote: > On Tue, 2 Apr 2019 at 20:00, Ian Romanick wrote: >> >> On 4/2/19 4:43 AM, Emil Velikov wrote: >>> On Tue, 2 Apr 2019 at 04:55, Dave Airlie wrote: On Tue, 2 Apr 2019 at 11:24, Dave Airlie wrote: > > Marek's commit to add

[Mesa-dev] [Bug 110328] meson-built drivers are installed with non-empty rpath

2019-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110328 Bug ID: 110328 Summary: meson-built drivers are installed with non-empty rpath Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Adam Jackson changed: What|Removed |Added Depends on||110328 Referenced Bugs:

[Mesa-dev] [Bug 110328] meson-built drivers are installed with non-empty rpath

2019-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110328 Adam Jackson changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 110328, which changed state. Bug 110328 Summary: meson-built drivers are installed with non-empty rpath https://bugs.freedesktop.org/show_bug.cgi?id=110328 What|Removed |Added

Re: [Mesa-dev] [PATCH 2/4] panfrost: Expose perfcounters through the pipe_query interface

2019-04-04 Thread Alyssa Rosenzweig
> Will drop the indirect calls, and move the code to perfcnt.c (unless > you want to keep it in panfrost_drm.c). I'm not sure. Tomeu introduced the indirection/abstraction/etc to begin with; you might want to know his thoughts. I don't know if he has plans for continued refactors. Personally, it

Re: [Mesa-dev] [PATCH 1/4] drm-uapi: panfrost: Add perfcnt related bits

2019-04-04 Thread Alyssa Rosenzweig
Gotcha! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/6] panfrost/midgard: Add umin/umax opcodes

2019-04-04 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/helpers.h | 2 ++ src/gallium/drivers/panfrost/midgard/midgard.h | 4 src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 ++ 3 files changed, 8 insertions(+) diff --git

[Mesa-dev] [PATCH 5/6] panfrost/midgard: Add ibitcount8 op

2019-04-04 Thread Alyssa Rosenzweig
The mechanics of this opcode are a little opaque, but essentially, it's used in 8-bit mode to do a bit count in parallel of a uint and then doing a ton of clever iadd/imov ops to recombine. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/helpers.h | 1 +

[Mesa-dev] [PATCH 4/6] panfrost/midgard: Add ilzcnt op

2019-04-04 Thread Alyssa Rosenzweig
Used for implementing findLSB/MSB Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/helpers.h | 1 + src/gallium/drivers/panfrost/midgard/midgard.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/helpers.h

[Mesa-dev] [PATCH 6/6] panfrost/midgard: Enable lower_find_lsb

2019-04-04 Thread Alyssa Rosenzweig
This is exactly what the blob does. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.h b/src/gallium/drivers/panfrost/midgard/midgard_compile.h

[Mesa-dev] [PATCH 0/6] Document new functionality (tilebuffer, shaders)

2019-04-04 Thread Alyssa Rosenzweig
This patchset implements new functionality relating to tilebuffer loadback and some new operands found in the course of playing with tilebuffer loadback / related wanderings . Alyssa Rosenzweig (6): panfrost/decode: Add flags for tilebuffer readback panfrost: Add tilebuffer load? branch

[Mesa-dev] [PATCH 1/6] panfrost/decode: Add flags for tilebuffer readback

2019-04-04 Thread Alyssa Rosenzweig
These flags are set when reading back the tilebuffer from a fragment shader via various mechanisms (including ARM_shader_framebuffer_fetch and EXT_pixel_local_storage). Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/include/panfrost-job.h | 7 +++

[Mesa-dev] [PATCH 2/6] panfrost: Add tilebuffer load? branch

2019-04-04 Thread Alyssa Rosenzweig
Also document branches better. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/disassemble.c| 4 +++ .../drivers/panfrost/midgard/midgard.h| 34 ++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 108250] [GLSL] layout-location-struct.shader_test fails to link

2019-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108250 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH 1/1] iris: set default tiling mode to X-tiled

2019-04-04 Thread James Xiong
From: "Xiong, James" UMDs such as modesetting can use legacy ADDFD which doesn't accept Y-tiled buffer, ths patch sets the default tiling mode to X-tiled for backward compatibility. Signed-off-by: Xiong, James --- src/gallium/drivers/iris/iris_resource.c | 3 ++- 1 file changed, 2

Re: [Mesa-dev] [PATCH 4/4] panfrost: Add T860 counters

2019-04-04 Thread Boris Brezillon
On Thu, 4 Apr 2019 08:55:24 -0700 Alyssa Rosenzweig wrote: > I sure hope you have a way of automatically generating these ^_^ Definitely. Didn't focus on that so far, but defining them in an XML (or whatever) and generating .c/.h files out of it should be doable. > > One fleeting thought is

Re: [Mesa-dev] [PATCH 3/4] panfrost: Implement perfcnt hooks in the DRM driver

2019-04-04 Thread Boris Brezillon
On Thu, 4 Apr 2019 08:52:26 -0700 Alyssa Rosenzweig wrote: > > + struct pandrost_drm_perfcnt_query *data; > > Typo. How did that even compile? --Oh, wait, you have that typo > throughout the file. > > s/pandrost/panfrost/g, please ;) Will fix that :-) > > --- > > Other than that,

Re: [Mesa-dev] [PATCH 1/4] drm-uapi: panfrost: Add perfcnt related bits

2019-04-04 Thread Boris Brezillon
On Thu, 4 Apr 2019 08:44:13 -0700 Alyssa Rosenzweig wrote: > Good, but let's wait for the kernel side to be finalized first, in case > the UABI changes a bit there :) Of course. Just sent the mesa-side so that people can test/comment on the API choices, but there's no point merging this code

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] swr/rast: don't create wrapper for every Create LLVM call

2019-04-04 Thread Emil Velikov
On Thu, 4 Apr 2019 at 17:58, Dylan Baker wrote: > > Quoting Hota, Alok (2019-04-04 09:44:40) > > > > Can you elaborate what seems to be the problem? I'm more than happy to > > > > rework the patch so it works for you guys - do you have a WIP branch > > > > somewhere? > > > > > > > Humble ping? >

Re: [Mesa-dev] [PATCH 0/4] panfrost: Expose HW counters through the pipe_query iface

2019-04-04 Thread Boris Brezillon
On Thu, 4 Apr 2019 08:43:33 -0700 Alyssa Rosenzweig wrote: > > This series adds new hooks to the panfrost_driver driver interface so > > that both the drm and non-drm drivers can be plugged (I only developped > > the glue for the DRM driver so far, but can work on the non-DRM driver > > if

Re: [Mesa-dev] [PATCH 2/4] panfrost: Expose perfcounters through the pipe_query interface

2019-04-04 Thread Boris Brezillon
On Thu, 4 Apr 2019 08:49:28 -0700 Alyssa Rosenzweig wrote: > > + if (!screen->driver->create_perfcnt_query) > > + return NULL; > > Redundant -- it'll always be set since there's only DRM driver now. We > should probably drop the indirection wholesale, too, but that's for a >