On Wed, Oct 2, 2013 at 2:14 AM, Chris Forbes chr...@ijw.co.nz wrote:
With those fixes:
Reviewed-by: Chris Forbes chr...@ijw.co.nz
Thanks, I will push it shortly.
With this change landed, the slowness of sample_d is no longer the
bottleneck. Instead, the lack of native SIMD16 sample_d becomes
On 10/01/2013 07:15 PM, Francisco Jerez wrote:
v2: Fix GLSL version in which the type became available. Add
contains_atomic() convenience method. Split off atomic counter
comparison error checking to a separate patch that will handle all
opaque types. Include new ir_variable
On 09/30/2013 03:08 AM, Chris Forbes wrote:
From: Maxence Le Dore maxence.led...@gmail.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
---
src/mapi/glapi/gen/ARB_texture_gather.xml | 14 ++
src/mapi/glapi/gen/gl_API.xml | 2 +-
src/mesa/main/context.c
On 10/02/2013 02:39 AM, Kenneth Graunke wrote:
On 09/30/2013 03:08 AM, Chris Forbes wrote:
From: Maxence Le Dore maxence.led...@gmail.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
---
src/mapi/glapi/gen/ARB_texture_gather.xml | 14 ++
src/mapi/glapi/gen/gl_API.xml
https://bugs.freedesktop.org/show_bug.cgi?id=70009
Pavel Ondračka pavel.ondra...@email.cz changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop.
This patch fixes a race when a client releases a named buffer before the
server had the time to handle 'wl_drm_create_buffer'. When triggered,
the server would fail to create the buffer since the client already
having destroyed it, throwing out the client in the process with a
protocol error.
To
Kenneth Graunke kenn...@whitecape.org writes:
On 10/01/2013 07:15 PM, Francisco Jerez wrote:
[...]
@@ -441,6 +442,27 @@ struct glsl_type {
}
/**
+* Return the amount of atomic counter storage required for a type.
+*/
+ unsigned atomic_size() const
+ {
+ if
Chad Versace chad.vers...@linux.intel.com writes:
In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's
physical dimensions. (Logical and physical dimensions may differ for
multisample surfaces).
However, in SURFACE_STATE, we always set Width and Height to the slice's
(Adding Alan to the CC list.)
On 10/01/2013 10:51 PM, Vinson Lee wrote:
On Mon, Sep 30, 2013 at 10:21 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
On 09/27/2013 06:24 PM, Emil Velikov wrote:
* With the recent split of the intel driver codebase, the new i965
headers has been getting a
The maximum number of atomic buffer objects is somewhat arbitrary, we
can change it in the future easily if it turns out it's not enough...
v2: Add comments with the relevant mesa dirty bits. Fix usage of
BRW_NEW_UNIFORM_BUFFER in the GS ABO state atom.
v3: Update binding table layout
---
src/mesa/drivers/dri/i965/brw_context.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_context.h
b/src/mesa/drivers/dri/i965/brw_context.h
index 4423862..420e630 100644
--- a/src/mesa/drivers/dri/i965/brw_context.h
+++
---
src/mesa/drivers/dri/i965/brw_context.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.h
b/src/mesa/drivers/dri/i965/brw_context.h
index 1407f20..4423862 100644
--- a/src/mesa/drivers/dri/i965/brw_context.h
+++
On Oct 2, 2013 9:29 PM, Francisco Jerez curroje...@riseup.net wrote:
The maximum number of atomic buffer objects is somewhat arbitrary, we
can change it in the future easily if it turns out it's not enough...
v2: Add comments with the relevant mesa dirty bits. Fix usage of
Paul Berry stereotype...@gmail.com writes:
Previously, we computed dFdy() using the following instruction:
add(8) dst1F src4,4,0)F -src.24,4,0F { align1 1Q }
That had the disadvantage that it computed the same value for all 4
pixels of a 2x2 subspan, which meant that it was less accurate
On Wed, Oct 2, 2013 at 10:48 AM, Eric Anholt e...@anholt.net wrote:
Chad Versace chad.vers...@linux.intel.com writes:
In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's
physical dimensions. (Logical and physical dimensions may differ for
multisample surfaces).
However,
On Wed, Oct 02, 2013 at 12:41:16PM -0700, Jordan Justen wrote:
On Wed, Oct 2, 2013 at 10:48 AM, Eric Anholt e...@anholt.net wrote:
Chad Versace chad.vers...@linux.intel.com writes:
In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's
physical dimensions. (Logical and
Emil Velikov emil.l.veli...@gmail.com writes:
On 30/09/13 21:44, Eric Anholt wrote:
Here are the megadrivers changes, after the prep series I posted earlier.
A few tiny updates to the prep series are available in my tree as
megadriver-prep and this series is available as megadrivers-5
FPS
On Wed, Oct 2, 2013 at 11:02 AM, Ian Romanick i...@freedesktop.org wrote:
(Adding Alan to the CC list.)
On 10/01/2013 10:51 PM, Vinson Lee wrote:
On Mon, Sep 30, 2013 at 10:21 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
On 09/27/2013 06:24 PM, Emil Velikov wrote:
* With the recent
Marek Olšák mar...@gmail.com writes:
On Mon, Sep 30, 2013 at 10:44 PM, Eric Anholt e...@anholt.net wrote:
The previous interface relied on a static struct, which meant tha the
driver didn't get a chance to edit the struct before the struct got used.
For megadrivers, I want to return a
Emil Velikov emil.l.veli...@gmail.com writes:
On 30/09/13 21:44, Eric Anholt wrote:
Previously, we've split things such that mesa core is in libdricore,
exposing the whole Mesa core interface in the global namespace, and the
i965_dri.so code all links against that. Along with polluting
On 10/02/2013 12:51 PM, Matt Turner wrote:
On Wed, Oct 2, 2013 at 11:02 AM, Ian Romanick i...@freedesktop.org wrote:
(Adding Alan to the CC list.)
On 10/01/2013 10:51 PM, Vinson Lee wrote:
On Mon, Sep 30, 2013 at 10:21 PM, Kenneth Graunke kenn...@whitecape.org
wrote:
On 09/27/2013 06:24
https://bugs.freedesktop.org/show_bug.cgi?id=70054
Priority: medium
Bug ID: 70054
Keywords: regression
CC: i...@freedesktop.org, kenn...@whitecape.org
Assignee: mesa-dev@lists.freedesktop.org
Summary: EnumStrings.LookUpByNumber
https://bugs.freedesktop.org/show_bug.cgi?id=70057
Priority: medium
Bug ID: 70057
Keywords: regression
CC: emil.l.veli...@gmail.com, johannesoberm...@gmx.de,
tstel...@gmail.com
Assignee: mesa-dev@lists.freedesktop.org
On 10/02/2013 10:48 AM, Eric Anholt wrote:
Chad Versace chad.vers...@linux.intel.com writes:
In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's
physical dimensions. (Logical and physical dimensions may differ for
multisample surfaces).
However, in SURFACE_STATE, we always
https://bugs.freedesktop.org/show_bug.cgi?id=70057
Johannes Obermayr johannesoberm...@gmx.de changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop.
All texture instructions can use offsets, not just TXF. Offsets into
the literals array were wrong, too.
---
src/gallium/drivers/r600/r600_shader.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_shader.c
With commit cb1febb07, I have incorrectly removed HAVE_COMMON_DRI
assuming that swrast does not need to build the the translations
for driconf options, as effectively swrast/drisw does not use them.
With the incomming unification work of dri and drisw, it makes
sense just to revert the offending
On 03.10.2013 00:12, Grigori Goronzy wrote:
All texture instructions can use offsets, not just TXF. Offsets into
the literals array were wrong, too.
BTW, I just noticed it now: this fixes the fs-textureOffset-2D piglit
test, which unfortunately does not appear to be part of any of the test
On 10/02/2013 03:27 PM, Emil Velikov wrote:
With commit cb1febb07, I have incorrectly removed HAVE_COMMON_DRI
assuming that swrast does not need to build the the translations
^^^
Just the. :)
for driconf options, as effectively swrast/drisw
On 10/02/2013 11:46 AM, Adrian M Negreanu wrote:
On Oct 2, 2013 9:29 PM, Francisco Jerez curroje...@riseup.net
mailto:curroje...@riseup.net wrote:
The maximum number of atomic buffer objects is somewhat arbitrary, we
can change it in the future easily if it turns out it's not enough...
With commit cb1febb07, I have incorrectly removed HAVE_COMMON_DRI
assuming that swrast does not need to build the translations for
driconf options, as effectively swrast/drisw does not use them.
With the incoming unification work of dri and drisw, it makes
sense just to revert the offending hunk.
I don't understand. All piglit tests should be listed in all.tests. Is
it not the case with fs-textureOffset-2D?
Marek
On Thu, Oct 3, 2013 at 12:36 AM, Grigori Goronzy g...@chown.ath.cx wrote:
On 03.10.2013 00:12, Grigori Goronzy wrote:
All texture instructions can use offsets, not just TXF.
On 10/02/2013 04:20 PM, Marek Olšák wrote:
I don't understand. All piglit tests should be listed in all.tests. Is
it not the case with fs-textureOffset-2D?
I think that's a shader_runner test (file name is *.shader_test).
shader_runner tests aren't explicitly listed in all.tests. Instead some
On 30 September 2013 03:08, Chris Forbes chr...@ijw.co.nz wrote:
From: Maxence Le Dore maxence.led...@gmail.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
This patch broke make check for me. src/mesa/main/tests/test-suite.log
shows:
That's news to me that all tests must be part of all.tests. You can
blame me for that, I thought there were others not being part of
all.tests, but the README indeed states all new tests must be part of
it. So maybe the only tests not added there are those I wrote :-).
Roland
Am 03.10.2013
On 10/02/2013 05:08 PM, Roland Scheidegger wrote:
That's news to me that all tests must be part of all.tests. You can
blame me for that, I thought there were others not being part of
all.tests, but the README indeed states all new tests must be part of
it. So maybe the only tests not added
Hi Paul,
Sorry, I should have run make check first.
I'll fix this when I get home.
-- Chris
On Thu, Oct 3, 2013 at 1:06 PM, Paul Berry stereotype...@gmail.com wrote:
On 30 September 2013 03:08, Chris Forbes chr...@ijw.co.nz wrote:
From: Maxence Le Dore maxence.led...@gmail.com
On 10/02/2013 05:03 PM, Ian Romanick wrote:
On 10/02/2013 04:20 PM, Marek Olšák wrote:
I don't understand. All piglit tests should be listed in all.tests. Is
it not the case with fs-textureOffset-2D?
I think that's a shader_runner test (file name is *.shader_test).
shader_runner tests
Not all tests have to be part of all.tests, like the
framebuffer_blit_scaled ones, because they are more strict than the
spec mandates.
However generally, all tests that it makes sense to test regularly
should be listed in all.tests. I only use quick.tests, which is the
only way I use piglit. I
This patch series adds the necessary machinery to the GLSL compiler to
allow shaders to redeclare the gl_PerVertex interface block. Although
the precise rules for how to redeclare gl_PerVertex were not published
until GLSL 4.10, it seems clear from context that this was intended as
a
We use a location of -1 for variables which don't have their own
assigned locations--this includes ir_variables which represent named
interface blocks. Technically the location assigned to gl_in doesn't
matter, since gl_in is only accessed via its members (which have their
own locations). But
Previously, we erroneously used the name gl_in for both the block
name and the instance name.
---
src/glsl/builtin_variables.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp
index 3667dc8..91518ba 100644
---
Although these interfaces can't be accessed directly by GLSL (since
they don't have an instance name), they will be necessary in order to
allow redeclarations of gl_PerVertex.
---
src/glsl/builtin_variables.cpp | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
In commit e2660770731b018411fbe1620cacddaf8dff5287 (glsl: Keep track
of location for interface block fields), I neglected to update
glsl_type::record_key_compare to account for the fact that interface
types now contain location information. As a result, interface types
that differ only by their
GLSL reserves identifiers beginning with gl_ or containing __, but
we haven't been consistent about enforcing this rule. This patch
makes a new function to check whether identifier names are valid. In
the process it closes a loophole where we would previously allow
function argument names to
Note: some limited amount of redeclaration is actually allowed,
provided the shader is redeclaring the built-in gl_PerVertex interface
block. Support for this will be added in future patches.
Fixes piglit tests
Note: we need to make an exception for the gl_PerVertex interface
block, since this is allowed to be redeclared. Future patches will
make redeclaration of gl_PerVertex work properly.
Fixes piglit test
spec/glsl-1.50/compiler/interface-block-name-uses-gl-prefix.vert.
---
src/glsl/ast_to_hir.cpp
Note: we need to make an exception for the gl_PerVertex interface
block, since built-in variables are allowed to be redeclared inside
it. Future patches will make redeclaration of gl_PerVertex work
properly.
Fixes piglit tests:
-
Note: we need to make an exception for the gl_PerVertex interface
block, since in geometry shaders it is allowed to be redeclared with
the instance name gl_in. Future patches will make redeclaration of
gl_PerVertex work properly.
Fixes piglit test
Fixes piglit test
spec/glsl-1.10/compiler/struct/struct-name-uses-gl-prefix.vert.
---
src/glsl/ast_to_hir.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index bb14fc9..8fb7f2f 100644
--- a/src/glsl/ast_to_hir.cpp
+++
This patch modifies the get_variable_being_redeclared() function so
that it no longer relies on the ast_declaration for the variable being
redeclared. In future patches, this will allow
get_variable_being_redeclared() to be used for processing
redeclarations of the built-in gl_PerVertex interface
This will be used by future patches to change an ir_variable's
interface type when the gl_PerVertex built-in interface block is
redeclared.
---
src/glsl/ir.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/glsl/ir.h b/src/glsl/ir.h
index 25c7e82..595c935 100644
In later patches, we'll use this in order to implement the required
behaviour that after the gl_PerVertex interface block has been
redeclared, only members of the redeclared interface block may be
used.
---
src/glsl/glsl_symbol_table.cpp | 9 +
src/glsl/glsl_symbol_table.h | 7 +++
This patch verifies that:
- The gl_PerVertex input interface block may only be redeclared in a
geometry shader, and that it may only be redeclared as gl_in[].
- The gl_PerVertex output interface block may only be redeclared in a
vertex or geometry shader, and that it may only be redeclared
Fixes piglit tests:
- spec/glsl-1.50/execution/redeclare-pervertex-out-subset-gs
- spec/glsl-1.50/execution/redeclare-pervertex-subset-vs
---
src/glsl/ast_to_hir.cpp | 62 +++--
1 file changed, 60 insertions(+), 2 deletions(-)
diff --git
From section 4.1.9 (Arrays) of the GLSL 4.40 spec (as of revision 7):
However, unless noted otherwise, blocks cannot be redeclared;
an unsized array in a user-declared block cannot be sized
through redeclaration.
The only place where the spec notes that interface blocks can be
Fixes piglit test
spec/glsl-1.50/execution/redeclare-pervertex-subset-vs-to-gs.
---
src/glsl/ast_to_hir.cpp | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index f44e97d..a4af562 100644
---
Fixes piglit tests:
- spec/glsl-1.50/compiler/gs-redeclares-pervertex-in-after-other-usage.geom
- spec/glsl-1.50/compiler/gs-redeclares-pervertex-out-after-other-usage.geom
- spec/glsl-1.50/compiler/gs-redeclares-pervertex-out-after-usage.geom
-
In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's
physical dimensions. (Logical and physical dimensions may differ for
multisample surfaces).
However, in SURFACE_STATE, we always set Width and Height to the slice's
logical dimensions. We should do the same for
Currently, we create just a single gl_PerVertex interface block for
geometry shader inputs. In later patches, we'll also need to create
an interface block for geometry and vertex shader outputs. Moving the
code into its own class will make reuse easier.
---
src/glsl/builtin_variables.cpp | 72
Clean up inconsistency in enum decoration:
- Use the undecorated enums where possible.
- MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB remains decorated, since it
has no undecorated equivalent in GL4.
Signed-off-by: Chris Forbes chr...@ijw.co.nz
---
src/mapi/glapi/gen/ARB_texture_gather.xml | 6
Maarten Lankhorst maarten.lankho...@canonical.com writes:
The 9.2 branch is falling a bit behind. I'm going to trickle out
patches to the stable branch over the next few days / week. My plan is
to do 9.2.1 during the week of XDC.
...
Waiting for mesa 9.2.1. :D
And I interfered with Ian's
Just want to check an inconsistency,
so GL clears respect glDepthMask, gallium docs don't explicitly
mention depth masking, they say clear isn't affected by color or
stencil write masks, should that sentence contain depth?
Dave.
___
mesa-dev mailing
63 matches
Mail list logo
