Re: [Mesa-dev] [PATCH 10/12] i965/fs: Reimplement emit_texture() in terms of logical send messages.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:41 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 66 +--- 1

[Mesa-dev] [PATCH] gallium/util: Stop bundling our snprintf implementation.

2015-07-22 Thread Jose Fonseca
Use MSVCRT functions instead. Their semantics are slightly different but they can be made to work as expected. Also, use the same code paths for both MSVCRT and MinGW. No testing yet. Just built. https://bugs.freedesktop.org/show_bug.cgi?id=91418 --- src/gallium/auxiliary/Makefile.sources |

Re: [Mesa-dev] [PATCH] targets/dri: scons: add missing link against libdrm

2015-07-22 Thread Jose Fonseca
On 22/07/15 16:04, Emil Velikov wrote: Otherwise the final dri module will have (additional) unresolved symbols. Cc: Brian Paul bri...@vmware.com Cc: Jose Fonseca jfons...@vmware.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- We can only fix the remaining unresolved symbols

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:31 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: A few comments below. Mostly just asking for explanation. 1-3 are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com Obviously, don't merge 4/4 until it actually

Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-22 Thread Emil Velikov
It should be in master now. -Emil On 21 July 2015 at 23:34, Dylan Baker baker.dyla...@gmail.com wrote: Cool, I was under that impression too, but having it confirmed is great. Since these do matter and I don't have push access, could you make sure this lands? On Jul 21, 2015 15:33, Emil

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-22 Thread Jose Fonseca
On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca jfons...@vmware.com wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov emil.l.veli...@gmail.com writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful hints to the compiler in the absence

Re: [Mesa-dev] [PATCH 04/12] i965/fs: Pass a BAD_FILE header source to LOAD_PAYLOAD in emit_texture_gen7().

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:43 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez curroje...@riseup.net wrote: So that it's left uninitialized by LOAD_PAYLOAD, we only need to reserve space for it in

Re: [Mesa-dev] [PATCH 12/12] i965/fs: Reimplement emit_single_fb_write() in terms of logical framebuffer writes.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:54 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Thu, Jul 16, 2015 at 8:41 AM, Francisco Jerez curroje...@riseup.net wrote: The only non-trivial thing it still has to do is figure out where to take the src/dst

Re: [Mesa-dev] [PATCH 09/12] i965/fs: Hook up SIMD lowering to handle texturing opcodes of unsupported width.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:55 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez curroje...@riseup.net wrote: This should match the set of cases in which we currently call fail() or no16() from the

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #3 from Ilia Mirkin imir...@alum.mit.edu --- (In reply to Brian Paul from comment #1) Hmm, I can't reproduce that. The test passes completely for me. What driver are you using? I'm testing llvmpipe/softpipe. Odd. I repro with

Re: [Mesa-dev] [PATCH 18/78] i965: Take is_scalar_shader_stage() method out to allow reuse

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 4:26 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 07/13/2015 01:38 PM, Jason Ekstrand wrote: On Fri, Jul 10, 2015 at 8:53 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 06/30/2015 06:58 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 63 +++- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Brian Paul
On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after the format/type checks so that we don't bail out with success on a width/height/depth == 0

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Wed, Jul 22, 2015 at 12:31 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: A few comments below. Mostly just asking for explanation. 1-3 are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 10:02 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 63 +++- 1

Re: [Mesa-dev] [PATCH 04/12] i965/fs: Pass a BAD_FILE header source to LOAD_PAYLOAD in emit_texture_gen7().

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Wed, Jul 22, 2015 at 12:43 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez curroje...@riseup.net wrote: So that it's left uninitialized by

Re: [Mesa-dev] [PATCH] gallium/util: Stop bundling our snprintf implementation.

2015-07-22 Thread Brian Paul
On 07/22/2015 10:15 AM, Jose Fonseca wrote: Use MSVCRT functions instead. Their semantics are slightly different but they can be made to work as expected. Also, use the same code paths for both MSVCRT and MinGW. No testing yet. Just built. https://bugs.freedesktop.org/show_bug.cgi?id=91418

Re: [Mesa-dev] [PATCH 1/2] mesa: adjust error message when there's a missing teximage

2015-07-22 Thread Brian Paul
On 07/22/2015 11:02 AM, Ilia Mirkin wrote: The current message makes it seem like the zoffset is invalid. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/main/texgetimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/texgetimage.c

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #4 from Brian Paul bri...@vmware.com --- OK, the problem is my local copy of getteximage-invalid-format-for-packed-type.c has the patch ext_packed_float: fix getteximage-invalid-format-for-packed-type test which I posted for review

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-22 Thread Jason Ekstrand
This needs a *lot* more commentary. These calculations are extremely tricky and there are almost no comments. For instance, you are turning a 2D offset on a tiled surface into a new 2D address into the raw view of the surface. Nowhere do you explain what the raw surface looks like and how its

[Mesa-dev] [PATCH 1/2] mesa: adjust error message when there's a missing teximage

2015-07-22 Thread Ilia Mirkin
The current message makes it seem like the zoffset is invalid. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/main/texgetimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 59ec091..2f35ac6

[Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Ilia Mirkin
This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after the format/type checks so that we don't bail out with success on a width/height/depth == 0 request when the format/type don't match.

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 63 +++- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Wed, Jul 22, 2015 at 10:02 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 10:16 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Wed, Jul 22, 2015 at 10:02 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Tue, Jul 21, 2015 at 9:38 AM, Francisco

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Brian Paul
On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul bri...@vmware.com wrote: On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the

Re: [Mesa-dev] [PATCH 06/14] meta: Don't do fragment color clamping in case of ReadPixels

2015-07-22 Thread Anuj Phogat
On Tue, Jul 21, 2015 at 1:18 AM, Iago Toral ito...@igalia.com wrote: On Tue, 2015-07-21 at 09:24 +0200, Iago Toral wrote: On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: Without this patch, piglit test arb_color_buffer_float-readpixels fails, when forced to use the meta pbo path.

Re: [Mesa-dev] [PATCH 09/20] i965/fs: Import image format conversion primitives.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: Define bitfield packing, unpacking and type conversion operations in terms of which the image format conversion code will be implemented. These don't directly know about image formats: The packing and unpacking

Re: [Mesa-dev] [PATCH] mesa: initialize variables to silence compiler warnings

2015-07-22 Thread Anuj Phogat
On Tue, Jul 21, 2015 at 5:42 PM, Brian Paul bri...@vmware.com wrote: --- src/mesa/main/fbobject.c | 4 ++-- src/mesa/main/shaderapi.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index f46554b..cc342c2 100644

[Mesa-dev] [PATCH] glx: Fix build warnings for PURE being redefined.

2015-07-22 Thread Eric Anholt
We can't completely drop this #define because it's used in the xserver generated code. Until someone gets around to putting xml generation directly in the server, we're stuck #defining it for them. --- src/mapi/glapi/gen/gl_XML.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

Re: [Mesa-dev] [PATCH v2 1/7] nouveau: implement the nvif hardware performance counters interface

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This commit implements the base interface for hardware performance counters that will be shared between nv50 and nvc0 drivers. TODO: Bump libdrm version of mesa when nvif will be merged. Changes since v2: - remove double-query thing for domains,

Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-07-22 Thread Ian Romanick
On 06/26/2015 07:38 AM, Ilia Mirkin wrote: On Fri, Jun 26, 2015 at 4:18 AM, Tapani Pälli tapani.pa...@intel.com wrote: On 06/26/2015 01:06 AM, Ilia Mirkin wrote: On Thu, Jun 25, 2015 at 4:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jun 25, 2015 at 5:08 AM, Marta Lofstedt

[Mesa-dev] [PATCH v2 06/14] meta: Don't do fragment color clamping in _mesa_meta_pbo_GetTexSubImage

2015-07-22 Thread Anuj Phogat
_mesa_meta_pbo_GetTexSubImage() uses _mesa_meta_BlitFrameBuffer(), which will do fragment clamping if enabled. But fragment clamping doesn't affect ReadPixels and GetTexImage. Without this patch, piglit test arb_color_buffer_float-clear fails, when forced to use the meta pbo path. v2: Apply this

Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-07-22 Thread Ilia Mirkin
On Wed, Jul 22, 2015 at 2:55 PM, Ian Romanick i...@freedesktop.org wrote: On 06/26/2015 07:38 AM, Ilia Mirkin wrote: On Fri, Jun 26, 2015 at 4:18 AM, Tapani Pälli tapani.pa...@intel.com wrote: On 06/26/2015 01:06 AM, Ilia Mirkin wrote: On Thu, Jun 25, 2015 at 4:22 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-22 Thread Jose Fonseca
On 22/07/15 17:13, Jose Fonseca wrote: On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca jfons...@vmware.com wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov emil.l.veli...@gmail.com writes: On 14/07/15 19:45, Eric Anholt wrote: These are really

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Ilia Mirkin
On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul bri...@vmware.com wrote: On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after the format/type checks so

Re: [Mesa-dev] [PATCH] radeon: Silence GCC unused-but-set-variable warnings.

2015-07-22 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jul 22, 2015 at 7:04 AM, Vinson Lee v...@freedesktop.org wrote: radeon_fbo.c: In function 'radeon_map_renderbuffer_s8z24': radeon_fbo.c:162:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable] int ret;

Re: [Mesa-dev] [PATCH v2 2/7] nv50: allocate a software object class

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This will allow to monitor global performance counters through the command stream of the GPU instead of using ioctls. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 11 +++

Re: [Mesa-dev] [PATCH 07/14] mesa: Set green, blue channels to zero only for formats with these components

2015-07-22 Thread Iago Toral
On Tue, 2015-07-21 at 11:13 -0700, Anuj Phogat wrote: On Tue, Jul 21, 2015 at 12:50 AM, Iago Toral ito...@igalia.com wrote: On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/common/meta.c | 13 ++--- 1

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: A few comments below. Mostly just asking for explanation. 1-3 are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com Obviously, don't merge 4/4 until it actually has users. --Jason Thanks. On Thu, Jul 16, 2015 at 8:35 AM, Francisco Jerez

Re: [Mesa-dev] [PATCH 09/12] i965/fs: Hook up SIMD lowering to handle texturing opcodes of unsupported width.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez curroje...@riseup.net wrote: This should match the set of cases in which we currently call fail() or no16() from the emit_texture_*() methods and the ones in which emit_texture_gen4() enables the

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #38 from Heiko lil_...@web.de --- (In reply to Antoine Labour from comment #37) Can you make glXWaitX re-evaluate window sizes? That's the reason we call it - we just resized the window, we want to make sure we're drawing to the

Re: [Mesa-dev] [PATCH mesa 2/2] egl: android: remove DRM_GRALLOC_TOP hack

2015-07-22 Thread Varad Gautam
On Tuesday, July 21, 2015 03:36:32 PM Emil Velikov wrote: Now that the drm_gralloc module exports the correct includes we can get rid of this hack. Cc: Varad Gautam varadgau...@gmail.com Cc: Chih-Wei Huang cwhu...@android-x86.org Cc: Eric Anholt e...@anholt.net Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH v2] android: rework the EGL build

2015-07-22 Thread Varad Gautam
On Tuesday, July 21, 2015 03:27:47 PM Emil Velikov wrote: See previous two commits for details. v2: Don't forget git mv, bring back DRM_GRALLOC_TOP. Spotted by Varad. Cc: Varad Gautam varadgau...@gmail.com Cc: Chih-Wei Huang cwhu...@android-x86.org Cc: Eric Anholt e...@anholt.net

Re: [Mesa-dev] [PATCH 05/14] meta: Abort meta pbo path if readpixels need signed-unsigned conversion

2015-07-22 Thread Iago Toral
On Tue, 2015-07-21 at 17:05 -0700, Anuj Phogat wrote: On Tue, Jul 21, 2015 at 1:36 AM, Iago Toral ito...@igalia.com wrote: On Tue, 2015-07-21 at 08:13 +0200, Iago Toral wrote: On Mon, 2015-07-20 at 10:56 -0700, Anuj Phogat wrote: On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral

Re: [Mesa-dev] [PATCH 18/78] i965: Take is_scalar_shader_stage() method out to allow reuse

2015-07-22 Thread Eduardo Lima Mitev
On 07/13/2015 01:38 PM, Jason Ekstrand wrote: On Fri, Jul 10, 2015 at 8:53 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 06/30/2015 06:58 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: This patch makes public the

[Mesa-dev] [PATCH] i965/fs: Fix calculation of the number of registers read in opt_copy_propagate.

2015-07-22 Thread Francisco Jerez
This seems to have been multiplying by stride twice since fs_inst::regs_read/regs_written were changed to return the value in register units rather than in dispatch_width-wide components. The value returned by fs_inst::regs_read() already takes into account the stride so it's wrong to do it again

Re: [Mesa-dev] [PATCH 02/12] st/dri: fix EGL_KHR_fence_sync since the last radeonsi change broke it

2015-07-22 Thread Michel Dänzer
On 17.07.2015 01:54, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Broken by f1be3d8cdde17a9b9ae283e1bab2f46b992d3bf3, which returns NULL if no commands have been submitted. I've fixed that in radeonsi, so you can drop this patch. -- Earthling Michel Dänzer |

Re: [Mesa-dev] [PATCH 16/78] i965/nir/vec4: Implement store_output intrinsic

2015-07-22 Thread Eduardo Lima Mitev
On 07/13/2015 01:57 PM, Jason Ekstrand wrote: On Wed, Jul 8, 2015 at 11:54 PM, Eduardo Lima Mitev el...@igalia.com wrote: On 06/30/2015 06:51 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: The index into the output_reg array where to

Re: [Mesa-dev] [PATCH 10/12] i965/fs: Reimplement emit_texture() in terms of logical send messages.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 66 +--- 1 file changed, 49 insertions(+), 17 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 04/12] i965/fs: Pass a BAD_FILE header source to LOAD_PAYLOAD in emit_texture_gen7().

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez curroje...@riseup.net wrote: So that it's left uninitialized by LOAD_PAYLOAD, we only need to reserve space for it in the message since it will be initialized implicitly by the generator. ---

Re: [Mesa-dev] [PATCH 12/12] i965/fs: Reimplement emit_single_fb_write() in terms of logical framebuffer writes.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Thu, Jul 16, 2015 at 8:41 AM, Francisco Jerez curroje...@riseup.net wrote: The only non-trivial thing it still has to do is figure out where to take the src/dst depth values from and predicate the instruction if discard is in use. The manual

Re: [Mesa-dev] [PATCH 01/12] i965/fs: Define logical framebuffer write opcode.

2015-07-22 Thread Francisco Jerez
Kenneth Graunke kenn...@whitecape.org writes: On Thursday, July 16, 2015 06:41:16 PM Francisco Jerez wrote: The logical variant is largely equivalent to the original opcode but instead of taking a single payload source it expects the arguments that make up the payload separately as individual

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 Bug ID: 91425 Summary: [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails Product: Mesa Version: git Hardware: Other

Re: [Mesa-dev] [PATCH v2 4/7] nv50: configure the ring buffer for reading back PM counters

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: To write data at the right offset, the kernel has to know some parameters of this ring buffer, like the number of domains and the maximum number of queries. Changes since v2: - only configure the ring buffer if the notifier BO is allocated - only use

Re: [Mesa-dev] [PATCH 17/20] i965/fs: Handle image uniforms in NIR programs.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: v2: Move the image_params array back to brw_stage_prog_data. --- src/mesa/drivers/dri/i965/brw_fs.h | 1 + src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50 +++- 2 files changed,

Re: [Mesa-dev] [PATCH 18/20] i965/fs: Translate image load, store and atomic NIR intrinsics.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 149 +++ 1 file changed, 149 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Antoine Labour pi...@chromium.org changed: What|Removed |Added CC||pi...@chromium.org

[Mesa-dev] [PATCH] glsl/tests: fix varying_test since tess changes.

2015-07-22 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This fixes make check since the tess changes. Signed-off-by: Dave Airlie airl...@redhat.com --- src/glsl/tests/varyings_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/tests/varyings_test.cpp

[Mesa-dev] [PATCH] i965: fix warning since tess merge.

2015-07-22 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 6c97933..33469d4 100644

Re: [Mesa-dev] [PATCH] glsl/tests: fix varying_test since tess changes.

2015-07-22 Thread Michel Dänzer
On 23.07.2015 10:14, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This fixes make check since the tess changes. Signed-off-by: Dave Airlie airl...@redhat.com Tested-by: Michel Dänzer michel.daen...@amd.com Please push this to fix make check. -- Earthling Michel Dänzer

[Mesa-dev] [PATCH 1/2] i965: fix warning since tess merge.

2015-07-22 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 6c97933..33469d4 100644

[Mesa-dev] [PATCH] docs/GL3.txt: ARB_shader_precision

2015-07-22 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This extension is about setting expectation on GL4.1 implementations rather than actually enforcing things. So once you support GLSL 410 then you support this in theory. Signed-off-by: Dave Airlie airl...@redhat.com --- docs/GL3.txt | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] docs/GL3.txt: ARB_shader_precision

2015-07-22 Thread Ilia Mirkin
In actuality it'll only be exposed on nvc0 atm... On Wed, Jul 22, 2015 at 9:20 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This extension is about setting expectation on GL4.1 implementations rather than actually enforcing things. So once you support GLSL 410

[Mesa-dev] [PATCH] glsl: Allow token pasting in ESSL

2015-07-22 Thread Ryan Houdek
All vendors I've tested allow token pasting in their ESSL shaders. At least one application expects this to be supported even though it is against spec. This would be the Dolphin GameCube/Wii emulator that requires this. The vendors I've tested that is known to support this is: ARM Mali Qualcomm

Re: [Mesa-dev] [PATCH v2 06/14] meta: Don't do fragment color clamping in _mesa_meta_pbo_GetTexSubImage

2015-07-22 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Wed, 2015-07-22 at 11:54 -0700, Anuj Phogat wrote: _mesa_meta_pbo_GetTexSubImage() uses _mesa_meta_BlitFrameBuffer(), which will do fragment clamping if enabled. But fragment clamping doesn't affect ReadPixels and GetTexImage. Without

Re: [Mesa-dev] [PATCH 18/20] mesa: fill out the ARB_shader_subroutine APIs

2015-07-22 Thread Kenneth Graunke
On Tuesday, July 21, 2015 03:19:25 PM Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This fleshes out the APIs, using the program resource APIs where they should match. It also sets the default values to valid subroutines. Signed-off-by: Dave Airlie airl...@redhat.com ---

Re: [Mesa-dev] [PATCH 16/78] i965/nir/vec4: Implement store_output intrinsic

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 4:37 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 07/13/2015 01:57 PM, Jason Ekstrand wrote: On Wed, Jul 8, 2015 at 11:54 PM, Eduardo Lima Mitev el...@igalia.com wrote: On 06/30/2015 06:51 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 Samuel Iglesias sigles...@igalia.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 2/2] doxygen: Link GLvector4f struct members properly, avoiding invalid XML/HTML warning

2015-07-22 Thread rhyskidd
From: Rhys Kidd rhysk...@gmail.com Signed-off-by: Rhys Kidd rhysk...@gmail.com --- src/mesa/math/m_vector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/math/m_vector.h b/src/mesa/math/m_vector.h index 3b7f583..5bd76b8 100644 --- a/src/mesa/math/m_vector.h +++

[Mesa-dev] [PATCH 1/2] doxygen: Correct grammatical typo in math/m_vector.h

2015-07-22 Thread rhyskidd
From: Rhys Kidd rhysk...@gmail.com Signed-off-by: Rhys Kidd rhysk...@gmail.com --- src/mesa/math/m_vector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/math/m_vector.h b/src/mesa/math/m_vector.h index 8551ee7..3b7f583 100644 --- a/src/mesa/math/m_vector.h +++

[Mesa-dev] [PATCH] glsl: Fix a bug where LHS swizzles of swizzles were too small.

2015-07-22 Thread Kenneth Graunke
A simple shader such as vec4 color; color.xy.x = 1.0; would cause ir_assignment::set_lhs() to generate bogus IR: (swiz xy (swiz x (constant float (1.0 We were setting the number of components of each new RHS swizzle based on the highest channel used in the LHS swizzle. So, .xy.y

Re: [Mesa-dev] [PATCH 18/20] mesa: fill out the ARB_shader_subroutine APIs

2015-07-22 Thread Dave Airlie
On 23 July 2015 at 15:01, Kenneth Graunke kenn...@whitecape.org wrote: On Tuesday, July 21, 2015 03:19:25 PM Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This fleshes out the APIs, using the program resource APIs where they should match. It also sets the default values to valid

Re: [Mesa-dev] [PATCH v2 5/7] nv50: add support for compute/graphics global performance counters

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This commit adds support for both compute and graphics global performance counters which have been reverse engineered with CUPTI (Linux) and PerfKit (Windows). Currently, only one query type can be monitored at the same time because the Gallium's HUD

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-22 Thread Jose Fonseca
On 22/07/15 21:01, Jose Fonseca wrote: On 22/07/15 17:13, Jose Fonseca wrote: On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca jfons...@vmware.com wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov emil.l.veli...@gmail.com writes: On 14/07/15 19:45,

Re: [Mesa-dev] [PATCH v2 7/7] nv50: enable GL_AMD_performance_monitor

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This exposes a group of global performance counters that enables GL_AMD_performance_monitor. All piglit tests are okay. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 35

Re: [Mesa-dev] [PATCH v2 6/7] nv50: expose global performance counters to the HUD

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 41 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 1 + src/gallium/drivers/nouveau/nv50/nv50_screen.h | 3 ++

[Mesa-dev] [RFC 17/16] glsl: add AoA support for atmoic counters

2015-07-22 Thread Timothy Arceri
--- src/glsl/link_atomics.cpp | 73 +++ 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/src/glsl/link_atomics.cpp b/src/glsl/link_atomics.cpp index 100d03c..21f9af7 100644 --- a/src/glsl/link_atomics.cpp +++ b/src/glsl/link_atomics.cpp

[Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Brian Paul
Hi Marek, This is regarding your commit st/mesa: use pipe_sampler_view_release for releasing sampler views from last October. Basically, we have: void st_texture_release_all_sampler_views(struct st_context *st, struct st_texture_object *stObj) { GLuint

[Mesa-dev] [RFC 18/16] nir: wrapper for glsl_type arrays_of_arrays_size()

2015-07-22 Thread Timothy Arceri
--- src/glsl/nir/nir_types.cpp | 6 ++ src/glsl/nir/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp index 62176f5..06f5b0a 100644 --- a/src/glsl/nir/nir_types.cpp +++ b/src/glsl/nir/nir_types.cpp @@ -106,6 +106,12 @@

[Mesa-dev] [RFC 19/16] nir: add atomic lowering support for AoA

2015-07-22 Thread Timothy Arceri
--- src/glsl/nir/nir_lower_atomics.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/glsl/nir/nir_lower_atomics.c b/src/glsl/nir/nir_lower_atomics.c index ce3615a..e5ec008 100644 --- a/src/glsl/nir/nir_lower_atomics.c +++

[Mesa-dev] [Bug 90311] Fail to build libglx with clang at linking stage

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90311 Julien Isorce julien.iso...@gmail.com changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-22 Thread Jason Ekstrand
This all looks correct as far as I can tell. However, I'm very concerned about the number of checks such as has_matching_typed_format() that are built-in to the compiler (via surface_builder) where we then go on to do something that is highly dependant on state setup doing the exact same check

Re: [Mesa-dev] [PATCH 20/20] i965: Expose ARB_shader_image_load_store.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez curroje...@riseup.net wrote: Reviewed-by: Paul Berry stereotype...@gmail.com I'm sure that Paul still thinks this patch does what the commit message says. However, does the r-b really still apply to the rest of it? ---

Re: [Mesa-dev] [PATCH 07/20] glsl/types: add new subroutine type (v3.1)

2015-07-22 Thread Kenneth Graunke
On Tuesday, July 21, 2015 03:19:14 PM Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This type will be used to store the name of subroutine types as in subroutine void myfunc(void); will store myfunc into a subroutine type. This is required to the parser can identify a

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 10:05 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Wed, Jul 22, 2015 at 12:31 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: A few comments below. Mostly just asking

[Mesa-dev] [RFC] AoA atomic counter follow-up fixes

2015-07-22 Thread Timothy Arceri
Hi Guys, These patches fix up AoA support for atomic counters following my change in approach to uniforms in V2 of my AoA GLES series. However I wanted to get some feedback mainly on the first patch as the end result is the whole AoA is marked as active which doesnt happen on Nvidia drivers. I

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Brian Paul
On 07/22/2015 05:31 PM, Jose Fonseca wrote: On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit st/mesa: use pipe_sampler_view_release for releasing sampler views from last October. Basically, we have: void st_texture_release_all_sampler_views(struct st_context *st,

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Jose Fonseca
On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit st/mesa: use pipe_sampler_view_release for releasing sampler views from last October. Basically, we have: void st_texture_release_all_sampler_views(struct st_context *st, struct

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Jose Fonseca
On 23/07/15 01:00, Brian Paul wrote: On 07/22/2015 05:31 PM, Jose Fonseca wrote: On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit st/mesa: use pipe_sampler_view_release for releasing sampler views from last October. Basically, we have: void

[Mesa-dev] [PATCH 2/2] dispatch_sanity.cpp: remove commented out tess entries

2015-07-22 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com These entries were put in the GL4.0 section, so removed the commented out ones. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/tests/dispatch_sanity.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 13/14] mesa: Change the signature of _mesa_need_rgb_to_luminance_conversion()

2015-07-22 Thread Iago Toral
Looks good to me, if this did not introduce any regressions: Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: This allows us to handle cases when texImage-_BaseFormat doesn't match _mesa_format_get_base_format(texImage-Format). _BaseFormat

Re: [Mesa-dev] [PATCH 14/14] meta: Use _mesa_need_rgb_to_luminance_conversion() in decompress_texture_image()

2015-07-22 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/common/meta.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #2 from Michel Dänzer mic...@daenzer.net --- FWIW, I got the same regression with radeonsi. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [PATCH] targets/dri: scons: add missing link against libdrm

2015-07-22 Thread Emil Velikov
Otherwise the final dri module will have (additional) unresolved symbols. Cc: Brian Paul bri...@vmware.com Cc: Jose Fonseca jfons...@vmware.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- We can only fix the remaining unresolved symbols (_glapi_foo), as we remove the non-shared

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #1 from Brian Paul bri...@vmware.com --- Hmm, I can't reproduce that. The test passes completely for me. What driver are you using? I'm testing llvmpipe/softpipe. -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 91387] Mesa 10.6.1 implementation error: invalid target in _swrast_choose_texture_sample_func

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91387 --- Comment #3 from Michael Godfrey michaeldgodf...@gmail.com --- Created attachment 117297 -- https://bugs.freedesktop.org/attachment.cgi?id=117297action=edit backtrace -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH V2 12/14] meta: Fix reading luminance texture as rgba in _mesa_meta_pbo_GetTexSubImage()

2015-07-22 Thread Iago Toral
The problem here is that the _mesa_meta_BlitFramebuffer is not setting G/B channels to 0.0 when doing Luminance/Intensity to RGBA conversions, so why not implement the fix in _mesa_meta_BlitFramebuffer directly? The GL spec expects frambuffer blits to handle these conversions properly, so it looks

Re: [Mesa-dev] [PATCH 11/14] meta: Use _mesa_need_luminance_to_rgb_conversion() in decompress_texture_image()

2015-07-22 Thread Iago Toral
Patches 10-11 are Reviewed-by: Iago Toral Quiroga ito...@igalia.com On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/common/meta.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [Bug 91387] Mesa 10.6.1 implementation error: invalid target in _swrast_choose_texture_sample_func

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91387 Brian Paul bri...@vmware.com changed: What|Removed |Added CC||anuj.pho...@gmail.com ---

  1   2   >