Re: [Mesa-dev] [PATCH] i965: Skip update_texture_surface when the plane doesn't exist

2016-06-24 Thread Jason Ekstrand
On Fri, Jun 24, 2016 at 9:02 PM, Mark Janes wrote: > On snb and ilk, this patch breaks > piglit.spec.ext_image_dma_buf_import.ext_image_dma_buf_import-sample_nv1 > > https://bugs.freedesktop.org/show_bug.cgi?id=96674 Looks like rebase fail to me. > > Jordan Justen

Re: [Mesa-dev] [PATCH] i965: Skip update_texture_surface when the plane doesn't exist

2016-06-24 Thread Mark Janes
On snb and ilk, this patch breaks piglit.spec.ext_image_dma_buf_import.ext_image_dma_buf_import-sample_nv1 https://bugs.freedesktop.org/show_bug.cgi?id=96674 Jordan Justen writes: > Reported-by: Grazvydas Ignotas > Bugzilla:

Re: [Mesa-dev] [PATCH] mesa: faster validation of sampler unit mapping for SSO

2016-06-24 Thread Timothy Arceri
On Fri, 2016-06-24 at 10:07 +0200, Gregory Hainaut wrote: > Code was inspired from _mesa_update_shader_textures_used > > However unlike _mesa_update_shader_textures_used that only check for > a single > stage, it will check all stages. > > It avoids to loop on all uniforms, only active samplers

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] intel: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi > --- > intel/intel_chipset.h | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Fri, 2016-06-24 at 22:06 +, Pandiyan, Dhinakaran wrote: > On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > > The spec has been updated adding new PCI IDs. > > > > Signed-off-by: Rodrigo Vivi > > --- > > include/drm/i915_pciids.h | 3 +++ > > 1 file

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi > --- > include/drm/i915_pciids.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/drm/i915_pciids.h

Re: [Mesa-dev] [PATCH] glsl: Ignore ir_texture in lower_const_arrays_to_uniforms.

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 7:26 PM, Kenneth Graunke wrote: > On Friday, June 24, 2016 7:03:35 PM PDT Ilia Mirkin wrote: >> On Fri, Jun 24, 2016 at 6:41 PM, Kenneth Graunke >> wrote: >> > The only part of an ir_texture which can be an array is the >> >

Re: [Mesa-dev] [PATCH] glsl: Ignore ir_texture in lower_const_arrays_to_uniforms.

2016-06-24 Thread Kenneth Graunke
On Friday, June 24, 2016 7:03:35 PM PDT Ilia Mirkin wrote: > On Fri, Jun 24, 2016 at 6:41 PM, Kenneth Graunke > wrote: > > The only part of an ir_texture which can be an array is the > > offsets array in textureGatherOffsets() calls. We don't want > > to lower those,

Re: [Mesa-dev] [PATCH] glsl: Ignore ir_texture in lower_const_arrays_to_uniforms.

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 6:41 PM, Kenneth Graunke wrote: > The only part of an ir_texture which can be an array is the > offsets array in textureGatherOffsets() calls. We don't want > to lower those, because they're required to remain constants. > > Fixes

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] intel: Add more Kabylake PCI IDs.

2016-06-24 Thread Vivi, Rodrigo
On Fri, 2016-06-24 at 22:42 +, Pandiyan, Dhinakaran wrote: > On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > > > > The spec has been updated adding new PCI IDs. > > > > Signed-off-by: Rodrigo Vivi > > --- > >  intel/intel_chipset.h | 14 ++ > >  1

[Mesa-dev] [PATCH] glsl: Ignore ir_texture in lower_const_arrays_to_uniforms.

2016-06-24 Thread Kenneth Graunke
The only part of an ir_texture which can be an array is the offsets array in textureGatherOffsets() calls. We don't want to lower those, because they're required to remain constants. Fixes textureGatherOffsets with Gallium drivers such as llvmpipe, which commit

[Mesa-dev] [PATCH 1/1] winsys: Fix always false comparison

2016-06-24 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c index

Re: [Mesa-dev] [PATCH] fixup! genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE

2016-06-24 Thread Mauro Rossi
> On Mon, Jun 20, 2016 at 4:49 PM, Chad Versace > wrote: > > Emil, how do you test the Android build? I tried building i965 using > > vanilla AOSP, but that turned into a long journey in yak shaving. > > Fun, isn't it. Here's cut-n-paste from my CI job that is tracks AOSP

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-06-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 96622, which changed state. Bug 96622 Summary: [radeonsi,apitrace] "Dreamfall Chapters: The longest Journey" shows visual corruption https://bugs.freedesktop.org/show_bug.cgi?id=96622 What|Removed

Re: [Mesa-dev] [PATCH v4 2/4] anv: use cache uuid based on the build timestamp.

2016-06-24 Thread Emil Velikov
On 24 June 2016 at 20:15, Jason Ekstrand wrote: > > > On Fri, Jun 24, 2016 at 11:59 AM, Emil Velikov > wrote: >> >> From: Emil Velikov >> >> Do not rely on the git sha1: >> - its current truncated form makes it less

Re: [Mesa-dev] [PATCH v4 2/4] anv: use cache uuid based on the build timestamp.

2016-06-24 Thread Jason Ekstrand
On Fri, Jun 24, 2016 at 11:59 AM, Emil Velikov wrote: > From: Emil Velikov > > Do not rely on the git sha1: > - its current truncated form makes it less unique > - it does not attribute for local (Vulkand or otherwise) changes > > Use a

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 2:56 PM, Alejandro Piñeiro wrote: > On 24/06/16 17:15, Ilia Mirkin wrote: >> On Fri, Jun 24, 2016 at 10:42 AM, Alejandro Piñeiro >> wrote: >>> >>> On 24/06/16 12:17, Nicolai Hähnle wrote: Hi Alejandro, >>> Hi, thanks for

[Mesa-dev] [PATCH v4 2/4] anv: use cache uuid based on the build timestamp.

2016-06-24 Thread Emil Velikov
From: Emil Velikov Do not rely on the git sha1: - its current truncated form makes it less unique - it does not attribute for local (Vulkand or otherwise) changes Use a timestamp produced at the time of build. It's perfectly unique, unless someone explicitly

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-24 Thread Alejandro Piñeiro
On 24/06/16 17:15, Ilia Mirkin wrote: > On Fri, Jun 24, 2016 at 10:42 AM, Alejandro Piñeiro > wrote: >> >> On 24/06/16 12:17, Nicolai Hähnle wrote: >>> Hi Alejandro, >> Hi, thanks for the quick answer, more comments below. >> >>> my understanding of the spec is that the test

Re: [Mesa-dev] [PATCH] i965: Skip update_texture_surface when the plane doesn't exist

2016-06-24 Thread Chad Versace
On Mon 20 Jun 2016, Jordan Justen wrote: > Reported-by: Grazvydas Ignotas > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96607 > Signed-off-by: Jordan Justen > Cc: Kristian Høgsberg > Cc: "12.0"

Re: [Mesa-dev] [PATCH 5/6] gallium/radeon: add a heuristic dynamically enabling DCC for scanout surfaces

2016-06-24 Thread Marek Olšák
On Fri, Jun 24, 2016 at 1:09 PM, Nicolai Hähnle wrote: > On 22.06.2016 20:29, Marek Olšák wrote: >> >> From: Marek Olšák >> >> DCC for displayable surfaces is allocated in a separate buffer and is >> enabled or disabled based on PS invocations from 2

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-24 Thread Chad Versace
On Thu 16 Jun 2016, Emil Velikov wrote: > On 16 June 2016 at 21:14, Haixia Shi wrote: > > Emil > > > > I looked at commit 3689ef32 which started the problem, and it seems that > > patch removed the line "touch git_sha1.h.tmp". Previously my workflow was > > "working" because

Re: [Mesa-dev] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

2016-06-24 Thread Chad Versace
On Thu 23 Jun 2016, Ian Romanick wrote: > ping > > *Before* 12.0 ships, we must either land this patch or a patch that > redacts the GLES 3.1 functions (e.g., glDispatchCompute) that we already > statically export. Pong. Yes, please do this. Yes, this sucks (for Linux ABI conventions). The

Re: [Mesa-dev] [PATCH] anv: install the intel_icd.json to ${datarootdir} by default

2016-06-24 Thread Emil Velikov
On 24 June 2016 at 18:15, Jason Ekstrand wrote: > On Fri, Jun 24, 2016 at 10:13 AM, Emil Velikov > wrote: >> >> From: Emil Velikov >> >> As mentioned by the spec (and used by Archlinux and Debian) default to >>

Re: [Mesa-dev] [PATCH v3 2/4] anv: use cache uuid based on the build timestamp.

2016-06-24 Thread Jason Ekstrand
On Fri, Jun 24, 2016 at 10:15 AM, Emil Velikov wrote: > From: Emil Velikov > > Do not rely on the git sha1: > - its current truncated form makes it less unique > - it does not attribute for local (Vulkand or otherwise) changes > > Use a

Re: [Mesa-dev] [PATCH] anv: install the intel_icd.json to ${datarootdir} by default

2016-06-24 Thread Jason Ekstrand
On Fri, Jun 24, 2016 at 10:13 AM, Emil Velikov wrote: > From: Emil Velikov > > As mentioned by the spec (and used by Archlinux and Debian) default to > ${datarootdir} as opposed to ${sysconfdir} for the default location. > Just to confirm,

[Mesa-dev] [PATCH v3 2/4] anv: use cache uuid based on the build timestamp.

2016-06-24 Thread Emil Velikov
From: Emil Velikov Do not rely on the git sha1: - its current truncated form makes it less unique - it does not attribute for local (Vulkand or otherwise) changes Use a timestamp produced at the time of build. It's perfectly unique, unless someone explicitly

[Mesa-dev] [PATCH] anv: install the intel_icd.json to ${datarootdir} by default

2016-06-24 Thread Emil Velikov
From: Emil Velikov As mentioned by the spec (and used by Archlinux and Debian) default to ${datarootdir} as opposed to ${sysconfdir} for the default location. Cc: Jason Ekstrand Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/4] radeon/vce: use vce structure for vce 52 firmware

2016-06-24 Thread Leo Liu
On 06/22/2016 05:44 PM, Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce.c| 4 + src/gallium/drivers/radeon/radeon_vce.h| 17 + src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 4 +

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

2016-06-24 Thread Emil Velikov
On 20 June 2016 at 19:14, Ian Romanick wrote: > On 06/17/2016 11:15 AM, Emil Velikov wrote: >> On 17 June 2016 at 18:20, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Khronos recommends that the GLES 3.1 library also be

[Mesa-dev] [PATCH] radeonsi: use optimal WD settings for primitive restart on Polaris

2016-06-24 Thread Marek Olšák
From: Marek Olšák ported from Vulkan --- src/gallium/drivers/radeonsi/si_state_draw.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index

Re: [Mesa-dev] [PATCH] st/mesa: check the texture image level in st_texture_match_image

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 11:59 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Otherwise, 1x1 images of arbitrarily high level are accepted. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96639#add_comment Please nuke the #add_comment

[Mesa-dev] [PATCH] st/mesa: check the texture image level in st_texture_match_image

2016-06-24 Thread Nicolai Hähnle
From: Nicolai Hähnle Otherwise, 1x1 images of arbitrarily high level are accepted. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96639#add_comment Cc: 11.2 12.0 --- src/mesa/state_tracker/st_texture.c | 5 + 1 file

Re: [Mesa-dev] [PATCH] st/mesa: an incomplete texture may have a zero-size first image

2016-06-24 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin That makes sense. Thanks for looking into it! On Fri, Jun 24, 2016 at 10:39 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes a regression introduced by commit 42624ea83 which triggered > an

Re: [Mesa-dev] [PATCH] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 10:43 AM, Brian Paul wrote: > This indicates the alpha channel of the surface should always be one. > Drivers can use this to adjust blending terms when needed. > > v2: also check for R, RG, LUMINANCE surfaces, per Ilia > --- >

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 10:42 AM, Alejandro Piñeiro wrote: > > > On 24/06/16 12:17, Nicolai Hähnle wrote: >> Hi Alejandro, > > Hi, thanks for the quick answer, more comments below. > >> >> my understanding of the spec is that the test should be correct as >> originally

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_surface::alpha_one field

2016-06-24 Thread Nicolai Hähnle
On 24.06.2016 16:40, Brian Paul wrote: On 06/24/2016 03:56 AM, Nicolai Hähnle wrote: On 24.06.2016 04:07, Brian Paul wrote: If the user requests an RGB drawing surface but we actually create an RGBA surface, we need it to act as if A=1. For blending, this means adjusting the blending terms to

Re: [Mesa-dev] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-24 Thread Nicolai Hähnle
On 24.06.2016 16:42, Alejandro Piñeiro wrote: On 24/06/16 12:17, Nicolai Hähnle wrote: Hi Alejandro, Hi, thanks for the quick answer, more comments below. my understanding of the spec is that the test should be correct as originally written, i.e. with glTextureBarrier only between full

Re: [Mesa-dev] [PATCH 6/7] radeonsi: fix fractional odd tessellation spacing for Polaris

2016-06-24 Thread Nicolai Hähnle
On 24.06.2016 16:11, Nicolai Hähnle wrote: Are you sure this is Polaris-specific? I see a mention of this 14/30 as well, but it seems to apply to all of gfx8. Never mind, I didn't look closely enough. R-b for this patch as well. Nicolai The rest of this series is Reviewed-by: Nicolai

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_surface::alpha_one field

2016-06-24 Thread Roland Scheidegger
For what formats is this really needed? I think that usually if you have a rgb surface, the corresponding rgbx format should be used instead of rgba (which implicitly has the alpha == 1 property for blending). But maybe some formats are missing... Roland Am 24.06.2016 um 04:07 schrieb Brian

[Mesa-dev] [PATCH] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

2016-06-24 Thread Brian Paul
This indicates the alpha channel of the surface should always be one. Drivers can use this to adjust blending terms when needed. v2: also check for R, RG, LUMINANCE surfaces, per Ilia --- src/mesa/state_tracker/st_cb_fbo.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [Mesa-dev] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-24 Thread Alejandro Piñeiro
On 24/06/16 12:17, Nicolai Hähnle wrote: > Hi Alejandro, Hi, thanks for the quick answer, more comments below. > > my understanding of the spec is that the test should be correct as > originally written, i.e. with glTextureBarrier only between full > rectangle draws. > > FWIW, radeonsi passes

[Mesa-dev] [Bug 96629] dEQP-GLES2.functional.texture.completeness.cube.not_positive_level_0: Assertion `width >= 1' failed.

2016-06-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96629 --- Comment #4 from Nicolai Hähnle --- I think the correct solution is just to guard this particular call to guess_and_alloc_texture accordingly. See https://patchwork.freedesktop.org/patch/95080/ -- You are receiving this

[Mesa-dev] [PATCH] st/mesa: an incomplete texture may have a zero-size first image

2016-06-24 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes a regression introduced by commit 42624ea83 which triggered an assertion in dEQP-GLES2.functional.texture.completeness.cube.not_positive_level_0 While stImage must have a non-zero size as verified by the caller, we also look at the size of the

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_surface::alpha_one field

2016-06-24 Thread Brian Paul
On 06/24/2016 03:56 AM, Nicolai Hähnle wrote: On 24.06.2016 04:07, Brian Paul wrote: If the user requests an RGB drawing surface but we actually create an RGBA surface, we need it to act as if A=1. For blending, this means adjusting the blending terms to use 1/0 instead of

Re: [Mesa-dev] [PATCH 2/4] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 10:33 AM, Brian Paul wrote: > On 06/23/2016 08:14 PM, Ilia Mirkin wrote: >> >> Isn't this true for any-non-alpha-having format? I.e. _BaseFormat != >> GL_RGBA && _BaseFormat != GL_ALPHA && _BaseFormat != >> GL_LUMINANCE_ALPHA && _BaseFormat !=

Re: [Mesa-dev] [PATCH 2/4] st/mesa: set the new pipe_surface::alpha_one field for RGB surfaces

2016-06-24 Thread Brian Paul
On 06/23/2016 08:14 PM, Ilia Mirkin wrote: Isn't this true for any-non-alpha-having format? I.e. _BaseFormat != GL_RGBA && _BaseFormat != GL_ALPHA && _BaseFormat != GL_LUMINANCE_ALPHA && _BaseFormat != GL_INTENSITY? (Not sure about that last one tbh.) One would also have to check for GL_DEPTH,

Re: [Mesa-dev] [PATCH 4/6] gallium/radeon: add state setup for a separate DCC buffer

2016-06-24 Thread Marek Olšák
On Fri, Jun 24, 2016 at 1:10 PM, Nicolai Hähnle wrote: > I remember there was a plausible reason to have a dcc_offset instead of just > a dcc_address (though I keep forgetting it), but maybe it's time to change > that now? Yeah I think having dcc_address would now be more

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-24 Thread Nayan Deshmukh
Hi Andy, Thanks for testing the patches. I have made some changes with which hqscaling=0 should work fine. But I don't know how to set pillar boxes to black. Do you have some idea how this could be done? Any suggestions Christian? Regards, Nayan. On Fri, Jun 24, 2016 at 4:57 AM, Andy Furniss

Re: [Mesa-dev] Mesa (master): glsl: Make lower_const_arrays_to_uniforms work directly on constants.

2016-06-24 Thread Ilia Mirkin
Same deal on nouveau. This is the TGSI: FRAG PROPERTY FS_COLOR0_WRITES_ALL_CBUFS 1 DCL IN[0], POSITION, LINEAR DCL OUT[0], COLOR DCL SAMP[0] DCL SVIEW[0], 2D, FLOAT DCL CONST[5] DCL CONST[0..3] DCL TEMP[0] DCL TEMP[1..2], LOCAL IMM[0] INT32 {0, 0, 0, 0} 0: MOV TEMP[0], IN[0] 1: MAD TEMP[0].y,

Re: [Mesa-dev] [PATCH 6/7] radeonsi: fix fractional odd tessellation spacing for Polaris

2016-06-24 Thread Nicolai Hähnle
Are you sure this is Polaris-specific? I see a mention of this 14/30 as well, but it seems to apply to all of gfx8. The rest of this series is Reviewed-by: Nicolai Hähnle On 24.06.2016 14:15, Marek Olšák wrote: From: Marek Olšák ported from

Re: [Mesa-dev] [PATCH] st/mesa: don't assume that the whole surface gets mapped

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 3:27 AM, Nicolai Hähnle wrote: > On 24.06.2016 04:32, Ilia Mirkin wrote: >> >> Under some circumstances, the driver may choose to return a temporary >> surface instead of a pointer to the original. Make sure to pass the >> actual view volume to be

Re: [Mesa-dev] [PATCH 4/4] radeon/vce: handle newly added parameters

2016-06-24 Thread Christian König
Am 24.06.2016 um 14:46 schrieb Ilia Mirkin: On Fri, Jun 24, 2016 at 8:39 AM, Christian König wrote: Ilia and/or maybe other nouveau developers: You guys don't have any plans to expose the NVidia encoding functionality through the OpenMAX/VA-API state trackers in the

Re: [Mesa-dev] [PATCH 4/4] radeon/vce: handle newly added parameters

2016-06-24 Thread Ilia Mirkin
On Fri, Jun 24, 2016 at 8:39 AM, Christian König wrote: > Ilia and/or maybe other nouveau developers: You guys don't have any plans to > expose the NVidia encoding functionality through the OpenMAX/VA-API state > trackers in the near future don't you? Not in the near

Re: [Mesa-dev] [PATCH 4/4] radeon/vce: handle newly added parameters

2016-06-24 Thread Samuel Pitoiset
On 06/24/2016 02:39 PM, Christian König wrote: +if (pic->enable_low_level_control == true) { Well using this enable_low_level_control switch to choose between two sets of hardcoded values is clearly a no go. For the motion estimation and most of the other flags I would say just try to

Re: [Mesa-dev] [PATCH 4/4] radeon/vce: handle newly added parameters

2016-06-24 Thread Christian König
+ if (pic->enable_low_level_control == true) { Well using this enable_low_level_control switch to choose between two sets of hardcoded values is clearly a no go. For the motion estimation and most of the other flags I would say just try to expose the parameters we have in the hardware

[Mesa-dev] [PATCH 5/7] radeonsi: set some VGT context registers on SI-CI

2016-06-24 Thread Marek Olšák
From: Marek Olšák the kernel sets them, but other UMDs can change them --- src/gallium/drivers/radeonsi/si_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

[Mesa-dev] [PATCH 2/7] gallium/radeon: let drivers specify SC_MODE_CNTL_1 fields

2016-06-24 Thread Marek Olšák
From: Marek Olšák radeonsi will set more fields --- src/gallium/drivers/r600/evergreen_state.c| 7 ++- src/gallium/drivers/radeon/cayman_msaa.c | 12 +--- src/gallium/drivers/radeon/r600_pipe_common.h | 3 ++- src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 6/7] radeonsi: fix fractional odd tessellation spacing for Polaris

2016-06-24 Thread Marek Olšák
From: Marek Olšák ported from Vulkan (and no source explains why this is needed) Cc: 12.0 --- src/gallium/drivers/radeonsi/si_hw_context.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 +

[Mesa-dev] [PATCH 7/7] radeonsi: fix a compute shader hang with big threadgroups on SI & CI

2016-06-24 Thread Marek Olšák
From: Marek Olšák ported from Vulkan Cc: 12.0 --- src/gallium/drivers/radeonsi/si_compute.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c

[Mesa-dev] [PATCH 4/7] radeonsi: optimize rendering to linear color buffers

2016-06-24 Thread Marek Olšák
From: Marek Olšák loosely ported from Vulkan --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h

[Mesa-dev] [PATCH 3/7] radeonsi: set almost optimal settings in SC_MODE_CNTL_1

2016-06-24 Thread Marek Olšák
From: Marek Olšák ported from Vulkan --- src/gallium/drivers/radeonsi/si_state.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f5da153..df188dd 100644

[Mesa-dev] [PATCH 1/7] gallium/radeon: disable complicated point clipping against user clip planes

2016-06-24 Thread Marek Olšák
From: Marek Olšák Nothing in the GL spec says that we should expand points to triangles. --- src/gallium/drivers/r600/evergreen_state.c | 1 - src/gallium/drivers/r600/r600_state.c | 1 - src/gallium/drivers/radeonsi/si_state.c| 1 - 3 files changed, 3 deletions(-)

Re: [Mesa-dev] [PATCH 4/6] gallium/radeon: add state setup for a separate DCC buffer

2016-06-24 Thread Nicolai Hähnle
I remember there was a plausible reason to have a dcc_offset instead of just a dcc_address (though I keep forgetting it), but maybe it's time to change that now? Either way, patches 1-4 & 6 are Reviewed-by: Nicolai Hähnle On 22.06.2016 20:29, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 5/6] gallium/radeon: add a heuristic dynamically enabling DCC for scanout surfaces

2016-06-24 Thread Nicolai Hähnle
On 22.06.2016 20:29, Marek Olšák wrote: From: Marek Olšák DCC for displayable surfaces is allocated in a separate buffer and is enabled or disabled based on PS invocations from 2 frames ago (to let queries go idle) and the number of slow clears from the current frame. At

Re: [Mesa-dev] [PATCH 0/2] radeonsi: last minute Polaris touch-ups

2016-06-24 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Jun 24, 2016 at 1:42 AM, Nicolai Hähnle wrote: > Hi, > > I'm sending out two changes for Polaris support that should still go into > 12.0 (fingers crossed that that's it :-)). > > Note that the

Re: [Mesa-dev] [PATCH] st/mesa: handle negative _ColorDrawBufferIndexes values correctly

2016-06-24 Thread Marek Olšák
Pushed, thanks. Marek On Thu, Jun 23, 2016 at 7:56 PM, Francesco Ansanelli wrote: > --- > src/mesa/state_tracker/st_cb_fbo.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_cb_fbo.c >

Re: [Mesa-dev] [PATCH v2] r600g: move PA_SU_POLY_OFFSET_DB_FMT_CNTL to poly offset states for evergreen

2016-06-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 22, 2016 at 10:14 PM, Axel Davy wrote: > Emit PA_SU_POLY_OFFSET_DB_FMT_CNTL with the other poly_offset states. > This will be useful to implement > PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED. > > v2: Increase the

Re: [Mesa-dev] [PATCH v2] r600g: move PA_SU_POLY_OFFSET_DB_FMT_CNTL to poly offset states for r600

2016-06-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 22, 2016 at 10:13 PM, Axel Davy wrote: > Emit PA_SU_POLY_OFFSET_DB_FMT_CNTL with the other poly_offset states. > This will be useful to implement > PIPE_CAP_POLYGON_OFFSET_UNITS_UNSCALED. > > v2: Increase the

Re: [Mesa-dev] [PATCH v3 1/1] r600: Enable FMA on chips that support it

2016-06-24 Thread Marek Olšák
Pushed, thanks. Marek On Thu, Jun 16, 2016 at 1:41 AM, Jan Vesely wrote: > v2: Merge with PIPE_SHADER_CAP_DOUBLES > Add CHIP_HEMLOCK > > v3: only set the instruction on EG and CM > > Signed-off-by: Jan Vesely > --- >

Re: [Mesa-dev] [PATCH 2/4] anv: use cache uuid based on the build timestamp.

2016-06-24 Thread Emil Velikov
On 24 June 2016 at 03:32, Michel Dänzer wrote: > On 23.06.2016 22:25, Emil Velikov wrote: >> On 23 June 2016 at 03:49, Michel Dänzer wrote: >>> On 22.06.2016 21:04, Emil Velikov wrote: From: Emil Velikov Do not

Re: [Mesa-dev] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-24 Thread Nicolai Hähnle
Hi Alejandro, my understanding of the spec is that the test should be correct as originally written, i.e. with glTextureBarrier only between full rectangle draws. FWIW, radeonsi passes the test as-is (though I reduced the GLSL version requirement, which I'd ask you to change as well before

Re: [Mesa-dev] [PATCH 2/4] anv: use cache uuid based on the build timestamp.

2016-06-24 Thread Emil Velikov
On 24 June 2016 at 03:59, Dave Airlie wrote: > On 23 June 2016 at 23:25, Emil Velikov wrote: >> On 23 June 2016 at 03:49, Michel Dänzer wrote: >>> On 22.06.2016 21:04, Emil Velikov wrote: From: Emil Velikov

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_surface::alpha_one field

2016-06-24 Thread Nicolai Hähnle
On 24.06.2016 04:07, Brian Paul wrote: If the user requests an RGB drawing surface but we actually create an RGBA surface, we need it to act as if A=1. For blending, this means adjusting the blending terms to use 1/0 instead of DST_ALPHA/INV_DST_ALPHA. Drivers can use this flag to determine

[Mesa-dev] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-24 Thread Alejandro Piñeiro
Gets the test passing for cases with low resolution, high amount of triangles and more than one glDrawRangeElements (drawing_passes). --- Just to catch attention, this issue also affects the failing CTS test GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass on Intel gen7+. And sorry for the

Re: [Mesa-dev] [PATCH 2/2] radeonsi: set LLVM denormal flags

2016-06-24 Thread Nicolai Hähnle
For both: Reviewed-by: Nicolai Hähnle On 22.06.2016 15:13, Marek Olšák wrote: From: Marek Olšák - make sure FP32 denormals will stay disabled in LLVM in the future (the current default is disabled) - tell LLVM that FP64 denormals are enabled

[Mesa-dev] [PATCH] mesa: faster validation of sampler unit mapping for SSO

2016-06-24 Thread Gregory Hainaut
Code was inspired from _mesa_update_shader_textures_used However unlike _mesa_update_shader_textures_used that only check for a single stage, it will check all stages. It avoids to loop on all uniforms, only active samplers are checked. Signed-off-by: Gregory Hainaut

Re: [Mesa-dev] [BRANCH] Gallium Radeon cleanups

2016-06-24 Thread Nicolai Hähnle
I noticed a small number of places where true/false are assigned to booleans that are still in the Gallium interfaces: - uses of DEBUG_GET_ONCE_BOOL_OPTION - timestamp_disjoint.disjoint ... but then if those weren't changed now, it'd just cause inconsistencies later when the Gallium interface

Re: [Mesa-dev] [PATCH] radeonsi: keep using v_rcp_f32 for division in future LLVM

2016-06-24 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 23.06.2016 00:03, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/radeon_llvm.h | 3 +++ .../drivers/radeon/radeon_setup_tgsi_llvm.c| 28 -- 2 files

Re: [Mesa-dev] [PATCH 0/6] Gallium multithreaded queue - cleanup and multiple threads per queue

2016-06-24 Thread Nicolai Hähnle
On 23.06.2016 00:35, Marek Olšák wrote: On Thu, Jun 23, 2016 at 12:29 AM, Marek Olšák wrote: On Tue, Jun 21, 2016 at 4:47 PM, Nicolai Hähnle wrote: On 21.06.2016 14:17, Marek Olšák wrote: Hi, This improves u_queue to be more usable in more cases.

Re: [Mesa-dev] [PATCH] st/mesa: don't assume that the whole surface gets mapped

2016-06-24 Thread Nicolai Hähnle
On 24.06.2016 04:32, Ilia Mirkin wrote: Under some circumstances, the driver may choose to return a temporary surface instead of a pointer to the original. Make sure to pass the actual view volume to be mapped to the transfer function rather than adjusting the map pointer after-the-fact. I'm

Re: [Mesa-dev] V4 ARB_enhanced_layouts packing support for i965 Gen6+

2016-06-24 Thread Edward O'Callaghan
This series is ACK'ed by, Edward O'Callaghan On 06/24/2016 01:52 PM, Timothy Arceri wrote: > V4: > - add vec4 backend support and enable for Gen6+ > > V3: > - Rewrite patch 9 (add support for packing arrays) to not add > hacks to the type_size() functions. > - Add

Re: [Mesa-dev] Mesa (master): glsl: Make lower_const_arrays_to_uniforms work directly on constants.

2016-06-24 Thread Michel Dänzer
On 24.06.2016 03:59, Kenneth Graunke wrote: > Module: Mesa > Branch: master > Commit: ef78df8d3b0cf540e5f08c8c2f6caa338b64a6c7 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=ef78df8d3b0cf540e5f08c8c2f6caa338b64a6c7 > > Author: Kenneth Graunke > Date: Fri