Re: [Mesa-dev] [PATCH 06/95] i965/vec4/nir: fix nir_intrinsic_load_uniform for doubles

2016-07-27 Thread Iago Toral
On Thu, 2016-07-28 at 15:49 +1000, Timothy Arceri wrote: > On Tue, 2016-07-19 at 12:40 +0200, Iago Toral Quiroga wrote: > > > > From: Connor Abbott > > > > --- > >  src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 12/17] glsl/ast: Allow redeclaration of gl_LastFragData with different precision qualifier.

2016-07-27 Thread Kenneth Graunke
On Wednesday, July 20, 2016 9:49:42 PM PDT Francisco Jerez wrote: > --- > src/compiler/glsl/ast_to_hir.cpp | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/compiler/glsl/ast_to_hir.cpp > b/src/compiler/glsl/ast_to_hir.cpp > index c050a3f..ac651a9 100644 > --- a/src/com

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-07-27 Thread Francisco Jerez
Emil Velikov writes: > On 6 June 2016 at 00:02, Vedran Miletić wrote: >> On 06/04/2016 04:18 AM, Francisco Jerez wrote: >>> >>> Serge Martin writes: >>> From: Vedran Miletić Make sure that a struct argument did not get compiled into a pointer type with the byval attribute.

Re: [Mesa-dev] [PATCH 06/95] i965/vec4/nir: fix nir_intrinsic_load_uniform for doubles

2016-07-27 Thread Timothy Arceri
On Tue, 2016-07-19 at 12:40 +0200, Iago Toral Quiroga wrote: > From: Connor Abbott > > --- >  src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > index 5a7e

Re: [Mesa-dev] [PATCH 01/95] i965/nir: double/dvec2 uniforms only need to be padded to a single vec4 slot

2016-07-27 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10/17] glsl: Define a gl_LastFragData built-in for GLSL versions that have gl_FragData.

2016-07-27 Thread Francisco Jerez
Kenneth Graunke writes: > On Wednesday, July 27, 2016 5:05:39 PM PDT Francisco Jerez wrote: >> Kenneth Graunke writes: >> >> > On Wednesday, July 20, 2016 9:49:40 PM PDT Francisco Jerez wrote: >> >> The EXT_shader_framebuffer_fetch extension defines alternative >> >> language for GLES2 shaders

Re: [Mesa-dev] [PATCH 10/17] glsl: Define a gl_LastFragData built-in for GLSL versions that have gl_FragData.

2016-07-27 Thread Kenneth Graunke
On Wednesday, July 27, 2016 5:05:39 PM PDT Francisco Jerez wrote: > Kenneth Graunke writes: > > > On Wednesday, July 20, 2016 9:49:40 PM PDT Francisco Jerez wrote: > >> The EXT_shader_framebuffer_fetch extension defines alternative > >> language for GLES2 shaders where user-defined fragment outpu

Re: [Mesa-dev] [PATCH 02/12] glsl: Replace big pile of hand-written code with a generator

2016-07-27 Thread Francisco Jerez
Ilia Mirkin writes: > Another alternative would be to make these into IR nodes. This could > be done by groups, e.g. adding a special "atomic" ir type with > subtypes, or .. whatever else. Just pointing out that this fun with > strings isn't totally necessary. Not sure why it was done that way in

Re: [Mesa-dev] [PATCH 02/12] glsl: Replace big pile of hand-written code with a generator

2016-07-27 Thread Ilia Mirkin
Another alternative would be to make these into IR nodes. This could be done by groups, e.g. adding a special "atomic" ir type with subtypes, or .. whatever else. Just pointing out that this fun with strings isn't totally necessary. Not sure why it was done that way in the first place. [Not saying

[Mesa-dev] [Bug 97019] [clover] build failure in llvm/codegen/native.cpp:129:52

2016-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97019 Francisco Jerez changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

Re: [Mesa-dev] [Patch v2] clover: make GCC 4.8 happy

2016-07-27 Thread Francisco Jerez
Dieter Nützel writes: > Can someone of you commit for me after review, please. Reviewed-by and pushed, thanks. > > Thanks, >Dieter > > Am 28.07.2016 00:20, schrieb Dieter Nützel: >> Without this GCC 4.8.x throws below error: >> >> error: invalid initialization of non-const reference of typ

Re: [Mesa-dev] Call i965 GLSL IR backend optimisation from the common linker

2016-07-27 Thread Timothy Arceri
On Tue, 2016-07-26 at 22:56 -0700, Matt Turner wrote: > On Tue, Jul 26, 2016 at 10:20 PM, Timothy Arceri > wrote: > > The ultimate goal is to be able to convert to NIR and make use of > > its > > optimisations before assigning varying and uniform locations. This > > should allow us to start removi

[Mesa-dev] [PATCH] egl: android: query native window default width and height

2016-07-27 Thread Haixia Shi
On android platform, the width and height of a native window surface may be updated after initialization. It is therefore necessary to query android framework for the current width and height. TEST=dEQP-EGL.functional.resize.surface_size#* on cyan-cheets Signed-off-by: Haixia Shi --- src/egl/dr

Re: [Mesa-dev] [PATCH] i965: remove unnecessary null check

2016-07-27 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: remove unnecessary null check

2016-07-27 Thread Timothy Arceri
We would have hit a segfault already if this could be null. Fixes Coverity warning spotted by Matt. Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_gs.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_gs.c b/src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 10/17] glsl: Define a gl_LastFragData built-in for GLSL versions that have gl_FragData.

2016-07-27 Thread Francisco Jerez
Kenneth Graunke writes: > On Wednesday, July 20, 2016 9:49:40 PM PDT Francisco Jerez wrote: >> The EXT_shader_framebuffer_fetch extension defines alternative >> language for GLES2 shaders where user-defined fragment outputs are not >> allowed. Instead of using inout user-defined fragment outputs

Re: [Mesa-dev] [PATCH 03/11] mesa: Implement _mesa_all_varyings_in_vbos.

2016-07-27 Thread Fredrik Höglund
On Wednesday 27 July 2016, Mathias Fröhlich wrote: > Hi, > > On Thursday, June 23, 2016 16:53:59 Fredrik Höglund wrote: > > On Friday 17 June 2016, mathias.froehl...@gmx.net wrote: > > > From: Mathias Fröhlich > > > > > > Implement the equivalent of vbo_all_varyings_in_vbos for > > > vertex arra

Re: [Mesa-dev] [PATCH 5/5] isl/state: Add some asserts about format capabilities

2016-07-27 Thread Nanley Chery
On Tue, Jul 26, 2016 at 10:04:26PM -0700, Jason Ekstrand wrote: > This keeps invalid surface states from leaking through and potentially > hanging the GPU. We shouldn't actually be hitting this on a regular basis, > but a helpful assert is better than a hang. Patches 4 and 5 are, Reviewed-by: Nan

Re: [Mesa-dev] [PATCH] i965: print error messages if gs fails to compile

2016-07-27 Thread Matt Turner
On Wed, Jul 20, 2016 at 9:50 PM, Kenneth Graunke wrote: > On Thursday, July 21, 2016 2:07:01 PM PDT Timothy Arceri wrote: >> From: Timothy Arceri >> >> We do this for all other stages. >> --- >> src/mesa/drivers/dri/i965/brw_gs.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/

Re: [Mesa-dev] [PATCH] ddebug: use pclose to close a popen()'d FILE

2016-07-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jul 27, 2016 at 4:48 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Found by Coverity. > --- > src/gallium/drivers/ddebug/dd_draw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/ddebug/dd_draw.c > b/s

Re: [Mesa-dev] [PATCH 2/2] radeonsi/compute: Use the HSA abi for non-TGSI compute shaders

2016-07-27 Thread Marek Olšák
On Tue, Jul 26, 2016 at 5:39 PM, Nicolai Hähnle wrote: > On 26.07.2016 01:11, Tom Stellard wrote: >> >> This patche switches non-TGSI compute shaders over to using the HSA > > > Typo: patch :) > > >> ABI described here: >> >> https://github.com/RadeonOpenCompute/ROCm-Docs/blob/master/AMDGPU-ABI.md

[Mesa-dev] [Bug 97019] [clover] build failure in llvm/codegen/native.cpp:129:52

2016-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97019 Dieter Nützel changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

Re: [Mesa-dev] [Patch v2] clover: make GCC 4.8 happy

2016-07-27 Thread Dieter Nützel
Can someone of you commit for me after review, please. Thanks, Dieter Am 28.07.2016 00:20, schrieb Dieter Nützel: Without this GCC 4.8.x throws below error: error: invalid initialization of non-const reference of type 'clover::llvm::compat::raw_ostream_to_emit_file {aka llvm::raw_svector_ost

Re: [Mesa-dev] V4 On disk shader cache for i965

2016-07-27 Thread Timothy Arceri
Ping ... any feedback/ideas for moving this forward would be greatly appreciated. On Wed, 2016-07-13 at 12:46 +1000, Timothy Arceri wrote: > Big thanks to Grazvydas Ignotas for helping test this version.  > > V4: > - lots of reworking patches to remove code churn should be much nicer > now > - fi

[Mesa-dev] [Patch v2] clover: make GCC 4.8 happy

2016-07-27 Thread Dieter Nützel
Without this GCC 4.8.x throws below error: error: invalid initialization of non-const reference of type 'clover::llvm::compat::raw_ostream_to_emit_file {aka llvm::raw_svector_ostream&}' from an rvalue of type '' v2: change commit title and add error message like Eric Engestrom requested Signed-

Re: [Mesa-dev] [PATCH v2 18/35] i965/blorp: Use ISL to compute image offsets

2016-07-27 Thread Jason Ekstrand
On Jul 27, 2016 1:53 PM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:02:09PM -0700, Jason Ekstrand wrote: > > For the moment, we still call the old miptree function; we just assert that > > the two are equal. > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 94 +++

Re: [Mesa-dev] [PATCH] configure: additional libs for LLVM static linking

2016-07-27 Thread
On Wed, Jul 27, 2016 at 3:44 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Wed, Jul 27, 2016 at 2:44 PM, Emil Velikov > wrote: >> On 27 July 2016 at 12:36, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: >>> diff --git a/configure.ac b/configure.ac >>> index 5c196a9..58c2db4 100644 >>> --- a/configure.

[Mesa-dev] [PATCH v1 1/3] nvc0: fix up TCP header on GM107+

2016-07-27 Thread Samuel Pitoiset
The number of outputs patch (limited to 255) has moved in the TCP header, but blob seems to also set the old position. Also, the high 8-bits are now located inbetween the min/max parallel output read address at position 20. v1: make use of (opcs & 0x0f) to improve readability Signed-off-by: Samue

Re: [Mesa-dev] [PATCH v1 3/3] nvc0: enable ARB_tessellation_shader on GM107+

2016-07-27 Thread Ilia Mirkin
Patches 2, 3: Reviewed-by: Ilia Mirkin Patch 1: Acked-by: Ilia Mirkin On Wed, Jul 27, 2016 at 4:51 PM, Samuel Pitoiset wrote: > This exposes OpenGL 4.1 on Maxwell (tested on GM107 and GM206). > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 --- >

[Mesa-dev] [PATCH] configure: additional libs for OpenCL with LLVM static linking

2016-07-27 Thread Jan Ziak
Mesa compilation fails when "--disable-llvm-shared-libs --enable-opencl" is passed to the configure script. Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- configure.ac | 1 + 1 file changed, 1 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac

[Mesa-dev] [PATCH v1 2/3] gm107/ir: add a legalize SSA pass for PFETCH

2016-07-27 Thread Samuel Pitoiset
PFETCH, actually ISBERD on GM107+ ISA only accepts a GPR for src0. v1: make NVC0LegalizeSSA::bld as protected attribute Signed-off-by: Samuel Pitoiset --- .../nouveau/codegen/nv50_ir_lowering_gm107.cpp | 33 ++ .../nouveau/codegen/nv50_ir_lowering_gm107.h | 8

[Mesa-dev] [PATCH v1 3/3] nvc0: enable ARB_tessellation_shader on GM107+

2016-07-27 Thread Samuel Pitoiset
This exposes OpenGL 4.1 on Maxwell (tested on GM107 and GM206). Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c

Re: [Mesa-dev] [PATCH 03/11] mesa: Implement _mesa_all_varyings_in_vbos.

2016-07-27 Thread Eric Anholt
mathias.froehl...@gmx.net writes: > From: Mathias Fröhlich > > Implement the equivalent of vbo_all_varyings_in_vbos for > vertex array objects. One comment on patch 1, but other than that, 2-11 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH] anv/pipeline: Enable only one dispatch width in case of per sample shading

2016-07-27 Thread Anuj Phogat
On Tue, Jul 26, 2016 at 7:27 PM, Jason Ekstrand wrote: > On Jul 26, 2016 12:54 PM, "Anuj Phogat" wrote: > > > > Fixes ~45 DEQP sample shading tests: > > ./deqp-vk --deqp-case=dEQP-VK.pipeline.multisample.min_sample_shading* > > > > Many tests exited with VK_ERROR_OUT_OF_DEVICE_MEMORY without thi

Re: [Mesa-dev] [PATCH 01/11] mesa: Add flush_vertices argument to _mesa_bind_vertex_buffer.

2016-07-27 Thread Eric Anholt
mathias.froehl...@gmx.net writes: > From: Mathias Fröhlich > > Similar to _mesa_update_array_format add an argument to > avoid calling FLUSH_VERTICES in certain cases. > This will be used with the following change. Do we need to avoid calling FLUSH_VERTICES in the following change, though? We'v

Re: [Mesa-dev] [PATCH v2 18/35] i965/blorp: Use ISL to compute image offsets

2016-07-27 Thread Pohjolainen, Topi
On Tue, Jul 26, 2016 at 03:02:09PM -0700, Jason Ekstrand wrote: > For the moment, we still call the old miptree function; we just assert that > the two are equal. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 94 > +-- > 1 file changed, 91 insertions(+), 3 deleti

Re: [Mesa-dev] [PATCH v2 17/35] isl: Add functions for computing surface offsets in samples

2016-07-27 Thread Pohjolainen, Topi
On Tue, Jul 26, 2016 at 03:02:08PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 24 > src/intel/isl/isl.h | 48 > 2 files changed, 60 insertions(+), 12 deletions(-) This looks logical, I compared to isl_surf_g

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

2016-07-27 Thread Francesco Ansanelli
Hello, unluckily this didn't fix the warning... I've done some more compile testing and found this solution: - static struct ir3_shader_key key = {{0}}; +static struct ir3_shader_key key = {{{0, 0, 0, 0, 0, 0, 0, 0}}, 0, 0, 0, 0, 0, 0, 0, 0}; is this correct? Should I send a new patch? Cheers,

Re: [Mesa-dev] [PATCH 4/6] anv: do not export the Vulkan API

2016-07-27 Thread Jason Ekstrand
I don't really like this... Bit I believe it is correct. The whole series (modulo validation) is Reviewed-by: Jason Ekstrand Let's cc stable on the whole thing as well. On Jul 27, 2016 6:03 AM, "Emil Velikov" wrote: > From: Emil Velikov > > With version 1 of the Loader interface there is an

Re: [Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Jason Ekstrand
I looked at the one validate function we still have and I don't think it validates anything that won't trigger asserts elsewhere. Let's just kill it all. On Jul 27, 2016 8:37 AM, "Emil Velikov" wrote: > On 27 July 2016 at 16:17, Jason Ekstrand wrote: > > On Jul 27, 2016 6:03 AM, "Emil Velikov"

Re: [Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Emil Velikov
On 27 July 2016 at 16:17, Jason Ekstrand wrote: > On Jul 27, 2016 6:03 AM, "Emil Velikov" wrote: >> >> From: Emil Velikov >> >> Presently the layer has only a single entry point, which uses asserts >> solely. >> Thus even on release builds the function (and thus the whole layer) will >> do >> no

Re: [Mesa-dev] [PATCH 6/6] isl: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

2016-07-27 Thread Jason Ekstrand
Thanks. Came across some interesting issues with Talos the other day with Talos having both my system Mesa and a branch of the Vulkan driver at the same time. Bad things happened because my debug branch of the Vulkan driver was picking up isl symbols from system Mesa. Regardless of what we do wit

Re: [Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

2016-07-27 Thread Jason Ekstrand
Thanks. We only had that because at one point we weren't using the loader and dota2 needed it. No longer an issue... On Jul 27, 2016 6:03 AM, "Emil Velikov" wrote: From: Emil Velikov The vkCmdDbgMarker{Begin,End} symbols are exported, yet the json does not that the driver supports the extensio

Re: [Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Jason Ekstrand
On Jul 27, 2016 6:03 AM, "Emil Velikov" wrote: > > From: Emil Velikov > > Presently the layer has only a single entry point, which uses asserts solely. > Thus even on release builds the function (and thus the whole layer) will do > nothing but adding runtime and binary(size) overhead. > > Cc: "12

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not follow the push path for indexed draws

2016-07-27 Thread Samuel Pitoiset
On 07/27/2016 03:45 PM, Ilia Mirkin wrote: On Wed, Jul 27, 2016 at 9:42 AM, Emil Velikov wrote: On 8 June 2016 at 18:08, Samuel Pitoiset wrote: This fixes a lot of flickering in The Talos Principle on Fermi+ (tested on both GF119 and GK106). My guess is that some indices and/or some vertex

[Mesa-dev] [PATCH] ddebug: use pclose to close a popen()'d FILE

2016-07-27 Thread Nicolai Hähnle
From: Nicolai Hähnle Found by Coverity. --- src/gallium/drivers/ddebug/dd_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c index a54cecb..d3c4e7f 100644 --- a/src/gallium/drivers/ddebug/dd_draw

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] i915: store reference to the context within struct intel_fence

2016-07-27 Thread Emil Velikov
On 16 July 2016 at 01:02, Mauro Rossi wrote: > Hi, > > I'm sending the v2 re-spin of patch as per i965, rechecked twice > line-by-line with Tomasz's one. > > Building ok, marshmallow-x86 booting ok and here are the results of Android > CTS egl and gles2 x86 target tests > > Android CTS 6.0_r7 buil

[Mesa-dev] [Bug 96950] Another regression from bc4e0c486: vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-07-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96950 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: Save and restore entire CE RAM.

2016-07-27 Thread Bas Nieuwenhuizen
On Wed, Jul 27, 2016 at 3:33 PM, Emil Velikov wrote: > On 6 June 2016 at 16:46, Bas Nieuwenhuizen wrote: >> On Mon, Jun 6, 2016 at 5:14 PM, Nicolai Hähnle wrote: >>> On 06.06.2016 00:28, Bas Nieuwenhuizen wrote: This fixes a problem with the CE preamble and restoring only stuff in the

Re: [Mesa-dev] [Mesa-stable] [PATCH 05/11] glsl: Don't monkey about with the interpolation modes

2016-07-27 Thread Emil Velikov
On 15 June 2016 at 04:54, Timothy Arceri wrote: > On Tue, 2016-06-14 at 19:01 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Previously we'd munge the interpolation mode so that later checks in >> the >> GLSL linker would pass. The caused problems for similar checks in >> SSO >> IO valid

Re: [Mesa-dev] [PATCH v4 1/2] glx: fix error code when there is no context bound

2016-07-27 Thread Tapani Pälli
On 07/27/2016 04:53 PM, Emil Velikov wrote: On 14 June 2016 at 16:08, Emil Velikov wrote: n 7 June 2016 at 11:33, Tapani Pälli wrote: From: Bernard Kilarski v2: change all related NULL checks to check against dummyContext v3: really check for dummyContext *only* when ctx was from __glX

Re: [Mesa-dev] [PATCH v4 1/2] glx: fix error code when there is no context bound

2016-07-27 Thread Emil Velikov
On 14 June 2016 at 16:08, Emil Velikov wrote: > n 7 June 2016 at 11:33, Tapani Pälli wrote: >> From: Bernard Kilarski >> >> v2: change all related NULL checks to check against dummyContext >> v3: really check for dummyContext *only* when ctx was from >> __glXGetCurrentContext >> v4: cover mo

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-07-27 Thread Ilia Mirkin
On Wed, Jul 27, 2016 at 9:46 AM, Emil Velikov wrote: > On 6 June 2016 at 23:35, Ilia Mirkin wrote: >> On Mon, Jun 6, 2016 at 6:32 PM, Nicolai Hähnle wrote: >>> On 06.06.2016 23:58, Ilia Mirkin wrote: On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: > > On 05.06.2016 08:24

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-07-27 Thread Emil Velikov
On 6 June 2016 at 23:35, Ilia Mirkin wrote: > On Mon, Jun 6, 2016 at 6:32 PM, Nicolai Hähnle wrote: >> On 06.06.2016 23:58, Ilia Mirkin wrote: >>> >>> On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: On 05.06.2016 08:24, Ilia Mirkin wrote: > > > In the case where we ca

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not follow the push path for indexed draws

2016-07-27 Thread Ilia Mirkin
On Wed, Jul 27, 2016 at 9:42 AM, Emil Velikov wrote: > On 8 June 2016 at 18:08, Samuel Pitoiset wrote: >> This fixes a lot of flickering in The Talos Principle on Fermi+ >> (tested on both GF119 and GK106). My guess is that some indices >> and/or some vertex attributes are incorrectly set when em

Re: [Mesa-dev] [PATCH] configure: additional libs for LLVM static linking

2016-07-27 Thread
On Wed, Jul 27, 2016 at 2:44 PM, Emil Velikov wrote: > On 27 July 2016 at 12:36, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: >> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> >> --- >> configure.ac | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletions(-) >> >> diff

Re: [Mesa-dev] [Mesa-stable] [PATCH] nvc0: do not follow the push path for indexed draws

2016-07-27 Thread Emil Velikov
On 8 June 2016 at 18:08, Samuel Pitoiset wrote: > This fixes a lot of flickering in The Talos Principle on Fermi+ > (tested on both GF119 and GK106). My guess is that some indices > and/or some vertex attributes are incorrectly set when emitting > data directly into the command stream rather than

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: Save and restore entire CE RAM.

2016-07-27 Thread Emil Velikov
On 6 June 2016 at 16:46, Bas Nieuwenhuizen wrote: > On Mon, Jun 6, 2016 at 5:14 PM, Nicolai Hähnle wrote: >> On 06.06.2016 00:28, Bas Nieuwenhuizen wrote: >>> >>> This fixes a problem with the CE preamble and restoring only stuff in the >>> preamble when needed. >>> >>> To illustrate suppose we h

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-07-27 Thread Emil Velikov
On 6 June 2016 at 00:02, Vedran Miletić wrote: > On 06/04/2016 04:18 AM, Francisco Jerez wrote: >> >> Serge Martin writes: >> >>> From: Vedran Miletić >>> >>> Make sure that a struct argument did not get compiled into a pointer >>> type with the byval attribute. If we try to handle the pointer w

Re: [Mesa-dev] [PATCH 0/6] anv: Symbol visibility fixes et al

2016-07-27 Thread Emil Velikov
On 27 July 2016 at 14:02, Emil Velikov wrote: > Hi all, > > A small series which covers the following: > - Don't build the internal validate layer for release builds. The only > validate function uses only asserts thus is no-op, yet cannot the > optimiser cannot drop the ~10KiB of unused code. >

[Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Emil Velikov
From: Emil Velikov Presently the layer has only a single entry point, which uses asserts solely. Thus even on release builds the function (and thus the whole layer) will do nothing but adding runtime and binary(size) overhead. Cc: "12.0" Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- We c

[Mesa-dev] [PATCH 3/6] anv: automake: build with -Bsymbolic

2016-07-27 Thread Emil Velikov
From: Emil Velikov Explicitly suggested in the Loader interface version 2 section, but it's good idea either way. It essentially, ensures that our symbols are not interposed. Cc: "12.0" Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 1 + 1 file changed, 1 i

[Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

2016-07-27 Thread Emil Velikov
From: Emil Velikov The vkCmdDbgMarker{Begin,End} symbols are exported, yet the json does not that the driver supports the extension. Furturmore the functions are empty stubs. Remove those until we get a proper implementation and json notation. Cc: "12.0" Cc: Jason Ekstrand Signed-off-by: Emi

[Mesa-dev] [PATCH 6/6] isl: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

2016-07-27 Thread Emil Velikov
From: Emil Velikov Cc: "12.0" Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- src/intel/isl/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/isl/Makefile.am b/src/intel/isl/Makefile.am index 7c22324..1b1a357 100644 --- a/src/intel/isl/Makefile.am +++ b/src/intel/is

[Mesa-dev] [PATCH 2/6] anv: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

2016-07-27 Thread Emil Velikov
From: Emil Velikov Hide the internal symbols and annotate the vk_icdGetInstanceProcAddr as public since the loader needs it (as of v1 of the loader interface). Cc: "12.0" Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- Adding VISIBILITY_CFLAGS to AM_CPPFLAGS feels dirty, yet we don't have

[Mesa-dev] [PATCH 4/6] anv: do not export the Vulkan API

2016-07-27 Thread Emil Velikov
From: Emil Velikov With version 1 of the Loader interface there is an internal/private symbol (vk_icdGetInstanceProcAddr) which is used to retrieve all the API from the Vulkan entrypoints from the ICD. Implying that exposing the Vulkan API is not recommended. Version 2 goes a step further explic

[Mesa-dev] [PATCH 0/6] anv: Symbol visibility fixes et al

2016-07-27 Thread Emil Velikov
Hi all, A small series which covers the following: - Don't build the internal validate layer for release builds. The only validate function uses only asserts thus is no-op, yet cannot the optimiser cannot drop the ~10KiB of unused code. - Hide all* the symbols but vk_icdGetInstanceProcAddr fro

Re: [Mesa-dev] [PATCH] configure: additional libs for LLVM static linking

2016-07-27 Thread Emil Velikov
On 27 July 2016 at 12:36, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > configure.ac | 3 ++- > 1 file changed, 2 insertions(+), 1 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 5c196a9..58c2db4 1

Re: [Mesa-dev] [PATCH] configure: add support for LLVM 4.0.0svn static libs

2016-07-27 Thread Eric Engestrom
On Wed, Jul 27, 2016 at 01:36:16PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> Thanks! Reviewed-by: Eric Engestrom > --- > configure.ac | 2 +- > 1 file changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure.ac b/configure.a

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

2016-07-27 Thread Alejandro Piñeiro
On 26/07/16 22:16, Francisco Jerez wrote: > >>> -- However that spec change would have the side effect of making >>> the CTS test you're trying to fix non-compliant... >> This would not be the first case of a CTS test that is not correct due >> the complexities/ambiguities of the OpenGL spec. Or wo

Re: [Mesa-dev] [PATCH] configure: fix LLVM 4.0.0svn compilation, add libs for LLVM static linking

2016-07-27 Thread
On Wed, Jul 27, 2016 at 12:15 PM, Eric Engestrom wrote: > The version change is good and would get my r-b, but the LLVM_COMPONENTS > change would need some testing to make sure it doesn't interfere with > anything before enabling it for everyone. I am unable to imagine how it could interfere. ___

[Mesa-dev] [PATCH] configure: additional libs for LLVM static linking

2016-07-27 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 5c196a9..58c2db4 100644 --- a/configure.ac +++ b/configure.ac @@ -2194,6 +2194,7 @@ if test "x$enabl

[Mesa-dev] [PATCH] configure: add support for LLVM 4.0.0svn static libs

2016-07-27 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- configure.ac | 2 +- 1 file changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 5c196a9..58c2db4 100644 --- a/configure.ac +++ b/configure.ac @@ -2535,7 +2535,7 @@ if test "x$MESA_L

Re: [Mesa-dev] [PATCH] configure: fix LLVM 4.0.0svn compilation, add libs for LLVM static linking

2016-07-27 Thread Eric Engestrom
On Tue, Jul 26, 2016 at 09:54:27PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > configure.ac | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 5c196a9..58c2db4 100644 > --- a/c

Re: [Mesa-dev] [PATCH 2/3] gm107/ir: add a legalize SSA pass for PFETCH

2016-07-27 Thread Samuel Pitoiset
On 07/27/2016 01:24 AM, Ilia Mirkin wrote: On Tue, Jul 26, 2016 at 6:53 PM, Samuel Pitoiset wrote: PFETCH, actually ISBERD on GM107+ ISA only accepts a GPR for src0. Signed-off-by: Samuel Pitoiset --- .../nouveau/codegen/nv50_ir_lowering_gm107.cpp | 33 ++ .../nouve

Re: [Mesa-dev] [PATCH 1/3] nvc0: fix up TCP header on GM107+

2016-07-27 Thread Samuel Pitoiset
On 07/27/2016 01:32 AM, Ilia Mirkin wrote: On Tue, Jul 26, 2016 at 6:53 PM, Samuel Pitoiset wrote: The number of outputs patch (limited to 255) has moved in the TCP header, but blob seems to also set the old position. Also, the high 8-bits are now located inbetween the min/max parallel output

Re: [Mesa-dev] [PATCH v2 16/35] isl: Fix get_image_offset_sa_gen4_2d for multisample surfaces

2016-07-27 Thread Pohjolainen, Topi
On Tue, Jul 26, 2016 at 03:02:07PM -0700, Jason Ekstrand wrote: > The function takes a logical array layer but was assuming it was a physical > array layer. While we'er here, we also make it not assert-fail on gen9 3-D > surfaces. Looks good to me: Reviewed-by: Topi Pohjolainen > --- > src/in

Re: [Mesa-dev] [PATCH] glsl: free hash tables earlier

2016-07-27 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2016-07-27 at 09:52 +1000, Timothy Arceri wrote: > These are only used by get_matching_input() which has been call > at this point so free the hash tables. > --- >  src/compiler/glsl/link_varyings.cpp | 10 +++--- >  1 file changed, 3 insertions(+), 7 d

Re: [Mesa-dev] [PATCH] mesa: standardize naming Mesa3D, MESA -> Mesa

2016-07-27 Thread Vedran Miletić
On 07/26/2016 10:29 PM, Kenneth Graunke wrote: > On Tuesday, July 26, 2016 5:41:29 PM PDT Vedran Miletić wrote: >> On 07/15/2016 07:27 AM, Edward O'Callaghan wrote: >>> Reviewed-by: Edward O'Callaghan >>> >> >> Anything I can do to get this pushed? >> >> Regards, >> Vedran > > Pushed: > > To ssh

Re: [Mesa-dev] [PATCH v2 15/35] i965/blorp: Add an isl_view to blorp_surface_info

2016-07-27 Thread Pohjolainen, Topi
On Tue, Jul 26, 2016 at 11:26:34PM -0700, Jason Ekstrand wrote: >On Jul 26, 2016 10:41 PM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Tue, Jul 26, 2016 at 03:02:06PM -0700, Jason Ekstrand wrote: >> > Eventually, this will be the actual view that gets pa