Re: [Mesa-dev] what happened to libgallium.so ?

On 03.08.2016 18:09, Marek Olšák wrote: > It has always been statically linked as far as I remember. > libgallium.so is a Ubuntu speciality that we don't support. on win32 (using scons), it doesn't seem to be the case:

Re: [Mesa-dev] __func__ vs. __FUNCTION__

On 03.08.2016 12:20, Eric Engestrom wrote: > BTW, c99_compat.h has a #define for __func__ where needed, so this > change (removing use of __FUNCTION__) is a good one indeed :) Did a few experiments w/ gcc vs msvc. The common denominator is both define __FUNCTION__, so I moved there and dropped

Re: [Mesa-dev] OpenCL for radeon Hawaii?

It looks like CLBlast makes the same mistake that the CLU library did until recently (fixed in 435957d667bc22cdb2f0bdc32). It assumes that if your system has OpenCL 2.0 headers installed that the OpenCL platforms present on the system also support CL 2.0. In the case of Mesa, it doesn't support

Re: [Mesa-dev] [PATCH] egl/x11: avoid using freed memory if dri2 init fails

Thanks! See also related series here, which fixes the other platforms: https://lists.freedesktop.org/archives/mesa-dev/2016-August/125147.html On Sun, Jul 31, 2016 at 9:44 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Found with valgrind: > > ==4841== Invalid read of size 4 > ==4841==at

[Mesa-dev] [PATCH 2/4] egl/surfaceless: Set disp->DriverData to NULL on error

Avoid use-after-free on error. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/platform_surfaceless.c | 1 + 1 file changed, 1 insertion(+) diff

[Mesa-dev] [PATCH 3/4] egl/drm: Set disp->DriverData to NULL on error

Avoid use-after-free on error. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/platform_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 1/4] egl/wayland: Set disp->DriverData to NULL on error

Avoid use-after-free, fix spec@egl_khr_fence_sync@conformance. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Reported-by: Michel Dänzer Signed-off-by: Nicolas Boichat ---

[Mesa-dev] [PATCH 4/4] egl/android: Set dpy->DriverData to NULL on error

Avoid use-after-free on error. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/platform_android.c | 1 + 1 file changed, 1 insertion(+) diff

[Mesa-dev] [PATCH 0/4] egl/*: Set disp->DriverData to NULL on error

egl/x11 fixup has already be sent here: https://patchwork.freedesktop.org/patch/101934/ Compile-tested only (on android only). I was first thinking of modifying most functions in egl_dri2.c to take in dri2_egl_display *dri2_dpy instead of _EGLDisplay *disp as parameter, so we do not need to set

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

On Thu, Aug 4, 2016 at 9:38 AM, Michel Dänzer wrote: > On 04.08.2016 09:53, Nicolas Boichat wrote: >> On Thu, Aug 4, 2016 at 12:22 AM, Martin Peres >> wrote: >>> On 03/08/16 16:54, Nicolas Boichat wrote: In the case where

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

On 04.08.2016 09:53, Nicolas Boichat wrote: > On Thu, Aug 4, 2016 at 12:22 AM, Martin Peres > wrote: >> On 03/08/16 16:54, Nicolas Boichat wrote: >>> >>> In the case where dri2_initialize is called with a TestOnly display, >>> the display is not actually initialized,

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

On Thu, Aug 4, 2016 at 12:22 AM, Martin Peres wrote: > > > On 03/08/16 16:54, Nicolas Boichat wrote: >> >> In the case where dri2_initialize is called with a TestOnly display, >> the display is not actually initialized, so dri2_egl_display always >> fails, and we

Re: [Mesa-dev] c99 vs v90

On 03.08.2016 23:28, Jose Fonseca wrote: Hi, > There are minor inconsistencies. For example, it doesn't support > __func__, but doing > > #define __func__ __FUNCTION__ > > suffices to make __func__ work compatible. Wait a second ... IIRC, __FUNCTION__ was a non-standard gcc'ism - now msvc

Re: [Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/5] glsl: fix indentation, comments and line lengths in ast_function.cpp

Acked-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/5] glsl: apply_implicit_conversion is static again

Reviewed-by: Timothy Arceri On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > Signed-off-by: Andres Gomez > --- >  src/compiler/glsl/ast_function.cpp | 4 >  src/compiler/glsl/ast_to_hir.cpp   | 2 +- >  2 files changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > When an argument for a structure constructor or initializer doesn't > match the expected type, only Section 4.1.10 “Implicit Conversions” > are allowed to try to match that expected type. > > From page 32 (page 38 of the PDF) of the GLSL

Re: [Mesa-dev] [PATCH 4/6] util/rgb9e5: Get rid of the float754 union

Am 03.08.2016 um 20:09 schrieb Jason Ekstrand: > There are a number of reasons for this refactor. First, format_rgb9e5.h is > not something that a user would expect to define such a generic union. > Second, defining it requires checking for endianness which is ugly. Third, > 90% of what we were

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

Nayan Deshmukh wrote: Hi Christian On Wed, Aug 3, 2016 at 6:16 PM, Christian König wrote: Sorry for the delay I've been on vacation for a week. Good to hear back from you !! Where you able to fix the problem Andy reported? I was able to rather easily reproduce

Re: [Mesa-dev] [PATCH 2/5] glsl: Refactor implicit conversion into its own helper

On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > Signed-off-by: Andres Gomez > --- >  src/compiler/glsl/ast_function.cpp | 79 +++- > -- >  1 file changed, 47 insertions(+), 32 deletions(-) > > diff --git

[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

Implicit conversions were added in the GLSL 1.20 spec version. v2 (Timothy): Join the checks for GLSL 1.10 and ESSL. Signed-off-by: Andres Gomez --- src/compiler/glsl_types.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

On Thu, 2016-08-04 at 08:53 +1000, Timothy Arceri wrote: > On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > > Implicit conversions were added in the GLSL 1.20 spec version. > > > > Signed-off-by: Andres Gomez > > --- > >  src/compiler/glsl_types.cpp | 4 > >  1

Re: [Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote: > Implicit conversions were added in the GLSL 1.20 spec version. > > Signed-off-by: Andres Gomez > --- >  src/compiler/glsl_types.cpp | 4 >  1 file changed, 4 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 39/95] i965/vec4: dump the instruction execution size

Reviewed-by: Francisco Jerez Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp >

Re: [Mesa-dev] [PATCH 2/2 v2] mesa: Dynamically allocate the matrix stack.

Reviewed-by: Brian Paul On 08/03/2016 03:22 PM, Eric Anholt wrote: By allocating and initializing the matrices at context creation, the OS can't even overcommit the pages. This saves about 63k (out of 946k) of maximum memory size according to massif on simulated vc4

Re: [Mesa-dev] [PATCH 40/95] i965/vec4: add a SIMD lowering pass

Iago Toral Quiroga writes: > Generally, instructions in Align16 mode only ever write to a single > register and don't need anny form of SIMD splitting, that's why we > have never had a SIMD splitting pass in the vec4 backend. However, > double-precision instructions typically

Re: [Mesa-dev] c99 vs v90

On 03/08/16 09:43, Enrico Weigelt, metux IT consult wrote: On 03.08.2016 09:47, Timothy Arceri wrote: The current requirement for Mesa is MSVC 2013 so any compat workarounds for functionality supported by that version can be dropped. A bunch of stuff has been dropped already but feel free to

[Mesa-dev] [PATCH 2/2 v2] mesa: Dynamically allocate the matrix stack.

By allocating and initializing the matrices at context creation, the OS can't even overcommit the pages. This saves about 63k (out of 946k) of maximum memory size according to massif on simulated vc4 glsl-algebraic-add-add-1. It also means we could potentially relax the maximum stack sizes, but

[Mesa-dev] [PATCH 3/3] radeonsi: move spi_ps_input_addr override outside of the loop

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 455f604..64c367e 100644 ---

[Mesa-dev] [PATCH 1/3] radeonsi: do not pass the return type to buffer_load_const

From: Nicolai Hähnle Overriding it is not allowed anyway, and actually lead to a crash when polygon stippling was used with monolithic shaders. --- src/gallium/drivers/radeonsi/si_shader.c | 36 1 file changed, 18 insertions(+), 18

[Mesa-dev] [PATCH 2/3] radeonsi: drop unnecessary u_pstipple.h include

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 0aae097..455f604 100644 ---

[Mesa-dev] [PATCH 3/5] glsl: struct constructors/initializers only allow implicit conversions

When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. From page 32 (page 38 of the PDF) of the GLSL 1.20 spec: " The arguments to the constructor will be used to

[Mesa-dev] [PATCH v2 0/5] struct constructors/initializers only allow implicit conversions

When an argument for a structure constructor or initializer doesn't match the expected type, only Section 4.1.10 “Implicit Conversions” are allowed to try to match that expected type. Fixes GL44-CTS.shading_language_420pack.initializer_list_negative Andres Gomez (5): glsl/types: disallow

[Mesa-dev] [PATCH 5/5] glsl: fix indentation, comments and line lengths in ast_function.cpp

Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_function.cpp | 880 +++-- 1 file changed, 460 insertions(+), 420 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 52cbf1f..817673a

[Mesa-dev] [PATCH 2/5] glsl: Refactor implicit conversion into its own helper

Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_function.cpp | 79 +++--- 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 9dcec50..567ad6e

[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

Implicit conversions were added in the GLSL 1.20 spec version. Signed-off-by: Andres Gomez --- src/compiler/glsl_types.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp index 8a06695..24aec25 100644 ---

[Mesa-dev] [PATCH 4/5] glsl: apply_implicit_conversion is static again

Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_function.cpp | 4 src/compiler/glsl/ast_to_hir.cpp | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index ccd070f..52cbf1f

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote: > On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote: > > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: > > [snip] > > > diff --git a/src/compiler/glsl/ast_function.cpp > > > b/src/compiler/glsl/ast_function.cpp > > > index

Re: [Mesa-dev] OpenCL for radeon Hawaii?

Hi, you can use clinfo utility to check whether OpenCL has been setup correctly. It won't be able to run luxmark, but simpler stuff should work. Jan On Wed, 2016-08-03 at 20:45 +0100, Sam Halliday wrote: > Hello everybody, > > I recently got a Radeon R9 290x (aka Hawaii). I run ArchLinux,

Re: [Mesa-dev] [PATCH 36/95] i965/vec4: add a helper function to create double immediates

Iago Toral Quiroga writes: > Gen7 hardware does not support double immediates so these need > to be moved in 32-bit chunks to a regular vgrf instead. Instead > of doing this every time we need to create a DF immediate, > create a helper function that does the right thing

[Mesa-dev] [PATCH 1/2] anv/clear: Make cmd_clear_image take an actual VkClearValue

Cc: "12.0" --- src/intel/vulkan/anv_meta_clear.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_meta_clear.c b/src/intel/vulkan/anv_meta_clear.c index e399498..fa07ec1 100644 ---

[Mesa-dev] [PATCH 2/2] anv/clear: Clear E5B9G9R9 images as R32_UINT

We can't actually clear these images normally because we can't render to them. Instead, we have to manually unpack the rgb9e5 color value on the CPU and clear it as R32_UINT. We still have a bit of work to do to clear non-power-of-two images, but this should get all of the power-of-two clears

Re: [Mesa-dev] OpenCL for radeon Hawaii?

Without commenting on the opencl question(which should be supported, but perhaps not a late enough spec version that your programs require), you should be able to get all the necessary functionality by writing opengl compute programs, supported in both desktop core and es profiles. On Aug 3, 2016

[Mesa-dev] OpenCL for radeon Hawaii?

Hello everybody, I recently got a Radeon R9 290x (aka Hawaii). I run ArchLinux, which has mesa 12.0.1. I am keen to try out mesa's partial OpenCL implementation. Ideally to use a BLAS implementation such as https://github.com/CNugteren/CLBlast but I'd also be happy to just write something basic

Re: [Mesa-dev] dead code

On Wed, Aug 3, 2016 at 2:48 PM, Rob Clark wrote: > On Wed, Aug 3, 2016 at 2:18 PM, Enrico Weigelt, metux IT consult > wrote: >> On 03.08.2016 13:25, Rob Clark wrote: >> >>> Probably it would be on a case-by-case basis. There are at least a >>> few

Re: [Mesa-dev] [PATCH 5/7] radeonsi: add has_draw_indirect_multi flag

On 03.08.2016 19:43, Marek Olšák wrote: Is this for the latest version of the MULTI packets and not the first one without indirect_count? According to the firmware person, it's for the latest version of those packets. Nicolai Marek On Tue, Aug 2, 2016 at 9:41 PM, Nicolai Hähnle

[Mesa-dev] [PATCH v2 2/2] anv/blit2d: Add support for RGB destinations

This fixes 104 of the new image_clearing and copy_and_blit Vulkan CTS tests. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/intel/vulkan/anv_meta_blit2d.c | 216 - 1 file changed, 214 insertions(+),

Re: [Mesa-dev] dead code

On Wed, Aug 3, 2016 at 2:18 PM, Enrico Weigelt, metux IT consult wrote: > On 03.08.2016 13:25, Rob Clark wrote: > >> Probably it would be on a case-by-case basis. There are at least a >> few places with some useful debug code, ie. not the kind that you'd >> normally

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

Hi Christian On Wed, Aug 3, 2016 at 6:16 PM, Christian König wrote: > Sorry for the delay I've been on vacation for a week. > > Good to hear back from you !! > Where you able to fix the problem Andy reported? I was able to rather > easily reproduce that. > > I have

Re: [Mesa-dev] dead code

On 03.08.2016 13:25, Rob Clark wrote: > Probably it would be on a case-by-case basis. There are at least a > few places with some useful debug code, ie. not the kind that you'd > normally enable, but stuff you'd want if you were making changes in > those areas.. In those cases, shouldn't we

Re: [Mesa-dev] [PATCH 4/7] radeonsi: transpose indirect/index draw dispatch

Patches 1-4: Reviewed-by: Marek Olšák Marek On Tue, Aug 2, 2016 at 9:41 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This allows better code sharing for indirect draw calls. > --- >

[Mesa-dev] [PATCH 5/6] util/format: Use explicitly sized types

Both the rgb9e5 and r11g11b10 formats are defined based on how they are packed into a 32-bit integer. It makes sense that the functions that manipulate them take an explicitly sized type. Signed-off-by: Jason Ekstrand --- src/util/format_r11g11b10f.h | 10 ++

[Mesa-dev] [PATCH 4/6] util/rgb9e5: Get rid of the float754 union

There are a number of reasons for this refactor. First, format_rgb9e5.h is not something that a user would expect to define such a generic union. Second, defining it requires checking for endianness which is ugly. Third, 90% of what we were doing with the union was float <-> uint32_t bitcasts

[Mesa-dev] [PATCH 0/6] util: Clean up rgb9e5 and r11g11b10f

This little series pulls the helpers for rgb9e5 and r11g11b10f into src/util and cleans them up a bit. We've been using them from both gallium and mesa main for quite some time now but, since they were header-only, they got left in gallium. Jason Ekstrand (6): util: Move format_rgb9e5.h to

[Mesa-dev] [PATCH 2/6] util: Move format_r11g11b10f.h to src/util

It's used from both mesa main and gallium. Signed-off-by: Jason Ekstrand --- src/gallium/auxiliary/Makefile.sources | 1 - src/gallium/auxiliary/util/u_format_other.c | 2 +- src/gallium/auxiliary/util/u_format_r11g11b10f.h | 232 ---

[Mesa-dev] [PATCH 6/6] util/r11g11b10f: Whitespace cleanups

Signed-off-by: Jason Ekstrand --- src/util/format_r11g11b10f.h | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/src/util/format_r11g11b10f.h b/src/util/format_r11g11b10f.h index 5fe2e51..c9e967c 100644 ---

[Mesa-dev] [PATCH 3/6] util/format_rgb9e5: Get rid of the rgb9e5 union

The rgb9e5 format is a packed format defined in terms of slicing up a single 32-bit value. The bitfields are far more confusing than simple shifts and require that we check the endianness. Signed-off-by: Jason Ekstrand --- src/util/format_rgb9e5.h | 38

[Mesa-dev] [PATCH 1/6] util: Move format_rgb9e5.h to src/util

It's used from both mesa main and gallium. Signed-off-by: Jason Ekstrand --- src/gallium/auxiliary/Makefile.sources| 1 - src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c | 2 +- src/gallium/auxiliary/util/u_format_other.c | 2 +-

Re: [Mesa-dev] [PATCH 6/7] radeonsi: program multi draw and indirect draw count parameters

On Tue, Aug 2, 2016 at 10:18 PM, Nicolai Hähnle wrote: > Bas pointed out some things that mean this patch (and the next) probably > need to be reworked. The tests were probably not thorough enough. I think that all indirect parameters are read by PFP. Our cache flush sequence

Re: [Mesa-dev] [PATCH] loader: fix memory leak in loader_dri3_open

Jan Ziak <0xe2.0x9a.0...@gmail.com> writes: > Found via "valgrind --leak-check=full glxgears". Pushed. Thanks! signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] gbm: Correct bo_import documentation (trivial)

Ben Widawsky writes: > Missed here: > commit a43d286ef7ff65087b1f051d071b829ca7b02073 > Author: Kristian Høgsberg > Date: Fri Mar 28 10:17:11 2014 -0700 > > gbm: Add import from fd > > Cc: Kristian Høgsberg > Signed-off-by: Ben

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

https://bugs.freedesktop.org/show_bug.cgi?id=93089 Lauri Kasanen changed: What|Removed |Added OS|OpenBSD |All

Re: [Mesa-dev] what happened to libgallium.so ?

libgallium.so was an awful idea. Just a few days ago we had an internal bug report because libgallium.so symbols were clashing with the application symbols. This is because all that libgallium.so export all gallium symbols, even though they have no unique prefix -- it uses common symbols

Re: [Mesa-dev] [PATCH 5/7] radeonsi: add has_draw_indirect_multi flag

Is this for the latest version of the MULTI packets and not the first one without indirect_count? Marek On Tue, Aug 2, 2016 at 9:41 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Prefer to use DRAW_(INDEX)_INDIRECT_MULTI when available in the

Re: [Mesa-dev] [PATCH 2/2] mesa: Dynamically allocate the matrix stack.

Just two minor things below. On 08/03/2016 11:27 AM, Eric Anholt wrote: By allocating and initializing the matrices at context creation, the OS can't even overcommit the pages. This saves about 63k (out of 946k) of maximum memory size according to massif on simulated vc4

Re: [Mesa-dev] [PATCH 1/2] state_tracker: Initialize the draw context only when needed.

Reviewed-by: Brian Paul On 08/03/2016 11:27 AM, Eric Anholt wrote: It's only used for rarely-used deprecated GL features (feedback/rasterpos), so we can skip the memory allocation and initialization for it most of the time. Saves about 659k (out of 1605k) of maximum memory

[Mesa-dev] [PATCH 2/2] mesa: Dynamically allocate the matrix stack.

By allocating and initializing the matrices at context creation, the OS can't even overcommit the pages. This saves about 63k (out of 946k) of maximum memory size according to massif on simulated vc4 glsl-algebraic-add-add-1. It also means we could potentially relax the maximum stack sizes, but

[Mesa-dev] [PATCH 1/2] state_tracker: Initialize the draw context only when needed.

It's only used for rarely-used deprecated GL features (feedback/rasterpos), so we can skip the memory allocation and initialization for it most of the time. Saves about 659k (out of 1605k) of maximum memory size according to massif on simulated vc4 glsl-algebraic-add-add-1 ---

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

On 03/08/16 16:54, Nicolas Boichat wrote: In the case where dri2_initialize is called with a TestOnly display, the display is not actually initialized, so dri2_egl_display always fails, and we cannot do any reference counting. Fixes piglit spec@egl_khr_create_context@verify gl flavor

Re: [Mesa-dev] what happened to libgallium.so ?

It has always been statically linked as far as I remember. libgallium.so is a Ubuntu speciality that we don't support. Marek On Wed, Aug 3, 2016 at 10:45 AM, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > > I'm currently backporting latest mesa to Ubuntu

Re: [Mesa-dev] __func__ vs. __FUNCTION__

On Wed, Aug 03, 2016 at 11:41:58AM +0200, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > > I've seen we're using __func__ as well as __FUNCTION__. > Should we consolidate that ? Quick comment, but for small questions like these asking on IRC (#dri-devel on freenode) tends to be much

Re: [Mesa-dev] non-shared glapi still needed ?

On 08/02/2016 06:40 PM, Enrico Weigelt, metux IT consult wrote: Hi folks, is there still a real need for having non-shared glapi ? Otherwise, should we remove it ? +1 I have the same question. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v2] i965: use mt->offset in intel_miptree_map_movntdqa().

On 08/02/2016 08:09 PM, Kenneth Graunke wrote: On Tuesday, August 2, 2016 5:03:32 PM PDT Haixia Shi wrote: We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc:

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

Sorry for the delay I've been on vacation for a week. Where you able to fix the problem Andy reported? I was able to rather easily reproduce that. Leave out level 8&9 is clearly a good idea and I'm rather eager to commit this set now if it doesn't show any more obvious problems. Regards,

Re: [Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix transfer destination formats

On Aug 3, 2016 5:53 AM, "Lionel Landwerlin" wrote: > > We let the user believe we support some transfer destination formats > which we don't. This can lead to crashes when actually trying to use > those formats for example on >

[Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

In the case where dri2_initialize is called with a TestOnly display, the display is not actually initialized, so dri2_egl_display always fails, and we cannot do any reference counting. Fixes piglit spec@egl_khr_create_context@verify gl flavor (reproducible with LIBGL_ALWAYS_SOFTWARE=1) and

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

On Wed, Aug 3, 2016 at 9:38 PM, Rob Herring wrote: > On Tue, Aug 2, 2016 at 9:27 PM, Tomasz Figa wrote: >> Hi Rob, >> >> On Wed, Aug 3, 2016 at 2:32 AM, Rob Herring wrote: >>> On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

On Tue, Aug 2, 2016 at 9:27 PM, Tomasz Figa wrote: > Hi Rob, > > On Wed, Aug 3, 2016 at 2:32 AM, Rob Herring wrote: >> On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: >>> From: Nicolas Boichat >>> >>> Existing

Re: [Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

Hi Christian, That deqp failure was due to my deqp setup that always used 16Kx16K framebuffers. I'm dropping this patch because it's obviously silly. It at least raised awareness of this issue. Marek On Aug 2, 2016 7:30 PM, "Christian König" wrote: > Am 02.08.2016 um

Re: [Mesa-dev] [PATCH mesa] glx/dri3: remove never-used field

Your patch created rev4 at https://patchwork.freedesktop.org/series/10429/ I just created rev5 which no longer includes field hasPresent. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] dead code

On Wed, Aug 3, 2016 at 5:00 AM, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > > I've seen quite a lot of #if 0's - looks like dead code. > Should we remove that ? > Probably it would be on a case-by-case basis. There are at least a few places with some useful

[Mesa-dev] [PATCH] dri: use 'bool' instead of 'int' for boolean variables

Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/egl/drivers/dri2/egl_dri2.h | 19 ++- src/egl/drivers/dri2/platform_drm.c | 6 +++--- src/egl/drivers/dri2/platform_wayland.c | 20 ++--

[Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix transfer destination formats

We let the user believe we support some transfer destination formats which we don't. This can lead to crashes when actually trying to use those formats for example on dEQP-VK.api.copy_and_blit.image_to_image.* tests. Allow formats we can render to as meta implements transfers using attachments.

Re: [Mesa-dev] __func__ vs. __FUNCTION__

On Wed, Aug 03, 2016 at 11:41:58AM +0200, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > > I've seen we're using __func__ as well as __FUNCTION__. > Should we consolidate that ? > > > --mtx Hi, To reply this and your other questions, I think you should just send those patches and

[Mesa-dev] __func__ vs. __FUNCTION__

Hi folks, I've seen we're using __func__ as well as __FUNCTION__. Should we consolidate that ? --mtx ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/3] RadeonSI GLSL "lit" tests

On 03.08.2016 01:28, Marek Olšák wrote: On Tue, Aug 2, 2016 at 9:23 PM, Nicolai Hähnle wrote: On 02.08.2016 21:06, Marek Olšák wrote: On Tue, Aug 2, 2016 at 3:40 PM, Nicolai Hähnle wrote: On 31.07.2016 22:29, Marek Olšák wrote: Inspired by

[Mesa-dev] dead code

Hi folks, I've seen quite a lot of #if 0's - looks like dead code. Should we remove that ? --mtx ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] what happened to libgallium.so ?

Hi folks, I'm currently backporting latest mesa to Ubuntu Trusty, starting with their original deb files. One problem I stumbled across is that libgallium.so isn't built/installed anymore - it seems that it's now statically linked into all the drivers. What happened to that so ? Why now

Re: [Mesa-dev] c99 vs v90

On 03.08.2016 09:47, Timothy Arceri wrote: > The current requirement for Mesa is MSVC 2013 so any compat workarounds > for functionality supported by that version can be dropped. > > A bunch of stuff has been dropped already but feel free to find any > remaining code. hmm, I dont have any msvc

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

On Mon, Aug 17, 2015 at 03:17:30PM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > "X rendering calls made prior to glXWaitX are guaranteed to be > > executed before GL rendering calls made after glXWaitX." > > > > The goal is to implement that without adding a

Re: [Mesa-dev] Mesa (master): egl/dri2: Add reference count for dri2_egl_display

Hi, On Tue, Aug 2, 2016 at 7:21 PM, Martin Peres wrote: > On 29/07/16 09:20, Michel Dänzer wrote: >> >> On 28.07.2016 22:11, Emil Velikov wrote: >>> >>> Module: Mesa >>> Branch: master >>> Commit: 9ee683f877b283020c6f24776236f1145cb7a4ea >>> URL: >>>

Re: [Mesa-dev] [PATCH] main/shaderimage: image unit invalid if texture is incomplete, independently of the level

On 27/07/16 13:47, Alejandro Piñeiro wrote: > On 26/07/16 22:16, Francisco Jerez wrote: -- However that spec change would have the side effect of making the CTS test you're trying to fix non-compliant... >>> This would not be the first case of a CTS test that is not correct due >>> the

Re: [Mesa-dev] c99 vs v90

On Wed, 2016-08-03 at 08:27 +0200, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > > do we still need to support pre-c99 compilers or could we drop > that compat stuff ? The problem we have had is Microsoft Visual C doesn't fully support c99 although Microsoft has finally been adding

[Mesa-dev] c99 vs v90

Hi folks, do we still need to support pre-c99 compilers or could we drop that compat stuff ? --mtx ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev