Re: [Mesa-dev] [PATCH 1/5] r100: Don't advertise OpenGL ES 1.1

On 05/30/2017 08:27 PM, Kenneth Graunke wrote: > On Tuesday, May 30, 2017 5:40:26 PM PDT Ian Romanick wrote: >> From: Ian Romanick >> >> EXT_point_parameters is required, but it is not supported by radeon. >> >> Fixes piglit's egl-create-context-verify-gl-flavor test. >>

Re: [Mesa-dev] [RFC] some glsl->tgsi optimisations

On 30 May 2017 at 22:31, Ilia Mirkin wrote: > Is this a reimplementation of the same algorithm in a more efficient > manner, or an implementation of a different algorithm which happens to > also run faster? The reason I ask is whether I should be seeing any > differences in

Re: [Mesa-dev] [PATCH] radv: Revert HTILE reset word to 0xFFFFFFFF.

On 31 May 2017 at 08:57, Bas Nieuwenhuizen wrote: > Dyanamic lighting stops working in the benchmark. > > Not entirely root caused yet, I actually suspect this unhides a bug, > in that 0x might have cleared something that 0x30f doesn't (If > I completely disable

Re: [Mesa-dev] [PATCH 1/5] r100: Don't advertise OpenGL ES 1.1

On Tuesday, May 30, 2017 5:40:26 PM PDT Ian Romanick wrote: > From: Ian Romanick > > EXT_point_parameters is required, but it is not supported by radeon. > > Fixes piglit's egl-create-context-verify-gl-flavor test. > > Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 1/4] glsl: simplify +INF check

ir_reader and S-expression parsing are only used by the unit tests for lower_jumps(). They're not used during actual compilation at all. If it weren't for those unit tests, I'd be happy to see them deleted. On Tuesday, May 30, 2017 4:34:11 PM PDT Ian Romanick wrote: > Ken: Is this code still

Re: [Mesa-dev] [PATCH 4/4] glx: use memcmp instead of strncmp

2017-05-31 2:42 GMT+03:00 Ian Romanick : > Same comment here as on patch 3. > The size of glxextensions.o is decreased by 8 bytes in debug build (I am not sure why), so in that regard there is next to no benefit. But the main reason behind this change was not the size but

Re: [Mesa-dev] [PATCH 2/4] glsl: trivial change of the file extension matching

2017-05-31 2:39 GMT+03:00 Ian Romanick : > On 05/30/2017 03:45 PM, Vlad Golovkin wrote: >> --- >> src/compiler/glsl/standalone.cpp | 17 ++--- >> 1 file changed, 10 insertions(+), 7 deletions(-) >> >> diff --git a/src/compiler/glsl/standalone.cpp >>

Re: [Mesa-dev] Proposal to branch off old drivers

On 31/05/17 10:38, Ian Romanick wrote: How many times do people have to say NO to this proposal until it goes away? Maybe you could tell me? Nobody has explicitly said no. There have been concerns that the reasons for splitting them of are not compelling enough, but nobody has said no, if

Re: [Mesa-dev] [PATCH 2/4] glsl: make ast_node destructor virtual

This patch is Reviewed-by: Ian Romanick On 05/30/2017 01:47 PM, Rob Herring wrote: > Make ast_node destructor virtual to fix the following clang warning: > > src/compiler/glsl/ast.h:51:4: warning: destructor called on non-final > 'ast_node' that has virtual functions

Re: [Mesa-dev] [PATCH 4/4] mesa/main: drop needless condition check in _mesa_GetPerfCounterInfoINTEL

I've seen this warning a million times, and I always talk myself out of fixing it. If the type of counterIndex ever changes to int (or another signed type), this will break. It may not be obvious at the time of the break that it happened, and it will likely be annoying to debug. I'm not NAKing

Re: [Mesa-dev] [PATCH 00/30] i965: Overhaul resolves

On Sat, May 27, 2017 at 6:44 PM, Jason Ekstrand wrote: > On Fri, May 26, 2017 at 5:34 PM, Jason Ekstrand > wrote: > >> On Fri, May 26, 2017 at 4:30 PM, Jason Ekstrand >> wrote: >> >>> This patch series does a complete overhaul

Re: [Mesa-dev] [PATCH 28/30] i965: Use the new tracking mechanism for HiZ

On Fri, May 26, 2017 at 4:30 PM, Jason Ekstrand wrote: > This is similar to the previous commit only for HiZ. For HiZ, apart > from everything looking different, there is really only one functional > change: We now track the ISL_AUX_STATE_COMPRESSED_NO_CLEAR state. >

Re: [Mesa-dev] [PATCH 19/30] i965: Move color rendering to the new resolve functions

On Fri, May 26, 2017 at 4:30 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_context.c | 35 +++ > src/mesa/drivers/dri/i965/brw_draw.c | 4 +-- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 48 >

Re: [Mesa-dev] [PATCH 3/4] mesa/main: fix gl_buffer_index enum comparison

This patch is Reviewed-by: Ian Romanick On 05/30/2017 01:47 PM, Rob Herring wrote: > For clang, enums are unsigned by default and gives the following warning: > > external/mesa3d/src/mesa/main/buffers.c:764:21: warning: comparison of > constant -1 with expression of

Re: [Mesa-dev] [PATCH 01/13] gallium/dri: always link against shared glapi

On 30 May 2017 at 22:37, Juan A. Suarez Romero wrote: > On Fri, 2017-04-28 at 14:14 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> In the early days of Xorg and Mesa we had multiple providers of the >> GLAPI. All of those were the ones

[Mesa-dev] [PATCH 08/11] intel/isl: Add a new layout for HiZ and stencil on Sandy Bridge

--- src/intel/isl/isl.c | 162 ++-- src/intel/isl/isl.h | 40 + 2 files changed, 197 insertions(+), 5 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 77b8a40..e4d7901 100644 --- a/src/intel/isl/isl.c +++

[Mesa-dev] [PATCH 11/11] intel/blorp: Handle gen6 stencil/HiZ offsets in the back-end

--- src/intel/blorp/blorp_genX_exec.h| 32 - src/intel/isl/isl_emit_depth_stencil.c | 1 + src/mesa/drivers/dri/i965/brw_blorp.c| 61 src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +-

[Mesa-dev] [PATCH 03/11] intel/isl: Refactor isl_calc_array_pitch_el_rows

Over 90% of the function only applies to ISL_DIM_LAYOUT_GEN4_2D anyway so we can just handle the other two as special cases at the top. The two "generic" cases below the switch only apply on gen9 and above and only to 3D or CCS surfaces. This implies that they only apply to surfaces with

[Mesa-dev] [PATCH 04/11] intel/isl: Add an isl_assert_div helper

This is a fairly common operation and it's nice to be able to just call the one little function. --- src/intel/isl/isl_priv.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/isl/isl_priv.h b/src/intel/isl/isl_priv.h index 3c4cc1e..186e84d 100644 --- a/src/intel/isl/isl_priv.h

[Mesa-dev] [PATCH 10/11] intel/isl: Add a helper for getting the byte/tile offset of a subimage

Frequently, get_image_offset_sa is combined with get_intratile_offset_sa so it makes sense to have a single helper to do both. If the caller doesn't want the intratile offsets, it can simply pass NULL and ISL will assert that they are 0. --- src/intel/blorp/blorp_blit.c | 13 -

[Mesa-dev] [PATCH 05/11] intel/isl: Refactor to use a phys_total_el extent.

We've already implicitly been using a physical total size in surface elements. This just centralizes things a bit. --- src/intel/isl/isl.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

[Mesa-dev] [PATCH 09/11] intel/isl: Make get_intratile_offset_el take the element size in bits

From: Jason Ekstrand --- src/intel/isl/isl.c| 7 +++ src/intel/isl/isl.h| 6 ++ src/mesa/drivers/dri/i965/intel_blit.c | 2 +- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 00/11] intel/isl: Add support for HiZ and stencil on gen6

This little series adds support to ISL for gen6 HiZ ans stencil via a new isl_dim_layout enum value. Unfortunately, I couldn't easily add the new layout without doing a little refactoring. The way ISL likes to calculate surface layouts today is fairly heavily based on the needs of 2D array

[Mesa-dev] [PATCH 02/11] intel/isl: Move isl_calc_array_pitch_el_rows higher up

--- src/intel/isl/isl.c | 234 ++-- 1 file changed, 117 insertions(+), 117 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index f0e948a..b573f0d 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -712,6 +712,123 @@

[Mesa-dev] [PATCH 07/11] intel/isl: Generate phys_total_el from isl_calc_phys_extent

The only surface layout for which slice0 makes any sense is GEN4_2D. Move all of the slice0 stuff into isl_calc_phys_total_extent_el_gen4_2d and make the others trivially return the total size in surface elements. As a side-effect, array_pitch_el_rows is now returned from these helpers as well.

[Mesa-dev] [PATCH 01/11] intel/isl: Remove the device parameter from isl_tiling_get_info

We were only using it for validating that we don't use Ys/Yf on gen8 and earlier. Removing it from isl_tiling_get_info lets us remove it from a bunch of other things that had no business needing a hardware generation. --- src/intel/blorp/blorp_blit.c | 4 ++-- src/intel/isl/isl.c

[Mesa-dev] [PATCH 06/11] intel/isl: Don't check array pitch for gen4 3D textures

Array pitch doesn't matter in this layout. --- src/intel/isl/tests/isl_surf_get_image_offset_test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/isl/tests/isl_surf_get_image_offset_test.c b/src/intel/isl/tests/isl_surf_get_image_offset_test.c index 1b3dc58..05fd79f 100644 ---

Re: [Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

I don't understand these warnings, and I have even less understanding of how "using" fixes them. For example... On 05/30/2017 01:47 PM, Rob Herring wrote: > clang gives warnings about overloaded virtual functions: > > src/compiler/glsl/linker.cpp:244:30: warning: '(anonymous >

Re: [Mesa-dev] [PATCH 6/6] glsl: fix a crash in ir_print_visitor() for bindless samplers/images

This patch is Reviewed-by: Ian Romanick On 05/25/2017 11:07 AM, Samuel Pitoiset wrote: > Bindless samplers/images are represented with 64-bit unsigned > integers and they can be assigned with explicit constructors. > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 5/6] glsl: teach opt_array_splitting about bindless images

On 05/25/2017 11:07 AM, Samuel Pitoiset wrote: > Memory/format layout qualifiers shouldn't be lost when arrays > of images are splitted by this pass. > > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl/opt_array_splitting.cpp | 17 +++-- > 1 file

Re: [Mesa-dev] [PATCH 6/6] glsl: fix a crash in ir_print_visitor() for bindless samplers/images

Reviewed-by: Timothy Arceri On 26/05/17 04:07, Samuel Pitoiset wrote: Bindless samplers/images are represented with 64-bit unsigned integers and they can be assigned with explicit constructors. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 4/6] glsl: teach opt_structure_splitting about images in structures

On 05/25/2017 11:07 AM, Samuel Pitoiset wrote: > GL_ARB_bindless_texture allows images to be declared inside > structures, but when memory/format qualifiers are used, they > should be propagated when structures are splitted. split. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 5/6] glsl: teach opt_array_splitting about bindless images

Again I'd rather contains_image() -> without_array()->is_image() The array we a splitting could contain a struct, nested struct etc. There is no need to recurse the structs/interface and attempt to copy the empty memory qualifiers. With that change: Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH 1/6] glsl: handle memory qualifiers for struct with array of images

On 05/25/2017 11:07 AM, Samuel Pitoiset wrote: > This handles a situation like: > > struct { >image2D imgs[6]; > } s; Without looking at the surrounding code... does this also handle cases like: struct S { image2D imgs[6]; }; struct { S s } s; > > Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 3/5] r100, r200: Don't assume glVisual is non-NULL during context creation

From: Ian Romanick Thanks to EGL_MESA_configless_context, the visual pointer can be NULL. Fixes a segfault (or assertion failure) in piglit's egl-configless-context test. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 5/5] r100: Silence numerous unused this or that warnings

From: Ian Romanick radeon_fbo.c: In function ‘radeon_map_renderbuffer_s8z24’: radeon_fbo.c:147:50: warning: unused parameter ‘ctx’ [-Wunused-parameter] radeon_map_renderbuffer_s8z24(struct gl_context *ctx, ^~~

[Mesa-dev] [PATCH 4/5] r100: Use _mesa_get_format_base_format in radeon_update_wrapper

From: Ian Romanick The wrapper is for a renderbuffer around a texture. Textures can have formats (e.g., 3) that aren't valide for API generated renderbuffers. _mesa_base_fbo_format will return 0, but _mesa_get_format_base_format will return the base format of RGB.

[Mesa-dev] [PATCH 1/5] r100: Don't advertise OpenGL ES 1.1

From: Ian Romanick EXT_point_parameters is required, but it is not supported by radeon. Fixes piglit's egl-create-context-verify-gl-flavor test. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 2/5] r100: Don't assume that the base mipmap of a texture exists

From: Ian Romanick Fixes crashes in piglit's gl-1.2-texture-base-level. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/radeon/radeon_texstate.c | 14 ++ 1 file changed, 10

Re: [Mesa-dev] [PATCH 4/6] glsl: teach opt_structure_splitting about images in structures

On 26/05/17 04:07, Samuel Pitoiset wrote: GL_ARB_bindless_texture allows images to be declared inside structures, but when memory/format qualifiers are used, they should be propagated when structures are splitted. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] Proposal to branch off old drivers

How many times do people have to say NO to this proposal until it goes away? On 05/25/2017 05:45 PM, Timothy Arceri wrote: > Hi all, > > Following on from the discussion here: > > https://lists.freedesktop.org/archives/mesa-dev/2017-May/155971.html > > Back in 2011/12 despite various concerns

Re: [Mesa-dev] [PATCH 2/6] glsl: handle format layout qualifiers for struct with array of images

Patches 1-2: Reviewed-by: Timothy Arceri On 26/05/17 04:07, Samuel Pitoiset wrote: This handles a situation like: struct { layout (r32f) image2D imgs[6]; } s; Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp | 3 ++-

Re: [Mesa-dev] [PATCH 3/6] glsl: fix broken indentation in do_structure_splitting()

Reviewed-by: Timothy Arceri On 26/05/17 04:07, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/opt_structure_splitting.cpp | 29 --- 1 file changed, 13 insertions(+), 16 deletions(-) diff

Re: [Mesa-dev] Adding a SPIR-V back-end to the GLSL compiler

On 31/05/17 09:46, Jason Ekstrand wrote: On Tue, May 30, 2017 at 4:32 PM, Ian Romanick > wrote: On 05/26/2017 08:57 AM, Jason Ekstrand wrote: > This is something that I have considered doing on multiple occasions and > have given

Re: [Mesa-dev] Adding a SPIR-V back-end to the GLSL compiler

On Tue, May 30, 2017 at 4:32 PM, Ian Romanick wrote: > On 05/26/2017 08:57 AM, Jason Ekstrand wrote: > > This is something that I have considered doing on multiple occasions and > > have given a significant amount of thought. Unfortunately, it has never > > made it

Re: [Mesa-dev] [PATCH 3/4] util: use memcmp instead of strncmp

I believe this change is correct, but does it have any measurable benefit? Reduction in generated code size, perhaps? On 05/30/2017 03:45 PM, Vlad Golovkin wrote: > --- > src/util/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/debug.c

Re: [Mesa-dev] [PATCH 4/4] glx: use memcmp instead of strncmp

Same comment here as on patch 3. On 05/30/2017 03:45 PM, Vlad Golovkin wrote: > --- > src/glx/glxextensions.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glx/glxextensions.c b/src/glx/glxextensions.c > index 22b078ce48..c0640d0b73 100644 > ---

Re: [Mesa-dev] [PATCH 2/4] glsl: trivial change of the file extension matching

On 05/30/2017 03:45 PM, Vlad Golovkin wrote: > --- > src/compiler/glsl/standalone.cpp | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/src/compiler/glsl/standalone.cpp > b/src/compiler/glsl/standalone.cpp > index 52554bb92a..b9cee23642 100644 > ---

Re: [Mesa-dev] [PATCH 1/4] glsl: simplify +INF check

Ken: Is this code still used? On 05/30/2017 03:45 PM, Vlad Golovkin wrote: > --- > src/compiler/glsl/s_expression.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/s_expression.cpp > b/src/compiler/glsl/s_expression.cpp > index

Re: [Mesa-dev] [PATCH 4/5] gallium/u_blitter: use TXF if possible

Am 31.05.2017 um 00:46 schrieb Marek Olšák: > From: Marek Olšák > > This fixes piglit: > arb_texture_view-rendering-r32ui > > TEX (image_sample) flushes denorms to 0 with FP32 textures on GCN, but such > a texture can contain integer data written using an integer render

Re: [Mesa-dev] Adding a SPIR-V back-end to the GLSL compiler

On 05/26/2017 08:57 AM, Jason Ekstrand wrote: > This is something that I have considered doing on multiple occasions and > have given a significant amount of thought. Unfortunately, it has never > made it particularly high on my priority list so no code has been > written. However, there have

[Mesa-dev] [PATCH] i965: Set "Subslice Hashing Mode" to 16x16 on Apollolake.

As of 4.11, the kernel isn't bothering to set the subslice hashing mode on Apollolake, leaving it at the default of 8x8. (It initializes it to 16x4 on most platforms.) Performance data for GPUTest Triangle on Apollolake at 1024x640: X-tiled RT: --- 8x8 -> 16x4: 2.4325% +/-

Re: [Mesa-dev] [PATCH 4/5] gallium/u_blitter: use TXF if possible

On Wed, May 31, 2017 at 12:59 AM, Roland Scheidegger wrote: > Am 31.05.2017 um 00:46 schrieb Marek Olšák: >> From: Marek Olšák >> >> This fixes piglit: >> arb_texture_view-rendering-r32ui >> >> TEX (image_sample) flushes denorms to 0 with FP32

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #32 from Roland Scheidegger --- (In reply to Ben Crocker from comment #29) > Created attachment 131577 [details] [review] > Patch to lp_build_gather_elem_vec > > THIS is the attachment I meant to attach to

Re: [Mesa-dev] [PATCH] radv: Revert HTILE reset word to 0xFFFFFFFF.

Dyanamic lighting stops working in the benchmark. Not entirely root caused yet, I actually suspect this unhides a bug, in that 0x might have cleared something that 0x30f doesn't (If I completely disable the transition, which should be valid because we always have a decompressed HTILE

[Mesa-dev] [PATCH 1/5] gallium/ureg: add TEX/TXF_LZ opcodes to ureg

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h b/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h index 96ac480..d11d0e5 100644 ---

[Mesa-dev] [PATCH 5/5] gallium/u_blitter: use 2D_ARRAY for cubemap blits if possible

From: Marek Olšák so that we can use TXF. The cubemap blit pixel shader code size: 148 -> 92 bytes --- src/gallium/auxiliary/util/u_blitter.c | 52 ++ src/gallium/auxiliary/util/u_blitter.h | 3 +- src/gallium/drivers/r300/r300_blit.c |

[Mesa-dev] [PATCH 2/2] radeonsi: move PSIZE and CLIPDIST unique IO indices after GENERIC

From: Marek Olšák Heaven LDS usage for LS+HS is below. The masks are "outputs_written" for LS and HS. Note that 32K is the maximum size. Before: heaven_x64: ls=1f1 tcs=1f1, lds=32K heaven_x64: ls=31 tcs=31, lds=24K heaven_x64: ls=71 tcs=71, lds=28K After:

[Mesa-dev] [PATCH 3/5] gallium/u_blitter: use TEX_LZ if it's supported

From: Marek Olšák The sampler views always have first_level == last_level. Now radeonsi doesn't have to use the WQM. (a few SALU removed) --- src/gallium/auxiliary/util/u_blitter.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] gallium/util: add _LZ and TXF options to simple shaders

From: Marek Olšák --- src/gallium/auxiliary/util/u_blit.c | 2 +- src/gallium/auxiliary/util/u_blitter.c| 13 +++-- src/gallium/auxiliary/util/u_simple_shaders.c | 70 +++ src/gallium/auxiliary/util/u_simple_shaders.h | 20 ++--

[Mesa-dev] [PATCH 4/5] gallium/u_blitter: use TXF if possible

From: Marek Olšák This fixes piglit: arb_texture_view-rendering-r32ui TEX (image_sample) flushes denorms to 0 with FP32 textures on GCN, but such a texture can contain integer data written using an integer render view. If we do a transfer blit with TEX, denorms are

[Mesa-dev] [PATCH 1/2] radeonsi: fix a GPU hang with tessellation on 2-CU configs

From: Marek Olšák Only harvested Stoney has 2 CUs, but I couldn't test that and the bug reporter hasn't tested it on Stoney yet. However, I reproduced the hang on Fiji limited to 2 CUs per SE, which is how I was able to fix it. Cc: 17.0 17.1

[Mesa-dev] [PATCH 0/4] use memcmp instead of strncmp when string lengths are known

This series contains a couple of trivial changes, mostly places where the code looks like this: if (len1 == len2 && (strncmp(str1, str2, len1)) ... It is better to use memcmp here because there is no need to check for the terminating null byte Vlad Golovkin (4): glsl: simplify +INF check

[Mesa-dev] [PATCH 2/4] glsl: trivial change of the file extension matching

--- src/compiler/glsl/standalone.cpp | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/standalone.cpp b/src/compiler/glsl/standalone.cpp index 52554bb92a..b9cee23642 100644 --- a/src/compiler/glsl/standalone.cpp +++

[Mesa-dev] [PATCH 1/4] glsl: simplify +INF check

--- src/compiler/glsl/s_expression.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/s_expression.cpp b/src/compiler/glsl/s_expression.cpp index f82e155a6b..0e05c4bba7 100644 --- a/src/compiler/glsl/s_expression.cpp +++ b/src/compiler/glsl/s_expression.cpp

[Mesa-dev] [PATCH 4/4] glx: use memcmp instead of strncmp

--- src/glx/glxextensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/glxextensions.c b/src/glx/glxextensions.c index 22b078ce48..c0640d0b73 100644 --- a/src/glx/glxextensions.c +++ b/src/glx/glxextensions.c @@ -366,7 +366,7 @@ set_glx_extension(const struct

[Mesa-dev] [PATCH 3/4] util: use memcmp instead of strncmp

--- src/util/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/debug.c b/src/util/debug.c index 98b1853325..78041d414f 100644 --- a/src/util/debug.c +++ b/src/util/debug.c @@ -42,7 +42,7 @@ parse_debug_string(const char *debug, for (; n =

Re: [Mesa-dev] [PATCH 2/5] genxml: Fix decoder for groups with multiple fields.

Patches 2-4 are : Acked-by: Lionel Landwerlin On 20/05/17 08:24, Kenneth Graunke wrote: If you have something like: We would reset ctx->group_count to 0 after processing the first field, so the second would not have a group count.

Re: [Mesa-dev] [PATCH 5/5] genxml: Make 3DSTATE_CONSTANT_BODY on Gen7+ use arrays.

With Jason's comment addressed : Reviewed-by: Lionel Landwerlin On 20/05/17 08:24, Kenneth Graunke wrote: This will let us initialize the constant buffers with loops. --- src/intel/genxml/gen7.xml | 14 ++

Re: [Mesa-dev] [PATCH] radv: Revert HTILE reset word to 0xFFFFFFFF.

How did it regress it? Marek On Tue, May 30, 2017 at 11:06 PM, Bas Nieuwenhuizen wrote: > 0x30f regressed mad max. > > Signed-off-by: Bas Nieuwenhuizen > Fixes: df91abfe5af "radv: Use correct clear words for HTILE." > --- >

Re: [Mesa-dev] [PATCH 3/3] radeonsi: remove unused si_pm4_state::compute_pkt

For the series: Reviewed-by: Marek Olšák Marek On Tue, May 30, 2017 at 6:53 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_pm4.c | 3 +-- >

Re: [Mesa-dev] [PATCH 1/5] genxml: Fix parsing of address fields in groups.

Reviewed-by: Lionel Landwerlin On 20/05/17 08:24, Kenneth Graunke wrote: For example, used to generate: const uint64_t v2_address = __gen_combine_address(data, [2], values->Pointer, 0); ... const uint64_t v4_address =

Re: [Mesa-dev] [PATCH 1/2] intel: gen-decoder: rework how we handle groups

On 30/05/17 22:39, Rafael Antognolli wrote: On Tue, May 30, 2017 at 08:59:06PM +0100, Lionel Landwerlin wrote: The current way of handling groups doesn't seem to be able to handle MI_LOAD_REGISTER_* with more than one register. Hi Lionel, I don't think this is entirely true. I have added

Re: [Mesa-dev] [PATCH 2/2] st/dri: Use fence extension in drisw.c

For the series: Reviewed-by: Marek Olšák Marek On Tue, May 23, 2017 at 2:34 AM, Gurchetan Singh wrote: > This is desirable for synchronization in virtual machines. > --- > src/gallium/state_trackers/dri/drisw.c | 2 ++ > 1 file changed, 2

Re: [Mesa-dev] [PATCH 1/2] intel: gen-decoder: rework how we handle groups

On Tuesday, May 30, 2017 2:39:42 PM PDT Rafael Antognolli wrote: > On Tue, May 30, 2017 at 08:59:06PM +0100, Lionel Landwerlin wrote: > > The current way of handling groups doesn't seem to be able to handle > > MI_LOAD_REGISTER_* with more than one register. Somewhat related, I fixed a bunch of

Re: [Mesa-dev] [PATCH] configure.ac: Require amdgpu for r600.

Emil had a solution to this, but it still seems to be under discussion. I think the plan is not to require amdgpu for r600. Marek On Tue, May 30, 2017 at 11:14 PM, Vinson Lee wrote: > This is the r600 build error with libdrm < 2.4.81. > > CC

[Mesa-dev] [PATCH 6/6] i965: Convert upload_default_color to genxml.

This function was moved to genX_state_upload.c but was still not using genxml. By converting it to genxml, we make some things simpler, like setting haswell's border color state, but others are more complex, since the structs used by each gen are different. Signed-off-by: Rafael Antognolli

[Mesa-dev] [PATCH 2/6] genxml: fix gen5 sampler border color state.

Based on the current code, gen5 and gen6 have the same sampler border color state struct. So fix the gen5 one to match gen6. Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen5.xml | 40 1 file changed, 20

[Mesa-dev] [PATCH 4/6] i965: Convert vs, gs, tcs, tes and cs samplers to genxml.

Since they just use the code that is already available in genX_state_upload.c, convert them in one batch. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 109 - src/mesa/drivers/dri/i965/brw_state.h |

[Mesa-dev] [PATCH 5/6] i965: Remove unused code and delete file.

The sampler state code was all moved to genxml, so we can get rid of these functions and delete the file. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_sampler_state.c | 623

[Mesa-dev] [PATCH 3/6] i965: Convert fs sampler state to use genxml.

Also convert some auxiliary functions used by it, and copy upload_default_color to genX_state_upload.c. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 18 - src/mesa/drivers/dri/i965/brw_state.h | 1 -

[Mesa-dev] [PATCH 1/6] aubinator: Dump sampler state pointers on gen6 too.

We already have a function to dump sampler states, so do that for gen6 too. Signed-off-by: Rafael Antognolli --- src/intel/tools/aubinator.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c

Re: [Mesa-dev] [PATCH 1/2] intel: gen-decoder: rework how we handle groups

On Tue, May 30, 2017 at 08:59:06PM +0100, Lionel Landwerlin wrote: > The current way of handling groups doesn't seem to be able to handle > MI_LOAD_REGISTER_* with more than one register. Hi Lionel, I don't think this is entirely true. I have added support to read variable length structs on

Re: [Mesa-dev] [PATCH 01/13] gallium/dri: always link against shared glapi

On Fri, 2017-04-28 at 14:14 +0100, Emil Velikov wrote: > From: Emil Velikov > > In the early days of Xorg and Mesa we had multiple providers of the > GLAPI. All of those were the ones responsible for dlopening the DRI > module. Hence it was perfectly fine, and

[Mesa-dev] [PATCH] configure.ac: Require amdgpu for r600.

This is the r600 build error with libdrm < 2.4.81. CC common/common_libamd_common_la-ac_gpu_info.lo common/ac_gpu_info.c: In function ‘ac_query_gpu_info’: common/ac_gpu_info.c:161:36: error: ‘AMDGPU_HW_IP_VCN_DEC’ undeclared (first use in this function) r =

Re: [Mesa-dev] [PATCH 4/5] radv: Use correct clear words for HTILE.

Yeah, I got your message on IRC and found this one too. Looking at things I suspect it is correct and just unhides a bug somewhere else though, so I was a bit reluctant to roll back. However, since I'm probably not able to fix this before the weekend, I just send a change that reverts the

[Mesa-dev] [PATCH] radv: Revert HTILE reset word to 0xFFFFFFFF.

0x30f regressed mad max. Signed-off-by: Bas Nieuwenhuizen Fixes: df91abfe5af "radv: Use correct clear words for HTILE." --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 4/4] mesa/main: drop needless condition check in _mesa_GetPerfCounterInfoINTEL

Fixes the following warning: external/mesa3d/src/mesa/main/performance_query.c:352:21: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (counterIndex < 0 || counterIndex >= queryNumCounters) { ^ ~ counterIndex will be ~0 if

[Mesa-dev] [PATCH 3/4] mesa/main: fix gl_buffer_index enum comparison

For clang, enums are unsigned by default and gives the following warning: external/mesa3d/src/mesa/main/buffers.c:764:21: warning: comparison of constant -1 with expression of type 'gl_buffer_index' is always false [-Wtautological-constant-out-of-range-compare] if (srcBuffer == -1) {

[Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

clang gives warnings about overloaded virtual functions: src/compiler/glsl/linker.cpp:244:30: warning: '(anonymous namespace)::array_resize_visitor::visit' hides overloaded virtual function [-Woverloaded-virtual] virtual ir_visitor_status visit(ir_variable *var)

[Mesa-dev] [PATCH 2/4] glsl: make ast_node destructor virtual

Make ast_node destructor virtual to fix the following clang warning: src/compiler/glsl/ast.h:51:4: warning: destructor called on non-final 'ast_node' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] Signed-off-by: Rob Herring ---

[Mesa-dev] [PATCH v2 41/64] st/mesa: add st_convert_image_from_unit() helper

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_atom_image.c | 33 ++--- src/mesa/state_tracker/st_texture.h| 5 + 2

[Mesa-dev] [PATCH v2 49/64] radeonsi: add si_set_shader_image_desc() helper

To share some common code between bound and bindless images. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 78 --- 1 file changed, 46 insertions(+), 32 deletions(-) diff --git

[Mesa-dev] [PATCH v2 59/64] radeonsi: only decompress resident textures/images when used

When the current bound shaders don't use any bindless textures or images, it's useless to decompress the resident resources. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH v2 63/64] radeonsi: add support for loading bindless images

v2: - removed use of the Bindless flags after rebasing - make use of tgsi_is_bindless_image_file() Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 28 +-- 1 file changed, 21 insertions(+), 7 deletions(-)

[Mesa-dev] [PATCH v2 25/64] gallium: add PIPE_CAP_BINDLESS_TEXTURE

Whether bindless texture operations are supported by the underlying driver. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1

[Mesa-dev] [PATCH v2 27/64] gallium/util: add new util_dynarray_{shrink, delete} helpers

These helpers will be used for handling dynamic arrays of resident texture/image handles. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/util/u_dynarray.h | 20 1 file changed, 20 insertions(+) diff --git

[Mesa-dev] [PATCH v2 57/64] radeonsi: isolate real framebuffer changes from the decompression passes

When a stencil buffer is part of the framebuffer state, it is decompressed but because it's bindles, all draw calls set stencil_dirty_level_mask to 1. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c | 8

[Mesa-dev] [PATCH v2 38/64] st/mesa: implement ARB_bindless_texture

v2: - remove "texture" parameter from create_texture_handle() Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) Reviewed-by: Marek Olšák (v1) --- src/mesa/state_tracker/st_cb_texture.c | 84

[Mesa-dev] [PATCH v2 48/64] radeonsi: add si_set_sampler_view_desc() helper

To share some common code between bound and bindless textures. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 95 +++ 1 file changed, 52 insertions(+), 43 deletions(-) diff --git

  1   2   3   >