Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Tomasz Figa
Hi Yogesh, On Wed, Jul 12, 2017 at 2:18 AM, Marathe, Yogesh wrote: >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Tomasz Figa >> Sent: Tuesday, July 11, 2017 9:59 PM >> To: Marathe, Yogesh

Re: [Mesa-dev] [PATCH] anv: Round u_vector element sizes to a power of two

2017-07-11 Thread Jason Ekstrand
On Tue, Jul 11, 2017 at 8:18 PM, Kenneth Graunke wrote: > On Tuesday, July 11, 2017 7:09:32 PM PDT Jason Ekstrand wrote: > > This fixes 32-bit builds of the driver. > > > > Fixes: 08413a81b93dc537fb0c34327ad162f07e8c3427 > > Cc: Mark Janes > > Cc:

Re: [Mesa-dev] [PATCH] anv: Round u_vector element sizes to a power of two

2017-07-11 Thread Kenneth Graunke
On Tuesday, July 11, 2017 7:09:32 PM PDT Jason Ekstrand wrote: > This fixes 32-bit builds of the driver. > > Fixes: 08413a81b93dc537fb0c34327ad162f07e8c3427 > Cc: Mark Janes > Cc: mesa-sta...@lists.freedesktop.org > --- > src/intel/vulkan/anv_batch_chain.c | 15

Re: [Mesa-dev] [PATCH] anv: Round u_vector element sizes to a power of two

2017-07-11 Thread Jason Ekstrand
On Tue, Jul 11, 2017 at 7:09 PM, Jason Ekstrand wrote: > This fixes 32-bit builds of the driver. > I just updated the commit message to be more descriptive: This fixes 32-bit builds of the driver. Commit 08413a81b93dc537fb0c3 changed things so that we now put

Re: [Mesa-dev] [PATCH 08/19] mesa/st: implement memory objects as a backend for texture storage

2017-07-11 Thread Andres Rodriguez
On 2017-07-11 02:31 PM, Marek Olšák wrote: On Sat, Jul 1, 2017 at 1:03 AM, Andres Rodriguez wrote: From: Dave Airlie Instead of allocating memory to back a texture, use the provided memory object. Signed-off-by: Andres Rodriguez

[Mesa-dev] [PATCH] anv: Round u_vector element sizes to a power of two

2017-07-11 Thread Jason Ekstrand
This fixes 32-bit builds of the driver. Fixes: 08413a81b93dc537fb0c34327ad162f07e8c3427 Cc: Mark Janes Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_batch_chain.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] freedreno/ir3: fix load_front_face conversion

2017-07-11 Thread Ilia Mirkin
The comments are correct - we get -1 and 0. However by adding 1, we convert this into 0,1. This mostly works for conditionals, but when negated, this will yield the wrong result. Instead just negate the values (as they are backwards -- -1 means back instead of front). Fixes

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-11 Thread Connor Abbott
On Tue, Jul 11, 2017 at 6:02 PM, Matt Turner wrote: > On Mon, Jul 10, 2017 at 4:05 PM, Connor Abbott wrote: >> On Mon, Jul 10, 2017 at 3:50 PM, Matt Turner wrote: >>> On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott

[Mesa-dev] [PATCH 3/3] swr: Add path to draw directly from client memory without copy.

2017-07-11 Thread Bruce Cherniak
If size of client memory copy is too large, don't copy. The draw will access user-buffer directly and then block. This is faster and more efficient than queuing many large client draws. Applications that use large draws from client arrays benefit from this. VMD is an example. The threshold for

[Mesa-dev] [PATCH 0/3] swr: Optimize large draws from client arrays.

2017-07-11 Thread Bruce Cherniak
If size of client memory copy is too large, don't copy. The draw will access user-buffer directly and then block. This is faster and more efficient than queuing many large client draws. Applications that use large draws from client arrays benefit from this. VMD is an example. The threshold for

[Mesa-dev] [PATCH 2/3] swr: Move environment config options into separate function.

2017-07-11 Thread Bruce Cherniak
Moved reading of environment config options out of swr_create_screen_internal, into a separate swr_validate_env_options. This is to keep from cluttering create_screen. --- src/gallium/drivers/swr/swr_screen.cpp | 60 +++--- 1 file changed, 34 insertions(+), 26

[Mesa-dev] [PATCH 1/3] swr: Remove hard-coded constant and "todo" comment.

2017-07-11 Thread Bruce Cherniak
Removed the hard-coded constant in favor of a #define. Also removed TODO comment, the constant value doesn't need an environment configurable option. --- src/gallium/drivers/swr/swr_scratch.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 09/20] nir: Add system values from ARB_shader_ballot

2017-07-11 Thread Matt Turner
On Mon, Jul 10, 2017 at 4:05 PM, Connor Abbott wrote: > On Mon, Jul 10, 2017 at 3:50 PM, Matt Turner wrote: >> On Mon, Jul 10, 2017 at 1:10 PM, Connor Abbott wrote: >>> On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Wu, Zhongmin
Thanks very much for Emil and Tomasz's suggestions. We can see that the out fence needed in queue buffer is get from batch buffer flushing. Now we may flush bath buffer at below places: 1. Create sync ===> flush buffer and get out fence from driver 2.Do glFLush() >flush

Re: [Mesa-dev] [PATCH v3 16/16] anv: Predicate fast-clear resolves

2017-07-11 Thread Jason Ekstrand
On Tue, Jul 11, 2017 at 3:34 PM, Nanley Chery wrote: > On Mon, Jul 10, 2017 at 04:00:23PM -0700, Jason Ekstrand wrote: > > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery > wrote: > > > > > Image layouts only let us know that an image *may* be

Re: [Mesa-dev] [PATCH v3 11/16] anv/cmd_buffer: Move aux_usage assignment up

2017-07-11 Thread Jason Ekstrand
On Tue, Jul 11, 2017 at 4:31 PM, Nanley Chery wrote: > On Mon, Jul 10, 2017 at 02:36:16PM -0700, Jason Ekstrand wrote: > > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery > wrote: > > > > > For readability, bring the assignment of CCS closer to the

[Mesa-dev] [PATCH 08/11] anv/image: Use vk_zalloc instead of an explicit memset

2017-07-11 Thread Jason Ekstrand
--- src/intel/vulkan/anv_image.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index fe5544e..7c4655d 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c @@ -264,12 +264,11 @@

[Mesa-dev] [PATCH 11/11] anv: Add a new anv_surface_state struct

2017-07-11 Thread Jason Ekstrand
This struct represents a full surface state including the addresses of the referenced main and auxiliary surfaces (if any). This makes relocation setup substantially simpler and allows us to move 100% of the surface state setup logic into anv_image where it belongs. Before, we were manually

[Mesa-dev] [PATCH 09/11] anv/image: zalloc image views

2017-07-11 Thread Jason Ekstrand
This allows us to avoid some extra zeroing. --- src/intel/vulkan/anv_image.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 7c4655d..af50ebd 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH 04/11] anv/image: Add INPUT_ATTACHMENT to the list of required usages

2017-07-11 Thread Jason Ekstrand
From the Vulkan 1.0.53 spec VU for vkCreateImageView: "image must have been created with a usage value containing at least one of VK_IMAGE_USAGE_SAMPLED_BIT, VK_IMAGE_USAGE_STORAGE_BIT, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, or

[Mesa-dev] [PATCH 10/11] anv/image: Break surface state fill logic into a helper

2017-07-11 Thread Jason Ekstrand
This gives us a single centralized place where we take an image view and use it to fill out a surface state. --- src/intel/vulkan/anv_image.c | 171 + src/intel/vulkan/anv_private.h | 14 +++ src/intel/vulkan/genX_cmd_buffer.c | 37 +++- 3 files

[Mesa-dev] [PATCH 03/11] anv/cmd_buffer: Properly handle render passes with 0 attachments

2017-07-11 Thread Jason Ekstrand
We were early returning and never created the NULL surface state. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/genX_cmd_buffer.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH 02/11] anv: Get rid of some unused function declarations

2017-07-11 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 4dce360..3e7f9c7 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -2226,13 +2226,6 @@ void

[Mesa-dev] [PATCH 07/11] anv: Separate surface states by layout instead of aux_usage

2017-07-11 Thread Jason Ekstrand
--- src/intel/vulkan/anv_descriptor_set.c | 5 +--- src/intel/vulkan/anv_image.c | 56 --- src/intel/vulkan/anv_private.h| 21 ++--- src/intel/vulkan/genX_cmd_buffer.c| 29 -- 4 files changed, 58 insertions(+), 53

[Mesa-dev] [PATCH 06/11] intel/isl: Add some sanity checks for compressed surfaces

2017-07-11 Thread Jason Ekstrand
--- src/intel/isl/isl_surface_state.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index 1620c93..e8bdb65 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@

[Mesa-dev] [PATCH 05/11] intel/isl: Add a helper to get a subimage surface

2017-07-11 Thread Jason Ekstrand
--- src/intel/blorp/blorp_blit.c | 38 +- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 23 +++ 3 files changed, 71 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH 01/11] anv: Stop leaking the no_aux sampler surface state

2017-07-11 Thread Jason Ekstrand
Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_image.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index c84fc8d..a4cf6f8 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c @@ -776,6

[Mesa-dev] [PATCH 00/11] anv: A few refactors and fixes

2017-07-11 Thread Jason Ekstrand
I started working on another up-and-coming Vulkan feature today and, as is frequently the case, found a bunch of bugs along the way. This tiny little series fixes some bugs, does a few cleanups, and does most of the needed refactoring for said feature. The last two patches are the important

Re: [Mesa-dev] [PATCH v3 11/16] anv/cmd_buffer: Move aux_usage assignment up

2017-07-11 Thread Nanley Chery
On Mon, Jul 10, 2017 at 02:36:16PM -0700, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > > > For readability, bring the assignment of CCS closer to the assignment of > > NONE and MCS. > > > > Signed-off-by: Nanley Chery

Re: [Mesa-dev] [PATCH 1/6] radeonsi: declare new user SGPR indices for bindless samplers/images

2017-07-11 Thread Marek Olšák
On Tue, Jul 4, 2017 at 3:05 PM, Samuel Pitoiset wrote: > A new pair of user SGPR is needed for loading the bindless > descriptors from shaders. Because the descriptors are global for > all stages, there is no need to add separate indices for GFX9. > > Signed-off-by:

Re: [Mesa-dev] [PATCH] gallium/util: remove unused util_{begin, end}_pipestat_query() helpers

2017-07-11 Thread Marek Olšák
I'd like to keep these for debugging. Marek On Thu, Jul 6, 2017 at 6:43 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/util/u_helpers.c | 50 > -- >

Re: [Mesa-dev] [PATCH] ddebug: fix parsing of the pipelined mode

2017-07-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jul 7, 2017 at 9:52 AM, Samuel Pitoiset wrote: > Trivial. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/ddebug/dd_screen.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH v3 16/16] anv: Predicate fast-clear resolves

2017-07-11 Thread Nanley Chery
On Mon, Jul 10, 2017 at 04:00:23PM -0700, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote: > > > Image layouts only let us know that an image *may* be fast-cleared. For > > this reason we can end up with redundant resolves. Testing has shown > >

Re: [Mesa-dev] [PATCH] radeonsi: enable support for EXT_memory_object v2

2017-07-11 Thread Marek Olšák
On Fri, Jul 7, 2017 at 6:34 AM, Andres Rodriguez wrote: > v2: fix an indentation error > > Signed-off-by: Andres Rodriguez > --- > src/gallium/drivers/r600/r600_pipe.c | 2 +- > src/gallium/drivers/radeonsi/si_pipe.c | 2 +- > 2 files changed, 2

Re: [Mesa-dev] [PATCH] Initial support for EXT_external_objects v2

2017-07-11 Thread Marek Olšák
ac, radeonsi, and gallium patches look OK to me except where I commented. Marek On Fri, Jul 7, 2017 at 6:24 AM, Andres Rodriguez wrote: > This series is an initial step towards the implementation of > EXT_external_objects. It implements the functionality under >

Re: [Mesa-dev] [PATCH 17/25] mesa: hook up UUID queries for driver and device v2

2017-07-11 Thread Marek Olšák
On Fri, Jul 7, 2017 at 6:24 AM, Andres Rodriguez wrote: > v2: respective changes for new gallium interface > > Signed-off-by: Andres Rodriguez > --- > src/mesa/main/dd.h | 15 +++ > src/mesa/main/get.c | 17

[Mesa-dev] [PATCH 2/4] dri: Add KHR_no_error DRI extension

2017-07-11 Thread Grigori Goronzy
This basic extension allows usage of the __DRI_CTX_FLAG_NO_ERROR flag. This includes support code for classic Mesa drivers to switch on the no-error mode if the flag is set. --- include/GL/internal/dri_interface.h | 19 +++ src/gallium/state_trackers/dri/dri2.c|

[Mesa-dev] [PATCH 1/4] egl: Add EGL_KHR_create_context_no_error support

2017-07-11 Thread Grigori Goronzy
This only adds the EGL side, needs to be plumbed into Mesa frontend. --- src/egl/drivers/dri2/egl_dri2.c | 20 ++-- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 1 + src/egl/main/eglcontext.c | 30 ++

[Mesa-dev] KHR_no_error improvements

2017-07-11 Thread Grigori Goronzy
Hi, this series implements support for the EGL_KHR_context_create_no error extension and the associated plumbing through the different layers of Mesa - EGL, DRI, Gallium state tracker, Mesa frontend. It took me a while to figure out how everything is connected together and still it's somewhat

[Mesa-dev] [PATCH 3/4] st/mesa: add support for KHR_no_error flag

2017-07-11 Thread Grigori Goronzy
Add a new context flag and plumb it through the various layers of the context creation code to set up dispatch tables for the no-error mode. --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_context.c | 3 +++ src/mesa/state_tracker/st_context.c

[Mesa-dev] [PATCH 4/4] dri: Add KHR_no_error toggle to driconf

2017-07-11 Thread Grigori Goronzy
Allows applications to be whitelisted. --- src/gallium/state_trackers/dri/dri_context.c| 3 +++ src/gallium/state_trackers/dri/dri_screen.c | 1 + src/mesa/drivers/dri/common/dri_util.c | 3 +++ src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 + 4 files changed, 12

Re: [Mesa-dev] [PATCH 16/25] gallium: introduce device/driver UUID queries

2017-07-11 Thread Marek Olšák
On Fri, Jul 7, 2017 at 6:24 AM, Andres Rodriguez wrote: > Signed-off-by: Andres Rodriguez > --- > src/gallium/drivers/ddebug/dd_screen.c | 17 + > src/gallium/include/pipe/p_defines.h | 1 + > src/gallium/include/pipe/p_screen.h| 13

Re: [Mesa-dev] [PATCH 09/25] radeonsi: add basic memory object support

2017-07-11 Thread Marek Olšák
On Fri, Jul 7, 2017 at 6:24 AM, Andres Rodriguez wrote: > From: Dave Airlie > > Signed-off-by: Andres Rodriguez > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++ > src/gallium/drivers/radeon/r600_texture.c | 112 >

Re: [Mesa-dev] [PATCH] st/mesa: add a winsys buffers list in st_context

2017-07-11 Thread Brian Paul
On 07/11/2017 11:15 AM, Charmaine Lee wrote: Commit a5e733c6b52e93de3000647d075f5ca2f55fcb71 fixes the dangling framebuffer object by unreferencing the window system draw/read buffers when context is released. However this can prematurely destroy the resources associated with these window system

Re: [Mesa-dev] [PATCH] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

2017-07-11 Thread Bas Nieuwenhuizen
On Fri, Jun 30, 2017 at 12:18 PM, Alex Smith wrote: > If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image > view's descriptor was set to a 2D array (and a few other fields adjusted > accordingly). This is correct when the image view is actually

[Mesa-dev] [PATCH] i965: Fix up a failed CPU/WC mmaping with a GTT mapping

2017-07-11 Thread Chris Wilson
Not all objects will be mappable for direct access by the CPU (either using WC/CPU or WC paths), for example, a dmabuf wrapping an object on a foreign device or an object wrapping access to stolen memory. Since either the physical pages are not known or even do not exist, we need to use the

Re: [Mesa-dev] [PATCH] svga: fix texture swizzle writemasking

2017-07-11 Thread Charmaine Lee
Looks good. Thanks for the quick fix. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, July 11, 2017 2:02 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga:

Re: [Mesa-dev] [PATCH] i965: Use VALGRIND_MAKE_MEM_x in place of MALLOCLIKE/FREELIKE

2017-07-11 Thread Kenneth Graunke
On Tuesday, July 11, 2017 8:54:25 AM PDT Chris Wilson wrote: > Valgrind doesn't actually implement VALGRIND_FREELIKE_BLOCK as the > exact inverse of VALGRIND_MALLOCLIKE_BLOCK. It makes the block > inaccessible, but still leaves it defined in its allocation tracker i.e. > it will report the mmap as

[Mesa-dev] [PATCH] svga: fix texture swizzle writemasking

2017-07-11 Thread Brian Paul
Commit bfe1e7737a76e3b046 changed how texture swizzles are set up. This exposed a latent bug in the VMware driver: we were ignoring the texture instruction's writemask when applying the 0 and 1 swizzle terms. This wasn't caught by the Piglit texture swizzle test because it only exercises fixed

[Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-11 Thread Rob Herring
From: Marek Olšák Add support for 32-bit RGBX/RGBA formats which are required for Android. The original patch (commit ccdcf91104a5) was reverted (commit c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based on further investigation by Chad Versace, moving

Re: [Mesa-dev] [PATCH 08/19] mesa/st: implement memory objects as a backend for texture storage

2017-07-11 Thread Marek Olšák
On Sat, Jul 1, 2017 at 1:03 AM, Andres Rodriguez wrote: > From: Dave Airlie > > Instead of allocating memory to back a texture, use the provided memory > object. > > Signed-off-by: Andres Rodriguez > --- > src/mesa/main/mtypes.h

Re: [Mesa-dev] [PATCH 08/19] mesa/st: implement memory objects as a backend for texture storage

2017-07-11 Thread Marek Olšák
On Sat, Jul 1, 2017 at 1:03 AM, Andres Rodriguez wrote: > From: Dave Airlie > > Instead of allocating memory to back a texture, use the provided memory > object. > > Signed-off-by: Andres Rodriguez > --- > src/mesa/main/mtypes.h

[Mesa-dev] OSdemo32 GLU undefined reference errors..

2017-07-11 Thread Trevor Sandy
I'm having some difficulty linking OSdemo32 [Mesa Demo] on MSYS2/MinGW. Basically, some functions are not included in libGLU.a as the error returned is undefined reference to __imp_glu... It's strange because these functions exist in the libGLU source and I am building and using a static libGLU

Re: [Mesa-dev] [PATCH v6 0/6] mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-07-11 Thread Gert Wollny
Hi all, I just wanted to send a ping to ask whether there might be a chance to get this into the next stable release? I also noted today that this update register merge algorithm fixed The Witcher 2 for me on r600g (BARTS) many thanks, Gert Am Dienstag, den 04.07.2017, 16:18 +0200 schrieb

Re: [Mesa-dev] [PATCH] swr/rast: make SWR_VISIBLE attribute work for windows

2017-07-11 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jul 11, 2017, at 9:52 AM, Tim Rowley wrote: > > From: George Kyriazis > > Needed to expose SwrGetInterface > --- > src/gallium/drivers/swr/rasterizer/common/os.h | 2 +- > 1 file

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Emil Velikov
On 11 July 2017 at 16:23, Tomasz Figa wrote: > Hi Zhongmin, > > On Tue, Jul 11, 2017 at 11:02 AM, Wu, Zhongmin wrote: >> By the way, >> >> For cancelBuffer, sorry I forget such function, thanks for notice. It should >> also pass the same fence fd as

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Marathe, Yogesh
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tomasz Figa > Sent: Tuesday, July 11, 2017 9:59 PM > To: Marathe, Yogesh > Cc: Gao, Shuo ; Liu, Zhiquan ; > Kondapally,

[Mesa-dev] [PATCH] st/mesa: add a winsys buffers list in st_context

2017-07-11 Thread Charmaine Lee
Commit a5e733c6b52e93de3000647d075f5ca2f55fcb71 fixes the dangling framebuffer object by unreferencing the window system draw/read buffers when context is released. However this can prematurely destroy the resources associated with these window system buffers. The problem is reproducible with

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

2017-07-11 Thread Rob Herring
On Tue, Jul 11, 2017 at 9:34 AM, Tomasz Figa wrote: > On Tue, Jul 11, 2017 at 11:16 PM, Rob Herring wrote: >> On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> As

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Tomasz Figa
Hi Yogesh, On Wed, Jul 12, 2017 at 1:09 AM, Marathe, Yogesh wrote: > Hello Figa, Few caveats on that approach (I'm Tomasz, by the way) > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Tomasz Figa >>

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Marathe, Yogesh
Hello Figa, Few caveats on that approach > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tomasz Figa > Sent: Tuesday, July 11, 2017 8:58 PM > To: Wu, Zhongmin > Cc: Gao, Shuo ; Liu, Zhiquan

[Mesa-dev] [PATCH] i965: Use VALGRIND_MAKE_MEM_x in place of MALLOCLIKE/FREELIKE

2017-07-11 Thread Chris Wilson
Valgrind doesn't actually implement VALGRIND_FREELIKE_BLOCK as the exact inverse of VALGRIND_MALLOCLIKE_BLOCK. It makes the block inaccessible, but still leaves it defined in its allocation tracker i.e. it will report the mmap as lost despite the call to FREELIKE! Instead of treating the mmap as

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Tomasz Figa
-chuanbo.w...@intel.com (bounces) +"Gao, Shuo" (forgot to add originally, sorry) On Wed, Jul 12, 2017 at 12:23 AM, Tomasz Figa wrote: > Hi Zhongmin, > > On Tue, Jul 11, 2017 at 11:02 AM, Wu, Zhongmin wrote: >> By the way, >> >> For

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Tomasz Figa
Now for real, sorry guys... (Seriously gmail why you do this to me.) -chuanbo.w...@intel.com (bounces) +"Gao, Shuo" (forgot to add originally, sorry) On Wed, Jul 12, 2017 at 12:23 AM, Tomasz Figa wrote: > Hi Zhongmin, > > On Tue, Jul 11, 2017 at 11:02

Re: [Mesa-dev] [PATCH 07/10] util/u_queue: add an option to resize the queue when it's full

2017-07-11 Thread Marek Olšák
On Tue, Jul 11, 2017 at 12:05 PM, Grazvydas Ignotas wrote: > On Tue, Jul 11, 2017 at 12:21 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> Consider the following situation: >> mtx_lock(mutex); >> do_something(); >>

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-11 Thread Tomasz Figa
Hi Zhongmin, On Tue, Jul 11, 2017 at 11:02 AM, Wu, Zhongmin wrote: > By the way, > > For cancelBuffer, sorry I forget such function, thanks for notice. It should > also pass the same fence fd as the queuebuffer. > > And Yogesh, you mentioned the gallium, is it another

Re: [Mesa-dev] [PATCH] anv: Stop leaking the no_aux sampler surface state

2017-07-11 Thread Lionel Landwerlin
Well spotted! Reviewed-by: Lionel Landwerlin On 11/07/17 16:14, Jason Ekstrand wrote: Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_image.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH] anv: Stop leaking the no_aux sampler surface state

2017-07-11 Thread Jason Ekstrand
Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_image.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 76ab923..9992685 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_image.c @@ -775,6

Re: [Mesa-dev] [PATCH v2 2/2] swr: build driver proper separate from rasterizer

2017-07-11 Thread Emil Velikov
On 11 July 2017 at 03:09, Tim Rowley wrote: > swr used to build and link the rasterizer to the driver, and to support > multiple architectures we needed to have multiple versions of the > driver/rasterizer combination, which needed to link in much of mesa. > > Changing

[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

2017-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101709 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net

[Mesa-dev] [PATCH] swr/rast: make SWR_VISIBLE attribute work for windows

2017-07-11 Thread Tim Rowley
From: George Kyriazis Needed to expose SwrGetInterface --- src/gallium/drivers/swr/rasterizer/common/os.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

2017-07-11 Thread Emil Velikov
On 11 July 2017 at 15:16, Rob Herring wrote: > On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> As said in the EGL_KHR_platform_android extensions >> >> For each EGLConfig that belongs

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

2017-07-11 Thread Tomasz Figa
On Tue, Jul 11, 2017 at 11:16 PM, Rob Herring wrote: > On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> As said in the EGL_KHR_platform_android extensions >> >> For each EGLConfig that

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

2017-07-11 Thread Rob Herring
On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov wrote: > From: Emil Velikov > > As said in the EGL_KHR_platform_android extensions > > For each EGLConfig that belongs to the Android platform, the > EGL_NATIVE_VISUAL_ID attribute is an

Re: [Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

2017-07-11 Thread Emil Velikov
On 10 July 2017 at 22:26, Louis-Francis Ratté-Boulianne wrote: > Hi, > > On Tue, 2017-06-20 at 15:19 +0100, Emil Velikov wrote: >> > +for (i = 0; i < count; i++) { >> > + modifiers[i] = (uint64_t) mod_parts[i * 2] << 32; >> > +

Re: [Mesa-dev] [PATCH] radv: set cb base tile swizzles for MRT speedups (v3)

2017-07-11 Thread Alex Smith
On 11 July 2017 at 14:27, Alex Smith wrote: > On 10 July 2017 at 05:59, Dave Airlie wrote: > >> From: Dave Airlie >> >> This patch uses addrlib to workout the tile swizzles according >> to the surface index. It seems to

[Mesa-dev] [PATCH 2/2] egl/drm: set the VISUAL_TYPE alongside the VISUAL_ID

2017-07-11 Thread Emil Velikov
From: Emil Velikov According to the EGL_KHR_platform_gbm extension: For each EGLConfig that belongs to the GBM platform, the EGL_NATIVE_VISUAL_ID attribute is a GBM color format, such as GBM_FORMAT_XRGB. Which we correctly manage. At the same time

[Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

2017-07-11 Thread Emil Velikov
From: Emil Velikov As said in the EGL_KHR_platform_android extensions For each EGLConfig that belongs to the Android platform, the EGL_NATIVE_VISUAL_ID attribute is an Android window format, such as WINDOW_FORMAT_RGBA_. Although it should be

Re: [Mesa-dev] [PATCH] radv: set cb base tile swizzles for MRT speedups (v3)

2017-07-11 Thread Alex Smith
On 10 July 2017 at 05:59, Dave Airlie wrote: > From: Dave Airlie > > This patch uses addrlib to workout the tile swizzles according > to the surface index. It seems to produce the same values as > amdgpu-pro for the deferred test. > > v2: don't apply

Re: [Mesa-dev] [PATCH] etnaviv: Use the correct LOG instruction on GC3000

2017-07-11 Thread Lucas Stach
Am Dienstag, den 11.07.2017, 15:07 +0200 schrieb Wladimir J. van der Laan: > GC3000 has a new LOG instruction, similar to the new SIN and COS instructions. > > Generate the new instruction sequence when appropriate; there are > two occasions, as part of LIT and the generator for the LG2 >

Re: [Mesa-dev] XCOM: Enemy Unknown vs. NaN texture unit LOD bias

2017-07-11 Thread Roland Scheidegger
Am 11.07.2017 um 08:25 schrieb Kenneth Graunke: > Hello, > > Mesa master has been hitting assert failures when running "XCOM: Enemy > Unknown" since commit f8d69beed49c64f883bb8ffb28d4960306baf575, where we > started asserting that the SAMPLER_STATE LOD Bias value actually fits in > the correct

[Mesa-dev] [PATCH] etnaviv: Use the correct LOG instruction on GC3000

2017-07-11 Thread Wladimir J. van der Laan
GC3000 has a new LOG instruction, similar to the new SIN and COS instructions. Generate the new instruction sequence when appropriate; there are two occasions, as part of LIT and the generator for the LG2 instruction itself. Signed-off-by: Wladimir J. van der Laan ---

Re: [Mesa-dev] [PATCH] meta: Fix BlitFramebuffer temp texture setup

2017-07-11 Thread Ville Syrjälä
On Mon, Jul 10, 2017 at 11:42:18PM +0300, Andres Gomez wrote: > Ville, has this patch fallen through the cracks ? Nope. I've still been looking into the issue whenever I've had a few minutes to spare. I think I have it more or les figured out at this stage, but I'll need to respin this patch, and

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-11 Thread Emil Velikov
On 10 July 2017 at 22:33, Chad Versace wrote: > On Mon 10 Jul 2017, Chad Versace wrote: >> On Fri 07 Jul 2017, Rob Herring wrote: >> > On Wed, Jul 5, 2017 at 5:14 PM, Chad Versace >> > wrote: >> > > On Fri 30 Jun 2017, Rob Herring wrote: >> >

[Mesa-dev] [PATCH 2/2] - drirc: whitelist glthread for Euro Truck Simulator 2

2017-07-11 Thread Petr Sebor
--- src/mesa/drivers/dri/common/drirc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 1311db9..be731a0 100644 --- a/src/mesa/drivers/dri/common/drirc +++ b/src/mesa/drivers/dri/common/drirc @@ -178,6 +178,9 @@

[Mesa-dev] [PATCH 1/2] - drirc: whitelist glthread for American Truck Simulator

2017-07-11 Thread Petr Sebor
--- src/mesa/drivers/dri/common/drirc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 69b735c..1311db9 100644 --- a/src/mesa/drivers/dri/common/drirc +++ b/src/mesa/drivers/dri/common/drirc @@ -175,6 +175,9 @@

Re: [Mesa-dev] [PATCH 07/10] util/u_queue: add an option to resize the queue when it's full

2017-07-11 Thread Grazvydas Ignotas
On Tue, Jul 11, 2017 at 12:21 AM, Marek Olšák wrote: > From: Marek Olšák > > Consider the following situation: > mtx_lock(mutex); > do_something(); > util_queue_add_job(...); > mtx_unlock(mutex); > > If the queue is full, util_queue_add_job will

Re: [Mesa-dev] [PATCH] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

2017-07-11 Thread Alex Smith
Ping. On 30 June 2017 at 11:18, Alex Smith wrote: > If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image > view's descriptor was set to a 2D array (and a few other fields adjusted > accordingly). This is correct when the image view is actually

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #23 from John --- Some apps worked, others froze the system. I'm still hopeful to find a fix here :) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #22 from Marko --- (In reply to John from comment #21) > I believe that's a same generation card, so it would make sense to behave > similarly. Yeah. Did it ever work for you? RADV was a no-go on my

[Mesa-dev] [PATCH 2/2] i965: Fix asynchronous mappings on !LLC platforms.

2017-07-11 Thread Kenneth Graunke
When using a read-only CPU mapping, we may encounter stale buffer contents. For example, the Piglit primitive-restart test offers the following scenario: 1. Read data via a CPU map. 2. Destroy that buffer. 3. Create a new buffer - obtaining the same one via the BO cache. 4. Call

[Mesa-dev] [PATCH 1/2] i965: Don't use PREAD for glGetBufferSubData().

2017-07-11 Thread Kenneth Graunke
Just map the buffer and memcpy. This will do a CPU mmap, which should be reasonably efficient, and doing this gives us full control over the domains and caching instead of leaving it to the kernel. This prevents regressions on Braswell in the next commit. Specifically

[Mesa-dev] XCOM: Enemy Unknown vs. NaN texture unit LOD bias

2017-07-11 Thread Kenneth Graunke
Hello, Mesa master has been hitting assert failures when running "XCOM: Enemy Unknown" since commit f8d69beed49c64f883bb8ffb28d4960306baf575, where we started asserting that the SAMPLER_STATE LOD Bias value actually fits in the correct number of bits. Apparently, XCOM calls