Re: [Mesa-dev] [PATCH 2/2] i915/fpc_translate: Remove a few unused variables

On Friday, August 25, 2017 12:04:36 AM PDT Eduardo Lima Mitev wrote: > --- > src/gallium/drivers/i915/i915_fpc_translate.c | 16 > 1 file changed, 16 deletions(-) > > diff --git a/src/gallium/drivers/i915/i915_fpc_translate.c > b/src/gallium/drivers/i915/i915_fpc_translate.c >

[Mesa-dev] [PATCH] radeonsi: stop leaking nir

--- src/gallium/drivers/radeonsi/si_state_shaders.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 35bc0db74e..71d798749c 100644 --- a/src/gallium/drivers/radeonsi/si_state_shaders.c +++

Re: [Mesa-dev] Question about implementing viewport transfer and const load in nir

On Saturday, August 26, 2017 6:40:14 AM PDT Qiang Yu wrote: > Hi guys, > > When working on lima gp compiler, I come across two problems about > inserting extra uniform > and instructions in nir for the driver and don't know where's the > right place to do it. So I'd like > to hear your opinion

Re: [Mesa-dev] [PATCH] st/mesa: fix handling of vertex array double inputs

On Saturday, August 26, 2017 9:42:17 PM PDT Ilia Mirkin wrote: > The is_double_vertex_input needs to be set for arrays of doubles as > well. > > Fixes KHR-GL45.enhanced_layouts.varying_array_locations > > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedesktop.org >

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: add Define Restart Interval to MJPEG bitstream reconstruction

On 08/27/2017 01:53 PM, Emil Velikov wrote: On 25 August 2017 at 18:17, Leo Liu wrote: Signed-off-by: Leo Liu Same here - please add a couple words of commit message alongside a fixes (or stable) tag. Well this is not a fix. It adds the capacity for

Re: [Mesa-dev] [PATCH 1/3] st/omx: move YUV deinterlace function to common

On 08/27/2017 01:49 PM, Emil Velikov wrote: Hi Leo, On 24 August 2017 at 16:11, Leo Liu wrote: Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_compositor.c | 87 +--- src/gallium/auxiliary/vl/vl_compositor.h | 21

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

On 08/27/2017 01:52 PM, Emil Velikov wrote: On 25 August 2017 at 18:17, Leo Liu wrote: Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking through it a couple times it seems like this should be more performant than my modification of Vladislav's original implementation. Would be nice to see a performance comparison

Re: [Mesa-dev] [PATCH] radv: clear dynamic_shader_stages on create

Reviewed-by: Bas Nieuwenhuizen On Mon, Aug 28, 2017, at 01:13, Grazvydas Ignotas wrote: > Valgrind reports it's being used uninitialized. > > Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" > Signed-off-by: Grazvydas Ignotas

Re: [Mesa-dev] [PATCH] amd: add .editorconfig

Heh, I noticed today that kate started following these rules for me too. Acked-by: Bas Nieuwenhuizen On Sun, Aug 27, 2017, at 23:44, Grazvydas Ignotas wrote: > amd/common/ and amd/vulkan/ are using tabs for indent, which doesn't > match the settings in root

Re: [Mesa-dev] [PATCH] glsl: fix counting of vertex shader output slots used by explicit vars

Reviewed-by: Timothy Arceri On 27/08/17 14:12, Ilia Mirkin wrote: The argument to count_attribute_slots should only be set to true for vertex inputs, not for all vertex shader varyings. Fixes KHR-GL45.enhanced_layouts.varying_locations Signed-off-by: Ilia Mirkin

[Mesa-dev] [PATCH] radv: clear dynamic_shader_stages on create

Valgrind reports it's being used uninitialized. Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_descriptor_set.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] radv: Don't allocate CMASK for linear images.

We can't use it anyway in fast clears, and on GFX9 it seems to actually hange the card if we specify it. Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" --- src/amd/vulkan/radv_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] radv: don't assert on empty hash table

Currently if table_size is 0, it's falling through to: unreachable("hash table should never be full"); But table_size can be 0 when RADV_DEBUG=nocache is set, or when the table allocation fails (which is not considered an error). Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan

[Mesa-dev] [PATCH] amd: add .editorconfig

amd/common/ and amd/vulkan/ are using tabs for indent, which doesn't match the settings in root .editorconfig, so let's override. Signed-off-by: Grazvydas Ignotas --- src/amd/common/.editorconfig | 3 +++ src/amd/vulkan/.editorconfig | 3 +++ 2 files changed, 6 insertions(+)

[Mesa-dev] [PATCH] ac/nir: silence maybe-uninitialized warnings

These are likely false positives, but are also annoying because they show up on every "make install", which causes ac_nir_to_llvm to be rebuilt here. Initializing those variables to NULL should be harmless even when unnecessary. Signed-off-by: Grazvydas Ignotas ---

Re: [Mesa-dev] [PATCH 8/8] clover/llvm: Make __OPENCL_VERSION__ dynamic

On Thu, Aug 10, 2017 at 11:07 AM, Jan Vesely wrote: > On Wed, 2017-08-09 at 22:36 -0500, Aaron Watry wrote: >> On Fri, Aug 4, 2017 at 1:43 PM, Jan Vesely wrote: >> > On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote: >> > > Signed-off-by: Aaron

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

Hi, On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" wrote: On 24/08/17 21:07, Connor Abbott wrote: > > Hi Alejandro, Hi Connor, > > This seems really suspicious. If the live ranges are really > independent, then the register allocator should be able to assign the > two

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: add Define Restart Interval to MJPEG bitstream reconstruction

On 25 August 2017 at 18:17, Leo Liu wrote: > Signed-off-by: Leo Liu Same here - please add a couple words of commit message alongside a fixes (or stable) tag. Thank you Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

On 25 August 2017 at 18:17, Leo Liu wrote: > Signed-off-by: Leo Liu > --- > src/gallium/drivers/radeon/radeon_uvd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeon/radeon_uvd.c >

Re: [Mesa-dev] [PATCH 1/3] st/omx: move YUV deinterlace function to common

Hi Leo, On 24 August 2017 at 16:11, Leo Liu wrote: > Signed-off-by: Leo Liu > --- > src/gallium/auxiliary/vl/vl_compositor.c | 87 > +--- > src/gallium/auxiliary/vl/vl_compositor.h | 21 >

Re: [Mesa-dev] [PATCH] nvc0/query: write 0 to pipeline_statistics.cs_invocations

Reviewed-by: Ilia Mirkin On Sun, Aug 27, 2017 at 12:00 PM, Karol Herbst wrote: > cs_invocations are currently unsupported, but leaving the field uninitialized > is even worse. > > fixes on nvc0: > *

[Mesa-dev] [PATCH] nvc0/query: write 0 to pipeline_statistics.cs_invocations

cs_invocations are currently unsupported, but leaving the field uninitialized is even worse. fixes on nvc0: * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_default_qo_values * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_non_rendering_commands_do_not_affect_queries

[Mesa-dev] [PATCH v2] st/mesa: fix handling of vertex array double inputs

The is_double_vertex_input needs to be set for arrays of doubles as well. Fixes KHR-GL45.enhanced_layouts.varying_array_locations Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- v1 -> v2: reflow code, per mattst88

[Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

this way Nouveau can report 128 inputs, but only 124 varyings. Fixes: 'KHR-GL45.limits.max_fragment_input_components' Signed-off-by: Karol Herbst --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 +

[Mesa-dev] [PATCH 10/10] egl/wayland: make sure HAS_$FORMAT is set for wl_dmabuf

From: Emil Velikov Otherwise eglCreateWaylandBufferFromImageWL will fail, since we have no "supported" format. Cc: Daniel Stone Fixes: 02cc35937277 ("egl/wayland: Use linux-dmabuf interface for buffers") Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 08/10] egl/wayland: remove dri2_surf width/height double init.

From: Emil Velikov The dimensions are already set [to 0 or the value provided by the attributes list] by the _eglInitSurface() call further up. The values are updated, as the DRI driver calls the DRI2/IMAGE_LOADER' get_buffers, shortly before making use of the

[Mesa-dev] [PATCH 06/10] egl: add juicy comment about WL_bind_wayland_display + wl_drm/wl_dmabuf

From: Emil Velikov AFAICT the extension only makes sense/can work with wl_drm. If/as we decide to drop it there's a lot of subtleties (borderline hacks) that can be dropped. Add a comment with a few keywords to grep. Cc: Daniel Stone

[Mesa-dev] [PATCH 09/10] egl/wayland: group wl_win specific code together

From: Emil Velikov Make the code a bit easier to follow. There should be no functional change since none of the bits set are accessible until the eglCreateWindowSurface call is complete. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 01/10] egl: simplify refcounting after screen creation

From: Emil Velikov If the specific initialize was successfull, dri2_egl_display() will return a non NULL pointer. Thus we can drop the check and flatten the codeflow. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 14

[Mesa-dev] [PATCH 05/10] egl/wayland: update comment to reflect wl_dmabuf presence

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c

[Mesa-dev] [PATCH 03/10] egl/wayland: polish object teardown in dri2_wl_destroy_surface

From: Emil Velikov The wl_drm wrapper is created before the wl display/surface ones. Thus make sure we destroy it after them. In reality it should not make any difference either way. Fixes: 03dd9a88b0b ("egl/wayland: Use per-surface event queues") Signed-off-by: Emil

[Mesa-dev] [PATCH 02/10] egl/wayland: plug leaks in dri2_wl_create_window_surface() error path

From: Emil Velikov We forgot to teardown the wl display/surface wrappers. Fixes: 03dd9a88b0b ("egl/wayland: Use per-surface event queues") Cc: Daniel Stone Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 04/10] egl: allow RGB565 formats in eglCreateWaylandBufferFromImageWL

From: Emil Velikov There's nothing special required, but a simple format check. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 00/10] egl: mixed bag of fixes/cleanups

Hi all, This is somewhat of a mixed bag series. I've tried splitting it up but it got a bit messy. So here it is, in a gist: - various missing bits wrt wl_dmabuf - a few small cleanups - wires RGB565 in WL_create_wayland_buffer_from_image -Emil Emil Velikov (10): egl: simplify refcounting

[Mesa-dev] [PATCH 07/10] egl/wayland: set correct format with wl_dmabuf as wl_drm is missing

From: Emil Velikov For most/all cases today, we have wl_drm available alongside wl_dmabuf. Yet in the long run, we want to make sure the latter can operate without any traces of the former. Cc: Daniel Stone Fixes: 02cc35937277 ("egl/wayland:

Re: [Mesa-dev] [PATCH] st/mesa: fix handling of vertex array double inputs

On Sat, Aug 26, 2017 at 9:42 PM, Ilia Mirkin wrote: > The is_double_vertex_input needs to be set for arrays of doubles as > well. > > Fixes KHR-GL45.enhanced_layouts.varying_array_locations > > Signed-off-by: Ilia Mirkin > Cc: