[Mesa-dev] [PATCH] anv: Move size check from anv_bo_cache_import() to caller (v2)

This change prepares for VK_ANDROID_native_buffer. When the user imports a gralloc hande into a VkImage using VK_ANDROID_native_buffer, the user provides no size. The driver must infer the size from the internals of the gralloc buffer. The patch is essentially a refactor patch. It should change

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

On Tue, Oct 17, 2017 at 09:00:56PM +0200, Nicolai Hähnle wrote: > On 17.10.2017 16:09, Ville Syrjälä wrote: > > On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: > >> On 17/10/17 02:22 PM, Daniel Vetter wrote: > >>> On Tue, Oct 17, 2017 at 12:28:17PM +0200, Michel Dänzer wrote: >

[Mesa-dev] [PATCH] radv: don't create dummy fs when compiling compute stage

Fixes: d1c9f30d7ff7 "radv: add radv_create_shaders() helper" --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 00315460c2..116e706f98 100644 ---

Re: [Mesa-dev] [PATCH 1/6] i965: Only put external handles into the handle ht

On Monday, October 16, 2017 12:38:04 PM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-10-16 20:07:05) > > Patches 2 and 5 look good to me as well. I'd like to try out the > > AMD_pinned_memory support with Left 4 Dead 2, as I know a bunch of > > the Source 1 games use AMD_pinned_memory

Re: [Mesa-dev] [PATCH] Fix the xf86vm meson dependency

I could have sworn this got fixed already, but clearly not. reviewed-by: Dylan Baker On October 17, 2017 6:04:16 PM PDT, Nicholas Miell wrote: >The pkg-config file is called xxf86vm. > >Signed-off-by: Nicholas Miell >--- > meson.build |

[Mesa-dev] [PATCH] Fix the xf86vm meson dependency

The pkg-config file is called xxf86vm. Signed-off-by: Nicholas Miell --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 33121600d0c..82c4d2ed12c 100644 --- a/meson.build +++ b/meson.build @@ -678,7 +678,7 @@ if

Re: [Mesa-dev] [PATCH 07/10] anv: Move size check from anv_bo_cache_import() to caller

On Tue, Oct 17, 2017 at 5:27 PM, Chad Versace wrote: > This change prepares for VK_ANDROID_native_buffer. When the user imports > a gralloc hande into a VkImage using VK_ANDROID_native_buffer, the user > provides no size. The driver must infer the size from the

Re: [Mesa-dev] [PATCH] llvmpipe: handle shader sample mask output

LGTM. Reviewed-by: Brian Paul On 10/17/2017 01:58 PM, srol...@vmware.com wrote: From: Roland Scheidegger This probably isn't all that useful for GL, but there are apis where sample_mask is a valid output even without msaa. Just discard the pixel if the

[Mesa-dev] [PATCH 07/10] anv: Move size check from anv_bo_cache_import() to caller

This change prepares for VK_ANDROID_native_buffer. When the user imports a gralloc hande into a VkImage using VK_ANDROID_native_buffer, the user provides no size. The driver must infer the size from the internals of the gralloc buffer. The patch is essentially a refactor patch. It should change

Re: [Mesa-dev] [PATCH 4/6] i965: Use blorp+userptr for GPU readback

Quoting Chris Wilson (2017-10-13 10:34:54) > The primary benefit for this is that we get format conversion for > "free", along with detiling and cache flushing (most relevant for !llc). > Using the GPU does impose a bandwidth cost that is presumably better > used for rendering, hence we limit the

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

On 18/10/17 09:37, Miklós Máté wrote: On 16/10/17 01:59, Timothy Arceri wrote: On 16/10/17 04:10, Miklós Máté wrote: Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with

Re: [Mesa-dev] [PATCH 1/2] nir: Add a safety check that we don't remove dead I/O vars after lowering.

Timothy Arceri writes: > On 18/10/17 07:52, Eric Anholt wrote: >> The pass only looks at var load/store intrinsics, not input load/store >> intrinsics, so assert that we don't see the other type. >> --- >> >> I tripped over this limitation when trying to use the NIR

Re: [Mesa-dev] [PATCH] meson: turn on pl111 not vc4 when pl111 driver specificed

Dylan Baker writes: > cc: Eric Anholt > fixes: 1918c9b1627d5403 ("meson: Add support for the pl111 driver.") > Signed-off-by: Dylan Baker > --- > > I missed this when I was reviewing, but saw it looking at the change log when > I

[Mesa-dev] [PATCH] i965: Fix memmem compiler warnings.

gcc is throwing this warning in my meson build: ../src/intel/compiler/brw_eu_validate.c:50:11: warning argument 1 null where non-null expected [-Wnonnull] return memmem(haystack.str, haystack.len, ^~ needle.str,

Re: [Mesa-dev] [PATCH v2 07/52] intel/fs: Use a pair of 1-wide MOVs instead of SEL for any/all

On Tue, Oct 17, 2017 at 2:53 PM, Jason Ekstrand wrote: > On Tue, Oct 17, 2017 at 2:18 PM, Matt Turner wrote: >> >> On 10/12, Jason Ekstrand wrote: >>> >>> For some reason, the any/all predicates don't work properly with SIMD32. >>> In particular, it

Re: [Mesa-dev] [PATCH 1/2] nir: Add a safety check that we don't remove dead I/O vars after lowering.

On 18/10/17 07:52, Eric Anholt wrote: The pass only looks at var load/store intrinsics, not input load/store intrinsics, so assert that we don't see the other type. --- I tripped over this limitation when trying to use the NIR linking helpers in vc4.

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

On 16/10/17 01:59, Timothy Arceri wrote: On 16/10/17 04:10, Miklós Máté wrote: Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowing the

Re: [Mesa-dev] [PATCH v2 07/52] intel/fs: Use a pair of 1-wide MOVs instead of SEL for any/all

On Tue, Oct 17, 2017 at 2:18 PM, Matt Turner wrote: > On 10/12, Jason Ekstrand wrote: > >> For some reason, the any/all predicates don't work properly with SIMD32. >> In particular, it appears that a SEL with a QtrCtrl of 2H doesn't read >> the correct subset of the flag

[Mesa-dev] [PATCH] meson: turn on pl111 not vc4 when pl111 driver specificed

cc: Eric Anholt fixes: 1918c9b1627d5403 ("meson: Add support for the pl111 driver.") Signed-off-by: Dylan Baker --- I missed this when I was reviewing, but saw it looking at the change log when I was rebasing some other work. meson.build | 2 +- 1

[Mesa-dev] [PATCH 5/5] gallium/util: don't call close() on Windows in u_tests.c

--- src/gallium/auxiliary/util/u_tests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_tests.c b/src/gallium/auxiliary/util/u_tests.c index 3cc79af..2548b46 100644 --- a/src/gallium/auxiliary/util/u_tests.c +++ b/src/gallium/auxiliary/util/u_tests.c @@ -567,6

[Mesa-dev] [PATCH 3/5] mesa: use util_strdup() macro in symbol_table.c

--- src/mesa/program/symbol_table.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 37066c9..f5dacbb 100644 --- a/src/mesa/program/symbol_table.c +++ b/src/mesa/program/symbol_table.c @@ -24,6 +24,7

[Mesa-dev] [PATCH 1/5] gallium/util: replace gethostbyname() with getaddrinfo()

Compiling with MSVC options /we4995 /we4996 (a subset of /sdl) generates a warning that the gethostbyname() function is deprecated in favor of getaddrinfo() or GetAddrInfoW(). Replace the call with getaddrinfo(). Untested. There are no callers to u_socket_connect() in Gallium. ---

[Mesa-dev] [PATCH 4/5] mesa: use util_strdup() macro in u_debug_symbol.c

--- src/gallium/auxiliary/util/u_debug_symbol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug_symbol.c b/src/gallium/auxiliary/util/u_debug_symbol.c index 4b55523..8476043 100644 --- a/src/gallium/auxiliary/util/u_debug_symbol.c +++

[Mesa-dev] [PATCH 2/5] util: add util_strdup() wrapper macro

To work around MSVC warning that strdup() is a deprecated POSIX function. --- src/util/u_string.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/u_string.h b/src/util/u_string.h index fa0241e..ce45430 100644 --- a/src/util/u_string.h +++ b/src/util/u_string.h @@ -203,6 +203,7 @@

Re: [Mesa-dev] [PATCH 4/4] meson: build nouveau veaux driver

Quoting Ilia Mirkin (2017-10-17 12:02:05) > On Tue, Oct 17, 2017 at 2:51 PM, Dylan Baker wrote: > > Gah. French is one of the few romance languages I've never learned even a > > little > > of. > > > > Fixed locally, would you like me to send a v2? > > I have faith in your

Re: [Mesa-dev] [PATCH v2 07/52] intel/fs: Use a pair of 1-wide MOVs instead of SEL for any/all

On 10/12, Jason Ekstrand wrote: For some reason, the any/all predicates don't work properly with SIMD32. In particular, it appears that a SEL with a QtrCtrl of 2H doesn't read the correct subset of the flag register and you end up getting garbage in the second half. Work around this by using a

Re: [Mesa-dev] [PATCH v2 6/8] egl: add dri2_egl_surface_destroy_image_front() helper (v2)

dri2_egl_surface_destroy_image_front and dri2_egl_surface_destroy_image_back are almost identical. Why don't you just create a dri2_surface_free_image(struct dri2_egl_surface *dri2_surf, __DRIimage **img) that you will call with both the front and back images? In addition, only platform_android

Re: [Mesa-dev] [PATCH v2 06/52] intel/fs: Use an explicit D type for vote any/all/eq intrinsics

On 10/12, Jason Ekstrand wrote: They return a boolean so this is the right type. Unfortunately, get_nir_dest has the annoying behavior of giving us a float type by default. This is mostly to work around the fact that gen7 has 64-bit float but no Q types. I'd really like to see a clearer

[Mesa-dev] [PATCH 1/2] nir: Add a safety check that we don't remove dead I/O vars after lowering.

The pass only looks at var load/store intrinsics, not input load/store intrinsics, so assert that we don't see the other type. --- I tripped over this limitation when trying to use the NIR linking helpers in vc4. src/compiler/nir/nir_remove_dead_variables.c | 20 1 file

[Mesa-dev] [PATCH 2/2] nir: Print the components referenced for split or packed shader in/outs.

Having 4 variables all called "gl_in_TexCoord0@n" isn't very informative, much better to see: decl_var shader_in INTERP_MODE_NONE float gl_in_TexCoord0 (VARYING_SLOT_VAR0.x, 1, 0) decl_var shader_in INTERP_MODE_NONE float gl_in_TexCoord0@0 (VARYING_SLOT_VAR0.y, 1, 0) decl_var shader_in

[Mesa-dev] [PATCH 2/2] ac: Silence a compiler warning about results[0].

We know that num_components will be > 0, but it doesn't. --- src/amd/common/ac_nir_to_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3ba3ebf051e2..07fa3fdf84b5 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH 1/2] ac: Fix a compiler warning for possibly undefined "name"

--- src/amd/common/ac_llvm_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 949f181aace0..2341d2135856 100644 --- a/src/amd/common/ac_llvm_build.c +++ b/src/amd/common/ac_llvm_build.c @@ -1257,7

Re: [Mesa-dev] [PATCH v2 2/8] egl: refactor color_buffers structure for deduplicating

Can you wrap color_buffers around: #if defined(HAVE_WAYLAND_PLATFORM) || defined(HAVE_DRM_PLATFORM) || defined(HAVE_ANDROID_PLATFORM) flags? This is because platform_surfaceless has no native surfaces and it's good to be explicit in that regard. On Fri, Oct 6, 2017 at 2:38 PM, Gwan-gyeong Mun

Re: [Mesa-dev] [PATCH v2 05/52] intel/fs: Don't stomp f0.1 in SIMD16 ballot

On 10/12, Jason Ekstrand wrote: In fragment shaders f0.1 is used for discards so doing ballot after a discard can potentially cause the discard to not happen. Since - SIMD32 currently only used in compute shaders - discard only available in fragment shaders this will fix

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

Quoting Nicolai Hähnle (2017-10-17 13:40:00) > On 17.10.2017 22:33, Dylan Baker wrote: > > Quoting Nicolai Hähnle (2017-10-17 13:05:12) > >> On 17.10.2017 21:21, Dylan Baker wrote: > >>> +CC, CFLAGS, CXX, CXXFLAGS > >>> +These environment variables > >>> +control the C and C++ compilers used

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

On 17.10.2017 22:33, Dylan Baker wrote: Quoting Nicolai Hähnle (2017-10-17 13:05:12) On 17.10.2017 21:21, Dylan Baker wrote: +CC, CFLAGS, CXX, CXXFLAGS +These environment variables +control the C and C++ compilers used during the build. The default compilers +depends on your operating system.

[Mesa-dev] [PATCH 0/5] etnaviv: support occlusion queries

This small patch series adds support for occlusion queries. This is the last thing needed to expose desktop opengl 2.0! Not all piglits for occlusion queries are passing but overall the results are looking good. Christian Gmeiner (5): etnaviv: update headers from rnndb etnaviv: add basic

[Mesa-dev] [PATCH 5/5] etnaviv: fix implicit conversion warning

Galliums query_type used in APIs is unsigned. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_query.h| 2 +- src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

The naming is verbose and somewhat inconsistent. We have: dri2_init_surface dri2_fini_surface dri2_egl_surface_alloc_local_buffer dri2_egl_surface_free_local_buffers I suggest you implement the following convention: dri2_surface_init dri2_surface_fini dri2_surface_alloc_attachment (instead of

[Mesa-dev] [PATCH 3/5] etnaviv: add support for occlusion queries

Passes most occlusion query piglits. The following piglits are broken: - spec@arb_occlusion_query@occlusion_query_meta_fragments - spec@arb_occlusion_query@occlusion_query_meta_save - spec@arb_occlusion_query2@render Signed-off-by: Christian Gmeiner ---

[Mesa-dev] [PATCH 4/5] etnaviv: enable occlusion query if GPU supports it

Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index

[Mesa-dev] [PATCH 2/5] etnaviv: add basic infrastructure for hw queries

No hardware query is supported yet. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium/drivers/etnaviv/etnaviv_context.c | 11 ++ src/gallium/drivers/etnaviv/etnaviv_context.h | 3 +

[Mesa-dev] [PATCH 1/5] etnaviv: update headers from rnndb

Update to etna_viv commit 6c9c706. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 36 ++- src/gallium/drivers/etnaviv/hw/common.xml.h| 117 src/gallium/drivers/etnaviv/hw/isa.xml.h | 4 +-

Re: [Mesa-dev] [PATCH] radv: remove XtoY_temps structs

r-b On Tue, Oct 17, 2017 at 11:04 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_bufimage.c | 62 > - > 1 file changed, 26 insertions(+), 36 deletions(-) > >

Re: [Mesa-dev] [PATCH] radv: use the dispatch initiator for indirect dispatches

r-b On Tue, Oct 17, 2017 at 12:02 PM, Samuel Pitoiset wrote: > Missed that when I allowed waves to be launched out-of-order. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 24 +--- > 1 file

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

Quoting Nicolai Hähnle (2017-10-17 13:05:12) > On 17.10.2017 21:21, Dylan Baker wrote: > > +CC, CFLAGS, CXX, CXXFLAGS > > +These environment variables > > +control the C and C++ compilers used during the build. The default > > compilers > > +depends on your operating system. Meson supports GCC,

Re: [Mesa-dev] [PATCH 3/4] meson: build r200 driver

Dylan Baker writes: > Build tested only > > Signed-off-by: Dylan Baker > --- > meson.build | 4 +- > meson_options.txt | 2 +- > src/mesa/drivers/dri/meson.build | 3 ++ >

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

On 17.10.2017 21:21, Dylan Baker wrote: +CC, CFLAGS, CXX, CXXFLAGS +These environment variables +control the C and C++ compilers used during the build. The default compilers +depends on your operating system. Meson supports GCC, Clang, and MSVC as first +class compilers. There is some support

Re: [Mesa-dev] [PATCH 7/7] glsl: Remove ir_binop_greater and ir_binop_lequal expressions

Good riddance! Reviewed-by: Nicolai Hähnle On 17.10.2017 20:14, Ian Romanick wrote: From: Ian Romanick NIR does not have these instructions. TGSI and Mesa IR both implement them using < and >=, repsectively. Removing them deletes a bunch

[Mesa-dev] [PATCH] llvmpipe: handle shader sample mask output

From: Roland Scheidegger This probably isn't all that useful for GL, but there are apis where sample_mask is a valid output even without msaa. Just discard the pixel if the sample_mask doesn't include the bit for sample 0. --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 26

Re: [Mesa-dev] [PATCH 5/7] glsl/parser: Return the glsl_type object from the lexer

Patches 1-5: Reviewed-by: Nicolai Hähnle On 17.10.2017 20:14, Ian Romanick wrote: From: Ian Romanick This allows us to use a single token for every built-in type except void. text data bss dec hex filename 8275163

Re: [Mesa-dev] [PATCH 6/7] glsl/parser: Track built-in types using the glsl_type directly

On 17.10.2017 21:54, Nicolai Hähnle wrote: On 17.10.2017 20:14, Ian Romanick wrote: From: Ian Romanick     text   data    bss    dec    hex    filename 8255243 268856 294072    8818171 868dfb    32-bit i965_dri.so before 8255291

Re: [Mesa-dev] [PATCH 6/7] glsl/parser: Track built-in types using the glsl_type directly

On 17.10.2017 20:14, Ian Romanick wrote: From: Ian Romanick text data bss dec hex filename 8255243 268856 294072 8818171 868dfb 32-bit i965_dri.so before 8255291 268856 294072 8818219 868e2b 32-bit i965_dri.so after 7815195 345592

Re: [Mesa-dev] [PATCH v3 02/43] mesa/st: Handle 16-bit types at st_glsl_storage_type_size()

Patches 1 & 2: Reviewed-by: Nicolai Hähnle On 12.10.2017 20:37, Jose Maria Casanova Crespo wrote: From: Eduardo Lima Mitev This is basically to avoid "not handle in switch" warnings. v2: Let the new types hit the assertion instead. (Marek Olšák

Re: [Mesa-dev] [PATCH 16/16] radeonsi: if there's just const buffer 0, set it in place of CONST/SSBO pointer

On 17.10.2017 17:43, Marek Olšák wrote: On Tue, Oct 17, 2017 at 2:25 PM, Nicolai Hähnle wrote: On 13.10.2017 14:04, Marek Olšák wrote: From: Marek Olšák SI_SGPR_CONST_AND_SHADER_BUFFERS now contains the pointer to const buffer 0 if there is no other

Re: [Mesa-dev] [PATCH] configure.ac: set -O0 on --enable-debug

On 16.10.2017 20:31, Miklós Máté wrote: On 16/10/17 13:21, Emil Velikov wrote: Hi Miklós, On 15 October 2017 at 18:46, Miklós Máté wrote: Autoconf sets CFLAGS="-g -O2" by default. Signed-off-by: Miklós Máté ---   configure.ac | 4   1 file changed, 4

Re: [Mesa-dev] [PATCH] glsl/linker: produce error when invalid explicit locations are used

On 16.10.2017 14:06, Iago Toral Quiroga wrote: We only need to add a check to validate output locations here. For inputs with invalid locations we will fail to link when we can't find a matching output in the same (invalid) location. Fixes: KHR-GL45.enhanced_layouts.varying_location_limit

[Mesa-dev] [PATCH] docs: add documentation for building with meson

Signed-off-by: Dylan Baker --- I'm sending this out now so that others can look at it, review it, and reference it, but this should not end up in the 17.3 release, as the meson build for mesa will not be ready to go into the 17.3 release. docs/contents.html | 1 +

Re: [Mesa-dev] [PATCH 4/4] meson: build nouveau veaux driver

On Tue, Oct 17, 2017 at 2:51 PM, Dylan Baker wrote: > Gah. French is one of the few romance languages I've never learned even a > little > of. > > Fixed locally, would you like me to send a v2? I have faith in your sed -i skills. Hopefully you'll push it somewhere though so

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

On 17.10.2017 19:16, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: On 17/10/17 05:04 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: On 17/10/17 02:22 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

On 17.10.2017 16:09, Ville Syrjälä wrote: On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: On 17/10/17 02:22 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 12:28:17PM +0200, Michel Dänzer wrote: On 17/10/17 11:34 AM, Nicolai Hähnle wrote: Common sense suggests that there

Re: [Mesa-dev] [PATCH v2 04/52] intel/fs: Use ANY/ALL32 predicates in SIMD32

On 10/12, Jason Ekstrand wrote: We have ANY/ALL32 predicates and, for the most part, they work just fine. (See the next commit for more details.) Also, due to the way that flag registers are handled in hardware, instruction splitting is able to split the CMP correctly. Specifically, that

Re: [Mesa-dev] [PATCH v2 03/52] intel/fs: Handle flag read/write aliasing in needs_src_copy

On 10/12, Jason Ekstrand wrote: In order to implement the ballot intrinsic, we do a MOV from flag register to some GRF. If that GRF is used in a SEL, cmod propagation helpfully changes it into a MOV from the flag register with a cmod. This is perfectly valid but when lower_simd_width comes

Re: [Mesa-dev] meson for remaining class drivers

Quoting Timothy Arceri (2017-10-16 18:05:38) > On 17/10/17 11:55, Dylan Baker wrote: > > Here is build support for the three remaining classic drivers, radeon > > (r100), > > r200, and the nouveau-veaux driver. None of these are too crazy, but I don't > > have hardware to test any of these. > >

Re: [Mesa-dev] [PATCH 4/4] meson: build nouveau veaux driver

Gah. French is one of the few romance languages I've never learned even a little of. Fixed locally, would you like me to send a v2? Quoting Ilia Mirkin (2017-10-16 18:50:49) > Old, not calves... > > On Oct 16, 2017 8:56 PM, "Dylan Baker" wrote: > > Build tested only.

[Mesa-dev] [Bug 103312] meson/macOS: Dependency libdrm_intel found: NO

https://bugs.freedesktop.org/show_bug.cgi?id=103312 --- Comment #3 from Dylan Baker --- Currently I haven't tested building on any platform other than Linux for meson. Honestly macOS isn't on my list of targets, I don't have a mac to test with and my employer doesn't

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/4] i965/gen10: Enable float blend optimization

On Thu, Oct 12, 2017 at 10:08 AM, Emil Velikov wrote: > Hi Anuj, > > On 3 October 2017 at 00:07, Anuj Phogat wrote: >> This optimization is enabled for previous generations too. >> See Mesa commit c17e214a6b >> On CNL this bit is moved to

[Mesa-dev] [PATCH 2/7] glsl/parser: Silence unused parameter warning

From: Ian Romanick glsl/glsl_parser_extras.cpp: In constructor ‘ast_struct_specifier::ast_struct_specifier(void*, const char*, ast_declarator_list*)’: glsl/glsl_parser_extras.cpp:1675:50: warning: unused parameter ‘lin_ctx’ [-Wunused-parameter]

[Mesa-dev] [PATCH 7/7] glsl: Remove ir_binop_greater and ir_binop_lequal expressions

From: Ian Romanick NIR does not have these instructions. TGSI and Mesa IR both implement them using < and >=, repsectively. Removing them deletes a bunch of code and means I don't have to add code to the SPIR-V generator for them. v2: Rebase on 2+ years of change...

[Mesa-dev] [PATCH 1/7] glsl: Silence unused parameter warnings

From: Ian Romanick glsl/standalone_scaffolding.cpp: In function ‘GLbitfield _mesa_program_state_flags(const gl_state_index*)’: glsl/standalone_scaffolding.cpp:103:66: warning: unused parameter ‘state’ [-Wunused-parameter] _mesa_program_state_flags(const

[Mesa-dev] [PATCH 6/7] glsl/parser: Track built-in types using the glsl_type directly

From: Ian Romanick textdata bss dec hex filename 8255243 268856 294072 8818171 868dfb 32-bit i965_dri.so before 8255291 268856 294072 8818219 868e2b 32-bit i965_dri.so after 7815195 345592 420592 8581379 82f103 64-bit i965_dri.so before

[Mesa-dev] [PATCH 5/7] glsl/parser: Return the glsl_type object from the lexer

From: Ian Romanick This allows us to use a single token for every built-in type except void. textdata bss dec hex filename 8275163 269336 294072 8838571 86ddab 32-bit i965_dri.so before 8255243 268856 294072 8818171 868dfb 32-bit i965_dri.so

[Mesa-dev] [PATCH 4/7] glsl/parser: Allocate identifier inside classify_identifier

From: Ian Romanick Passing YYSTYPE into classify_identifier enables a later patch. textdata bss dec hex filename 8310339 269336 294072 8873747 876713 32-bit i965_dri.so before 8275163 269336 294072 8838571 86ddab 32-bit i965_dri.so after

[Mesa-dev] [PATCH 3/7] glsl/parser: Move anonymous struct name handling to the parser

From: Ian Romanick There are two callers of the constructor, and they are right next to each other. Move the "#anon_struct" name handling to the parser so that the conditional can be removed. I've also deleted part of the comment (about the memory leak) because I

Re: [Mesa-dev] [PATCH mesa] meson: add missing radv_extensions.c generation for libvulkan_radeon

Quoting Eric Engestrom (2017-10-17 11:07:48) > On Tuesday, 2017-10-17 17:04:13 +, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-10-17 08:23:26) > > > On Tuesday, 2017-10-17 14:55:06 +, Andres Gomez wrote: > > > > On Tue, 2017-10-17 at 12:00 +0100, Eric Engestrom wrote: > > > > >

Re: [Mesa-dev] [PATCH 07/10] anv: Add sizeless anv_bo_cache_import()

On Tue, Oct 17, 2017 at 10:52 AM, Chad Versace wrote: > On Mon 16 Oct 2017, Jason Ekstrand wrote: > > On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace <[1] > chadvers...@chromium.org> > > wrote: > > > > The patch renames anv_bo_cache_import() to > >

Re: [Mesa-dev] [PATCH 07/10] anv: Add sizeless anv_bo_cache_import()

On Tue, Oct 17, 2017 at 10:52 AM, Chad Versace wrote: > On Mon 16 Oct 2017, Jason Ekstrand wrote: > > On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace <[1] > chadvers...@chromium.org> > > wrote: > > > > The patch renames anv_bo_cache_import() to > >

Re: [Mesa-dev] [PATCH mesa] meson: add missing radv_extensions.c generation for libvulkan_radeon

On Tuesday, 2017-10-17 17:04:13 +, Dylan Baker wrote: > Quoting Eric Engestrom (2017-10-17 08:23:26) > > On Tuesday, 2017-10-17 14:55:06 +, Andres Gomez wrote: > > > On Tue, 2017-10-17 at 12:00 +0100, Eric Engestrom wrote: > > > > Signed-off-by: Eric Engestrom >

Re: [Mesa-dev] [PATCH] squash! anv: Move close(fd) from anv_bo_cache_import to its callers

On Tue, Oct 17, 2017 at 10:46 AM, Chad Versace wrote: > On Mon 16 Oct 2017, Jason Ekstrand wrote: > > On October 16, 2017 4:18:45 PM Chad Versace > wrote: > > > > > > > > Add missing close(fd) for case > > >

Re: [Mesa-dev] [PATCH 07/10] anv: Add sizeless anv_bo_cache_import()

On Mon 16 Oct 2017, Jason Ekstrand wrote: > On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > The patch renames anv_bo_cache_import() to > anv_bo_cache_import_with_size(); and adds a new variant, > anv_bo_cache_import(), that lacks the 'size'

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

On Tuesday, 2017-10-17 17:20:13 +, Emil Velikov wrote: > On 17 October 2017 at 18:04, Kai Wasserbäch > wrote: > > Hey Eric, > > Eric Engestrom wrote on 17.10.2017 18:31: > >> On Tuesday, 2017-10-17 15:26:00 +, Kai Wasserbäch wrote: > >>> So far the

Re: [Mesa-dev] [PATCH] squash! anv: Move close(fd) from anv_bo_cache_import to its callers

On Mon 16 Oct 2017, Jason Ekstrand wrote: > On October 16, 2017 4:18:45 PM Chad Versace wrote: > > > > > Add missing close(fd) for case > > VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT_KHR, > > subcase ANV_SEMAPHORE_TYPE_BO. > > --- > > src/intel/vulkan/anv_queue.c

Re: [Mesa-dev] [PATCH mesa] meson: add missing radv_extensions.c generation for libvulkan_radeon

Can't comment much on style, but it fixes the build, so Tested-by: Gert Wollny Am Dienstag, den 17.10.2017, 12:00 +0100 schrieb Eric Engestrom: > Signed-off-by: Eric Engestrom > --- > src/amd/vulkan/meson.build | 10 +- > 1 file

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

On 17 October 2017 at 18:04, Kai Wasserbäch wrote: > Hey Eric, > Eric Engestrom wrote on 17.10.2017 18:31: >> On Tuesday, 2017-10-17 15:26:00 +, Kai Wasserbäch wrote: >>> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver >>> name. This

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote: > On 17/10/17 05:04 PM, Daniel Vetter wrote: >> On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: >>> On 17/10/17 02:22 PM, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 12:28:17PM +0200, Michel Dänzer

[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name (v2)

So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver name. This causes confusion, because there is an X11 protocol extension by the same name. To make matters worse, the protocol extension also has a newer version called "DRI3", which then can lead a user to the assumption that

[Mesa-dev] Mesa 17.2.3 release candidate

Hello list, The candidate for the Mesa 17.2.3 is now available. Currently we have: - 54 queued - 8 nominated (outstanding) - and 2 rejected patches In the current queue we have: The Vulkan drivers ANV and RADV have multiple small fixes. The EGL code has improved handling of the new

[Mesa-dev] [PATCH v3] compiler: Mark when input/ouput attribute at VS uses 16-bit (v2)

New shader attribute to mark when a location has 16-bit value. This patch includes support on mesa glsl and nir. v2: Remove use of is_half_slot as is a duplicate of is_16bit (Topi Pohjolainen) --- src/compiler/glsl_types.h | 15 +++ src/compiler/nir/nir_gather_info.c |

Re: [Mesa-dev] [PATCH mesa] meson: add missing radv_extensions.c generation for libvulkan_radeon

Quoting Eric Engestrom (2017-10-17 08:23:26) > On Tuesday, 2017-10-17 14:55:06 +, Andres Gomez wrote: > > On Tue, 2017-10-17 at 12:00 +0100, Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > > > I would add a line like: > > > > fixes: 17201a2eb0b

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

Hey Eric, Eric Engestrom wrote on 17.10.2017 18:31: > On Tuesday, 2017-10-17 15:26:00 +, Kai Wasserbäch wrote: >> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver >> name. This causes confusion, because there is a kernel interface by the >> same name where a version 3

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

On 17 October 2017 17:36:06 BST, Harish Krupo wrote: > Hi Emil, > > Thank you for the comments, will fix the code accordingly and send a > v2 patch. > I have answered the question inline. > > Emil Velikov writes: > > > Hi Harish, > > > >

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

On Tuesday, 2017-10-17 15:26:00 +, Kai Wasserbäch wrote: > So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver > name. This causes confusion, because there is a kernel interface by the > same name where a version 3 is available. What confusion? Do you have an example?

Re: [Mesa-dev] [PATCH 2/2] configure: enable the OpenCL ICD by default

On Mon, Oct 16, 2017 at 10:40 AM, Emil Velikov wrote: > From: Emil Velikov > > Nearly all the distributions* that build Mesa OpenCL, enable the ICD. > Since building a non-ICD driver has the chance of conflicting with > existing OpenCL binary

Re: [Mesa-dev] [PATCH v4 0/2] build system: Unify c++11 detection and used [was: configure+mesa/st:check -std=c++11 support and enable tests accordingly]

> > I also think adding a test for each C++11 feature used in the code is > too tedious, regardless of the build system, and it would really need a > dedicated maintainer. > Certainly. Rather than checking for everything, I think a code snippet that just includes a few c++11-only headers would

Re: [Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

Michel Dänzer wrote on 17.10.2017 17:42: > On 17/10/17 05:26 PM, Kai Wasserbäch wrote: >> So far the Mesa-internal EGL driver "dri2" returned "DRI2" as its driver >> name. This causes confusion, because there is a kernel interface by the >> same name where a version 3 is available. >> >> This

Re: [Mesa-dev] [PATCH 16/16] radeonsi: if there's just const buffer 0, set it in place of CONST/SSBO pointer

On Tue, Oct 17, 2017 at 2:25 PM, Nicolai Hähnle wrote: > On 13.10.2017 14:04, Marek Olšák wrote: >> >> From: Marek Olšák >> >> SI_SGPR_CONST_AND_SHADER_BUFFERS now contains the pointer to const buffer >> 0 >> if there is no other buffer there. >> >>

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

Eric Engestrom writes: > On Monday, 2017-10-16 13:54:25 +, Emil Velikov wrote: >> Hi Harish, >> >> Overall looks great, a few comments/questions inline. >> > > I agree with everything Emil said :) > >> On 13 October 2017 at 19:49, Harish Krupo

Re: [Mesa-dev] [PATCH mesa] meson: add missing radv_extensions.c generation for libvulkan_radeon

On Tuesday, 2017-10-17 14:55:06 +, Andres Gomez wrote: > On Tue, 2017-10-17 at 12:00 +0100, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > I would add a line like: > > fixes: 17201a2eb0b (radv: port to using updated anv entrypoint/extension >

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

On Tue, Oct 17, 2017 at 03:46:24PM +0200, Michel Dänzer wrote: > On 17/10/17 02:22 PM, Daniel Vetter wrote: > > On Tue, Oct 17, 2017 at 12:28:17PM +0200, Michel Dänzer wrote: > >> On 17/10/17 11:34 AM, Nicolai Hähnle wrote: > > > >>> Common sense suggests that there need to be two side to

Re: [Mesa-dev] [PATCH v2 8/8] egl/wayland: add dri2_wl_free_buffers() helper

On 17 October 2017 at 15:07, Eric Engestrom wrote: > On Friday, 2017-10-06 21:38:35 +, Gwan-gyeong Mun wrote: >> This deduplicates free routines of color_buffers array. >> >> Signed-off-by: Mun Gwan-gyeong >> --- >>

  1   2   >