Re: [Mesa-dev] [PATCH 02/50] glsl: Add "built-in" functions to do neg(fp64) (v2)

2018-03-12 Thread Roland Scheidegger
Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > v2: use mix. > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 51 > + >

[Mesa-dev] [PATCH 49/50] gallium: add pipe double support enum + docs

2018-03-12 Thread Dave Airlie
From: Dave Airlie --- src/gallium/docs/source/screen.rst | 4 +++- src/gallium/include/pipe/p_defines.h | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst index

[Mesa-dev] [PATCH 45/50] glsl: Add a lowering pass for 64-bit float frac()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_instructions.cpp | 25 + 1 file changed, 25 insertions(+) diff --git a/src/compiler/glsl/lower_instructions.cpp

[Mesa-dev] [PATCH 44/50] glsl: Add a lowering pass for 64-bit float ceil()

2018-03-12 Thread Dave Airlie
From: Elie Tournier [airlied: handle vector case] Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_instructions.cpp | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 24/50] glsl: Add a lowering pass for 64-bit float less()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 4 +++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 48/50] glsl: add lowering for mod64()

2018-03-12 Thread Dave Airlie
From: Elie Tournier This lowers to floor using the same code as the float lowering, it also fixes things to avoid creating more instructions that need lowering. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_optimization.h | 1 +

[Mesa-dev] [PATCH 35/50] glsl: Add a lowering pass for 64-bit float round()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 34/50] glsl: Add a lowering pass for 64-bit float trunc()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 39/50] glsl: Add a lowering pass for 64-bit float gequal()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_64bit.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/glsl/lower_64bit.cpp index

[Mesa-dev] [PATCH 29/50] glsl: Add a lowering pass for 64-bit float d2i()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 27/50] glsl: Add a lowering pass for 64-bit float d2u()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 33/50] glsl: Add a lowering pass for 64-bit float sqrt()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

2018-03-12 Thread Dave Airlie
On 13 March 2018 at 14:24, Dave Airlie wrote: > This is the main code for the soft fp64 work. It's mostly Elie's > code with a bunch of changes by me. > All the patches are in my tree here, along with some other bits:

[Mesa-dev] [PATCH 50/50] st/glsl: enable fp64 lowering support

2018-03-12 Thread Dave Airlie
From: Dave Airlie This enables fp64 emulation if the driver requests it with PIPE_CAP_DOUBLES set to PIPE_DOUBLES_EMULATE. It moves the mat->vec lowering earlier as we don't want to hit any matrix operation in double lowering, and if we lower div->rcp we end up getting the

[Mesa-dev] [PATCH 47/50] glsl: add a lowering pass for dfma to dmuladd.

2018-03-12 Thread Dave Airlie
From: Dave Airlie Just lowering dfma to dmuladd for now, I don't think it will matter for anything we care about. This also fixes the double dot to fma lowering to take this flag into account and avoid creating further fma's. Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 46/50] glsl: Add a lowering pass for 64-bit float rsq()

2018-03-12 Thread Dave Airlie
From: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_instructions.cpp | 25 + 2 files changed, 26 insertions(+) diff --git a/src/compiler/glsl/ir_optimization.h

[Mesa-dev] [PATCH 42/50] glsl: Add a lowering pass for 64-bit float max()

2018-03-12 Thread Dave Airlie
From: Elie Tournier [airlied: update to handle max(dvec, double) case] Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_instructions.cpp | 27 +++ 1 file changed, 27 insertions(+) diff --git

[Mesa-dev] [PATCH 43/50] glsl: Add a lowering pass for 64-bit float floor()

2018-03-12 Thread Dave Airlie
From: Elie Tournier [airlied: handle vector cases] Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_instructions.cpp | 34 ++-- 2 files changed, 33

[Mesa-dev] [PATCH 32/50] glsl: Add a lowering pass for 64-bit float f2d()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 40/50] glsl: Add a lowering pass for 64-bit float nequal()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/lower_64bit.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_64bit.cpp b/src/compiler/glsl/lower_64bit.cpp index

[Mesa-dev] [PATCH 41/50] glsl: Add a lowering pass for 64-bit float min()

2018-03-12 Thread Dave Airlie
From: Elie Tournier [airlied: update to handle min(dvec, double) case. Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 1 + src/compiler/glsl/lower_instructions.cpp | 33 2

[Mesa-dev] [PATCH 38/50] glsl/lower_64bit: lower d2b using comparison

2018-03-12 Thread Dave Airlie
From: Dave Airlie This just does a compare to 0 and inverts the result to lower d2b. Not 100% sure this is always correct, but it passes piglit --- src/compiler/glsl/lower_64bit.cpp | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 30/50] glsl: Add a lowering pass for 64-bit float i2d()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 31/50] glsl: Add a lowering pass for 64-bit float d2f()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 4 +++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 37/50] glsl/lower_64bit: handle any/all operations

2018-03-12 Thread Dave Airlie
From: Dave Airlie This just splits them out and combines the results. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_64bit.cpp | 61 ++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 25/50] glsl: Add a lowering pass for 64-bit float add()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 4 +++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 23/50] glsl: Add a lowering pass for 64-bit float equal()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 22/50] glsl: Add a lowering pass for 64-bit float sign()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 2 +- src/compiler/glsl/lower_64bit.cpp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h

[Mesa-dev] [PATCH 28/50] glsl: Add a lowering pass for 64-bit float u2d()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Handle non 64bit sources (airlied) Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 26/50] glsl: Add a lowering pass for 64-bit float mul()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 2 +- src/compiler/glsl/lower_64bit.cpp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_optimization.h

[Mesa-dev] [PATCH 12/50] glsl: Add "built-in" functions to do int_to_fp64(int) (v2)

2018-03-12 Thread Dave Airlie
From: Elie Tournier v2: use mix Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 129 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3

[Mesa-dev] [PATCH 21/50] glsl: Add a lowering pass for 64-bit float neg()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/lower_64bit.cpp | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 16/50] glsl: Add "built-in" functions to do trunc(fp64) (v2)

2018-03-12 Thread Dave Airlie
From: Elie Tournier v2: use mix. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 62 + src/compiler/glsl/builtin_functions.cpp | 4 +++ src/compiler/glsl/builtin_functions.h |

[Mesa-dev] [PATCH 17/50] glsl: Add "built-in" functions to do round(fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 225 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 +

[Mesa-dev] [PATCH 15/50] glsl: Add "built-in" functions to do sqrt(fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier This currently uses fp64->fp32, sqrt(fp32), fp32->fp64. [airlied: The code is include from soft float for doing proper sqrt64 but it needs to be decided if we need to pursue this and how to optimise it better.] Signed-off-by: Elie Tournier

[Mesa-dev] [PATCH 18/50] glsl: Add "built-in" functions to do rcp(fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 1829 +++ src/compiler/glsl/builtin_functions.cpp |4 + src/compiler/glsl/builtin_functions.h |3 +

[Mesa-dev] [PATCH 20/50] glsl: add define to lower all double operations

2018-03-12 Thread Dave Airlie
From: Dave Airlie We will add all fp64 ops to this for now, later drivers may want to only lower some. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_optimization.h | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 19/50] glsl: Add a lowering pass for 64-bit float abs()

2018-03-12 Thread Dave Airlie
From: Elie Tournier Squashed with: glsl/lower_64bit: fix return type conversion (airlied) Only do conversion for the 64-bit types, add a path to do result merging without conversion. Signed-off-by: Elie Tournier ---

[Mesa-dev] [PATCH 11/50] glsl: Add "built-in" functions to do fp64_to_int(fp64) (v2)

2018-03-12 Thread Dave Airlie
From: Elie Tournier v2: use mix Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 179 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3

[Mesa-dev] [PATCH 04/50] glsl: Add "built-in" functions to do eq(fp64, fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 104 src/compiler/glsl/builtin_functions.cpp | 4 ++ src/compiler/glsl/builtin_functions.h | 3 +

[Mesa-dev] [PATCH 02/50] glsl: Add "built-in" functions to do neg(fp64) (v2)

2018-03-12 Thread Dave Airlie
From: Elie Tournier v2: use mix. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 51 + src/compiler/glsl/builtin_functions.cpp | 4 +++ src/compiler/glsl/builtin_functions.h |

[Mesa-dev] soft fp64 support - main body (glsl/gallium)

2018-03-12 Thread Dave Airlie
This is the main code for the soft fp64 work. It's mostly Elie's code with a bunch of changes by me. This patchset has all the glsl lowering code. (using float64.glsl, yes I know checked in files are bad, but not bad enough for anyone to have solved int64.glsl yet, so we have a precedent). It

[Mesa-dev] [PATCH 10/50] glsl: Add "built-in" functions to do uint_to_fp64(uint)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 71 + src/compiler/glsl/builtin_functions.cpp | 4 ++ src/compiler/glsl/builtin_functions.h | 3 ++

[Mesa-dev] [PATCH 09/50] glsl: Add "built-in" functions to do fp64_to_uint(fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 209 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 +

[Mesa-dev] [PATCH 13/50] glsl: Add "built-in" functions to do fp64_to_fp32(fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 388 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 +

[Mesa-dev] [PATCH 08/50] glsl: Add "built-in" functions to do mul(fp64, fp64) (v2)

2018-03-12 Thread Dave Airlie
From: Elie Tournier v2: use mix Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 1348 +++ src/compiler/glsl/builtin_functions.cpp |4 + src/compiler/glsl/builtin_functions.h |

[Mesa-dev] [PATCH 14/50] glsl: Add "built-in" functions to do fp32_to_fp64(fp32)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 192 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 +

[Mesa-dev] [PATCH 05/50] glsl: add utility function to extract 64-bit sign.

2018-03-12 Thread Dave Airlie
From: Elie Tournier [airlied: left over from dropping le64] Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 18 ++ src/compiler/glsl/float64.glsl | 7 +++ 2 files changed, 25 insertions(+)

[Mesa-dev] [PATCH 03/50] glsl: Add "built-in" function to do sign(fp64) (v2)

2018-03-12 Thread Dave Airlie
From: Elie Tournier v2: use mix. Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 28 src/compiler/glsl/builtin_functions.cpp | 4 src/compiler/glsl/builtin_functions.h | 3

[Mesa-dev] [PATCH 01/50] glsl: Add "built-in" function to do abs(fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/Makefile.sources | 1 + src/compiler/glsl/builtin_float64.h | 19 +++ src/compiler/glsl/builtin_functions.cpp | 4

[Mesa-dev] [PATCH 06/50] glsl: Add "built-in" functions to do lt(fp64, fp64)

2018-03-12 Thread Dave Airlie
From: Elie Tournier Signed-off-by: Elie Tournier --- src/compiler/glsl/builtin_float64.h | 135 src/compiler/glsl/builtin_functions.cpp | 4 + src/compiler/glsl/builtin_functions.h | 3 +

[Mesa-dev] [PATCH] r600: fix abs for op3 sources

2018-03-12 Thread sroland
From: Roland Scheidegger If a src was referencing the same temp as the dst, the per-component copy code didn't work. e.g. cndge r0.xy, r0.xx, |r2|, r3 got expanded into mov r12.x, |r2| cndge r0.x, r0.x, r12, r3 mov r12.y, |r2| cndge r0.y, r0.x, r12, r3 hence for

[Mesa-dev] [PATCH 1/2] r600: add simple ib dumping under a env var

2018-03-12 Thread Dave Airlie
From: Dave Airlie I've used this a lot when developing, and keep rebasing it around a lot, seems like it could be useful to have upstream. R600_DUMP witll make lots of /tmp/rad_dump_.txt for every command submitted to the hw. Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 2/2] r600: assert on double opcodes if we hit them

2018-03-12 Thread Dave Airlie
From: Dave Airlie This asserts on any double opcocde getting into the shader assembler on gpus that don't support them. This is a better way to find holes in the soft fp64 coverage than gpu hangs. Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Dylan Baker
Quoting Mark Janes (2018-03-12 14:59:29) > Dylan Baker writes: > > > Quoting Mark Janes (2018-03-12 12:40:47) > >> Handling a screw-up could be done by maintainers by force-pushing the > >> commits off the WIP branch, and adding some annotations that prevent the > >> broken

[Mesa-dev] [Bug 105444] Enable GL disk shader cache when transform feedback is enabled

2018-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105444 Jordan Justen changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #1

Re: [Mesa-dev] [PATCH] meson: don't use compiler.has_header

2018-03-12 Thread Matt Turner
Acked-by: Matt Turner Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-03-12 Thread Keith Packard
Jason Ekstrand writes: > On Fri, Feb 23, 2018 at 3:43 PM, Keith Packard wrote: > > Once we're sure that's what we want, create an MR against the spec that > just adds enough to the XML to reserve your extension number. That will > get merged almost

Re: [Mesa-dev] [PATCH 2/2] main/program_binary: In ProgramBinary set link status as LINKING_SKIPPED

2018-03-12 Thread Jordan Justen
On 2018-03-12 14:51:56, Timothy Arceri wrote: > This only seems to be needed by i965. Alternative can't you just remove the: > > if (prog->sh.data->LinkStatus != LINKING_SKIPPED) >goto fail; > > from brw_disk_cache_upload_program() and let the cache search do its job? > > I believe

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Mark Janes
Dylan Baker writes: > Quoting Mark Janes (2018-03-12 12:40:47) >> Handling a screw-up could be done by maintainers by force-pushing the >> commits off the WIP branch, and adding some annotations that prevent the >> broken commit from being re-applied to WIP by automation. >>

Re: [Mesa-dev] [PATCH 1/2] glsl/serialize: Save shader program metadata sha1

2018-03-12 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 12/03/18 11:25, Jordan Justen wrote: When the shader cache is used, this can be generated. In fact, the shader cache uses this sha1 to lookup the serialized GL shader program. If a GL shader program is restored with ProgramBinary, the

Re: [Mesa-dev] [PATCH 2/2] main/program_binary: In ProgramBinary set link status as LINKING_SKIPPED

2018-03-12 Thread Timothy Arceri
This only seems to be needed by i965. Alternative can't you just remove the: if (prog->sh.data->LinkStatus != LINKING_SKIPPED) goto fail; from brw_disk_cache_upload_program() and let the cache search do its job? I believe its possible to end up linking the GLSL IR i.e.

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

2018-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105464 --- Comment #2 from Philip Rebohle --- Created attachment 138044 --> https://bugs.freedesktop.org/attachment.cgi?id=138044=edit Tessellation demo screenshot -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH 2/3] nv50, nvc0: Support BGRX1010102 and RGBX1010102 for sampling.

2018-03-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin It should be possible to get rendering on them BTW, with a bit of state fixups for DST_ALPHA blending. Just haven't gotten around to it. On Mon, Mar 12, 2018 at 4:45 PM, Mario Kleiner wrote: > Add them as usable for

[Mesa-dev] [PATCH 2/3] nv50, nvc0: Support BGRX1010102 and RGBX1010102 for sampling.

2018-03-12 Thread Mario Kleiner
Add them as usable for textures, so they can be used by Wayland drm in 10 bpc mode and for X11 compositing under GLX and EGL. We need these formats to be supported at least for sampling, otherwise GLX_texture_from_pixmap and the equivalent EGL image extension won't work with X11 drawables of depth

[Mesa-dev] More pieces for xbgr2101010/abgr2101010 support.

2018-03-12 Thread Mario Kleiner
These are needed together with Daniel Stone's 10 bpc bgr patches to make nouveau's 10 bpc support more complete. All tested on nouveau on a nv96 as primary/display gpu and also with a radeon as prime renderoffload gpu, and then the other way round with radeon primary + nouveau renderoffload. Also

[Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

2018-03-12 Thread Mario Kleiner
We need to distinguish if a backing pixmap of a window is XRGB2101010 or XBGR2101010, as different gpu hw supports different formats. NVidia hw prefers XBGR, whereas AMD and Intel are happy with XRGB. We use the red channel mask of the visual to distinguish at depth 30, but because we can't

[Mesa-dev] [PATCH 1/3] wayland-drm: Expose server-side xbgr2101010 and abgr2101010 formats.

2018-03-12 Thread Mario Kleiner
This way the wayland server can signal support for these formats to wayland EGL clients. This is currently used by nouveau for 10 bpc support. Tested with glmark2-wayland and glmark2-es2-wayland under weston to now expose 10 bpc EGL configs under nouveau. Signed-off-by: Mario Kleiner

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Dylan Baker
Quoting Mark Janes (2018-03-12 12:40:47) > Dylan Baker writes: > > > Quoting Emil Velikov (2018-03-12 08:38:31) > >> On 12 March 2018 at 11:31, Juan A. Suarez Romero > >> wrote: > >> > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > >> >> Ilia

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

2018-03-12 Thread Dave Airlie
On 13 March 2018 at 05:58, Marek Olšák wrote: > On Mon, Mar 12, 2018 at 3:05 PM, Dave Airlie wrote: >> On 13 March 2018 at 03:59, Marek Olšák wrote: >>> This is good, though some older distros only have libxcb 1.11. >> >> On those distros

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

2018-03-12 Thread Marek Olšák
On Mon, Mar 12, 2018 at 3:05 PM, Dave Airlie wrote: > On 13 March 2018 at 03:59, Marek Olšák wrote: >> This is good, though some older distros only have libxcb 1.11. > > On those distros you likely just want to --disable-dri3 anyways. > > Dave. Good one. I

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Mark Janes
Emil Velikov writes: > On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >>> - Patches are applied to proposed stable branch by automation when the >>>associated commit is pushed to

Re: [Mesa-dev] [PATCH v2 1/2] spirv: fix OpSConvert when the source is unsigned

2018-03-12 Thread Jason Ekstrand
On Mon, Mar 5, 2018 at 10:21 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > OpSConvert interprets the MSB of the unsigned value as the sign bit and > extends it to the new type. If we want to preserve the value, we need > to use OpUConvert opcode. > > v2: > - No need to check dst

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Mark Janes
Dylan Baker writes: > Quoting Emil Velikov (2018-03-12 08:38:31) >> On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> >> Ilia Mirkin writes: >> >> >> >> > On Tue,

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

2018-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105464 --- Comment #1 from Philip Rebohle --- Created attachment 138038 --> https://bugs.freedesktop.org/attachment.cgi?id=138038=edit Witcher 3 hull shader which may suffer from the same issue FWIW, the tessellation

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

2018-03-12 Thread Emil Velikov
On 12 March 2018 at 18:48, Dave Airlie wrote: > On 13 March 2018 at 03:24, Emil Velikov wrote: >> Hi Dave, >> >> On 11 March 2018 at 23:26, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> I'm not sure everyone

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

2018-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105464 Bug ID: 105464 Summary: Reading per-patch outputs in Tessellation Control Shader returns undefined values Product: Mesa Version: git Hardware: Other OS:

Re: [Mesa-dev] [PATCH 4/5 v6] clover/llvm: Add get_[cl|language]_version, validation and some helpers

2018-03-12 Thread Aaron Watry
ping. --Aaron On Thu, Mar 1, 2018 at 8:02 PM, Aaron Watry wrote: > Used to calculate the default CLC language version based on the --cl-std in > build args > and the device capabilities. > > According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by: > 1) If

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

2018-03-12 Thread Dave Airlie
On 13 March 2018 at 03:59, Marek Olšák wrote: > This is good, though some older distros only have libxcb 1.11. On those distros you likely just want to --disable-dri3 anyways. Dave. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

2018-03-12 Thread Eric Anholt
Thomas Helland writes: > Walking the whole hash table, inserting entries by hashing them first > is just a really bad idea. We can simply memcpy the whole thing. > --- > src/compiler/glsl/opt_copy_propagation.cpp | 13 -- >

Re: [Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

2018-03-12 Thread Emil Velikov
Hi Thomas, If I were you I'd split out the introduction of clone_acp() into a separate patch. Regardless of that suggestions, there seems to be a bug in this patch. On 12 March 2018 at 17:55, Thomas Helland wrote: > Walking the whole hash table, inserting entries by

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

2018-03-12 Thread Dave Airlie
On 13 March 2018 at 03:24, Emil Velikov wrote: > Hi Dave, > > On 11 March 2018 at 23:26, Dave Airlie wrote: >> From: Dave Airlie >> >> I'm not sure everyone wants to be updating their dri3 in a forced >> march setting, this allows

Re: [Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

2018-03-12 Thread Emil Velikov
Hi Thomas, On 12 March 2018 at 17:55, Thomas Helland wrote: > V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) > --- > src/util/hash_table.c | 22 ++ > src/util/hash_table.h | 2 ++ > 2 files changed, 24 insertions(+) > >

Re: [Mesa-dev] [PATCH RESEND] spirv: Silence compiler warning about undefined srcs[0]

2018-03-12 Thread Ian Romanick
Reviewed-by: Ian Romanick On 03/12/2018 11:21 AM, Eric Anholt wrote: > v2: Use assume() at the srcs[] definition instead. > > Cc: Jason Ekstrand > Cc: Ian Romanick > Cc: Eric Engestrom > ---

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

2018-03-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-03-12 11:05:51) > On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-03-12 07:33:27) > > > We're trying to be -Wundef clean so that we can turn it on (and > > > eventually make it an error). > > > > > > Note that the OMX code

Re: [Mesa-dev] Few issues with Meson

2018-03-12 Thread Dylan Baker
This is my cross file (Arch doesn't have a pkg-config for x86, so I have a shell wrapper that sets PKG_CONFIG_PATH), you'll probably need to adjust some paths ``` [binaries] c = '/usr/bin/gcc' cpp = '/usr/bin/g++' ar = '/usr/bin/ar' strip = '/usr/bin/strip' pkgconfig =

[Mesa-dev] [PATCH] meson: don't use compiler.has_header

2018-03-12 Thread Dylan Baker
Meson's compiler.has_header is completely useless, it only checks that a header exists, not whether it's usable. This creates problems if a header contains a conditional #error declaration, like so: > #if __x86_64__ > # error "Doesn't work with x86_64!" > #endif Compiler.has_header will return

[Mesa-dev] [PATCH RESEND] spirv: Silence compiler warning about undefined srcs[0]

2018-03-12 Thread Eric Anholt
v2: Use assume() at the srcs[] definition instead. Cc: Jason Ekstrand Cc: Ian Romanick Cc: Eric Engestrom --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

2018-03-12 Thread Emil Velikov
On 12 March 2018 at 17:45, Lepton Wu wrote: > Ping. Any more comments or missing stuff to get this commited into master? > As things have changed a bit (the original map/unmap behaviour is preserved) I was hoping that Tomasz will give it another look. If he prefers, I could

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

2018-03-12 Thread Eric Engestrom
On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-03-12 07:33:27) > > We're trying to be -Wundef clean so that we can turn it on (and > > eventually make it an error). > > > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > > of

Re: [Mesa-dev] [PATCH 0/2] Hash table cloning for copy propagation

2018-03-12 Thread Thomas Helland
I've also uploaded this series to my github, if you wan to pull them down from there [1]. I've also uploaded my previously talked about pointer_map to my github account [2]. There's a pointer map, pointer set, and some patches for nir in there, and some for disabling asserts in some places. So

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

2018-03-12 Thread Emil Velikov
Hi Andres, On 12 March 2018 at 15:57, Andres Gomez wrote: > On Mon, 2018-03-12 at 16:45 +0100, Juan A. Suarez Romero wrote: >> > >> On Mon, 2018-03-12 at 17:17 +0200, Andres Gomez wrote: > > [...] > I'm fully on board with your initial suggestion. >> > My proposal would be,

Re: [Mesa-dev] [PATCH] [rfc] dri3: allow building against older xcb

2018-03-12 Thread Marek Olšák
This is good, though some older distros only have libxcb 1.11. Marek On Sun, Mar 11, 2018 at 7:26 PM, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer

Re: [Mesa-dev] Few issues with Meson

2018-03-12 Thread Mike Lothian
Hi Dylan Do you have the link to patch on patchwork? I'll give it a go I'm using meson 0.45 however the cross-file requires more than just defining llvm-config, everything else is normally picked up from what portage is setting in the build environment - though strangely not if clang is used -

[Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

2018-03-12 Thread Thomas Helland
Walking the whole hash table, inserting entries by hashing them first is just a really bad idea. We can simply memcpy the whole thing. --- src/compiler/glsl/opt_copy_propagation.cpp | 13 -- .../glsl/opt_copy_propagation_elements.cpp | 29 -- 2 files

[Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

2018-03-12 Thread Thomas Helland
V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) --- src/util/hash_table.c | 22 ++ src/util/hash_table.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index b7421a0144..f8d5d0f88a 100644 ---

[Mesa-dev] [PATCH 0/2] Hash table cloning for copy propagation

2018-03-12 Thread Thomas Helland
This is a revival of some old patches I had around to improve the compile times in the glsl compiler by reducing the time spend inserting items in the hash table in opt_copy_propagation. I've only rebased this, as my system don't even want to compile anything right now. I also don't remember if it

[Mesa-dev] [PATCH v3] i965/miptree: Use cpu tiling/detiling when mapping

2018-03-12 Thread Scott D Phillips
Rename the (un)map_gtt functions to (un)map_map (map by returning a map) and add new functions (un)map_tiled_memcpy that return a shadow buffer populated with the intel_tiled_memcpy functions. Tiling/detiling with the cpu will be the only way to handle Yf/Ys tiling, when support is added for

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

2018-03-12 Thread Lepton Wu
Ping. Any more comments or missing stuff to get this commited into master? Thanks. On Wed, Mar 7, 2018 at 2:39 PM, Lepton Wu wrote: > If user calls map twice for kms_sw_displaytarget, the first mapped > buffer could get leaked. Instead of calling mmap every time, just >

Re: [Mesa-dev] [v4 PATCH 3/6] spirv_extensions: add list of extensions and to_string method

2018-03-12 Thread Dylan Baker
Adding Jason and Ian here for their opinions. Quoting Alejandro Piñeiro (2018-03-12 01:31:02) > On 11/03/18 18:08, Dylan Baker wrote: > > Quoting Alejandro Piñeiro (2018-03-08 07:00:16) > >> Ideally this should be generated somehow. One option would be gather > >> all the extension dependencies

  1   2   >