Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

On 07/24/2018 10:31 PM, Eric Anholt wrote: Tapani Pälli writes: These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli Aren't you missing the RGB16 and R/RG/RGB/RGBA16_SNORM cases

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

On 07/25/2018 12:45 AM, Nanley Chery wrote: On Tue, Jul 24, 2018 at 08:58:20AM +0300, Tapani Pälli wrote: These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli ---

Re: [Mesa-dev] [PATCH] r600: Scale integer valued texture border colors to float (v2)

Am 24.07.2018 um 21:27 schrieb Gert Wollny: > It seems the hardware always expects floating point border color values > [0,1] for unsigned, and [-1,1] for signed texture component, regardless > of pixel type, but the border colors are passed according to texture > component type. Hence, before

Re: [Mesa-dev] [PATCH] nir: Add a couple of iand/ior optimizations

On Tue, Jul 24, 2018 at 5:41 PM Timothy Arceri wrote: > On 24/07/18 00:10, Jason Ekstrand wrote: > > On Mon, Jul 23, 2018 at 1:08 AM Timothy Arceri > > wrote: > > > > Ian and I have been looking at these type of things recently. Ian has > > started work on

[Mesa-dev] [PATCH v2] clover: Reduce wait_count in abort path.

Trigger waiter condition variable. Passes 'events' CTS on carrizo and turks. v2: reduce to 0 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/event.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp

[Mesa-dev] [PATCH] r600: reduce num compute threads to 1024.

From: Dave Airlie I copied this value from radeonsi, but it was wrong, 1024 seems to be correct answer from looking at gpuinfo. This should fix a few compute shader related hangs. (at least in CTS) Cc: --- src/gallium/drivers/r600/r600_pipe_common.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] clover: Reduce wait_count in abort path.

Jan Vesely writes: > Trigger waiter condition variable. > Passes 'events' CTS on turks and carrizo. > Signed-off-by: Jan Vesely > --- > src/gallium/state_trackers/clover/core/event.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

Hi Chad, On Wed, Jul 25, 2018 at 10:11 AM Chad Versace wrote: > > Problem 1: u_debug_stack_android.cpp transitively included > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > include path. > > Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's libbacktrace headers >

[Mesa-dev] [PATCH] clover: Reduce wait_count in abort path.

Trigger waiter condition variable. Passes 'events' CTS on turks and carrizo. Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/event.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

Reviewed-by: Gurchetan Singh On Tue, Jul 24, 2018 at 6:11 PM Chad Versace wrote: > > Problem 1: u_debug_stack_android.cpp transitively included > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > include path. > > Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's

[Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

Problem 1: u_debug_stack_android.cpp transitively included "pipe/p_compiler.h", but src/gallium/include was missing from the C++ include path. Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's libbacktrace headers require C++11, but the Android toolchain (at least in the Chrome OS SDK) does not

[Mesa-dev] [PATCH v3 1/3] glsl: teach copy_propagation_elements to deal with whole variables

Keep information in acp_entry whether the entry is full or not, and use the ACP in more nodes when visiting the instructions: - add_copy: write whole variables to the ACP state (regardless the type). - visit(ir_dereference_variable *): perform the propagation here if we have a full

[Mesa-dev] [PATCH v3 2/3] glsl: use only copy_propagation_elements

Now that the elements version handles both cases, remove the non-elements version. Reviewed-by: Eric Anholt --- src/compiler/Makefile.sources | 1 - src/compiler/glsl/glsl_parser_extras.cpp | 1 - src/compiler/glsl/ir_optimization.h| 1 -

[Mesa-dev] [PATCH v3 3/3] glsl: propagate full variables eagerly

When creating a new acp_entry after an assignment "c = b", check if b itself has an acp_entry with a full variable associated and use that. This reduces the number of passes the algorithm needs to propagate a value in a chain of assignments. I've tried to make a similar change to the

[Mesa-dev] [PATCH v3 0/3] GLSL Copy Propagation

I've landed most of the patches in the original series. What remains is consolidating the two passes in a single one. Since opt_copy_propagation.cpp would be gone in the end of the series, I've dropped the patch that changes it to handle both paths in an if-statement. Patches 1 and 2 are already

Re: [Mesa-dev] [PATCH] drisw: Fix build on Android Nougat

On Thu, Jul 19, 2018 at 10:43 AM, Chad Versace wrote: > In commit cf54bd5e8, dri_sw_winsys.c began using to support > the new functions putImageShm, getImageShm in DRI_SWRastLoader. But > Android began supporting System V shared memory only in Oreo. Nougat has > no shm headers. > > Fix the

[Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android

u_debug_stack_android.cpp transitively included "pipe/p_compiler.h", but src/gallium/include was missing from the C++ include path. Cc: Gurchetan Singh Cc: Eric Engestrom --- src/gallium/auxiliary/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] drisw: Fix build on Android Nougat

ping for review On Wed 18 Jul 2018, Chad Versace wrote: > In commit cf54bd5e8, dri_sw_winsys.c began using to support > the new functions putImageShm, getImageShm in DRI_SWRastLoader. But > Android began supporting System V shared memory only in Oreo. Nougat has > no shm headers. > > Fix the

Re: [Mesa-dev] [PATCH] nir: Add a couple of iand/ior optimizations

On 24/07/18 00:10, Jason Ekstrand wrote: On Mon, Jul 23, 2018 at 1:08 AM Timothy Arceri > wrote: Ian and I have been looking at these type of things recently. Ian has started work on a pass to cover this stuff without having to add dozens of these types

[Mesa-dev] [PATCH] clover: Don't extend illegal integer types.

It's OK to pass them in memory, which is what kernel invocation needs. Fixes AMDGCN regressions since llvm r337535 ("Reapply "AMDGPU: Fix handling of alignment padding in DAG argument lowering"): scalar-arithmetic-char scalar-arithmetic-uchar scalar-arithemtic-short

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

On July 24, 2018 09:05:05 Dylan Baker wrote: Quoting Jason Ekstrand (2018-07-23 10:46:31) The original pass only looked for load_uniform intrinsics but there are a number of other places that could end up loading a push constant. One obvious omission was images which always implicitly use a

[Mesa-dev] [RFC][PATCH 5/5] Android.mk: Fix checkbuild on Mac builders.

From: Alistair Strachan This is a forward port of a patch in the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/d7f894a7d39e66ca5a832c19edaf175400041aff%5E%21/ The libmesa_dri_common target depends on xgettext unconditionally, but this is not a documented

[Mesa-dev] [RFC][PATCH 1/5] util: Android.mk: Convert implicit rules to static pattern rules

From: Dan Willemsen This is a partial cherry-pick from AOSP's mesa3d tree: https://android.googlesource.com/platform/external/mesa3d/+/a88dcf769eb00a4ffc7183a0396d881a28b5a29b%5E%21/ "We're deprecating make implicit rules, preferring static pattern rules, or just regular rules." Without this

[Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

From: Dan Willemsen This is a forward port of a patch from the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/bd633f11de0c6ac1ed333a28344c74fd9898df9e%5E%21/ Which replaces HOST_OUT_release with HOST_OUT Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall

[Mesa-dev] [RFC][PATCH 2/5] Android.common.mk: define HAVE_TIMESPEC_GET

From: Sumit Semwal This is a forward port of a patch from the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ Since https://android-review.googlesource.com/c/718518 added timespec_get() to bionic, mesa3d doesn't build

[Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

From: Yong Yao This is a forward port of a patch from the AOSP/master branch: https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51c7ae3a033b100a8429ae5415%5E%21/ Which allows boards to provide their own custom copy of mesa. Cc: Rob Herring Cc: Alistair Strachan Cc:

[Mesa-dev] [RFC][PATCH 0/5] Trying to align mesa upstream w/ AOSP/master

In trying to keep the upstream mesa aligned with AOSP, I wanted to submit a few changes that seemed reasonable to upstream. The first two are build fixes that are required to get mesa master building with AOSP. The last three are less critical, but seemed like things we might as well try to sync

Re: [Mesa-dev] [PATCH] st/nir: Fix st_nir_opts() prototype.

Reviewed-by: Timothy Arceri On 25/07/18 07:55, Kenneth Graunke wrote: This wasn't updated for the new scalar ISA parameter. It worked anyway because all the function's callers live in the same file, so it found the correct function. Tim made this external for the new st prog_to_nir

Re: [Mesa-dev] [PATCH v2 10/26] python: Use explicit integer divisions

Quoting Eric Engestrom (2018-07-24 09:42:57) > On Wednesday, 2018-07-11 19:52:31 +0200, Mathieu Bridon wrote: > > In Python 2, divisions return an integer: ^ of integers Since 32 / 4.0 returns 8.0 > > > > >>> 32 / 4 > > 8 > > > > In Python 3 though, they

Re: [Mesa-dev] [PATCH 09/26] python: Use range() instead of xrange()

I merged these, but I accidentally pulled the wrong versions. If anyone ever wonders why some of the review comment wasn't addressed, it was I just applied v1 instead of v2 :/ Dylan Quoting Dylan Baker (2018-07-11 10:13:55) > I've sent 4-9 to our CI, and assuming that it comes back green I'll go

[Mesa-dev] [PATCH v2] intel: Make the decoder handle STATE_BASE_ADDRESS not being a buffer.

Normally, i965 programs STATE_BASE_ADDRESS every batch, and puts all state for a given base in a single buffer. I'm working on a prototype which emits STATE_BASE_ADDRESS only once at startup, where each base address is a fixed 4GB region of the PPGTT. State may live in many buffers in that 4GB

[Mesa-dev] [PATCH] st/nir: Fix st_nir_opts() prototype.

This wasn't updated for the new scalar ISA parameter. It worked anyway because all the function's callers live in the same file, so it found the correct function. Tim made this external for the new st prog_to_nir translator, which got reverted, but which I'd like to land eventually. So, fix the

Re: [Mesa-dev] [PATCH 2/2] intel: Make the decoder handle STATE_BASE_ADDRESS not being a buffer.

On Tuesday, July 17, 2018 9:40:29 AM PDT Lionel Landwerlin wrote: > On 11/07/18 19:25, Kenneth Graunke wrote: > > Normally, i965 programs STATE_BASE_ADDRESS every batch, and puts all > > state for a given base in a single buffer. > > > > I'm working on a prototype which emits STATE_BASE_ADDRESS

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

On Tue, Jul 24, 2018 at 08:58:20AM +0300, Tapani Pälli wrote: > These bits were missing, found when extending the Piglit test. > > Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" > Signed-off-by: Tapani Pälli > --- > src/mesa/main/fbobject.c | 10 +++--- > 1 file changed,

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #41 from Roland Scheidegger --- (In reply to Ben Crocker from comment #40) > 'make check'/lp_test_arit fails in exactly the same way when I run it > on a ppc64le machine. That is sort of expected I guess. We only use "arch

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #40 from Ben Crocker --- 'make check'/lp_test_arit fails in exactly the same way when I run it on a ppc64le machine. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] intel: tools: dump: only store device id on success

We might fail on master node drm fd because we won't have the right permissions. Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_dump_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/intel_dump_gpu.c b/src/intel/tools/intel_dump_gpu.c

Re: [Mesa-dev] [PATCH] r600: Scale integer valued texture border colors to float (v2)

whitespace errors were fixed locally best, Gert Am Dienstag, den 24.07.2018, 21:27 +0200 schrieb Gert Wollny: > It seems the hardware always expects floating point border color > values > [0,1] for unsigned, and [-1,1] for signed texture component, > regardless > of pixel type, but the border

Re: [Mesa-dev] [PATCH] mesa: allow indirect draws with the default VAO and compatibility profile

Marek Olšák writes: > From: Marek Olšák Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

Tapani Pälli writes: > These bits were missing, found when extending the Piglit test. > > Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" > Signed-off-by: Tapani Pälli Aren't you missing the RGB16 and R/RG/RGB/RGBA16_SNORM cases here? They aren't required for rendering, but

[Mesa-dev] [PATCH] r600: Scale integer valued texture border colors to float (v2)

It seems the hardware always expects floating point border color values [0,1] for unsigned, and [-1,1] for signed texture component, regardless of pixel type, but the border colors are passed according to texture component type. Hence, before submitting the border color, convert and scale it these

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #39 from Ben Crocker --- Note that all the lp_test_format failures seem to have to do with packing/unpacking of "exotic: formats, while the lp_test_arit failures have to do with rounding. FAIL: lp_test_format

Re: [Mesa-dev] [Mesa-stable] [PATCH] nir/serialize: Alloc constants off the variable

Please add the bugzilla reference for 107366 Tested-by: Mark Janes Jason Ekstrand writes: > nir_sweep assumes that constants area always allocated off the variable > to which they belong. Violating this assumption causes them to get > freed early and leads to use-after-free bugs. > > Cc:

Re: [Mesa-dev] [PATCH] nir/serialize: Alloc constants off the variable

On 24/07/18 19:02, Jason Ekstrand wrote: nir_sweep assumes that constants area always allocated off the variable to which they belong. Violating this assumption causes them to get freed early and leads to use-after-free bugs. Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Lionel

[Mesa-dev] [PATCH] nir/serialize: Alloc constants off the variable

nir_sweep assumes that constants area always allocated off the variable to which they belong. Violating this assumption causes them to get freed early and leads to use-after-free bugs. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/nir/nir_serialize.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

On 24/07/18 18:34, Kenneth Graunke wrote: On Tuesday, July 24, 2018 5:34:57 AM PDT Lionel Landwerlin wrote: That looks correct to me (and we do the same in Anv). Also a bit baffled that we haven't run into issues earlier :( But would be good to have Ken's Rb too. Thanks a lot! Reviewed-by:

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

On Tuesday, July 24, 2018 5:34:57 AM PDT Lionel Landwerlin wrote: > That looks correct to me (and we do the same in Anv). > Also a bit baffled that we haven't run into issues earlier :( > > But would be good to have Ken's Rb too. > > Thanks a lot! > > Reviewed-by: Lionel Landwerlin Yeah, this

Re: [Mesa-dev] [PATCH v2 1/3] i965: Sweep NIR after linking phase to free held memory

This patch segfaults when both of the following environment variables are set: NIR_TEST_CLONE=true NIR_TEST_SERIALIZE=true Dylan -- please do not apply this to any stable branch until this bug has been resolved: https://bugs.freedesktop.org/show_bug.cgi?id=107366 -Mark Danylo Piliaiev

Re: [Mesa-dev] [PATCH 1/7] mesa: add ASTC 2D LDR decoder

On Tue, Jul 24, 2018 at 6:17 AM, Eric Engestrom wrote: > On Monday, 2018-07-23 19:52:01 -0400, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/Makefile.sources |2 + >> src/mesa/main/formats.c| 42 + >> src/mesa/main/formats.h|3 + >>

Re: [Mesa-dev] [PATCH 2/2] i965: Context aware user space EU control through application

> -Original Message- > From: Landwerlin, Lionel G > Sent: Tuesday, July 24, 2018 10:24 PM > To: Marathe, Yogesh ; Chris Wilson wilson.co.uk>; Muthukumar, Aravindan ; > mesa-dev@lists.freedesktop.org > Cc: Diwakar, Praveen > Subject: Re: [Mesa-dev] [PATCH 2/2] i965: Context aware user

Re: [Mesa-dev] [PATCH 2/2] i965: Context aware user space EU control through application

On 24/07/18 17:41, Marathe, Yogesh wrote: Lionel, Chris, -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Lionel Landwerlin Sent: Friday, July 20, 2018 3:31 PM To: Chris Wilson ; Muthukumar, Aravindan ; mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] gallium/tests: Don't ignore S3TC errors.

On 24 July 2018 at 13:58, Jose Fonseca wrote: > Now we do full S3TC decompression they should no longer fail. > --- > src/gallium/tests/unit/u_format_test.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/gallium/tests/unit/u_format_test.c >

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

On Tuesday, 2018-07-24 19:44:14 +0300, Andres Gomez wrote: > On Tue, 2018-07-24 at 09:07 -0700, Dylan Baker wrote: > > Quoting Emil Velikov (2018-07-24 08:56:55) > > > On 24 July 2018 at 11:29, Eric Engestrom wrote: > > > > On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: > > > > >

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

On Tue, 2018-07-24 at 09:07 -0700, Dylan Baker wrote: > Quoting Emil Velikov (2018-07-24 08:56:55) > > On 24 July 2018 at 11:29, Eric Engestrom wrote: > > > On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: > > > > Until now, the needed bits were wrongly included in linux/memfd.h > > >

Re: [Mesa-dev] [PATCH v2 10/26] python: Use explicit integer divisions

On Wednesday, 2018-07-11 19:52:31 +0200, Mathieu Bridon wrote: > In Python 2, divisions return an integer: > > >>> 32 / 4 > 8 > > In Python 3 though, they return floats: > > >>> 32 / 4 > 8.0 > > However, Python 3 has an explicit integer division operator: > > >>> 32 // 4 >

Re: [Mesa-dev] [PATCH 2/2] i965: Context aware user space EU control through application

Lionel, Chris, > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Lionel Landwerlin > Sent: Friday, July 20, 2018 3:31 PM > To: Chris Wilson ; Muthukumar, Aravindan > ; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 2/2]

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

On 24 July 2018 at 17:07, Dylan Baker wrote: > Quoting Emil Velikov (2018-07-24 08:56:55) >> On 24 July 2018 at 11:29, Eric Engestrom wrote: >> > On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: >> >> Until now, the needed bits were wrongly included in linux/memfd.h >> >> >> >> Since

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

Hi Danylo, Having a closer look inspired by Eric's comments On 24 July 2018 at 15:37, Danylo Piliaiev wrote: >>> Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. >>> As you bump the libdrm version: - drop the existing DRM_EVENT_CONTEXT_VERSION guard - swap the

Re: [Mesa-dev] [PATCH v2] egl: Fix missing clamping in eglSetDamageRegionKHR

Quoting Eric Engestrom (2018-07-24 07:55:03) > On Tuesday, 2018-07-24 18:15:54 +0530, Harish Krupo wrote: > > Hi Eric, > > > > Eric Engestrom writes: > > > > > On Sunday, 2018-07-08 12:53:00 +0530, Harish Krupo wrote: > > >> Clamp the x and y co-ordinates of the rectangles. > > >> > > >> v2:

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

Quoting Jason Ekstrand (2018-07-23 10:46:31) > The original pass only looked for load_uniform intrinsics but there are > a number of other places that could end up loading a push constant. One > obvious omission was images which always implicitly use a push constant. > Legacy VS clip planes also

[Mesa-dev] [Bug 107170] Build fails if building against X server/libxrandr with no leases support

https://bugs.freedesktop.org/show_bug.cgi?id=107170 --- Comment #2 from Emil Velikov --- Note that the xcb_randr API is not provided by libXrandr but xcb-randr ;-) A simple version check of the latter should fix things. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

On 24 July 2018 at 11:29, Eric Engestrom wrote: > On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: >> Until now, the needed bits were wrongly included in linux/memfd.h >> >> Since Travis' sys/syscall.h doesn't provide the SYS_memfd_create, we The definition has moved across libc

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

On Friday, 2018-07-13 16:57:34 +0300, Danylo Piliaiev wrote: > Make xlease automatically enabled only if xcb-randr >= 1.13, > check its version if manually enabled. > > Enable VK_EXT_display_control only when libdrm >= 2.4.89 > > Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler.

Re: [Mesa-dev] [PATCH] docs: move releases from Fridays to Wednesdays

On 19 July 2018 at 14:00, Andres Gomez wrote: > As discussed at: > https://lists.freedesktop.org/archives/mesa-dev/2018-March/188525.html > > Cc: Emil Velikov > Cc: Juan A. Suarez Romero > Cc: Dylan Baker > Cc: Ian Romanick > Cc: Carl Worth > Cc: Mark Janes > Signed-off-by: Andres Gomez

Re: [Mesa-dev] [PATCH] docs: update calendar to match the 18.2 plan with the one announced

On 19 July 2018 at 14:03, Andres Gomez wrote: > Additionally, I've extended the 18.1 cycle by one more release, > tentatively assigned to Dylan, due to the ~2 weeks delay for 18.2. > > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez Acked-by: Emil

Re: [Mesa-dev] [PATCH] mesa: Fix copy-paste error in ConservativeRasterDilateRange initialization

On 22 July 2018 at 18:27, Rhys Perry wrote: > Reviewed-by: Rhys Perry > > I'm not sure how much that's worth though, so I think I'll wait a few > days being pushing it (I assume you can't push it) and see if anyone > objects. > Please add the following as you do: Fixes: 4580617509d ("mesa: add

Re: [Mesa-dev] [PATCH] docs: correct typo in the submitting patches instructions

On 19 July 2018 at 14:02, Andres Gomez wrote: > Cc: Emil Velikov > Cc: Eric Engestrom > Signed-off-by: Andres Gomez > --- > docs/submittingpatches.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html > index

Re: [Mesa-dev] [PATCH] swrast: remove unneeded _glapi_check_multithread() call

On 18 July 2018 at 19:34, Eric Anholt wrote: > Emil Velikov writes: > >> From: Emil Velikov >> >> With commit c6c0f947142, back in 2006 Brian removed the >> _glapi_check_multithread() call from core mesa - _mesa_make_current. >> >> He moved it to a DRI loader (type of) decision - with

Re: [Mesa-dev] [PATCH v2] egl: Fix missing clamping in eglSetDamageRegionKHR

On Tuesday, 2018-07-24 18:15:54 +0530, Harish Krupo wrote: > Hi Eric, > > Eric Engestrom writes: > > > On Sunday, 2018-07-08 12:53:00 +0530, Harish Krupo wrote: > >> Clamp the x and y co-ordinates of the rectangles. > >> > >> v2: Clamp width/height after converting to co-ordinates > >>

Re: [Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

On 17 July 2018 at 11:32, Robert Foss wrote: > This failure mode is a bit tricky to debug and manifests itself > later as a null pointer dereference, for which finding the origin > is needlessly tricky. > > Signed-off-by: Robert Foss Reviewed-by: Emil Velikov Ever so mildly related:

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

Hi Emil, On 24.07.18 17:10, Emil Velikov wrote: Hi Danylo, On 13 July 2018 at 14:57, Danylo Piliaiev wrote: Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

Hi Danylo, On 13 July 2018 at 14:57, Danylo Piliaiev wrote: > Make xlease automatically enabled only if xcb-randr >= 1.13, > check its version if manually enabled. > > Enable VK_EXT_display_control only when libdrm >= 2.4.89 > > Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. >

Re: [Mesa-dev] [PATCH] gallium/tests: Don't ignore S3TC errors.

Am 24.07.2018 um 14:58 schrieb Jose Fonseca: > Now we do full S3TC decompression they should no longer fail. > --- > src/gallium/tests/unit/u_format_test.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/gallium/tests/unit/u_format_test.c >

[Mesa-dev] [PATCH v3] nir/linker: Add the start of a pure-NIR linker for XFB

From: Neil Roberts v2: ignore names on purpose, for consistency with other places where we are doing the same (Alejandro) v3: changes proposed by Timothy Arceri, implemented by Alejandro Piñeiro: * Remove redundant 'struct active_xfb_varying' * Update several comments, including spec

[Mesa-dev] [PATCH v2] nir/gather_info: Set info.gs.uses_streams

From: Neil Roberts Whenever a non-zero stream is written to it now sets uses_streams to true. This reflects the code in validate_geometry_shader_emissions for GLSL. v2: set uses_streams at gather_info instead that at spirv to nir (Jason Ekstrand) --- src/compiler/nir/nir_gather_info.c | 5

Re: [Mesa-dev] ANDROID: eglCreateImageKHR missing modifiers

Hi Thomasz, thanks for your reply On 21/07/18 04:27, Tomasz Figa wrote: As you noticed, this adds back the dependency on gralloc handle structure. Moreover, it actually adds a dependency on the handle having a binary format compatible with gralloc_gbm_handle_t. This is not something that we

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

Quoting Lionel Landwerlin (2018-07-24 13:45:18) > On 24/07/18 13:42, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2018-07-24 13:34:57) > >> That looks correct to me (and we do the same in Anv). > >> Also a bit baffled that we haven't run into issues earlier :( > > All the allocations should

[Mesa-dev] [PATCH] radv: Still enable inmemory & API level caching if disk cache is not enabled.

That we don't have a background disk cache does not mean we should prevent the app caching anything. CC: --- src/amd/vulkan/radv_pipeline_cache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline_cache.c

[Mesa-dev] [PATCH] freedreno: a2xx: ir2 update

this patch brings a number of changes to ir2: -ir2 now generates CF clauses as necessary during assembly. this simplifies fd2_program/fd2_compiler and is necessary to implement optimization passes -ir2 now has separate vector/scalar instructions. this will make it easier to implementing

[Mesa-dev] [PATCH] gallium/tests: Don't ignore S3TC errors.

Now we do full S3TC decompression they should no longer fail. --- src/gallium/tests/unit/u_format_test.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/tests/unit/u_format_test.c b/src/gallium/tests/unit/u_format_test.c index 6de581fd049..437cc94b757 100644 ---

Re: [Mesa-dev] [PATCH v2] egl: Fix missing clamping in eglSetDamageRegionKHR

Hi Eric, Eric Engestrom writes: > On Sunday, 2018-07-08 12:53:00 +0530, Harish Krupo wrote: >> Clamp the x and y co-ordinates of the rectangles. >> >> v2: Clamp width/height after converting to co-ordinates >> (Ilia Merkin) >> >> Signed-off-by: Harish Krupo >> --- >>

Re: [Mesa-dev] [PATCH v2] egl: Fix missing clamping in eglSetDamageRegionKHR

On Sunday, 2018-07-08 12:53:00 +0530, Harish Krupo wrote: > Clamp the x and y co-ordinates of the rectangles. > > v2: Clamp width/height after converting to co-ordinates > (Ilia Merkin) > > Signed-off-by: Harish Krupo > --- > src/egl/main/eglapi.c | 25 +++-- > 1 file

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

On 24/07/18 13:42, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-24 13:34:57) That looks correct to me (and we do the same in Anv). Also a bit baffled that we haven't run into issues earlier :( All the allocations should be in multiples of page size, alignment less than a page size

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

Quoting Lionel Landwerlin (2018-07-24 13:34:57) > That looks correct to me (and we do the same in Anv). > Also a bit baffled that we haven't run into issues earlier :( All the allocations should be in multiples of page size, alignment less than a page size should be a no-op. Tracking down who

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

That looks correct to me (and we do the same in Anv). Also a bit baffled that we haven't run into issues earlier :( But would be good to have Ken's Rb too. Thanks a lot! Reviewed-by: Lionel Landwerlin On 24/07/18 12:50, Sergii Romantsov wrote: Kernel (for ppgtt) requires memory address to

Re: [Mesa-dev] [PATCH] i965/miptree: Fix can_blit_slice()

Hi Nanley, I'm observing regressions for SKL and BDW which doesn't seem to be solved with this new patch, in git master. Therefore, I've gone ahead and reported: https://bugs.freedesktop.org/show_bug.cgi?id=107359 On Mon, 2018-07-23 at 10:17 -0700, Nanley Chery wrote: > Satisfy the BLT engine's

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

Hello, Kenneth. Looks like you are expert in memory management for i965. Could you, please, point me if that idea of patch is correct and what could i improve? Seems its better somehow to bind it to I915_GTT_PAGE_SIZE... right? On Tue, Jul 24, 2018 at 2:50 PM, Sergii Romantsov <

Re: [Mesa-dev] [PATCH 2/4] radv: generate entrypoints for VK_ANDROID_native_buffer

Hey Mauro, This looks good to me. Signed-off-by: Robert Foss On 2018-07-22 10:14, Mauro Rossi wrote: Patch changes radv entrypoints generator to not skip this extension even though it is set as disabled in the vk.xml Reference: 63525ba730 ("android: enable VK_ANDROID_native_buffer") Fixes:

Re: [Mesa-dev] [PATCH 4/4] android: radv: enable build of vulkan.radv HAL module

Hey Mauro, This looks good to me. Reviewed-by: Robert Foss On 2018-07-22 10:15, Mauro Rossi wrote: src/amd/Android.mk requires to include src/amd/vulkan/Android.mk to enable the build of vulkan.radv module Signed-off-by: Mauro Rossi --- src/amd/Android.mk | 1 + 1 file changed, 1

Re: [Mesa-dev] [PATCH 1/4] radv: move vk_format_table.c to generated sources

Hey Mauro, This looks good to me. Signed-off-by: Robert Foss On 2018-07-22 10:14, Mauro Rossi wrote: Android build system will try to compile vk_format_table.c as a shipped source, but at compile time it will be missing, we move it to generated source, where it belongs Signed-off-by: Mauro

[Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

Kernel (for ppgtt) requires memory address to be aligned to page size (4096). Added such alignment for buffers marked with EXEC_OBJECT_PINNED. -v2: added marking that also fixes initial commit 01058a552294 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106997 Fixes: a363bb2cd0e2 (i965:

[Mesa-dev] [Bug 106922] Tangrams demo: LLVM ERROR: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8

https://bugs.freedesktop.org/show_bug.cgi?id=106922 --- Comment #4 from Christoph Haag --- After seeing https://www.phoronix.com/scan.php?page=news_item=RADV-VK_KHR_16bit_storage I thought I'd try again. I now get a much clearer error: SPIR-V WARNING: In file

Re: [Mesa-dev] [PATCH 1/2] RFC : Context aware user space Resource control

On 23/07/18 10:20, Kedar J Karanje wrote: On Fri, Jul 20, 2018 at 10:59:03AM +0100, Lionel Landwerlin wrote: On 20/07/18 09:32, aravindan.muthuku...@intel.com wrote: diff --git a/src/egl/generate/egl.xml b/src/egl/generate/egl.xml index 9250f93..52b0c9f 100644 --- a/src/egl/generate/egl.xml

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: > Until now, the needed bits were wrongly included in linux/memfd.h > > Since Travis' sys/syscall.h doesn't provide the SYS_memfd_create, we Isn't this a matter of libc version? Isn't the right fix to upgrade the libc in the container

Re: [Mesa-dev] [PATCH 1/7] mesa: add ASTC 2D LDR decoder

On Monday, 2018-07-23 19:52:01 -0400, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/Makefile.sources |2 + > src/mesa/main/formats.c| 42 + > src/mesa/main/formats.h|3 + > src/mesa/main/texcompress_astc.cpp | 1871

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

Reviewed-by: Juan A. Suarez On Thu, 2018-07-19 at 15:33 +0300, Andres Gomez wrote: > Until now, the needed bits were wrongly included in linux/memfd.h > > Since Travis' sys/syscall.h doesn't provide the SYS_memfd_create, we > generate that header manually, including the needed bits to avoid >

Re: [Mesa-dev] [PATCH v2 1/2] i965, anv: Add extra unused character in disk_cache renderer temp string

On 23/07/18 05:27, Jordan Justen wrote: This extra character should not be used by snprintf, but we make it available to verify that we printed the exact number we wanted, and didn't overflow. v2: * Also update Anvil Signed-off-by: Jordan Justen Reviewed-by: Lionel Landwerlin (v1) For

[Mesa-dev] [PATCH v3 1/4] softpipe: Add assert verifying successful pipe_transfer_map

This failure mode is a bit tricky to debug and manifests itself later as a null pointer dereference, for which finding the origin is needlessly tricky. Signed-off-by: Robert Foss Reviewed-by: Brian Paul --- Changes since v2: - Added r-b Changes since v1: - Patch added

[Mesa-dev] [PATCH v3 3/4] platform/android: Enable kms_swrast fallback

Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero value. kms_swrast is also enabled as a fallback for when a driver is not able to be loaded for for a drm node that was opened. Signed-off-by:

[Mesa-dev] [PATCH v3 0/4] Android kms_swrast support

This series implements kms_swrast support for the Android platform. And since having to debug a null pointer dereference, simplify that process for the next guy. As it stands now, any kernel must have the following ioctls flagged with DRM_RENDER_ALLOW[1], which isn't the case in the mainline

  1   2   >