[Mesa-dev] [Bug 109131] cc1plus: error: unrecognized command line option "-std=c++11"

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109131 Bug ID: 109131 Summary: cc1plus: error: unrecognized command line option "-std=c++11" Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-21 Thread Rob Clark
On Fri, Dec 21, 2018 at 11:37 AM Lionel Landwerlin wrote: > > On 19/12/2018 17:19, Kenneth Graunke wrote: > > On Wednesday, December 19, 2018 8:10:49 AM PST Eric Engestrom wrote: > >> The point of this patch is for people to not be able to ignore this, and > >> have to become aware of the existenc

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Roland Scheidegger
Am 22.12.18 um 01:21 schrieb Ilia Mirkin: > > > On Fri, Dec 21, 2018, 19:16 Marek Olšák wrote: > > > > On Fri, Dec 21, 2018, 6:28 PM Kenneth Graunke wrote: > > That seems like a reasonable interface to me. > >

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Ilia Mirkin
On Fri, Dec 21, 2018, 19:16 Marek Olšák > > On Fri, Dec 21, 2018, 6:28 PM Kenneth Graunke wrote: > >> That seems like a reasonable interface to me. >> >> But, I don't think it's backwards compatible. Today, don't state >> trackers set index = 0 and expect all 11 to be returned? We could >> easi

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Marek Olšák
On Fri, Dec 21, 2018, 6:28 PM Kenneth Graunke That seems like a reasonable interface to me. > > But, I don't think it's backwards compatible. Today, don't state > trackers set index = 0 and expect all 11 to be returned? We could > easily change the in-tree state trackers, but not sure about the

Re: [Mesa-dev] [PATCH] intel/compiler: move nir_lower_bool_to_int32 before nir_lower_locals_to_regs

2018-12-21 Thread Rob Clark
jfyi, should be fixed by: https://gitlab.freedesktop.org/mesa/mesa/commit/3453814622040d2638ce7b7c73c046cd4a0119e9 I'm a bit surprised we didn't notice issues sooner BR, -R On Fri, Dec 21, 2018 at 12:39 PM Kristian Høgsberg wrote: > > This regresses at least > dEQP-GLES3.functional.shaders.fu

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Kenneth Graunke
That seems like a reasonable interface to me. But, I don't think it's backwards compatible. Today, don't state trackers set index = 0 and expect all 11 to be returned? We could easily change the in-tree state trackers, but not sure about the other ones. We could always encode the index differen

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #16 from Ilia Mirkin --- (In reply to Emil Velikov from comment #15) > It started with a confusing error message and upon closer look behaviour > seemed fairly different from what you guys wanted. > > Since the current solution is O

[Mesa-dev] [Bug 109129] format_types.h:1220: undefined reference to `_mm256_cvtps_ph'

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109129 Dylan Baker changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |baker.dyla...@gmail.com

Re: [Mesa-dev] [PATCH 6/6] st/nir: Drop unused gl_program parameter in VS input handling helper.

2018-12-21 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Mon, Dec 17, 2018 at 1:37 PM Kenneth Graunke wrote: > Nobody uses this, so let's drop it. This makes the helper callable > from places without a gl_program. > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 ++-- > 1 file changed, 2 inse

[Mesa-dev] [Bug 109129] format_types.h:1220: undefined reference to `_mm256_cvtps_ph'

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109129 --- Comment #2 from Dylan Baker --- Indeed, it seems to be fixed by that patch. I'm planning to make 0.49.1 required for using ICC once it's out anyway (due to a lot of fixes in 0.49.0 and the fix to this in 0.49.1 -- You are receiving this ma

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Marek Olšák
The series looks good. Another way to distinguish between return one and return all is to use "index". index <= 11 returns one. index == ~0 returns all. This is the least intrusive. st/mesa and gallium/hud always want to get one. st/nine and util/u_helpers always want to get all. Marek On Sat, D

Re: [Mesa-dev] [PATCH 3/3] radeonsi: make use of ac_are_tessfactors_def_in_all_invocs()

2018-12-21 Thread Marek Olšák
Nice. For the series: Reviewed-by: Marek Olšák Marek On Mon, Dec 17, 2018 at 8:18 PM Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c > b

Re: [Mesa-dev] [PATCH 2/2] tgsi/scan: correctly walk instructions in tgsi_scan_tess_ctrl()

2018-12-21 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:33 AM Timothy Arceri wrote: > The previous code used a do while loop and continues after walking > a nested loop/if-statement. This means we end up evaluating the > last instruction from the nested block against the whi

[Mesa-dev] [Bug 109129] format_types.h:1220: undefined reference to `_mm256_cvtps_ph'

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109129 --- Comment #1 from Dylan Baker --- This is likely due to: https://github.com/mesonbuild/meson/commit/b335ca2818b3cdb770bb69df25ae527d7ae8e7d3. I'm checking with said patch applied. -- You are receiving this mail because: You are the QA Conta

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 109129] format_types.h:1220: undefined reference to `_mm256_cvtps_ph'

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109129 Bug ID: 109129 Summary: format_types.h:1220: undefined reference to `_mm256_cvtps_ph' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] intel/compiler: move nir_lower_bool_to_int32 before nir_lower_locals_to_regs

2018-12-21 Thread Kristian Høgsberg
This regresses at least dEQP-GLES3.functional.shaders.functions.control_flow.return_in_loop_vertex on freedreno: Test case 'dEQP-GLES3.functional.shaders.functions.control_flow.return_in_loop_vertex'.. deqp-gles3: ../../../mesa/src/compiler/nir/nir_lower_bool_to_int32.c:49: lower_alu_instr: Asser

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #14 from Dylan Baker --- Ilia's explanation is my understanding of the problem, and how we got here. We do print a message saying that "version x.y.z was required because $driver requires it" maybe we can make the message better? Suc

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #13 from Ilia Mirkin --- (In reply to Emil Velikov from comment #12) > Fwiw my suggestion is to follow the autotools build, which was explicitly > requested by Ilia, Dave and Chad - commit > 2b4eaabff01a3a8ea0c4742ac481492092c1ab4f.

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 Emil Velikov changed: What|Removed |Added CC||airl...@freedesktop.org,

Re: [Mesa-dev] [PATCH] pci_ids: add new VegaM pci id

2018-12-21 Thread Liu, Leo
Reviewed-by: Leo Liu On 12/21/18 11:36 AM, Alex Deucher wrote: > Ping? > > On Thu, Dec 20, 2018 at 10:13 AM Alex Deucher wrote: >> Signed-off-by: Alex Deucher >> Cc: mesa-sta...@lists.freedesktop.org >> --- >> include/pci_ids/radeonsi_pci_ids.h | 1 + >> 1 file changed, 1 insertion(+) >> >>

Re: [Mesa-dev] [PATCH] pci_ids: add new VegaM pci id

2018-12-21 Thread Samuel Pitoiset
Feel free to add my Rb if you want to push this now. Reviewed-by: Samuel Pitoiset On 12/20/18 4:12 PM, Alex Deucher wrote: Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pc

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-21 Thread Lionel Landwerlin
On 19/12/2018 17:19, Kenneth Graunke wrote: On Wednesday, December 19, 2018 8:10:49 AM PST Eric Engestrom wrote: The point of this patch is for people to not be able to ignore this, and have to become aware of the existence of Meson and our intention to remove autotools, whenever this may happen

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #11 from Emil Velikov --- Right, let's keep multiple [pkg-config] dependencies out of the topic for now. As you pointed out, there are some glitches that need sorting out. -- You are receiving this mail because: You are the assigne

Re: [Mesa-dev] [PATCH] pci_ids: add new VegaM pci id

2018-12-21 Thread Alex Deucher
Ping? On Thu, Dec 20, 2018 at 10:13 AM Alex Deucher wrote: > > Signed-off-by: Alex Deucher > Cc: mesa-sta...@lists.freedesktop.org > --- > include/pci_ids/radeonsi_pci_ids.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/pci_ids/radeonsi_pci_ids.h > b/include/pci_ids/radeonsi

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-21 Thread Matt Turner
On Fri, Dec 21, 2018 at 1:36 AM Stuart Young wrote: > Yes, but at the moment we have no consensus and a deadlock on the issue. Consensus need not be unanimous. We have consensus. Signed-off-by: Gert Wollny Reviewed-by: Matt Turner Acked-by: Eric Engestrom Acked-by: Kenneth Graunke and I wou

Re: [Mesa-dev] [PATCH] docs: update 18.3 and add 19.x cycles for the release calendar

2018-12-21 Thread Juan A. Suarez Romero
On Tue, 2018-12-18 at 01:09 +0200, Andres Gomez wrote: > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > --- Acked-by: Juan A. Suarez > docs/release-calendar.html | 118 - > 1 file changed, 116 insertions(+), 2 del

Re: [Mesa-dev] [PATCH] docs: update 18.3 and add 19.x cycles for the release calendar

2018-12-21 Thread Emil Velikov
On Mon, 17 Dec 2018 at 23:10, Andres Gomez wrote: > > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > --- Acked-by: Emil Velikov Can you please follow-up and add some notes to the releasing docs: - at any point, next two feature releases are outlined

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-21 Thread Ilia Mirkin
On Fri, Dec 21, 2018 at 9:37 AM Gert Wollny wrote: > > Hello Stuart, > > Am Donnerstag, den 20.12.2018, 13:40 +1100 schrieb Stuart Young: > > Gert/Ilia, > > > > Could this be reduced this from an error to a warning, with the > > command-line option suppressing the warning? > > > > Perhaps as well

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-21 Thread Gert Wollny
Hello Stuart, Am Donnerstag, den 20.12.2018, 13:40 +1100 schrieb Stuart Young: > Gert/Ilia, > > Could this be reduced this from an error to a warning, with the > command-line option suppressing the warning? > > Perhaps as well as producing the warning, the build could sleep for > say 30 seconds

Re: [Mesa-dev] [PATCH] gallivm: abort when trying to use non-existing intrinsic

2018-12-21 Thread Roland Scheidegger
Am 21.12.18 um 15:30 schrieb Jose Fonseca: > On 21/12/2018 14:28, Roland Scheidegger wrote: >> Am 21.12.18 um 08:46 schrieb Jose Fonseca: >>> On 21/12/2018 01:42, srol...@vmware.com wrote: From: Roland Scheidegger Whenever llvm removes an intrinsic (we're using), we're hitting

Re: [Mesa-dev] [PATCH] gallivm: abort when trying to use non-existing intrinsic

2018-12-21 Thread Jose Fonseca
On 21/12/2018 14:28, Roland Scheidegger wrote: Am 21.12.18 um 08:46 schrieb Jose Fonseca: On 21/12/2018 01:42, srol...@vmware.com wrote: From: Roland Scheidegger Whenever llvm removes an intrinsic (we're using), we're hitting segfaults due to llvm doing calls to address 0 in the jitted code i

Re: [Mesa-dev] [PATCH] gallivm: abort when trying to use non-existing intrinsic

2018-12-21 Thread Roland Scheidegger
Am 21.12.18 um 08:46 schrieb Jose Fonseca: > On 21/12/2018 01:42, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Whenever llvm removes an intrinsic (we're using), we're hitting segfaults >> due to llvm doing calls to address 0 in the jitted code instead. >> However, Jose figured out w

Re: [Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

2018-12-21 Thread Lionel Landwerlin
Looking at this, I think the issue is more in anv_blorp.c. All of the mcs/ccs ops we're doing use the anv_image which can be a different format from the anv_image_view we're dealing with. In this particular bug, the image is R8G8B8A8_UNORM while the view is R8G8B8A8_SRGB. I think this might be

Re: [Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

2018-12-21 Thread Jason Ekstrand
This isn't quite true. Fast-clear without CCS compression (also known as CCS_D) is supported on gen9. There is, however, a bug with blending and non-0/1 clear colors that we don't currently bother handling in anv. See also: https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/mesa/drivers/

[Mesa-dev] [PATCH] anv: gen9 doesn't support fast clear on single-sampled SRGB buffers

2018-12-21 Thread Samuel Iglesias Gonsálvez
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108911 Signed-off-by: Samuel Iglesias Gonsálvez --- Lionel, I have doubts if this is only for gen9 or it should be gen9+. Can you confirm on gen10 if the sRGB bug is happening there and if this fixes it? (You would need to adapt the GEN_GEN

Re: [Mesa-dev] [PATCH] gallivm: don't use pavg.b intrinsic on llvm >= 6.0

2018-12-21 Thread Michel Dänzer
On 2018-12-21 1:25 a.m., srol...@vmware.com wrote: > From: Roland Scheidegger > > This intrinsic disppeared with llvm 6.0, using it ends up in segfaults > (due to llvm issuing call to NULL address in the jited shaders). > Add code doing the same thing as the autoupgrade code in llvm so it > can b

[Mesa-dev] [Bug 106769] radv: add support for shaderStorageImageMultisample

2018-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106769 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---