Re: [Mesa-dev] [PATCH 5/9] intel/compiler: relax brw_eu_validate for byte raw movs

2019-01-22 Thread Matt Turner
On Tue, Jan 22, 2019 at 10:26 PM Matt Turner wrote: > Was this just something that you noticed by inspection? With the patch reverted I see some validation failures in dEQP-VK.spirv_assembly.instruction.compute.8bit_storage.push_constant_8_to_16.scalar_uint and friends. mov(16) g10<4>B

Re: [Mesa-dev] [PATCH 3/8] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-01-22 Thread Eleni Maria Stea
On 1/22/19 9:25 PM, Nanley Chery wrote: [...] > > The performance difference should be negligible if the function is > declared static inline in the intel_mipmap_tree.h header. The compiler > should include the body of function (which should be small) and avoid > the overhead of a function call.

Re: [Mesa-dev] [PATCH 5/9] intel/compiler: relax brw_eu_validate for byte raw movs

2019-01-22 Thread Matt Turner
On Sun, Jul 8, 2018 at 5:27 PM, Jose Maria Casanova Crespo wrote: > When the destination is a BYTE type allow raw movs > even if the stride is not exact multiple of destination > type and exec type, execution type is Word and its size is 2. > > This restriction was only allowing stride==2

[Mesa-dev] [Bug 109361] [KBL-G][GL-es] several shader test cases failed to compile

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109361 --- Comment #3 from Hai --- If no next step, I will mark it as won't fix -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

[Mesa-dev] [Bug 108877] OpenGL CTS gl43 test cases were interrupted due to segment fault

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108877 Hai changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 108877] OpenGL CTS gl43 test cases were interrupted due to segment fault

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108877 --- Comment #5 from Hai --- With these two patches, this issue can't reproduce. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 94273] Clover on RadeonSI OpenCL segfault during testing of clBLAS

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94273 Peter changed: What|Removed |Added CC||pbrobin...@gmail.com -- You are receiving this

[Mesa-dev] [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100105 Peter changed: What|Removed |Added CC||pbrobin...@gmail.com -- You are receiving

Re: [Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

2019-01-22 Thread Timothy Arceri
On 23/1/19 3:27 pm, Caio Marcelo de Oliveira Filho wrote: Hi, The different problem I've found was that uses in the phi instruction after the then/else blocks was being replaced, causing churn in the optimizations further on. As a hack, I've ignored phi instructions in the use loop above.

[Mesa-dev] [Bug 87738] [OpenCL] Please add Image support

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87738 Julien Isorce changed: What|Removed |Added CC||julien.iso...@gmail.com -- You are

[Mesa-dev] [Bug 109334] OpenGL-OpenCL interop support

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109334 Peter changed: What|Removed |Added CC||pbrobin...@gmail.com -- You are receiving

[Mesa-dev] [Bug 87738] [OpenCL] Please add Image support

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87738 Peter changed: What|Removed |Added CC||pbrobin...@gmail.com -- You are receiving this

Re: [Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

2019-01-22 Thread Caio Marcelo de Oliveira Filho
Hi, > > The different problem I've found was that uses in the phi instruction > > after the then/else blocks was being replaced, causing churn in the > > optimizations further on. As a hack, I've ignored phi instructions in > > the use loop above. HURTs are gone and HELPs continued. > > > >

[Mesa-dev] [PATCH] nvc0: don't put text segment into bufctx

2019-01-22 Thread Ilia Mirkin
The text segment is shared among multiple contexts, while each one has its own bufctx. So when reallocating the text segment, some contexts may end up with stale values in their bufctx's. Instead limit the exposure to the bufctx to within a single draw. Signed-off-by: Ilia Mirkin --- nv50

[Mesa-dev] [PATCH] ac/nir_to_llvm: fix clamp shadow reference for more hardware

2019-01-22 Thread Timothy Arceri
Fixes the following piglit test on my VEGA and matches the behaviour in the tgsi backend. tests/spec/glsl-1.10/execution/samplers/glsl-fs-shadow2D-clamp-z.shader_test Fixes: 625dcbbc4566 ("amd/common: pass address components individually to ac_build_image_intrinsic") ---

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109258 --- Comment #7 from Daniel van Vugt --- > This revert makes Mesa ignore LIBGL_ALWAYS_SOFTWARE for the drm (and android) > platforms. That might be what it looks like, but as I understand it the opposite is true... The bug being fixed here is

Re: [Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

2019-01-22 Thread Timothy Arceri
On 23/1/19 11:27 am, Caio Marcelo de Oliveira Filho wrote: Hi, Did you look at any of the HURT? The problem I was seeing was this could end up stopping copy propagation from working on some UBOs etc. They were not UBO cases like yours, but looking at them I've found a different problem.

Re: [Mesa-dev] [PATCH 2/2] gallivm: Return true from arch_rounding_available() if NEON is available

2019-01-22 Thread Roland Scheidegger
I have no clue on aarch64, but looks all good to me. For the series: Reviewed-by: Roland Scheidegger Am 23.01.19 um 00:12 schrieb Matt Turner: > LLVM uses the single instruction "FRINTI" to implement llvm.nearbyint. > Fixes the rounding tests of lp_test_arit. > > Bug: >

Re: [Mesa-dev] [PATCH v3 24/42] intel/compiler: fix ddy for half-float in gen8

2019-01-22 Thread Matt Turner
On Tue, Jan 15, 2019 at 5:54 AM Iago Toral Quiroga wrote: > > We use ALign16 mode for this, since it is more convenient, but the PRM > for Broadwell states in Volume 3D Media GPGPU, Chapter 'Register region > restrictions', Section '1. Special Restrictions': > >"In Align16 mode, the channel

Re: [Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

2019-01-22 Thread Caio Marcelo de Oliveira Filho
Hi, > Did you look at any of the HURT? The problem I was seeing was this could end > up stopping copy propagation from working on some UBOs etc. They were not UBO cases like yours, but looking at them I've found a different problem. > However with this patch we end up with: > > load UBO at

Re: [Mesa-dev] [PATCH v3 23/42] intel/compiler: fix ddx and ddy for 16-bit float

2019-01-22 Thread Matt Turner
Obviously you cannot test the Gen11 code, but it looks believable. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 22/42] intel/compiler: don't propagate HF immediates to 3-src instructions

2019-01-22 Thread Matt Turner
On Tue, Jan 15, 2019 at 5:54 AM Iago Toral Quiroga wrote: > > 3-src instructions don't support immediates, but since 36bc5f06dd22, > we allow them on MAD and LRP relying on the combine constants pass to > fix it up later. However, that pass is specialized for 32-bit float > immediates and can't

Re: [Mesa-dev] [PATCH v3 21/42] intel/compiler: set correct precision fields for 3-source float instructions

2019-01-22 Thread Matt Turner
On Thu, Jan 17, 2019 at 12:18 PM Jason Ekstrand wrote: > > On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga wrote: >> >> Source0 and Destination extract the floating-point precision automatically >> from the SrcType and DstType instruction fields respectively when they are >> set to types :F

Re: [Mesa-dev] [PATCH v3 20/42] intel/compiler: allow half-float on 3-source instructions since gen8

2019-01-22 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 19/42] intel/compiler: don't compact 3-src instructions with Src1Type or Src2Type bits

2019-01-22 Thread Matt Turner
On Tue, Jan 15, 2019 at 5:55 AM Iago Toral Quiroga wrote: > > We are now using these bits, so don't assert that they are not set, just > avoid compaction in that case. > > Reviewed-by: Topi Pohjolainen > --- > src/intel/compiler/brw_eu_compact.c | 5 - > 1 file changed, 4 insertions(+), 1

Re: [Mesa-dev] [PATCH v3 17/42] intel/compiler: add new half-float register type for 3-src instructions

2019-01-22 Thread Matt Turner
On Tue, Jan 15, 2019 at 5:55 AM Iago Toral Quiroga wrote: > > This is available since gen8. > > v2: restore previously existing assertion. > > Reviewed-by: Topi Pohjolainen (v1) > --- > src/intel/compiler/brw_reg_type.c | 36 +++ > 1 file changed, 32 insertions(+), 4

Re: [Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Matt Turner
On Tue, Jan 22, 2019 at 3:25 PM Francisco Jerez wrote: > > Matt Turner writes: > > > emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its > > flag_subreg set, so that the IR knows which flag is accessed. However > > the flag is only used on Gen7 in Align1 mode. > > > > To avoid

Re: [Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Francisco Jerez
Matt Turner writes: > emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its > flag_subreg set, so that the IR knows which flag is accessed. However > the flag is only used on Gen7 in Align1 mode. > > To avoid setting unnecessary bits in the instruction words, get the > information we

[Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Matt Turner
emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its flag_subreg set, so that the IR knows which flag is accessed. However the flag is only used on Gen7 in Align1 mode. To avoid setting unnecessary bits in the instruction words, get the information we need and reset the default flag

[Mesa-dev] [PATCH 2/2] gallivm: Return true from arch_rounding_available() if NEON is available

2019-01-22 Thread Matt Turner
LLVM uses the single instruction "FRINTI" to implement llvm.nearbyint. Fixes the rounding tests of lp_test_arit. Bug: https://bugs.gentoo.org/665570 --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 4 +++- src/gallium/drivers/llvmpipe/lp_test_arit.c | 3 ++- 2 files changed, 5 insertions(+), 2

[Mesa-dev] [PATCH 1/2] gallium: Enable aarch64 NEON CPU detection.

2019-01-22 Thread Matt Turner
NEON (now called ASIMD) is available on all aarch64 CPUs. It seems that our code was missing an aarch64 path, leading to util_cpu_caps.has_neon always being false on aarch64. I think that means that the NEON tiling code in vc4 would not be enabled on aarch64 (vc4_load_lt_image_neon, etc). --- I

Re: [Mesa-dev] [PATCH 2/2] ac/nir_to_llvm: add bindless support for uniform handles

2019-01-22 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Mon, Jan 21, 2019 at 9:29 PM Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/src/amd/common/ac_nir_to_llvm.c >

Re: [Mesa-dev] [PATCH] ac/nir_to_llvm: fix interpolateAt* for structs

2019-01-22 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Tue, Jan 22, 2019 at 12:35 AM Timothy Arceri wrote: > This fixes the arb_gpu_shader5 interpolateAt* tests that contain > structs. > --- > > Extra piglit tests for structs: > > https://patchwork.freedesktop.org/patch/279466/ > > src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Francisco Jerez
Matt Turner writes: > emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its > flag_subreg set, so that the IR knows which flag is accessed. However > the flag is only used on Gen7 in Align1 mode. > > To avoid setting unnecessary bits in the instruction words, get the > information we

Re: [Mesa-dev] [PATCH] st/mesa: purge framebuffers when unbinding a context

2019-01-22 Thread Timothy Arceri
Acked-by: Timothy Arceri On 23/1/19 3:16 am, Marek Olšák wrote: From: Marek Olšák This fixes pipe_surface "leaks". Cc: 18.3 --- src/mesa/state_tracker/st_manager.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_manager.c

Re: [Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

2019-01-22 Thread Timothy Arceri
On 23/1/19 7:17 am, Caio Marcelo de Oliveira Filho wrote: Hi, I like this patch, did it get dropped for a specific reason or just forgotten? Did you look at any of the HURT? The problem I was seeing was this could end up stopping copy propagation from working on some UBOs etc. For example

Re: [Mesa-dev] [PATCH] radv: improve gathering of load_push_constants with dynamic bindings

2019-01-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Jan 22, 2019 at 7:27 PM Samuel Pitoiset wrote: > > For example, if a pipeline has two stages VS and FS. And if only > the fragment stage needs dynamic bindings, we shouldn't allocate > an extra user SGPR for the vertex stage. Of course, if the vertex >

Re: [Mesa-dev] [PATCH] radv: try to select better export formats for chips without Rb+

2019-01-22 Thread Bas Nieuwenhuizen
On Tue, Jan 22, 2019 at 4:32 PM Samuel Pitoiset wrote: > > For some R8 formats, it's useless to export two channels > when no alpha blending is used. I assume the CB should > automatically clamps its inputs. > > 29077 shaders in 15096 tests > Totals: > SGPRS: 1321106 -> 1320970 (-0.01 %) > VGPRS:

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2019-01-22 Thread Marek Olšák
On Thu, Nov 29, 2018 at 11:23 AM Koenig, Christian wrote: > Hi Marek, > > you stumbled over a pretty fundamental bug in the memory management here. > Essentially we where leaking BOs when we ran into an OOM situation. Patch > to fix this is on the mailing list. > > A second problem is that

Re: [Mesa-dev] [PATCH] loader: fix the no-modifiers case

2019-01-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Jan 22, 2019 at 10:20 PM Kristian Høgsberg wrote: > > On Tue, Jan 22, 2019 at 11:45 AM Rob Clark wrote: > > > > Normally modifiers take precendence over use flags, as they are more > > explicit. But if the driver supports modifiers, but the xserver does

[Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Matt Turner
emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its flag_subreg set, so that the IR knows which flag is accessed. However the flag is only used on Gen7 in Align1 mode. To avoid setting unnecessary bits in the instruction words, get the information we need and reset the default flag

Re: [Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Matt Turner
On Tue, Jan 22, 2019 at 11:53 AM Francisco Jerez wrote: > > Matt Turner writes: > > > emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its > > flag_subreg set, so that the IR knows which flag is accessed. However > > the flag is only used on Gen7 in Align1 mode, and it is used as an

Re: [Mesa-dev] [PATCH] loader: fix the no-modifiers case

2019-01-22 Thread Kristian Høgsberg
On Tue, Jan 22, 2019 at 11:45 AM Rob Clark wrote: > > Normally modifiers take precendence over use flags, as they are more > explicit. But if the driver supports modifiers, but the xserver does > not, then we should fallback to the old mechanism of allocating a buffer > using 'use' flags. > >

[Mesa-dev] [AppVeyor] mesa master #9821 completed

2019-01-22 Thread AppVeyor
Build mesa 9821 completed Commit 956c219c8f by Brian Paul on 1/22/2019 7:29 PM: svga: add new gallium formats to the format conversion table\n\nFixes a static assertion which broke the build.\n\nFixes: 3ee240890 "gallium: add SINT formats to have exact

Re: [Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

2019-01-22 Thread Caio Marcelo de Oliveira Filho
Hi, I like this patch, did it get dropped for a specific reason or just forgotten? shader-db results skl: total instructions in shared programs: 15049273 -> 15049211 (<.01%) instructions in affected programs: 75678 -> 75616 (-0.08%) helped: 197 HURT: 8 total cycles in shared programs:

[Mesa-dev] [PATCH] st/nine: Immediately upload user provided textures

2019-01-22 Thread Axel Davy
Fixes regression caused by 42d672fa6a766363e5703f119607f7c7975918aa st/nine: Bind src not dst in nine_context_box_upload Before that patch, for user provided textures, when the texture was destroyed, the safety check for pending uploads, which according to the code "Following condition cannot

Re: [Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Francisco Jerez
Matt Turner writes: > emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its > flag_subreg set, so that the IR knows which flag is accessed. However > the flag is only used on Gen7 in Align1 mode, and it is used as an > explicit source and destination. > > To avoid setting unnecessary

Re: [Mesa-dev] [PATCH] svga: add new gallium formats to the format conversion table

2019-01-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Sorry for breaking the build. Marek On Tue, Jan 22, 2019 at 2:31 PM Brian Paul wrote: > Fixes a static assertion which broke the build. > > Fixes:3ee240890 "gallium: add SINT formats to have exact counterparts to > SNORM formats" > --- >

[Mesa-dev] [PATCH] loader: fix the no-modifiers case

2019-01-22 Thread Rob Clark
Normally modifiers take precendence over use flags, as they are more explicit. But if the driver supports modifiers, but the xserver does not, then we should fallback to the old mechanism of allocating a buffer using 'use' flags. Fixes: 069fdd5f9facbd72fb6a289696c7b74e3237e70f Signed-off-by: Rob

Re: [Mesa-dev] [PATCH] svga: add new gallium formats to the format conversion table

2019-01-22 Thread Neha Bhende
Looks good Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Tuesday, January 22, 2019 11:31:13 AM To: mesa-dev@lists.freedesktop.org Cc: Jose Fonseca; Neha Bhende; Marek Olšák Subject: [PATCH] svga: add new gallium formats to the format

[Mesa-dev] [PATCH] intel/compiler: Reset default flag register in brw_find_live_channel()

2019-01-22 Thread Matt Turner
emit_uniformize() emits SHADER_OPCODE_FIND_LIVE_CHANNEL with its flag_subreg set, so that the IR knows which flag is accessed. However the flag is only used on Gen7 in Align1 mode, and it is used as an explicit source and destination. To avoid setting unnecessary bits in the instruction words,

[Mesa-dev] [PATCH] svga: add new gallium formats to the format conversion table

2019-01-22 Thread Brian Paul
Fixes a static assertion which broke the build. Fixes:3ee240890 "gallium: add SINT formats to have exact counterparts to SNORM formats" --- src/gallium/drivers/svga/svga_format.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/svga/svga_format.c

Re: [Mesa-dev] [PATCH v3 16/42] intel/compiler: add instruction setters for Src1Type and Src2Type.

2019-01-22 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/8] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-01-22 Thread Nanley Chery
On Tue, Jan 22, 2019 at 01:15:25PM +0200, Eleni Maria Stea wrote: > On 1/22/19 12:46 PM, Eleni Maria Stea wrote: > >>> + /** > >>> +* \brief Indicates that we fake the ETC2 compression support > >>> +* > >>> +* GPUs Gen < 8 don't support sampling and rendering of ETC2 > >>> formats

[Mesa-dev] [Bug 107822] Just Cause 3 Flickering Textures with AMD RADV

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107822 Alexander changed: What|Removed |Added Version|18.2|18.3 -- You are receiving this mail

[Mesa-dev] [Bug 107822] Just Cause 3 Flickering Textures with AMD RADV

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107822 Alexander changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[Mesa-dev] [AppVeyor] mesa master #9820 failed

2019-01-22 Thread AppVeyor
Build mesa 9820 failed Commit d85917deaf by Marek Olšák on 1/19/2019 12:35 AM: radeonsi: rename rfence -> sfence\n\nReviewed-by: Bas Nieuwenhuizen Configure your notification preferences ___ mesa-dev

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-22 Thread Jason Ekstrand
On Thu, Jan 17, 2019 at 1:07 PM Daniel Stone wrote: > Hi, > > On Thu, 17 Jan 2019 at 16:35, Jason Ekstrand wrote: > > On January 17, 2019 08:58:03 Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > > Whoops! I meant to say something like "we'd need to be able to > > > distinguis

Re: [Mesa-dev] [PATCH 3/8] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-01-22 Thread Nanley Chery
On Tue, Jan 22, 2019 at 02:17:16PM +0200, Eleni Maria Stea wrote: > On 1/19/19 1:32 AM, Nanley Chery wrote: > >> diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c > >> b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c > >> index e214fae140..4d1eafac91 100644 > >> ---

Re: [Mesa-dev] [PATCH 7/8] gallium/util: add a linear allocator for reducing malloc overhead

2019-01-22 Thread Marek Olšák
On Fri, Jan 18, 2019 at 8:22 PM Bas Nieuwenhuizen wrote: > On Sat, Jan 19, 2019 at 2:10 AM Marek Olšák wrote: > > > > On Fri, Jan 18, 2019 at 6:08 PM Bas Nieuwenhuizen < > b...@basnieuwenhuizen.nl> wrote: > >> > >> On Fri, Jan 18, 2019 at 5:44 PM Marek Olšák wrote: > >> > > >> > From: Marek

[Mesa-dev] [AppVeyor] mesa master #9818 failed

2019-01-22 Thread AppVeyor
Build mesa 9818 failed Commit a75b12ce66 by Lionel Landwerlin on 1/22/2019 5:36 PM: vulkan: make generated enum to strings helpers available from c++\n\nSigned-off-by: Lionel Landwerlin \nReviewed-by: Caio Marcelo de Oliveira Filho Configure your

[Mesa-dev] [PATCH] radv: improve gathering of load_push_constants with dynamic bindings

2019-01-22 Thread Samuel Pitoiset
For example, if a pipeline has two stages VS and FS. And if only the fragment stage needs dynamic bindings, we shouldn't allocate an extra user SGPR for the vertex stage. Of course, if the vertex stage loads constants, it needs an user SGPR. This should reduce the number of SET_SH_REG packets

Re: [Mesa-dev] [PATCH] vulkan: make generated enum to strings helpers available from c++

2019-01-22 Thread Lionel Landwerlin
Thanks Caio, pushed to master. On 22/01/2019 18:13, Caio Marcelo de Oliveira Filho wrote: Reviewed-by: Caio Marcelo de Oliveira Filho ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-22 Thread Juan A. Suarez Romero
On Tue, 2019-01-15 at 07:21 -0500, Rob Clark wrote: > On Tue, Jan 15, 2019 at 1:02 AM Tapani Pälli wrote: > > > > > > On 1/14/19 2:36 PM, Daniel Stone wrote: > > > Hi, > > > > > > On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand wrote: > > > > 5. There's no way with gitlab for Reviewed-by tags

Re: [Mesa-dev] [PATCH] vulkan: make generated enum to strings helpers available from c++

2019-01-22 Thread Caio Marcelo de Oliveira Filho
Reviewed-by: Caio Marcelo de Oliveira Filho On Tue, Jan 22, 2019 at 05:36:56PM +, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/vulkan/util/gen_enum_to_str.py | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/vulkan/util/gen_enum_to_str.py >

[Mesa-dev] MR: WIP: vulkan overlay layer

2019-01-22 Thread Lionel Landwerlin
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/139 The start of a Vulkan layer to display some basic swapchain/draws/submit information. Looks like this : https://i.imgur.com/4zyIiVb.png There is probably plenty of improvements that can be made to get closer to the gallium HUD.

[Mesa-dev] [AppVeyor] mesa review/arb_gl_spirv-xfb-improvement #9817 completed

2019-01-22 Thread AppVeyor
Build mesa 9817 completed Commit b1293c8745 by Alejandro Piñeiro on 11/7/2018 9:11 AM: nir/linker: use nir_gather_xfb_info\n\nInstead of a custom ARB_gl_spirv xfb gather info pass.\n\nIn fact, this is not only about reusing code, but the current custom\ncode

[Mesa-dev] [AppVeyor] mesa master #9816 failed

2019-01-22 Thread AppVeyor
Build mesa 9816 failed Commit 1cfbed7587 by Marek Olšák on 1/19/2019 12:39 AM: radeonsi: remove r600 from comments\n\nReviewed-by: Bas Nieuwenhuizen Configure your notification preferences ___ mesa-dev

[Mesa-dev] [PATCH] vulkan: make generated enum to strings helpers available from c++

2019-01-22 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/vulkan/util/gen_enum_to_str.py | 8 1 file changed, 8 insertions(+) diff --git a/src/vulkan/util/gen_enum_to_str.py b/src/vulkan/util/gen_enum_to_str.py index fb9ecd65c6d..06f74eb487c 100644 --- a/src/vulkan/util/gen_enum_to_str.py +++

[Mesa-dev] [PATCH] gallium: add etnaviv support for armada drm

2019-01-22 Thread Kyle Russell
Similar configuration to the iMX platform, but interfaces with the armada-drm driver. Signed-off-by: Kyle Russell --- configure.ac | 12 +- meson.build | 6 - meson_options.txt | 2 +-

Re: [Mesa-dev] [PATCH] st/mesa: fix PRIMITIVES_GENERATED query after the "pipeline stat single" changes

2019-01-22 Thread Marek Olšák
ping On Fri, Jan 18, 2019 at 11:27 AM Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_cb_queryobj.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_cb_queryobj.c > b/src/mesa/state_tracker/st_cb_queryobj.c > index

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #21 from amonpaike --- (In reply to mirh from comment #20) > A couple of devs are working into reinventing the wheel so that you could > basically have r600 cards work and be supported almost like they had been > released in 2018

[Mesa-dev] [PATCH] st/mesa: purge framebuffers when unbinding a context

2019-01-22 Thread Marek Olšák
From: Marek Olšák This fixes pipe_surface "leaks". Cc: 18.3 --- src/mesa/state_tracker/st_manager.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 7a3d9777101..7064b99743c 100644 ---

Re: [Mesa-dev] [PATCH mesa] configure: EGL requirements only apply if EGL is built

2019-01-22 Thread Eric Engestrom
On Tuesday, 2019-01-22 13:32:15 +, Emil Velikov wrote: > On Mon, 21 Jan 2019 at 19:53, Eric Engestrom wrote: > > > AFAICT this triggers when egl is explicitly disabled and drm is > explicitly listed in the with-platforms list. > Please add the triggering configure line to the commit message.

[Mesa-dev] [PATCH] radv: try to select better export formats for chips without Rb+

2019-01-22 Thread Samuel Pitoiset
For some R8 formats, it's useless to export two channels when no alpha blending is used. I assume the CB should automatically clamps its inputs. 29077 shaders in 15096 tests Totals: SGPRS: 1321106 -> 1320970 (-0.01 %) VGPRS: 935936 -> 935948 (0.00 %) Spilled SGPRs: 25186 -> 25204 (0.07 %) Code

Re: [Mesa-dev] [PATCH mesa] configure: EGL requirements only apply if EGL is built

2019-01-22 Thread Emil Velikov
On Mon, 21 Jan 2019 at 19:53, Eric Engestrom wrote: > AFAICT this triggers when egl is explicitly disabled and drm is explicitly listed in the with-platforms list. Please add the triggering configure line to the commit message. > Fixes: 2c4f6ceeb466cb15df34 "configure.ac: Fail if egl x11

Re: [Mesa-dev] [PATCH 3/8] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-01-22 Thread Eleni Maria Stea
On 1/19/19 1:32 AM, Nanley Chery wrote: >> diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c >> b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c >> index e214fae140..4d1eafac91 100644 >> --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c >> +++

Re: [Mesa-dev] [PATCH] i965: consider a 'base level' when calculating width0, height0, depth0

2019-01-22 Thread andrey simiklit
Hello, Could somebody help me with a push of the following patch? https://patchwork.freedesktop.org/patch/254397 This fix is needed to fix these fails: https://mesa-ci.01.org/global_logic/builds/56/group/ac3c5a0dc1f15492570367c6c8ec835c When this fix is pushed we will be able to remove the

Re: [Mesa-dev] [PATCH 3/8] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-01-22 Thread Eleni Maria Stea
On 1/22/19 12:46 PM, Eleni Maria Stea wrote: >>> + /** >>> +* \brief Indicates that we fake the ETC2 compression support >>> +* >>> +* GPUs Gen < 8 don't support sampling and rendering of ETC2 >>> formats so >>> +* we need to fake it. This variable is set to true when we >>> fake

Re: [Mesa-dev] [PATCH] nv50,nvc0: mark textures dirty on fb update

2019-01-22 Thread Karol Herbst
Reviewed-by: Karol Herbst On Mon, Jan 21, 2019 at 4:27 AM Ilia Mirkin wrote: > > We may have to flush the cache if there are any textures presently bound > that refer to the outgoing framebuffer. This is only checked at > validation time. > > Fixes a number of

Re: [Mesa-dev] [PATCH 3/8] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-01-22 Thread Eleni Maria Stea
> > + /** > > +* \brief Indicates that we fake the ETC2 compression support > > +* > > +* GPUs Gen < 8 don't support sampling and rendering of ETC2 > > formats so > > +* we need to fake it. This variable is set to true when we > > fake it. > > +*/ > > + bool needs_fake_etc;

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

2019-01-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109258 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] egl/dri2: try to bind old context if bindContext failed

2019-01-22 Thread Frank Binns
Hi Luigi, Luigi Santivetti writes: > Before this change, if bindContext() failed then dri2_make_current() would > rebind the old EGL context and surfaces and return EGL_BAD_MATCH. However, > it wouldn't rebind the DRI context and surfaces, thus leaving it in an > inconsistent and unrecoverable

Re: [Mesa-dev] [PATCH v3 25/42] intel/compiler: workaround for SIMD8 half-float MAD in gen8

2019-01-22 Thread Iago Toral
On Mon, 2019-01-21 at 18:48 -0600, Jason Ekstrand wrote: > On Mon, Jan 21, 2019 at 4:55 AM Iago Toral wrote: > > On Fri, 2019-01-18 at 11:51 -0600, Jason Ekstrand wrote: > > > On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga < > > > ito...@igalia.com> wrote: > > > > Broadwell hardware has a bug