https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #9 from fin4...@hotmail.com ---
The Rise of the Tomb Raider game works fine with my
System:
Host: ryzenpc Kernel: 5.0.0 x86_64 bits: 64 Desktop: Xfce 4.13.2
Distro: Debian GNU/Linux buster/sid
Machine:
Type: Desktop Mobo:
https://bugs.freedesktop.org/show_bug.cgi?id=109945
Bug ID: 109945
Summary: pan_assemble.c:51:46: error: passing argument 2 of
‘tgsi_to_nir’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
Product: Mesa
On Friday, 2019-03-08 15:54:37 -0700, Brian Paul wrote:
> ---
> docs/meson.html | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/docs/meson.html b/docs/meson.html
> index 7ffef81..43090aa 100644
> --- a/docs/meson.html
> +++ b/docs/meson.html
> @@ -274,6 +274,19 @@ on the
---
docs/meson.html | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/meson.html b/docs/meson.html
index 7ffef81..43090aa 100644
--- a/docs/meson.html
+++ b/docs/meson.html
@@ -274,6 +274,19 @@ on the system. This environment variable is used to
control the search path for
Fixes:
../src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c: In function
‘kms_sw_displaytarget_from_handle’:
../src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c:402:60: error:
dereferencing pointer to incomplete type ‘const struct pipe_resource’
Fixes:
../src/gallium/winsys/sw/dri/dri_sw_winsys.c: In function
‘dri_sw_displaytarget_display’:
../src/gallium/winsys/sw/dri/dri_sw_winsys.c:255:39: error: dereferencing
pointer to incomplete type ‘struct pipe_box’
offset = dri_sw_dt->stride * box->y;
This was used to avoid freeing a sampler view which was created by a
context that was already deleted. But the state tracker does not
allow that.
---
src/gallium/drivers/llvmpipe/lp_state_sampler.c | 6 --
1 file changed, 6 deletions(-)
diff --git
This function was used in the past to avoid deleting a sampler view
for a context that no longer exists. But the Mesa state tracker
ensures that cannot happen. Use the standard refcounting function
instead.
Testing Done: google chrome, variety of GL demos/games
---
After a while of running google-chrome and viewing Bing maps, we'd see
"context mismatch in svga_sampler_view_destroy()" messages and
eventually crash because we leaked too many sampler views (the kernel
module would have too many sampler views).
When a texture object is being deleted, we call
As with svga, llvmpipe drivers in previous patches.
Compile tested only.
---
src/gallium/drivers/swr/swr_state.cpp | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/gallium/drivers/swr/swr_state.cpp
b/src/gallium/drivers/swr/swr_state.cpp
index d7baa71..42d196f 100644
---
It's no longer used.
---
src/gallium/auxiliary/util/u_inlines.h | 20
1 file changed, 20 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_inlines.h
b/src/gallium/auxiliary/util/u_inlines.h
index fa1e920..567d3d0 100644
--- a/src/gallium/auxiliary/util/u_inlines.h
+++
As with previous patches for svga, llvmpipe, swr drivers.
Compile tested only.
---
src/gallium/drivers/i915/i915_state.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/gallium/drivers/i915/i915_state.c
b/src/gallium/drivers/i915/i915_state.c
index
https://bugs.freedesktop.org/show_bug.cgi?id=109535
Bug 109535 depends on bug 109505, which changed state.
Bug 109505 Summary: [GEN9+] 2% perf drop in Unigine Heaven, 1% in Valley
https://bugs.freedesktop.org/show_bug.cgi?id=109505
What|Removed |Added
> +/**
> + * struct drm_panfrost_wait_bo - ioctl argument for waiting for
> + * completion of the last DRM_PANFROST_SUBMIT_CL on a BO.
Nit: Should be plain DRM_PANFROST_SUBMIT, there is no CL for us.
> + __s64 timeout_ns; /* absolute */
Erm, why is this signed? Semantically, what does
https://bugs.freedesktop.org/show_bug.cgi?id=109944
Eric Engestrom changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=109929
Vinson Lee changed:
What|Removed |Added
Keywords||bisected
CC|
https://bugs.freedesktop.org/show_bug.cgi?id=109944
Eric Engestrom changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Eric
https://bugs.freedesktop.org/show_bug.cgi?id=109944
Bug ID: 109944
Summary: [bisected] Android build test fails with: utils.c:
error: use of undeclared identifier 'PACKAGE_VERSION'
Product: Mesa
Version: git
Hardware:
On Fri, Mar 8, 2019 at 9:30 AM Juan A. Suarez Romero
wrote:
> On Thu, 2019-03-07 at 07:15 -0600, Jason Ekstrand wrote:
> > Woah, is this legal SPIR-V? I think a second OpSelectionMerge is
> required.
>
> I'd say it is legal. The spec does not mandate that each branch has its own
> merge
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Friday, March 8, 2019 9:14 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [Mesa-dev] [PATCH] st/mesa: init hash keys with memset(), not
designated
> This doesn't work for t604 which has a special version of 0x6???. That
> helpfully also collides with bifrost versions. We could fix this up in
> the kernel to expose it as 0x0600. Then an 'is_bifrost' would be an
> easy (gpu_id & 0xf000).
I think there's a fundamental question here, do we want
Hi Eric
> > Use u_transfer_helper_resource_create(..) instead which uses the
> > resource_create(..) function specified in u_transfer_vtbl.
>
> I would need to run this through the CTS, as the stacking in
> u_transfer_helper is fragile. What's fixed for you by this patch?
I am playing around
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Thursday, March 7, 2019 6:45 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Deepak Singh Rawat
Subject: [Mesa-dev] [PATCH] svga: remove SVGA_RELOC_READ flag in
Reviewed-by: Roland Scheidegger
Am 08.03.19 um 18:14 schrieb Brian Paul:
> Since the compiler may not zero-out padding in the object.
> Add a couple comments about this to prevent misunderstandings in
> the future.
>
> Fixes: 67d96816ff5 ("st/mesa: move, clean-up shader variant key
Add new Introduction and Advanced Usage sections.
Spell out a few more details, like "ninja install".
Improve the layout around example commands.
Fix grammatical errors and tighten up the text.
Explain the --prefix option.
v2: Remove language about 'ninja clean' and move link to Meson
information
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, March 8, 2019 7:52 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH 5/5] st/mesa: minor refactoring of texture/sampler delete code
Rename
Since the compiler may not zero-out padding in the object.
Add a couple comments about this to prevent misunderstandings in
the future.
Fixes: 67d96816ff5 ("st/mesa: move, clean-up shader variant key decls/inits")
---
src/mesa/state_tracker/st_atom_shader.c | 9 +++--
On 03/08/2019 09:53 AM, Roland Scheidegger wrote:
Am 07.03.19 um 17:20 schrieb Brian Paul:
Move the variant key declarations inside the scope they're used.
Use designated initializers instead of memset() calls.
I don't think this will always work as intended, since there's
non-explicit padding
Am 07.03.19 um 17:20 schrieb Brian Paul:
> Move the variant key declarations inside the scope they're used.
> Use designated initializers instead of memset() calls.
I don't think this will always work as intended, since there's
non-explicit padding bits in the key, and AFAIK even with c11
Reviewed-by: Lionel Landwerlin
Thanks!
On 08/03/2019 15:52, Brian Paul wrote:
---
src/intel/compiler/brw_vec4.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp
index fe36851..2e9de29 100644
---
Reviewed-by: Lionel Landwerlin
On 08/03/2019 15:52, Brian Paul wrote:
---
src/intel/common/gen_batch_decoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/common/gen_batch_decoder.c
b/src/intel/common/gen_batch_decoder.c
index ff898d8..5cac983 100644
Eric Engestrom writes:
> On 2019-03-08 at 03:42, Brian Paul wrote:
>> Add new Introduction and Advanced Usage sections.
>> Spell out a few more details, like "ninja install".
>> Improve the layout around example commands.
>> Fix grammatical errors and tighten up the text.
>> Explain the
Christian Gmeiner writes:
> Use u_transfer_helper_resource_create(..) instead which uses the
> resource_create(..) function specified in u_transfer_vtbl.
I would need to run this through the CTS, as the stacking in
u_transfer_helper is fragile. What's fixed for you by this patch?
I've spent some time on this but I'm stumped.
I've been building with -Dshared-llvm=false for a while because I can't
get -Dshared-llvm=true to work.
I'm configuring meson with:
meson -Dplatforms=x11 \
-Dglx=gallium-xlib \
-Dgallium-drivers=swrast \
On Thu, Mar 7, 2019 at 11:51 PM Eric Engestrom wrote:
> On 2019-03-08 at 03:42, Brian Paul wrote:
> > Add new Introduction and Advanced Usage sections.
> > Spell out a few more details, like "ninja install".
> > Improve the layout around example commands.
> > Fix grammatical errors and tighten
To st_texture_release_context_sampler_view() to be more clear
that it's context-specific.
---
src/mesa/state_tracker/st_context.c | 2 +-
src/mesa/state_tracker/st_sampler_view.c | 4 ++--
src/mesa/state_tracker/st_sampler_view.h | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
Rename st_texture_free_sampler_views() to
st_delete_texture_sampler_views() to align with
st_DeleteTextureObject(), its only caller.
Move the call to st_texture_release_all_sampler_views() from
st_DeleteTextureObject() to st_delete_texture_sampler_views()
so all the sampler view clean-up code is
To de-clutter st_context.h.
Clean up remaining function prototypes in st_context.h.
The st_vp_uses_current_values() helper is only used in st_context.c
so move it there.
The st_get_active_states() function is only used in st_context.c so
remove its prototype in st_context.h
---
---
src/mesa/state_tracker/st_sampler_view.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_sampler_view.c
b/src/mesa/state_tracker/st_sampler_view.c
index 1669de5..b22aa20 100644
--- a/src/mesa/state_tracker/st_sampler_view.c
+++
st_init_driver_functions() is only called in st_context.c so there's
no need for the prototype in st_context.h
To avoid a forward declaration of st_init_driver_functions() in
st_context.c, we need to move around several other functions.
No functional change.
---
---
src/intel/compiler/brw_vec4.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp
index fe36851..2e9de29 100644
--- a/src/intel/compiler/brw_vec4.cpp
+++ b/src/intel/compiler/brw_vec4.cpp
@@ -414,7 +414,7 @@
---
src/intel/common/gen_batch_decoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/common/gen_batch_decoder.c
b/src/intel/common/gen_batch_decoder.c
index ff898d8..5cac983 100644
--- a/src/intel/common/gen_batch_decoder.c
+++
On Fri, Mar 8, 2019 at 3:27 AM Tomeu Vizoso wrote:
>
> Also use the raw GPU ID value to decide whether to use SFD or MFD.
>
> Signed-off-by: Tomeu Vizoso
> ---
> src/gallium/drivers/panfrost/pan_context.c | 66 ++
> src/gallium/drivers/panfrost/pan_context.h | 10
>
Patches 1-7 are Reviewed-by: Alyssa Rosenzweig
Patch 8 I don't have time to read through right now but will get to this
evening.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, 2019-03-07 at 07:15 -0600, Jason Ekstrand wrote:
> Woah, is this legal SPIR-V? I think a second OpSelectionMerge is required.
I'd say it is legal. The spec does not mandate that each branch has its own
merge instruction; only that the control flow must be structured for shaders.
In
On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner
wrote:
>
> Use u_transfer_helper_resource_create(..) instead which uses the
> resource_create(..) function specified in u_transfer_vtbl.
>
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +-
> 1 file
Build mesa 10318 failed
Commit d4381cf593 by Brian Paul on 3/7/2019 11:14 PM:
svga: remove SVGA_RELOC_READ flag in SVGA3D_BindGBSurface()\n\nThis fixes a rendering issue where UBO updates aren't always picked\nup by drawing calls. This issue effected the
https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #8 from Alex Smith ---
What LLVM version are you using and what CPU do you have? I'm unable to
reproduce this on current 19.0 branch
(8ab2fc8c963955818d6cbc1db47b76d9bffb9eb6) using LLVM 7, loading times seem as
expected to me with
oh, also add a Fixes tag please.
On Fri, Mar 8, 2019 at 2:50 PM Bas Nieuwenhuizen
wrote:
>
> I actually think it is partially right, but lets indeed revert for now
>
> Reviewed-by: Bas Nieuwenhuizen
>
> On Fri, Mar 8, 2019 at 2:48 PM Samuel Pitoiset
> wrote:
> >
> > This changes is actually
I actually think it is partially right, but lets indeed revert for now
Reviewed-by: Bas Nieuwenhuizen
On Fri, Mar 8, 2019 at 2:48 PM Samuel Pitoiset
wrote:
>
> This changes is actually wrong because we have to sync
> before doing image layout transitions.
>
> This fixes rendering issues in
This changes is actually wrong because we have to sync
before doing image layout transitions.
This fixes rendering issues in Batman, Path of Exile and
probably more titles.
This reverts commit 76c17cfd8da017ebd19be33ba6cef888957a6758.
Cc: 19.0
Signed-off-by: Samuel Pitoiset
---
https://bugs.freedesktop.org/show_bug.cgi?id=109939
Mike Lothian changed:
What|Removed |Added
CC||m...@fireburn.co.uk
--- Comment #7 from
https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #6 from Alex Smith ---
The loading screen will block for a while on pipeline creation for the level
that you are loading (that's what the CBackgroundWork threads are doing). If
you see much faster loading times on an older version,
https://bugs.freedesktop.org/show_bug.cgi?id=109401
--- Comment #6 from Samuel Pitoiset ---
Created attachment 143587
--> https://bugs.freedesktop.org/attachment.cgi?id=143587=edit
hack reflection issue
Can you try this hack too?
--
You are receiving this mail because:
You are the assignee
Reviewed-by: Alejandro Piñeiro
Out of curiosity: right now it is always used as true (so maintain
current behaviour). How it is intended to be used? With an envvar?
On 7/3/19 22:38, Jason Ekstrand wrote:
---
src/compiler/nir/nir_serialize.c | 56 ---
https://bugs.freedesktop.org/show_bug.cgi?id=109401
--- Comment #5 from Samuel Pitoiset ---
Does RADV_DEBUG=zerovram help?
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #2 from Timur Kristóf ---
Vinson, can you give me some more details on how to reproduce this, such as
what commands you used to configure and build mesa?
I tried the following:
./autogen.sh --enable-autotools --enable-debug
https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #5 from Timur Kristóf ---
Mikhail, are you sure this is a mesa issue? It could be a bug in the game. On
my machine (RX 570, with mesa 18.3 RADV) Rise of the Tomb Raider can spend a
lot of time (sometimes 10-15 minutes) on the
https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #4 from mikhail.v.gavri...@gmail.com ---
PS Yet another native Linux Vulkan game "F1 2017" that's made by Feral is
works, but first time the game starts too long around of 10 minutes, but it not
consuming all CPU cores.
--
You are
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #1 from Timur Kristóf ---
This is my mistake, forgot to add the autotools equivalent when I wrote the
meson part:
https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #3 from mikhail.v.gavri...@gmail.com ---
I am tested versions rc1 - rc6
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #2 from Timothy Arceri ---
Mesa 19.0 has not been released yet. You need to provide more detail on what
exactly you are testing with.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 11 +++
src/gallium/drivers/panfrost/pan_context.h | 7 +++
src/gallium/drivers/panfrost/pan_screen.c | 11 ++-
src/gallium/drivers/panfrost/pan_screen.h | 11 ++-
4 files changed, 30
Implement resource_get_handle for non-scanout cases.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_resource.c | 37 +++--
src/gallium/drivers/panfrost/pan_screen.h | 1 +
2 files changed, 20 insertions(+), 18 deletions(-)
It will be used by the DRM backend to store GEM handles from the kernel.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_allocate.h | 1 +
src/gallium/drivers/panfrost/pan_resource.h | 2 ++
2 files changed, 3 insertions(+)
diff --git
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_allocate.c | 4 ++--
src/gallium/drivers/panfrost/pan_resource.c | 2 +-
src/gallium/drivers/panfrost/pan_screen.h| 6 --
src/gallium/drivers/panfrost/pan_wallpaper.c | 2 +-
4 files
The corresponding change to the kernel can be seen here:
https://gitlab.freedesktop.org/tomeu/linux/commits/panfrost-5.0
Thanks,
Tomeu
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Also use the raw GPU ID value to decide whether to use SFD or MFD.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 66 ++
src/gallium/drivers/panfrost/pan_context.h | 10
src/gallium/drivers/panfrost/pan_screen.h | 1 +
3 files changed, 41
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index fdb3aa7ccdc2..3c8a483b8f58 100644
This backend interacts with the new DRM driver for Midgard GPUs which is
currently in development.
When using this backend, Panfrost has roughly on-par functionality as
when using the non-DRM driver from Arm.
Signed-off-by: Tomeu Vizoso
---
v2: - Adapt to changes in the UAPI, mostly one atom
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index 51c2ded48fe4..fdb3aa7ccdc2 100644
---
https://bugs.freedesktop.org/show_bug.cgi?id=109939
--- Comment #1 from mikhail.v.gavri...@gmail.com ---
Created attachment 143586
--> https://bugs.freedesktop.org/attachment.cgi?id=143586=edit
for i in {1..10}; do gdb --batch --ex "t a a bt" -pid=`pidof
RiseOfTheTombRaider` &>bt$i.txt; sleep
https://bugs.freedesktop.org/show_bug.cgi?id=109939
Bug ID: 109939
Summary: After upgrade mesa to 19.0.0 stop working the game
Rise of the Tomb Raider
Product: Mesa
Version: unspecified
Hardware: Other
OS:
On Friday, March 1, 2019 7:55:18 AM PST Christian Gmeiner wrote:
> Use u_transfer_helper_resource_create(..) instead which uses the
> resource_create(..) function specified in u_transfer_vtbl.
>
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +-
>
On Wed, 2019-03-06 at 09:21 +0100, Iago Toral wrote:
> On Tue, 2019-03-05 at 07:35 +0100, Iago Toral wrote:
> > On Mon, 2019-03-04 at 15:36 -0800, Francisco Jerez wrote:
> > > Iago Toral writes:
> > >
> > > > On Fri, 2019-03-01 at 19:04 -0800, Francisco Jerez wrote:
> > > > > Iago Toral writes:
https://bugs.freedesktop.org/show_bug.cgi?id=109920
Samuel Pitoiset changed:
What|Removed |Added
Status|VERIFIED|RESOLVED
--
You are receiving this
https://bugs.freedesktop.org/show_bug.cgi?id=109927
--- Comment #5 from Michel Dänzer ---
Weirdly, the backtrace of the crash doesn't look directly related to Mesa.
Maybe there's memory corruption, in which case running Xorg in valgrind might
give a clue. (Make sure debugging symbols are
77 matches
Mail list logo
