Re: [Mesa-dev] [PATCH] panfrost: Refactor blend descriptors

2019-05-04 Thread Alyssa Rosenzweig
> The blend shader enable bit is already described in the comments in > the header; the blend shader is enabled when unk2 == 0. I'm pretty sure that comment was from you, but thank you ;) > (the blend shader has > to be allocated within the same 2^24 byte range as the main shader for > it to

Re: [Mesa-dev] [PATCH 2/3] u_dynarray: return 0 on realloc failure

2019-05-04 Thread Caio Marcelo de Oliveira Filho
Hi, > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > > index b30fd7b1154..f6a81609dbe 100644 > > --- a/src/util/u_dynarray.h > > +++ b/src/util/u_dynarray.h > > @@ -85,20 +85,22 @@ util_dynarray_ensure_cap(struct util_dynarray *buf, > > unsigned newcap) > >

Re: [Mesa-dev] [PATCH 3/3] u_dynarray: turn util_dynarray_{grow, resize} into element-oriented macros

2019-05-04 Thread Bas Nieuwenhuizen
On Sat, May 4, 2019 at 3:25 PM Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > The main motivation for this change is API ergonomics: most operations > on dynarrays are really on elements, not on bytes, so it's weird to have > grow and resize as the odd operations out. > > The secondary

Re: [Mesa-dev] [PATCH] panfrost: Refactor blend descriptors

2019-05-04 Thread Connor Abbott
On Sun, May 5, 2019 at 12:14 AM Alyssa Rosenzweig wrote: > > This commit does a fairly large cleanup of blend descriptors, although > there should not be any functional changes. In particular, we split > apart the Midgard and Bifrost blend descriptors, since they are > radically different. From

Re: [Mesa-dev] [PATCH 2/3] u_dynarray: return 0 on realloc failure

2019-05-04 Thread Bas Nieuwenhuizen
On Sat, May 4, 2019 at 3:25 PM Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > We're not very good at handling out-of-memory conditions in general, but > this change at least gives the caller the option of handling it. > > This happens to fix an error in out-of-memory handling in i965, which

[Mesa-dev] [PATCH] panfrost: Refactor blend descriptors

2019-05-04 Thread Alyssa Rosenzweig
This commit does a fairly large cleanup of blend descriptors, although there should not be any functional changes. In particular, we split apart the Midgard and Bifrost blend descriptors, since they are radically different. From there, we can identify that the Midgard descriptor as previously

[Mesa-dev] [Bug 110611] src/compiler/nir/nir.h : warning: type of ‘nir_get_io_offset_src’ does not match original declaration [-Wlto- type-mismatch]

2019-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110611 Bug ID: 110611 Summary: src/compiler/nir/nir.h : warning: type of ‘nir_get_io_offset_src’ does not match original declaration [-Wlto- type-mismatch] Product: Mesa

[Mesa-dev] [Bug 110608] [bisected][18.3.3 regression] Nouveau on Wayland fails

2019-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110608 Marius Bakke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 2/5] ddebug: fix a few MSVC compiler warnings

2019-05-04 Thread Brian Paul
Don't return an expression in void functions. Replace an unsigned int with proper enum. --- src/gallium/auxiliary/driver_ddebug/dd_context.c | 15 --- src/gallium/auxiliary/driver_ddebug/dd_screen.c | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 1/5] glsl: s/GLboolean/bool/ to silence MSVC compiler warning

2019-05-04 Thread Brian Paul
It complains about mixing GLboolean and bool in the |= expression. --- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl/glsl_parser_extras.cpp index d99ab3d..41f2a97 100644

[Mesa-dev] [PATCH 4/5] gallium/pp: s/uint/enum tgsi_semantic/ to fix MSVC warning

2019-05-04 Thread Brian Paul
--- src/gallium/auxiliary/postprocess/pp_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/postprocess/pp_program.c b/src/gallium/auxiliary/postprocess/pp_program.c index 52786de..4cd3990 100644 ---

[Mesa-dev] [Bug 110608] [bisected][18.3.3 regression] Nouveau on Wayland fails

2019-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110608 --- Comment #1 from Ilia Mirkin --- This feels like a mesa cache format issue. For whatever reason, mesa's internal mechanisms don't detect that it should invalidate the shader cache. Try to wipe your $HOME/.cache/mesa_shader_cache directory,

[Mesa-dev] [PATCH 3/5] noop: s/enum pipe_transfer_usage/unsigned/ to fix MSVC warning

2019-05-04 Thread Brian Paul
The function pointer declaration in pipe_context uses unsigned for the bitmask. --- src/gallium/auxiliary/driver_noop/noop_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/driver_noop/noop_pipe.c b/src/gallium/auxiliary/driver_noop/noop_pipe.c

[Mesa-dev] [PATCH 5/5] gallium/util: fix two MSVC compiler warnings

2019-05-04 Thread Brian Paul
Remove stray const qualifier. s/unsigned/enum tgsi_semantic/ --- src/gallium/auxiliary/util/u_format_zs.h | 2 +- src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_zs.h

Re: [Mesa-dev] [PATCH 3/3] u_dynarray: turn util_dynarray_{grow, resize} into element-oriented macros

2019-05-04 Thread Gustaw Smolarczyk
sob., 4 maj 2019 o 15:25 Nicolai Hähnle napisał(a): > > From: Nicolai Hähnle > > The main motivation for this change is API ergonomics: most operations > on dynarrays are really on elements, not on bytes, so it's weird to have > grow and resize as the odd operations out. > > The secondary

[Mesa-dev] [Bug 110608] [bisected][18.3.3 regression] Nouveau on Wayland fails

2019-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110608 Bug ID: 110608 Summary: [bisected][18.3.3 regression] Nouveau on Wayland fails Product: Mesa Version: 18.3 Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [Bug 110606] [lib32] [vulkan-overlay-layer] build failure

2019-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110606 Bug ID: 110606 Summary: [lib32] [vulkan-overlay-layer] build failure Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [Bug 110607] Vulkan overlay build broken on IA-32

2019-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110607 Bug ID: 110607 Summary: Vulkan overlay build broken on IA-32 Product: Mesa Version: git Hardware: x86 (IA32) OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [PATCH 1/6] radeonsi: inline si_shader_binary_read_config into its only caller

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle Since it can only be used for reading the config of an individual, non-combined shader, it is not very reusable anyway. --- src/gallium/drivers/radeonsi/si_shader.c | 21 +++-- src/gallium/drivers/radeonsi/si_shader.h | 2 -- 2 files changed, 7

[Mesa-dev] [PATCH 0/6] amd,radeonsi: link explicit LDS symbols

2019-05-04 Thread Nicolai Hähnle
this series builds on my recent series adding a runtime linker to now support layout and relocation of explicit LDS symbols. Currently, all our uses of LDS have a single LDS base pointer which is defined either by an inttoptr case from 0 or as a single global LDS symbol. This is fine for our

[Mesa-dev] [PATCH 2/6] amd/rtld: layout and relocate LDS symbols

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle Upcoming changes to LLVM will emit LDS objects as symbols in the ELF symbol table, with relocations that will be resolved with this change. Callers will also be able to define LDS symbols that are shared between shader parts. This will be used by radeonsi for the ESGS ring

[Mesa-dev] [PATCH 5/6] radeonsi: use an explicit symbol for the LSHS LDS memory

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 17 +++-- src/gallium/drivers/radeonsi/si_state_draw.c | 5 + 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 4/6] radeonsi: rename lds_{load, store} to lshs_lds_{load, store}

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle These functions are now only used in LS/HS shaders (both separate and merged). --- src/gallium/drivers/radeonsi/si_shader.c | 33 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 3/6] radeonsi/gfx9: declare LDS ESGS ring as an explicit symbol on LLVM >= 9

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle This will make it easier to use LDS for other purposes in geometry shaders in the future. The lifetime of the esgs_ring variable is as follows: - declared as [0 x i32] while compiling shader parts or monolithic shaders - just before uploading, gfx9_get_gs_info computes

[Mesa-dev] [PATCH 6/6] radeonsi: raise the alignment of LDS memory for compute shaders

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle This implies that the memory will always be at address 0, which allows LLVM to generate slightly better code. --- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 2/3] u_dynarray: return 0 on realloc failure

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle We're not very good at handling out-of-memory conditions in general, but this change at least gives the caller the option of handling it. This happens to fix an error in out-of-memory handling in i965, which has the following code in brw_bufmgr.c: node =

[Mesa-dev] [PATCH 3/3] u_dynarray: turn util_dynarray_{grow, resize} into element-oriented macros

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle The main motivation for this change is API ergonomics: most operations on dynarrays are really on elements, not on bytes, so it's weird to have grow and resize as the odd operations out. The secondary motivation is memory safety. Users of the old byte-oriented functions

[Mesa-dev] [PATCH 1/3] freedreno: use util_dynarray_clear instead of util_dynarray_resize(_, 0)

2019-05-04 Thread Nicolai Hähnle
From: Nicolai Hähnle This is more expressive and simplifies a subsequent change. --- src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 12 ++-- src/gallium/drivers/freedreno/a3xx/fd3_gmem.c | 4 ++-- src/gallium/drivers/freedreno/a4xx/fd4_gmem.c | 2 +-

[Mesa-dev] [PATCH 0/3] u_dynarray: minor API cleanups

2019-05-04 Thread Nicolai Hähnle
just some small changes that should make util_dynarray more convenient and safer to use. Please review! Thanks, Nicolai -- .../drivers/freedreno/a2xx/fd2_gmem.c| 12 +++--- .../drivers/freedreno/a3xx/fd3_gmem.c| 4 +- .../drivers/freedreno/a4xx/fd4_gmem.c| 2 +-

Re: [Mesa-dev] [PATCH 03/10] mesa: Implement _mesa_array_element by walking enabled arrays.

2019-05-04 Thread Mathias Fröhlich
Hi Brian, On Friday, 3 May 2019 14:40:26 CEST Brian Paul wrote: > All your suggested changes look good. > > Reviewed-by: Brian Paul > > Thanks. Pushed Thanks! best Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org