[Mesa-dev] [Bug 111119] features.txt shows VK_KHR_device_group* as not started, while they are listed as enabled in radv

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=19 --- Comment #2 from Shmerl --- (In reply to Jason Ekstrand from comment #1) > More to the point, Vulkan extensions are not like GL extensions where you > either have it or don't. Yes, RADV advertises the extension but it's a > no-op

[Mesa-dev] [Bug 111119] features.txt shows VK_KHR_device_group* as not started, while they are listed as enabled in radv

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=19 Jason Ekstrand changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 111121] Meson build (ninja) loops infinitely when --native-file is used to specify llvm version

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=21 Shmerl changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 111121] Meson build (ninja) loops infinitely when --native-file is used to specify llvm version

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=21 --- Comment #2 from Shmerl --- (In reply to oschowa from comment #1) > That's a meson bug only present in 0.51 and already fixed on master: > https://github.com/mesonbuild/meson/issues/5505 > > It also only happens when the native file is not

[Mesa-dev] [Bug 111121] Meson build (ninja) loops infinitely when --native-file is used to specify llvm version

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=21 --- Comment #1 from osch...@web.de --- That's a meson bug only present in 0.51 and already fixed on master: https://github.com/mesonbuild/meson/issues/5505 It also only happens when the native file is not a real file. -- You are receiving

[Mesa-dev] [Bug 111121] Meson build (ninja) loops infinitely when --native-file is used to specify llvm version

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=21 Bug ID: 21 Summary: Meson build (ninja) loops infinitely when --native-file is used to specify llvm version Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 111119] features.txt shows VK_KHR_device_group* as not started, while they are listed as enabled in radv

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=19 Bug ID: 19 Summary: features.txt shows VK_KHR_device_group* as not started, while they are listed as enabled in radv Product: Mesa Version: git Hardware: x86-64

Re: [Mesa-dev] [PATCH v2] radv/gfx10: enable 1D textures

2019-07-12 Thread Bas Nieuwenhuizen
R-b On Fri, Jul 12, 2019, 8:17 AM Samuel Pitoiset wrote: > Mirror RadeonSI. This also fixes crashes in addrlib. > > v2: - fix ac_nir_to_llvm > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c| 14 +++--- > src/amd/vulkan/radv_image.c

[Mesa-dev] [PATCH 5/6] radv: pass output values to radv_emit_stream_output()

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index bc1d72f51bb..5bd938fc046 100644 ---

[Mesa-dev] [PATCH 3/6] radv: allow to emit PS_DONE/CS_DONE with RELEASE_MEM

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index a832dbd89eb..089c7d861c8 100644 --- a/src/amd/vulkan/si_cmd_buffer.c +++

[Mesa-dev] [PATCH 4/6] radv: allow to select DST_SEL with RELEASE_MEM

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 ++ src/amd/vulkan/radv_private.h| 2 +- src/amd/vulkan/radv_query.c | 2 ++ src/amd/vulkan/si_cmd_buffer.c | 8 ++-- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 2/6] radv: restore an assertion in handle_vs_outputs()

2019-07-12 Thread Samuel Pitoiset
The NGG GS epilogue no longers call that function so the assertion is just useless now. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c

[Mesa-dev] [PATCH 6/6] radv: add radv_emit_streamout_{begin, end} helpers

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 43 ++-- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 4f8137906e3..6a0db2b67e9 100644 ---

[Mesa-dev] [PATCH 1/6] radv/gfx10: emit ES outputs of TES when it's not NGG

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index e4ab5847729..d5d30bbcf12 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++

Re: [Mesa-dev] [PATCH 8/8] radv/gfx10: emit DISABLE_CONSERVATIVE_ZPASS_COUNTS

2019-07-12 Thread Bas Nieuwenhuizen
r-b for the series On Fri, Jul 12, 2019 at 12:17 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv_cmd_buffer.c > index

Re: [Mesa-dev] [PATCH 1/2] radv: store a pointer to rad_info in the pipeline

2019-07-12 Thread Bas Nieuwenhuizen
Please don't introduce multiple ways to do the same thing. (for both patches in the series). On Fri, Jul 12, 2019 at 10:39 AM Samuel Pitoiset wrote: > > Cleanup. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 173 - >

Re: [Mesa-dev] [PATCH] radeon/vcn: adding engine type for new fw interface

2019-07-12 Thread Liu, Leo
Reviewed-by Leo Liu On 2019-07-11 5:56 p.m., boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.h | 2 ++ > src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 1 + >

[Mesa-dev] [PATCH] radv/gfx10: invalidate everything in L2 when shaders read data

2019-07-12 Thread Samuel Pitoiset
This includes metadata as well. On GFX10, we have to invalidate the L2 metadata cache when shaders read DCC. Note that we still have to implement GFX10 coherency by introducing INV_L2_METATADA but for now just flush L2. This fixes a corruption with DCC and Talos. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 3/8] radv/gfx10: launch 2 compute waves per CU before going onto the next CU

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index efb94cdcd23..a58b0d6d006 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH 8/8] radv/gfx10: emit DISABLE_CONSERVATIVE_ZPASS_COUNTS

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index dacd8c8d803..86b5c812405 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++

[Mesa-dev] [PATCH 6/8] radv/gfx10: set HS/GS/CS.WGP_MODE

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 8f37c2bfb67..d055b6c96ca 100644 --- a/src/amd/vulkan/radv_shader.c +++

[Mesa-dev] [PATCH 1/8] ac: import ac_get_compute_resource_limits() from RadeonSI

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_gpu_info.c | 32 + src/amd/common/ac_gpu_info.h | 4 +++ src/gallium/drivers/radeonsi/si_compute.c | 35 ++- .../radeonsi/si_compute_prim_discard.c| 6 ++--

[Mesa-dev] [PATCH 4/8] radv/gfx10: enable vertex shaders without export parameters

2019-07-12 Thread Samuel Pitoiset
GFX10 allows this. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index a58b0d6d006..63583a9c6d9 100644 ---

[Mesa-dev] [PATCH 7/8] radv/gfx10: init more registers in the graphics preamble

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index 6d01e0ad7fd..a832dbd89eb 100644 --- a/src/amd/vulkan/si_cmd_buffer.c +++

[Mesa-dev] [PATCH 5/8] radv/gfx10: emit GE_PC_ALLOC

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 63583a9c6d9..fdb0ed29ea4 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH 2/8] radv: use ac_get_compute_resource_limits()

2019-07-12 Thread Samuel Pitoiset
No behaviour change. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 7720990ba45..efb94cdcd23 100644 ---

Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used

2019-07-12 Thread Michel Dänzer
On 2019-07-11 8:08 p.m., Marek Olšák wrote: > From: Jeremy Newton > > The amdgpu dri is used for the closed source AMD driver. Since this driver > does not implement multimedia, we fall back to radeonsi in mesa to do > multimedia. This corrects the dri driver name for when it is set to amdgpu.

Re: [Mesa-dev] [PATCH 1/2] radv: add more assertions to make sure packets are correctly emitted

2019-07-12 Thread Bas Nieuwenhuizen
Okay, r-b for the series then. On Fri, Jul 12, 2019 at 12:00 PM Samuel Pitoiset wrote: > > > On 7/12/19 11:54 AM, Bas Nieuwenhuizen wrote: > > On Fri, Jul 12, 2019 at 11:13 AM Samuel Pitoiset > > wrote: > >> Signed-off-by: Samuel Pitoiset > >> --- > >> src/amd/vulkan/radv_cs.h | 6 +++--- >

Re: [Mesa-dev] [PATCH 1/2] radv: add more assertions to make sure packets are correctly emitted

2019-07-12 Thread Samuel Pitoiset
On 7/12/19 11:54 AM, Bas Nieuwenhuizen wrote: On Fri, Jul 12, 2019 at 11:13 AM Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cs.h b/src/amd/vulkan/radv_cs.h

Re: [Mesa-dev] [PATCH 1/2] radv: add more assertions to make sure packets are correctly emitted

2019-07-12 Thread Bas Nieuwenhuizen
On Fri, Jul 12, 2019 at 11:13 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cs.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/amd/vulkan/radv_cs.h b/src/amd/vulkan/radv_cs.h > index 5f8b59c34cb..2ba7da1fb44 100644

Re: [Mesa-dev] [PATCH] st/mesa: accelerate glCopyPixels(STENCIL)

2019-07-12 Thread apinheiro
On 11/7/19 20:12, Marek Olšák wrote: The test passes here. I wouldn't push a commit that doesn't pass. Ok, thanks for confirming. It looks like v3d can't blit stencil. Ok, thanks for the hint. Marek On Thu, Jul 11, 2019 at 6:29 AM apinheiro > wrote:

[Mesa-dev] [PATCH 2/2] radv/gfx10: fix wrong emission of GE_CNTL

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 41a1b2014b9..7ecf189b0d6 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH 1/2] radv: add more assertions to make sure packets are correctly emitted

2019-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cs.h b/src/amd/vulkan/radv_cs.h index 5f8b59c34cb..2ba7da1fb44 100644 --- a/src/amd/vulkan/radv_cs.h +++ b/src/amd/vulkan/radv_cs.h @@ -42,7

[Mesa-dev] [Bug 111107] 726a31df705b causes the in memory shader cache to use up to 5x more memory

2019-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=07 Alex Smith changed: What|Removed |Added CC||asm...@feralinteractive.com -- You are

[Mesa-dev] [PATCH 2/2] radv: store a pointer to rad_info in the cmdbuffer

2019-07-12 Thread Samuel Pitoiset
Cleanup. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 75 +++- src/amd/vulkan/radv_private.h| 1 + 2 files changed, 37 insertions(+), 39 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH 1/2] radv: store a pointer to rad_info in the pipeline

2019-07-12 Thread Samuel Pitoiset
Cleanup. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 173 - src/amd/vulkan/radv_private.h | 2 + 2 files changed, 87 insertions(+), 88 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH v2] radv/gfx10: enable 1D textures

2019-07-12 Thread Samuel Pitoiset
Mirror RadeonSI. This also fixes crashes in addrlib. v2: - fix ac_nir_to_llvm Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c| 14 +++--- src/amd/vulkan/radv_image.c| 4 ++--