We throw away the original for space though, so there is nothing to compare
on collision (hence the cryptographic hash).
On Mon, Jul 3, 2023 at 10:23 AM abel.berna...@gmail.com <
abel.berna...@gmail.com> wrote:
> Two cents, sorry if too obvious.
>
> If you want to try to squeeze more performance
Assuming you meant 22.0, I have a backport for the 22.0 radv patch:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16126
On Fri, Apr 22, 2022 at 6:56 AM Dylan Baker wrote:
>
> Hi all,
>
> I've spent a good deal of time this week crushing the backlog of
> patches on the mesa 20.0
On Wed, Feb 9, 2022 at 7:10 PM Dylan Baker wrote:
>
> Hi all,
>
> I'd like to announce the availability of Mesa 22.0.0-rc2, the second
> release candidate for mesa 22.0.0. We have lots of fixes here, including
> a good deal of zink fixes, and some changes for shared microsoft, egl,
> core mesa,
On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen wrote:
>
> Mike Blumenkrantz writes:
>
> > On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen
> > wrote:
> >
> >> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand
> >> wrote:
> >> >
> >
On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand wrote:
>
> On Wed, Oct 6, 2021 at 11:24 AM Emma Anholt wrote:
> >
> > On Wed, Oct 6, 2021 at 9:20 AM Mike Blumenkrantz
> > wrote:
> > >
> > > Hi,
> > >
> > > It's recently come to my attention that gitlab has Approvals. Was anyone
> > > else aware
On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter wrote:
>
> On Wed, Jun 23, 2021 at 4:02 PM Christian König
> wrote:
> >
> > Am 23.06.21 um 15:49 schrieb Daniel Vetter:
> > > On Wed, Jun 23, 2021 at 3:44 PM Christian König
> > > wrote:
> > >
On Wed, Jun 23, 2021 at 2:59 PM Christian König
wrote:
>
> Am 23.06.21 um 14:18 schrieb Daniel Vetter:
> > On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen
> > wrote:
> >> On Tue, Jun 22, 2021 at 6:55 PM Daniel Vetter
> >> wrote:
> >>> WARN
new uapi behavior that we don't want to be
the end result.
Within AMDGPU this is probably solvable in two ways:
1) Downgrade AMDGPU_SYNC_NE_OWNER to AMDGPU_SYNC_EXPLICIT for shared fences.
2) Have an EXPLICIT fence owner that is used for explicit submissions
that is ignored by AMDGPU_SYNC_NE_OWNE
On Fri, May 21, 2021 at 4:37 PM Daniel Vetter wrote:
>
> On Fri, May 21, 2021 at 11:46:23AM +0200, Bas Nieuwenhuizen wrote:
> > On Fri, May 21, 2021 at 11:10 AM Daniel Vetter
> > wrote:
> > > ---
> > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++--
>
I think we can ignore LTS distros who
> upgrade their kernels but not their mesa3d snapshot.
>
> - Then when this is all in place we can merge this patch here.
>
> What is not a solution to this problem here is trying to make the
> dma_resv rules in the kernel more clever. The fu
On Mon, May 3, 2021 at 5:00 PM Jason Ekstrand wrote:
>
> Sorry for the top-post but there's no good thing to reply to here...
>
> One of the things pointed out to me recently by Daniel Vetter that I
> didn't fully understand before is that dma_buf has a very subtle
> second requirement beyond
On Tue, Apr 20, 2021 at 8:16 PM Daniel Stone wrote:
> On Tue, 20 Apr 2021 at 19:00, Christian König <
> ckoenig.leichtzumer...@gmail.com> wrote:
>
>> Am 20.04.21 um 19:44 schrieb Daniel Stone:
>>
>> But winsys is something _completely_ different. Yes, you're using the GPU
>> to do things with
On Thu, Aug 13, 2020 at 6:57 PM vivek pandya wrote:
>
> Hello,
>
> I found following function:
>
> src/amd/vulkan/radv_pipeline.c
> 4998:VkResult radv_CreateGraphicsPipelines(
In src/amd/vulkan/radv_entrypoints_gen.py we generate a bunch of code
that implements the vkGet*ProcAddr lookup, and
On Sun, Mar 29, 2020 at 11:36 PM Eric Engestrom wrote:
>
>
>
> On 2020-03-29 at 20:58, Jason Ekstrand wrote:
> > On Sun, Mar 29, 2020 at 11:45 AM Kristian Høgsberg
> > wrote:
> > >
> > > As for loading, doesn't glvnd solve that?
> >
> > Not really. There are still problems if you have HW
On Tue, Jan 28, 2020 at 8:46 PM Dylan Baker wrote:
>
> Quoting Dylan Baker (2020-01-22 10:27:05)
> > Hi list, due to some last minute changes in plan I'll be managing the 20.0
> > release. The release calendar has been updated, but the gitlab milestone
> > wasn't
> > opened. That has been
I think this ended up spawning a bunch of work in
https://gitlab.freedesktop.org/mesa/mesa/issues/2385
On Mon, Jan 20, 2020 at 3:41 PM Stefan Dirsch wrote:
>
> Hi
>
> Starting from the upcoming GCC release 10, the default of -fcommon option will
> change to -fno-common. Due to this we're going
On Tue, Dec 17, 2019 at 11:09 PM Marek Olšák wrote:
>
> Hi Eric,
>
> Does it mean people no longer need push access, because Marge can merge
> anything?
>
> So any random person can create a merge request and immediately assign it to
> Marge to merge it?
Per
On Fri, Dec 6, 2019 at 10:49 AM Michel Dänzer wrote:
>
>
> I just merged
> https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2794 , which
> affects people who want to run the CI pipeline on personal Mesa branches:
>
> Pushing changes to a personal branch now always creates a pipeline, but
>
{$BUILD_DIR?}/src/amd/vulkan/radv_entrypoints.h
{$BUILD_DIR?}/src/intel/vulkan/anv_entrypoints.h
generated using the entrypoints.py scripts in the corresponding source
directories.
On Thu, Oct 3, 2019 at 5:46 PM Andreas Bergmeier wrote:
>
> First off, thanks for git grep. Did not know that yet.
Hi all,
One things I realized during the migration is that end users generally
cannot edit labels on an issue[1] and there is no component selection
anymore.
So we end up with a bunch of changes:
1) Bugs come in without labels
2) People are not consistently fixing up labels for issues
3) Labels
Reviewed-by: Bas Nieuwenhuizen
On Wed, Aug 21, 2019 at 4:26 PM Samuel Pitoiset
wrote:
>
> This fixes a regression introduced with scan operations
> on GFX10. Note that some subgroups CTS still fail on GFX10 but
> I assume it's a different issue.
>
> This fixes dEQP-VK.su
On Wed, Aug 21, 2019 at 3:45 PM Samuel Pitoiset
wrote:
>
> This fixes a regression introduced with scan operations
> on GFX10. Note that some subgroups CTS still fail on GFX10 but
> I assume it's a different issue.
>
> This fixes dEQP-VK.subgroups.arithmetic.*.subgroupexclusive*.
>
> Fixes:
r-b
On Wed, Aug 21, 2019 at 9:01 AM Samuel Pitoiset
wrote:
>
> Trivial extension that matches PAL.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 9 +
> src/amd/vulkan/radv_extensions.py | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git
r-b
On Wed, Aug 21, 2019 at 8:34 AM Samuel Pitoiset
wrote:
>
> Scans aren't implemented on SI/CIK.
>
> Cc: 19.2
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 3 ++-
> src/amd/vulkan/radv_shader.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff
r-b for both.
On Wed, Aug 21, 2019 at 10:51 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index
r-b for both.
On Tue, Aug 20, 2019 at 3:19 PM Samuel Pitoiset
wrote:
>
> The script doesn't handle them correctly and D16_UNORM_S8_UINT
> isn't supported by the hardware, mark it as invalid.
>
> This fixes warning when generating gfx10_format_table.h.
>
> Bugzilla:
want to cc to 19.2?
r-b for both
On Tue, Aug 20, 2019 at 4:47 PM Samuel Pitoiset
wrote:
>
> This gives a nice boost, +20% at this time on my Vega 56. Shader
> ballot should be enabled by default at some point but it reduces
> performance a bit (-6%) with Wolfeinstein II. Enable it only for
>
r-b for both
On Mon, Aug 19, 2019 at 2:57 PM Samuel Pitoiset
wrote:
>
> CLEAR_STATE emits it for us.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/si_cmd_buffer.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c
r-b for both
On Thu, Aug 1, 2019 at 3:41 PM Samuel Pitoiset
wrote:
>
> It's 0 for depth surfaces with TC compat HTILE enabled.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_image.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
r-b for both
On Thu, Aug 1, 2019 at 5:56 PM Samuel Pitoiset
wrote:
>
> It's unnecessary to duplicate fields in another struct.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 4 ++--
> src/amd/vulkan/radv_image.c | 38 +---
>
r-b for patch 1,2,4
On Thu, Aug 1, 2019 at 10:40 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_llvm_helper.cpp | 30 +
> src/amd/vulkan/radv_shader.c| 3 ++-
> src/amd/vulkan/radv_shader_helper.h | 3 ++-
> 3
So I'm not sure we can actually do this.
AFAIU even though we use a 32-bit wave internally we still have to
expose 64-bit externally, because with
VkPhysicalDeviceSubgroupProperties we say the subgroup size is 64
bits.
So we have to ~emulate a 64-lane wave that always has the upper bits empty.
r-b for the series
On Wed, Jul 31, 2019 at 9:36 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 27 +++
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c
r-b
On Tue, Jul 30, 2019 at 6:29 PM Samuel Pitoiset
wrote:
>
> It can be enabled with RADV_PERFTEST=cswave32.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_debug.h | 1 +
> src/amd/vulkan/radv_device.c | 12 +++-
> src/amd/vulkan/radv_nir_to_llvm.c | 14
r-b
On Tue, Jul 30, 2019 at 3:11 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index
r-b
On Mon, Jul 29, 2019 at 2:35 PM Samuel Pitoiset
wrote:
>
>
> On 7/29/19 2:30 PM, Bas Nieuwenhuizen wrote:
> > On Mon, Jul 29, 2019 at 2:20 PM Samuel Pitoiset
> > wrote:
> >>
> >> On 7/29/19 2:15 PM, Bas Nieuwenhuizen wrote:
> >>> On Mon, J
On Mon, Jul 29, 2019 at 2:20 PM Samuel Pitoiset
wrote:
>
>
> On 7/29/19 2:15 PM, Bas Nieuwenhuizen wrote:
> > On Mon, Jul 29, 2019 at 2:11 PM Samuel Pitoiset
> > wrote:
> >> The HTILE masks seem to be different and so we need to rework that
> >> path. Ju
On Mon, Jul 29, 2019 at 2:11 PM Samuel Pitoiset
wrote:
>
> The HTILE masks seem to be different and so we need to rework that
> path. Just disabled for now and implement later.
The HTILE masks are not different per amdvlk?
Can you at least rework the commit message to reflect that?
>
> This
r-b
On Mon, Jul 29, 2019 at 10:47 AM Samuel Pitoiset
wrote:
>
> Natively supported on VI+.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 60 +++
> src/amd/vulkan/radv_device.c | 6
> src/amd/vulkan/radv_extensions.py | 1
r-b
On Mon, Jul 29, 2019 at 12:00 PM Samuel Pitoiset
wrote:
>
> This might happen when a pipeline doesn't define the vertex input
> state, so the buffer data format is 0 (aka INVALID).
>
> This fixes crashes when compiling some shaders on GFX10.
>
> Signed-off-by: Samuel Pitoiset
> ---
>
Without correct size, radeonsi assumes the metadata is incorrect,
which can and will cause issues.
Since the metadata is really incorrect without the size, let us
fix that.
Fixes: e43cc3e3afc "radv/gfx9: handle GFX9 opaque metadata"
---
src/amd/vulkan/radv_image.c | 3 ++-
1 file changed, 2
bleh, you're right
So we should not be using DCC ...
On Thu, Jul 25, 2019 at 4:37 PM Samuel Pitoiset
wrote:
>
> It's already disabled later in this function?
>
> On 7/25/19 4:34 PM, Bas Nieuwenhuizen wrote:
> > (a) radv does not set the DCC fields required yet.
> >
(a) radv does not set the DCC fields required yet.
(b) radeonsi just broke their DCC metadata.
Fixes: f8b6c5a1a63 "radeonsi: rewrite si_get_opaque_metadata, also for gfx10
support"
---
src/amd/vulkan/radv_image.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/amd/vulkan/radv_image.c
r-b
though it sounds like some of our cache flushes might be not ideal.
On Thu, Jul 25, 2019 at 3:35 PM Samuel Pitoiset
wrote:
>
> It's coherent and faster. GFX7-GFX9 should also support this but
> for now only uses L2 for GFX10 because it's untested on previous gens.
>
> This fixes
On Wed, Jul 24, 2019 at 4:47 PM Samuel Pitoiset
wrote:
>
> This fixes
> dEQP-VK.rasterization.primitive_size.points.point_size_*
>
> This also fixes some black squares with the Sascha SSAO demo.
>
> v2: - do not set for multiple channels
> - call vi_alpha_is_on_msb() for pre-GFX10
> -
On Wed, Jul 24, 2019 at 3:00 PM Samuel Pitoiset
wrote:
>
> This fixes
> dEQP-VK.rasterization.primitive_size.points.point_size_*
>
> This also fixes some black squares with the Sascha SSAO demo.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_image.c | 15 ++-
> 1
r-b for the series if you resolve my comment on patch 4.
On Tue, Jul 23, 2019 at 3:21 PM Samuel Pitoiset
wrote:
>
> When a pipeline uses transform feedback, the driver fallbacks to
> the legacy path because NGG support for streamout is a non-trivial
> amount of work.
>
> AMDVLK also uses the
On Tue, Jul 23, 2019 at 3:21 PM Samuel Pitoiset
wrote:
>
> NGG GS for streamout requires a bunch of work, so enable it with
> the legacy path only for now.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 28
> 1 file changed, 28
r-b
On Tue, Jul 23, 2019 at 2:44 PM Samuel Pitoiset
wrote:
>
> For some reasons, InstanceID is VGPR3 although StepRate0 is set to 1.
>
> v3: fix instanceID input VGPR for geometry
> v2: fix instanceID
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 12
r-b
On Tue, Jul 23, 2019 at 2:10 PM Samuel Pitoiset
wrote:
>
> For some reasons, InstanceID is VGPR3 although StepRate0 is set to 1.
>
> v2: fix instanceID
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 12 +---
> src/amd/vulkan/radv_shader.c | 2
So does this work with tests that use multiple instances?
If so, r-b.
On Tue, Jul 23, 2019 at 1:29 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
r-b
On Tue, Jul 23, 2019 at 8:37 AM Samuel Pitoiset
wrote:
>
> It actually works.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
>
r-b
On Tue, Jul 23, 2019 at 9:51 AM Samuel Pitoiset
wrote:
>
> Fixes: a20a9d0c5e7 ("radv: dont store disasm string unless keep_shader_info
> flag set")
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_shader.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff
On Mon, Jul 22, 2019 at 6:01 PM Ilia Mirkin wrote:
>
> On Mon, Jul 22, 2019 at 11:49 AM Samuel Pitoiset
> wrote:
> >
> > For TES as NGG.
> >
> > Signed-off-by: Samuel Pitoiset
> > ---
> > src/amd/vulkan/radv_nir_to_llvm.c | 17 -
> > 1 file changed, 16 insertions(+), 1
r-b
On Mon, Jul 22, 2019 at 10:09 AM Samuel Pitoiset
wrote:
>
> depth_stencil_attachment and/or ds_resolve attachment can be NULL.
>
> This fixes crashes with
> dEQP-VK.renderpass.suballocation.unused_clear_attachments.*
>
> Cc: 19.1
> Signed-off-by: Samuel Pitoiset
> ---
>
r-b
On Fri, Jul 19, 2019 at 9:19 PM Rhys Perry wrote:
>
> Seems to fix some hair artifacts in Max Payne 3:
> https://github.com/daniel-schuermann/mesa/issues/76
>
> Signed-off-by: Rhys Perry
> Fixes: f4e499ec791 ('radv: add initial non-conformant radv vulkan driver')
> ---
>
desc_type |=
> S_008F0C_FORMAT(V_008F0C_IMG_FORMAT_32_FLOAT) |
> +S_008F0C_OOB_SELECT(3) |
We really should get some enum/define values for OOB_SELECT.
Anyway, not a blocker
Reviewed-by: Bas Nieuwenhuizen
for the series
> +S_008F
We might want to merge this into patch 1, as we now emit the
R_028A84_VGT_PRIMITIVEID_EN twice after only patch 1.
Either way r-b for the series
On Thu, Jul 18, 2019 at 10:14 AM Samuel Pitoiset
wrote:
>
> Unnecessary.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c |
r-b
On Thu, Jul 18, 2019 at 10:04 AM Samuel Pitoiset
wrote:
>
>
> On 7/18/19 2:29 AM, Bas Nieuwenhuizen wrote:
> > On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset
> > wrote:
> >> With NGG, empty waves may still be required to export data.
> >&g
On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset
wrote:
>
> With NGG, empty waves may still be required to export data.
>
> This fixes dEQP-VK.ycbcr.format.*_unorm.geometry_*.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 31 ++-
> 1
On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index de933937f03..8b6e62a75f5
On Thu, Jul 18, 2019 at 2:05 AM Bas Nieuwenhuizen
wrote:
>
> On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset
> wrote:
> >
> > It's useless for NGG anyways.
> >
> > Signed-off-by: Samuel Pitoiset
> > ---
> > src/amd/vulkan/radv_pipeline.c | 43 +
On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset
wrote:
>
> It's useless for NGG anyways.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 43 ++
> 1 file changed, 33 insertions(+), 10 deletions(-)
>
> diff --git
r-b
On Wed, Jul 17, 2019 at 10:54 AM Samuel Pitoiset
wrote:
>
> Found by inspection.
>
> Cc:
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c
r-b
On Tue, Jul 16, 2019 at 7:28 AM Dave Airlie wrote:
>
> From: Dave Airlie
>
> This is ported from AMDVLK, it's probably not requires unless
> we want to use "real time queues", but it might be nice to just have
> in place.
> ---
> src/amd/common/sid.h | 1 +
>
After reset, if valid does not contain the relevant bit the descriptor
can be != NULL but still not be valid.
CC:
---
src/amd/vulkan/radv_meta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c
index
r-b
On Tue, Jul 16, 2019 at 5:11 PM Samuel Pitoiset
wrote:
>
> I did implement this extension a while ago but it didn't work
> on pre GFX10 for some reasons. Now all CTS pass.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_extensions.py | 1 +
>
r-b for the series
On Tue, Jul 16, 2019 at 4:39 PM Samuel Pitoiset
wrote:
>
> This is unsupported and hangs.
>
> This fixes GPU hangs with
> dEQP-VK.tessellation.geometry_interaction.limits.output_required_*.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 12
r-b
On Tue, Jul 16, 2019 at 5:35 PM Samuel Pitoiset
wrote:
>
> Unnecessary.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 7 ++-
> src/amd/vulkan/radv_device.c | 2 ++
> src/amd/vulkan/radv_image.c | 7 ---
> src/amd/vulkan/radv_private.h| 1
r-b
On Tue, Jul 16, 2019 at 1:25 AM Dave Airlie wrote:
>
> From: Dave Airlie
>
> Setting this seems to be broken, amdvlk only sets it for quilted
> textures which I'm not sure what those are.
>
> Fixes: dEQP-VK.glsl.texture_functions.query.texturesize*3d*
> ---
> src/amd/vulkan/radv_image.c |
R-b
On Mon, Jul 15, 2019, 8:49 AM Samuel Pitoiset
wrote:
> It was hack for geometry shaders.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 16 +---
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_nir_to_llvm.c
And R-b after suggestion
On Mon, Jul 15, 2019, 11:22 PM Bas Nieuwenhuizen
wrote:
>
>
> On Mon, Jul 15, 2019, 10:45 AM Samuel Pitoiset
> wrote:
>
>> This fixes
>> dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_*
>>
>> Found w
On Mon, Jul 15, 2019, 10:45 AM Samuel Pitoiset
wrote:
> This fixes
> dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_*
>
> Found with RADV_DEBUG=checkir
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 9 +
> 1 file changed, 9
r-b
On Mon, Jul 15, 2019 at 6:46 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_shader.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
> index
R-b
On Fri, Jul 12, 2019, 8:17 AM Samuel Pitoiset
wrote:
> Mirror RadeonSI. This also fixes crashes in addrlib.
>
> v2: - fix ac_nir_to_llvm
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_nir_to_llvm.c| 14 +++---
> src/amd/vulkan/radv_image.c
r-b for the series
On Fri, Jul 12, 2019 at 12:17 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c
> b/src/amd/vulkan/radv_cmd_buffer.c
> index
Please don't introduce multiple ways to do the same thing. (for both
patches in the series).
On Fri, Jul 12, 2019 at 10:39 AM Samuel Pitoiset
wrote:
>
> Cleanup.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 173 -
>
Okay, r-b for the series then.
On Fri, Jul 12, 2019 at 12:00 PM Samuel Pitoiset
wrote:
>
>
> On 7/12/19 11:54 AM, Bas Nieuwenhuizen wrote:
> > On Fri, Jul 12, 2019 at 11:13 AM Samuel Pitoiset
> > wrote:
> >> Signed-off-by: Samuel Pitoiset
> >>
On Fri, Jul 12, 2019 at 11:13 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cs.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cs.h b/src/amd/vulkan/radv_cs.h
> index 5f8b59c34cb..2ba7da1fb44 100644
R-b
On Thu, Jul 11, 2019, 6:33 PM Samuel Pitoiset
wrote:
> This is invalid and this fixes a crash in LLVM.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_nir_to_llvm.c
>
R-b for the series
On Thu, Jul 11, 2019, 6:04 PM Samuel Pitoiset
wrote:
> For debugging purposes.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 21 +
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
> diff --git
R-b
On Thu, Jul 11, 2019, 5:02 PM Samuel Pitoiset
wrote:
> This fixes dEQP-VK.clipping.user_defined.clip_distance.*geom*.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
R-b
On Thu, Jul 11, 2019, 5:02 PM Samuel Pitoiset
wrote:
> This fixes dEQP-VK.multiview.*geometry*.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 16 +++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git
r-b
On Thu, Jul 11, 2019 at 5:22 PM Samuel Pitoiset
wrote:
>
> Mirror RadeonSI. This also fixes crashes in addrlib.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_image.c| 4 ++--
> src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 6 --
> 2 files
r-b
On Thu, Jul 11, 2019 at 2:24 PM Samuel Pitoiset
wrote:
>
> The dimensions also have to be adjusted if the number of supported
> mip levels is changed.
>
> This fixes dEQP-VK.api.info.image_format_properties.3d.*.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_formats.c | 14
r-b
On Thu, Jul 11, 2019 at 11:54 AM Samuel Pitoiset
wrote:
>
> For some reasons D32_SFLOAT is also affected on GFX10, it works
> fine with previous generations.
>
> This fixes some dEQP-VK.renderpass2.depth_stencil_resolve.*.
>
> Signed-off-by: Samuel Pitoiset
> ---
>
Reviewed-by: Bas Nieuwenhuizen
for the series.
On Thu, Jul 11, 2019 at 8:44 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 540 +-
> src/amd/vulkan/radv_pipeline.c| 5 +-
&g
Reviewed-by: Bas Nieuwenhuizen
for the series.
On Wed, Jul 10, 2019 at 3:15 PM Samuel Pitoiset
wrote:
>
> It will help for GS as NGG on GFX10.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 118 +-
> 1 file
r-b for both
On Wed, Jul 10, 2019 at 1:00 PM Samuel Pitoiset
wrote:
>
> Now that the output usage mask is set to 0x1 the LayerID is
> correctly exported in the loop above.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 19 ++-
> 1 file changed, 2
On Tue, Jul 9, 2019 at 9:19 AM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 25 -
> 1 file changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
>
r-b
On Mon, Jul 8, 2019 at 1:45 PM Samuel Pitoiset
wrote:
>
> We don't need it.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
>
r-b
On Sun, Jul 7, 2019 at 7:50 PM Samuel Pitoiset
wrote:
>
> Will be useful for testing the legacy path.
>
> v2: add to get_hash_flags() too
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_debug.h| 1 +
> src/amd/vulkan/radv_device.c | 1 +
>
Please add the option to get_hash_flags in radv_pipeline.c too, so it
does not poison the cache.
On Sun, Jul 7, 2019 at 7:35 PM Samuel Pitoiset
wrote:
>
> Will be useful for testing the legacy path.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_debug.h| 1 +
>
r-b
On Sun, Jul 7, 2019 at 7:32 PM Samuel Pitoiset
wrote:
>
> GFX10 has two rings, so UMR want to know which one to halt.
> Select the first one by default.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_debug.c | 9 ++---
> src/amd/common/ac_debug.h
r-b
On Thu, Jul 4, 2019 at 8:51 AM Samuel Pitoiset
wrote:
>
> These values are only useful if binning is disabled.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 44 +-
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff
r-b
On Thu, Jul 4, 2019 at 8:51 AM Samuel Pitoiset
wrote:
>
> If the destination attachment is UNUSED.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta_resolve_cs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git
r-b
On Tue, Jul 2, 2019 at 2:47 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_image.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index
I really like just always filling the struct completely. Provides a
better abstraction and less surprises.
On Tue, Jul 2, 2019 at 2:47 PM Samuel Pitoiset
wrote:
>
> The decompress/resummarize pass always use the depth aspect.
>
> Signed-off-by: Samuel Pitoiset
> ---
>
r-b
On Tue, Jul 2, 2019 at 2:47 PM Samuel Pitoiset
wrote:
>
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c
> b/src/amd/vulkan/radv_cmd_buffer.c
> index 322e705621f..a89d804aa65 100644
> ---
r-b
On Tue, Jul 2, 2019 at 2:47 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta_decompress.c | 66 +--
> 1 file changed, 41 insertions(+), 25 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_meta_decompress.c
>
1 - 100 of 2350 matches
Mail list logo
