Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

Hi Juan, I filed a bug about a test that was regressed by this patch: https://bugs.freedesktop.org/show_bug.cgi?id=104668 -Mark "Juan A. Suarez Romero" writes: > According with OpenGL GLSL 4.20 spec, section 4.3.9, page 57: > >"It is a link-time error if any

Re: [Mesa-dev] [PATCH] spirv: avoid infinite loop / freeze in vtn_cfg_walk_blocks()

This patch doesn't apply to master as formatted. I've reverted the bisected commit, since it disables testing on master. Eero Tamminen writes: > Fixes: 9702fac68e (spirv: consider bitsize when handling OpSwitch cases) > Bugzilla:

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Timothy Arceri <tarc...@itsqueeze.com> writes: > On 06/12/17 12:04, Mark Janes wrote: >> Jordan Justen <jordan.l.jus...@intel.com> writes: >> >>> On 2017-12-05 14:49:28, Mark Janes wrote: >>>> Jordan Justen <jordan.l.jus...@intel.com> write

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen <jordan.l.jus...@intel.com> writes: > On 2017-12-05 14:49:28, Mark Janes wrote: >> Jordan Justen <jordan.l.jus...@intel.com> writes: >> >> > On 2017-12-05 09:13:11, Mark Janes wrote: >> >> Jordan Justen <jordan.l.jus...@intel

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen <jordan.l.jus...@intel.com> writes: > On 2017-12-05 09:13:11, Mark Janes wrote: >> Jordan Justen <jordan.l.jus...@intel.com> writes: >> >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> >> Reviewed-by: Timothy Arceri &l

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

Jordan Justen writes: > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> Reviewed-by: Timothy Arceri >> >> Mark may want to consider adding some of the once a day type CI runs for >> this. For example running the test suite for two consecutive

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 13/48] intel/fs: Use the original destination region for int MUL lowering

This patch is CC'd to stable, but CTS regressions bisected to it: https://bugs.freedesktop.org/show_bug.cgi?id=103626 Please do not merge to stable until the bug is addressed. Jason Ekstrand writes: > Some hardware (CHV, BXT) have special restrictions on register

Re: [Mesa-dev] [PATCH] i965: disable NIR linking on HSW and below

This needs to be backported/cc'd to stable for the 17.3 release. Timothy Arceri writes: > Fixes: 379b24a40d3d "i965: make use of nir linking" > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103537 > --- > > Jason's fixes referenced in the bug report help a

Re: [Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

Dylan pushed this series through our CI, and there were no regressions. Emil Velikov writes: > [removing Neil's old email as it bounces] > > On 2 November 2017 at 19:01, Adam Jackson wrote: >> From: Neil Roberts >> >> It

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

gt; > On Wed, Nov 1, 2017 at 11:16 PM, Mark Janes <mark.a.ja...@intel.com> wrote: >> Mark Janes <mark.a.ja...@intel.com> writes: >> >>> Marek Olšák <mar...@gmail.com> writes: >>> >>>> Hi Mark, >>>> >>>> Can you try

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

Mark Janes <mark.a.ja...@intel.com> writes: > Marek Olšák <mar...@gmail.com> writes: > >> Hi Mark, >> >> Can you try the attached patches instead? > > After talking with Ken and Dylan, I realize that I missed a one-line > patch fro

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

gressions in CI. I'm testing the attached patches as well. > Thanks, > Marek > > On Wed, Nov 1, 2017 at 9:49 PM, Mark Janes <mark.a.ja...@intel.com> wrote: >> Dylan Baker <dy...@pnwbakers.com> writes: >> >>> I haven't run the CTS tests, but both the d

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

51) >> This is how I run piglit on i965: >> WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm >> piglit/bin/glinfo|head >> GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop >> >> Of course I have Radeon as my main GPU. >> >> Marek >>

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

you guys fix i965 when you have time? > > Marek > > On Thu, Oct 26, 2017 at 5:46 PM, Mark Janes <mark.a.ja...@intel.com> wrote: >> That fixed many issues, but: >> >> On deqp EGL tests, we get: >> >> dEQP-EGL.functional.create_context_ext.gl_42.r

Re: [Mesa-dev] [PATCH] meson: Add a dependency on nir_opcodes_h for freedreno

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Dylan Baker <dy...@pnwbakers.com> writes: > This fixes a race condition in the build. > > cc: Rob Clark <robdcl...@gmail.com> > Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> > --- > src/gallium

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

That fixed many issues, but: On deqp EGL tests, we get: dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion `ctx->Version > 0' failed. On ES31 CTS tests:

Re: [Mesa-dev] [PATCH] egl: reinstate _eglInitDriverFallbacks() calls

Tested-by: Mark Janes <mark.a.ja...@intel.com> Emil Velikov <emil.l.veli...@gmail.com> writes: > From: Emil Velikov <emil.veli...@collabora.com> > > Seems that a few function pointers are initialized by the function. > We could pick the missing ones and add th

Re: [Mesa-dev] [PATCH mesa 5/6] egl: move alloc & init out of _eglBuiltInDriver{DRI2, Haiku}

This patch causes wflinfo to segfault for Intel platforms. https://bugs.freedesktop.org/show_bug.cgi?id=103349 This has a high impact, because Intel engineers cannot test their patches until the commit is fixed or reverted. Eric Engestrom writes: > Note: dropping the

Re: [Mesa-dev] [PATCH] mapi/shared-glapi/test: rework glapitable.h handling

Tested-by: Mark Janes <mark.a.ja...@intel.com> Emil Velikov <emil.l.veli...@gmail.com> writes: > From: Emil Velikov <emil.veli...@collabora.com> > > Currently all the build systems but Meson generate the header in > src/mapi/glapi. Meson cannot do that since: >

Re: [Mesa-dev] [PATCH] include: Revert out the update of the Khronos GLX extension header.

Tested-by: Mark Janes <mark.a.ja...@intel.com> Reviewed-by: Mark Janes <mark.a.ja...@intel.com> I'd like to get this pushed right away, because Mesa CI is basically offline due to the subsequent build failures. Eric Anholt <e...@anholt.net> writes: > They made a mistake in

Re: [Mesa-dev] [PATCH] mesa: Disallow GL_RED/GL_RG with half-floats on GLES2.

Tested-by: Mark Janes <mark.a.ja...@intel.com> Eric Anholt <e...@anholt.net> writes: > Sure, you'd think that the combination of GL_OES_texture_half_float and > GL_EXT_texture_rg would mean that GL_RG16F exists, but it doesn't. > > Bugzilla: https://bugs.freedesktop.or

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

Tested-by: Mark Janes <mark.a.ja...@intel.com> Dave Airlie <airl...@gmail.com> writes: > From: Dave Airlie <airl...@redhat.com> > > When I realigned the bufferobj code, I didn't see the getters > were different, realign the getters to work the sam

Re: [Mesa-dev] [PATCH] glsl/linker: fix output variable overlap check

This patch regressed piglit and gl cts tests for the i965 driver https://bugs.freedesktop.org/show_bug.cgi?id=102904 Nicolai Hähnle writes: > From: Nicolai Hähnle > > Prevent an overflow caused by too many output variables. To limit the > scope of

Re: [Mesa-dev] [PATCH] i965: Don't reset aux_state on buffers without modifiers

https://bugs.freedesktop.org/show_bug.cgi?id=102856 Tested-by: Mark Janes <mark.a.ja...@intel.com> Jason Ekstrand <ja...@jlekstrand.net> writes: > On gen7-8 where we use CCS_D, we were setting AUX_STATE_AUX_INVALID > because that's the obvious aux state when there is no m

Re: [Mesa-dev] [PATCH 1/3] glsl: use 'declared_var' instead of 'var' after checking redeclarations

Sorry for the interruption to the CI's uptime. It looks like one of our developers force-pushed to the master branch of our automation, which generated a merge conflict in our automation. I've fixed it. -Mark Iago Toral writes: > Mark, I could not run this series through

Re: [Mesa-dev] [PATCH v2 1/5] i965/eu: add support for 1-OWord Block Read/Write messages

This series resolves https://bugs.freedesktop.org/show_bug.cgi?id=101985, currently blocking 17.2 release. Tested-by: Mark Janes <mark.a.ja...@intel.com> Samuel Iglesias Gonsálvez <sigles...@igalia.com> writes: > v2: > - Use nibctrl and the number of written/read owords to

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

Eric Anholt writes: > Tapani Pälli writes: > >> On 06/22/2017 02:08 AM, Eric Anholt wrote: >>> Tapani Pälli writes: >>> On 06/14/2017 01:12 AM, Eric Anholt wrote: > Tapani Pälli writes: >

Re: [Mesa-dev] [PATCH] egl: Fix predecence problem when setting __DRI_CTX_FLAG_NO_ERROR

Tested-by: Mark Janes <mark.a.ja...@intel.com> Kenneth Graunke <kenn...@whitecape.org> writes: > This accidentally set __DRI_CTX_FLAG_NO_ERROR whenever any flags were > present. Just needs extra parenthesis. > > Fixes: 4909519a6655 (egl: Add EGL_KHR_create_context_no_err

Re: [Mesa-dev] [PATCH] intel: Fix broxton 2x6 way size computation

Tested-by: Mark Janes <mark.a.ja...@intel.com> Anuj Phogat <anuj.pho...@gmail.com> writes: > This patch is undoing the changes to way size computation > in broxton 2x6, made by below commit: > > Commit: 0d576fbfbe912cf3fb9ab594bb31eb58bccf2138 > Author: Anuj Ph

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

Samuel Pitoiset <samuel.pitoi...@gmail.com> writes: > On 04/28/2017 06:58 PM, Mark Janes wrote: >> With this commit, a wide range of intel hardware began hanging during >> the GLES CTS, with dmesg errors like: >> >> [25488.739167] traps: glcts[15106] general

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

With this commit, a wide range of intel hardware began hanging during the GLES CTS, with dmesg errors like: [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 sp:7ffdcda85a20 error:0 Machines that did complete the cts, reported hundreds of errors like: *** Error in

Re: [Mesa-dev] [PATCH] anv/pipeline: Properly handle unset gl_Layer and gl_ViewportIndex

Tested-by: Mark Janes <mark.a.ja...@intel.com> Jason Ekstrand <ja...@jlekstrand.net> writes: > When the shader does not set one of these values, they are supposed to > get a default value of 0. We have hardware bits in 3DSTATE_CLIP for > this but haven't been sett

Re: [Mesa-dev] [PATCH v2] util/u_atomic: provide 64bit atomics where they're missing

This commit appears to intermittently provoke gpu hangs on 32-bit Intel systems when running piglit.shaders.glsl-max-varyings >max_varying_components Since the behavior is intermittent, I may have identified the wrong patch. Please let me know if this patch seems unlikely to affect the test.

Re: [Mesa-dev] [PATCH] getteximage: avoid to lookup textures with id 0

Does this work on AMD hardware? It regresses every Intel GPU. https://bugs.freedesktop.org/show_bug.cgi?id=100088 Samuel Pitoiset writes: > This fixes the following assertion when the key is 0. > > main/hash.c:181: _mesa_HashLookup_unlocked: Assertion `key' failed.

Re: [Mesa-dev] [PATCH] glsl: fix subroutine mismatch between declarations/definitions

quot;restores" the previous > behavior. > > Though, piglit.spec.arb_shader_subroutine.linker.no-overloads_vert > should be fixed in a separate patch. > > Mark, can you confirm? Yes, you are correct. Thanks for figuring out what happened. > Thanks! > > On 03/02/2017 06:56 PM, Mark Janes wrote: >

Re: [Mesa-dev] [PATCH] glsl: fix subroutine mismatch between declarations/definitions

_qualifier::is_subroutine_decl() to differentiate > declarations and definitions easily. > > This fixes a regression with: > arb_shader_subroutine/compiler/direct-call.vert > > Cc: Mark Janes <mark.a.ja...@intel.com> > Fixes: be8aa76afd ("glsl: remove unecessary fla

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

This patch breaks gl45-cts.shader_subroutine.static_subroutine_call. It also breaks piglit.spec.arb_shader_subroutine.compiler.direct-call_vert: Failed to compile vertex shader piglit/tests/spec/arb_shader_subroutine/compiler/direct-call.vert: 0:26(2): error: subroutine name cannot be a

Re: [Mesa-dev] [PATCH 29/32] util/disk_cache: check cache exists before calling munmap()

Timothy Arceri <tarc...@itsqueeze.com> writes: > On 17/02/17 12:20, Mark Janes wrote: >> This series breaks the scons build: >> >> src/compiler/glsl/linker.cpp:4641: undefined reference to >> `shader_cache_read_program_metadata(gl_context*, gl_shader_program*)'

Re: [Mesa-dev] [PATCH 29/32] util/disk_cache: check cache exists before calling munmap()

This series breaks the scons build: src/compiler/glsl/linker.cpp:4641: undefined reference to `shader_cache_read_program_metadata(gl_context*, gl_shader_program*)' Timothy Arceri writes: > --- > src/util/disk_cache.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

With this series, I encounter the following crash using wflinfo: wflinfo: src/mesa/drivers/dri/common/xmlconfig.c:1028: driQueryOptionb: Assertion `cache->info[i].name != ((void *)0)' failed. Samuel Pitoiset writes: > Mesa currently doesn't allow to create 3.1+

Re: [Mesa-dev] [PATCH] radeonsi: Fix build on LLVM < 3.9 v2

Tested-by: Mark Janes <mark.a.ja...@intel.com> Tom Stellard <thomas.stell...@amd.com> writes: > This was broken by: e0cc0a614c96011958bc3a1b84da9168e0e1ccbb > > v2: > - Use preprocessor macro > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c |

Re: [Mesa-dev] [PATCH] radeonsi: Fix build on LLVM < 3.9

I still get build errors when compiling with LLVM 3.6: Tom Stellard writes: > This was broken by: e0cc0a614c96011958bc3a1b84da9168e0e1ccbb > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 14 ++ > 1 file changed, 10 insertions(+), 4

Re: [Mesa-dev] [PATCH 1/2] intel/blorp: Handle clearing of A4B4G4R4 on all platforms

Tested-by: Mark Janes <mark.a.ja...@intel.com> Jason Ekstrand <ja...@jlekstrand.net> writes: > Cc: "13.0 17.0" <mesa-sta...@lists.freedesktop.org> > --- > src/intel/blorp/blorp_clear.c | 19 +++ > 1 file changed, 19 insertions(+) > >

Re: [Mesa-dev] [PATCH] mesa/main: fix version/extension checks in _mesa_ClampColor

This patch regressed i915 systems: https://bugs.freedesktop.org/show_bug.cgi?id=99401 Please don't apply to stable until the bug is resolved. Nicolai Hähnle writes: > From: Nicolai Hähnle > > Add a proper check for feature support, and raise an

Re: [Mesa-dev] [PATCH 0/8] i965: gl_TessLevel rescrambling in NIR

Eero Tamminen writes: > Hi, > > On 04.01.2017 13:07, Kenneth Graunke wrote: >> This series reworks i965's handling of gl_TessLevelInner/Outer[] arrays. >> Instead of using lower_tess_levels to turn them into vec4/vec2s, we pass >> them through to NIR and make them

Re: [Mesa-dev] [PATCH 5/6] nir: Add a pass for moving SPIR-V continue blocks to the ends of loops

Jason Ekstrand writes: > When shaders come in from SPIR-V, we handle continue blocks by placing > the contents of the continue inside of a "if (!first_iteration)". We do > this so that we can properly handle the fact that continues in SPIR-V > jump to the continue block at

Re: [Mesa-dev] [PATCH v2] egl/dri2: implement query surface hook

Tested-by: Mark Janes <mark.a.ja...@intel.com> Tapani Pälli <tapani.pa...@intel.com> writes: > This makes better guarantee that the values we return are > in sync what the underlying drawable currently has. > > Together with dEQP change in bug #98327 this fixes fol

Re: [Mesa-dev] [PATCH] egl: Fix crashes in eglCreate*Surface()

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Chad Versace <chadvers...@chromium.org> writes: > Don't dereference a null EGLDisplay. > > Fixes tests > dEQP-EGL.functional.negative_api.create_pbuffer_surface > dEQP-EGL.functional.negative_api.create_pixm

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

reply with a "Tested-by" tomorrow. >>> >>> >> >> Thanks for the kind reply, but I wonder if a more thorough testing >> should be done before applying this. I remember its i965 counterpart >> (commit 28090b30d) did cause some problem (Bug 90791) a

Re: [Mesa-dev] [Mesa-announce] Mesa 12.0.4 release candidate

Matt Turner writes: > On Tue, Nov 8, 2016 at 1:59 PM, Emil Velikov wrote: >> Jordan Justen (1) >> 49c24d8 i965: fix noop_scissor range issue on width/height >> Note: temporary on hold since it causes GPU lockups on 32bit builds. > > Let's just

Re: [Mesa-dev] [PATCH] egl: set preserved behavior for surface only if config supports it

Tested-by: Mark Janes <mark.a.ja...@intel.com> Tapani Pälli <tapani.pa...@intel.com> writes: > Otherwise we can end up with mismatching behavior between config and > surface when client queries surface attributes. As example, configs > for DRI3 do not support preserved beha

Re: [Mesa-dev] [PATCH 13/22] anv/wsi: split image alloc/free out to separate fns.

Dave Airlie writes: > From: Dave Airlie > > This moves these outside the wsi platform code, so we can reuse > that code > --- > src/intel/vulkan/anv_wsi.c | 121 +++- > src/intel/vulkan/anv_wsi.h | 19 - >

Re: [Mesa-dev] [PATCH] nir: Use the correct infos structure for copying atomic sources

Tested-by: Mark Janes <mark.a.ja...@intel.com> Jason Ekstrand <ja...@jlekstrand.net> writes: > Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> > Cc: "12.0" <mesa-...@lists.freedestkop.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> >

Re: [Mesa-dev] [PATCH v4] i965: Fix calculation of the image height at start level

This patch regresses es2-cts.gtf.gl2extensiontests.egl_image_external.testsimpleunassociated https://bugs.freedesktop.org/show_bug.cgi?id=97761 Antia Puentes writes: > - Fixes CTS tests: > > * GL44-CTS.shader_image_size.advanced-nonMS-cs-float > *

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

Hi Lionel, This patch triggered CID 1372521 in Coverity. Please let me know if my the analysis is correct below: Lionel Landwerlin writes: > Fixes new CTS tests : > > dEQP-VK.spirv_assembly.instruction.compute.opatomic.load >

Re: [Mesa-dev] [PATCH] mapi: add gl32.h to the list of GLES3 headers for installation

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Tested-by: Mark Janes <mark.a.ja...@intel.com> Ilia Mirkin <imir...@alum.mit.edu> writes: > This was missed when I added the updated (and new) Khronos headers. > > Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu>

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

I saw no regressions from these tests. However, I wasn't able to run the dEQP-EGL tests the last time I tried. What branch of dEQP are you running? InternalError (Runtime check failed: '(m_capabilities & CAPABILITY_GET_DISPLAY_PLATFORM) == 0' at egluNativeDisplay.cpp:70) -Mark Chad

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

I'll test it. Chad Versace writes: > Hi Intel folks, could one of you please run this through Jenkins? > I verified manually that it fixes the listed dEQP tests on Skylake. > > Chad Versace (2): > i965: Fix miptree layout for EGLImage-based renderbuffers > i965: Respect

Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

Tested-by: Mark Janes <mark.a.ja...@intel.com> Kenneth Graunke <kenn...@whitecape.org> writes: > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae > was entirely broken. A missing "break" made the load_interpolated_input > case always fa

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv: vulkan: remove the anv_device.$(OBJEXT) rule

In the interest of getting the build going again, I pushed this patch with Jason's review. Emil Velikov writes: > From: Emil Velikov > > Atm the actual rule will expand to foo.o which is used for static > libraries only. > > Thus the

Re: [Mesa-dev] [PATCH] i965: Skip update_texture_surface when the plane doesn't exist

On snb and ilk, this patch breaks piglit.spec.ext_image_dma_buf_import.ext_image_dma_buf_import-sample_nv1 https://bugs.freedesktop.org/show_bug.cgi?id=96674 Jordan Justen writes: > Reported-by: Grazvydas Ignotas > Bugzilla:

Re: [Mesa-dev] [PATCH 29/29] vbo: Use a bitmask to track the active arrays in vbo_save*.

Mathias Fröhlich <mathias.froehl...@gmx.net> writes: > On Monday, June 20, 2016 10:33:42 Mark Janes wrote: >> mathias.froehl...@gmx.net writes: >> >> > From: Mathias Fröhlich <mathias.froehl...@web.de> >> > >> > The use of a bitmask make

Re: [Mesa-dev] [PATCH 29/29] vbo: Use a bitmask to track the active arrays in vbo_save*.

mathias.froehl...@gmx.net writes: > From: Mathias Fröhlich > > The use of a bitmask makes functions iterating only active > attributes less visible in profiles. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/vbo/vbo_save.h | 2 ++

Re: [Mesa-dev] [PATCH 1/2] anv: let anv_entrypoints_gen.py generate proper Wayland/Xcb guards

Tested-by: Mark Janes <mark.a.ja...@intel.com> Emil Velikov <emil.l.veli...@gmail.com> writes: > From: Emil Velikov <emil.veli...@collabora.com> > > Similar to the vulkan headers, our code should include everything > properly guarded by the WSI VK_USE_PLATFORM_*_

Re: [Mesa-dev] [PATCH v2] c11/threads: resolve link issues with -O0

Tested-by: Mark Janes <mark.a.ja...@intel.com> Emil Velikov <emil.l.veli...@gmail.com> writes: > From: Emil Velikov <emil.veli...@collabora.com> > > Add weak symbol notation for the pthread_mutexattr* symbols, thus making > the linker happy. When building wit

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

Rob Clark <robdcl...@gmail.com> writes: > On Mon, May 23, 2016 at 5:16 PM, Mark Janes <mark.a.ja...@intel.com> wrote: >> I run a buildtest in our CI to help Intel engineers avoid breaking the >> builds for other Mesa targets. >> >> With this commit, it prod

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

I run a buildtest in our CI to help Intel engineers avoid breaking the builds for other Mesa targets. With this commit, it produces: make[2]: Entering directory '/home/majanes/src/mesa/src/gbm' CCLD libgbm.la backends/dri/.libs/gbm_dri.o: In function `mtx_init':

Re: [Mesa-dev] [PATCH] mesa: Build EGL without X11 headers after interop patchset

Tom Stellard <t...@stellard.net> writes: > On Fri, May 20, 2016 at 04:29:07PM -0700, Mark Janes wrote: >> Tom Stellard <t...@stellard.net> writes: >> >> > On Wed, Apr 27, 2016 at 10:33:14PM +, Youry Metlitsky wrote: >> >> --- >> >>

Re: [Mesa-dev] [PATCH] mesa: Build EGL without X11 headers after interop patchset

Tom Stellard writes: > On Wed, Apr 27, 2016 at 10:33:14PM +, Youry Metlitsky wrote: >> --- >> include/GL/mesa_glinterop.h | 15 ++- >> 1 file changed, 14 insertions(+), 1 deletion(-) >> > > Hi, > > This patch breaks the build for me: > > glxcmds.c:2699:1:

Re: [Mesa-dev] [PATCH] glsl: Guard against NULL dereference

ts in the table, but it is not a type. add_type() fails, then get_type() fails. > On Fri, May 20, 2016 at 11:58 AM, Mark Janes <mark.a.ja...@intel.com> wrote: >> This trivially corrects mesa 3ca1c221, which introduced a check that >> crashes when a match is not found. >>

[Mesa-dev] [PATCH] glsl: Guard against NULL dereference

This trivially corrects mesa 3ca1c221, which introduced a check that crashes when a match is not found. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95005 Fixes: piglit.spec.glsl-1_50.compiler.interface-blocks-name-reused-globally-4.vert --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1

[Mesa-dev] [PATCH] i965: Fix strerror error code sign

This trivial fix to error-handling corrects the sign of drm error codes before passing them to strerror. Identified by Coverity: CID1358581 --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

[Mesa-dev] [PATCH] anv/batch_chain: free pointers for error cases

Trivial fix to improperly handled cleanup during VK_ERROR_OUT_OF_HOST_MEMORY. Identified by Coverity: CID 1358908 and 1358909 --- src/intel/vulkan/anv_batch_chain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c

[Mesa-dev] [PATCH] i965: check tcs for NULL dereference

Coverity issue 1361544 found an instance where the tcs variable is checked for NULL, but unconditionally dereferenced later in the same function. CC: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_tcs.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH] i965/fs: Default all constants to a location of -1

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Jason Ekstrand <ja...@jlekstrand.net> writes: > Otherwise constants which aren't live get an undefined constant location. > When we go to set up param and pull_param we end up assigning all unused > uniforms to slot 0.

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

Gurchetan Singh writes: > This change enables the creation of pbuffer > surfaces on the surfaceless platform. > > V2: Use double-buffered pbuffer configuration > --- > src/egl/drivers/dri2/egl_dri2.h | 8 +- >

[Mesa-dev] [PATCH] mesa/objectlabel: handle NULL src string

This prevents a crash when a NULL src is passed with a non-NULL length. fixes: dEQP-GLES31.functional.debug.object_labels.query_length_only Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95252 Signed-off-by: Mark Janes <mark.a.ja...@intel.com> --- src/mesa/main/objectlabel

Re: [Mesa-dev] [PATCH] i965/fs: Follow pow(16) instructions with a NOP.

Tested-by: Mark Janes <mark.a.ja...@intel.com> Matt Turner <matts...@gmail.com> writes: > Beginning with commit 7b208a73, Unigine Valley began hanging the GPU on > Gen >= 8 platforms. This patch avoids the GPU hangs, but does not > implement a full work around for the res

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

sitor::visit_leave(ir_assignment*): Assertion `!"should have been lowered"' failed." Mark Janes <mark.a.ja...@intel.com> writes: > Samuel Iglesias Gonsálvez <sigles...@igalia.com> writes: > >> Hello, >> >> This patch series continues adding arb_gpu_

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

Samuel Iglesias Gonsálvez writes: > Hello, > > This patch series continues adding arb_gpu_shader_fp64 support to the > Intel driver. Specifically, this targets the i965 scalar backend for > BDW+ hardware (vec4 is still under research and gen7 has its own > issues which we

Re: [Mesa-dev] [PATCH] mesa: Fix indirect draw buffer size check on 32-bit systems.

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Kenneth Graunke <kenn...@whitecape.org> writes: > Fixes dEQP-GLES31.functional subtests: > draw_indirect.negative.command_offset_not_in_buffer_signed32_wrap > draw_indirect.negative.command_offset_not_in_buffer_unsigned32_wra

Re: [Mesa-dev] [PATCH 02/13] nir/builder: Add bit_size info to nir_build_imm()

Hi Samuel, When this patch was pushed, it broke the vulkan build. Can you please add "--with-vulkan-drivers=intel" to the build-test that you run before pushing? thanks, Mark Samuel Iglesias Gonsálvez writes: > Signed-off-by: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] [PATCH 2/4] mesa: Disallow CopyTexSubImage on stencil formats in ES.

Kenneth Graunke writes: > Fixes > - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8 > - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample After this patch was pushed, I still see Gen9 failures for

Re: [Mesa-dev] [PATCH] util/list: Add list splicing functions

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Jason Ekstrand <ja...@jlekstrand.net> writes: > This adds functions for splicing one list into another. These have > more-or-less the same API as the kernel list splicing functions. > --- > src/util/list.h | 22

Re: [Mesa-dev] [PATCH] i965/fs: Don't allow OOB array access of images

Tested-by: Mark Janes <mark.a.ja...@intel.com> Jason Ekstrand <ja...@jlekstrand.net> writes: > We have had a guard against OOB array access of images on IVB for a long > time, but it can actually cause hangs on any GPU generation. This can > happen due to getting an

Re: [Mesa-dev] [PATCH] util: Fix warning of invalid return value

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Chad Versace <chad.vers...@intel.com> writes: > _mesa_libgcrypt_init() returns NULL, but its return type is void. > > Cc: Mark Janes <mark.a.ja...@intel.com> > --- > src/util/mesa-sha1.c | 3 ++- > 1 file

Re: [Mesa-dev] [PATCH] util: Fix race condition on libgcrypt initialization

Jason Ekstrand <ja...@jlekstrand.net> writes: > On Tue, Apr 12, 2016 at 3:51 PM, Jason Ekstrand <ja...@jlekstrand.net> > wrote: > >> >> On Apr 12, 2016 3:41 PM, "Matt Turner" <matts...@gmail.com> wrote: >> > >> > On Tue, Ap

[Mesa-dev] [PATCH] util: Fix race condition on libgcrypt initialization

Fixes intermittent Vulkan CTS failures within the test groups: dEQP-VK.api.object_management.multithreaded_per_thread_device dEQP-VK.api.object_management.multithreaded_per_thread_resources dEQP-VK.api.object_management.multithreaded_shared_resources Signed-off-by: Mark Janes <mark.a

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

Iago Toral writes: > On Wed, 2016-03-09 at 09:54 +0200, Pohjolainen, Topi wrote: >> On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: >> > Hello, >> > >> > There is only one patch from this series that has been reviewed (patch >> > 1). >> > >> > Our

Re: [Mesa-dev] vulkan: Move XML and generator into src/intel/genxml

Steven Newbury writes: > On Sun, 2016-02-21 at 12:01 +, Steven Newbury wrote: >> On Sun, 2016-02-21 at 11:28 +, Steven Newbury wrote: >> > On Sun, 2016-02-21 at 10:56 +, Steven Newbury wrote: >> > > On Sun, 2016-02-21 at 10:16 +, Steven Newbury

Re: [Mesa-dev] [PATCH] Revert "i965: Restore vbo after color resolve during brw_try_draw_prims()"

Ben Widawsky writes: > On Mon, Feb 15, 2016 at 11:34:03AM +0200, Topi Pohjolainen wrote: >> This got pushed accidentally in the first place but wasn't reverted >> as it didn't regress piglit but instead fixed one newly introduced >> test exercising a corner in case

Re: [Mesa-dev] [PATCH] [v2] i965/bxt: Production thread counts

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Ben Widawsky <benjamin.widaw...@intel.com> writes: > v2: Forgot to squash in the comment removal > > Signed-off-by: Ben Widawsky <benjamin.widaw...@intel.com> > --- > src/mesa/drivers/dri/i965/brw_device_info.c |

Re: [Mesa-dev] [PATCH] i965/bxt: Fix conservative wm thread counts.

Tested-by: Mark Janes <mark.a.ja...@intel.com> Ben Widawsky <benjamin.widaw...@intel.com> writes: > When setting the conservative thread counts, I halved everything. That isn't > correct for the wm, which has nothing to do with actual thread counts. I suck. > &

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

in a single layout(...), this > change triggers the rules for multiple layouts. > > Cc: Mark Janes <mark.a.ja...@intel.com> > --- > src/glsl/ast_type.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp > index cf494d9..e0e33

Re: [Mesa-dev] [PATCH v2] Add missing platform information for KBL

Thanks Sarah. I'll turn on KBL testing in the CI. Sarah Sharp <sarah.a.sh...@linux.intel.com> writes: > From: Mark Janes <mark.a.ja...@intel.com> > > In testing KBL, I found: > > - urb size was not set for slices gt1.5, gt2, and gt3. The value I >used for the

[Mesa-dev] [PATCH] Add missing platform information for KBL

With this commit, KBL passes piglit at parity with SKL. Signed-off-by: Mark Janes <mark.a.ja...@intel.com> --- src/mesa/drivers/dri/i965/brw_device_info.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_

Re: [Mesa-dev] [PATCH] Add missing platform information for KBL

Sarah Sharp <sarah.a.sh...@intel.com> writes: > On Fri, Jan 08, 2016 at 04:30:20PM -0800, Mark Janes wrote: >> In testing KBL, I found: >> >> - urb size was not set for slices gt1.5, gt2, and gt3. The value I >>used for these slices (384) was tak

Re: [Mesa-dev] [PATCH] i915: correctly parse/set the context flags

Reviewed-by: Mark Janes <mark.a.ja...@intel.com> Tested-by: Mark Janes <mark.a.ja...@intel.com> Emil Velikov <emil.l.veli...@gmail.com> writes: > With an earlier commit we've spit the flags parsing to a separate > function, but forgot to update all the dri modules to

Re: [Mesa-dev] [Mesa-announce] Mesa 11.1.0 release candidate 1

Hi Emil, I noticed that this branchpoint is after the KHR_DEBUG patches which broke GL conformance. Is the plan to resolve this bug before release? https://bugs.freedesktop.org/show_bug.cgi?id=93048 -Mark Emil Velikov writes: > On 23 November 2015 at 09:18, Thierry

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

Hi Emil, I get this regression testing the new branch: piglit.spec.oes_compressed_paletted_texture.basic api /tmp/build_root/m64/lib/piglit/bin/oes_compressed_paletted_texture-api -auto -fbo Trying glTexImage2D... Trying glCompressedTexImage2D... Unexpected GL error: GL_INVALID_ENUM 0x500

<    1   2   3   >