On Thu, Jan 26, 2017 at 10:27 AM, Emil Velikov wrote:
> With this in mind we can drop the LLVM requirement, which some
> builders/distros explicitly patch out.
Like who?
I'm not sure why binary distros would do such a thing. Gentoo used to
have a patch that removed the AC_MSG_ERROR from configur
On Fri, Jan 27, 2017 at 2:18 PM, Jason Ekstrand wrote:
> This causes hangs on Broadwell if you try to render to it. I have no
> idea how we managed to not hit this earlier.
>
> Cc: "13.0 17.0"
> ---
> src/intel/isl/isl_format.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> di
This partially reverts commit 97217a40f97cdeae0304798b607f704deb0c3558.
It leaves ES 2.0 support in place per Ian's suggestion, because ES 2.0
is designed to work on hardware like i915.
The piglit results look like:
name: before-revert-i915 after-revert-i915
--
On Sun, Jan 29, 2017 at 8:29 PM, Kenneth Graunke wrote:
> On Sunday, January 29, 2017 6:20:10 PM PST Matt Turner wrote:
>> This partially reverts commit 97217a40f97cdeae0304798b607f704deb0c3558.
>> It leaves ES 2.0 support in place per Ian's suggestion, because ES 2.0
>&
Previously if you used MESA_GL_VERSION_OVERRIDE=3.3COMPAT, Mesa exposed
an OpenGL 3.3 compatibility profile context (with various unimplemented
features and bugs), but still refused to compile shaders with
#version 330 compatibility
This patch simply adds a small bit of plumbing to let that th
On Fri, Feb 3, 2017 at 5:37 PM, Jason Ekstrand wrote:
> On Thu, Feb 2, 2017 at 11:18 PM, Ben Widawsky wrote:
>> s/Sky Lake/Skylake/g
>
>
> I can never figure out which it's supposed to be. The PRM says "Skylake"
> but I thought ARC said "Sky Lake" but, now that I look, it says "Skylake"
> too.
On Mon, Feb 6, 2017 at 3:02 PM, Emil Velikov wrote:
> The third release candidate for Mesa 17.0.0 is now available.
>
> Note that we have a couple of issues that I'd like to see fixed.
> If those are be not sorted by this Friday the final release will be
> out, regardless.
I don't think it's acce
On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák wrote:
> On Tue, Feb 7, 2017 at 2:57 AM, Kenneth Graunke wrote:
>> On Monday, February 6, 2017 8:54:40 PM PST Marek Olšák wrote:
>>> On Mon, Feb 6, 2017 at 8:20 PM, Ernst Sjöstrand wrote:
>>> > FYI glmark2 segfaults with mesa_glthread=true. Expected t
On Tue, Feb 7, 2017 at 4:42 AM, Timothy Arceri wrote:
> This series adds support for a GLSL IR level and TGSI (OpenGL/st)
> level caches.
>
> There are a few small bug fixes and a little bit of restructuring
> to the GLSL IR patches to make things work for Gallium drivers vs
> just i965 previously
On Wed, Feb 8, 2017 at 12:31 AM, Timothy Arceri wrote:
> On Tue, 2017-02-07 at 23:58 +0100, Matt Turner wrote:
>> On Tue, Feb 7, 2017 at 4:42 AM, Timothy Arceri > > wrote:
>> > This series adds support for a GLSL IR level and TGSI (OpenGL/st)
>> > level caches.
&g
On Wed, Feb 8, 2017 at 11:38 AM, Bas Nieuwenhuizen
wrote:
> On Wed, Feb 8, 2017, at 11:25, Matt Turner wrote:
>> On Wed, Feb 8, 2017 at 12:31 AM, Timothy Arceri
>> wrote:
>> > On Tue, 2017-02-07 at 23:58 +0100, Matt Turner wrote:
>> >> On Tue, Feb 7, 2017 at
On Wed, Feb 8, 2017 at 6:03 PM, Marek Olšák wrote:
> From: Paul Berry
>
> This is not yet used in the build, just generated.
>
> v2: Add missing build dependencies.
> v3: Avoid mixing declarations and code, remove logic for avoiding emitting
> code that the compiler's optimizer can deal with
On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> The two symbols referenced were introduced with v2.2 and 2.3 of
> the dri2proto package.
... and we require dri2proto >= 2.6.
Reviewed-by: Matt Turner
___
m
On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> Macro will always be defined as of earlier commit.
How about something like
DRI2DriverPrimeShift was added in dri2proto-2.8, which we now require
as of the previous commit.
_
On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> Macro will always be defined as of earlier commit.
Same comment as 04/10.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin
On Thu, Feb 9, 2017 at 3:22 PM, Matt Turner wrote:
> On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> The two symbols referenced were introduced with v2.2 and 2.3 of
>> the dri2proto package.
>
> ... and we require dri2proto >
On Thu, Feb 9, 2017 at 3:03 PM, Marek Olšák wrote:
> On Thu, Feb 9, 2017 at 1:52 PM, Ian Romanick wrote:
>> On 02/08/2017 10:26 AM, Nicolai Hähnle wrote:
>>> On 07.02.2017 23:54, Matt Turner wrote:
>>>> On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák wrote:
>&g
On Wed, Feb 8, 2017 at 6:03 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/include/state_tracker/st_api.h | 19 +++
> src/gallium/state_trackers/dri/dri_context.c| 10 ++
> src/gallium/state_trackers/dri/dri_drawable.c | 6 ++
> src/galli
Patches' titles should have a prefix. These should likely be "i965: "
Also, I don't know what you mean by a label. The target of an
unstructured jump? The commit message should explain and provide some
background information.
On Mon, Feb 13, 2017 at 3:25 AM, Lonnberg, Toni wrote:
> ---
> src/in
On Mon, Feb 13, 2017 at 3:25 AM, Lonnberg, Toni wrote:
> ---
> src/mesa/drivers/dri/i965/brw_disasm.c | 109
> +++--
> src/mesa/drivers/dri/i965/brw_inst.h | 31 +-
> 2 files changed, 135 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i
On Mon, Feb 13, 2017 at 3:25 AM, Lonnberg, Toni wrote:
> ---
We need a summary message that gives an overview of what's going on.
I see at least the following changes:
- Colon before the register type
- Semi-colon instead of comma after VertStride
- Printing swizzles on 3-src arguments wi
;"
Reviewed-by: Matt Turner
I'll give it a day or so before I commit it, so others have an
opportunity to comment.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Feb 14, 2017 at 7:35 AM, Grazvydas Ignotas wrote:
> On Tue, Feb 14, 2017 at 3:12 PM, Haridasan, Sujith
> wrote:
>> I am using mesa 12.0.1 from yocto project
>> (http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-graphics/mesa/mesa_12.0.1.bb?h=morty).
>> While building core-i
Provides the ability to read the .note.gnu.build-id section of ELF
binaries, which is inserted by the --build-id=... flag to ld.
---
configure.ac | 2 +
src/util/Makefile.sources | 2 +
src/util/build_id.c | 109 ++
src/util/build_
The --build-id=... ld flag has been present since binutils-2.18,
released 28 Aug 2007.
---
src/intel/vulkan/Makefile.am | 1 +
src/intel/vulkan/anv_device.c | 31 ---
2 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/src/intel/vulkan/Makefile.am b/src/i
On Tue, Feb 7, 2017 at 3:31 PM, Timothy Arceri wrote:
> On Tue, 2017-02-07 at 23:58 +0100, Matt Turner wrote:
>> On Tue, Feb 7, 2017 at 4:42 AM, Timothy Arceri > > wrote:
>> > This series adds support for a GLSL IR level and TGSI (OpenGL/st)
>> > level caches.
&g
On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand wrote:
> I'm not sure how I feel about the silent fall-backs. At least in the Vulkan
> driver, we should fail to compile if we can't get build-id. Otherwise,
> you'll end up compiling a driver that will always fail device creation.
That was reall
On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner wrote:
> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand wrote:
>> I'm not sure how I feel about the silent fall-backs. At least in the Vulkan
>> driver, we should fail to compile if we can't get build-id. Otherwise,
>
On Tue, Feb 14, 2017 at 11:21 AM, Matt Turner wrote:
> On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner wrote:
>> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand
>> wrote:
>>> I'm not sure how I feel about the silent fall-backs. At least in the Vulkan
>>> d
On Tue, Feb 14, 2017 at 11:39 AM, Kristian H. Kristensen
wrote:
> Matt Turner writes:
>> diff --git a/src/util/build_id.c b/src/util/build_id.c
>> new file mode 100644
>> index 000..a2e21b7
>> --- /dev/null
>> +++ b/src/util/build_id.c
>> @@ -0,0 +
On Tue, Feb 14, 2017 at 12:43 PM, Nicholas Miell wrote:
> On 02/14/2017 12:30 PM, Chad Versace wrote:
>>
>> On Tue 14 Feb 2017, Matt Turner wrote:
>>>
>>> Provides the ability to read the .note.gnu.build-id section of ELF
>>> binaries, which is
The --build-id=... ld flag has been present since binutils-2.18,
released 28 Aug 2007.
---
src/intel/vulkan/Makefile.am | 1 +
src/intel/vulkan/anv_device.c | 28 +++-
2 files changed, 8 insertions(+), 21 deletions(-)
diff --git a/src/intel/vulkan/Makefile.am b/src/intel
Provides the ability to read the .note.gnu.build-id section of ELF
binaries, which is inserted by the --build-id=... flag to ld.
---
configure.ac | 2 +
src/util/Makefile.sources | 2 +
src/util/build_id.c | 110 ++
src/util/build_
On Tue, Feb 14, 2017 at 3:52 PM, Jason Ekstrand wrote:
> The new version does a SHA1 sum of the timestamp together with the
> device PCI ID. This fixes a theoretical bug where, if you moved a drive
> between machines, you could end up trying to use a pipeline cache from
> one platform with a diff
Reviewed-by: Matt Turner
Please commit ASAP.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
applicable and not another string ? Worth adding a note/comment ?
It's generated by GNU ld in all cases I'm aware of, so I think it's the same.
> On 14 February 2017 at 23:58, Matt Turner wrote:
>> Provides the ability to read the .note.gnu.build-id section of ELF
>&
On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov wrote:
> Hi Matt,
>
> On 14 February 2017 at 23:58, Matt Turner wrote:
>> The --build-id=... ld flag has been present since binutils-2.18,
>> released 28 Aug 2007.
>> ---
>> src/intel/vulkan/Makefile.am | 1 +
>&
The --build-id=... ld flag has been present since binutils-2.18,
released 28 Aug 2007.
---
src/intel/vulkan/Makefile.am | 1 +
src/intel/vulkan/anv_device.c | 28 +++-
2 files changed, 8 insertions(+), 21 deletions(-)
diff --git a/src/intel/vulkan/Makefile.am b/src/intel
Provides the ability to read the .note.gnu.build-id section of ELF
binaries, which is inserted by the --build-id=... flag to ld.
Reviewed-by: Emil Velikov
---
configure.ac | 6 +++
src/util/Makefile.sources | 2 +
src/util/build_id.c | 109 +
On Thu, Feb 16, 2017 at 4:29 AM, Lionel Landwerlin
wrote:
> Signed-off-by: Lionel Landwerlin
> ---
> run.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/run.c b/run.c
> index 2654bff..d2ec8c6 100644
> --- a/run.c
> +++ b/run.c
> @@ -307,7 +307,7 @@ const struct
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99660
>
No newline here.
> Signed-off-by: Samuel Iglesias Gonsálvez
> Tested-by: Mark Janes
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://
On Thu, Feb 16, 2017 at 9:11 AM, Hugues Evrard wrote:
> Hi all,
>
> I'm a researcher at Imperial College London, my group is working on a
> testing framework for graphics drivers, in particular shader compilers,
> and we would like to get in touch with Mesa shader compiler developers.
>
> Our appr
On Tue, Feb 14, 2017 at 1:45 PM, Kenneth Graunke wrote:
> diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.h
> b/src/mesa/drivers/dri/i965/intel_batchbuffer.h
> index bf7cadfc4d6..da8f7e561f4 100644
> --- a/src/mesa/drivers/dri/i965/intel_batchbuffer.h
> +++ b/src/mesa/drivers/dri/i965/in
On Fri, Feb 17, 2017 at 5:39 AM, Emil Velikov wrote:
> On 17 February 2017 at 01:10, Jonathan Gray wrote:
>> On Thu, Feb 16, 2017 at 04:25:02PM +, Emil Velikov wrote:
>>> On 16 February 2017 at 14:23, Jonathan Gray wrote:
>>> > On Wed, Feb 15, 2017 at 11:11
On Thu, Feb 16, 2017 at 4:29 AM, Lionel Landwerlin
wrote:
> Intel produces fairly beefy Xeon servers on which it would be nice to be
> able to run shader-db to get some results pretty fast. Unfortunately those
> don't ship with any intel graphics IP (only ancient Matrox cards).
>
> This new script
On Fri, Feb 17, 2017 at 1:56 AM, Kenneth Graunke wrote:
> The only feature over and above ES 3.0 is DrawTransformFeedback().
>
> We already have to do the whole SOL_NUM_PRIMS_WRITTEN counter dance in
> order to compute the SVBI value for ResumeTransformFeedback(), at which
> point our existing Get
; +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> +* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> +* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN THE
> +* SOFTWARE.""")
> +
> +C_TEMPLATE = Template(textwrap.dedent(u"""\
> +/* Autogenerated file -- do not edit
> + * generated by ${file}
> + *
> + ${copyright}
> + */
> +
> +#include
> +#include "util/macros.h"
> +#include "vk_enum_to_str.h"
> +
> +% for enum in enums:
> +
> +const char *
> +vk_${enum.name[2:]}_to_str(${enum.name} input)
> +{
> +switch(input) {
> +% for v in enum.values:
> +case ${v}:
> +return "${v}";
"case", like "default", shouldn't be indented.
Acked-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Nice, thanks.
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, Feb 17, 2017 at 4:59 PM, Eric Engestrom wrote:
> Hey all,
>
> I (finally) set up the git hook, which means that the website [1] is now
> automagically updated whenever a change in docs/* on master is pushed.
>
> There might be bugs, and I'll be doing some other git hook related
> changes l
On Sat, Feb 18, 2017 at 1:31 PM, Jacob Lifshay wrote:
> This commit improves the message by telling them that they could probably
> enable DRI3. More importantly, it includes a little heuristic to check
> to see if we're running on AMD or NVIDIA's proprietary X11 drivers and,
> if we are, doesn't
On Sun, Feb 19, 2017 at 3:23 PM, Eric Engestrom wrote:
> Tested with dEQP-EGL.functional.get_proc_address.*
>
> Signed-off-by: Eric Engestrom
> ---
> src/egl/main/eglapi.c | 37 -
> 1 file changed, 24 insertions(+), 13 deletions(-)
>
> diff --git a/src/egl/mai
On Wed, Feb 22, 2017 at 12:06 AM, Iago Toral Quiroga wrote:
> From: Iago Toral Quiroga
Oops :)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri wrote:
> For gpu generations that use LLVM we create a timestamp string
> containing both the LLVM and Mesa build times, otherwise we just
> use the Mesa build time.
Why not use the build id for Mesa?
___
On Wed, Feb 22, 2017 at 2:12 PM, Timothy Arceri wrote:
> On 23/02/17 08:46, Matt Turner wrote:
>> On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri
>> wrote:
>>>
>>> For gpu generations that use LLVM we create a timestamp string
>>> containing both the LL
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
s/flacky/flakey/ in the title.
On Thu, Feb 23, 2017 at 9:13 AM, Emil Velikov wrote:
> From: Emil Velikov
>
> Note that all the symbols/ABI checks in tree do so :-\
>
> Signed-off-by: Emil Velikov
> ---
> Mostly an RFC since the es*api code might be going soon.
Tell me more :)
> ---
> src/map
On Thu, Feb 23, 2017 at 9:29 AM, Emil Velikov wrote:
> On 23 February 2017 at 17:22, Dylan Baker wrote:
>> Quoting Emil Velikov (2017-02-23 02:32:17)
>>> On 22 February 2017 at 23:35, Dylan Baker wrote:
>>> > This changes the python generator to write the files itself, rather than
>>> > piping t
On Thu, Feb 23, 2017 at 11:41 AM, Emil Velikov wrote:
> On 30 January 2017 at 02:20, Matt Turner wrote:
>> This partially reverts commit 97217a40f97cdeae0304798b607f704deb0c3558.
>> It leaves ES 2.0 support in place per Ian's suggestion, because ES 2.0
>> is designe
On Fri, Feb 24, 2017 at 3:48 PM, Jason Ekstrand wrote:
> The algorithms used by this pass, especially for division, are heavily
> based on the work Ian Romanick did for the similar int64 lowering pass
> in the GLSL compiler.
>
> v2: Properly handle vectors
>
> v3: Get rid of log2_denom stuff. Sin
Both are
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Both look good to me.
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Sun, Feb 26, 2017 at 12:31 PM, Constantine Charlamov
wrote:
> Initially I was trying to implement for r600 optimization like in the
> d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed
> because I need to learn some more about GPUs internals. For another time.
> Anyway,
On Tue, Jul 28, 2015 at 12:06 PM, Jason Ekstrand wrote:
> The meta CopyImageSubData path uses BlitFramebuffers to do the actual copy.
> The only thing that can affect BlitFramebuffers other than the currently
> bound framebuffers is the scissor so we need to save that off and reset it.
> If we don
On Tue, Jul 28, 2015 at 4:45 PM, Anuj Phogat wrote:
> brw_cs.cpp:386:27: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Wed, Jul 29, 2015 at 10:11 AM, Anuj Phogat wrote:
> Fixes following compiler warning:
> brw_cs.cpp:386:27: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>
> Signed-off-by: Anuj Phogat
> Cc: Matt Turner
> ---
Perfect. Thanks!
Rev
On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov wrote:
> Strictly speaking the xcb_connection_has_error() might be sufficient,
> yet the documentation does not mention what will happen if NULL is fed
> to the function.
>
> Keep things explicit, which will allow us to remove the dri2_dpy->conn
> chec
On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov wrote:
> This is a port of commit 7bd95ec437a(dri2: Trust our own driver name
> lookup over the server's.) from glx/dri2.
>
> Cc: Eric Anholt
> Cc: Julien Isorce
> Reported-by: Julien Isorce
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dr
Static analysis tools don't like partial object initializations.
---
src/glsl/lower_subroutine.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/glsl/lower_subroutine.cpp b/src/glsl/lower_subroutine.cpp
index e45ccfe..b29912a 100644
--- a/src/glsl/lower_subroutine.c
On Wed, Jul 29, 2015 at 8:12 PM, Vinson Lee wrote:
> u_surface.c: In function 'util_resource_copy_region':
> u_surface.c:257:21: warning: variable 'src_format' set but not used
> [-Wunused-but-set-variable]
> enum pipe_format src_format, dst_format;
> ^
>
> Signed-off-by:
On Thu, Jul 30, 2015 at 2:31 PM, Ben Widawsky
wrote:
> Recommended-by: Kenneth Graunke
> Signed-off-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/Makefile.sources | 1 +
> src/mesa/drivers/dri/i965/gen6_constant_state.c | 189
>
> src/mesa/drivers/dri/i965/
ck, fs_inst, inst, cfg) {
> + if (inst->dst.file == GRF) {
> + fsv_assert(inst->dst.reg_offset + inst->regs_written <=
> alloc.sizes[inst->dst.reg]);
Line wrap.
> + }
> +
> + for (unsigned i = 0; i < inst->sources; i++) {
> + if (inst->src[i].file == GRF) {
> +fsv_assert(inst->src[i].reg_offset + inst->regs_read(i) <=
> (int)alloc.sizes[inst->src[i].reg]);
Line wrap.
I noticed the (int) cast and checked whether regs_read() actually
needs to return a negative value, and it doesn't. You might want to
change regs_read() to return unsigned and remove the cast.
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, Jul 31, 2015 at 7:13 AM, Roland Scheidegger wrote:
> CC mesa-dev.
>
> This looks good to me. I am starting to wonder though why we don't just
> use lrintf() and let the compiler sort it out (for x86 too).
> Though actually some quick experiments show that:
> - llvm's clang will always use
iver interface for glMemoryBarrierByRegion
> mesa/es3.1: Implement the entry point of MemoryBarrierByRegion
> i965/es3.1: Implement glMemoryBarrierByRegion
Patches 1-3 are
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
On Fri, Jul 31, 2015 at 5:15 AM, Marta Lofstedt
wrote:
> From: Marta Lofstedt
>
> Signed-off-by: Marta Lofstedt
> ---
> src/mesa/drivers/dri/i965/brw_program.c | 34
> +
> 1 file changed, 34 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_program.c
On Fri, Jul 31, 2015 at 9:57 AM, Ilia Mirkin wrote:
> Won't this cause a compilation failure in mesa? I thought it'd start
> looking for the _mesa_MemoryBarrierByRegion function. Normally this is
> added as a stub in the first commit, and then the real impl comes
> later.
Yeah, that's probably tr
On Fri, Jul 31, 2015 at 10:25 AM, Ilia Mirkin wrote:
> On Fri, Jul 31, 2015 at 8:15 AM, Marta Lofstedt
> wrote:
>> From: Marta Lofstedt
>>
>> Signed-off-by: Marta Lofstedt
>> ---
>> src/mesa/drivers/dri/i965/brw_program.c | 34
>> +
>> 1 file changed, 34 insert
I'm not sure what the true meaning of "The rounding mode may vary." is,
but it is the case that the IROUND() path rounds differently than the
other paths (and does it wrong, at that).
Like _mesa_roundeven{f,}(), just add an use _mesa_lroundeven{f,}() that
has known semantics.
---
src/mesa/main/fo
Cuts about 9k of .text size.
textdata bss dec hex filename
4992804 197808 26328 5216940 4f9aac i965_dri.so before
4983676 197808 26328 5207812 4f7704 i965_dri.so after
Also, Darwin's libm does not ever set errno, so if we care about those
systems we shouldn't rely on er
lroundf is the most common replacement. I replaced uses of IROUND()
where there was a comment saying "rounded to nearest integer" with
_mesa_lroundevenf.
IROUND64 is replaced with llroundf.
---
src/mesa/main/drawpix.c | 21 +++--
src/mesa/main/eval.c| 14 ++
gcc actually generates this for us now that we use -fno-math-errno
(which is weird, since lrintf()/lrint() don't set errno) but clang still
does not. Presumably helps MSVC as well.
Reduced .text size by 8.5k with gcc before -fno-math-errno.
text data bss dec hex filename
49
Cuts about 1k of .text size.
textdata bss dec hex filename
4983676 197808 26328 5207812 4f7704 i965_dri.so before
4982522 197800 26328 5206650 4f727a i965_dri.so after
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac
---
src/glsl/ir_constant_expression.cpp | 14 --
src/mesa/main/imports.c | 4 ++--
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/glsl/ir_constant_expression.cpp
b/src/glsl/ir_constant_expression.cpp
index 2853c16..309b6b7 100644
--- a/src/glsl/ir_con
Functional change in which way half-way cases are rounded from towards
positive-infinity to even. The spec says "the passed value is rounded to
the nearest integer". Removes another case of bad half-up rounding.
---
src/glx/pixelstore.c | 25 +
1 file changed, 13 insertions
On Fri, Jul 31, 2015 at 4:41 PM, Ilia Mirkin wrote:
> On Fri, Jul 31, 2015 at 7:26 PM, Matt Turner wrote:
>> gcc actually generates this for us now that we use -fno-math-errno
>> (which is weird, since lrintf()/lrint() don't set errno) but clang still
>> does not. Pre
On Fri, Jul 31, 2015 at 5:50 PM, Roland Scheidegger wrote:
> Am 01.08.2015 um 01:26 schrieb Matt Turner:
>> gcc actually generates this for us now that we use -fno-math-errno
>> (which is weird, since lrintf()/lrint() don't set errno) but clang still
>> does not. Pre
On Wed, Jul 29, 2015 at 6:56 AM, Timothy Arceri wrote:
> This removes the need for multiple functions designed to validate an array
> subscript and replaces them with a call to a single function.
>
> The change also means that validation is now only done once and the index
> is retrived at the sam
On Sun, Aug 2, 2015 at 11:09 PM, Rhys Kidd wrote:
> mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function
> 'brw_postdraw_set_buffers_need_resolve':
> mesa/src/mesa/drivers/dri/i965/brw_draw.c:390:22: warning: comparison between
> signed and unsigned integer expressions [-Wsign-compare]
> f
On Sun, Aug 2, 2015 at 11:09 PM, Rhys Kidd wrote:
> mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function
> 'intel_validate_framebuffer':
> mesa/src/mesa/drivers/dri/i965/intel_fbo.c:734:18: warning: comparison
> between signed and unsigned integer expressions [-Wsign-compare]
> for (i = 0
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, Aug 3, 2015 at 1:04 AM, Lofstedt, Marta
wrote:
> However, I don't agree that the driver interface should be removed.
> In my opinion, it is a driver specific decision if glMemoryBarrierByRegion
> should be
> implemented directly on top of glMemoryBarrier or if you want to do some
> optimi
On Fri, Jul 17, 2015 at 11:53 AM, Emil Velikov wrote:
> On 17 July 2015 at 19:09, Matt Turner wrote:
>> On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov
>> wrote:
>>> Hello all,
>>>
>>> A few days ago I realised that BSD make (bmake) is available in the
On Fri, Jul 31, 2015 at 5:46 PM, Roland Scheidegger wrote:
>> + */
>> +static inline long
>> +_mesa_lroundevenf(float x)
>> +{
>> + return lrintf(x);
>> +}
>> +
>> +/**
>> + * \brief Rounds \c x to the nearest integer, with ties to the even integer,
>> + * and returns the value as a long int.
>>
On Fri, Jul 31, 2015 at 6:37 PM, Roland Scheidegger wrote:
> Am 01.08.2015 um 03:02 schrieb Matt Turner:
>> On Fri, Jul 31, 2015 at 5:50 PM, Roland Scheidegger
>> wrote:
>>> Am 01.08.2015 um 01:26 schrieb Matt Turner:
>>>> gcc actually generates this fo
gcc actually generates this for us now that we use -fno-math-errno
(which is weird, since lrintf()/lrint() don't set errno) but clang still
does not. Presumably helps MSVC as well.
Reduced .text size by 8.5k with gcc before -fno-math-errno.
text data bss dec hex filename
49
On Mon, Aug 3, 2015 at 4:17 PM, Roland Scheidegger wrote:
> Reviewed-by: Roland Scheidegger
Thanks!
> I'm wondering though if this is really exactly implementing lrintf why
> we're using a different name and not just something like _mesa_lrintf().
> Though arguably _mesa_roundeven is the same..
On Tue, Aug 4, 2015 at 10:17 AM, Oded Gabbay wrote:
> This patch fixes a bug in big-endian treatment, where the previous
> swizzle info wasn't cleared before a new swizzle info was inserted into
> the format field using a bitwise-OR operation.
>
> v2: use MESA_ARRAY_FORMAT_SWIZZLE_*_MASK instead o
gs back together into a vector. */
> + nir_ssa_def *vec;
> + switch (lower->def.num_components) {
> + case 2:
> + vec = nir_vec2(&b, loads[0], loads[1]);
> + break;
> + case 3:
> + vec = nir_vec3(&b, loads[0], loads[1], loads[2]);
> + break;
>
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
index 89fdccb..540c655 100644
--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.
Regression since commit 3a31876600, when tiling modes were moved into
layout_flags.
The relevant enum values are
MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5
MIPTREE_LAYOUT_ALLOC_XTILED = 1 << 6
MIPTREE_LAYOUT_ALLOC_ANY_TILED = MIPTREE_LAYOUT_ALLOC_YTILED |
MI
On Tue, Aug 4, 2015 at 11:18 PM, Matt Turner wrote:
> Regression since commit 3a31876600, when tiling modes were moved into
> layout_flags.
>
> The relevant enum values are
>
>MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5
>MIPTREE_LAYOUT_ALLOC_XTILED = 1 << 6
&g
701 - 800 of 6487 matches
Mail list logo
