[Mesa-dev] [PATCH v2] clover: Update OpenCL version string to match OpenGL

Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, append git version suffix if available. Original idea from Giuseppe Bilotta . --- src/gallium/state_trackers/clover/api/device.cpp | 6 +-

Re: [Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

lease give it some time for others to weight in before sending out v4. Sure. Sorry for multiple revisions initially. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, append git version suffix from git_sha1.h if available. Original idea from Giuseppe Bilotta . --- src/gallium/state_trackers/clover/api/device.cpp | 7 ++-

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

On 06/06/2016 02:04 AM, Francisco Jerez wrote: Vedran Miletić <ved...@miletic.net> writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken. Consider the following argument -I"/foo bar/baz" which is

[Mesa-dev] [PATCH v5] clover: Update OpenCL version string to match OpenGL

Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, always append git version suffix from git_sha1.h. v5: move semicolon to same line as MESA_GIT_SHA1. v4: drop #ifdef guards. v3: add missing include. v2: change CL_DEVICE_VERSION as well. Reviewed-by: Francisco Jerez

[Mesa-dev] [PATCH v4] clover: Update OpenCL version string to match OpenGL

Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, always append git version suffix from git_sha1.h. v4: dropped #ifdef guards. It would be very nice if this could be considered for 12.0 release. --- src/gallium/state_trackers/clover/api/device.cpp | 5 -

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

On 06/04/2016 10:13 AM, Francisco Jerez wrote: Vedran Miletić <ved...@miletic.net> writes: OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the OpenCL compiler was called via a shell, the shell would remove (single or

Re: [Mesa-dev] [PATCH v4] clover: Update OpenCL version string to match OpenGL

On 06/06/2016 12:44 AM, Vedran Miletić wrote: Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, always append git version suffix from git_sha1.h. v4: dropped #ifdef guards. It would be very nice if this could be considered for 12.0 release. --- src/gallium

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

On 06/04/2016 04:18 AM, Francisco Jerez wrote: Serge Martin <edb+m...@sigluy.net> writes: From: Vedran Miletić <ved...@miletic.net> Make sure that a struct argument did not get compiled into a pointer type with the byval attribute. If we try to handle the pointer with byva

Re: [Mesa-dev] [PATCH v1.1 2/2] clover: fix getting scalar args api size

as we round it here to the next power of two, store that in scalar arg object, and later compare that rounded value to sizeof(struct_arg_type) which user has passed via the API. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing lis

[Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the OpenCL compiler was called via a shell, the shell would remove (single or double) quotes before passing the argument to the compiler. Since we call Clang as a library, we have to

[Mesa-dev] [PATCH] clover: Compute aligned size for scalar argument

Scalar arguments are aligned to the next power of two per OpenCL 1.2 specification, Ch. 6.1.5: "A built-in data type that is not a power of two bytes in size must be aligned to the next larger power of two." We already compute size aligned to the next power of two in get_kernel_args() and store it

Re: [Mesa-dev] [PATCH 10/10] gallium/radeon: don't use the DMA ring for pipelined buffer uploads

all graphics settings Ultra, 4xAA, 1080p resolution with downsampling from 1200p). Wow! Tested-by: Vedran Miletić <ved...@miletic.net> Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.fre

Re: [Mesa-dev] [BRANCH] Gallium Radeon cleanups

lean -> bool, TRUE -> true, FALSE -> false radeonsi: make si_is_format_supported static Please review. I presume the next series will address boolean-> bool in si_state.c. This series is Reviewed-by: Vedran Miletić <ved...@miletic.net> Marek

Re: [Mesa-dev] [PATCH 1/4] clover: conditionally use MESA_GIT_SHA1

sa-sta...@lists.freedesktop.org Cc: Vedran Miletić <ved...@miletic.net> Cc: Francisco Jerez <curroje...@riseup.net> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/gallium/state_trackers/clover/api/device.cpp | 6 +- src/gallium/state_trackers/clover/api/platform.cpp | 5 +

Re: [Mesa-dev] [PATCH] clover: Fix build against clang SVN >= r273191

On 06/21/2016 03:13 AM, Michel Dänzer wrote: On 21.06.2016 08:17, Vedran Miletić wrote: setLangDefaults() now requires PreprocessorOptions as an argument. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH] clover: Pass unquoted include path to Clang

OpenCL apps quote include paths they pass to the OpenCL compiler. If the OpenCL compiler is called via a shell, the shell removes quotes before passing the argument to the compiler. Since we call Clang as a library, we have to remove quotes before passing the argument. ---

[Mesa-dev] [PATCH] clover: Pass unquoted include path to Clang

OpenCL apps quote include paths they pass to the OpenCL compiler. If the OpenCL compiler is called via a shell, the shell removes quotes before passing the argument to the compiler. Since we call Clang as a library, we have to remove quotes before passing the argument. ---

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

ay make bug >> triaging easier. >> >> Signed-off-by: Giuseppe Bilotta <giuseppe.bilo...@gmail.com> > > Acked-by: Francisco Jerez <curroje...@riseup.net> > Acked-by: Vedran Miletić <riva...@gmail.com> How about also adding Mesa git version, like "OpenGL

Re: [Mesa-dev] [PATCH] mesa: standardize naming Mesa3D, MESA -> Mesa

On 07/26/2016 10:29 PM, Kenneth Graunke wrote: > On Tuesday, July 26, 2016 5:41:29 PM PDT Vedran Miletić wrote: >> On 07/15/2016 07:27 AM, Edward O'Callaghan wrote: >>> Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> >>> >> >> Anythi

[Mesa-dev] [PATCH] st/nine: add missing copyright headers

Few files were missing the copyright headers. This patch adds correct copyright headers according to the commit author and date. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- src/gallium/state_trackers/nine/nine_dump.c | 21 + src/gallium/state_tracker

Re: [Mesa-dev] [PATCH] mesa: standardize naming Mesa3D, MESA -> Mesa

On 07/15/2016 07:27 AM, Edward O'Callaghan wrote: Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> Anything I can do to get this pushed? Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list me

Re: [Mesa-dev] oldest gcc version to support ?

> > (anyways, it's just for non-autoconf builds) > > If there aren't too many I would keep them. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

in the game; in the first run there is a very long stop (approx 1 second) the moment the character picks up the green sigil (and a few other points, I would have to check exactly), second run is all smooth. Regards, Vedran -- Vedran Miletić vedran.miletic.net

[Mesa-dev] [PATCH] mesa: standardize naming Mesa3D, MESA -> Mesa

Signed-off-by: Vedran Miletić <ved...@miletic.net> --- docs/xlibdriver.html| 2 +- src/gallium/docs/source/drivers/openswr/faq.rst | 4 ++-- src/gallium/include/pipe/p_defines.h| 2 +- src/mesa/main/version.c | 2 +- 4 files c

Re: [Mesa-dev] [PATCH 2/2] clover: Re-order includes in invocation.cpp to fix build

e "llvm/compat.hpp" +#include "llvm/invocation.hpp" +#include "llvm/metadata.hpp" +#include "llvm/util.hpp" +#include "util/algorithm.hpp" + + using namespace clover; using namespace clover::llvm; The series is: Reviewed-by: Vedran Miletić <ved...

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

generic macro names, but I don't think that's on anybody's todo list. it was just a suggestion, feel free to ignore it. Jan I love cleaning stuff like that and can provide a patch changing DEBUG to e.g. MESA_DEBUG, if that would solve the problem on Mesa's side. Regards, Vedran -- Vedran

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

/bugzilla/show_bug.cgi?id=1514 -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the Clang OpenCL compiler was called via a shell, the shell would split the arguments with respect to to quotes and then remove quotes before passing the arguments to the compiler.

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

06.06.2016 u 12:24, Vedran Miletić je napisao/la: On 06/06/2016 02:04 AM, Francisco Jerez wrote: Vedran Miletić <ved...@miletic.net> writes: Aside from working just like NVIDIA and AMD proprietary stacks, no. However, what we do right now is most certainly broken. Consider the fol

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

On 07/22/2016 03:37 AM, Rob Clark wrote: On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark <robdcl...@gmail.com> wrote: On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić <ved...@miletic.net> wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. As a general practice, we

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On 07/01/2016 02:52 AM, Vedran Miletić wrote: Had something similar in the works, Bas did as well, but this approach is cleaner. With these changes, in si_pipe.c and r600_pipe.c, you should not return max_const_buffer_size anymore, since it can exceed int limits, but instead something like

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

, but instead something like MAX2(0x7ff, max_const_buffer_size) Haven't tried running memory-heavy OpenCL programs, but clinfo other than const buffer size looks good. -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: add radeon_info::max_alloc_size into the winsys interface

;info.gart_size); The radeon driver in kernels older than 3.17 can't allocate BOs larger than 256MB. Indeed. You should ensure DRM >= 2.40. Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.fre

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On 07/01/2016 11:11 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák <mar...@gmail.com> wrote: On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić <ved...@miletic.net> wrote: On 07/01/2016 01:29 AM, Marek Olšák wrote: From: Marek Olšák <marek.ol...@amd

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

On 07/01/2016 02:27 PM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 1:45 PM, Vedran Miletić <ved...@miletic.net> wrote: On 07/01/2016 11:11 AM, Marek Olšák wrote: On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák <mar...@gmail.com> wrote: On Fri, Jul 1, 2016 at 2:52 AM, Vedran

Re: [Mesa-dev] [PATCH] gallium/radeon: add and use radeon_info::max_alloc_size (v2)

Reviewed-by: Vedran Miletić <ved...@miletic.net> On 07/01/2016 04:18 PM, Marek Olšák wrote: From: Marek Olšák <marek.ol...@amd.com> v2: - squashed the patches - use INT_MAX - clamp max_const_buffer_size - check the DRM version in radeon --- src/gallium/drivers/r600

[Mesa-dev] [PATCH] clover: Fix build against clang SVN >= r273191

setLangDefaults() now requires PreprocessorOptions as an argument. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] www.mesa3d.org moving to freedesktop.org

warnings in your browser for a bit... > > Eventually, the pages on www.mesa3d.org <http://www.mesa3d.org> should > get automatically updated from git check-ins to the docs/ directory. > > -Brian > Great! We also got https in the process, very nice. -- Vedran Miletić vedran.mileti

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

;info.tcc_cache_line_size = 64; /* TC L2 line size on GCN */ > > -ws->check_vm = strstr(debug_get_option("R600_DEBUG", ""), "check_vm") != > NULL; > +if ((strstr(debug_get_option("R600_DEBUG", ""), "c

[Mesa-dev] pfn_notify in clCreateContext()

-- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radeonsi: fix R600_DEBUG=nooptvariant

memset(>opt, 0, sizeof(key->opt)); > } > > Good catch. Reviewed-by: Vedran Miletić <ved...@miletic.net> -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

-off-by: Vedran Miletić <ved...@miletic.net> Reviewed-by[v1]: Edward O'Callaghan <funfunc...@folklore1984.net> --- docs/envvars.html | 9 + src/gallium/state_trackers/clover/llvm/invocation.cpp | 10 +++--- 2 files changed, 16 insertions(+),

[Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

older than EG will not use this capability). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97513 Signed-off-by: Vedran Miletić <ved...@miletic.net> --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + src/gallium/include/pipe/p_defines.h | 3 ++- src/g

Re: [Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

On 08/29/2016 09:30 PM, Jan Vesely wrote: On Mon, 2016-08-29 at 20:13 +0200, Vedran Miletić wrote: Clover presently reports 32 as CL_DEVICE_ADDRESS_BITS, which is not correct for AMD SI and newer chip generations. This patch introduces the PIPE_COMPUTE_CAP_ADDRESS_BITS pipe capability queried

[Mesa-dev] [PATCH] clover: Introduce CLOVER_COMPILER_OPTIONS

Options specified via the CLOVER_COMPILER_OPTIONS shell variable are appended to the compiler options specified by the OpenCL program (if any). Signed-off-by: Vedran Miletić <ved...@miletic.net> --- docs/envvars.html | 2 ++ src/gallium/state_trackers/

Re: [Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

On 09/07/2016 04:14 PM, Jan Vesely wrote: > On Wed, 2016-09-07 at 13:43 +0200, Vedran Miletić wrote: >> Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell >> variable >> are appended to the compiler and linker options specified by the >> OpenCL &g

Re: [Mesa-dev] [PATCH] st/clover: Define __OPENCL_VERSION__ on the device side

On 08/28/2016 04:42 PM, Niels Ole Salscheider wrote: > This is required by the OpenCL standard. > > Signed-off-by: Niels Ole Salscheider <niels_...@salscheider-online.de> Reviewed-by: Vedran Miletić <ved...@miletic.net> Good catch. Do we miss more defines from [1]? Regar

[Mesa-dev] [PATCH] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell variable are appended to the compiler and linker options specified by the OpenCL program (if any). v2: * rename to CLOVER_EXTRA_COMPILER_OPTIONS * use debug_get_option * append to linker options as well Signed-off-by: Vedran

Re: [Mesa-dev] [PATCH] clover: Introduce CLOVER_COMPILER_OPTIONS

On 08/30/2016 09:27 AM, Serge Martin wrote: > On Tuesday 30 August 2016 01:20:55 Vedran Miletić wrote: >> Options specified via the CLOVER_COMPILER_OPTIONS shell variable are >> appended to the compiler options specified by the OpenCL program (if >> any). >> >> S

Re: [Mesa-dev] [PATCH] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

On 08/31/2016 12:11 PM, Vedran Miletić wrote: > Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell variable > are appended to the compiler and linker options specified by the OpenCL > program (if any). > > v2: > * rename to CLOVER_EXTRA_COMPILER_OPTIONS > *

Re: [Mesa-dev] Problem with RX 480 on Alien: Isolation and Dota 2

edora 24 still doesn't have it in their stable package (and it's not > even in test in Bodhi). I'll try to compile my own LLVM as Edward advised. > Fedora 24 is unlikely to get LLVM 3.9 in updates. If packaged, it will come to Fedora 25 or newer. Good choice. -- Vedran Miletić vedran.miletic.

Re: [Mesa-dev] [PATCH v2 0/2] Add support for some of the missing CL1.2 queries

m/invocation.cpp | 2 +- > .../state_trackers/clover/tgsi/compiler.cpp| 2 +- > 11 files changed, 61 insertions(+), 5 deletions(-) > Nice work. The series is Reviewed-by: Vedran Miletić <ved...@miletic.net> -- Vedran Miletić vedran.miletic.net

Re: [Mesa-dev] [PATCH v2] clover: add GetKernelArgInfo (CL 1.2)

const ::llvm::Argument , > + const std::string ) { > + return ::llvm::cast<::llvm::ConstantInt>( > +::llvm::dyn_cast<::llvm::ConstantAsMetadata>( > + detail::get_kernel_metadata_operands(f, name)[arg.getArgNo()]) > + ->getValue()) > +->getLimitedValue(UINT_MAX); > + } > + > + /// >/// Return a vector with all CL kernel functions found in the LLVM >/// module \p mod. >/// > diff --git a/src/gallium/state_trackers/clover/tgsi/compiler.cpp > b/src/gallium/state_trackers/clover/tgsi/compiler.cpp > index 9bbd454..f94d19f 100644 > --- a/src/gallium/state_trackers/clover/tgsi/compiler.cpp > +++ b/src/gallium/state_trackers/clover/tgsi/compiler.cpp > @@ -76,7 +76,7 @@ namespace { > } > } > > - m.syms.push_back({ name, 0, offset, args }); > + m.syms.push_back({ name, 0, offset, args, {} }); >} > } > > -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] clover: clGetExtensionFunctionAddressForPlatform

const char *p_name) { >> + return GetExtensionFunctionAddressForPlatform(d_platform, p_name); >> +} >> + >> CLOVER_ICD_API cl_int >> clIcdGetPlatformIDsKHR(cl_uint num_entries, cl_platform_id *rd_platforms, >> cl_uint *rnum_platforms) { > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Vedran Miletić <ved...@miletic.net> -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] clover: Allow OpenCL version override

CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C version. --- docs/envvars.html | 12

[Mesa-dev] [PATCH v2] clover: assert struct argument is compiled usably

://reviews.llvm.org/D20168 or an equivalent patch. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/common.cpp b/src/gallium/state_tr

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

On 10/06/2016 07:15 PM, Jan Vesely wrote: > On Thu, 2016-10-06 at 16:26 +0200, Vedran Miletić wrote: >> CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version >> supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for >> OpenGL. >> CLOVER_CL_C_VERSIO

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

On 10/06/2016 04:26 PM, Vedran Miletić wrote: > CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version > supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. > CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C version. > --- > do

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

On 07/28/2016 07:52 AM, Francisco Jerez wrote: > Emil Velikov <emil.l.veli...@gmail.com> writes: > >> On 6 June 2016 at 00:02, Vedran Miletić <ved...@miletic.net> wrote: >>> On 06/04/2016 04:18 AM, Francisco Jerez wrote: >>>> >>>> Serge Mar

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

On 09/19/2016 07:08 PM, Vedran Miletić wrote: > On 07/28/2016 07:52 AM, Francisco Jerez wrote: >> Emil Velikov <emil.l.veli...@gmail.com> writes: >> >>> On 6 June 2016 at 00:02, Vedran Miletić <ved...@miletic.net> wrote: >>>> On 06/04/2016 04

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

On 09/07/2016 06:52 PM, Vedran Miletić wrote: > LLVM and Mesa both define the DEBUG macro in incompatible ways. As a > general practice, we should avoid using such generic names when it is > possible to do so. > > This patch renames all occurrences of the DEBUG macro to MESA_DEBUG

[Mesa-dev] [PATCH v3] clover: Pass unquoted compiler arguments to Clang

OpenCL apps can quote arguments they pass to the OpenCL compiler, most commonly include paths containing spaces. If the Clang OpenCL compiler was called via a shell, the shell would split the arguments with respect to to quotes and then remove quotes before passing the arguments to the compiler.

[Mesa-dev] [PATCH v5] clover: Introduce CLOVER_EXTRA_{COMPILER, LINKER}_OPTIONS

Signed-off-by: Vedran Miletić <ved...@miletic.net> Reviewed-by[v1]: Edward O'Callaghan <funfunc...@folklore1984.net> --- docs/envvars.html | 13 + src/gallium/state_trackers/clover/llvm/invocation.cpp | 11 --- 2 files changed, 2

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

On 09/07/2016 07:58 PM, Nicholas Bishop wrote: > Bump, any interest in this? > In my experience rST is much nicer to write than pure HTML, and I like how the output looks. Definitive yes on the rST instead of HTML, no strong opinion on readthedocs.org vs self-hosted. Regards, Vedran --

[Mesa-dev] [PATCH v4] clover: Introduce CLOVER_EXTRA_{COMPILER, LINKER}_OPTIONS

to CLOVER_EXTRA_COMPILER_OPTIONS * use debug_get_option * append to linker options as well v3: code cleanups v4: separate CLOVER_EXTRA_LINKER_OPTIONS options Signed-off-by: Vedran Miletić <ved...@miletic.net> Reviewed-by[v1]: Edward O'Callaghan <funfunc...@folklore1984.net> --- docs/

[Mesa-dev] [PATCH v6] clover: Introduce CLOVER_EXTRA_*_OPTIONS environment variables

typo * use CLOVER_EXTRA_COMPILER_OPTIONS in link stage v6: * separate in CLOVER_EXTRA_{BUILD,COMPILE,LINK}_OPTIONS * append options in cl{Build,Compile,Link}Program Signed-off-by: Vedran Miletić <ved...@miletic.net> Reviewed-by[v1]: Edward O'Callaghan <funfunc...@folklore1984.net&g

Re: [Mesa-dev] [PATCH v6] clover: Introduce CLOVER_EXTRA_*_OPTIONS environment variables

On 09/28/2016 04:22 PM, Edward O'Callaghan wrote: > Just drop the Rb as soon as you revise any patch please. Obviously there > was a bunch of stuff that happened and discussion.. > Indeed, v1 and v6 are quite different. Will do in the future. Regards, Vedran -- Vedra

[Mesa-dev] [PATCH v4] clover: Pass unquoted compiler arguments to Clang

a comment Signed-off-by: Vedran Miletić <ved...@miletic.net> --- src/gallium/state_trackers/clover/llvm/util.hpp | 39 ++--- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/util.hpp b/src/gallium/state_trackers/clove

Re: [Mesa-dev] [PATCH] scons: Require libdrm >= 2.4.65 for DRM.

a large bump and 2.4.65 is just over a year old. It would be nice to support a couple more versions before. Is there an acceptable workaround? Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH] scons: Require libdrm >= 2.4.65 for DRM.

On 10/25/2016 04:15 AM, Michel Dänzer wrote: > On 25/10/16 11:01 AM, Michel Dänzer wrote: >> On 25/10/16 09:17 AM, Vedran Miletić wrote: >>> On 10/25/2016 01:41 AM, Vinson Lee wrote: >>>> Fix SCons build. drmDevicePtr is not available until libdrm 2.4.65. >>>

Re: [Mesa-dev] [Clover] Compilations error with latest LLVM version 4.0.0svn in llvm/codegen/bitcode.cpp

lErrors(std::move(err), [&](::llvm::ErrorInfoBase ) { + msg = EIB.message(); + fail(r_log, error(CL_INVALID_PROGRAM), msg.c_str()); + }); + } return std::unique_ptr<::llvm::Module>(std::move(*mod)); } Regards, Vedran -- Vedran Miletić vedran.miletic.net

[Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

--- src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp b/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp index 8e89a49..5dcc4f8 100644 ---

Re: [Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

On 11/14/2016 04:49 PM, Tom Stellard wrote: > On Mon, Nov 14, 2016 at 01:44:18PM +0100, Dieter Nützel wrote: >> Tested-by: Dieter Nützel <die...@nuetzel-hh.de> >> >> Thanks Vedran! >> > > Pushed, thanks! > > -Tom > Thank you

[Mesa-dev] [PATCH] clover: restore support for LLVM <= 3.9

The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 broke 3.9 and older versions of LLVM for Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- .../state_trackers/clover/llvm/c

[Mesa-dev] [PATCH v5] clover: restore support for LLVM <= 3.9

: simplify using templates and lambda Signed-off-by: Vedran Miletić <ved...@miletic.net> Reviewed-by[v2]: Jan Vesely <jan.ves...@rutgers.edu> Tested-by[v4]: Vinson Lee <v...@freedesktop.org> Tested-by[v4]: Pierre Moreau <pierre.mor...@free.fr> Reviewed-by: Francisco Jere

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

On 11/16/2016 11:21 PM, Vinson Lee wrote: > On Wed, Nov 16, 2016 at 10:10 AM, Jan Vesely <jan.ves...@rutgers.edu> wrote: >> On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote: >>> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM >>>

[Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- .../state_trackers/clover/llvm/c

[Mesa-dev] [PATCH v3] clover: restore support for LLVM <= 3.9

The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- .../state_trackers/clover/llvm/c

[Mesa-dev] [PATCH v4] clover: restore support for LLVM <= 3.9

The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM 3.9 and older versionsin Clover. This patch restores it and refactors the support using Clover compatibility layer for LLVM. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- .../state_trackers/clover/llvm/c

Re: [Mesa-dev] [PATCH v4] clover: Pass unquoted compiler arguments to Clang

On 10/30/2016 08:16 PM, Francisco Jerez wrote: > Vedran Miletić <ved...@miletic.net> writes: > >> OpenCL apps can quote arguments they pass to the OpenCL compiler, most >> commonly include paths containing spaces. >> >> If the Clang OpenCL compiler was called v

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

On 10/07/2016 12:05 PM, Serge Martin wrote: > On Thursday 06 October 2016 16:26:21 Vedran Miletić wrote: >> CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version >> supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. >> CLOVER_CL_C_VERSION_OVER

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

On 10/13/2016 07:45 PM, Vedran Miletić wrote: > On 10/07/2016 12:05 PM, Serge Martin wrote: >> On Thursday 06 October 2016 16:26:21 Vedran Miletić wrote: >>> PACKAGE_VERSION #ifdef MESA_GIT_SHA1 >>> " (" MESA_GIT_SHA1 ")

[Mesa-dev] [PATCH v2] clover: Allow OpenCL version override

tor ss; std::istringstream iss(s); std::string t; - while (getline(iss, t, ' ')) + while (getline(iss, t, sep)) ss.push_back(t); return ss; diff --git a/src/gallium/state_trackers/clover/util/version.hpp b/src/gallium/state_trackers/

Re: [Mesa-dev] Documenting with Sphinx

d I'm > wondering if we should try and preserve what's already there. > > --Jason > Somewhat related effort was already discussed several months ago: https://lists.freedesktop.org/archives/mesa-dev/2016-September/128182.html V. -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: drop unused fields in physical device.

Nice cleanup. Reviewed-by: Vedran Miletić <ved...@miletic.net> On 12/13/2016 04:58 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Signed-off-by: Dave Airlie <airl...@redhat.com> > --- > src/amd/vulkan/radv_private.h | 6 -- > 1 fi

[Mesa-dev] [RFC PATCH] clover: Return correct CL_EVENT_REFERENCE_COUNT

-event test. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- src/gallium/state_trackers/clover/api/event.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/event.cpp b/src/gallium/state_trackers/clover/api/event.cpp index 5

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

On 09/19/2016 08:39 PM, Vedran Miletić wrote: > On 09/07/2016 06:52 PM, Vedran Miletić wrote: >> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >> general practice, we should avoid using such generic names when it is >> possible to do so. >>

[Mesa-dev] [PATCH v2] clover: Use Clang's diagnostics

. v2: fix inconsistent code formatting Signed-off-by: Vedran Miletić <ved...@miletic.net> Reviewed-by: Francisco Jerez <curroje...@riseup.net> --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/st

Re: [Mesa-dev] [RFC PATCH] clover: Return correct CL_EVENT_REFERENCE_COUNT

On 12/20/2016 11:59 AM, Jan Vesely wrote: > On Fri, 2016-12-16 at 13:43 -0800, Francisco Jerez wrote: >> Vedran Miletić <ved...@miletic.net> writes: >> >>> Current implementation of event handling keeps an extra reference to >>> the hardware event, in

[Mesa-dev] [PATCH] clover: Use Clang's diagnostics

. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp

[Mesa-dev] [PATCH] ac, gallium: fix building with LLVM >= r298393

AttributeSet got renamed to AttributeList. Signed-off-by: Vedran Miletić <ved...@miletic.net> --- src/amd/common/ac_llvm_helper.cpp | 10 -- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 8 +++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH] swr: [rasterizer jitter] fix llvm >= 5.0 build break

to argitr = soFunc->getArgumentList().begin(); > + auto argitr = soFunc->arg_begin(); > Value* pSoCtx = &*argitr++; > pSoCtx->setName("pSoCtx"); > > Yup, that's the way to go. Reviewed-by: Vedran Miletić <ved...@miletic.net> -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/18] Good bye pragma once

| 5 +++ > src/util/format_r11g11b10f.h | 5 +++ > src/util/register_allocate.h | 6 ++- > src/util/strndup.c | 47 > -- > src/util/strndup.h

Re: [Mesa-dev] [PATCH v3 1/1] clover: use pipe_resource references

t; >> What is pxfer->resource about in that case? > > that's a good question, so I did a bit of digging. for EG global > buffers are shadowed in global buffer memory pool, so mapping uses > memory pool's pipe_resource. I'm still not 100% sure where exactly > unmapping the glob

Re: [Mesa-dev] [PATCH 2/2] radv: Set driver version to mesa version;

, Works with Dota 2, Talos and Doom over Wine. Mesa version appears nicely in Doom. This patch and the previous one is Tested-by: Vedran Miletić <ved...@miletic.net> -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

er the current website, not to mention easier to maintain. As for the theme, I suggest Guzzle [1] instead; RTD is very pretty, but it's also fairly common, as is Bootswatch. Guzzle is pretty and not so commonly used, as far as my anecdotal experience goes. Regards, Vedran [

Re: [Mesa-dev] debian wheezy - r300 bug

Can you find it in Freedesktop Bugzilla? Regards, Vedran -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/clover: add space between < and ::

6 files changed, 17 insertions(+), 17 deletions(-) > Commit message looks fine to me. If you still want to reword it, then remove mention of the compiler and say something along the lines of: "C++11 requires space between < and :: as <: is an alternate spelling for [ (see st

Re: [Mesa-dev] [PATCH v2 1/1] clover: use pipe_resource references

destroy(device().pipe, pipe); > + pipe_resource_reference(>pipe, NULL); > } > > sub_resource::sub_resource(resource , const vector ) : > -- Vedran Miletić vedran.miletic.net ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

  1   2   >