[Mesa-dev] [PATCH 07/19] etnaviv: GC7000: Add etnaviv_blt

Add a low-level library for using the BLT engine from the etnaviv driver. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium/drivers/etnaviv/etnaviv_blt.c| 219 +++ src/gallium/d

[Mesa-dev] [PATCH 09/19] etnaviv: GC7000: BLT engine blitting support

Add an implemenation of key clear_blit functions using the BLT engine that replaced the RS on GC7000. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/Makefile.sources | 1 + src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 7 +

[Mesa-dev] [PATCH 03/19] etnaviv: Put HALTI level in specs

The HALTI level is an indication of the gross architecture of the GPU. It determines for significant part what feature level the GPU has, what state (especially frontend state) is there, and where it is located. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/d

[Mesa-dev] [PATCH 06/19] etnaviv: GC7000: Support BLT as recipient for etna_stall

When the BLT is involved as source or target, add an extra BLT enable/disable sequence around the sync sequence. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 08/19] etnaviv: GC7000: Split off RS blit functions

Prepare for BLT-based blitting path by moving RS-based blitting to its own implementation file. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/Makefile.sources | 1 + src/gallium/drivers/etnaviv/etnaviv_clear_blit.c

[Mesa-dev] [PATCH 05/19] etnaviv: Use only DRAW_INSTANCED on GC3000+

The blob does this, as DRAW_INSTANCED can replace fully all the other draw commands - the other path is only there for compatibility and will go away (or at least rot to become buggy due to dis-use) in newer hardware. Preparation for GC7000 support. Signed-off-by: Wladimir J. van der Laan <

[Mesa-dev] [PATCH 04/19] etnaviv: Emit SCALE for vertex attributes

This is used by HALTI2+ (GC3000+) when drawing with DRAW_INSTANCED. It is also necessary when switching between integer and floating point vertex element formats. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 5 + src/g

[Mesa-dev] [PATCH 01/19] etnaviv: Update from rnndb

Updated as of etnav_viv commit 8255e4b. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +- src/g

[Mesa-dev] [PATCH 00/19] GC7000 preparation

. If you really want to see etnaviv_texture_desc.c in its current state, it's here: https://github.com/laanwj/mesa/blob/gc7000/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c Wladimir J. van der Laan (19): etnaviv: Update from rnndb etnaviv: Const-correctness etnaviv_emit.h etnaviv: Put HALTI

[Mesa-dev] [PATCH 02/19] etnaviv: Const-correctness etnaviv_emit.h

The relocation structure is never changed by submitting it. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.h b/src/g

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer) > here, which seems more consistent with the rest of the codebase. Well, I mimiced the style from other assertion in the function which compares explicitly with

Re: [Mesa-dev] [PATCH] etnaviv: make use of TEXTURE_TYPE_1D

On Thu, Oct 26, 2017 at 04:16:31PM +0200, Christian Gmeiner wrote: > I have no problem to postpone this patch until I have my farm up and > get the first results. Alternatively, I'd say just disable this for !HALTI0 for now, revert to the old behavior in that case, then someone who is able to

Re: [Mesa-dev] [PATCH] etnaviv: add ext_texture_srgb support

mats-s3tc > > Btw. this enables GL 2.1 :-) That's all? Cool, I thought ext_texture_srgb needed rendering to srgb too, but apparently not. > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- >

[Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

Prevents an assertion when using GALLIUM_HUD with ioquake3, when cso_restore_constant_buffer_slot0 restores an empty constant buffer in slot 0. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH] etnaviv: Don't flush on transfer when UNSYNCHRONIZED

Structure code to only flush when we will potentially call cpu_prep. This prevents spurious flushes in applications that heavily rely on u_uploader. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_transfer.c | 24

[Mesa-dev] [PATCH] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

Prevents an assertion when using GALLIUM_HUD with ioquake3, when cso_restore_constant_buffer_slot0 restores an empty constant buffer in slot 0. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +- 1 file changed, 1 insertion

Re: [Mesa-dev] [PATCH 8/8] etnaviv: fix rs blit for formats with blocksize of 8

On Sat, Oct 21, 2017 at 10:22:09AM +0200, Christian Gmeiner wrote: > Hi Wladimir > > 2017-10-21 7:28 GMT+02:00 Wladimir J. van der Laan <laa...@gmail.com>: > > On Fri, Oct 20, 2017 at 10:21:28PM +0200, Christian Gmeiner wrote: > >> Fixes piglit/bin/oes_texture_f

Re: [Mesa-dev] meson build for etnaviv and imx

On Fri, Oct 20, 2017 at 04:04:09PM -0700, Dylan Baker wrote: > This is all pretty straight-forward, it builds on my system, but I don't have > any actual hardware to test on. > > Christian and/or Wladimir, could one of you build this and do some kind of > testing to ensure it works? Sure, if you

Re: [Mesa-dev] [PATCH 1/8] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

On Fri, Oct 20, 2017 at 10:21:21PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/mesa/main/glformats.c | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by: Wladimir J. van der Laan <laa..

Re: [Mesa-dev] [PATCH 7/8] etnaviv: add float formats

On Fri, Oct 20, 2017 at 10:21:27PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> Optional suggestions inline. > --- > src/gallium/drivers/etnaviv/

Re: [Mesa-dev] [PATCH 6/8] etnaviv: expose float formats only if GPU supports it

On Fri, Oct 20, 2017 at 10:21:26PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 4 > 1 file changed, 4

Re: [Mesa-dev] [PATCH 5/8] etnaviv: handle 8 byte block in tiling

On Fri, Oct 20, 2017 at 10:21:25PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_tiling.c | 8 ++-- > 1 file cha

Re: [Mesa-dev] [PATCH 3/8] etnaviv: update RS_FORMAT_MASK to include extended formats

On Fri, Oct 20, 2017 at 10:21:23PM +0200, Christian Gmeiner wrote: > Also update RS_FORMAT_RB_SWAP. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etn

Re: [Mesa-dev] [PATCH 2/8] etnaviv: HALTI0 indicates extended PE formats

On Fri, Oct 20, 2017 at 10:21:22PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan Verified that HALTI0 has PE TEXTURE_FORMAT_EXT by looking at GC2000 blob replays. > --- > src/gallium/

Re: [Mesa-dev] [PATCH 8/8] etnaviv: fix rs blit for formats with blocksize of 8

On Fri, Oct 20, 2017 at 10:21:28PM +0200, Christian Gmeiner wrote: > Fixes piglit/bin/oes_texture_float half > > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_translate.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 4/8] etnaviv: add support for extended PE formats

On Fri, Oct 20, 2017 at 10:21:24PM +0200, Christian Gmeiner wrote: > Use the extended format if an such a format was passed. > > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_state.c | 10 -- > 1 file changed, 8 insertions(+),

Re: [Mesa-dev] [PATCH v2 1/5] etnaviv: update headers from rnndb

On Thu, Oct 19, 2017 at 11:12:44PM +0200, Christian Gmeiner wrote: > Update to etna_viv commit 6c9c706. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> > Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> For whole v2 series: Reviewed-by: Wladi

Re: [Mesa-dev] [PATCH 3/5] etnaviv: add support for occlusion queries

> There is one difference - how the sum is interpreted - uint64_t vs. bool > value. In general the code Ok in that case it's ok like this, just looked like unnecessary/accidental duplication. Regards, Wladimir ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 5/5] etnaviv: fix implicit conversion warning

On Tue, Oct 17, 2017 at 10:38:17PM +0200, Christian Gmeiner wrote: > Galliums query_type used in APIs is unsigned. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/gallium/drivers/etnavi

Re: [Mesa-dev] [PATCH 3/5] etnaviv: add support for occlusion queries

On Tue, Oct 17, 2017 at 10:38:15PM +0200, Christian Gmeiner wrote: > Passes most occlusion query piglits. The following piglits are broken: > - spec@arb_occlusion_query@occlusion_query_meta_fragments > - spec@arb_occlusion_query@occlusion_query_meta_save > - spec@arb_occlusion_query2@render > >

Re: [Mesa-dev] [PATCH 4/5] etnaviv: enable occlusion query if GPU supports it

On Tue, Oct 17, 2017 at 10:38:16PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 ++- > 1 file cha

Re: [Mesa-dev] [PATCH 2/5] etnaviv: add basic infrastructure for hw queries

On Tue, Oct 17, 2017 at 10:38:14PM +0200, Christian Gmeiner wrote: > No hardware query is supported yet. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> ___

Re: [Mesa-dev] [PATCH 1/5] etnaviv: update headers from rnndb

On Tue, Oct 17, 2017 at 10:38:13PM +0200, Christian Gmeiner wrote: > Update to etna_viv commit 6c9c706. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnav

Re: [Mesa-dev] [PATCH 2/2] etnaviv: rework TS enable to be a derived state

> Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Keeping the TS memory config state up to date with our internal state is a good idea. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 5 +-- >

Re: [Mesa-dev] [PATCH 1/2] etnaviv: skip unused vertex attributes when assigning VS inputs

rwrite other valid inputs otherwise. > > Fixes piglit drawpixels and a bunch of other tests using the st_draw path. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> __

Re: [Mesa-dev] [PATCH 2/2] etnaviv: call util_query_clear_result(..) in the generic layer

On Sun, Oct 08, 2017 at 10:00:07PM +0200, Christian Gmeiner wrote: > Saves us from calling util_query_clear_result(..) in every query > type implementation. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan

Re: [Mesa-dev] [PATCH 1/2] etnaviv: push query active handling into generic layer

On Sun, Oct 08, 2017 at 10:00:06PM +0200, Christian Gmeiner wrote: > We want the same active handling for every query type. So lets > handle it in the generic layer. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-By: Wladimir J. van der Laan

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

On Wed, Oct 04, 2017 at 11:44:32AM -0400, Rob Clark wrote: > Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed etnaviv change only. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + > src/g

Re: [Mesa-dev] [PATCH] etnaviv: Set up GC3000 states, fix point sprite rendering

On Sun, Oct 01, 2017 at 01:46:05PM +0200, Christian Gmeiner wrote: > Okay.. hopefully we do not forget to remove them here when it gets > used during state emission like PE_ALPHA_COLOR_EXT0. But I > am fine with that change and will shut up. Yes, it should be removed then. Though if I understand

[Mesa-dev] [PATCH v2 2/2] etnaviv: Set up unknown GC3000 states

Set up new states that the blob started setting for GC3000 consistently. This makes sure that when another test or driver leaves the GPU in unpredictable state, these states are set up correctly for our rendering. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/g

[Mesa-dev] [PATCH v2 1/2] etnaviv: Fix point sprite rendering on GC3000

Setting PA_VIEWPORT_UNK state correctly is necessary to make point sprite rendering on GC3000 work. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH v2 0/2] etnaviv: Set up GC3000 states, fix point sprite rendering

sprite rendering on GC3000 work. Wladimir J. van der Laan (2): etnaviv: Fix point sprite rendering on GC3000 etnaviv: Set up unknown GC3000 states src/gallium/drivers/etnaviv/etnaviv_context.c | 13 + 1 file changed, 13 insertions(+) -- 2.7.4

[Mesa-dev] [PATCH 1/2] etnaviv: Support opcodes with bit 6 set in assembler

Support opcodes with bit 6 set in assembler, and assert that only ops 0x00..0x7f are used. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_asm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 2/2] etnaviv: Add support for DP2 instruction

A two-component dot product instruction is supported with HALTI2, use it on hardware that supports it. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 3 ++- src/gallium/drivers/etnaviv/etnaviv_disasm.c | 1 + src/gallium/d

[Mesa-dev] [PATCH 0/2] etnaviv: Support opcode bit 6 assembler, add DP2 instruction

Support opcodes with bit 6 set in assembler, then use that to add the DP2 instruction, supported with HALTI2. Wladimir J. van der Laan (2): etnaviv: Support opcodes with bit 6 set in assembler etnaviv: Add support for DP2 instruction src/gallium/drivers/etnaviv/etnaviv_asm.c | 5

[Mesa-dev] [PATCH v2] etnaviv: Do GC3000 resolve-in-place when possible

doing i.MX6qp scanout using PRE, and when rendering to textures (though here using sampler TS would be even better). Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 1 + src/gallium/drivers/etnaviv/etnaviv_emit.c

Re: [Mesa-dev] [PATCH] etnaviv: Do GC3000 resolve-in-place when possible

On Fri, Sep 29, 2017 at 06:00:13PM +0200, Wladimir J. van der Laan wrote: > If an RS blit is done with source exactly the same as destination, and > the hardware supports this, do an in-place resolve. > > This is the same as the blob does and potentially saves significant > bandw

Re: [Mesa-dev] [PATCH] etnaviv: fix bogus flush requests in transfer handling

Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) >

[Mesa-dev] [PATCH] etnaviv: Do GC3000 resolve-in-place when possible

TS would be even better). Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 9 - src/gallium/drivers/etnaviv/etnaviv_rs.c | 16 +--- src/gallium/drivers/etnaviv/etnaviv_rs.h | 1 + 3 files changed, 22 inse

Re: [Mesa-dev] [PATCH] etnaviv: update HW headers and fix provoking vertex

cas Stach <l.st...@pengutronix.de> Thanks for figuring this one out Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com>: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_rasterizer.c | 3 +- > src/gallium/drivers/etnaviv/hw/cmdstream.xml.h

Re: [Mesa-dev] [PATCH v2 3/3] etnaviv: optimize RS transfers

appens a lot with glTexSubImage2D). > > Optimize this by only blitting the tile aligned subregion of the > resource, which the transfer is going to change. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmamil.com>

Re: [Mesa-dev] [PATCH v2 1/3] etnaviv: support tile aligned RS blits

use of the RS > - split out tile mask computation, to make it easier to read the code Thanks! Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 86 > +--- > 1 file changed, 78 insertions(

Re: [Mesa-dev] [PATCH v3 1/2] etnaviv: fix varying interpolation

me cases. Regards, Wladimir > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> > Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > v2: fix invalid vreg assignment > v3: fix missed negat

[Mesa-dev] [PATCH] etnaviv: Set up GC3000 states, fix point sprite rendering

sprite rendering on GC3000 work. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_context.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c b/src/gallium/drivers/etnaviv/etnaviv_con

[Mesa-dev] [PATCH] etnaviv: Add missing includes after 6ace0b8

Add missing includes after 6ace0b8 (etnaviv: don't enable RT full-overwrite when logicop is enabled), otherwise the etnaviv driver won't build because of missing macros. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_blend.c | 2 ++

Re: [Mesa-dev] [PATCH] etnaviv: fix 16bpp clears

asked off. > > I've only observed the issue with R5G6B5_UNORM surfaces, other 16bpp > formats seem to work fine. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > > Fixes: d6aa2ba2b2 (etnaviv: replace translate_clear_color with > util_pack_color) > Cc: mesa-s

Re: [Mesa-dev] [PATCH 2/2] etnaviv: move sw query defines to etnaviv_query_sw.h

On Tue, Sep 19, 2017 at 06:16:05PM +0200, Christian Gmeiner wrote: > Also add new define ETNA_SW_QUERY_BASE. > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etn

Re: [Mesa-dev] [PATCH 1/2] etnaviv: move sw get_driver_query_info(..)

ail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_query.c| 15 +++ > src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 21 + > src/gallium/drivers/etnaviv/etnaviv_query_sw.h | 4 &

Re: [Mesa-dev] [PATCH v2 1/2] etnaviv: fix varying interpolation

_USE_POINTCOORD is a bit of a misnomer now, as it isn't > only used for pointcoords, but missing a better name I left it as-is. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > v2: fix invalid vreg assig

Re: [Mesa-dev] [PATCH v2 2/2] etnaviv: remove flat shading workaround

nix.de> > Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_rasterizer.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/ga

Re: [Mesa-dev] [PATCH 2/3] etnaviv: add resource subregion copy

On Fri, Sep 15, 2017 at 06:00:53PM +0200, Lucas Stach wrote: > This is useful if we only need to copy part of a larger resource, mostly > when using the RS engine to de-/tile on pipe transfers. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J.

Re: [Mesa-dev] [PATCH 1/3] etnaviv: support tile aligned RS blits

On Fri, Sep 15, 2017 at 06:00:52PM +0200, Lucas Stach wrote: > The RS can blit abitrary tile aligned subregions of a resource by > adjusting the buffer offset. Thanks for doing this. Comments inline, > Signed-off-by: Lucas Stach > --- >

Re: [Mesa-dev] [Freedreno] [PATCH] a2xx: add support for a few 16-bit color rendering formats

On Fri, Aug 25, 2017 at 12:48:22AM -0400, Ilia Mirkin wrote: > The rest should be possible too, just needs some additional > investigation. Passes fbo-*-formats piglit tests. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Ilia Mirkin <imir...@alum.mit

Re: [Mesa-dev] glmark2 terrain errors on imx6q

On Thu, Aug 24, 2017 at 04:12:21PM -0700, Chris Healy wrote: > When running on Mesa 17.2, I believe this has already been fixed with > the GC3000 but is still not working with the GC2000. Here's the fix > I'm thinking addresses the issue with the GC3000: > >

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Fri, Aug 04, 2017 at 06:54:12PM +0200, Philipp Zabel wrote: > On Fri, 2017-08-04 at 18:15 +0200, Wladimir J. van der Laan wrote: > > On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote: > > > Look up BOs from the name table using the name parameter instead of >

Re: [Mesa-dev] [PATCH 1/2] etnaviv: fix etna_bo_from_name

On Fri, Aug 04, 2017 at 05:07:54PM +0200, Philipp Zabel wrote: > Look up BOs from the name table using the name parameter instead of > req.handle (which at this point is always zero). Good catch. Just out of interest: when is this used, what problems does this cause? Regards, Wladimir

[Mesa-dev] [PATCH] etnaviv: Add support for R8_UNORM textures

R8_UNORM textures can be emulated by means of L8 and a swizzle. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c

[Mesa-dev] [PATCH 1/3] etnaviv: Update headers from rnndb

Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/hw/state_3d.xml.h | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/etnaviv/hw/state_3d.xml.h b/src/gallium/drivers/etnaviv/hw/state_3d.xml.h

[Mesa-dev] [PATCH 3/3] etnaviv: Implement ICACHE

rom memory on demand. Small shaders will be uploaded in the usual way. This mimics the behavior of the blob. On GPUs that don't support ICACHE, this patch should make no difference. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compile

[Mesa-dev] [PATCH 2/3] etnaviv: Unified uniforms support

is still fixed and hardcoded. It should make no difference on hardware that does not have unified uniform memory. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 19 +++ src/gallium/drivers/etnaviv/etnaviv_internal.

[Mesa-dev] [PATCH 0/3] etnaviv: Support large shaders on GC3000

rom memory on demand. Small shaders will be uploaded in the usual way. This mimics the behavior of the blob. On GPUs that don't support ICACHE, this patch should make no difference. Wladimir J. van der Laan (3): etnaviv: Update headers from rnndb etnaviv: Unified uniforms support etnaviv:

[Mesa-dev] [PATCH] etnaviv: Clear lbl_usage array correctly

. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium/drivers/etnaviv/etnaviv_compiler.c index cc6bfc9..165ab74 100644 --- a/src/g

Re: [Mesa-dev] [PATCH] etnaviv: Avoid duplicates in formats table

On Fri, Jul 21, 2017 at 02:43:11PM +0200, Lucas Stach wrote: > Am Freitag, den 21.07.2017, 12:49 +0200 schrieb Wladimir J. van der > Laan: > > Remove the following duplicates from the formats table: > > > > - R8G8B8A8_UNORM (V_,_T) > > - R8G8B8X8_UNORM

[Mesa-dev] [PATCH] etnaviv: Avoid duplicates in formats table

Remove the following duplicates from the formats table: - R8G8B8A8_UNORM (V_,_T) - R8G8B8X8_UNORM (_T,_T) - DXT3_RGBA (_T,_T) Only the first has an effect because the _T overrides the V_ initializer, the latter two were harmless duplications of the same. Signed-off-by: Wladimir J. van der Laan

[Mesa-dev] [PATCH v2] etnaviv: Add support for ETC2 texture compression

this for sure. (Only enabled on GC3000+ for now, as the GC2000 ETC2 decoder implementation is buggy and we don't work around that) Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_format.c | 11 +++ src/gallium/drivers/e

[Mesa-dev] [PATCH] etnaviv: Reset indexed rendering information when not rendering indexed

A dangling bo object would result in memory corruption while loading a level in ioquake3_opengl2. Fixes a problem introduced in 330d0607ed60fd3edca192e54b4246310f06652f. Fix suggested by Lucas Stach. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --- src/gallium/drivers/e

[Mesa-dev] [PATCH] etnaviv: Use the correct LOG instruction on GC3000

GC3000 has a new LOG instruction, similar to the new SIN and COS instructions. Generate the new instruction sequence when appropriate; there are two occasions, as part of LIT and the generator for the LG2 instruction itself. Signed-off-by: Wladimir J. van der Laan <laa...@gmail.com> --

Re: [Mesa-dev] [PATCH 10/11] etnaviv: implement resource creation with modifier

On Fri, Jun 23, 2017 at 05:50:27PM +0200, Lucas Stach wrote: > This allows to create buffers with a specific tiling layout, which is > primarily > used by GBM to allocate the EGL back buffers with the correct tiling/modifier > for use with the scanout engines. > > Signed-off-by: Lucas Stach

Re: [Mesa-dev] [PATCH 09/11] etnaviv: fill in modifier in etna_resource_get_handle

On Fri, Jun 23, 2017 at 05:50:26PM +0200, Lucas Stach wrote: > This allows the state trackers to know the tiling layout of the > resource and pass this through the various userspace protocols. > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Comment inline. Reviewed-by: Wlad

Re: [Mesa-dev] [PATCH 07/11] etnaviv: implement resource import with modifier

deronly scanout allocated > buffers, as the linear modifier is enough to trigger correct handling > of those buffers. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/galliu

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

rge performance > gains for the render to texture cases). Agreed. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> Regards, Wladimir ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/11] etnaviv: fold etna_screen_bo_get_handle into etna_resource_get_handle

ng screen specific. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 14 -- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 --- > src/gallium/drivers/etnaviv/etnaviv_screen.

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

On Fri, Jun 23, 2017 at 05:50:23PM +0200, Lucas Stach wrote: > This reworks the logic in etna_update_sampler_source to select the > newest resource view for updating the texture view. This should make > the logic easier to follow and fixes texture updates from imported > dma-bufs. Comment in-line

Re: [Mesa-dev] [PATCH 05/11] etnaviv: increment correct seqno for external resources

the external view seqno, instead of the base resource seqno. Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 5 - > 1 file changed, 4 insertions(+),

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote: > > sure if we should advertise the broken formats (on gpus with HALTI0). FWIW, I did check on both GC2000 and GC3000, so HALTI0 should be ok. Wladimir ___ mesa-dev mailin

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

> I can confirm that 11 bit stuff works on the GC2000 . I used piglit's > oes_compressed_etc2_texture-miptree_gles3 for verification. > How have you tested these formats? I rendered the example images from https://github.com/Ericsson/ETCPACK/tree/master/testing/testvectors_correct/pkm, which

Re: [Mesa-dev] [PATCH 11/11] etnaviv: advertise supported dmabuf modifiers

ender target binding for them. The SPLIT formats are only supported on hardware with multiple pixel pipes. Should this be checked, or is it harmless to advertize them unconditionally? Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --

Re: [Mesa-dev] [PATCH 04/11] etnaviv: pad scanout buffer size to RS alignment

lution. Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/etnaviv/etnav

Re: [Mesa-dev] [PATCH 02/11] etnaviv: fix memory leak when BO allocation fails

On Fri, Jun 23, 2017 at 05:50:19PM +0200, Lucas Stach wrote: > The resource struct is already allocated at this point and should be > free properly. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> >

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

On Tue, Jun 27, 2017 at 02:54:56PM +0200, Wladimir J. van der Laan wrote: > Add support for ETC2 compressed textures in the etnaviv driver. > > One step closer towards GL ES 3 support. > > For now, treat SRGB and RGB formats the same. It looks like these are > distinguished usi

[Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

Add support for ETC2 compressed textures in the etnaviv driver. One step closer towards GL ES 3 support. For now, treat SRGB and RGB formats the same. It looks like these are distinguished using a different bit in sampler state, and not part of the format, but I have not yet been able to confirm

Re: [Mesa-dev] [PATCH 01/11] etnaviv: fill in layer_stride for imported resources

On Fri, Jun 23, 2017 at 05:50:18PM +0200, Lucas Stach wrote: > The layer stride information is used in various parts of the driver, > so it needs to be present regardless if the driver allocated the > buffer itself or merely imported it from an external source. Reviewed-by: Wladimir J

Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

On Sat, Jun 24, 2017 at 10:41:58AM +0200, Christian Gmeiner wrote: > Hi > > 2017-06-22 14:39 GMT+02:00 Wladimir J. van der Laan <laa...@gmail.com>: > > On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: > >> Passes all ext_texture_swizzle piglits. &g

Re: [Mesa-dev] [PATCH 4/4] etnaviv: add support for snorm textures

On Wed, Jun 21, 2017 at 10:36:48PM +0200, Christian Gmeiner wrote: > Based on a patch from Wladimir J. van der Laan and untested due > to lack of hardware. Binary blob emits those formats if GPU supports > HALTI1 (faked with ibvivhook). Reviewed-by: Wladimir J. van der Laan <laa.

Re: [Mesa-dev] [PATCH 3/4] etnaviv: add R8G8 texture support

On Wed, Jun 21, 2017 at 10:36:47PM +0200, Christian Gmeiner wrote: > Passes texwrap GL_ARB_texture_rg piglit (with faked full texture rg support). Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com>

Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: > Passes all ext_texture_swizzle piglits. You seem to have dropped the check in etnaviv_screen.c for HALTI0 when texture formats have implicit non-identity swizzle. I do think that is necessary as those formats don't work on

Re: [Mesa-dev] [PATCH 1/4] etnaviv: add support for extended texture formats

On Wed, Jun 21, 2017 at 10:36:45PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- > src

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

On Mon, Jun 05, 2017 at 09:11:02PM +0200, Lucas Stach wrote: > Same as with the colormasks, the blend color needs to be swizzled according > to the rendertarget format. Yes, indeed. Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Lucas Stach <d...@lynxeye.de> > --- >

Re: [Mesa-dev] [RFC] etnaviv: flush color cache and depth cache together before resolves

On Tue, May 30, 2017 at 12:50:07PM +0200, Philipp Zabel wrote: > Before resolving a rendertarget or a depth/stencil resource into a > texture, flush both the color cache and the depth cache together. > > It is unclear whether this is necessary for the following stall to > work properly, or

Re: [Mesa-dev] [PATCH] etnaviv: add rs-operations sw query

t path - should we count these too?) Reviewed-By: Wladimir J. van der Laan <laa...@gmail.com> > > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + > src/gallium/drivers/etnaviv/etnaviv_emit.c | 2

<    1   2   3   >