From: Jakob Bornecrantz
In short what the code did before:
__DRIscreen *psp = NULL;
if (pcp)
psp = pcp->psb;
assert(psp);
if (psp->stuff)
other_stuff();
return psb->even_more(pcp);
Remove all that stupid checking which still segfaults/asserts lat
From: Jakob Bornecrantz
In short what the code did before:
__DRIscreen *psp = NULL;
if (pcp)
psp = pcp->psb;
assert(psp);
if (psp->stuff)
other_stuff();
return psb->even_more(pcp);
Remove all that stupid checking which still segfaults/asserts lat
he state tracker code itself) around anymore?
>
> I'm fine with removing the xorg target for i915g, I have never tested it
> actually.
Sad to see it go, but I'm okay with removing it.
Cheers, Jakob.
___
mesa-dev mailing
Reviewed-by: Jakob Bornecrantz
On Sat, Nov 16, 2013 at 4:49 PM, Brian Paul wrote:
> Needs to be larger than 6 to accomodate 3D textures and array textures.
> Fixes a few piglit tests (fbo-3d, copyteximage 3D).
> ---
> src/gallium/drivers/svga/svga_resource_texture.c |9 +
&g
Good catch, both patches in the series are
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob.
On Mon, Nov 18, 2013 at 11:55 PM, Brian Paul wrote:
> We were always passing PIPE_TEXTURE_2D, but not all formats are
> supported for all types of textures. In particular, the driver may
> not
st shared dri core and glapi correct. And then hardlinks
from say vmwgfx_dri.so to gallium_dri.so?
Also looking at the patch it looks like stdri can still be build without
DRM installed on the system? I remember the Hurd people being
quite vocal about this.
Cheers, Jakob.
>
> Cheers
On Thu, Jun 19, 2014 at 1:08 PM, Marek Olšák wrote:
> Hi Jakob,
>
> libdricore was nuked quite some time ago. What classic drivers now use
> is all drivers in mesa_dri_drivers.so and the _dri.so files are
> hardlinks to that file.
Ah, thanks for the info. Wouldn't that mean
Thanks again, and fair enough. :)
Cheers, Jakob.
On Thu, Jun 19, 2014 at 1:22 PM, Marek Olšák wrote:
> Yes, that's correct. However, it's better to duplicate the same code
> twice than ten times.
>
> Marek
>
> On Thu, Jun 19, 2014 at 1:12 PM, Jakob Bornecrantz
>
15/sw/SConscript | 12
> 3 files changed, 35 deletions(-)
> delete mode 100644 src/gallium/drivers/i915/SConscript
> delete mode 100644 src/gallium/winsys/i915/sw/SConscript
Reviewed-by: Jakob Bornecrantz
>
> diff --git a/src/gallium/SConscript b/src/gallium/SConscript
>
ate_trackers/xa/xa_tracker.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob.
>
> diff --git a/src/gallium/state_trackers/xa/xa_tracker.c
> b/src/gallium/state_trackers/xa/xa_tracker.c
> index 6e4312e..268d56b 100644
&
table@lists.freedesktop.**org
>
> But what about:
> NOTE: This is a candidate for the 9.2 branch.
> (but not the 9.1 branch, or 9.0 branch...)
>
> What then?
mesa-stable+9_3+...@lists.freedesktop.org ?
Cheers, Jakob.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Jul 11, 2013 at 1:58 AM, Jakob Bornecrantz wrote:
> Just tried this out, on your XA branch, and I'm getting rendering
> issues in gnome-terminal. It looks like some text is offset by
> one or two lines, and the rest looks a bit like pitch issues.
>
> http://i.imgur.c
Sure, okay with me. I'll push this patch to the video-vmware repo.
Cheers, Jakob.
On Thu, Jul 25, 2013 at 1:20 AM, Rob Clark wrote:
> On Wed, Jul 24, 2013 at 6:33 PM, Jakob Bornecrantz
> wrote:
> > On Thu, Jul 11, 2013 at 1:58 AM, Jakob Bornecrantz >
> > wrote:
>
t; get exported.
>
> Sanity-checked on X11/EGL with Piglit, and on Wayland by running
> weston-gears.
>
You need to test this patch on a non-inbuilt driver, egl_gallium or egl_glx,
none of which require you to have any hardware. Or force egl_
On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz wrote:
> On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace > wrote:
>
>> libEGL was incorrectly exporting *all* symbols, public and private.
>> This patch adds -fvisibility=hidden to libEGL's linker flags to ensure
>>
On Wed, Aug 7, 2013 at 2:00 AM, Chad Versace
wrote:
> On 08/06/2013 03:02 PM, Jakob Bornecrantz wrote:
>
>> On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz > >wrote:
>>
>> On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace <
>>> chad.vers...@linux.intel.co
ago
>
This seems to be have dropped on the floor.
The Makefile.sources patches looks good, can't comment on the other ones.
If you rebase them and you clobber the Makefile.sources ones, then send that
along with the reset of the patches on that branch out I'm sure they will
ge
ke to see VISIBILITY_CFLAGS be added to st/dri and
> the dri targets, which directly list source files from libdrmcommon in
> their SOURCES. Besides, it seems __driConfigOptions and
> __dri2ConfigOptions are also marked PUBLIC. Do they need to be
> exported?
>
I tested the v2 pat
I can think of.
That might include setting up a connection to a X server which is quite a
heavy handed thing to do. Less then optimal, also the extension might not
be supported by the loaded driver for the default platform but supported
by other drivers for other platforms.
Just t
nce 7
> + */
> +
> +#define __DRI_IMAGE_FLAG_SRGB_VIEW 0x0001
> +#define __DRI_IMAGE_FLAG_LINEAR_VIEW 0x0002
> +
These really should just be another set of formats, since that is
how they are handled gallium anyways.
Cheers, Jakob.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
nar,
> +NULL,
> +dri2_duplicate_image,
> };
>
> /*
> diff --git a/src/mesa/state_tracker/st_manager.c
> b/src/mesa/state_tracker/st_manager.c
> index a3a6771..3659499 100644
> --- a/src/mesa/state_tracker/st_manager
or something.
Cheers, Jakob.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
ter
> wrapper driver to actually cause the flush to happen.
>
> This contains the llvmpipe and wrapper sw changes.
>
> Signed-off-by: Dave Airlie
Errr, what about using flush_frontbuffer, it seems todo
the exact same thing.
Cheers, Jakob.
> ---
> src/gallium/drivers/ll
close to what I'd want to do alright.
It was used on windows to call the magical present ioctl,
its also used by llvm to flush pixels from the tile cache to the linear
displaytarget store, or at least it used to, not so sure now.
The void* backend thingy is a remnant fro
, leaving only the crucial mmap check
>>
>> Gents can someone take a look at this trivial patch.
>>
>> Cheers,
>> Emil
Reviewed-by: Jakob Bornecrantz
>> ---
>> src/gallium/auxiliary/rtasm/rtasm_execmem.c | 10 +++---
>> 1 file changed,
On Mon, Apr 7, 2014 at 11:50 AM, Thomas Hellstrom wrote:
> Cc: "10.1"
> Signed-off-by: Thomas Hellstrom
>
> ---
> src/gallium/winsys/svga/drm/vmwgfx_drm.h | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
Both patches are:
Reviewed-by: Jakob
r inconsistent sampler state /
> sampler view setup.
>
> Signed-off-by: Thomas Hellstrom
> ---
> src/gallium/state_trackers/xa/xa_renderer.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob.
>
> diff
; Found/fixed by Charmaine Lee.
>
> Cc: "10.0"
> ---
> src/gallium/drivers/svga/svga_context.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob
___
mesa-dev mailing list
mesa
insertions(+), 10 deletions(-)
>
> Series is:
> Reviewed-by: Kenneth Graunke
Was looking trough the series but couldn't find the first patch, but
now I have and also the series is:
Reviewed-by: Jakob Bornecrantz
___
mesa-dev mailing
t; ---
> src/mesa/state_tracker/st_cb_texture.c |2 +-
> src/mesa/state_tracker/st_texture.c| 12
> src/mesa/state_tracker/st_texture.h|3 +++
> 3 files changed, 16 insertions(+), 1 deletion(-)
Is this patch obsoleted by the FREE/MALLOC remove series? Otherwise
thi
On 10 Apr 2014 15:56, "Brian Paul" wrote:
>
> On 04/10/2014 01:43 AM, Jakob Bornecrantz wrote:
>>
>> On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul wrote:
>>>
>>> We were using REALLOC() from u_memory.h but FREE() from imports.h.
>>> This m
1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Jakob Bornecrantz
> diff --git a/src/gallium/state_trackers/xa/xa_context.c
> b/src/gallium/state_trackers/xa/xa_context.c
> index 37de45b..df3043c 100644
> --- a/src/gallium/state_trackers/xa/xa_context.c
> +++ b/sr
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jakob Bornecrantz
> diff --git a/src/gallium/state_trackers/xa/xa_context.c
> b/src/gallium/state_trackers/xa/xa_context.c
> index 37de45b..df3043c 100644
> --- a/src/gallium/state_trackers/xa/xa_context.c
> +++ b/src/g
Acked-by: Jakob Bornecrantz
On Sun, May 18, 2014 at 9:07 AM, Emil Velikov wrote:
> Unmaintained and broken.
>
> Cc: Jakob Bornecrantz
> Signed-off-by: Emil Velikov
> ---
> scons/gallium.py | 1 -
> src/gallium/SConscript
Reviewed-by: Jakob Bornecrantz
On Wed, May 21, 2014 at 1:44 PM, Rob Clark wrote:
> From: Rob Clark
>
> Signed-off-by: Rob Clark
> ---
> src/gallium/drivers/rbug/rbug_context.c | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git a/
onal backends. Kristian
> > may have some ideas about how to do that.
>
> Sounds good.
>
The libEGL.so code in Mesa might not be exactly what you are looking for,
the current dispatching is more like mesas internal driver dispatching then
libGL.so straight up dispatching, as it v
The changes looks good at a first glance.
There are some thoughts tho,
maybe we should try and make libxatracker.so autodetect
which driver to use so we don't have to create a libxatracker.so
for each driver, at least for linux that should be do-able.
Thoughts?
Cheers,
On Tue, Jul 2, 2013 at 11:37 PM, Matt Turner wrote:
> On Tue, Jul 2, 2013 at 1:02 PM, Ian Romanick wrote:
> > 2. Instead of just posting md5sum for the release tarballs, I think we
> > should start GPG signing them. I'm not sure what sort of process we
> want to
> > establish for this. Should
,
going to take a extra look at the xa patches on the mesa sida.
Cheers, Jakob.
On Mon, Jun 10, 2013 at 7:31 PM, Rob Clark wrote:
> Only just compile tested, as I don't have the "hardware" for it..
>
> Signed-off-by: Rob Clark
> ---
> configure.ac |
Hi! My name is Jakob Sinclair and I would like to start contributing to
mesa development. I was wondering if anyone has any easy tasks that I as
a newbie could start working on. I tried looking at
https://wiki.freedesktop.org/dri/NewbieProjects/ but it seems that page
is outdated and most of
On 2016-04-11 09:14, Jason Ekstrand wrote:
Jakob,
Thanks for your interest and welcome to the mailing list!
Thanks!
Yes, the NewbieProjects page, as with much of the mesa documentation,
is a bit
dated. Before I can really tell you where to start, it would be good
to have a bit of
On 2016-04-11 14:07, Marek Olšák wrote:
Hi Jakob,
Getting familiar with the code should be the first priority. I suggest
you start with a simple feature like adding an easy GL or GL ES
extension into your favourite driver.
You should also use a test suite for testing driver correctness. The
On 2016-04-11 17:25, Ilia Mirkin wrote:
On Mon, Apr 11, 2016 at 11:18 AM, Jakob Sinclair
wrote:
Thanks for the tips! I have been looking at the
ARB_shader_image_load_store
and ARB_shader_image size extensions for GL ES 3.1 and noticed that
the
radeonsi drivers does not support them even
ne that is reviewing this patch can push this.
Signed-off-by: Jakob Sinclair
---
src/mesa/state_tracker/st_cb_bufferobjects.c | 8
src/mesa/state_tracker/st_cb_drawpixels.c| 8
src/mesa/state_tracker/st_cb_readpixels.c| 4 ++--
src/mesa/state_tracker/st_cb_texture.c
On 2016-04-12 11:00, Timothy Arceri wrote:
On Sun, 2016-04-10 at 21:45 +0200, Jakob Sinclair wrote:
Hi! My name is Jakob Sinclair and I would like to start contributing
to
mesa development. I was wondering if anyone has any easy tasks that I
as
a newbie could start working on. I tried looking
Trivial change. Removing unnecessary semi-colons from the code.
I don't have push access so someone reviewing this can push it.
Signed-off-by: Jakob Sinclair
---
src/mesa/main/pipelineobj.c | 2 +-
src/mesa/main/shaderapi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
Trivial change. Removing unnecessary semi-colons from the code.
I don't have push access so someone reviewing this can push it.
Signed-off-by: Jakob Sinclair
---
src/compiler/glsl/ast_function.cpp | 2 +-
src/compiler/glsl/ir_rvalue_visitor.cpp | 2 +-
2 files changed, 2 insertions(
Trivial change. Removing unnecessary semi-colons from the code.
I don't have push access so someone reviewing this can push it.
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/dr
he uniform storage so it just uses the
gl_constant_value could lead to much simplier, but also more effiecient,
code.
So is it a reasonable idea to implement right now?
What kind of problems could you expect and would anyone benefit from
it?
--
Mvh Jako
On 2016-04-14 00:43, Ian Romanick wrote:
It looks like there are a couple other instances dangling around the
tree. src/glx/dri2_glx.c, src/mesa/math/m_debug_norm.c, etc.
I did 'grep -r ';[[:space:]]*;' src/'. Most of the hits were
for-loops.
On 04/13/2016 09:43 AM,
yet either.
Regards
Jakob Sinclair
Jakob Sinclair (4):
egl: Remove every double semi-colon
gallium: Remove every double semi-colon
glx: Remove every double semi-colon
mesa: Remove every double semi-colon
src/egl/drivers/dri2/platform_android.c | 2 +-
src/egl/dr
Signed-off-by: Jakob Sinclair
---
src/glx/dri2_glx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
index 7710349..eae3c0f 100644
--- a/src/glx/dri2_glx.c
+++ b/src/glx/dri2_glx.c
@@ -405,7 +405,7 @@ dri2CreateDrawable(struct
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/freedreno/a3xx/fd3_emit.c | 2 +-
src/gallium/drivers/ilo/ilo_resource.c| 2 +-
src/gallium/drivers/ilo/shader/ilo_shader_gs.c| 2 +-
src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp | 2
Removes all acidental semi-colons in egl.
Signed-off-by: Jakob Sinclair
---
src/egl/drivers/dri2/platform_android.c | 2 +-
src/egl/drivers/dri2/platform_surfaceless.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl
Signed-off-by: Jakob Sinclair
---
src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 2 +-
src/mesa/math/m_debug_norm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp
b/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp
index
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index 6a990ed..2382b1d 100644
--- a/src/gallium/drivers/radeonsi/si_pipe.c
This patch adds the needed function for ARB_clear_texture.
The function itself is mostly based on the nouveau implementation.
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/radeon/r600_texture.c | 72 +++
1 file changed, 72 insertions(+)
diff --git a/src
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/r600/r600_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/r600/r600_pipe.c
b/src/gallium/drivers/r600/r600_pipe.c
index c594f5c..7d1d6b2 100644
--- a/src/gallium/drivers/r600/r600_pipe.c
+++ b
Tested with piglit. All ARB_clear_texture tests passed.
Signed-off-by: Jakob Sinclair
---
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index dc75cf8..654c856 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -192,7 +192,7 @@ GL 4.4
tures...)
Thanks for the heads up. It did at least not cause any errors on the
piglit test.
I will need to probably check with other radeon developers to see if
this is actually safe.
--
Mvh Jakob Sinclair
___
mesa-dev mailing list
mes
implementation of the same function. I don't have push access so someone
reviewing this can push it.
Regards
Jakob Sinclair
Jakob Sinclair (4):
gallium/radeon: add clear_texture function
gallium/radeonsi: enable ARB_clear_texture
gallium/r600: enable ARB_clear_texture
docs/GL3.txt:
e that object to create a new surface which the old
surface can now point too.
Did I get the idea behind it or did I misunderstand the whole thing?
--
Mvh Jakob Sinclair
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedes
This patch fixes a Coverity defect. By checking if the value is negative before
using it to index an array it makes the code a bit safer and cleaner but it
should not actually change the outcome of the functions.
CID: 1355598
Jakob Sinclair (1):
radeonsi: check if value is negative
src
Fixes a Coverity defect by adding checks to see if a value is negative
before using it to index an array. By checking the value first it makes
the code more clean and it doesn't change the outcome of the function.
CID: 1355598
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/rad
Fixes a Coverity defect by adding checks to see if a value is negative
before using it to index an array. By checking the value first it makes
the code a bit safer but overall should not have a big impact.
CID: 1355598
Signed-off-by: Jakob Sinclair
---
Resending this patch because I did not
Reviewed-by: Jakob Bornecrantz
On 17 Nov 2014 18:11, "Brian Paul" wrote:
> Fix oversights from the "add a window_space option to the passthrough
> vertex shader" patch.
> ---
> src/gallium/tests/trivial/quad-tex.c |2 +-
> src/gallium/tests/trivial/tri.
Could cause issues if you tried to read from an uninitialised pointer.
This just initalises the pointer to null to avoid that being a problem.
Discovered by Coverity.
CID: 1343616
Signed-off-by: Jakob Sinclair
---
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
1 file changed, 1 insertion
On 2016-06-06 15:48, Iago Toral wrote:
Reviewed-by: Iago Toral Quiroga
I don't have push access so I would be very happy if you could push this
patch for me. Thanks!
--
Mvh Jakob Sinclair
On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote:
Could cause issues if you tried to
gned-off-by: Jakob Sinclair
---
I don't have push access so anyone reviewing this could push it. Thanks!
src/gallium/drivers/radeon/r600_texture.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers/radeo
Reviewed-by: Nicolai Hähnle
Thanks!
--
Mvh Jakob Sinclair
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
V2: Removed "- PIPE_SWIZZLE_X" for more consistency.
CID: 1337954
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/radeon/r600_texture.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers/radeon/r600_te
0) rather than explicit.
the same comment applies to your v2.
Jan
Thanks for the input. Now when I think about it again this is probably a
bad change.
Didn't think about the lower bound. So this patch should probably not be
pushed.
--
Mvh Jakob Sin
So I have encountered bug that should be fixed by this. In my case its
a happy little accident that I can use GL_ARB_gpu_shader5 in a
compatibility context (since I want the textureGatherOffset
functions). So while one part of me is happy that the bug exist.
Cheers, Jakob
On Sun, Aug 24, 2014 at 2:16 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/texture.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Jakob Bornecrantz
>
> diff --git a/src/texture.c b/src/texture.c
> index 659d0de..40
On Sun, Aug 24, 2014 at 2:16 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> set c99 because u_math.h fails to compile without it with gcc
> ---
> Makefile.in | 5 +++--
> configure.ac | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Jakob Bornecran
nged, 136 insertions(+), 38 deletions(-)
I'm assuming most of those random changes in the xml are due to the
editing app doing stupid stuff. If that is the case and since the code
changes looks good to me, this patch is
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob.
On Mon, Oct 16, 2017 at 5:04 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> Fixes: 6a7dea93fa7 ("dri: Rework planar image interface")
> Cc: Jakob Bornecrantz
> Signed-off-by: Emil Velikov
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob.
> ---
> src/
c87ed4 ("dri: Make query image WIDTH and HEIGHT be version 4")
> Cc: Jakob Bornecrantz
> Signed-off-by: Emil Velikov
Reviewed-by: Jakob Bornecrantz
Cheers, Jakob.
> ---
> src/gbm/backends/dri/gbm_dri.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
On Mon, Oct 16, 2017 at 6:58 PM, Scott D Phillips
wrote:
> Dylan Baker writes:
>
>> Quoting Scott D Phillips (2017-10-16 10:04:45)
>> > Dylan Baker writes:
>> >
>> > > Quoting Jakob Bornecrantz (2017-10-14 13:03:14)
>> > > > On S
y more verbose than we need and would drop
> a huge source of our "fix up the build system" patches for automake's
> stupid distcheck.
Wasn't lacking distcheck support one of the arguments against moving
to only a scons build wh
;t you just use the Makefile parser José wrote for the scons
build, that would avoid running make and waiting for a new version of
Meson. Or is there something it is lacking?
We could start out with our own Makefile parser and then move onto one
in Meson once it is upstreamed and
These extensions are important for Vulkan interop and various
other use cases. So it would be nice if we tracked them.
Cheers, Jakob.
Signed-off-by: Jakob Bornecrantz
---
docs/features.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/features.txt b/docs/features.txt
index
ecise declarations) only declarations.
Going to do some testing on this patch soon.
Cheers, Jakob.
On Tue, Apr 10, 2018 at 7:02 PM Marek Olšák wrote:
>
> This doesn't change TGSI. It only changes utilities around it.
>
> Marek
>
> On Mon, Apr 9, 2018 at 6:02 PM, Joe M. Kniss
On Mon, Jun 18, 2018 at 1:06 PM Elie Tournier wrote:
>
> On Mon, Jun 18, 2018 at 12:06:42PM +0100, Jakob Bornecrantz wrote:
> > TGSI already has a invariant field on declarations, we are running
> > into a bug with virgl because st_glsl_to_tgsi completely drops the
> > inv
larger then the struct
virgl_caps_v1 dummy and cause it to write over the stack? (I am assuming
you are using the dummy here as a place to put the extra caps the host
is exposing but the driver isn't supporting).
Wouldn't it be better if we had a virgl_block_skip function?
Che
On 2018-06-27 23:26, Dave Airlie wrote:
On 28 June 2018 at 03:25, Jakob Bornecrantz wrote:
On 2018-06-08 07:22, Dave Airlie wrote:
From: Dave Airlie
The vtest protocol is pretty simple but also pretty dumb, and
the v1 caps query was fixed size, with no nice way to expand it,
however the
Tested-by: Jakob Bornecrantz
On Mon, May 14, 2018 at 3:14 PM, Tomeu Vizoso
wrote:
> Virgl could save a lot of work converting buffers in the host side
> between formats if Mesa supported a bunch of other formats when reading
> pixels.
>
> This commit adds cases to handle spec
I have run this patch on my Intel host running various CTS in a virgl
guest. Not sure if this constitutes as a Tested-by or a Acked-by, but
at least it is a datapoint.
Cheers, Jakob.
On Fri, May 18, 2018 at 11:04 AM, Tomeu Vizoso
wrote:
> Virgl could save a lot of work converting buffers in
ing if the returned value is
zero or not. Looking around it seems that a lot of other drivers just
returns zero for PIPE_CAP_VIEWPORT_SUBPIXEL_BITS not just virgl, so
this probably causes regressions on more drivers then virgl.
Cheers, Jakob.
___
mesa-dev m
This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full
setup is dEQP running on virgl with vtest that is running RadeonSI. So
QEMU is not in the picture. All instances of the Mesa driver is from
the same tree and have the patch applied.
Cheers, Jakob.
On Wed, Sep 12, 2018 at 12:05 PM
On Wed, Sep 19, 2018 at 1:48 PM Ilia Mirkin wrote:
>
> On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz
> wrote:
> > This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full
> > setup is dEQP running on virgl with vtest that is running RadeonSI. So
> >
Tested-by: Jakob Bornecrantz
On Wed, Oct 17, 2018 at 5:29 PM Marek Olšák wrote:
>
> From: Marek Olšák
>
> Cc: 18.1 18.2
> ---
> src/gallium/drivers/radeonsi/si_state_draw.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/s
Tested-by: Jakob Bornecrantz
On Wed, Oct 17, 2018 at 5:29 PM Marek Olšák wrote:
>
> From: Marek Olšák
>
> This fixes dEQP-GLES2.functional.rasterization.limits.points.
> Broken by: ea039f789d9b54e1bd1d644b6a29863ca3500314
> ---
> src/gallium/drivers/radeonsi/si_get.c | 5
Reviewed-by: Jakob Bornecrantz
On Tue, Aug 14, 2018 at 2:02 PM, Erik Faye-Lund
wrote:
> These macro-names are also used for softpipe, so let's avoid confusion
> by avoiding them. Besides, they are just used in one place in virgl, so
> let's just inline them into the place th
Reviewed-by: Jakob Bornecrantz
On Tue, Aug 14, 2018 at 2:02 PM, Erik Faye-Lund
wrote:
> Instead of doing conservative guesses, we should report the max levels
> based on the max sizes we get from GL on the host.
>
> Signed-off-by: Erik Faye-Lund
> ---
> src/gallium/driver
On 2016-04-27 12:17, Marek Olšák wrote:
Reviewed-by: Marek Olšák
Marek
On Mon, Apr 25, 2016 at 9:03 AM, Jakob Sinclair
wrote:
Fixes a Coverity defect by adding checks to see if a value is negative
before using it to index an array. By checking the value first it
makes
the code a bit safer
re careful with testing the patch. Anyways
this looks all good to me. By the fact that you are using assert I'm
guessing that first_non_void shouldn't be negative very often and that
when it is negative something has gone horribly wrong.
Reviewed-by: Jakob Sinclair
On 2016-05-02 07:15, Jan Vesely wrote:
From: Jan Vesely
Signed-off-by: Jan Vesely
---
src/gallium/auxiliary/util/u_blitter.c| 10 +-
src/gallium/auxiliary/util/u_cpu_detect.c | 2 +-
src/gallium/auxiliary/util/u_format.c | 4
e constructors.
This issue was discovered by Coverity.
CID: 401603, 401604, 401605, 401610
Signed-off-by: Jakob Sinclair
---
src/compiler/glsl/ir.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp
index d69ab13..9637d7a 100644
--- a/src/
e constructors.
This issue was discovered by Coverity.
CID: 401603, 401604, 401605, 401610
Signed-off-by: Jakob Sinclair
---
I don't have push access so anyone reviewing this patch could push it. Thank
you!
src/compiler/glsl/ir.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/s
1 - 100 of 357 matches
Mail list logo
