indeed commits prior to that one work as expected. Any hints what
> would be the right fix to not trigger the assert?
Hmm strange,
So on etnaviv devices, as far as I know, the maximum 'stride' between vertices
is 256.
This means that a starting offset of 576 is
d now be able to use hw-atomics for some stages and not for
> other, if needed.
>
> Signed-off-by: Erik Faye-Lund
Etnaviv part
Reviewed-by: Wladimir J. van der Laan
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> index
-off-by: Erik Faye-Lund
Etnaviv part
Reviewed-by: Wladimir J. van der Laan
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> index 9669bd2f60..108b97d35c 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
06d0d11d0b238ab2ba2d4dd9d43.
> Reviewed-by: Rob Clark
Thanks!
Regards,
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Add support for:
- PIPE_FORMAT_ETC1_RGB8
- PIPE_FORMAT_DXT1_RGB
- PIPE_FORMAT_DXT1_RGBA
- PIPE_FORMAT_DXT3_RGBA
- PIPE_FORMAT_DXT5_RGBA
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++
1 file changed, 11
Denormalized texture coordinates are required for text rendering in
GALLIUM_HUD.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++-
src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 +
src/gallium/drivers
Use DOT2ADDv instruction with 0.0f constant add.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 +
1 file changed, 21 insertions(+)
Change since v2: spaces->tabs
diff --git a/src/gallium/driv
Compose swizzles using util_format_compose_swizzles instead
of the custom code (which somehow had a bug).
This makes the GL_ALPHA internal format work.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +-
1
Extend translate_sge_slt to emit these, in analogous fashion
but using CNDEv.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
Change since v2
Change use of BLEND_ to BLEND2_,
BLEND_* a3xx_rb_blend_opcode
BLEND2_* is a2xx_rb_blend_opcode
This makes no effective difference as the used enumerant has the same
value (0), but the other enumerants do not match 1-to-1 so this will
avoid future problems.
Signed-off-by: Wladimir J. van
p patch 6,7,8
Wladimir J. van der Laan (8):
freedreno: a2xx: Update rnndb header for formats enumeration
freedreno: a2xx: Change use of BLEND_ to BLEND2_
freedreno: a2xx: Fix fd2_tex_swiz
freedreno: a2xx: Prevent crash in emit_texture if view is not set
freedreno: a2xx: Support
Textures will sometimes be updated if texture view state was
un-set, without this change that causes an assertion crash or
segfault.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 13 ++---
1 file changed, 10
The format enumeration comes comes from the yamoto
register headers that are part of the amd-gpu kernel driver.
(see freedreno envytools commit 1b32c444f82cd7144d71602106462f59f146c1d0)
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Ilia Mirkin
---
src/gallium/drivers/freedreno/a2xx
sue here is that I had set my editor for spaces due to the other
parts of mesa)
> Reviewed-by: Ilia Mirkin
Thanks.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Use DOT2ADDv instruction with 0.0f constant add.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c
b/src/gallium/drivers
Add support for:
- PIPE_FORMAT_ETC1_RGB8
- PIPE_FORMAT_DXT1_RGB
- PIPE_FORMAT_DXT1_RGBA
- PIPE_FORMAT_DXT3_RGBA
- PIPE_FORMAT_DXT5_RGBA
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src
Change use of BLEND_ to BLEND2_,
BLEND_* a3xx_rb_blend_opcode
BLEND2_* is a2xx_rb_blend_opcode
This makes no effective difference as the used enumerant has the same
value (0), but the other enumerants do not match 1-to-1 so this will
avoid future problems.
Signed-off-by: Wladimir J. van
Denormalized texture coordinates are required for text rendering in
GALLIUM_HUD.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++-
src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 +
src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 1
Extend translate_sge_slt to emit these, in analogous fashion
but using CNDEv.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/freedreno
The format enumeration comes comes from the yamoto
register headers that are part of the amd-gpu kernel driver.
(see freedreno envytools commit 1b32c444f82cd7144d71602106462f59f146c1d0)
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33
Textures will sometimes be updated if texture view state was
un-set, without this change that causes an assertion crash or
segfault.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions
the patch stack.
Changes since first post:
- Split up rnndb patch into a patch that changes formate numeration
and one that changed BLEND->BLEND2.
- fd2_emit emit_texture const correctness.
I checked that there is no Gallium capability to be set for TEXTURE_RECT.
Wladimir J. van der Laan (8)
Compose swizzles using util_format_compose_swizzles instead
of the custom code (which somehow had a bug).
This makes the GL_ALPHA internal format work.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +-
1 file changed, 9
that all Gallium drivers support, or at
least emulate this.
For example in src/mesa/state_tracker/st_extensions.c:
extensions->NV_texture_rectangle = GL_TRUE;
Regards,
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.free
On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote:
> Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's
> called... I forget.)
Yes, good point, will add that.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.free
On Thu, Jan 25, 2018 at 08:40:00AM -0500, Ilia Mirkin wrote:
> On Thu, Jan 25, 2018 at 8:29 AM, Wladimir J. van der Laan
> wrote:
> > Also update BLEND_ to BLEND2_ opcodes to accomodate.
>
> Are you saying this doesn't compile right now? I would have expected
>
Use DOT2ADDv instruction with 0.0f constant add.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c
b/src/gallium/drivers
Extend translate_sge_slt to emit these, in analogous fashion
but using CNDEv.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/freedreno
Compose swizzles using util_format_compose_swizzles instead
of the custom code (which somehow had a bug).
This makes the GL_ALPHA internal format work.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +-
1 file changed, 9
Textures will sometimes be updated if texture view state was
un-set, without this change that causes an assertion crash or
segfault.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff
Denormalized texture coordinates are required for text rendering in
GALLIUM_HUD.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++-
src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 +
src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 1
Add support for:
- PIPE_FORMAT_ETC1_RGB8
- PIPE_FORMAT_DXT1_RGB
- PIPE_FORMAT_DXT1_RGBA
- PIPE_FORMAT_DXT3_RGBA
- PIPE_FORMAT_DXT5_RGBA
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src
Also update BLEND_ to BLEND2_ opcodes to accomodate.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33 +++
src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 4 ++--
2 files changed, 15 insertions(+), 22 deletions(-)
diff
the patch stack.
Wladimir J. van der Laan (7):
freedreno: a2xx: Update rnndb header
freedreno: a2xx: Fix fd2_tex_swiz
freedreno: a2xx: Prevent crash in emit_texture if view is not set
freedreno: a2xx: Support TEXTURE_RECT
freedreno: a2xx: Compressed textures support
freedreno: a2xx: imp
Update state objects to add new state, and emit function to emit new
state.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 249 +++--
src/gallium/drivers/etnaviv/etnaviv_internal.h | 4 +
src
Hello Christian,
On Sat, Nov 25, 2017 at 05:10:36PM +0100, Christian Gmeiner wrote:
> 2017-11-18 10:44 GMT+01:00 Wladimir J. van der Laan :
> > Update state objects to add new state, and emit function to emit new
> > state.
> >
> > Signed-off-by: Wladimir J. va
On Thu, Nov 23, 2017 at 10:37:15AM +0100, Lucas Stach wrote:
> Am Donnerstag, den 23.11.2017, 10:08 +0100 schrieb Wladimir J. van der Laan:
> > Vertex buffer legacy state is no longer picked up with new drawing
> > commands. Change to use different cases depending on the numbe
Vertex buffer legacy state is no longer picked up with new drawing
commands. Change to use different cases depending on the number of
vertex streams in the GPU specs.
This results in slightly more compact state emission as well, on all
vivantes.
This needs to go in before "etnaviv: Use only DRAW_
se 00684/006A8 only on
single-vertex-stream GPUs, otherwise write consecutively.
(I must already had this patched locally when I tested this, but regarded as
unnecessary later...)
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https:/
On Wed, Nov 22, 2017 at 07:29:18PM +0100, Wladimir J. van der Laan wrote:
>
> > I would really like to know what's wrong with this patch, as using the
> > new draw command should be fine on GC3000 and we certainly want to
> > support instanced drawing at some point.
&
there's something wrong with that one - DRAW_INSTANCED seems to be
ignored if state 00780+attr stays at 0.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hello Lucas,
On Wed, Nov 22, 2017 at 02:29:33PM +0100, Lucas Stach wrote:
> Hi Wladimir,
>
> Am Samstag, den 18.11.2017, 10:44 +0100 schrieb Wladimir J. van der Laan:
> > The blob does this, as DRAW_INSTANCED can replace fully all the other
> > draw commands. It is al
cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/freedreno/a4xx/fd4_program.c#n473
> +
> https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c#n2945
>
> (i.e. you have to load flat inputs specially on a4xx+)
Interesting, both quite different approaches from Vivante.
Regards,
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Prepare for two texture handling paths, the descriptor-based
path will be added in a future commit. These are structured
so that the texture implementation handles its own state
emission.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv
This needs to be shared between texture_plain and texture_desc.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.c| 12
src/gallium/drivers/etnaviv/etnaviv_texture.c | 6 ++
src/gallium/drivers/etnaviv
When the BLT is involved as source or target, add an extra BLT
enable/disable sequence around the sync sequence.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
Unchanged since v1
This will be shared with the texture descriptor path.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_texture.c | 42 +--
src/gallium/drivers/etnaviv/etnaviv_texture.h | 5
2 files changed, 31
Update context reset for HALTI3..HALTI5, sorting states for the HALTI
version that has them.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 37 +++
1 file changed, 32 insertions(+), 5 deletions
Update state objects to add new state, and emit function to emit new
state.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 246 +++--
src/gallium/drivers/etnaviv/etnaviv_internal.h | 4 +
src
Track varying component offset of the point size output, as well as
provide the offset of the point coord input.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 21 +++--
src/gallium/drivers/etnaviv
RS align is not necessary and might even be harmful when using the BLT
engine for blitting.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 +
src/gallium/drivers/etnaviv/etnaviv_surface.c | 41
Need this to efficiently emit texture descriptor invalidations.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 1 +
src/gallium/drivers/etnaviv/etnaviv_context.h | 1 +
src/gallium/drivers/etnaviv/etnaviv_emit.c| 1
Add an implemenation of key clear_blit functions using the BLT engine
that replaced the RS on GC7000.
Also set level->size correctly for imported resources. This is important
for the BLT resolve-in-place path to work for them.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/driv
- This core must load shaders from memory (AFAIK)
- Yet another new location for UNIFORMS
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions
The HALTI level is an indication of the gross architecture of the GPU.
It determines for significant part what feature level the GPU has, what
state (especially frontend state) is there, and where it is located.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src
This is used by HALTI2+ (GC3000+) when drawing with DRAW_INSTANCED.
It is also necessary when switching between integer and floating point
vertex element formats.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 5
Prepare for BLT-based blitting path by moving RS-based
blitting to the RS implementation file, making this
self-contained.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 558 +--
src/gallium/drivers/etnaviv/etnaviv_clear_blit.h
ed this issue as I'm using the Vivante kernel driver. If
you want to see etnaviv_texture_desc.c in its current state, it's here:
https://github.com/laanwj/mesa/blob/gc7000/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c
Wladimir J. van der Laan (17):
etnaviv: Const-correctness etnav
Want to be able to emit state from the texture implementation,
and the blitter implementation.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 83 --
src/gallium/drivers/etnaviv/etnaviv_emit.h
The relocation structure is never changed by submitting it.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Philipp Zabel
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Unchanged since v1.
diff --git a
changes the behavior for GC3000-, by no longer using
the index offset for DRAW_INDEXED but instead adding it to INDEX_ADDR.
This should make no difference.
Preparation for GC7000 support.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Philipp Zabel
---
src/gallium/drivers/etnaviv
On Wed, Nov 15, 2017 at 05:33:17PM +0100, Lucas Stach wrote:
> The OVERWRITE bit disables destination fetches, which is exactly what
> we want when there is no valid color buffer bound.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Wladimir J.
On Thu, Nov 16, 2017 at 12:26:05PM -0500, Ilia Mirkin wrote:
> On Thu, Nov 16, 2017 at 7:15 AM, Wladimir wrote:
> The point of the texcoord semantics is precisely point sprite
> replacement. NVIDIA hardware (Fermi+) can only do point sprite
> replacement on certain specially-loca
_vertex, currently we don't handle
pipe_rasterizer_state->point_size at all, we pretty much just assume
point_size_per_vertex.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ld be reasonable to re-emit the shader state (or maybe
just the varyings) when the primitive type changes from points to
non-points. It virtually never happens that the same shader combo is
used for points and non-points.
Wladimir
___
mesa-dev mailing li
coordinate, e.g. to render solid points?
I thought about that, but I don't think it's general enough.
Could we make the blitter label texture coordinates properly?
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://
s nor flat shading.
I'll have a look...
Regards,
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
: fix varying
interpolation"
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c
b/src/gallium/drivers/etnaviv/etnaviv_compil
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +-
src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +-
src/gallium/drivers/etnaviv/hw/state.xml.h | 4 ++--
src/gallium/drivers/etnaviv/hw/state_3d.xml.h
when not using sampler TS, as
resolve-in-place will now be skipped if a resource has no (valid) TS.
Signed-off-by: Wladimir J. van der Laan
Reviewed-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_emit.c| 26 ++
src/gallium/drivers/etnaviv/etnaviv_texture.c | 74
Resources only need a resolve-to-itself if their TS is valid for any
level, not just if it happens to be allocated.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 +
src/gallium/drivers/etnaviv/etnaviv_resource.h | 6 +-
2 files
This is to make sure that the TS is properly flushed to memory before
rendering to a new surface starts.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.c
b
re rendering to a new surface
starts). This should prevent missing tile artifacts.
- Remove unused added arguments from etna_update_sampler_source /
etna_configure_sampler_ts / etna_can_use_sampler_ts
Wladimir J. van der Laan (5):
etnaviv: rnndb update
etnaviv: Check that resource ha
Sampler TS introduces yet another format enumeration for
renderable+textureable formats. Introduce it into the etnaviv_format
table as another column.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 162 +++
src/gallium/drivers
systems.
Reviewed-by: Wladimir J. van der Laan
> Wladimir, Christian: while looking at f1e1c60ff6, I noticed
> state_blt.xml.h and texdesc_3d.xml.h were also added, but don't seem to
> be used anywhere; were those files added by mistake?
I guess so. They're used in upcomin
On Tue, Nov 7, 2017 at 5:43 PM, Wladimir J. van der Laan
wrote:
> Sampler TS introduces yet another format enumeration for renderable
> formats. Introduce it into etnaviv_format as unobtrusively as possible.
>
> Signed-off-by: Wladimir J. van der Laan
> ---
> src/galli
On Fri, Nov 10, 2017 at 07:42:12AM +0100, Wladimir J. van der Laan wrote:
> Hello Lucas,
>
> On Thu, Nov 09, 2017 at 06:15:51PM +0100, Lucas Stach wrote:
> > Hi Wladimir!
>
> > > etna_resource_needs_flush is only called from two places - here, and
> > &
Hello Lucas,
On Thu, Nov 09, 2017 at 06:15:51PM +0100, Lucas Stach wrote:
> Hi Wladimir!
> > etna_resource_needs_flush is only called from two places - here, and
> > in resource_flush, where it also determines whether to do a
> > resolve-to-self, but before presenting the
valid_ts(&to->base)) {
I just realized - would it maybe make sense to roll the call to
etna_resource_has_valid_ts into etna_resource_needs_flush?
etna_resource_needs_flush is only called from two places - here, and
in resource_flush, where it also determines whether to do a
res
Update rnndb to etna_viv 07c756a.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +-
src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +-
src/gallium/drivers/etnaviv/hw/state.xml.h | 4 ++--
src/gallium/drivers/etnaviv/hw
Sampler TS introduces yet another format enumeration for renderable
formats. Introduce it into etnaviv_format as unobtrusively as possible.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_format.c | 19 +++
src/gallium/drivers/etnaviv
: 7.692 ms
after: [shadow] : FPS: 244 FrameTime: 4.098 ms
Wladimir J. van der Laan (3):
etnaviv: rnndb update
etnaviv: Add TS_SAMPLER formats to etnaviv_format
etnaviv: Add sampler TS support
src/gallium/drivers/etnaviv/etnaviv_emit.c | 26 +++
src/gallium/drivers/etnaviv/etnavi
when not using sampler TS, as
resolve-in-place will now be skipped if a resource has no (valid) TS.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c| 26
src/gallium/drivers/etnaviv/etnaviv_texture.c | 92 +--
src/gallium
;
> > +
> > +#include "hw/state_3d.xml.h"
>
> Is this include needed?
Huh, no, I don't see why the states would need to be included in the header,
probably a leftover, I'll remove it.
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
e) {
if (!ctx->specs.use_blt) {
...
}
} else {
if (!ctx->specs.use_blt)
..
}
My current working tree can be found at
https://github.com/laanwj/mesa/tree/gc7000. It contains these patches
(but also some temporary local scaffolding, so be warned).
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Sun, Nov 5, 2017 at 1:09 PM, Christian Gmeiner
wrote:
> 2017-10-30 17:16 GMT+01:00 Wladimir J. van der Laan :
>> Prepare for BLT-based blitting path by moving RS-based
>> blitting to its own implementation file.
>>
>> Signed-off-by: Wladimir J. van der Laan
>
On Sun, Nov 5, 2017 at 12:47 PM, Christian Gmeiner
wrote:
> 2017-10-30 17:16 GMT+01:00 Wladimir J. van der Laan :
>> When the BLT is involved as source or target, add an extra BLT
>> enable/disable sequence around the sync sequence.
>>
>
> Does this mean we are doing l
HALIGN_FOUR/SIXTEEN has no meaning for compressed textures, and we can't
render to them anyway. So use the tightest possible packing. This
avoids bugs with non-power-of-two block sizes.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_resource.c
On Wed, Nov 01, 2017 at 01:27:30PM -0400, Ilia Mirkin wrote:
> On Wed, Nov 1, 2017 at 1:19 PM, Wladimir J. van der Laan
> wrote:
> > Add ASTC texture support for hardware that supports this
> > (currently only GC3000 on i.MX6qp is known to have this).
> >
> > Pi
ay. Having a specs bit is easier
for that.
(also, vivante is doing away with feature bits on newer GPUs; we're
going to have our own model->specs mapping database like them at some point)
Wladimir
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, Nov 01, 2017 at 02:27:40PM +0100, Lucas Stach wrote:
> Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan:
> > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote:
> > > I would prefer the shorter expression (!cb->buffer && !cb->
rdware (programmed through a different register), so IMO it makes sense to
add a new format bit for it, just like for EXT_FORMAT.
Relying on mesa's judgement on whether something is astc seems brittle.
Regards,
Wladimir
___
mesa-dev mailing li
Updated as of etnav_viv commit 3b4a8ec.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +-
src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +-
src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +-
src/gallium/drivers/etnaviv
drs Block 4x4.
PIGLIT: {"subtest": {"sRGB decode full precision" : "fail"}}
PIGLIT: {"subtest": {"sRGB skip decode" : "pass"}}
This means all block sizes are working, and basic RGB/sRGB.
Not sure why "sRGB decode full precisi
Add ASTC texture support for hardware that supports this
(currently only GC3000 on i.MX6qp is known to have this).
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_emit.c | 8 +++
src/gallium/drivers/etnaviv/etnaviv_format.c | 30
On Wed, Nov 1, 2017 at 11:35 AM, Eric Engestrom
wrote:
> On Wednesday, 2017-11-01 11:17:53 +0100, Wladimir J. van der Laan wrote:
>> GC3000 resolve-in-place assumes that the TS state is configured.
>> If it is not, this will result in MMU errors. This is especially
>>
On Wed, Nov 01, 2017 at 11:57:39AM +0100, Philipp Zabel wrote:
> On Mon, 2017-10-30 at 17:16 +0100, Wladimir J. van der Laan wrote:
> > The blob does this, as DRAW_INSTANCED can replace fully all the other
> > draw commands - the other path is only there for compatibility and
>
On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote:
> Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan:
> > GC3000 resolve-in-place assumes that the TS state is configured.
> > If it is not, this will result in MMU errors. This is especially
&g
GC3000 resolve-in-place assumes that the TS state is configured.
If it is not, this will result in MMU errors. This is especially
apparent when using glGenMipmaps().
Fixes a problem introduced in 78ade659569ee6fe9bd244170956139f19dd8c6c.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium
This will be shared with the texture descriptor path.
Signed-off-by: Wladimir J. van der Laan
---
src/gallium/drivers/etnaviv/etnaviv_texture.c | 40 +--
src/gallium/drivers/etnaviv/etnaviv_texture.h | 5
2 files changed, 30 insertions(+), 15 deletions(-)
diff
1 - 100 of 264 matches
Mail list logo