Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Jason Ekstrand
On Wed, Feb 14, 2018 at 9:42 AM, Ville Syrjälä < ville.syrj...@linux.intel.com> wrote: > On Wed, Feb 14, 2018 at 04:43:15PM +, Daniel Stone wrote: > > On 14 February 2018 at 16:27, Jason Ekstrand > wrote: > > > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone > wrote: > > >> > On Tue, Feb 13, 2

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Ville Syrjälä
On Wed, Feb 14, 2018 at 04:43:15PM +, Daniel Stone wrote: > On 14 February 2018 at 16:27, Jason Ekstrand wrote: > > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote: > >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone > >> > wrote: > >> >> For actual scanout, the kernel very specifical

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Daniel Stone
On 14 February 2018 at 17:23, Jason Ekstrand wrote: > On Wed, Feb 14, 2018 at 8:43 AM, Daniel Stone wrote: >> Linear is unchanged as it's implicit. X tiling has to take the >> workaround, in case anyone wants to display it. > > I'm not sure I buy that. From a userspace perspective, you shouldn't

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Jason Ekstrand
On Wed, Feb 14, 2018 at 8:43 AM, Daniel Stone wrote: > On 14 February 2018 at 16:27, Jason Ekstrand wrote: > > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone > wrote: > >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone > wrote: > >> >> For actual scanout, the kernel very specifically demands

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Daniel Stone
On 14 February 2018 at 16:27, Jason Ekstrand wrote: > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote: >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone >> > wrote: >> >> For actual scanout, the kernel very specifically demands that if the >> >> BO is X-tiled, then set_tiling be called wi

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Jason Ekstrand
On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote: > Hi, > > On 13 February 2018 at 22:15, Jason Ekstrand wrote: > > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone > wrote: > >> On 9 February 2018 at 23:43, Jason Ekstrand > wrote: > >> For actual scanout, the kernel very specifically demands

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Daniel Stone
On 14 February 2018 at 11:39, Daniel Stone wrote: > On 13 February 2018 at 22:15, Jason Ekstrand wrote: >> On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote: >>> On 9 February 2018 at 23:43, Jason Ekstrand wrote: >>> For actual scanout, the kernel very specifically demands that if the >>> BO

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-14 Thread Daniel Stone
Hi, On 13 February 2018 at 22:15, Jason Ekstrand wrote: > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote: >> On 9 February 2018 at 23:43, Jason Ekstrand wrote: >> For actual scanout, the kernel very specifically demands that if the >> BO is X-tiled, then set_tiling be called with TILING_X

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote: > Hi Jason, > > On 9 February 2018 at 23:43, Jason Ekstrand wrote: > > - /* For images using modifiers, we require a dedicated > allocation > > - * and we set the BO tiling to match the tiling of the > underlying > > -

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-13 Thread Daniel Stone
Hi Jason, On 9 February 2018 at 23:43, Jason Ekstrand wrote: > - /* For images using modifiers, we require a dedicated allocation > - * and we set the BO tiling to match the tiling of the underlying > - * modifier. This is a bit unfortunate as this is completely > -

[Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-09 Thread Jason Ekstrand
For a bit there, we had a bug in i965 where it ignored the tiling of the modifier and used the one from the BO instead. At one point, we though this was best fixed by setting a tiling from Vulkan. However, we've decided that i965 was just doing the wrong thing and have fixed it as of 50485723523d