[Mesa-dev] [PATCH 6/6] i965/fs: don't copy propagate if the instruction writes to more than two adjacent GRFs

This is not allowed by the HW and copy propagation can hide this issue to lower_simd_width pass, which is going to fix it. Signed-off-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 3/6] i965/fs/gen7: split instructions that run into exec masking bugs

From: Iago Toral Quiroga In fp64 we can produce code like this: mov(16) vgrf2<2>:UD, vgrf3<2>:UD That our simd lowering pass would typically split in instructions with a width of 8, writing to two consecutive registers each. Unfortunately, gen7 hardware has a bug affecting

[Mesa-dev] [Bug 96825] anv_device.c:31:27: fatal error: anv_timestamp.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=96825 --- Comment #5 from Emil Velikov --- > Does the system in question have access to 'date' ? If not I'd strongly > recommend installing a new enough version of the coreutil package. > > If `date' is available, please

Re: [Mesa-dev] [PATCH] anv: Add anv_timestamp.h to VULKAN_GENERATED_SOURCES.

On 5 July 2016 at 22:13, Kenneth Graunke wrote: > Otherwise it doesn't get automatically generated in a clean build. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96825 > Signed-off-by: Kenneth Graunke > --- >

[Mesa-dev] [PATCH 4/6] i965/fs: do not require force_writemask_all with exec_size 4

So far we only used instructions with this size in situations where we did not operate per-channel and we wanted to ignore the execution mask, but gen7 fp64 will need to emit code with a width of 4 that needs normal execution masking. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 1 - 1

[Mesa-dev] [PATCH 2/6] i965/fs: use the new helper function to create double immediates

From: Iago Toral Quiroga --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 268c847..d805d95 100644 ---

[Mesa-dev] [PATCH 5/6] i965/fs: do pack lowering before simd splitting

From: Iago Toral Quiroga So that we can have gen7 split large writes produced by the pack lowering. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 1/6] i965/fs: add a helper function to create double immediates

From: Iago Toral Quiroga Gen7 hardware does not support double immediates so these need to be moved in 32-bit chunks to a regular vgrf instead. Instead of doing this every time we need to create a DF immediate, create a helper function that does the right thing depending on

[Mesa-dev] [PATCH 0/6] i965/fs: fix Haswell support for doubles

Hello, This patch series implements the Haswell specific changes to fix the scalar backend support for doubles in that generation. These changes are related to a couple of HW limitations in gen < 8 that were seen when enabling ARB_gpu_shader_fp64 extension. There are no piglit regressions on HSW

[Mesa-dev] [PATCH mesa] egl/display: remove unnecessary code and make it easier to read

Remove the two first level `if` as they will always be true, and flatten the two remaining `if`. No functional change. Signed-off-by: Eric Engestrom --- src/egl/main/egldisplay.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-)

Re: [Mesa-dev] [PATCH] i965: consolidate generation check

Reviewed-by: Samuel Iglesias Gonsálvez On 06/07/16 05:14, Timothy Arceri wrote: > --- > src/mesa/drivers/dri/i965/brw_vs.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vs.c >

[Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

Signed-off-by: Eric Engestrom --- I know nothing about blorp, but GCC6 noticed the weird indentation, and my best guess looking at the code is that there are missing braces. CC gen7_blorp.lo gen7_blorp.c: In function ‘gen7_blorp_exec’: gen7_blorp.c:797:4:

[Mesa-dev] [PATCH 1/4] vl/compositor: move weave shader out from rgb weaving

We'll use weave shader in the later patch. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_compositor.c | 157 --- src/gallium/auxiliary/vl/vl_compositor.h | 2 +- 2 files changed, 83 insertions(+), 76 deletions(-) diff --git

[Mesa-dev] [PATCH 2/4] vl/compositor: add weave to yuv shader

This shader will make interlaced yuv to progressive yuv. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_compositor.c | 38 src/gallium/auxiliary/vl/vl_compositor.h | 5 + 2 files changed, 43 insertions(+) diff --git

[Mesa-dev] [PATCH 3/4] vl/compositor: set layer of y or uv to render

Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_compositor.c | 30 ++ src/gallium/auxiliary/vl/vl_compositor.h | 12 2 files changed, 42 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_compositor.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

On Wed, Jul 6, 2016 at 11:09 AM, Jiang, Sonny wrote: > Hi Emil, > > > Are you Okay with these? Without these patches UVD won't work on Polaris. Alex > > > Thanks, > > Sonny > > > From: Jiang, Sonny > Sent: Monday, July 4, 2016 5:33:29 PM >

[Mesa-dev] EGL: Implement EGL_KHR_debug

This is a set of patches to implement the EGL_KHR_debug extension. In addition to hopefully being useful in its own right, the current draft of the libglvnd interface for EGL requires each vendor library to support EGL_KHR_debug. The same functions should work for both a normal and libglvnd-based

Re: [Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

On Wed, Jul 06, 2016 at 05:36:54PM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > > I know nothing about blorp, but GCC6 noticed the weird indentation, and my > best > guess looking at the code is that there are missing braces. > > CC

[Mesa-dev] [Bug 96825] anv_device.c:31:27: fatal error: anv_timestamp.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=96825 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] Mesa 12.0.0 release candidate 4

On Thu, Jun 23, 2016 at 6:35 AM, Emil Velikov wrote: > Hi all, > > On 21 June 2016 at 15:35, Emil Velikov wrote: > > The fourth release candidate for Mesa 12.0.0 is now available. > > > > Note: this is the final release candidate, with Mesa

Re: [Mesa-dev] [PATCH] anv: vulkan: remove the anv_device.$(OBJEXT) rule

On Wed, Jul 6, 2016 at 10:46 AM, Emil Velikov wrote: > On 6 July 2016 at 16:39, Jason Ekstrand wrote: > > So here's a thought: could we make anv_timestamp.h generation trigger > off of > > libvulkan_intel.so getting rebuilt? I'm not quite sure

[Mesa-dev] [PATCH 4/4] st/omx/dec: make decoder video buffer progressive

The idea of encode tunneling is to use video buffer directly for encoder, but currently the encoder doesn’t support interlaced surface, the OMX decoder set progressive surface before on that purpose. Since now we are polling the driver for interlacing information for decoder, we got the

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 --- Comment #5 from Ilia Mirkin --- (In reply to Corentin Wallez from comment #4) > I also tried the changes you mentioned in Comment 1, while it fixes the > values queried back from the driver, the triangle is still not

Re: [Mesa-dev] Mesa 12.0.0 release candidate 4

On Thu, Jun 23, 2016 at 9:35 AM, Emil Velikov wrote: > Hi all, > > On 21 June 2016 at 15:35, Emil Velikov wrote: >> The fourth release candidate for Mesa 12.0.0 is now available. >> >> Note: this is the final release candidate, with Mesa 12.0.0

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 --- Comment #7 from Corentin Wallez --- Thank you, I'm still figuring out how to test top of tree Mesa and will confirm if that fixes all the failures. I've fixed the core profile GL_EXTENSIONS bug locally, will push to the

Re: [Mesa-dev] [PATCH mesa] i965/docs: update Intel Linux Graphics URLs

On Wednesday, July 6, 2016 5:09:15 PM PDT Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > docs/developers.html | 2 +- > docs/faq.html| 2 +- > src/mesa/drivers/dri/i965/brw_defines.h | 2 +- >

[Mesa-dev] [PATCH] radeonsi: don't interleave R600_DEBUG-enabled shader dumps

From: Nicolai Hähnle Only setting R600_DEBUG doesn't set any debug callback. Conversely, the debug callback is only called when R600_DEBUG is set. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 0/5] update swr rasterizer

Highlights include llvm-3.9 support, conservative rasterization work, and small cleanups. Tim Rowley (5): swr: [rasterizer] add support for llvm-3.9 swr: [rasterizer core] make all api functions call GetContext swr: [rasterizer] buckets cleanup swr: [rasterizer core] conservative rast

[Mesa-dev] [PATCH 3/5] swr: [rasterizer] buckets cleanup

--- .../swr/rasterizer/common/rdtsc_buckets.cpp| 16 ++- .../drivers/swr/rasterizer/common/rdtsc_buckets.h | 33 -- .../swr/rasterizer/common/rdtsc_buckets_shared.h | 2 ++ .../drivers/swr/rasterizer/core/rdtsc_core.h | 4 +-- 4 files changed, 43

[Mesa-dev] [PATCH 5/5] swr: [rasterizer core] correct MSAA behavior for conservative rasterization

--- .../drivers/swr/rasterizer/core/multisample.h | 4 +++ .../drivers/swr/rasterizer/core/rasterizer.cpp | 35 +++--- .../drivers/swr/rasterizer/core/rasterizer.h | 3 ++ 3 files changed, 31 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] swr: [rasterizer core] conservative rast backend changes

--- src/gallium/drivers/swr/rasterizer/core/api.cpp| 6 +- .../drivers/swr/rasterizer/core/backend.cpp| 22 +- .../drivers/swr/rasterizer/core/conservativeRast.h | 111 - .../drivers/swr/rasterizer/core/frontend.cpp | 28 +-

Re: [Mesa-dev] [PATCH 2/6] i965/fs: use the new helper function to create double immediates

On Wednesday, July 6, 2016 12:09:58 PM PDT Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 --- Comment #6 from Ilia Mirkin --- Oh, actually it should work now with the patch I pushed out last night but failed to mention, since it wasn't addressing the array issue. Double-checked on i965:

Re: [Mesa-dev] [PATCH 1/6] i965/fs: add a helper function to create double immediates

On Wednesday, July 6, 2016 12:09:57 PM PDT Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > Gen7 hardware does not support double immediates so these need > to be moved in 32-bit chunks to a regular vgrf instead. Instead > of doing this every time we need to

[Mesa-dev] [PATCH] swr: [rasterizer jitter] fix llvm-3.7 compile

d3d97f8 broke llvm-3.7, which has a mismatched API for setDataLayout/getDataLayout. --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp

[Mesa-dev] [PATCH 2/5] swr: [rasterizer core] make all api functions call GetContext

Small api cleanup. Make all api functions call GetContext instead of locally casting handle. Makes debugging easier by providing a single point to track context changes. --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 28 - 1 file changed, 14 insertions(+), 14

[Mesa-dev] [PATCH 1/5] swr: [rasterizer] add support for llvm-3.9

--- .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 38 -- .../jitter/scripts/gen_llvm_ir_macros.py | 5 --- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 --- Comment #3 from Ilia Mirkin --- (In reply to Corentin Wallez from comment #2) > Thanks for taking a look, indeed my understanding was wrong but I found a > Khronos bug related to this that doesn't have a formal

Re: [Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

On Fri 01 Jul 2016, Nanley Chery wrote: > On Fri, Jul 01, 2016 at 02:24:19PM -0700, Chad Versace wrote: > > I don't agree with this patch. > > > > Locally, the patch look correct. But when you consider that > > anv_image_create() is public within the driver, the patch makes the code > > fragile.

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 --- Comment #4 from Corentin Wallez --- The bug indicates that "array" and "array[0]" are identical so I'd assume that the binding done last takes precedence. I'm not sure about AofA, or if it's even allowed for fragment

[Mesa-dev] [PATCH 3/3] radeonsi: catch a potential state tracker error with non-MSAA FBs

From: Nicolai Hähnle At least st/mesa ensures this, so I'd rather not handle deviations in radeonsi. --- src/gallium/drivers/radeonsi/si_state.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 2/3] radeonsi: explicitly choose center locations for 1xAA on Polaris

From: Nicolai Hähnle Unlike SC, the small primitive filter does not automatically use center locations in 1xAA mode, so this is needed to avoid artifacts caused by the small primitive filter discarding triangles that it shouldn't. As a side effect of how the effective

[Mesa-dev] [PATCH 1/3] r600g: call cayman_emit_msaa_sample_locs only when needed

From: Nicolai Hähnle In the case of nr_samples <= 1, that function is (currently) a no-op anyway. --- src/gallium/drivers/r600/evergreen_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv: vulkan: remove the anv_device.$(OBJEXT) rule

In the interest of getting the build going again, I pushed this patch with Jason's review. Emil Velikov writes: > From: Emil Velikov > > Atm the actual rule will expand to foo.o which is used for static > libraries only. > > Thus the

Re: [Mesa-dev] [PATCH] anv: vulkan: remove the anv_device.$(OBJEXT) rule

On 6 July 2016 at 16:39, Jason Ekstrand wrote: > So here's a thought: could we make anv_timestamp.h generation trigger off of > libvulkan_intel.so getting rebuilt? I'm not quite sure how one would even > do that but it seems like a thing you might be able to do... > Not

Re: [Mesa-dev] [PATCH] anv: vulkan: remove the anv_device.$(OBJEXT) rule

Fine by me On Jul 6, 2016 8:18 AM, "Emil Velikov" wrote: > From: Emil Velikov > > Atm the actual rule will expand to foo.o which is used for static > libraries only. > > Thus the automake manual recommendation [to use OBJEXT] won't help us,

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

On 6 July 2016 at 16:09, Jiang, Sonny wrote: > Hi Emil, > > > Are you Okay with these? > It'll do for now. General suggestion - do not try to justifying the patch on the grounds that it fixes a bug. Mention what was wrong and/or why it was resolved in a particular way. A

[Mesa-dev] [PATCH 3/6] EGL: Implement remaining functions from EGL_KHR_debug.

Implemented eglDebugMessageControlKHR and eglQueryDebugKHR. Added entries in _egl_global to hold the debug callback and the set of enabled message types. Added a _eglDebugReport function to report a debug message, plus some macros for each of the message types. Still to do is to relace existing

[Mesa-dev] [PATCH 5/6] EGL: Record the debug object label in _EGLThreadInfo.

Added a field to _EGLThreadInfo to hold the object label for the current EGL function call. Changed the _EGL_FUNC_START macro and _eglSetFuncName function to take an object type enum and an _EGLResource pointer, which it uses to fill in the object label. Removed the command name and object label

Re: [Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

On Wed, Jul 06, 2016 at 05:26:40PM +0100, Eric Engestrom wrote: > diff --git a/src/intel/vulkan/Makefile.sources > b/src/intel/vulkan/Makefile.sources > index aa1459a..7303995 100644 > --- a/src/intel/vulkan/Makefile.sources > +++ b/src/intel/vulkan/Makefile.sources > @@ -66,7 +66,8 @@

[Mesa-dev] [PATCH 2/6] EGL: Implement eglLableObjectKHR.

Added a label to the _EGLThreadInfo, _EGLDisplay, and EGLResource structs. Implemented the function eglLabelObjectKHR. --- src/egl/main/eglapi.c | 64 +++ src/egl/main/eglcurrent.c | 10 src/egl/main/eglcurrent.h | 5

[Mesa-dev] [PATCH 6/6] EGL: Fix some command names for EGL_KHR_debug.

Change a few EGL entrypoints to call a common internal function instead of forwarding to another entrypoint. If one EGL entrypoint calls another, then the second entrypoint would overwrite the current function name in the _EGLThreadInfo struct. That would cause it to pass the wrong function name

[Mesa-dev] [PATCH 4/6] EGL: Call the EGL_KHR_debug callback on errors.

Added a member to _EGLThreadInfo to hold the name of the current EGL function. Each EGL entrypoint will now set that at the beginning. _eglError will now call the debug callback function, using the function name stored in the current _EGLThreadInfo struct. This should allow the EGL_KHR_debug

[Mesa-dev] [PATCH 1/6] EGL: Update eglext.h.

Updated eglext.h to revision 32074 from the Khronos repository. Added two #includes to egltypedefs.h. Both were in the previous version of eglext.h but not in the new one. --- include/EGL/eglext.h | 36 ++-- src/egl/main/egltypedefs.h | 2 ++ 2 files

Re: [Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

On Wed, Jul 06, 2016 at 08:40:06PM +0300, Pohjolainen, Topi wrote: > On Wed, Jul 06, 2016 at 05:36:54PM +0100, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > > > I know nothing about blorp, but GCC6 noticed the weird indentation, and my > > best >

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

Hi Emil, Are you Okay with these? Thanks, Sonny From: Jiang, Sonny Sent: Monday, July 4, 2016 5:33:29 PM To: Christian König; Emil Velikov Cc: 12.0; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for

Re: [Mesa-dev] [PATCH 00/12] render reordering for optimized tile buffer usage

On Sat, Jul 2, 2016 at 12:52 PM, Rob Clark wrote: > So, games/apps that are aware of how a tiler gpu works will make an > effort to avoid mid-batch (tile pass) updates to textures, UBOs, etc, > since this will force a flush, and extra resolve (tile->mem) and > restore

Re: [Mesa-dev] [PATCH 27/64] isl/state: Add assertions for buffer surface restrictions

Hi Jason, On Sat, Jun 11, 2016 at 09:02:42AM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index 8f223d1..ca13175 100644 >

[Mesa-dev] [PATCH] anv: vulkan: remove the anv_device.$(OBJEXT) rule

From: Emil Velikov Atm the actual rule will expand to foo.o which is used for static libraries only. Thus the automake manual recommendation [to use OBJEXT] won't help us, since since we're working with a shared library. Thus let's 'demote' the file and add it back

[Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

Signed-off-by: Eric Engestrom --- I know nothing about blorp, but GCC6 noticed the weird indentation, and my best guess looking at the code is that there are missing braces. CC gen7_blorp.lo gen7_blorp.c: In function ‘gen7_blorp_exec’: gen7_blorp.c:797:4:

Re: [Mesa-dev] [PATCH] anv: vulkan: remove the anv_device.$(OBJEXT) rule

So here's a thought: could we make anv_timestamp.h generation trigger off of libvulkan_intel.so getting rebuilt? I'm not quite sure how one would even do that but it seems like a thing you might be able to do... On Jul 6, 2016 8:18 AM, "Emil Velikov" wrote: > From:

[Mesa-dev] [PATCH mesa] i965/docs: update Intel Linux Graphics URLs

Signed-off-by: Eric Engestrom --- docs/developers.html | 2 +- docs/faq.html| 2 +- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- src/mesa/drivers/dri/i965/brw_sf_state.c | 2 +- 4 files changed, 4 insertions(+), 4

[Mesa-dev] [Bug 89599] symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

https://bugs.freedesktop.org/show_bug.cgi?id=89599 austinengl...@gmail.com changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] egl: Fix the bad surface attributes combination checking for pbuffers. (v2)

On Wed 06 Jul 2016, Chad Versace wrote: > On Mon 20 Jun 2016, Guillaume Charifi wrote: > > Fixes a regression induced by commit > > a0674ce5c41903ccd161e89abb149621bfbc40d2: > > When EGL_TEXTURE_FORMAT and EGL_TEXTURE_TARGET were both specified (and > > both != EGL_NO_TEXTURE), an error was

[Mesa-dev] [PATCH mesa] i965/blorp: fix indentation level

Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/gen7_blorp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers/dri/i965/gen7_blorp.c index 7201549..0afd76b 100644 ---

Re: [Mesa-dev] [PATCH 2/2] nir: Optimize away IF statements with no body on either side.

On Wed, Jul 6, 2016 at 5:12 PM, Eric Anholt wrote: > Due to the rampant dead code elimination in coordinate shaders for vc4, we > often end up with IFs that do nothing on either side. In the > loops-enabled build, shader-db gives: > > total instructions in shared programs:

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

Looks good to me Reviewed-by: Jason Ekstrand On Wed, Jul 6, 2016 at 5:12 PM, Eric Anholt wrote: > This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering > producing some constants that were getting compared. > > total instructions in

Re: [Mesa-dev] [PATCH 1/5] swr: [rasterizer] add support for llvm-3.9

Am 06.07.2016 um 23:51 schrieb Tim Rowley: > --- > .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 38 > -- > .../jitter/scripts/gen_llvm_ir_macros.py | 5 --- > 2 files changed, 28 insertions(+), 15 deletions(-) > > diff --git

[Mesa-dev] Resend V4 ARB_enhanced_layouts packing support for i965 Gen6+

This is just a resend that is rebased and has previously reviewed patches pushed to master. V4: - add vec4 backend support and enable for Gen6+ V3: - Rewrite patch 9 (add support for packing arrays) to not add hacks to the type_size() functions. - Add packing support for the load_output

[Mesa-dev] [PATCH 01/17] glsl/nir: add new num_packed_components field

This will be used to store the total number of components used at this location when packing via ARB_enhanced_layouts. --- src/compiler/glsl/glsl_to_nir.cpp | 1 + src/compiler/glsl/ir.h | 5 +++ src/compiler/glsl/link_varyings.cpp | 74 -

[Mesa-dev] [PATCH 08/17] i965/vec4: add support for packing inputs

--- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp index f3b4528..cbe7468 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp +++

[Mesa-dev] [PATCH 09/17] i965/vec4: add support for packing vs/gs/tes outputs

Here we create a new output_generic_reg array with the ability to store the dst_reg for each component of user defined varyings. This is needed as the previous code only stored the dst_reg based on the varying location which meant packed varyings would overwrite each other. ---

[Mesa-dev] [PATCH 07/17] i965: add helpers for creating component layout swizzle

This will be used to swizzle components to the beginning or end of the vector based on the component layout qualifier and whether we are doing a load or store. --- src/mesa/drivers/dri/i965/brw_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_reg.h

[Mesa-dev] [PATCH 04/17] i965: add support for packing arrays

Here we add a new helper function calc_type_size_offset() to help calculate the size of a varying once packing is taken into account. --- src/compiler/nir/nir_lower_io.c | 55 +++-- 1 file changed, 48 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 02/17] i965: enable component packing for vs and fs

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 20 src/mesa/drivers/dri/i965/brw_fs.h | 5 +++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 29 - 3 files changed, 35 insertions(+), 19 deletions(-) diff --git

[Mesa-dev] [PATCH 05/17] i965: add component packing support for load_output intrinsics

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 38 +++- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index a08297e..cac0527 100644 ---

[Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

The GL spec is very unclear on this point. Apparently this is discussed without resolution in the closed Khronos bugtracker at https://cvs.khronos.org/bugzilla/show_bug.cgi?id=7829 . The recommendation is to allow dropping the [0] for looking up the bindings. The approach taken in this patch is

[Mesa-dev] [PATCH] mesa: print number of samples in renderbuffer_storage error msg

--- src/mesa/main/fbobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index bf47c1c..2c01526 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2128,7 +2128,7 @@ renderbuffer_storage(struct

[Mesa-dev] [PATCH 2/2] nir: Optimize away IF statements with no body on either side.

Due to the rampant dead code elimination in coordinate shaders for vc4, we often end up with IFs that do nothing on either side. In the loops-enabled build, shader-db gives: total instructions in shared programs: 125192 -> 119693 (-4.39%) instructions in affected programs: 30649 -> 25150

[Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering producing some constants that were getting compared. total instructions in shared programs: 112276 -> 112198 (-0.07%) instructions in affected programs: 2239 -> 2161 (-3.48%) total estimated cycles in shared programs:

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 --- Comment #8 from Ilia Mirkin --- https://patchwork.freedesktop.org/patch/97464/ This patch should also fix it for the [0] names. I chose to implement it as a fallback thing, so if you have foo and foo[0] set, foo will

Re: [Mesa-dev] [PATCH] egl: Fix the bad surface attributes combination checking for pbuffers. (v2)

On Mon 20 Jun 2016, Guillaume Charifi wrote: > Fixes a regression induced by commit a0674ce5c41903ccd161e89abb149621bfbc40d2: > When EGL_TEXTURE_FORMAT and EGL_TEXTURE_TARGET were both specified (and > both != EGL_NO_TEXTURE), an error was instantly triggered, before the > other one had even a

Re: [Mesa-dev] [PATCH] radeonsi: don't interleave R600_DEBUG-enabled shader dumps

On Wed, Jul 06, 2016 at 11:55:03PM +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Only setting R600_DEBUG doesn't set any debug callback. Conversely, the debug > callback is only called when R600_DEBUG is set. I don't get any output from shader-db with this

[Mesa-dev] [PATCH 16/17] i965: enable ARB_enhanced_layouts for gen6+

--- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 27dfb0c..9989611 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++

[Mesa-dev] [PATCH 03/17] nir: add glsl_dvec_type() helper

--- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 2d46ed2..f694a84 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_types.cpp @@ -263,6 +263,12 @@

[Mesa-dev] [PATCH 06/17] nir/glsl: add double packing support to vs and fs

--- src/compiler/glsl/link_varyings.cpp | 16 +--- src/compiler/nir/nir_lower_io.c | 16 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 35f97a9..31faaa1 100644 ---

[Mesa-dev] [PATCH 17/17] docs: mark ARB_enhanced_layouts as DONE for i965

--- docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index ce34869..0e89a12 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -193,11 +193,11 @@ GL 4.4, GLSL 4.40: GL_MAX_VERTEX_ATTRIB_STRIDE DONE (all

[Mesa-dev] [PATCH 15/17] i965/vec4: add packing support for tes load outputs

--- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 17 + src/mesa/drivers/dri/i965/brw_vec4_tcs.h | 1 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp b/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp index 0a33a39..27b8988

[Mesa-dev] [PATCH 13/17] i965/vec4: add support for packing tcs outputs

--- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp b/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp index 8c76e81..0a33a39 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp +++

[Mesa-dev] [PATCH 10/17] i965: add helper for creating packing writemask

For example where n=3 first_component=1 this will give us 0xE (WRITEMASK_YZW). --- src/mesa/drivers/dri/i965/brw_reg.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_reg.h b/src/mesa/drivers/dri/i965/brw_reg.h index 8e6fcd5..792015b 100644 ---

[Mesa-dev] [PATCH 12/17] i965/vec4: support packing tcs inputs

--- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 8 ++-- src/mesa/drivers/dri/i965/brw_vec4_tcs.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp b/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp index f61c612..8c76e81 100644 ---

[Mesa-dev] [PATCH 11/17] i965/vec4: add component packing for gs

--- src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp index 9ebfb27..4b15302 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_gs_nir.cpp +++

[Mesa-dev] [PATCH 14/17] i965/vec4: add support for packing tes inputs

--- src/mesa/drivers/dri/i965/brw_vec4_tes.cpp | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tes.cpp b/src/mesa/drivers/dri/i965/brw_vec4_tes.cpp index 6639c86..22293da 100644 ---

Re: [Mesa-dev] [PATCH] mesa: print number of samples in renderbuffer_storage error msg

On Wed, 2016-07-06 at 18:02 -0600, Brian Paul wrote: > --- >  src/mesa/main/fbobject.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index bf47c1c..2c01526 100644 > --- a/src/mesa/main/fbobject.c > +++

Re: [Mesa-dev] [PATCH] osmesa: Export OSMesaCreateContextAttribs.

On Wednesday, July 06, 2016 07:53:06 Brian Paul wrote: > On 07/05/2016 09:08 PM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > Hi, > > > > Since the function is exported like any other > > public api fucnntion and put in the header > > as if you

Re: [Mesa-dev] [PATCH mesa] i965/blorp: fix indentation level

On Wed, Jul 06, 2016 at 10:02:42PM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/mesa/drivers/dri/i965/gen7_blorp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for fixing this! Reviewed-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH] anv: Add anv_timestamp.h to VULKAN_GENERATED_SOURCES.

On 6 July 2016 at 14:47, Emil Velikov wrote: > On 6 July 2016 at 12:46, Emil Velikov wrote: >> On 5 July 2016 at 22:13, Kenneth Graunke wrote: >>> Otherwise it doesn't get automatically generated in a clean build. >>>

[Mesa-dev] [Bug 96765] BindFragDataLocationIndexed on array fragment shader output.

https://bugs.freedesktop.org/show_bug.cgi?id=96765 --- Comment #2 from Corentin Wallez --- Thanks for taking a look, indeed my understanding was wrong but I found a Khronos bug related to this that doesn't have a formal resolution but indicates that while you can't bind

Re: [Mesa-dev] [PATCH] anv: Add anv_timestamp.h to VULKAN_GENERATED_SOURCES.

On 6 July 2016 at 12:46, Emil Velikov wrote: > On 5 July 2016 at 22:13, Kenneth Graunke wrote: >> Otherwise it doesn't get automatically generated in a clean build. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96825 >>

Re: [Mesa-dev] [PATCH] vbo: fix attr reset

On 07/05/2016 08:57 PM, Mathias Fröhlich wrote: On Tuesday, July 05, 2016 15:47:45 Rob Clark wrote: > In bc4e0c4 (vbo: Use a bitmask to track the active arrays in vbo_exec*.) > we stopped looping over all the attributes and resetting all slots. > Which exposed an issue in

  1   2   >