Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Marek Olšák
On Fri, Jan 13, 2017 at 5:25 PM, Jason Ekstrand wrote: > On Fri, Jan 13, 2017 at 4:05 AM, Marek Olšák wrote: >> >> On Fri, Jan 13, 2017 at 3:37 AM, Ilia Mirkin wrote: >> > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL (v2)

2017-01-13 Thread Kyle Brenneman
I can if that's preferable. On 01/11/2017 04:24 PM, Timo Aaltonen wrote: On 05.01.2017 23:29, Kyle Brenneman wrote: --- src/egl/generate/eglFunctionList.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/egl/generate/eglFunctionList.py

[Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
From: Emil Velikov At the moment we support 5+ different implementations each with varying amount of bugs - from thread safely problems [1], to outright broken implementation(s) [2] In order to accommodate these we have 150+ lines of configure script and extra two

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #16 from NicolasChauvet --- I went deeper in this issue assuming the real fix is to build glapi shared and link to it anyway. (I'm not sure if there is any users that will find the dlopening glapi only as needed

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Andy Furniss
Nayan Deshmukh wrote: On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss wrote: Would be interesting to see if you see the same with this vid which easily shows the corruption. https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s?usp=sharing Looks bad

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 8:43 AM, Marek Olšák wrote: > On Fri, Jan 13, 2017 at 5:25 PM, Jason Ekstrand > wrote: > > On Fri, Jan 13, 2017 at 4:05 AM, Marek Olšák wrote: > >> > >> On Fri, Jan 13, 2017 at 3:37 AM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Thomas Helland
2017-01-13 18:41 GMT+01:00 Vladislav Egorov : > 13.01.2017 15:31, Tapani Pälli пишет: >> >> >> >> On 01/12/2017 09:23 PM, Thomas Helland wrote: >>> >>> Walking the whole hash table, inserting entries by hashing them first >>> is just a really really bad idea. We can simply

Re: [Mesa-dev] [PATCH] shader-db: Update the README

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 10:04 AM, Elie Tournier wrote: > Use the binary to run shader-db instead of run.py > > Signed-off-by: Elie Tournier > --- > README | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 19:22, Vladislav Egorov wrote: > 13.01.2017 19:51, Emil Velikov пишет: >> >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 11:51 AM, Dylan Baker wrote: > Quoting Emil Velikov (2017-01-13 08:51:31) >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems

[Mesa-dev] [PATCH 3/3] gallivm: Reenable PPC VSX

2017-01-13 Thread Ben Crocker
Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, now that LLVM bug 26775 and its corollary, 25503, are fixed. Signed-off-by: Ben Crocker --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 ++- 1 file changed, 14 insertions(+), 1

Re: [Mesa-dev] [PATCH 3/3] gallivm: Reenable PPC VSX

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 12:39 PM, Ben Crocker wrote: > Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, > now that LLVM bug 26775 and its corollary, 25503, are fixed. > > Signed-off-by: Ben Crocker > --- >

Re: [Mesa-dev] [PATCH 4/8] android: fix llvmpipe build

2017-01-13 Thread Jose Fonseca
On 13/01/17 18:37, Emil Velikov wrote: On 11 January 2017 at 19:19, Jose Fonseca wrote: On 10/01/17 15:54, Emil Velikov wrote: On 6 January 2017 at 17:35, Wu Zhen wrote: From: WuZhen since (cf410574 gallivm: Make MCJIT a

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
2017-01-13 22:43 GMT+03:00 Emil Velikov : > > On 13 January 2017 at 19:22, Vladislav Egorov wrote: > > 13.01.2017 19:51, Emil Velikov пишет: > >> > >> From: Emil Velikov > >> > >> At the moment we support 5+ different

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov wrote: > 13.01.2017 19:51, Emil Velikov пишет: > >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely

Re: [Mesa-dev] [PATCH] mesa/main: fix version/extension checks in _mesa_ClampColor

2017-01-13 Thread Mark Janes
This patch regressed i915 systems: https://bugs.freedesktop.org/show_bug.cgi?id=99401 Please don't apply to stable until the bug is resolved. Nicolai Hähnle writes: > From: Nicolai Hähnle > > Add a proper check for feature support, and raise an

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
I am generally in favor of this for all the reasons you've described. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 1:01 PM, Vladislav Egorov wrote: > 2017-01-13 22:43 GMT+03:00 Emil Velikov : >> >> On 13 January 2017 at 19:22, Vladislav Egorov wrote: >> > 13.01.2017 19:51, Emil Velikov пишет: >> >> >> >> From: Emil

[Mesa-dev] Subset of patches from wip-high-priority that can be useful

2017-01-13 Thread Andres Rodriguez
Following are a subset of patches from my wip-high-priority branch that may be useful outside that context. The HW priority debugging may take a little while, so I wanted to make some of the more generic bits to be available on master as other work could benefit from it.

[Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Andres Rodriguez
Each physical may have different extensions than one another. Furthermore, depending on the software stack, some extensions may not be accessible. If an extension is conditional, it can be registered only when necessary. Signed-off-by: Andres Rodriguez ---

[Mesa-dev] [PATCH 1/3] radv: use a winsys context per-queue, instead of per device

2017-01-13 Thread Andres Rodriguez
Queues are independent execution streams. The vulkan spec provides no ordering guarantees for different queues. By using a single context for all queues, we are forcing all commands into an unecessary FIFO ordering. This change is a preparation step to allow our-of-ordering scheduling of certain

[Mesa-dev] [PATCH 2/3] radv: rename global extension properties structs

2017-01-13 Thread Andres Rodriguez
All extension arrays are global, but only one of them refers to instance extensions. The device extension array refers to extensions that are common across all physical devices. This disctinction will be more imporant once we have dynamic extension support for devices. Signed-off-by: Andres

[Mesa-dev] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8"

2017-01-13 Thread Ben Crocker
If llvm::sys::getHostCPUName() returns "generic", override it with "pwr8" (on PPC64LE). This is a work-around for a bug in LLVM: a table entry for "POWER8NVL" is missing, resulting in (big-endian) "generic" being returned on little-endian Power8NVL systems. The result is that code that attempts

[Mesa-dev] [PATCH 1/3] gallivm: Improve debug output

2017-01-13 Thread Ben Crocker
Improve debug output from gallivm_compile_module and lp_build_create_jit_compiler_for_module, printing the -mcpu and -mattr options passed to LLC. Signed-off-by: Ben Crocker --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 5 -

[Mesa-dev] [PATCH] i965/vec4: Fix mapping attributes

2017-01-13 Thread Jordan Justen
From: "Juan A. Suarez Romero" This patch reverts 57bab6708f2bbc1ab8a3d202e9a467963596d462, which was causing issues with ILK and earlier VS programs. 1. Revert "i965/vec4/nir: vec4 also needs to remap vs attributes" Do not perform a remap in vec4 backend. Rather, do it

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Dylan Baker
Quoting Emil Velikov (2017-01-13 08:51:31) > From: Emil Velikov > > At the moment we support 5+ different implementations each with varying > amount of bugs - from thread safely problems [1], to outright broken > implementation(s) [2] > > In order to accommodate

Re: [Mesa-dev] [PATCH v4 0/7] etnaviv: update derived texture resources of (re)imported buffers

2017-01-13 Thread Christian Gmeiner
Hi all. I am looking for some r-b/s-b for the core bits - anyone? 2016-12-06 17:17 GMT+01:00 Philipp Zabel : > Hi, > > to get weston / wayland_egl working on etnaviv, we need to update the texture > resources derived from imported buffers every time they are re-imported.

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Axel Davy
On 13/01/2017 19:50, Matteo Bruni wrote: 2017-01-13 3:37 GMT+01:00 Ilia Mirkin : On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand wrote: Unless, of course, it's controlled by the same hardware bit... Clearly, we can can give you abs on rsq without

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
13.01.2017 19:51, Emil Velikov пишет: From: Emil Velikov At the moment we support 5+ different implementations each with varying amount of bugs - from thread safely problems [1], to outright broken implementation(s) [2] In order to accommodate these we have 150+

Re: [Mesa-dev] [PATCH] mesa/get: Remove unused extra_ARB_viewport_array

2017-01-13 Thread Emil Velikov
On 9 January 2017 at 14:48, Boyan Ding wrote: > Unused since 0a7691ee (mesa: Enable enums for OES_viewport_array). > Silence a warning of unused variable. > > Signed-off-by: Boyan Ding R-b and pushed to master. Thanks Emil

Re: [Mesa-dev] [PATCH] anv: Default PointSize to 1.0 if not written by the shader

2017-01-13 Thread Kenneth Graunke
On Friday, January 13, 2017 9:41:58 AM PST Jason Ekstrand wrote: > The Vulkan rules for point size are a bit whacky. If you only have a > vertex shader and you use points, then you must write PointSize in your > vertex shader. If you have a geometry or tessellation shader, then it's > dependent

Re: [Mesa-dev] Unify the style of function pointer calls in structs

2017-01-13 Thread Emil Velikov
Hi Boyan, On 25 November 2015 at 05:27, Boyan Ding wrote: > This series is a follow-up of Brian's patch ([1], commit 47fae842). It > converts nearly all of the function-pointer-in-a-struct calls from > (*foo->bar)(...) or (foo->bar)(...) > to > foo->bar(...) > > The

[Mesa-dev] [PATCH 3/7] i965/sync: Add brw_fence::type

2017-01-13 Thread Chad Versace
This a refactor patch; no expected changed in behavior. Add `enum brw_fence_type` and brw_fence::type. There is only one type currently, BRW_FENCE_TYPE_BO_WAIT. This patch reduces a lot of noise in the next, which adds new type BRW_FENCE_TYPE_SYNC_FD. --- src/mesa/drivers/dri/i965/brw_sync.c |

[Mesa-dev] [PATCH 5/7] i965/sync: Rename brw_fence_insert()

2017-01-13 Thread Chad Versace
Rename to brw_fence_insert_locked(). This is correct because the fence's mutex is effectively locked, as all callers are also *creators* of the fence, and have not yet returned the new fence. This reduces noise in the next patch, which defines and uses brw_fence_insert(), an unlocked variant. ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Add missing glproto dependency for gallium-xlib glx

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 17:41, Chuck Atkins wrote: > Just saw this got merged, thanks! Any chance of it getting to stable for > the 13.1 release? > Not sure I parse that - currently we have 12.0 and 13.0 series. With a 17.0 one coming in shortly. It will land for 13.0,

Re: [Mesa-dev] [PATCH 4/8] android: fix llvmpipe build

2017-01-13 Thread Emil Velikov
On 11 January 2017 at 19:19, Jose Fonseca wrote: > On 10/01/17 15:54, Emil Velikov wrote: >> >> On 6 January 2017 at 17:35, Wu Zhen wrote: >>> >>> From: WuZhen >>> >>> since (cf410574 gallivm: Make MCJIT a runtime optioni.),

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss wrote: > > Nayan Deshmukh wrote: >> >> On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: >> >>> Nayan Deshmukh wrote: >>> Hi Andy, Please test this patch for regressions. >>> >>> Do you

[Mesa-dev] [PATCH] anv: Default PointSize to 1.0 if not written by the shader

2017-01-13 Thread Jason Ekstrand
The Vulkan rules for point size are a bit whacky. If you only have a vertex shader and you use points, then you must write PointSize in your vertex shader. If you have a geometry or tessellation shader, then it's dependent on the shaderTessellationAndGeometryPointSize device feature. From the

Re: [Mesa-dev] [PATCH] glx: Add missing glproto dependency for gallium-xlib glx

2017-01-13 Thread Chuck Atkins
Just saw this got merged, thanks! Any chance of it getting to stable for the 13.1 release? -- Chuck Atkins Staff R Engineer, Scientific Computing Kitware, Inc. On Mon, Jan 9, 2017 at 11:10 PM, Cherniak, Bruce wrote: > This comes in very handy on a SLES11 (or

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Vladislav Egorov
13.01.2017 15:31, Tapani Pälli пишет: On 01/12/2017 09:23 PM, Thomas Helland wrote: Walking the whole hash table, inserting entries by hashing them first is just a really really bad idea. We can simply memcpy the whole thing. Maybe it is just 'really' not 'really really' since I don't spot

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Nicolai Hähnle
On 13.01.2017 18:53, Jason Ekstrand wrote: On Fri, Jan 13, 2017 at 8:43 AM, Marek Olšák > wrote: On Fri, Jan 13, 2017 at 5:25 PM, Jason Ekstrand > wrote: > On Fri, Jan 13, 2017 at 4:05 AM,

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Matteo Bruni
2017-01-13 3:37 GMT+01:00 Ilia Mirkin : > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand wrote: >> Unless, of course, it's controlled by the same hardware bit... Clearly, we >> can can give you abs on rsq without denorm flushing (easy shader hacks) but

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 NicolasChauvet changed: What|Removed |Added Attachment #127532|0 |1 is

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #15 from NicolasChauvet --- Created attachment 128936 --> https://bugs.freedesktop.org/attachment.cgi?id=128936=edit mesa: glapi: Clean-up dlopening glapi as we are building shared by default -- You are

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #14 from NicolasChauvet --- Created attachment 128935 --> https://bugs.freedesktop.org/attachment.cgi?id=128935=edit Revert "gbm: dlopen libglapi so gbm_create_device works" -- You are receiving this mail

[Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

2017-01-13 Thread Emil Velikov
From: Emil Velikov The implementation was added with commit d085a5dff5b and effectively provided a hidden dependency. Namely: the codepath used was determined solely during build time. Thus if we built again new wayland and then run against older (yet still within

Re: [Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

2017-01-13 Thread Daniel Stone
Hi Emil, On 13 January 2017 at 17:27, Emil Velikov wrote: > The implementation was added with commit d085a5dff5b and effectively > provided a hidden dependency. > > Namely: the codepath used was determined solely during build time. Thus > if we built again new wayland

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Владислав Егоров
> Quick benchmark of Tom's patches on shader-db. Thomas' patch, sorry. It's hard to simultaneously compose messages, and play in Paw Patrol with 3 yo kid. 2017-01-13 20:41 GMT+03:00 Vladislav Egorov : > 13.01.2017 15:31, Tapani Pälli пишет: > >> >> >> On 01/12/2017 09:23

[Mesa-dev] [PATCH 2/7] i965: Add intel_batchbuffer_flush_fence()

2017-01-13 Thread Chad Versace
A variant of intel_batchbuffer_flush() with parameters for in and out fence fds. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 24 ++-- src/mesa/drivers/dri/i965/intel_batchbuffer.h | 14 -- 2 files changed, 26 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Add missing glproto dependency for gallium-xlib glx

2017-01-13 Thread Chuck Atkins
Hi Emil, > It will land for 13.0, Excellent! Sorry for the confusion. That's what I was looking for. It caused specific pains for deploying on "older" Cray systems, whch are a large part of my userbase. This way I can stop patching the builds and move to an actual release. > but I can

[Mesa-dev] [PATCH 1/7] i965: Add intel_screen::has_fence_fd

2017-01-13 Thread Chad Versace
This bool maps to I915_PARAM_HAS_EXEC_FENCE_FD. TODO: The i915 param is not yet upstream. Wait for the kernel interface before committing. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ src/mesa/drivers/dri/i965/intel_screen.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-13 Thread Chad Versace
This series depends on fence fd support in I915_GEM_EXECBUFFER2, which isn't upstream in libdrm nor the kernel yet. I tested this with kmscube on Skylake, and everything looked good to me. I pushed tags for this series as well as all the code I tested with: mesa:

Re: [Mesa-dev] [PATCH v4 1/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 15:05, Jonas Ådahl wrote: > When failing to initializing the Wayland EGL driver, don't leak the > display server connection if it was us who created it. > > Signed-off-by: Jonas Ådahl > Cc: mesa-sta...@lists.freedesktop.org Added the r-b

[Mesa-dev] [PATCH] shader-db: Update the README

2017-01-13 Thread Elie Tournier
Use the binary to run shader-db instead of run.py Signed-off-by: Elie Tournier --- README | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/README b/README index 5e9bb2d..6f6a7e2 100644 --- a/README +++ b/README @@ -1,6 +1,6 @@ ===

[Mesa-dev] [PATCH 6/7] WAIT: configure: Bump libdrm requirement to 2.4.XX

2017-01-13 Thread Chad Versace
Required to implement EGL_ANDROID_native_fence_sync on i965. Specifically, i965 needs drm_intel_gem_bo_exec_fence(), I915_PARAM_HAS_EXEC_FENCE, and libsync.h. TODO: Pick real libdrm version after Intel exec fences land. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 7/7] i965/sync: Implement fences based on Linux sync_file

2017-01-13 Thread Chad Versace
This patch implements a new type of struct brw_fence, one that is based struct sync_file. This completes support for EGL_ANDROID_native_fence_sync. * Background Linux 4.7 added a new file type, struct sync_file. See commit 460bfc41fd52959311ed0328163f785e023857af Author: Gustavo

[Mesa-dev] [PATCH 4/7] i965/sync: Fail sync creation when batchbuffer flush fails

2017-01-13 Thread Chad Versace
Pre-patch, brw_sync.c ignored the return value of intel_batchbuffer_flush(). When intel_batchbuffer_flush() fails during eglCreateSync (brw_dri_create_fence), we now give up, cleanup, and return NULL. When it fails during glFenceSync, however, we blindly continue and hope for the best because

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #51 from Jani Kärkkäinen --- Sent a support ticket to Psyonix about this (and the request for a debug build). Hopefully a random persons support ticket gets to the dev team and they deem it something that's

[Mesa-dev] [PATCH] anv: remove some unused macros and functions

2017-01-13 Thread Grazvydas Ignotas
VK_ICD_WSI_PLATFORM_MAX is used, but a duplicate from wsi_common.h . Signed-off-by: Grazvydas Ignotas --- no commit access requested by Emil: https://lists.freedesktop.org/archives/mesa-dev/2017-January/140733.html src/intel/vulkan/anv_private.h | 15 ---

Re: [Mesa-dev] [PATCH] anv: remove some unused macros and functions

2017-01-13 Thread Jason Ekstrand
Acked-by: Jason Ekstrand I'll push it. On Fri, Jan 13, 2017 at 3:10 PM, Grazvydas Ignotas wrote: > VK_ICD_WSI_PLATFORM_MAX is used, but a duplicate from wsi_common.h . > > Signed-off-by: Grazvydas Ignotas > --- > no commit access >

[Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-13 Thread Emil Velikov
Earlier commit made the decision whether to use MCJIT a run-time one. At the same time, it changed the code-flow in the following manner: - LLVMLinkInMCJIT() was executed regardless of whether MCJIT is to be used or not. Admittedly it is a no-op at least in some builds. - LLVMLinkInJIT() was

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
14.01.2017 01:45, Timothy Arceri пишет: I'm asking for a chance to test before we jump in, its probably not a big deal and I may even still be able to reduce my use of hashing but it would be nice to be given a few days to test and even explore alternatives before jumping on this implementation.

Re: [Mesa-dev] [PATCH 15/22] i965/vec4: fix SIMD-width lowering for double_to_single operation in IVB/VLV

2017-01-13 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > From: "Juan A. Suarez Romero" > > When spliting double_to_single() in Ivybridge/Valleyview, the second > part should use a temporal register, and then move the values to the > second

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Timothy Arceri
On Fri, 2017-01-13 at 13:59 -0800, Jason Ekstrand wrote: > On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov com> wrote: > > 13.01.2017 19:51, Emil Velikov пишет: > > > From: Emil Velikov > > > > > > At the moment we support 5+ different

Re: [Mesa-dev] [PATCH 09/22] i965/fs: add lowering x2d step for IVB/VLV

2017-01-13 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > From: "Juan A. Suarez Romero" > > On Ivybridge/Valleyview, when converting a float (F) to a double > precision float (DF), the hardware automatically duplicates the source > horizontal

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 2:18 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Fri, 2017-01-13 at 13:59 -0800, Jason Ekstrand wrote: > > On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov > com> wrote: > > > 13.01.2017 19:51, Emil Velikov пишет: > > > > From:

Re: [Mesa-dev] [PATCH 14/22] i965/vec4: fix double_to_single() for IVB/VLV

2017-01-13 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > From: "Juan A. Suarez Romero" > > In the generator we must generate slightly different code for > Ivybridge/Valleview, because of the way the stride works in > this hardware. > --- >

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Timothy Arceri
On Fri, 2017-01-13 at 14:32 -0800, Jason Ekstrand wrote: > On Fri, Jan 13, 2017 at 2:18 PM, Timothy Arceri bora.com> wrote: > > On Fri, 2017-01-13 at 13:59 -0800, Jason Ekstrand wrote: > > > On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov > ail. > > >

Re: [Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Bas Nieuwenhuizen
On Sat, Jan 14, 2017 at 12:20 AM, Andres Rodriguez wrote: > > > On 2017-01-13 06:04 PM, Bas Nieuwenhuizen wrote: >> >> On Fri, Jan 13, 2017 at 11:06 PM, Andres Rodriguez >> wrote: >>> >>> Each physical may have different extensions than one another. >>>

Re: [Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Bas Nieuwenhuizen
On Sat, Jan 14, 2017 at 12:34 AM, Andres Rodriguez wrote: > > > On 2017-01-13 06:30 PM, Bas Nieuwenhuizen wrote: >> >> On Sat, Jan 14, 2017 at 12:20 AM, Andres Rodriguez >> wrote: >>> >>> >>> On 2017-01-13 06:04 PM, Bas Nieuwenhuizen wrote: On

Re: [Mesa-dev] [PATCH 17/22] i965/vec4: fix register_coalesce() for partial writes

2017-01-13 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > From: "Juan A. Suarez Romero" > > When lowering double_to_single() we added a final mov() that puts 32-bit I can't confirm that this patch is necessary in the current

Re: [Mesa-dev] [PATCH] i965: Move Gen4-5 interpolation stuff to brw_wm_prog_data.

2017-01-13 Thread Timothy Arceri
On Fri, 2017-01-13 at 16:07 -0800, Kenneth Graunke wrote: > This fixes glxgears rendering, which had surprisingly been broken > since > late October!  Specifically, commit > 91d61fbf7cb61a44adcaae51ee08ad0dd6b. > > glxgears uses glShadeModel(GL_FLAT) when drawing the main portion of > the >

Re: [Mesa-dev] [PATCH 2/3] radv: rename global extension properties structs

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 23:44, Andres Rodriguez wrote: > All extension arrays are global, but only one of them refers to instance > extensions. > > The device extension array refers to extensions that are common across > all physical devices. This disctinction will be more

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
14.01.2017 00:17, Matt Turner пишет: On Fri, Jan 13, 2017 at 1:01 PM, Vladislav Egorov wrote: 2017-01-13 22:43 GMT+03:00 Emil Velikov : On 13 January 2017 at 19:22, Vladislav Egorov wrote: 13.01.2017 19:51, Emil Velikov

Re: [Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Andres Rodriguez
On 2017-01-13 06:04 PM, Bas Nieuwenhuizen wrote: On Fri, Jan 13, 2017 at 11:06 PM, Andres Rodriguez wrote: Each physical may have different extensions than one another. Furthermore, depending on the software stack, some extensions may not be accessible. If an extension

[Mesa-dev] [PATCH] i965: Move Gen4-5 interpolation stuff to brw_wm_prog_data.

2017-01-13 Thread Kenneth Graunke
This fixes glxgears rendering, which had surprisingly been broken since late October! Specifically, commit 91d61fbf7cb61a44adcaae51ee08ad0dd6b. glxgears uses glShadeModel(GL_FLAT) when drawing the main portion of the gears, then uses glShadeModel(GL_SMOOTH) for drawing the Gouraud-shaded inner

[Mesa-dev] [Bug 92877] Add support for libglvnd

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 Darek changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] nvc0: allow TK1 (NVEA) queries to work

2017-01-13 Thread Ilia Mirkin
The NVEA 3D class is numerically larger than the NVF0 3D class. The TK1 chip uses the SM35 ISA and likely has the same hw counters. Allow these to be used like on all the other supported chips. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c

[Mesa-dev] [PATCH 2/3] radv: rename global extension properties structs

2017-01-13 Thread Andres Rodriguez
All extension arrays are global, but only one of them refers to instance extensions. The device extension array refers to extensions that are common across all physical devices. This disctinction will be more imporant once we have dynamic extension support for devices. Signed-off-by: Andres

[Mesa-dev] Subset of patches from wip-high-priority that can be useful v2

2017-01-13 Thread Andres Rodriguez
Following are a subset of patches from my wip-high-priority branch that may be useful outside that context. The HW priority debugging may take a little while, so I wanted to make some of the more generic bits to be available on master as other work could benefit from it. v2: Fixed a rebasing

[Mesa-dev] [PATCH 1/3] radv: use a winsys context per-queue, instead of per device v2

2017-01-13 Thread Andres Rodriguez
Queues are independent execution streams. The vulkan spec provides no ordering guarantees for different queues. By using a single context for all queues, we are forcing all commands into an unecessary FIFO ordering. This change is a preparation step to allow our-of-ordering scheduling of certain

[Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Andres Rodriguez
Each physical device may have different extensions than one another. Furthermore, depending on the software stack, some extensions may not be accessible. If an extension is conditional, it can be registered only when necessary. v2: removed unused function and fixed indentation Signed-off-by:

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
Thanks for the comments gents. This is the type of discussion I was aiming at. On 13 January 2017 at 22:45, Timothy Arceri wrote: > On Fri, 2017-01-13 at 14:32 -0800, Jason Ekstrand wrote: >> On Fri, Jan 13, 2017 at 2:18 PM, Timothy Arceri >

Re: [Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Andres Rodriguez
On 2017-01-13 06:30 PM, Bas Nieuwenhuizen wrote: On Sat, Jan 14, 2017 at 12:20 AM, Andres Rodriguez wrote: On 2017-01-13 06:04 PM, Bas Nieuwenhuizen wrote: On Fri, Jan 13, 2017 at 11:06 PM, Andres Rodriguez wrote: Each physical may have different

Re: [Mesa-dev] [PATCH] i965/vec4: Fix mapping attributes

2017-01-13 Thread Kenneth Graunke
On Friday, January 13, 2017 1:41:34 PM PST Jordan Justen wrote: > From: "Juan A. Suarez Romero" > > This patch reverts 57bab6708f2bbc1ab8a3d202e9a467963596d462, which was > causing issues with ILK and earlier VS programs. > > 1. Revert "i965/vec4/nir: vec4 also needs to

[Mesa-dev] [PATCH 1/2] i965: Combine some dead code elimination NOP'ing code.

2017-01-13 Thread Kenneth Graunke
In theory we might have incorrectly NOP'd instructions that write the flag, but where that flag value isn't used, and yet the instruction either writes the accumulator or has side effects. I don't believe any such instructions exist, so this is mostly a code cleanup. Signed-off-by: Kenneth

[Mesa-dev] [PATCH 2/2] i965: Make DCE set null destinations on messages with side effects.

2017-01-13 Thread Kenneth Graunke
(Co-authored by Matt Turner.) Image atomics, for example, return a value - but the shader may not want to use it. We assigned a useless VGRF destination. This seemed harmless, but it can actually be quite harmful. The register allocator has to assign that VGRF to a real register. It may

Re: [Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Bas Nieuwenhuizen
On Fri, Jan 13, 2017 at 11:06 PM, Andres Rodriguez wrote: > Each physical may have different extensions than one another. > Furthermore, depending on the software stack, some extensions may not be > accessible. > > If an extension is conditional, it can be registered only when

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Connor Abbott
On Fri, Jan 13, 2017 at 1:55 PM, Thomas Helland wrote: > 2017-01-13 18:41 GMT+01:00 Vladislav Egorov : >> 13.01.2017 15:31, Tapani Pälli пишет: >>> >>> >>> >>> On 01/12/2017 09:23 PM, Thomas Helland wrote: Walking the whole hash table,

Re: [Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

2017-01-13 Thread Lionel Landwerlin
On 13/01/17 15:22, Emil Velikov wrote: On 13 January 2017 at 15:02, Lionel Landwerlin wrote: On 13/01/17 14:31, Emil Velikov wrote: On 13 January 2017 at 12:00, Lionel Landwerlin wrote: v2: rework entry point iteration (Jason)

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Andy Furniss
Nayan Deshmukh wrote: On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, Please test this patch for regressions. Do you have a testcase to show the fix? TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2 h/w dec never

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 4:05 AM, Marek Olšák wrote: > On Fri, Jan 13, 2017 at 3:37 AM, Ilia Mirkin wrote: > > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand > wrote: > >> Unless, of course, it's controlled by the same hardware

Re: [Mesa-dev] [PATCH] anv: increase ANV_MAX_STATE_SIZE_LOG2 limit to 256 kB

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 1:33 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > Fixes crash in dEQP-VK.ubo.random.all_shared_buffer.48 due to a > fragment shader code bigger than 128 kB. > > This patch increases the allocation size limit to 256 kB. > That limit will have to be

Re: [Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

2017-01-13 Thread Derek Foreman
On 13/01/17 11:27 AM, Emil Velikov wrote: From: Emil Velikov The implementation was added with commit d085a5dff5b and effectively provided a hidden dependency. Namely: the codepath used was determined solely during build time. Thus if we built again new wayland and

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Jonathan Gray
On Fri, Jan 13, 2017 at 04:51:31PM +, Emil Velikov wrote: > From: Emil Velikov > > At the moment we support 5+ different implementations each with varying > amount of bugs - from thread safely problems [1], to outright broken > implementation(s) [2] > > In order

Re: [Mesa-dev] [PATCH] nir/i965: assert first is always less than 64

2017-01-13 Thread Kenneth Graunke
On Thursday, January 12, 2017 12:24:41 PM PST Juan A. Suarez Romero wrote: > This fixes a defect detected by Coverity Scan. > --- > src/mesa/drivers/dri/i965/brw_draw_upload.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c >

Re: [Mesa-dev] [PATCH] i965: Enable OpenGL 4.5 on Haswell.

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 10:53 PM, Kenneth Graunke wrote: > Everything is in place and the test results look solid. > > Signed-off-by: Kenneth Graunke Wow, that's been a long time coming. Great work all around. I feel like we've reached the top of

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Christian König
Am 13.01.2017 um 14:15 schrieb Nayan Deshmukh: If begin_frame is called before setting intra_matrix and non_intra_matrix it leads to segmentation faults when vl_mpeg12_decoder.c is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Nayan Deshmukh

Re: [Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Daniel Stone
Hi, On 13 January 2017 at 14:09, Emil Velikov wrote: > Please use conditional as the one during setup. Namely: > disp->PlatformDisplay == NULL > dri2_initialize_wayland_swrast needs a similar hunk, as well as > platform_drm.c. Can you address those as with later patches

Re: [Mesa-dev] [PATCH 1/2] gallium: Moving X11 dependencies under HAVE_PLATFORM_X11

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 13:19, Christian König wrote: > Am 29.11.2016 um 13:22 schrieb Emil Velikov: >> >> On 28 November 2016 at 14:51, Christian König >> wrote: >> >>> --- a/src/gallium/state_trackers/va/context.c >>> +++

  1   2   >