[Mesa-dev] [PATCH] radv: Support loader interface version 3.

2017-01-13 Thread Bas Nieuwenhuizen
Port of 1e41d7f7b0855934744fe578ba4eae9209ee69f7: "anv: Support loader interface version 3 (patch v2)" Signed-off-by: Bas Nieuwenhuizen Cc: mesa-sta...@lists.freedesktop.org --- src/amd/vulkan/radv_device.c | 45 1 file changed, 45 insertions(+) diff

Re: [Mesa-dev] [PATCH 08/22] i965/fs: fix lower SIMD width for IVB/VLV's MOVE_INDIRECT

2017-01-13 Thread Samuel Iglesias Gonsálvez
On Thu, 2017-01-12 at 16:45 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: "Juan A. Suarez Romero" > > > > Previous to Broadwell, we have 8 registers for MOV_INDIRECT. But if > > IVB/VLV deal with DFs, we will duplicate the exec_size from 8 to > > 16. > > > > Thi

[Mesa-dev] [PATCH v3 1/2] egl/wayland: Avoid race conditions when on non-main thread

2017-01-13 Thread Jonas Ådahl
When EGL is used on some other thread than the thread that drives the main wl_display queue, the Wayland EGL dri2 implementation is vulnerable to a race condition related to display round trips and global object advertisements. The race that may happen is that after after a proxy is created, but b

[Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Jonas Ådahl
When failing to initializing the Wayland EGL driver, don't leak the display server connection if it was us who created it. Signed-off-by: Jonas Ådahl --- Changes since v2 (where it was part of PATCH 1/2): * Fixed use-after-free src/egl/drivers/dri2/platform_wayland.c | 2 ++ 1 file changed,

[Mesa-dev] [PATCH] anv: increase ANV_MAX_STATE_SIZE_LOG2 limit to 256 kB

2017-01-13 Thread Samuel Iglesias Gonsálvez
Fixes crash in dEQP-VK.ubo.random.all_shared_buffer.48 due to a fragment shader code bigger than 128 kB. This patch increases the allocation size limit to 256 kB. Signed-off-by: Samuel Iglesias Gonsálvez --- OpenGL driver compares the code size against the allocated cache buffer object size and

Re: [Mesa-dev] [PATCH 2/2] main/fbobject: throw invalid operation when get_attachment fails if needed

2017-01-13 Thread Nicolai Hähnle
On 12.01.2017 23:22, Alejandro Piñeiro wrote: In most cases, if a call to get_attachment fails is because attachment is a INVALID_ENUM. But for some specific cases, if COLOR_ATTACHMENTm (where m >= MAX_COLOR_ATTACHMENTS) is used, it should raise an INVALID_OPERATION exception instead. Fixes: GL4

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 Darek changed: What|Removed |Added CC||dz1125.bug.trac...@gmail.co |

[Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

2017-01-13 Thread Lionel Landwerlin
v2: rework entry point iteration (Jason) cleanup unused imports Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/Makefile.am| 15 ++-- src/intel/vulkan/anv_entrypoints_gen.py | 126 2 files changed, 71 insertions(+), 70 deletions(-) diff --

[Mesa-dev] [PATCH v2 4/4] radv: generate entrypoints from vk.xml

2017-01-13 Thread Lionel Landwerlin
v2: rework entry point iteration (Jason) cleanup unused imports Signed-off-by: Lionel Landwerlin Cc: Bas Nieuwenhuizen Cc: Dave Airlie --- src/amd/vulkan/Makefile.am | 14 ++--- src/amd/vulkan/radv_entrypoints_gen.py | 106 - 2 files changed, 56

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Marek Olšák
On Fri, Jan 13, 2017 at 3:37 AM, Ilia Mirkin wrote: > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand wrote: >> Unless, of course, it's controlled by the same hardware bit... Clearly, we >> can can give you abs on rsq without denorm flushing (easy shader hacks) but >> not the other way around. >

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Tapani Pälli
On 01/12/2017 09:23 PM, Thomas Helland wrote: Walking the whole hash table, inserting entries by hashing them first is just a really really bad idea. We can simply memcpy the whole thing. Maybe it is just 'really' not 'really really' since I don't spot any difference in time running the tort

[Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
If begin_frame is called before setting intra_matrix and non_intra_matrix it leads to segmentation faults when vl_mpeg12_decoder.c is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/picture.c | 6 +++--- 1 file ch

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
Hi Andy, Please test this patch for regressions. Cheers, Nayan On Fri, Jan 13, 2017 at 6:45 PM, Nayan Deshmukh wrote: > If begin_frame is called before setting intra_matrix and > non_intra_matrix it leads to segmentation faults when > vl_mpeg12_decoder.c is used. > > Bugzilla: https://bugs.fre

Re: [Mesa-dev] [PATCH 1/2] gallium: Moving X11 dependencies under HAVE_PLATFORM_X11

2017-01-13 Thread Christian König
Am 29.11.2016 um 13:22 schrieb Emil Velikov: On 28 November 2016 at 14:51, Christian König wrote: --- a/src/gallium/state_trackers/va/context.c +++ b/src/gallium/state_trackers/va/context.c @@ -118,6 +118,7 @@ VA_DRIVER_INIT_FUNC(VADriverContextP ctx) return VA_STATUS_ERROR_UNIMPLEMENT

Re: [Mesa-dev] [PATCH 2/2] st/va: flush pipeline after post processing

2017-01-13 Thread Christian König
Am 29.11.2016 um 17:05 schrieb Nicolai Hähnle: On 29.11.2016 15:36, Christian König wrote: Am 29.11.2016 um 15:28 schrieb Nicolai Hähnle: On 29.11.2016 15:12, Christian König wrote: Am 29.11.2016 um 15:06 schrieb Nicolai Hähnle: On 29.11.2016 14:50, Christian König wrote: Am 29.11.2016 um 14

[Mesa-dev] [PATCH] anv: move nir_lower_wpos_center to later

2017-01-13 Thread Samuel Iglesias Gonsálvez
We can have a crash produced because the tests is using the same shader module for all stages (setting a different entry point per stage). So when we fix world position center on the fragment's built-in input position in fragment shader ("gl_Fragcoord" in GLSL), we might be using one from previous

Re: [Mesa-dev] [PATCH] travis: Add the new drivers etnaviv and imx

2017-01-13 Thread Rhys Kidd
On 13 January 2017 at 02:05, Christian Gmeiner wrote: > 2017-01-13 5:06 GMT+01:00 Rhys Kidd : > > Signed-off-by: Rhys Kidd > > --- > > .travis.yml | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 3d107aa..dfbc052 100644 > >

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Christian König
Am 13.01.2017 um 14:15 schrieb Nayan Deshmukh: If begin_frame is called before setting intra_matrix and non_intra_matrix it leads to segmentation faults when vl_mpeg12_decoder.c is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Nayan Deshmukh At one point I

Re: [Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 09:05, Jonas Ådahl wrote: > When failing to initializing the Wayland EGL driver, don't leak the > display server connection if it was us who created it. > > Signed-off-by: Jonas Ådahl > --- > > Changes since v2 (where it was part of PATCH 1/2): > > * Fixed use-after-free >

Re: [Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Daniel Stone
Hi, On 13 January 2017 at 14:09, Emil Velikov wrote: > Please use conditional as the one during setup. Namely: > disp->PlatformDisplay == NULL > dri2_initialize_wayland_swrast needs a similar hunk, as well as > platform_drm.c. Can you address those as with later patches ? > > To make it cleaner t

[Mesa-dev] [PATCH] mesa/main: Fix FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for NONE attachment type

2017-01-13 Thread Alejandro Piñeiro
When the attachment type is NONE (att->Type), FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE should be NONE too. Note that technically, the current behaviour follows the spec. From OpenGL 4.5 spec, Section 9.2.3 "Framebuffer Object Queries": "If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE, the

Re: [Mesa-dev] [PATCH 1/2] gallium: Moving X11 dependencies under HAVE_PLATFORM_X11

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 13:19, Christian König wrote: > Am 29.11.2016 um 13:22 schrieb Emil Velikov: >> >> On 28 November 2016 at 14:51, Christian König >> wrote: >> >>> --- a/src/gallium/state_trackers/va/context.c >>> +++ b/src/gallium/state_trackers/va/context.c >>> @@ -118,6 +118,7 @@ VA_DRIVER

Re: [Mesa-dev] [PATCH] gallium: add Tegra renderonly support

2017-01-13 Thread Grazvydas Ignotas
Hi, just out of the interest, can this be used on Tegra X1 right now? If so, what would I need to get it to work (kernel, firmware, something else)? I'd be interested to run mesa on the Shield TV. Gražvydas On Fri, Jan 13, 2017 at 9:47 AM, Alexandre Courbot wrote: > From: Christian Gmeiner > >

Re: [Mesa-dev] [PATCH v3 1/2] egl/wayland: Avoid race conditions when on non-main thread

2017-01-13 Thread Daniel Stone
Hi Jonas, On 13 January 2017 at 09:05, Jonas Ådahl wrote: > @@ -1876,9 +1878,7 @@ dri2_initialize_wayland_swrast(_EGLDriver *drv, > _EGLDisplay *disp) > if (dri2_dpy->own_device) >wl_display_dispatch_pending(dri2_dpy->wl_dpy); > > - dri2_dpy->wl_registry = wl_display_get_registry(d

Re: [Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 12:00, Lionel Landwerlin wrote: > v2: rework entry point iteration (Jason) > cleanup unused imports > > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/Makefile.am| 15 ++-- > src/intel/vulkan/anv_entrypoints_gen.py | 126 > --

Re: [Mesa-dev] [PATCH] gallium: add Tegra renderonly support

2017-01-13 Thread Ilia Mirkin
Note, I'm only commenting on the nouveau bits: On Fri, Jan 13, 2017 at 2:47 AM, Alexandre Courbot wrote: > diff --git a/src/gallium/drivers/nouveau/nouveau_buffer.c > b/src/gallium/drivers/nouveau/nouveau_buffer.c > index 17052b26e9c8..95dcaad94396 100644 > --- a/src/gallium/drivers/nouveau/nouv

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Andy Furniss
Nayan Deshmukh wrote: Hi Andy, Please test this patch for regressions. Do you have a testcase to show the fix? TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2 h/w dec never worked properly anyway. https://bugs.freedesktop.org/show_bug.cgi?id=93760 With mpv --hwdec=vaapi it do

Re: [Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

2017-01-13 Thread Lionel Landwerlin
On 13/01/17 14:31, Emil Velikov wrote: On 13 January 2017 at 12:00, Lionel Landwerlin wrote: v2: rework entry point iteration (Jason) cleanup unused imports Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/Makefile.am| 15 ++-- src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v4 2/2] egl/wayland: Avoid race conditions when on non-main thread

2017-01-13 Thread Jonas Ådahl
When EGL is used on some other thread than the thread that drives the main wl_display queue, the Wayland EGL dri2 implementation is vulnerable to a race condition related to display round trips and global object advertisements. The race that may happen is that after after a proxy is created, but b

[Mesa-dev] [PATCH v4 1/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Jonas Ådahl
When failing to initializing the Wayland EGL driver, don't leak the display server connection if it was us who created it. Signed-off-by: Jonas Ådahl Cc: mesa-sta...@lists.freedesktop.org --- Changes since v3: * Also disconnect in the swrast initializer error path. * Changed condition to be t

Re: [Mesa-dev] [PATCH] anv: move nir_lower_wpos_center to later

2017-01-13 Thread Lionel Landwerlin
Hi Samuel, Maybe you missed Ken's patch? : https://patchwork.freedesktop.org/series/17864/ Thanks, - Lionel On 13/01/17 13:48, Samuel Iglesias Gonsálvez wrote: We can have a crash produced because the tests is using the same shader module for all stages (setting a different entry point per s

Re: [Mesa-dev] [PATCH v2] radv: remove some unused macros and functions

2017-01-13 Thread Emil Velikov
On 11 January 2017 at 01:31, Grazvydas Ignotas wrote: > These seem unlikely to be used. > Also remove irrelevant comment about SKL. > > v2: forgot to rebase on master > > Signed-off-by: Grazvydas Ignotas > --- > no commit access > > src/amd/vulkan/radv_private.h | 15 +-- > src/amd/v

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 --- Comment #11 from Pekka Paalanen --- Hi, sorry, just back from holidays. The patch looks fine so would be nice to have that on wayland-devel@ mailing list if you didn't send it already. I think it'd be an ok addition to simple-egl. Does it ma

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Support loader interface version 3.

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 08:02, Bas Nieuwenhuizen wrote: > Port of 1e41d7f7b0855934744fe578ba4eae9209ee69f7: > "anv: Support loader interface version 3 (patch v2)" > > Signed-off-by: Bas Nieuwenhuizen > Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Emil Velikov Thanks ! Emil _

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Andy, >> >> Please test this patch for regressions. >> > > Do you have a testcase to show the fix? > > TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2 > h/w dec never worked properly anyway. > > ht

Re: [Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 15:02, Lionel Landwerlin wrote: > On 13/01/17 14:31, Emil Velikov wrote: >> >> On 13 January 2017 at 12:00, Lionel Landwerlin >> wrote: >>> >>> v2: rework entry point iteration (Jason) >>> cleanup unused imports >>> >>> Signed-off-by: Lionel Landwerlin >>> --- >>> sr

Re: [Mesa-dev] [PATCH] anv: move nir_lower_wpos_center to later

2017-01-13 Thread Samuel Iglesias Gonsálvez
El 2017-01-13 16:05, Lionel Landwerlin escribió: > Hi Samuel, > > Maybe you missed Ken's patch? : > > https://patchwork.freedesktop.org/series/17864/ > Oh yes, I didn't see it :-( Thanks Lionel! Sam P.S: Please discard this patch. > Thanks, > > - > Lionel > > On 13/01/17 13:48, Samuel Igl

Re: [Mesa-dev] [PATCH] gallium: add Tegra renderonly support

2017-01-13 Thread Emil Velikov
Hi Alexandre, On 13 January 2017 at 07:47, Alexandre Courbot wrote: > @@ -2559,6 +2559,10 @@ if test -n "$with_gallium_drivers"; then > require_libdrm "virgl" > require_basic_egl "virgl" > ;; > +xtegra) > +HAVE_GALLIUM_TEGRA=yes > +

Re: [Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

2017-01-13 Thread Jason Ekstrand
On Jan 13, 2017 7:22 AM, "Emil Velikov" wrote: On 13 January 2017 at 15:02, Lionel Landwerlin wrote: > On 13/01/17 14:31, Emil Velikov wrote: >> >> On 13 January 2017 at 12:00, Lionel Landwerlin >> wrote: >>> >>> v2: rework entry point iteration (Jason) >>> cleanup unused imports >>> >>> S

Re: [Mesa-dev] [PATCH] travis: Add the new drivers etnaviv and imx

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 13:50, Rhys Kidd wrote: > On 13 January 2017 at 02:05, Christian Gmeiner > wrote: >> >> 2017-01-13 5:06 GMT+01:00 Rhys Kidd : >> > Signed-off-by: Rhys Kidd >> > --- >> > .travis.yml | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/.tr

Re: [Mesa-dev] [PATCH v2 3/4] anv: generate entry points from vk.xml

2017-01-13 Thread Lionel Landwerlin
On 13/01/17 15:22, Emil Velikov wrote: On 13 January 2017 at 15:02, Lionel Landwerlin wrote: On 13/01/17 14:31, Emil Velikov wrote: On 13 January 2017 at 12:00, Lionel Landwerlin wrote: v2: rework entry point iteration (Jason) cleanup unused imports Signed-off-by: Lionel Landwerlin -

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Andy Furniss
Nayan Deshmukh wrote: On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, Please test this patch for regressions. Do you have a testcase to show the fix? TBH I've not tested gstreamer with mpeg2 before as vaapi mpeg2 h/w dec never worked properly anyway.

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 4:05 AM, Marek Olšák wrote: > On Fri, Jan 13, 2017 at 3:37 AM, Ilia Mirkin wrote: > > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand > wrote: > >> Unless, of course, it's controlled by the same hardware bit... Clearly, > we > >> can can give you abs on rsq without denor

Re: [Mesa-dev] [PATCH] anv: increase ANV_MAX_STATE_SIZE_LOG2 limit to 256 kB

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 1:33 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > Fixes crash in dEQP-VK.ubo.random.all_shared_buffer.48 due to a > fragment shader code bigger than 128 kB. > > This patch increases the allocation size limit to 256 kB. > That limit will have to be changed

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Marek Olšák
On Fri, Jan 13, 2017 at 5:25 PM, Jason Ekstrand wrote: > On Fri, Jan 13, 2017 at 4:05 AM, Marek Olšák wrote: >> >> On Fri, Jan 13, 2017 at 3:37 AM, Ilia Mirkin wrote: >> > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand >> > wrote: >> >> Unless, of course, it's controlled by the same hardware b

Re: [Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL (v2)

2017-01-13 Thread Kyle Brenneman
I can if that's preferable. On 01/11/2017 04:24 PM, Timo Aaltonen wrote: On 05.01.2017 23:29, Kyle Brenneman wrote: --- src/egl/generate/eglFunctionList.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/egl/generate/eglFunctionList.py b/src/egl/generate/eglFun

[Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
From: Emil Velikov At the moment we support 5+ different implementations each with varying amount of bugs - from thread safely problems [1], to outright broken implementation(s) [2] In order to accommodate these we have 150+ lines of configure script and extra two configure toggles. Whist an act

Re: [Mesa-dev] Unify the style of function pointer calls in structs

2017-01-13 Thread Emil Velikov
Hi Boyan, On 25 November 2015 at 05:27, Boyan Ding wrote: > This series is a follow-up of Brian's patch ([1], commit 47fae842). It > converts nearly all of the function-pointer-in-a-struct calls from > (*foo->bar)(...) or (foo->bar)(...) > to > foo->bar(...) > > The sed regex to do the conver

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 NicolasChauvet changed: What|Removed |Added Attachment #127532|0 |1 is obsolete|

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #15 from NicolasChauvet --- Created attachment 128936 --> https://bugs.freedesktop.org/attachment.cgi?id=128936&action=edit mesa: glapi: Clean-up dlopening glapi as we are building shared by default -- You are receiving this mail

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #14 from NicolasChauvet --- Created attachment 128935 --> https://bugs.freedesktop.org/attachment.cgi?id=128935&action=edit Revert "gbm: dlopen libglapi so gbm_create_device works" -- You are receiving this mail because: You are t

Re: [Mesa-dev] [PATCH v4 1/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 15:05, Jonas Ådahl wrote: > When failing to initializing the Wayland EGL driver, don't leak the > display server connection if it was us who created it. > > Signed-off-by: Jonas Ådahl > Cc: mesa-sta...@lists.freedesktop.org Added the r-b tags and pushed to master. Thanks Jo

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

2017-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #16 from NicolasChauvet --- I went deeper in this issue assuming the real fix is to build glapi shared and link to it anyway. (I'm not sure if there is any users that will find the dlopening glapi only as needed useful over not buildi

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss wrote: > > Nayan Deshmukh wrote: >> >> On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: >> >>> Nayan Deshmukh wrote: >>> Hi Andy, Please test this patch for regressions. >>> >>> Do you have a testcase to show the fix? >>> >>> T

[Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

2017-01-13 Thread Emil Velikov
From: Emil Velikov The implementation was added with commit d085a5dff5b and effectively provided a hidden dependency. Namely: the codepath used was determined solely during build time. Thus if we built again new wayland and then run against older (yet still within the requirements, as per the co

Re: [Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

2017-01-13 Thread Daniel Stone
Hi Emil, On 13 January 2017 at 17:27, Emil Velikov wrote: > The implementation was added with commit d085a5dff5b and effectively > provided a hidden dependency. > > Namely: the codepath used was determined solely during build time. Thus > if we built again new wayland and then run against older (

Re: [Mesa-dev] [PATCH] mesa/get: Remove unused extra_ARB_viewport_array

2017-01-13 Thread Emil Velikov
On 9 January 2017 at 14:48, Boyan Ding wrote: > Unused since 0a7691ee (mesa: Enable enums for OES_viewport_array). > Silence a warning of unused variable. > > Signed-off-by: Boyan Ding R-b and pushed to master. Thanks Emil ___ mesa-dev mailing list mes

Re: [Mesa-dev] [PATCH] glx: Add missing glproto dependency for gallium-xlib glx

2017-01-13 Thread Chuck Atkins
Just saw this got merged, thanks! Any chance of it getting to stable for the 13.1 release? -- Chuck Atkins Staff R&D Engineer, Scientific Computing Kitware, Inc. On Mon, Jan 9, 2017 at 11:10 PM, Cherniak, Bruce wrote: > This comes in very handy on a SLES11 (or similar) based install. >

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Vladislav Egorov
13.01.2017 15:31, Tapani Pälli пишет: On 01/12/2017 09:23 PM, Thomas Helland wrote: Walking the whole hash table, inserting entries by hashing them first is just a really really bad idea. We can simply memcpy the whole thing. Maybe it is just 'really' not 'really really' since I don't spot a

[Mesa-dev] [PATCH] anv: Default PointSize to 1.0 if not written by the shader

2017-01-13 Thread Jason Ekstrand
The Vulkan rules for point size are a bit whacky. If you only have a vertex shader and you use points, then you must write PointSize in your vertex shader. If you have a geometry or tessellation shader, then it's dependent on the shaderTessellationAndGeometryPointSize device feature. From the Vul

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Andy Furniss
Nayan Deshmukh wrote: On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss wrote: Would be interesting to see if you see the same with this vid which easily shows the corruption. https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s?usp=sharing Looks bad --hwdec-vaapi with or without

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 8:43 AM, Marek Olšák wrote: > On Fri, Jan 13, 2017 at 5:25 PM, Jason Ekstrand > wrote: > > On Fri, Jan 13, 2017 at 4:05 AM, Marek Olšák wrote: > >> > >> On Fri, Jan 13, 2017 at 3:37 AM, Ilia Mirkin > wrote: > >> > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand > > >>

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Владислав Егоров
> Quick benchmark of Tom's patches on shader-db. Thomas' patch, sorry. It's hard to simultaneously compose messages, and play in Paw Patrol with 3 yo kid. 2017-01-13 20:41 GMT+03:00 Vladislav Egorov : > 13.01.2017 15:31, Tapani Pälli пишет: > >> >> >> On 01/12/2017 09:23 PM, Thomas Helland wrote

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Add missing glproto dependency for gallium-xlib glx

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 17:41, Chuck Atkins wrote: > Just saw this got merged, thanks! Any chance of it getting to stable for > the 13.1 release? > Not sure I parse that - currently we have 12.0 and 13.0 series. With a 17.0 one coming in shortly. It will land for 13.0, but I can check if it's appli

Re: [Mesa-dev] [PATCH] anv: Default PointSize to 1.0 if not written by the shader

2017-01-13 Thread Kenneth Graunke
On Friday, January 13, 2017 9:41:58 AM PST Jason Ekstrand wrote: > The Vulkan rules for point size are a bit whacky. If you only have a > vertex shader and you use points, then you must write PointSize in your > vertex shader. If you have a geometry or tessellation shader, then it's > dependent o

[Mesa-dev] [PATCH] shader-db: Update the README

2017-01-13 Thread Elie Tournier
Use the binary to run shader-db instead of run.py Signed-off-by: Elie Tournier --- README | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/README b/README index 5e9bb2d..6f6a7e2 100644 --- a/README +++ b/README @@ -1,6 +1,6 @@ === What === -A giant pile

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Nicolai Hähnle
On 13.01.2017 18:53, Jason Ekstrand wrote: On Fri, Jan 13, 2017 at 8:43 AM, Marek Olšák mailto:mar...@gmail.com>> wrote: On Fri, Jan 13, 2017 at 5:25 PM, Jason Ekstrand mailto:ja...@jlekstrand.net>> wrote: > On Fri, Jan 13, 2017 at 4:05 AM, Marek Olšák mailto:mar...@gmail.com>> wrote

Re: [Mesa-dev] [PATCH 4/8] android: fix llvmpipe build

2017-01-13 Thread Emil Velikov
On 11 January 2017 at 19:19, Jose Fonseca wrote: > On 10/01/17 15:54, Emil Velikov wrote: >> >> On 6 January 2017 at 17:35, Wu Zhen wrote: >>> >>> From: WuZhen >>> >>> since (cf410574 gallivm: Make MCJIT a runtime optioni.), llvmpipe assume >>> MCJIT is available on x86(_64). this is not the cas

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Matteo Bruni
2017-01-13 3:37 GMT+01:00 Ilia Mirkin : > On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand wrote: >> Unless, of course, it's controlled by the same hardware bit... Clearly, we >> can can give you abs on rsq without denorm flushing (easy shader hacks) but >> not the other way around. > > OK, so some

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Add missing glproto dependency for gallium-xlib glx

2017-01-13 Thread Chuck Atkins
Hi Emil, > It will land for 13.0, Excellent! Sorry for the confusion. That's what I was looking for. It caused specific pains for deploying on "older" Cray systems, whch are a large part of my userbase. This way I can stop patching the builds and move to an actual release. > but I can ch

[Mesa-dev] [PATCH 1/7] i965: Add intel_screen::has_fence_fd

2017-01-13 Thread Chad Versace
This bool maps to I915_PARAM_HAS_EXEC_FENCE_FD. TODO: The i915 param is not yet upstream. Wait for the kernel interface before committing. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ src/mesa/drivers/dri/i965/intel_screen.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-13 Thread Chad Versace
This series depends on fence fd support in I915_GEM_EXECBUFFER2, which isn't upstream in libdrm nor the kernel yet. I tested this with kmscube on Skylake, and everything looked good to me. I pushed tags for this series as well as all the code I tested with: mesa: http://git.kiwitree.net/cgi

[Mesa-dev] [PATCH 2/7] i965: Add intel_batchbuffer_flush_fence()

2017-01-13 Thread Chad Versace
A variant of intel_batchbuffer_flush() with parameters for in and out fence fds. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 24 ++-- src/mesa/drivers/dri/i965/intel_batchbuffer.h | 14 -- 2 files changed, 26 insertions(+), 12 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 7/7] i965/sync: Implement fences based on Linux sync_file

2017-01-13 Thread Chad Versace
This patch implements a new type of struct brw_fence, one that is based struct sync_file. This completes support for EGL_ANDROID_native_fence_sync. * Background Linux 4.7 added a new file type, struct sync_file. See commit 460bfc41fd52959311ed0328163f785e023857af Author: Gustavo Pado

[Mesa-dev] [PATCH 4/7] i965/sync: Fail sync creation when batchbuffer flush fails

2017-01-13 Thread Chad Versace
Pre-patch, brw_sync.c ignored the return value of intel_batchbuffer_flush(). When intel_batchbuffer_flush() fails during eglCreateSync (brw_dri_create_fence), we now give up, cleanup, and return NULL. When it fails during glFenceSync, however, we blindly continue and hope for the best because the

[Mesa-dev] [PATCH 6/7] WAIT: configure: Bump libdrm requirement to 2.4.XX

2017-01-13 Thread Chad Versace
Required to implement EGL_ANDROID_native_fence_sync on i965. Specifically, i965 needs drm_intel_gem_bo_exec_fence(), I915_PARAM_HAS_EXEC_FENCE, and libsync.h. TODO: Pick real libdrm version after Intel exec fences land. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 3/7] i965/sync: Add brw_fence::type

2017-01-13 Thread Chad Versace
This a refactor patch; no expected changed in behavior. Add `enum brw_fence_type` and brw_fence::type. There is only one type currently, BRW_FENCE_TYPE_BO_WAIT. This patch reduces a lot of noise in the next, which adds new type BRW_FENCE_TYPE_SYNC_FD. --- src/mesa/drivers/dri/i965/brw_sync.c | 10

[Mesa-dev] [PATCH 5/7] i965/sync: Rename brw_fence_insert()

2017-01-13 Thread Chad Versace
Rename to brw_fence_insert_locked(). This is correct because the fence's mutex is effectively locked, as all callers are also *creators* of the fence, and have not yet returned the new fence. This reduces noise in the next patch, which defines and uses brw_fence_insert(), an unlocked variant. ---

Re: [Mesa-dev] [PATCH 4/4] glsl: Use hash table cloning in copy propagation

2017-01-13 Thread Thomas Helland
2017-01-13 18:41 GMT+01:00 Vladislav Egorov : > 13.01.2017 15:31, Tapani Pälli пишет: >> >> >> >> On 01/12/2017 09:23 PM, Thomas Helland wrote: >>> >>> Walking the whole hash table, inserting entries by hashing them first >>> is just a really really bad idea. We can simply memcpy the whole thing. >

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
13.01.2017 19:51, Emil Velikov пишет: From: Emil Velikov At the moment we support 5+ different implementations each with varying amount of bugs - from thread safely problems [1], to outright broken implementation(s) [2] In order to accommodate these we have 150+ lines of configure script and e

Re: [Mesa-dev] [PATCH] shader-db: Update the README

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 10:04 AM, Elie Tournier wrote: > Use the binary to run shader-db instead of run.py > > Signed-off-by: Elie Tournier > --- > README | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/README b/README > index 5e9bb2d..6f6a7e2 100644

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 19:22, Vladislav Egorov wrote: > 13.01.2017 19:51, Emil Velikov пишет: >> >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems [1], to outright broken >> implementation(s) [2] >> >

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Dylan Baker
Quoting Emil Velikov (2017-01-13 08:51:31) > From: Emil Velikov > > At the moment we support 5+ different implementations each with varying > amount of bugs - from thread safely problems [1], to outright broken > implementation(s) [2] > > In order to accommodate these we have 150+ lines of confi

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 11:51 AM, Dylan Baker wrote: > Quoting Emil Velikov (2017-01-13 08:51:31) >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems [1], to outright broken >> implementation(s) [2] >>

Re: [Mesa-dev] [PATCH] mesa/main: fix version/extension checks in _mesa_ClampColor

2017-01-13 Thread Mark Janes
This patch regressed i915 systems: https://bugs.freedesktop.org/show_bug.cgi?id=99401 Please don't apply to stable until the bug is resolved. Nicolai Hähnle writes: > From: Nicolai Hähnle > > Add a proper check for feature support, and raise an invalid enum for > GL_CLAMP_VERTEX/FRAGMENT_COLO

[Mesa-dev] [PATCH 1/3] gallivm: Improve debug output

2017-01-13 Thread Ben Crocker
Improve debug output from gallivm_compile_module and lp_build_create_jit_compiler_for_module, printing the -mcpu and -mattr options passed to LLC. Signed-off-by: Ben Crocker --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 5 - src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 9 +

[Mesa-dev] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8"

2017-01-13 Thread Ben Crocker
If llvm::sys::getHostCPUName() returns "generic", override it with "pwr8" (on PPC64LE). This is a work-around for a bug in LLVM: a table entry for "POWER8NVL" is missing, resulting in (big-endian) "generic" being returned on little-endian Power8NVL systems. The result is that code that attempts t

[Mesa-dev] [PATCH 3/3] gallivm: Reenable PPC VSX

2017-01-13 Thread Ben Crocker
Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, now that LLVM bug 26775 and its corollary, 25503, are fixed. Signed-off-by: Ben Crocker --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH v4 0/7] etnaviv: update derived texture resources of (re)imported buffers

2017-01-13 Thread Christian Gmeiner
Hi all. I am looking for some r-b/s-b for the core bits - anyone? 2016-12-06 17:17 GMT+01:00 Philipp Zabel : > Hi, > > to get weston / wayland_egl working on etnaviv, we need to update the texture > resources derived from imported buffers every time they are re-imported. > > This patchset is base

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Vladislav Egorov
2017-01-13 22:43 GMT+03:00 Emil Velikov : > > On 13 January 2017 at 19:22, Vladislav Egorov wrote: > > 13.01.2017 19:51, Emil Velikov пишет: > >> > >> From: Emil Velikov > >> > >> At the moment we support 5+ different implementations each with varying > >> amount of bugs - from thread safely prob

Re: [Mesa-dev] [PATCH 3/3] gallivm: Reenable PPC VSX

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 12:39 PM, Ben Crocker wrote: > Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, > now that LLVM bug 26775 and its corollary, 25503, are fixed. > > Signed-off-by: Ben Crocker > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 ++-

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
I am generally in favor of this for all the reasons you've described. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Matt Turner
On Fri, Jan 13, 2017 at 1:01 PM, Vladislav Egorov wrote: > 2017-01-13 22:43 GMT+03:00 Emil Velikov : >> >> On 13 January 2017 at 19:22, Vladislav Egorov wrote: >> > 13.01.2017 19:51, Emil Velikov пишет: >> >> >> >> From: Emil Velikov >> >> >> >> At the moment we support 5+ different implementati

Re: [Mesa-dev] [PATCH 4/8] android: fix llvmpipe build

2017-01-13 Thread Jose Fonseca
On 13/01/17 18:37, Emil Velikov wrote: On 11 January 2017 at 19:19, Jose Fonseca wrote: On 10/01/17 15:54, Emil Velikov wrote: On 6 January 2017 at 17:35, Wu Zhen wrote: From: WuZhen since (cf410574 gallivm: Make MCJIT a runtime optioni.), llvmpipe assume MCJIT is available on x86(_64).

[Mesa-dev] [PATCH] i965/vec4: Fix mapping attributes

2017-01-13 Thread Jordan Justen
From: "Juan A. Suarez Romero" This patch reverts 57bab6708f2bbc1ab8a3d202e9a467963596d462, which was causing issues with ILK and earlier VS programs. 1. Revert "i965/vec4/nir: vec4 also needs to remap vs attributes" Do not perform a remap in vec4 backend. Rather, do it later when setup at

Re: [Mesa-dev] [PATCH] util: import sha1 implementation from OpenBSD

2017-01-13 Thread Jason Ekstrand
On Fri, Jan 13, 2017 at 11:22 AM, Vladislav Egorov wrote: > 13.01.2017 19:51, Emil Velikov пишет: > >> From: Emil Velikov >> >> At the moment we support 5+ different implementations each with varying >> amount of bugs - from thread safely problems [1], to outright broken >> implementation(s) [2]

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Axel Davy
On 13/01/2017 19:50, Matteo Bruni wrote: 2017-01-13 3:37 GMT+01:00 Ilia Mirkin : On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand wrote: Unless, of course, it's controlled by the same hardware bit... Clearly, we can can give you abs on rsq without denorm flushing (easy shader hacks) but not the

[Mesa-dev] [PATCH 2/3] radv: rename global extension properties structs

2017-01-13 Thread Andres Rodriguez
All extension arrays are global, but only one of them refers to instance extensions. The device extension array refers to extensions that are common across all physical devices. This disctinction will be more imporant once we have dynamic extension support for devices. Signed-off-by: Andres Rodri

[Mesa-dev] [PATCH 1/3] radv: use a winsys context per-queue, instead of per device

2017-01-13 Thread Andres Rodriguez
Queues are independent execution streams. The vulkan spec provides no ordering guarantees for different queues. By using a single context for all queues, we are forcing all commands into an unecessary FIFO ordering. This change is a preparation step to allow our-of-ordering scheduling of certain

[Mesa-dev] [PATCH 3/3] radv: make device extension setup dynamic

2017-01-13 Thread Andres Rodriguez
Each physical may have different extensions than one another. Furthermore, depending on the software stack, some extensions may not be accessible. If an extension is conditional, it can be registered only when necessary. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 196 ++

  1   2   >