[Mesa-dev] [PATCH] android: add libmesa_util include path to MESA_DRI_C_INCLUDES

2017-08-01 Thread Tapani Pälli
It is required by libmesa_dri_common and i965_dri modules which both already use MESA_DRI_C_INCLUDES. Fixes following build errors: In file included from vendor/intel/external/android_ia/mesa/src/mesa/drivers/dri/common/dri_util.c:45:

Re: [Mesa-dev] [PATCH 1/6] radeonsi: fix various CLEAR_STATE issues

2017-08-01 Thread Samuel Pitoiset
On 08/01/2017 12:43 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [Mesa-dev RESEND 15/26] mesa: add clear_buffer_sub_data_error() helper

2017-08-01 Thread Samuel Pitoiset
And make clear_buffer_sub_data() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 52 +++ 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/bufferobj.c

[Mesa-dev] [Mesa-dev RESEND 13/26] mesa: add KHR_no_error support to glLinkProgram()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 18 ++ src/mesa/main/shaderapi.h | 3 +++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [Mesa-dev RESEND 19/26] mesa: add clear_bufferi() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/clear.c | 50 ++ 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index 853d445b7e..4c3400412c 100644 ---

[Mesa-dev] [Mesa-dev RESEND 21/26] mesa: add clear_bufferuiv() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/clear.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index 62a00c0401..5ee1eb2433 100644 ---

[Mesa-dev] [Mesa-dev RESEND 16/26] mesa: add KHR_no_error support to glClear*Buffer*Data()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_clear_buffer_object.xml | 4 +- src/mapi/glapi/gen/ARB_direct_state_access.xml | 4 +- src/mesa/main/bufferobj.c | 73 ++ src/mesa/main/bufferobj.h

[Mesa-dev] [Mesa-dev RESEND 14/26] mesa: make get_texbuffer_format() global

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/teximage.c | 6 +++--- src/mesa/main/teximage.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 7523b9fc98..04d0d6f911 100644 ---

[Mesa-dev] [Mesa-dev RESEND 12/26] mesa: add link_program() and link_program_error() helpers

2017-08-01 Thread Samuel Pitoiset
And call link_program_error() from _mesa_link_program(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 46 +- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] [Mesa-dev RESEND 06/26] mesa: add KHR_no_error support to glBeginConditionalRender()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/condrender.c | 8 src/mesa/main/condrender.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [Mesa-dev RESEND 03/26] mesa: add buffer_data() and buffer_data_error() helpers

2017-08-01 Thread Samuel Pitoiset
And call buffer_data_error() from _mesa_buffer_data(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 112 ++ 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/src/mesa/main/bufferobj.c

[Mesa-dev] [Mesa-dev RESEND 07/26] mesa: add end_conditional_render() render

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/condrender.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 24a7f4b694..051cd8f962 100644 ---

[Mesa-dev] [Mesa-dev RESEND 08/26] mesa: add KHR_no_error support to glEndConditionalRender()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/condrender.c | 8 src/mesa/main/condrender.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [Mesa-dev RESEND 18/26] mesa: add KHR_no_error support to glClearBufferfv()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/clear.c | 9 + src/mesa/main/clear.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [Mesa-dev RESEND 11/26] mesa: add KHR_no_error support to glShaderSource()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 9 + src/mesa/main/shaderapi.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [Mesa-dev RESEND 10/26] mesa: add shader_source() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index ae5647b4c0..941419b6f1 100644 ---

[Mesa-dev] [Mesa-dev RESEND 09/26] mesa: rename shader_source() to set_shader_source()

2017-08-01 Thread Samuel Pitoiset
There is already get_shader_source(), and shader_source() will be used for adding KHR_no_error support. Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 2/3] mesa: add always-false enable for GL 4.6

2017-08-01 Thread Samuel Pitoiset
I believe this should be enough for now. Signed-off-by: Samuel Pitoiset --- src/mesa/main/version.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 34f8bbbcb1..f04c43ddf5

[Mesa-dev] [PATCH 3/3] mesa: add GLSL 4.60 to shading_language_version()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/getstring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 5da405d9fa..4c805ca4d5 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstring.c

[Mesa-dev] [PATCH 1/3] glsl: recognize GLSL 4.60

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/glsl_parser_extras.cpp | 4 ++-- src/compiler/glsl/glsl_parser_extras.h | 2 +- src/compiler/glsl/standalone.cpp | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [Bug 101981] Commit ddc32537d6db69198e88ef0dfe19770bf9daa536 breaks rendering in multiple applications

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101981 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Mesa-dev RESEND 22/26] mesa: add KHR_no_error support to glClearBufferuiv()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/clear.c | 9 + src/mesa/main/clear.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [Mesa-dev RESEND 25/26] mesa: add polygon_mode() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/polygon.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/polygon.c b/src/mesa/main/polygon.c index a924b84980..98a9118fd2 100644 ---

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #25 from John --- Since I have seen Dave posting many SI-related fixes/workaround on the ML, I've just tried again (on latest amd-staging as well, in case there was something there too). radv wise I am

[Mesa-dev] [Mesa-dev RESEND 23/26] mesa: add clear_bufferiv() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/clear.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index 3aa3cfd9a9..ea75a95184 100644 ---

[Mesa-dev] [Mesa-dev RESEND 24/26] mesa: add KHR_no_error support to glClearBufferiv()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/clear.c | 8 src/mesa/main/clear.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [Mesa-dev RESEND 17/26] mesa: add clear_bufferfv() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/clear.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index 3adbe38185..439e7dcfc5 100644 ---

[Mesa-dev] [Mesa-dev RESEND 26/26] mesa: add KHR_no_error support to glPolygonMode()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/polygon.c | 8 src/mesa/main/polygon.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [Mesa-dev RESEND 20/26] mesa: add KHR_no_error support to glClearBufferfi()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/clear.c | 9 + src/mesa/main/clear.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 John changed: What|Removed |Added Summary|Any vulkan app seems to |AMD SI cards: Some

[Mesa-dev] [PATCH] ac/nir: Add float cast before shadow comparator clamp.

2017-08-01 Thread Bas Nieuwenhuizen
LLVM complained about passing an i32 to a float clamp. Signed-off-by: Bas Nieuwenhuizen Fixes: 0f9e32519bb "ac/nir: clamp shadow texture comparison value on VI" --- src/amd/common/ac_nir_to_llvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [RFC mesa 1/3] egl: deduplicate swap interval clamping logic

2017-08-01 Thread Eric Engestrom
On Monday, 2017-07-31 17:07:56 +, Daniel Stone wrote: > Hi Eric, > > On 31 July 2017 at 18:04, Eric Engestrom wrote: > > @@ -956,16 +956,9 @@ dri2_x11_swap_interval(_EGLDriver *drv, _EGLDisplay > > *disp, _EGLSurface *surf, > > struct dri2_egl_display

Re: [Mesa-dev] [PATCH] Revert "st_glsl_to_tgsi: rewrite rename registers to use array fully."

2017-08-01 Thread Gert Wollny
> The original code has a loop over num_renames, so if two renames > were in the list in order like > > 8 renames to 4 and 4 renames to 2, then 8 would rename to 2. > however if 4 renamed to 2 then 8 renamed to 4 (not sure if this could > happen), it was different. > > My initial patch fails

Re: [Mesa-dev] [PATCH 00/14] AMD GCN tile swizzle

2017-08-01 Thread Bas Nieuwenhuizen
On Tue, Aug 1, 2017 at 3:50 AM, Dave Airlie wrote: > On 1 August 2017 at 09:40, Marek Olšák wrote: >> Hi, >> >> This might slightly increase MRT performance. You need the amdgpu >> kernel driver if you want it for SI and CI. >> >> I've fixed a few of issues

Re: [Mesa-dev] [PATCH] i965: Avoids loop for buffer object availability in add_exec_bo

2017-08-01 Thread Chris Wilson
Quoting Marathe, Yogesh (2017-08-01 09:21:51) > > > -Original Message- > > > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > > > Sent: Friday, July 28, 2017 2:30 PM > > > To: Muthukumar, Aravindan ; mesa- > > > d...@lists.freedesktop.org > > > Cc:

Re: [Mesa-dev] [PATCH] mesa: fix bad cast conversions in viewport()

2017-08-01 Thread Samuel Pitoiset
On 08/01/2017 02:03 AM, Matt Turner wrote: On Mon, Jul 31, 2017 at 12:43 PM, Samuel Pitoiset wrote: Fixes: ddc32537d6 ("mesa: clamp viewport values only once when using glViewport()") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101981 Bugzilla:

Re: [Mesa-dev] [PATCH 3/3] ac/nir: fix nir_op_unpack_64_2x32_split_y emission

2017-08-01 Thread Nicolai Hähnle
On 01.08.2017 03:41, Connor Abbott wrote: From: Connor Abbott This was broken thanks to a typo in b2367cf. Cc: Nicolai Hähnle Sorry about that! Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 2

Re: [Mesa-dev] [PATCH v2] gallium: add PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE and corresponding cap

2017-08-01 Thread Nicolai Hähnle
On 01.08.2017 00:39, Roland Scheidegger wrote: Am 31.07.2017 um 18:36 schrieb Nicolai Hähnle: From: Nicolai Hähnle v2: rename cap to PIPE_CAP_QUERY_SO_OVERFLOW and be a bit more explicit in the documentation --- I decided to keep the query names as they were, to

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-01 Thread Timothy Arceri
On 01/08/17 18:07, Samuel Pitoiset wrote: Don't you think it's just safer to revert the bad commit for 17.2 and fix it later on? I'm not overly worried. If you really want to go that way we can, but I don't think it's necessary. On 08/01/2017 09:35 AM, Timothy Arceri wrote: When

[Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-01 Thread Timothy Arceri
When generation the storage offset for struct members we need to skip opaque types as they no longer have backing storage. Fixes: fcbb93e86024 ("mesa: stop assigning unused storage for non-bindless opaque types") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101983 ---

[Mesa-dev] [PATCH 1/2] mesa: fix i915 CTS regression caused by fcbb93e86024

2017-08-01 Thread Timothy Arceri
When generation the storage offset for struct members we need to skip opaque types as they no longer have backing storage. Fixes: fcbb93e86024 ("mesa: stop assigning unused storage for non-bindless opaque types") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101983 ---

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-01 Thread Samuel Pitoiset
Don't you think it's just safer to revert the bad commit for 17.2 and fix it later on? On 08/01/2017 09:35 AM, Timothy Arceri wrote: When generation the storage offset for struct members we need to skip opaque types as they no longer have backing storage. Fixes: fcbb93e86024 ("mesa: stop

Re: [Mesa-dev] [PATCH] i965: Avoids loop for buffer object availability in add_exec_bo

2017-08-01 Thread Marathe, Yogesh
> > -Original Message- > > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > > Sent: Friday, July 28, 2017 2:30 PM > > To: Muthukumar, Aravindan ; mesa- > > d...@lists.freedesktop.org > > Cc: Marathe, Yogesh ; Muthukumar,

[Mesa-dev] [Mesa-dev RESEND 05/26] mesa: add begin_conditional_render() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/condrender.c | 121 - 1 file changed, 66 insertions(+), 55 deletions(-) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 2ea2c8821d..95d6d6ad5f

[Mesa-dev] [Mesa-dev RESEND 02/26] mesa: add KHR_no_error support to glLineWidth()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/lines.c | 8 src/mesa/main/lines.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [Mesa-dev RESEND 04/26] mesa: add KHR_no_error support to glNamedBufferData() and glBufferData()

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/bufferobj.c | 30 ++ src/mesa/main/bufferobj.h

[Mesa-dev] [Mesa-dev RESEND 01/26] mesa: add line_width() helper

2017-08-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/lines.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/lines.c b/src/mesa/main/lines.c index 4df658794d..04b3e2ff12 100644 --- a/src/mesa/main/lines.c +++

Re: [Mesa-dev] [PATCH] android: add libmesa_util include path to MESA_DRI_C_INCLUDES

2017-08-01 Thread Chih-Wei Huang
2017-08-01 15:51 GMT+08:00 Tapani Pälli : > It is required by libmesa_dri_common and i965_dri modules which both > already use MESA_DRI_C_INCLUDES. Fixes following build errors: > > In file included from >

[Mesa-dev] [PATCH 2/2] mesa/st: add support for hw atomics

2017-08-01 Thread Dave Airlie
From: Dave Airlie This adds support for hw atomics to the state tracker, it just sets the limits using the new CAPs, and sets the maximums etc for it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 50

[Mesa-dev] [Bug 102010] libvulkan_radeon crashes if loaded on Intel hardware

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102010 Bug ID: 102010 Summary: libvulkan_radeon crashes if loaded on Intel hardware Product: Mesa Version: 17.1 Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r302589

2017-08-01 Thread Michel Dänzer
On 02/08/17 01:57 PM, Keith Packard wrote: > Michel Dänzer writes: > >> +#if HAVE_LLVM >= 0x0500 >> + virtual void deregisterEHFrames() { >> + mgr()->deregisterEHFrames(); >> + } >> +#elif HAVE_LLVM >= 0x0304 >> + virtual void deregisterEHFrames(uint8_t

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r302589

2017-08-01 Thread Keith Packard
Michel Dänzer writes: > +#if HAVE_LLVM >= 0x0500 > + virtual void deregisterEHFrames() { > + mgr()->deregisterEHFrames(); > + } > +#elif HAVE_LLVM >= 0x0304 > + virtual void deregisterEHFrames(uint8_t *Addr, uint64_t LoadAddr, > size_t Size) { > +

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #26 from Marko --- Hi, For the life of me can't find the commit I was using yesterday since I did a fresh checkout and deleted the source before testing, but it was something like early 2017-08-01

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #27 from John --- That does not seem much better in your case :/ Maybe I'll try a few emulators such as Dolphin and RPCS3 to see what happens. It'd be great if we could get a dev back here :) -- You are

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #28 from Dave Airlie --- can you try the patch on master? https://patchwork.freedesktop.org/series/27906/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [Mesa-dev RESEND 26/26] mesa: add KHR_no_error support to glPolygonMode()

2017-08-01 Thread Timothy Arceri
\o/ 9-26: Reviewed-by: Timothy Arceri Thanks for doing all this :) Please try to knock off a few more piglit tests here and there when time permits, it would be a shame if dev's tried to start turning this stuff on only to run into strange errors.

[Mesa-dev] [PATCH] i965: Delete pitch alignment assertion in get_blit_intratile_offset_el.

2017-08-01 Thread Kenneth Graunke
The cacheline alignment restriction is on the base address; the pitch can be anything. Fixes assertion failures when using primus (say, on glxgears, which creates a 300x300 linear BGRX surface with a pitch of 1200): intel_blit.c:190: get_blit_intratile_offset_el: Assertion `mt->surf.row_pitch %

[Mesa-dev] [PATCH 2/2] spirv: Fix SpvImageFormatR16ui

2017-08-01 Thread Jason Ekstrand
Cc: "17.1 17.2" --- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 4b9c121..7b34dad 100644 ---

[Mesa-dev] [PATCH 1/2] anv: Advertise support for two more sRGB formats

2017-08-01 Thread Jason Ekstrand
Unreal Engine 4 seems to really like VK_FORMAT_R8_SRGB for some reason. We don't technically have the hardware format but we do have L8_SRGB. It's easy enough to fake with that and a swizzle. While we're at it, we may as well support R8G8_SRGB using L8A8_SRGB. --- src/intel/vulkan/anv_formats.c

[Mesa-dev] [PATCH] vulkan/wsi: handle UINT64_MAX timeout correctly.

2017-08-01 Thread Dave Airlie
From: Dave Airlie The spec says "If timeout is UINT64_MAX, the function will not return until an image is acquired from the presentation engine." Now I know UINT64_MAX is probably heat death of the universe, but this changes the code to avoid calculating things in that case

[Mesa-dev] [Bug 102010] libvulkan_radeon crashes if loaded on Intel hardware

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102010 --- Comment #1 from Thiago Macieira --- Also submitted at libvulkan itself: https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1978 I don't know what is at fault: whether it's libvulkan for loading the

Re: [Mesa-dev] [PATCH] glsl: look up for transform feedback varyings after linking

2017-08-01 Thread Timothy Arceri
On 06/07/17 19:12, Juan A. Suarez Romero wrote: Check if shaders have transform feedback varyings also after the post-link step. This fixes: KHR-GL45.enhanced_layouts.xfb_vertex_streams piglit/spec/arb_enhanced_layouts/gs-stream-location-aliasing --- src/compiler/glsl/glsl_to_nir.cpp | 3 +++

[Mesa-dev] [PATCH] build: Don't bail on OSError in git_sha1_gen.py

2017-08-01 Thread Tobias Klausmann
When building sandboxed, we may encounter additional errors. Ignore the errors, as we are in a constrained environment. This can be observed when building latest git with OBS. Signed-off-by: Tobias Klausmann --- bin/git_sha1_gen.py | 3 +++ 1 file changed,

Re: [Mesa-dev] [PATCH 13/13] radeonsi: enable ARB_transform_feedback_overflow_query

2017-08-01 Thread Marek Olšák
I commented on patches 9 and 11. Other than that, the series is: Reviewed-by: Marek Olšák Marek On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > docs/features.txt |

Re: [Mesa-dev] [PATCH] ac/nir: Add float cast before shadow comparator clamp.

2017-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 1, 2017 at 12:27 PM, Bas Nieuwenhuizen wrote: > LLVM complained about passing an i32 to a float clamp. > > Signed-off-by: Bas Nieuwenhuizen > Fixes: 0f9e32519bb "ac/nir: clamp shadow

Re: [Mesa-dev] [PATCH] glsl: look up for transform feedback varyings after linking

2017-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 6, 2017 at 11:12 AM, Juan A. Suarez Romero wrote: > Check if shaders have transform feedback varyings also after the > post-link step. > > This fixes: > KHR-GL45.enhanced_layouts.xfb_vertex_streams >

Re: [Mesa-dev] [PATCH 1/5] anv: Make some bits of anv_extensions module-private

2017-08-01 Thread Lionel Landwerlin
Patches 1, 3, 4 & 5 are: Reviewed-by: Lionel Landwerlin On 01/08/17 19:54, Jason Ekstrand wrote: This way we can use "from anv_extensions import *" in the entrypoint generator without worrying too much about pollution ---

Re: [Mesa-dev] [PATCH] radeon/ac: use ds_swizzle for derivs on si/cik.

2017-08-01 Thread Marek Olšák
Tested on SI. Acked-by: Marek Olšák Marek On Tue, Aug 1, 2017 at 6:14 AM, Dave Airlie wrote: > From: Dave Airlie > > This looks like it's supported since llvm 3.9 at least, > so switch over radeonsi and radv to using it, -pro also >

[Mesa-dev] [RFC] intel: Common MOCS metadata straw-man

2017-08-01 Thread Jason Ekstrand
This is more of a straw-man patch than something I intend to land today. The idea is to come up with some central way of representing MOCS that we can use from either GL or Vulkan. I have no idea if this is how we want to represent MOCS or not. There are many alternative approaches: 1) Having

Re: [Mesa-dev] [PATCH 2/2] anv: Advertise VK_KHR_relaxed_block_layout

2017-08-01 Thread Lionel Landwerlin
Since this is available from 1.0.57, do we need to bump the supported API version first? On 01/08/17 17:02, Jason Ekstrand wrote: There is literally no work for us to do here. It already just works in our driver. --- src/intel/vulkan/anv_device.c | 4 1 file changed, 4 insertions(+)

[Mesa-dev] [PATCH 4/5] st/dri: add drisw image extension

2017-08-01 Thread Gurchetan Singh
Since the revelant functions have been moved to dri_helpers, drisw.c can make use of the extension. Note we have version 6 of the extension, since we want to support createImageFromTexture. v2: Rebase to master --- src/gallium/state_trackers/dri/drisw.c | 11 +++ 1 file changed, 11

Re: [Mesa-dev] [PATCH 2/5] anv: Add MAX_API_VERSION to anv_extensions.py

2017-08-01 Thread Lionel Landwerlin
On 01/08/17 19:54, Jason Ekstrand wrote: The VkVersion class is probably overkill but it makes it really easy to compare versions in a way that's safe without the caller having to think about patch vs. no patch. --- src/intel/vulkan/anv_entrypoints_gen.py | 4 +--

Re: [Mesa-dev] [PATCH v2 5/6] radeonsi: use slot indexes for bindless handles

2017-08-01 Thread Marek Olšák
There is an issue independent of this patch: si_update_all_resident_texture_descriptors only updates resident descriptors. Non-resident descriptors aren't updated, and si_make_texture_handle_resident doesn't update them either. I think it should be fixed in si_make_texture_handle_resident. Same

Re: [Mesa-dev] [PATCH v2 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

2017-08-01 Thread Marek Olšák
Hi Samuel, Can you move this slot allocator into a util module? It seems generic enough that it could be reused for "handle" and "ID" allocations. Some additional notes: - a bit array of uin32_t would be better. bool is too large (1 byte). - "free" is the inverse of "used", so the "used" array

[Mesa-dev] [Bug 97852] Unreal Engine corrupted preview viewport

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97852 --- Comment #10 from Markus --- Any news on this? -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH v2 17/17] swr/rast: fix core / knights split of AVX512 intrinsics

2017-08-01 Thread Tim Rowley
Move AVX512BW specific intrinics to be Core-only. Move some AVX512F intrinsics back to common implementation file. --- .../drivers/swr/rasterizer/common/simdlib.hpp | 2 + .../swr/rasterizer/common/simdlib_512_avx512.inl | 53 +

[Mesa-dev] [PATCH v2 15/17] swr/rast: split gen_knobs templates into .h/.cpp

2017-08-01 Thread Tim Rowley
Switch to a 1:1 mapping template:generated for future maintenance. --- src/gallium/drivers/swr/Makefile.am| 3 +- src/gallium/drivers/swr/SConscript | 2 +- .../drivers/swr/rasterizer/codegen/gen_knobs.py| 14 +-

[Mesa-dev] [PATCH v2 14/17] swr/rast: gen_knobs template code style

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp b/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp index

[Mesa-dev] [PATCH v2 16/17] swr/rast: simplify knob default value setup

2017-08-01 Thread Tim Rowley
--- .../drivers/swr/rasterizer/codegen/templates/gen_knobs.h| 13 - src/gallium/drivers/swr/rasterizer/core/knobs_init.h| 12 +++- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.h

Re: [Mesa-dev] [PATCH] swr: Add arch flags to support Cray and PGI compilers

2017-08-01 Thread Rowley, Timothy O
On Jul 31, 2017, at 3:51 PM, Chuck Atkins > wrote: Hi Tim, If the Cray flags are for wrapper scripts, why do we need specific flags for that instead of using the underlying compiler flags? Sort answer: It's the "Cray" way of doing

Re: [Mesa-dev] [PATCH 11/13] radeonsi: fix streamout overflow predication on VI+

2017-08-01 Thread Marek Olšák
On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > There is a firmware regression that causes failures. Work around it by > using the compute shader for query_buffer_objects to summarize the query > results. > --- >

[Mesa-dev] [Bug 102003] Mesa demos doesn't compile due to gles1

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102003 Mike Lothian changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH 5/5] egl/dri2: add image extension such it's usable by swrast driver

2017-08-01 Thread Gurchetan Singh
Otherwise, this extension is not visible to the EGL users who use the swrast driver. This will allow the swrast driver to use eglCreateImageKHR, provided the target is EGL_GL_TEXTURE_2D_KHR or EGL_GL_RENDERBUFFER_KHR. Note we still have to implement the create from render buffer path. v2: add

Re: [Mesa-dev] [PATCH 2/5] anv: Add MAX_API_VERSION to anv_extensions.py

2017-08-01 Thread Jason Ekstrand
On Tue, Aug 1, 2017 at 2:07 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 01/08/17 19:54, Jason Ekstrand wrote: > >> The VkVersion class is probably overkill but it makes it really easy to >> compare versions in a way that's safe without the caller having to think >> about

Re: [Mesa-dev] [PATCH 2/2] anv: Advertise VK_KHR_relaxed_block_layout

2017-08-01 Thread Jason Ekstrand
On Tue, Aug 1, 2017 at 2:03 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Since this is available from 1.0.57, do we need to bump the supported API > version first? > I don't think it really matters > On 01/08/17 17:02, Jason Ekstrand wrote: > >> There is literally no work

[Mesa-dev] [PATCH v2 07/17] swr/rast: fix movemask_ps / movemask_pd on AVX512

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl index

[Mesa-dev] [PATCH v2 10/17] swr/rast: SIMD16 shaders - widen fetch and vertex shaders

2017-08-01 Thread Tim Rowley
Work in progress, disabled by default. --- .../drivers/swr/rasterizer/core/frontend.cpp | 33 src/gallium/drivers/swr/rasterizer/core/knobs.h| 1 + src/gallium/drivers/swr/rasterizer/core/state.h| 10 ++ .../drivers/swr/rasterizer/jitter/JitManager.cpp | 16 ++

[Mesa-dev] [PATCH v2 12/17] swr/rast: fix scons gen_knobs.h dependency

2017-08-01 Thread Tim Rowley
Copy/paste error was duplicating a gen_knobs.cpp rule. --- src/gallium/drivers/swr/SConscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/SConscript b/src/gallium/drivers/swr/SConscript index a32807d..c578d7a 100644 ---

[Mesa-dev] [PATCH v2 09/17] swr/rast: vmask() implementations for KNL

2017-08-01 Thread Tim Rowley
--- .../swr/rasterizer/common/simdlib_512_avx512_knights.inl | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512_knights.inl b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512_knights.inl index

[Mesa-dev] [PATCH v2 03/17] swr/rast: fix USE_SIMD16_FRONTEND issues

2017-08-01 Thread Tim Rowley
Fix problems found when enabling USE_SIMD16_FRONTEND, mostly related to vMask / movemask_ps(pd). --- .../drivers/swr/rasterizer/common/simd16intrin.h| 14 ++ .../drivers/swr/rasterizer/common/simdintrin.h | 21 +

[Mesa-dev] [PATCH v2 02/17] swr/rast: simdlib better seperation of core vs. knights avx512

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/Makefile.am| 2 +- src/gallium/drivers/swr/Makefile.sources | 8 + .../drivers/swr/rasterizer/common/simdlib.hpp | 21 ++- .../swr/rasterizer/common/simdlib_128_avx512.inl | 108 +++-

[Mesa-dev] [PATCH v2 08/17] swr/rast: rename frontend pVertexStore

2017-08-01 Thread Tim Rowley
Rename to reflect global nature. --- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index

[Mesa-dev] [PATCH v2 06/17] swr/rast: stop using MSFT types in platform independent code

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 6 -- src/gallium/drivers/swr/rasterizer/core/api.cpp| 2 +- src/gallium/drivers/swr/rasterizer/core/api.h | 4 ++-- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 4 ++--

[Mesa-dev] [PATCH v2 13/17] swr/rast: switch gen_knobs.cpp license

2017-08-01 Thread Tim Rowley
Unintentionally added with an apache2 license; relicense to match the rest of the tree. --- .../swr/rasterizer/codegen/templates/gen_knobs.cpp | 29 +- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git

[Mesa-dev] [PATCH v2 01/17] swr/rast: threadID via portable std::this_thread::get_id()

2017-08-01 Thread Tim Rowley
Replace use of Win32 GetCurrentThreadId() with portable std::this_thread::get_id(). --- .../codegen/templates/gen_ar_eventhandlerfile.hpp| 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH v2 04/17] swr/rast: disable AVX512 optimization of SSE / AVX code

2017-08-01 Thread Tim Rowley
Disable an optimization which implemented sse/avx operations on avx512 using avx512 intrinsics (to avoid switching between lane widths). Compile with SIMD_OPT_128_AVX512 / SIMD_OPT_256_AVX512 defined to enable these optimizations. --- src/gallium/drivers/swr/rasterizer/common/simdlib.hpp | 4

[Mesa-dev] [PATCH v2 00/17] swr: update rasterizer

2017-08-01 Thread Tim Rowley
Highlights include enabling the simd16 frontend and code cleanups. v2: split previous gen_knobs patch into five chunks: scons fix, relicense to match rest of tree, code style, template split, simplification of default value setup Tim Rowley (17): swr/rast: threadID via portable

[Mesa-dev] [PATCH v2 05/17] swr/rast: enable USE_SIMD16_FRONTEND by default

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/knobs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/knobs.h b/src/gallium/drivers/swr/rasterizer/core/knobs.h index 7ad6fe3..10bd4a5 100644 ---

Re: [Mesa-dev] [PATCH 09/13] gallium/radeon: implement basic parts of PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE

2017-08-01 Thread Marek Olšák
Hi Nicolai, Can you add R600_MAX_STREAM = 4 to make the code more readable? Thanks, Marek On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeon/r600_query.c | 96 >

Re: [Mesa-dev] [PATCH 6/6] egl/x11: use dri2_create_image_khr for swrast

2017-08-01 Thread Gurchetan Singh
Thanks for the reviews! I rebased patch number #4, and added platform_wayland support and squashed this patch to form patch #5. Note it seems platform_drm already has the correct path for swrast, since gbm_dri_screen_extensions already has the lookup extension and the dri2_drm_display_vtbl is

  1   2   >